D17122: RFC: Use wl_display_add_socket_auto by default

[Fabian Vogt]

fvogt added a comment.


  In D17122#395537 , @romangg wrote:
  
  > I don't think we need  a second variable effectiveSocketName. Just test if 
socketName is empty. If it is call wl_display_add_socket_auto, otherwise call 
wl_display_add_socket.
  
  
  If `socketName` is overwritten after using wl_display_add_socket_auto, it's 
not possible to call `start` twice without resetting `socketName` again.
  
  > According to description some autotest fails. Which one exactly?
  
  testSocketName as the default value of socketName changed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

[Albert Astals Cid]

aacid added subscribers: skelly, cgiboudeaux.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18345

To: aacid
Cc: cgiboudeaux, skelly, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18137: delete copy constructor and assignment operator of some public classes

[Albert Astals Cid]

aacid added a comment.


  The magic to generate sip files was not magic enough
  
  https://phabricator.kde.org/D18345

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D18137

To: aacid, mpyne
Cc: cgiboudeaux, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

D18345: Fix python binding generation for classes with deleted copy constructors

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
aacid requested review of this revision.

TEST PLAN
  kcoreaddons compiles again

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18345

AFFECTED FILES
  find-modules/sip_generator.py

To: aacid
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17122: RFC: Use wl_display_add_socket_auto by default

[Roman Gilg]

romangg added a comment.


  I don't think we need  a second variable effectiveSocketName. Just test if 
socketName is empty. If it is call wl_display_add_socket_auto, otherwise call 
wl_display_add_socket.
  
  According to description some autotest fails. Which one exactly?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17122

To: fvogt, #kwin, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[Pino Toscano]

pino added a comment.


  In D18317#395513 , @pino wrote:
  
  > This makes a "core" library grow a dependency on widgets -- not really a 
good idea, considering there is the sonnetui library for that.
  
  
  In addition to the above, there are also really bad consquences: take a 
console-only application running QCoreApplication as application class and 
using sonnetcore. Now, in case of the situation described, sonnetcore will try 
spawn a QMessageBox, which IIRC exits the application, as no GUI is available.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[Pino Toscano]

pino added a comment.


  This makes a "core" library grow a dependency on widgets -- not really a good 
idea, considering there is the sonnetui library for that.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[Nathaniel Graham]

ngraham added a reviewer: loh.tar.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17459: SearchBar: Add Cancel button to stop long running tasks

[loh tar]

loh.tar updated this revision to Diff 49754.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Fix to pass autotest
  
  97% tests passed, 2 tests failed out of 67
  
  Total Test time (real) = 137.70 sec
  
  The following tests FAILED:
  
24 - kateindenttest_testCppstyle (Failed)
66 - vimode_keys (Failed)
  
  Errors while running CTest

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17459?vs=48391=49754

REVISION DETAIL
  https://phabricator.kde.org/D17459

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/search/searchbarpower.ui

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: dhaumann, anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars

D18010: Fix failing test of exiv gps data

[Alexander Stippich]

astippich retitled this revision from "Allow zero altitude/longitude/latitude 
exiv gps data" to "Fix failing test of exiv gps data".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_zero_gps

REVISION DETAIL
  https://phabricator.kde.org/D18010

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18010: Allow zero altitude/longitude/latitude exiv gps data

[Alexander Stippich]

astippich updated this revision to Diff 49750.
astippich added a comment.


  - fix gps altitude precision

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18010?vs=49317=49750

BRANCH
  fix_zero_gps

REVISION DETAIL
  https://phabricator.kde.org/D18010

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18205: Test empty and zero gps data

[Alexander Stippich]

astippich updated this revision to Diff 49749.
astippich added a comment.


  - update

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18205?vs=49377=49749

BRANCH
  gps_tests

REVISION DETAIL
  https://phabricator.kde.org/D18205

AFFECTED FILES
  autotests/exiv2extractortest.cpp
  autotests/exiv2extractortest.h
  autotests/samplefiles/test_no_gps.jpg
  autotests/samplefiles/test_zero_gps.jpg

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18329: Remove the AndroidX support library dependency

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Turns out we don't actually need that, the version checks in the Java code
  accomplish the same. More importantly, it doesn't support custom icon
  graphics, a feature we need to supply icons from the C++ side rather than
  from an Android resource.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18329

AFFECTED FILES
  src/android/build.gradle

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Oswald Buddenhagen]

ossi added a comment.


  the 3rd line is still wrong ...

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D18308: Ignore all non-storage deviceAdded signals from Solid

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R293:c0b57ee70ea2: Ignore all non-storage deviceAdded signals 
from Solid (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18308?vs=49686=49724#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18308?vs=49686=49724

REVISION DETAIL
  https://phabricator.kde.org/D18308

AFFECTED FILES
  src/file/storagedevices.cpp

To: bruns, #baloo, #frameworks, ngraham, broulik
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D11236: [KCrash] Establish socket to allow change of ptracer

[Oswald Buddenhagen]

ossi added a comment.


  right, threads, i didn't think of that. i suppose it might make sense to 
pthread_kill() from within kcrash to freeze the other threads, but that will be 
non-atomic, and i wonder whether it wouldn't have undesirable interactions with 
the attached debugger and/or exiting the process.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D18308: Ignore all non-storage deviceAdded signals from Solid

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> broulik wrote in storagedevices.cpp:79
> I think you can also move this check up

yes, especially as it is the most trivial check ...

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18308

To: bruns, #baloo, #frameworks, ngraham, broulik
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18137: delete copy constructor and assignment operator of some public classes

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  This is causing an error when building the python bindings:
  
  > In file included from 
/data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/unifiedKCoreAddons.cpp:15:
  >  
/data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKdelibs4Migration.cpp:134:65:
 error: overload resolution selected deleted operator '='
  > 
  >   reinterpret_cast< ::Kdelibs4Migration *>(sipDst)[sipDstIdx] = 
*reinterpret_cast< ::Kdelibs4Migration *>(sipSrc);
  >   ~~~ ^ 
~
  > 
  > /data/kde/src/kcoreaddons/src/lib/util/kdelibs4migration.h:85:24: note: 
candidate function has been explicitly deleted
  > 
  >   Kdelibs4Migration =(const Kdelibs4Migration &) = delete;
  >  ^
  > 
  > In file included from 
/data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/unifiedKCoreAddons.cpp:15:
  >  
/data/kde/build/kcoreaddons/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKdelibs4Migration.cpp:148:17:
 error: call to deleted constructor of '::Kdelibs4Migration'
  > 
  >   return new  ::Kdelibs4Migration(reinterpret_cast(sipSrc)[sipSrcIdx]);
  >   ^   
~

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D18137

To: aacid, mpyne
Cc: cgiboudeaux, mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick edited the summary of this revision.
croick edited the test plan for this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick edited the summary of this revision.
croick edited the test plan for this revision.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 49717.
croick added a comment.


  - swap variable declaration

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49710=49717

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick marked an inline comment as done.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick added a comment.


  I think it's quite useful (see BUG 175362). Remaining threads remain quite 
busy otherwise, especially since KCrash is closing all file descriptors by 
default, which leads to a lot of polling of non-existant FDs in the background.
  Maybe you would like to join the discussion in D18245 
 about this ;)

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Oswald Buddenhagen]

ossi added inline comments.

INLINE COMMENTS

> kcrash.cpp:658
> +// when launching drkonqi. Note that DrKonqi will SIGSTOP this 
> process in the meantime
> +// and only send SIGCONT when it is about to attach a debugger.
>  #ifdef Q_OS_LINUX

ok. but come to think of it, maybe that should be revised - that SIGSTOPping 
sounds a tad paranoid to start with. feel like researching the history of that?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick marked an inline comment as done.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Oswald Buddenhagen]

ossi added a comment.


  In D11235#395021 , @croick wrote:
  
  > What do you mean? The (internal) debugger is a child of the debuggee.
  
  
  yes, that's why you need setPtracer() - if crashtest was *under* gdb, that 
would be unnecessary. ;)
  (i'm still referring to the enumeration of cases, if that wasn't clear.)

INLINE COMMENTS

> ptracer.cpp:63
> +
> +int bytes = 0, r;
> +while (bytes < msize) {

i meant this line ...
(but your change was good, too).

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18317: Don't fail if defaultLanguage dictionary can't be loaded

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: sandsmark.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  If the files of the the dictionary set in defaultLanguage= can't be
  loaded, instead of failing silently, try to load the locale language
  dictionary, and display a message informing the user of what's been done.
  
  BUG: 325541
  FIXED-IN: 5.55.0

TEST PLAN
  - Edit ~/.config/KDE/Sonnet.conf (or wherever your distro puts the conf file 
under the home dir, and set defaultLanguage= to something invalid/unavailable, 
say en_AB
  - Start e.g. kate and try to spell check something; note that doesn't work 
and this error log is spewed to the terminal: "sonnet.core: No language 
dictionaries for the language: "de_AT_ost""
  - Apply the diff and try again

REPOSITORY
  R246 Sonnet

BRANCH
  invalid-defaultLanguage

REVISION DETAIL
  https://phabricator.kde.org/D18317

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/loader.cpp
  src/core/sonnet-core.pro

To: ahmadsamir, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise added a comment.


  I'm not sure why the tests fail, and the tests failing are unrelated to 
xattrs. I think there is some problem in queuing the subjobs and ensuring they 
all have finished.
  After the copy job is finished, the copyLocalDirectory test can't find the 
file inside the copied test directory. Manually testing recursive copy I can't 
find problems, but the autotest fail. So, I think some parts of the copy job 
are executed after the copyjob finishes if I add a subjob.
  As I said, we can use start, instead of exec, to be asynchronous, but using a 
subjob seems to need some refactor, maybe adding a new state for the xattr 
subjob.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise marked an inline comment as done.
cochise added a comment.


  I'm not sure why the tests fail, and the tests failing are unrelated to 
xattrs. I think there is some problem in queuing the subjobs and ensuring they 
all have finished.
  After the copy job is finished, the `copyLocalDirectory` test can't find the 
file inside the copied test directory. Manually testing recursive copy I can't 
find problems, but the autotest fail. So, I think some parts of the copy job 
are executed after the copyjob finishes if I add a subjob. 
  As I said, we can use start, instead of exec, to be asynchronous, but using a 
subjob seems to need some refactor, maybe adding a new state for the xattr 
subjob.

INLINE COMMENTS

> cfeck wrote in copyjob.cpp:1119
> Here, too.

I tried various ways to call this as a subjob, but all of them leads to 
breakage of non xattr related tests. Maybe some major changes to the class are 
needed.

But the call can be asynchronous with little effort. All tests still pass if 
`start()` is called, instead of `exec()`.

> bruns wrote in copyjob.cpp:2199
> you can (typically) avoid the double (syscall, i.e. expensive) by 
> preallocating the array and only reallocating if you get `errno == ERANGE`. 
> Dito for getxattr.

In theory, xattrs have unlimited size on some filesystems. Ext limits it to a 
fs block (4 Kb on most end user setups). Allocating full 4 kb is a overkill, as 
most of xattr ae small.

But as most of files don't have xattr, and the function will return here, we 
have to pay the cost of the second call only if we will use it. If we 
preallocate memory, we have to pay a cost for every file.

> bruns wrote in copyjob.cpp:2221
> `... always ...`

On Linux, at least. Each item gets a `\0` terminator and the list itself too. 
Not tested on other systems.

> bruns wrote in copyjob.cpp:2225
> There should probably be a `if (!xattrkey.startsWith("user.")) continue;` 
> here.

Doing some research and test...

> Currently, the security, system, trusted, and user extended attribute classes 
> are defined as described below.  Additional classes may be added in the 
> future.

If a copy a file with kioclient as user, any attribute outside `user.` is lost 
and I get a warning for the ones I'm unable to preserve, but if I copy as root, 
all are preserved.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, 
ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, michaelh

D18315: Device: Check object path in interfaces removed slot

[David Rosca]

drosca created this revision.
drosca added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
drosca requested review of this revision.

REVISION SUMMARY
  Only remove Input and MediaPlayer objects when path matches.
  
  BUG: 403289

TEST PLAN
  Added autotest pass

REPOSITORY
  R269 BluezQt

BRANCH
  bug403289

REVISION DETAIL
  https://phabricator.kde.org/D18315

AFFECTED FILES
  autotests/fakebluez/deviceinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/object.h
  autotests/mediaplayertest.cpp
  autotests/mediaplayertest.h
  src/device_p.cpp
  src/input.cpp
  src/input_p.h
  src/mediaplayer_p.cpp
  src/mediaplayer_p.h

To: drosca, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick updated this revision to Diff 49711.
croick marked an inline comment as done.
croick added a comment.


  - invert debugger-debuggee hierarchy in comment

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11236?vs=49650=49711

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

AFFECTED FILES
  src/kcrash.cpp

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 17 Jan 2019 12:04:59 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick added a comment.


  > you got the parent-child ordering wrong in the commit message. ^^
  
  What do you mean? The (internal) debugger is a child of the debuggee.
  
$ pstree -pn $(pidof crashtest)
crashtest(17220)─┬─{crashtest}(17221)
 ├─{crashtest}(17222)
 └─drkonqi(17223)─┬─{drkonqi}(17224)
  ├─{drkonqi}(17225)
  ├─{drkonqi}(17231)
  └─gdb(17293)─┬─{gdb}(17294)
   ├─{gdb}(17295)
   └─{gdb}(17296)

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 49710.
croick added a comment.


  - swap lines, declare array for response message where needed

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49705=49710

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11236: [KCrash] Establish socket to allow change of ptracer

[Oswald Buddenhagen]

ossi added a comment.


  commit message inverted here as well.

INLINE COMMENTS

> kcrash.cpp:658
> +// when launching drkonqi. Note that DrKonqi will SIGSTOP this 
> process in the meantime
> +// and only send SIGCONT when it is to be attached by a debugger.
>  #ifdef Q_OS_LINUX

"when it is about to attach a debugger".

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D18164: Review KateGotoBar

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3b806f3b40f7: Review KateGotoBar (authored by loh.tar, 
committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18164?vs=49665=49708

REVISION DETAIL
  https://phabricator.kde.org/D18164

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Oswald Buddenhagen]

ossi added a comment.


  you got the parent-child ordering wrong in the commit message. ^^

INLINE COMMENTS

> ptracer.cpp:61
> +char msg[msize], rmsg[msize];
> +int bytes = 0, r;
> +sprintf(msg, "%lld", debuggerpid);

this looks stupid, i'd swap the order.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D11235

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18164: Review KateGotoBar

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Yep ;=)
  
  Thanks for the improvements, will merge.

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D11236: [KCrash] Establish socket to allow change of ptracer

[Christoph Roick]

croick edited the summary of this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D11235: [DrKonqi] Request change of ptrace scope from KCrash

[Christoph Roick]

croick updated this revision to Diff 49705.
croick edited the summary of this revision.
croick added a comment.


  - adjust warning and check for EINTR when polling

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11235?vs=49651=49705

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11235

AFFECTED FILES
  src/CMakeLists.txt
  src/debuggerlaunchers.cpp
  src/debuggerlaunchers.h
  src/ptracer.cpp
  src/ptracer.h
  src/tests/crashtest/crashtest.cpp

To: croick, #plasma_workspaces, #frameworks, ossi
Cc: ossi, lepagevalleeemmanuel, maximilianocuria, adridg, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18308: Ignore all non-storage deviceAdded signals from Solid

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> storagedevices.cpp:79
>  Entry entry(dev);
>  if (dev.udi().isEmpty())
>  return nullptr;

I think you can also move this check up

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18308

To: bruns, #baloo, #frameworks, ngraham, broulik
Cc: broulik, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams