KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/14/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 29 Jan 2019 04:33:13 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Jan 2019 04:33:14 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 29 Jan 2019 04:32:56 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 29 Jan 2019 04:33:14 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Jan 2019 04:32:56 +
 Build duration:
8 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33058/48369)51%
(15906/31074)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4461/4756)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1873/3151)47%
(1566/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 29 Jan 2019 04:32:26 +
 Build duration:
7 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18516: Fix end of folding region in rules with lookAhead=true

[Dominik Haumann]

dhaumann added a comment.


  Ok I see: this kind of reverts Christophs changes in the lookahead case.
  
  What I wonder is whether we need a // TODO KF6: add a bool lookAhead in 
applyFolding() such that we know whether a folding end region should end at 0 
or at length.
  
  @cullmann Your take on this? I think it's an improvement, but a comment could 
be added that states why this differentiation is done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18516

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/6/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 29 Jan 2019 02:08:25 +
 Build duration:
8 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Jan 2019 02:08:25 +
 Build duration:
3 min 58 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 29 Jan 2019 02:08:25 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D17737: [CopyJob] Create clones in btrf/xfs mount

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @bruns  ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17737

To: chinmoyr, dfaure, davidedmundson
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 23:55:34 +
 Build duration:
5 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45963)38%
(13050/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5545/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 23:55:34 +
 Build duration:
3 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45963)38%
(13050/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5545/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 28 Jan 2019 23:55:34 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D18475: Add AsciiDoc support

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:de5fc35624d2: Add AsciiDoc support (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18475?vs=50391=50453#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18475?vs=50391=50453

REVISION DETAIL
  https://phabricator.kde.org/D18475

AFFECTED FILES
  autotests/folding/asciidoc.adoc.fold
  autotests/html/asciidoc.adoc.html
  autotests/input/asciidoc.adoc
  autotests/reference/asciidoc.adoc.ref
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D18475: Add AsciiDoc support

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  1. I apply your patch: arc patch D18475 
  2. Since there is a new syntax highlighting file, I do: touch 
data/syntax-data.qrc.in
  3. I switch to the build directory, type make -j4 install
  4. I run the tests, some fail, since the reference of your test file is 
missing
  5. In the build folder, I run: ./autotests/update-reference-data.sh
  6. Now git status tells me there are several untracked files:
- autotests/folding/asciidoc.adoc.fold
- autotests/html/asciidoc.adoc.html
- autotests/reference/asciidoc.adoc.ref
  7. In the source folder, I git add all these files, then commit
  8. Finally, I call: arc diff to land your patch

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb updated this revision to Diff 50451.
rjvbb added a comment.


  This follows David's suggestion, but using `QUERY_IF` instead of the 
suggested `TRY_IF` to make it clear that this parameter controls the querying 
of the compiler.
  I haven't yet tested the new logic exhaustively but the as far as I can tell 
the macro behaves as intended as used in the two compiler settings modules.
  
  I've simplified the `QUERY_IF` conditions in those modules to just "if 
APPLE". Querying systematically on APPLE seems reasonable because the 
likelihood that a non-clang compiler is used for building is very small and 
when  it happens we'd probably be dealing with a non-GNU compiler.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16894?vs=50399=50451

REVISION DETAIL
  https://phabricator.kde.org/D16894

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake
  kde-modules/KDEFrameworkCompilerSettings.cmake
  modules/ECMAddCompilerFlag.cmake

To: rjvbb, #build_system, kfunk
Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb set the repository for this revision to R240 Extra CMake Modules.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 28 Jan 2019 19:12:47 +
 Build duration:
1 hr 36 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 12 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 20:29:13 +
 Build duration:
3 min 38 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)84%
(16/19)84%
(16/19)45%
(1677/3716)36%
(762/2105)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)68%
(255/377)49%
(71/144)src.imageformats92%
(12/13)92%
(12/13)44%
(1418/3207)36%
(689/1903)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/27/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 28 Jan 2019 20:29:13 +
 Build duration:
2 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/14/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 20:29:13 +
 Build duration:
1 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)84%
(16/19)84%
(16/19)45%
(1677/3716)36%
(762/2105)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)68%
(255/377)49%
(71/144)src.imageformats92%
(12/13)92%
(12/13)44%
(1418/3207)36%
(689/1903)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/11/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 20:15:47 +
 Build duration:
4 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(15/19)79%
(15/19)42%
(1541/3712)33%
(691/2105)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats85%
(11/13)85%
(11/13)40%
(1274/3205)32%
(617/1903)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/13/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 20:15:47 +
 Build duration:
1 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(15/19)79%
(15/19)42%
(1541/3712)33%
(691/2105)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats85%
(11/13)85%
(11/13)40%
(1274/3205)32%
(617/1903)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/10/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 19:32:02 +
 Build duration:
4 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(15/19)79%
(15/19)42%
(1540/3710)33%
(690/2103)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats85%
(11/13)85%
(11/13)40%
(1273/3203)32%
(616/1901)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/12/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 19:32:02 +
 Build duration:
1 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)79%
(15/19)79%
(15/19)42%
(1540/3710)33%
(690/2103)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats85%
(11/13)85%
(11/13)40%
(1273/3203)32%
(616/1901)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/11/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 19:12:47 +
 Build duration:
1 min 25 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1500/3632)33%
(670/2043)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1233/3125)32%
(596/1841)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/9/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 19:12:47 +
 Build duration:
1 min 22 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1500/3632)33%
(670/2043)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1233/3125)32%
(596/1841)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/8/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 18:18:32 +
 Build duration:
3 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1499/3630)33%
(669/2041)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1232/3123)32%
(595/1839)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 23 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/23/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 28 Jan 2019 18:18:32 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 18:18:32 +
 Build duration:
1 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1499/3630)33%
(669/2041)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1232/3123)32%
(595/1839)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 28 Jan 2019 18:18:32 +
 Build duration:
46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga

D18582: Add explicit SurfaceInterface::commited signal

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> surface_interface.h:347
> + * @since 5.54
> + */
> +void committed();

**/

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18582

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18582: Add explicit SurfaceInterface::commited signal

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Whilst some interfaces that are double-buffered against the wl_surface
  are proxied through SurfaceInterface, some are not, most notably
  XdgShell.
  
  We need some low level signal to know when the surface has been
  committed which doesn't rely on their being a damaged buffer.

TEST PLAN
  Unit test 
  Used in kwin

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18582

AFFECTED FILES
  autotests/client/test_wayland_surface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 28 Jan 2019 13:21:51 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 13:21:51 +
 Build duration:
3 min 53 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1499/3630)33%
(669/2041)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1232/3123)32%
(595/1839)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/9/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 13:21:51 +
 Build duration:
1 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1499/3630)33%
(669/2041)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)39%
(1232/3123)32%
(595/1839)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.11 - Build # 22 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.11/22/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 28 Jan 2019 13:21:50 +
 Build duration:
1 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 324 lines...]Scanning dependencies of target kimg_rgbScanning dependencies of target writetestScanning dependencies of target imageconverterScanning dependencies of target kimg_psdScanning dependencies of target kimg_rasScanning dependencies of target kimg_picScanning dependencies of target readtestScanning dependencies of target imagedumpScanning dependencies of target kimg_xcf[ 29%] Building CXX object src/imageformats/CMakeFiles/kimg_tga.dir/tga.cpp.obj[ 29%] Building CXX object src/imageformats/CMakeFiles/kimg_pcx.dir/pcx.cpp.obj[ 31%] Building CXX object src/imageformats/CMakeFiles/kimg_rgb.dir/rgb.cpp.obj[ 33%] Building CXX object autotests/CMakeFiles/writetest.dir/writetest.cpp.obj[ 35%] Building CXX object src/imageformats/CMakeFiles/kimg_ras.dir/ras.cpp.objpcx.cppScanning dependencies of target pictesttga.cppwritetest.cpprgb.cppras.cpp[ 37%] Building CXX object tests/CMakeFiles/imageconverter.dir/imageconverter.cpp.obj[ 43%] Building CXX object src/imageformats/CMakeFiles/kimg_xcf.dir/xcf.cpp.obj[ 43%] Building CXX object tests/CMakeFiles/imagedump.dir/imagedump.cpp.obj[ 45%] Building CXX object src/imageformats/CMakeFiles/kimg_pic.dir/pic.cpp.objxcf.cppimageconverter.cpp[ 50%] Building CXX object src/imageformats/CMakeFiles/kimg_psd.dir/psd.cpp.obj[ 50%] Building CXX object autotests/CMakeFiles/readtest.dir/readtest.cpp.objimagedump.cpppic.cpppsd.cppreadtest.cpp[ 52%] Building CXX object src/imageformats/CMakeFiles/kimg_pcx.dir/kimg_pcx_autogen/mocs_compilation.cpp.obj[ 54%] Building CXX object src/imageformats/CMakeFiles/kimg_tga.dir/kimg_tga_autogen/mocs_compilation.cpp.objC:\CI\workspace\Frameworks\kimageformats\kf5-qt5 WindowsMSVCQt5.11\src\imageformats\xcf.cpp(1126): error C3861: 'bzero': identifier not foundmocs_compilation.cpp[ 56%] Building CXX object autotests/CMakeFiles/writetest.dir/writetest_autogen/mocs_compilation.cpp.objmocs_compilation.cpp[ 58%] Building CXX object src/imageformats/CMakeFiles/kimg_rgb.dir/kimg_rgb_autogen/mocs_compilation.cpp.objjom: C:\CI\workspace\Frameworks\kimageformats\kf5-qt5 WindowsMSVCQt5.11\build\src\imageformats\CMakeFiles\kimg_xcf.dir\build.make [src\imageformats\CMakeFiles\kimg_xcf.dir\xcf.cpp.obj] Error 2jom: C:\CI\workspace\Frameworks\kimageformats\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [src\imageformats\CMakeFiles\kimg_xcf.dir\all] Error 2[ 43%] Building CXX object autotests/CMakeFiles/pictest.dir/pictest.cpp.objpictest.cppmocs_compilation.cppmocs_compilation.cpp[ 62%] Building CXX object tests/CMakeFiles/imageconverter.dir/imageconverter_autogen/mocs_compilation.cpp.obj[ 66%] Building CXX object src/imageformats/CMakeFiles/kimg_ras.dir/kimg_ras_autogen/mocs_compilation.cpp.obj[ 68%] Building CXX object tests/CMakeFiles/imagedump.dir/imagedump_autogen/mocs_compilation.cpp.obj[ 64%] Building CXX object src/imageformats/CMakeFiles/kimg_pic.dir/kimg_pic_autogen/mocs_compilation.cpp.obj[ 68%] Building CXX object autotests/CMakeFiles/pictest.dir/pictest_autogen/mocs_compilation.cpp.objmocs_compilation.cppmocs_compilation.cppmocs_compilation.cpp[ 70%] Building CXX object autotests/CMakeFiles/readtest.dir/readtest_autogen/mocs_compilation.cpp.obj[ 72%] Building CXX object src/imageformats/CMakeFiles/kimg_psd.dir/kimg_psd_autogen/mocs_compilation.cpp.obj[ 75%] Linking CXX executable ..\bin\writetest.exemocs_compilation.cppmocs_compilation.cppmocs_compilation.cppmocs_compilation.cpp[ 77%] Linking CXX executable ..\bin\pictest.exe[ 83%] Linking CXX executable ..\bin\readtest.exe[ 83%] Linking CXX executable ..\bin\imagedump.exe[ 83%] Linking CXX executable ..\bin\imageconverter.exe[ 85%] Linking CXX shared module ..\..\bin\imageformats\kimg_tga.dll[ 87%] Linking CXX shared module ..\..\bin\imageformats\kimg_pcx.dll[ 89%] Linking CXX shared module ..\..\bin\imageformats\kimg_rgb.dll[ 91%] Linking CXX shared module ..\..\bin\imageformats\kimg_pic.dll[ 95%] Linking CXX shared module ..\..\bin\imageformats\kimg_psd.dll[ 95%] Linking CXX shared module ..\..\bin\imageformats\kimg_ras.dll   Creating library ..\..\lib\kimg_pcx.lib and object ..\..\lib\kimg_pcx.exp   Creating library ..\..\lib\kimg_tga.lib and object ..\..\lib\kimg_tga.exp[ 95%] Built target writetest[ 95%] Built target imageconverter[ 95%] Built target pictest   Creating library ..\..\lib\kimg_rgb.lib and object ..\..\lib\kimg_rgb.exp[ 95%] Built target imagedump   Creating library ..\..\lib\kimg_pic.lib and object ..\..\lib\kimg_pic.exp[ 95%] Built target readtest   Creating library ..\..\lib\kimg_psd.lib and object ..\..\lib\kimg_psd.exp   Creating library ..\..\lib\kimg_ras.lib and object ..\..\lib\kimg_ras.exp   Creating library ..\..\lib\kimg_pcx.lib and object 

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R287:51d710adda14: Fix various OOB reads and writes in 
kimg_tga and kimg_xcf (authored by fvogt).

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18574?vs=50416=50427

REVISION DETAIL
  https://phabricator.kde.org/D18574

AFFECTED FILES
  src/imageformats/tga.cpp
  src/imageformats/xcf.cpp

To: fvogt, aacid
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18475: Add AsciiDoc support

[Andreas Gratzer]

andreasgr added a comment.


  In D18475#400238 , @nibags wrote:
  
  > Hi!!
  >  Please, also add a test file in: "autotests/input/". To generate the files 
in "folding", "html" and "reference" use `make test` and 
`autotests/update-reference-data.sh`.
  
  
  I tried to understand how the testing works, but I failed.
  
  `make test` complains about one test failed with latest master branch.
  It complains about more failed tests after I added the AsciiDoc files.
  I does not give hints about what's wrong, though.
  
  Is there a guide somewhere about how to support testing  of syntax 
highlighting?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting
Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, 
bruns, demsking, cullmann, vkrause, sars

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 28 Jan 2019 12:11:25 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26691/31384)53%
(10653/20107)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12201/12371)50%
(6392/12853)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6271/7383)65%
(1803/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)86%
(7765/8977)66%
(2281/3470)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/9/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 28 Jan 2019 12:11:25 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 12:11:25 +
 Build duration:
7 min 22 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 3 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/260)92%
(240/260)85%
(26669/31387)53%
(10635/20107)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12170/12372)50%
(6370/12853)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6282/7385)65%
(1808/2795)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(117/117)100%
(117/117)86%
(7763/8977)66%
(2280/3470)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

D18475: Add AsciiDoc support

[Andreas Gratzer]

andreasgr added a comment.


  In D18475#400989 , @nibags wrote:
  
  > If you are only going to use the "admonition" keywords list for 
autocompletion, you could add them to the end of the context "section" or 
"start", keeping the attribute (Normal).
  
  
  Thanks for the tip.
  I think its not that important, though.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting
Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D18577: Make XdgTest spec compliant

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:818e0d1fcb65: Make XdgTest spec compliant (authored by 
davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18577?vs=50422=50425

REVISION DETAIL
  https://phabricator.kde.org/D18577

AFFECTED FILES
  tests/xdgtest.cpp

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Thanks :)

REPOSITORY
  R287 KImageFormats

BRANCH
  sec

REVISION DETAIL
  https://phabricator.kde.org/D18574

To: fvogt, aacid
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18237: Fix ResultIterator

[Albert Astals Cid]

aacid added a comment.


  ping

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18577: Make XdgTest spec compliant

[David Edmundson]

davidedmundson updated this revision to Diff 50422.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18577?vs=50420=50422

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18577

AFFECTED FILES
  tests/xdgtest.cpp

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18577: Make XdgTest spec compliant

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18577

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18577: Make XdgTest spec compliant

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> xdgtest.cpp:124
>  Q_ASSERT(m_xdgShellSurface);
> -connect(m_xdgShellSurface, ::sizeChanged, this, 
> ::render);
> -render();
> +connect(m_xdgShellSurface, ::configureRequested, 
> this, [this](const QSize , KWayland::Client::XdgShellSurface::States 
> states, int serial) {
> +m_xdgShellSurface->ackConfigure(serial);

Q_UNUSED(size)
Q_UNUSED(states)

> xdgtest.cpp:129
> +
> +m_xdgShellSurface->setTitle("Test Window");
> +

I had to use QStringLiteral to make it compile.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18577

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18577: Make XdgTest spec compliant

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Right now it worked in kwin, but was in fact breaking the spec sending
  buffers before it was configured.
  
  There also seems to be an unclearly written (but very very sensible)
  rule about comitting the surface after initial properties in order to
  recieve the configure event.
  
  After these changes it works in Weston too.

TEST PLAN
  Ran test in kwin_wayland and weston

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18577

AFFECTED FILES
  tests/xdgtest.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » qqc2-desktop-style » kf5-qt5 SUSEQt5.12 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/qqc2-desktop-style/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 28 Jan 2019 09:32:13 +
 Build duration:
1 hr 18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/8)0%
(0/8)0%
(0/1431)0%
(0/881)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskirigami-plasmadesktop-integration0%
(0/4)0%
(0/4)0%
(0/149)0%
(0/54)plugin0%
(0/4)0%
(0/4)0%
(0/1282)0%
(0/827)

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb added a comment.


  Usually if you have a conditional behaviour the associated condition 
specifies when to trigger it, no?
  You're right that the names don't suggest exactly how the condition is being 
evaluated (with extra checks or not), but that was also a bit the idea.
  Don't bother the user with such details, just provide a macro that will add 
the flag(s) if they are supported, with an optional conditional expression that 
can make things faster.
  
  Not that this optimisation makes a huge difference in my experience, so the 
already suggested simplification of just querying the compiler for everything 
isn't completely off the table either AFAIAC.
  
  >   In summary, I suggest having both SUPPORTED_IF and TRY_IF, and moving 
AppleClang magic out of the function.
  
  So:
  
  SUPPORTED_IF : add the flag(s) if the expression is true?
  TRY_IF: query the compiler if the expression is true? How would that 
intersect with the SUPPORTED_IF test?
  
  What about the macro name itself in that case?
  
  What bothers me here is that it puts the responsability to invoke magic or 
not back in the hands of the users, most of whom cannot test (directly) on the 
platform where this is needed. That could well open the door to new issues, 
either when a new problematic flag is added, or if someone thinks that some 
cleanup is in order and safe.
  
  Counter proposal: add a SUPPORTED_BY or SUPPORTING_COMPILERS parameter that 
take a list of compiler IDs for flags like -pedantic that are supported by all 
versions and can thus be added with only a simple compiler check. The question 
then is if an error should be raised if both parameters are specified?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

[Fabian Vogt]

fvogt edited the summary of this revision.
fvogt edited the test plan for this revision.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D18574

To: fvogt, aacid
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

[Fabian Vogt]

fvogt updated this revision to Diff 50416.
fvogt added a comment.


  Also bail out early if image data known broken.
  (Unrelated to the overflow fixes, but nice to have)

REPOSITORY
  R287 KImageFormats

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18574?vs=50414=50416

BRANCH
  sec

REVISION DETAIL
  https://phabricator.kde.org/D18574

AFFECTED FILES
  src/imageformats/tga.cpp
  src/imageformats/xcf.cpp

To: fvogt, aacid
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

[Luca Beltrame]

lbeltrame added a comment.


  Can you expand a bit the description? I understand you are fixing problems, 
but why the problems are there and what you are doing exactly.

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D18574

To: fvogt, aacid
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[David Faure]

dfaure added a comment.


  Ah. You meant an "OR", I thought it was an "AND".   (as in `our known 
selection of compilers OR/AND appleclang supports it`)
  But things are certainly not clearer now with the name CONDITION, which 
doesn't imply either one.
  
  Aside from the AppleClang issue, I've had cases where a compiler flag was 
added in an unreleased version of the compiler, so it makes sense to me to have 
a way to have a TRY_IF condition.
  At the same time, I guess we can have SUPPORTED_IF for the cases where we 
know it's supported and we want to save time by not even checking it.
  Then one could say "TRY_IF apple and clang" for the flags that we want to 
double-check on appleclang, instead of the function having this black magic 
hardcoded inside.
  And this way we don't need to check flags that work on all versions of clang 
like -pedantic.
  
  In summary, I suggest having both SUPPORTED_IF and TRY_IF, and moving 
AppleClang magic out of the function.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D18574: Fix various OOB reads and writes in kimg_tga and kimg_xcf

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

TEST PLAN
  No crash anymore.

REPOSITORY
  R287 KImageFormats

BRANCH
  sec

REVISION DETAIL
  https://phabricator.kde.org/D18574

AFFECTED FILES
  src/imageformats/tga.cpp
  src/imageformats/xcf.cpp

To: fvogt, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns