D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich added a dependent revision: D18604: Implement support for writing 
rating information for taglib writer.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added a dependency: D18603: Implement more tags for taglib writer.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich added a comment.


  I forgot to add the dependent revision.
  Thanks for the review, as it's been hard lately to get a reply to anything 
related to KFileMetaData

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich added a dependency: D18601: Rewrite taglib writer to use property 
interface.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Alexander Stippich]

astippich added a comment.


  In D18450#402175 , @TheAssassin 
wrote:
  
  > `LIBAPPIMAGE_BINARIES` (or, more likely, `LIBAPPIMAGE_LIBRARIES`) doesn't 
exist, maybe it existed for a short while but got deleted. @kossebau can you 
please link to `libappimage` directly?
  
  
  Oh sorry, just noticed that I wrongly and consistently wrote 
LIBAPPIMAGE_BINARIES while I meant LIBAPPIMAGE_LIBRARIES, that may have caused 
some confusion.
  
  I will hopefully find some time tonight or tomorrow to test this again

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added a dependent revision: D18603: Implement more tags for taglib 
writer.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham added a comment.


  It's difficult to know the intentions of the user whether they wanted to 
create a single directory with slash in it or a directory tree. So this patch 
is stuck in between the   two.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18603: Implement more tags for taglib writer

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

To: astippich, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  Well now I am. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Noah Davis]

ndavis added a comment.


  In D18563#402216 , @ngraham wrote:
  
  > It's rather ironic that in D18571 , I 
endorse a hidden productivity booster feature, but here, I reject one. :)
  >
  > I think I'm reconsidering. It's true that people get confused when they try 
to create folders with slashes in the name, but removing the feature entirely 
is probably not the best way to handle it.
  >
  > Ideas?
  
  
  Aren't you endorsing hidden productivity boosters in both?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Andrew Crouthamel]

acrouthamel added a comment.


  -1 from me. I would prefer we stick to Unix methodologies.
  
  KDE software is also known to be the more feature-rich and customizable 
options out there, and as mentioned commonly linked to power users. We would be 
wise to not introduce a feature removal/regression such as this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  It's rather ironic that in D18571 , I 
endorse a hidden productivity booster feature, but here, I reject one. :)
  
  I think I'm reconsidering. It's true that people get confused when they try 
to create folders with slashes in the name, but removing the feature entirely 
is probably not the best way to handle it.
  
  Ideas?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18610: Introduce KF5AuthNoWidgets

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  It's KF5Auth but without kauthobjectdecorator.cpp
  
  This will allow us to link helpers just against KF5AuthNoWidgets making
  the library tree they pull much smaller

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18610

AFFECTED FILES
  src/CMakeLists.txt
  src/kauthobjectdecorator.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 50535.
kossebau added a comment.


  rely completely on working libappimage cmake config files, as avail with 
recent
  releases

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18450?vs=50146=50535

BRANCH
  addappimageextractor

REVISION DETAIL
  https://phabricator.kde.org/D18450

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/appimageextractortest.cpp
  autotests/appimageextractortest.h
  autotests/samplefiles/test.AppImage
  src/extractors/CMakeLists.txt
  src/extractors/appimageextractor.cpp
  src/extractors/appimageextractor.h

To: kossebau, #baloo
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D18611: [appimage thumbnailer] Rely on imported cmake target libappimage

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: broulik.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Recent released versions of libappimage set working imported cmake target,
  and people better use the latest versions of libappimage anyway,
  being a young & active project. No old widespread versions aronud
  which need supporting here.

TEST PLAN
  Appimage thumbnailer still builds and links (clean new build).

REPOSITORY
  R320 KIO Extras

BRANCH
  relyonappimageimportedtarget

REVISION DETAIL
  https://phabricator.kde.org/D18611

AFFECTED FILES
  thumbnail/CMakeLists.txt

To: kossebau, broulik
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18610: Introduce KF5AuthNoWidgets

[Albert Astals Cid]

aacid added a comment.


  This is how the dependency graph of backlighthelper looks like at the moment
  F6575456: current_kauth.png 
  
  and this is how it looks if we change it to use the KF5AuthNoWidgets library
  F6575461: patched_kauth.png 
  
  Saving us from QtWidgets and QtGui is a big thing for helpers that are run as 
root.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb added a comment.


  >   In that sentence, one can read "if supported" for the macro name, ...
  
  That was my idea too, and the reason the macro ends in "_if_supported".

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Given there are now released versions of libappimage which provide cmake 
config files, I will now update this patch to simply only support those. 
Distributions will be encouraged to also get the latest version of libappimage 
anyway.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[TheAssassin]

TheAssassin added a comment.


  You can use a system Google test installation by setting 
`-DUSE_SYSTEM_GTEST=ON`, IIRC. But it's easier to simply `git submodule --init 
--recursive`.
  
  `LIBAPPIMAGE_BINARIES` doesn't exist, maybe it existed for a short while but 
got deleted. @kossebau can you please link to `libappimage` directly?
  
  In the future Debian packages we'll introduce pkg-config support by 
installing a `.pc` file, which makes linking to libappimage even easier.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D16894: [ECM] use a macro to add compiler flags conditionally

[David Faure]

dfaure added a comment.


  > SUPPORTED_IF : add the flag(s) if the expression is true?
  
  Yes.
  
  > TRY_IF: query the compiler if the expression is true?
  
  Yes.
  
  > How would that intersect with the SUPPORTED_IF test?
  
  In addition.
  
  AFAICS this is what you implemented, so I like it. I just find SUPPORTED_IF 
(as an intro to the condition) more readable than IF_SUPPORTED.
  
  The macro name seems fine to me.
  In plain English one would say "Add this flag if it's supported. It's 
supported for sure if condition A is true. Also try it if condition B is true, 
since it might work then, but we can't be sure".
  In that sentence, one can read "if supported" for the macro name, "SUPPORTED 
IF" for the first condition, and "TRY IF" for the second condition.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, 
michaelh, ngraham, bruns

D18237: Fix ResultIterator

[Albert Astals Cid]

aacid updated this revision to Diff 50533.
aacid added a comment.


  update so not to break BC

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18237?vs=49413=50533

BRANCH
  arcpatch-D18237

REVISION DETAIL
  https://phabricator.kde.org/D18237

AFFECTED FILES
  src/lib/resultiterator.cpp
  src/lib/resultiterator.h

To: aacid, #baloo, bruns, poboiko
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18237: Fix ResultIterator

[Albert Astals Cid]

aacid reclaimed this revision.
aacid added a comment.


  Ok, that makes sense

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18608: Save two KFilterDev::compressionTypeForMimeType calls

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18608

AFFECTED FILES
  src/kzip.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'm also a bit puzzled: are we removing a feature in order to show an error 
message instead?

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Mark Gaiser]

markg added a comment.


  In D18563#401979 , @shubham wrote:
  
  > @ndavis UNIX does not allow / in any valid identifier name.
  >  Also looking at the bug report, it feels like people wanted to create a 
folder named "a/b/c" which UNEXPECTEDLY created directory tree. So in this, I 
have fix both the problems, first one which is not valid and the latter one 
which is unexpected behaviour.
  
  
  Define unexpected.
  
  People that don't know much about technology but merely happen to use KDE (so 
that would be the ones that also call for help if a console opens) the making 
of a folder names "a/b/c" causing the tree to me made is indeed unexpected.
  The more technical inclined people, the power users, will know that "/" is 
the directory separator and that typing "a/b/c" probably makes the whole tree. 
For those (and i bet those are still the majority of Plasma users) you would 
introduce a regression with this patch.
  
  I'm not saying it should go or stay. I only ever used it a couple of times 
and one of them being when debugging something years ago.
  I can imagine it to be useful for people who got used to it and now rely on 
it for their workflow.
  I can also imagine it not feeling intuitive.
  
  Fyi, mkdir "a/b/c" also doesn't work. mkdir -p "a/b/c" does!

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18237: Fix ResultIterator

[Aleix Pol Gonzalez]

apol added a comment.


  Maybe it could make sense to deprecate the copy constructor and add the move 
operator?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18450: Add extractor for AppImage files

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @astippich  Thanks for the update. I see that myself I built libappimage with 
USE_SYSTEM_LIBARCHIVE:BOOL=ON, USE_SYSTEM_SQUASHFUSE:BOOL=OFF, 
USE_SYSTEM_XZ:BOOL=ON, BUILD_TESTING:BOOL=OFF (cannot remember why I configured 
the build that way when I initially set it up some months ago, possibly ran 
into issues as well, at least I remember issue when BUILD_TESTING was ON.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

[Krešimir Čohar]

rooty added a comment.


  F6575069: image.png 
  Before on top
  After below
  
  (I did the same thing to translucent/dialogs/background.svgz too)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18237: Fix ResultIterator

[Albert Astals Cid]

aacid abandoned this revision.
aacid added a comment.


  Hmmm, you're right, this is Source Compatible but not Binary Compatible.
  
  I guess i'll discard this and hope people don't really misuses it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich retitled this revision from "implement support for writing rating 
information for taglib writer" to "Implement support for writing rating 
information for taglib writer".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18604: implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add support for writing the rating tag to all
  supported mime types. Since the implementations quite
  differ, implement mime type specific paths when necessary.

TEST PLAN
  tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  rating_write

REVISION DETAIL
  https://phabricator.kde.org/D18604

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham added a comment.


  @ndavis UNIX does not allow / in any valid identifier name.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

[Krešimir Čohar]

rooty added a comment.


  In D18545#401958 , @davidedmundson 
wrote:
  
  > > "Background Contrast" darkens the background of all the UI elements by 
adding rectangles (instead of just darkening their backgrounds).
  >
  > That's both true and not true.
  >
  > We take the frame SVG and run:
  >
  > QBitmap(d->alphaMask().mask())
  >  Which is a  list of rectangles, but there's no reason why it wouldn't be 
an exact representation.
  >
  > Is the alphamask of the edited frame updated?
  
  
  I've only edited the three parts (the transparent squircle - is that the 
alphamask? sorry I'm not familiar with the terminology, the shadows and the 
black squircle).
  There was a part of the svg with strong rectangular borders i didn't change - 
should I have?
  
  Also, I have no idea why this happens:
  F6575061: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18163: Set the color scheme to Printing when print preview'ing

[Ahmad Samir]

ahmadsamir updated this revision to Diff 50503.
ahmadsamir retitled this revision from "KateRenderer: when printing initially 
set the color scheme to Printing" to "Set the color scheme to Printing when 
print preview'ing".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a subscriber: mwolff.
ahmadsamir added a comment.


  Only set the color scheme to printing when using print preview

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18163?vs=49184=50503

BRANCH
  print-preview-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18163

AFFECTED FILES
  src/printing/kateprinter.cpp

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

[David Edmundson]

davidedmundson added a comment.


  If you open the file, the mask is the black rectangle on the right.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Noah Davis]

ndavis added a comment.


  So if I want to make 2 folders at once, `~/a` and `~/a/b`, this patch removes 
that ability? If so, I don't like this change.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

[David Edmundson]

davidedmundson added a comment.


  > "Background Contrast" darkens the background of all the UI elements by 
adding rectangles (instead of just darkening their backgrounds).
  
  That's both true and not true.
  
  We take the frame SVG and run:
  
  QBitmap(d->alphaMask().mask())
  Which is a  list of rectangles, but there's no reason why it wouldn't be an 
exact representation.
  
  Is the alphamask or the edited frame updated?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18603: Implement more tags for taglib writer

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Implement more tags for writing for the
  taglib writer including composer, disc number,
  album artist, lyricist, conductor, lyrics,
  copyright and language.

TEST PLAN
  tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  enhance_taglibwriter

REVISION DETAIL
  https://phabricator.kde.org/D18603

AFFECTED FILES
  autotests/taglibwritertest.cpp
  autotests/taglibwritertest.h
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 29 Jan 2019 18:13:14 +
 Build duration:
7 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3146/3848)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1175/1563)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 29 Jan 2019 18:13:14 +
 Build duration:
6 min 38 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3146/3848)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1175/1563)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

[Krešimir Čohar]

rooty added a comment.


  In D18545#401802 , @ngraham wrote:
  
  > I really like the effect that this gives--not only for notifications, but 
also for plasma popups, OSDs, window switchers, etc. It's subtle and classy. 
Let us know when the remaining bugs are worked out!
  
  
  Actually, there's nothing more to be done here.
  
  This actually uncovered a bug (feature?) in Kwin.
  "Background Contrast" darkens the background of all the UI elements by adding 
rectangles (instead of just darkening their backgrounds).
  
  There are two ways forward here:
  (1) Ditch the background contrast effect by default - make Breeze Dark take 
on its natural color (I'm in favor of this one)
  or
  (2) Fix the Kwin background contrast effect - which I have no idea how to do, 
but might be able to learn
  
  Either way this patch remains the same, so... it's basically ready :D

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Rewrite the taglib writer to use taglib's
  unified property interface, which is more extensible.

TEST PLAN
  tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  rewrite_taglib

REVISION DETAIL
  https://phabricator.kde.org/D18601

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18599: Use specific error message if file/folder name contains '/'

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, thanks.

REPOSITORY
  R241 KIO

BRANCH
  err

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham updated this revision to Diff 50496.
shubham marked an inline comment as done.
shubham added a comment.


  Fix trailing spaces

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18599?vs=50495=50496

BRANCH
  err

REVISION DETAIL
  https://phabricator.kde.org/D18599

AFFECTED FILES
  src/core/global.h
  src/core/job_error.cpp
  src/ioslaves/file/file.cpp

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18450: Add extractor for AppImage files

[Alexander Stippich]

astippich added a comment.


  The first issue is when BUILD_TESTING is not set to false, cmake fails with
  CMake Error at lib/CMakeLists.txt:8 (add_subdirectory):
  
The source directory

  ~/Code/libappimage-0.1.8/lib/gtest

does not contain a CMakeLists.txt file.
  
  Second issue was a missing check for libfuse, otherwise it would fail during 
compiling (squashfuse I think).
  
  The LIBAPPIMAGE_BINARIES cmake variable is used in the target_link_libraries 
call in the autotest and extractor cmake file.
  
  I will open issues on github.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18450

To: kossebau, #baloo
Cc: TheAssassin, astippich, broulik, kde-frameworks-devel, ashaposhnikov, 
michaelh, spoorun, ngraham, bruns, abrahams

D18599: Use specific error message if file/folder name contains '/'

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> global.h:251
>  ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between 
> kuiserver and views when the job owner disappears unexpectedly. It should not 
> be emitted by slaves. @since 5.54
> +ERR_CANNOT_MKDIR_CONTAINING_SLASH = KJob::UserDefinedError + 76, ///< A 
> specific error for the mkdir job failing due to presence of slashes in the 
> directory names. @since 5.55 
>  };

There's a trailing space here

> job_error.cpp:1083
>  break;
> +
> +case ERR_CANNOT_MKDIR_CONTAINING_SLASH:

No spaces on line breaks

> job_error.cpp:1088
> +solutions << i18n("Do not use slashes in file/folder names.");
> +break;
>  

Trailing space

> file.cpp:285
>  const QString path(url.toLocalFile());
> +
> +#ifndef Q_OS_WIN

No spaces on line breaks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham updated this revision to Diff 50495.
shubham added a comment.


  1. #ifndef Q_OS_WIN for the error message

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18599?vs=50494=50495

BRANCH
  err

REVISION DETAIL
  https://phabricator.kde.org/D18599

AFFECTED FILES
  src/core/global.h
  src/core/job_error.cpp
  src/ioslaves/file/file.cpp

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Nathaniel Graham]

ngraham added reviewers: VDG, Frameworks, Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> knewfilemenu.cpp:905
>  KIO::Job *job;
> -if (name.contains(QLatin1Char('/'))) {
> -// If the name contains any slashes, use mkpath so that a/b/c works.
> -job = KIO::mkpath(url, baseUrl);
> -
> KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::Mkpath, 
> QList(), url, job);
> -} else {
> -// If not, use mkdir so it will fail if the name of an existing 
> folder was used
> -job = KIO::mkdir(url);
> -KIO::FileUndoManager::self()->recordJob(KIO::FileUndoManager::Mkdir, 
> QList(), url, job);
> -}
> +// UNIX throws error creating directory tree(a/b/c) while WINDOWS 
> creates directory named a/b/c
> +job = KIO::mkdir(url);

You don't need to duplicate the diff from D18563 
 here.

> file.cpp:286
> +
> +// UNIX does not allow identifiers containing /
> +if (path.contains(QLatin1Char('/'))) {

This should not be evaluated on Windows, since as you pointed out, Windows does 
allow slashes so there's no error here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham updated this revision to Diff 50494.
shubham added a comment.


  Remove unintentionally included header

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18599?vs=50493=50494

BRANCH
  err

REVISION DETAIL
  https://phabricator.kde.org/D18599

AFFECTED FILES
  src/core/global.h
  src/core/job_error.cpp
  src/filewidgets/knewfilemenu.cpp
  src/ioslaves/file/file.cpp

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham added a dependent revision: D18599: Use specific error message if 
file/folder name contains '/'.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18599: Use specific error message if file/folder name contains '/'

[Shubham]

shubham created this revision.
shubham added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Depends on D18563 

REPOSITORY
  R241 KIO

BRANCH
  err

REVISION DETAIL
  https://phabricator.kde.org/D18599

AFFECTED FILES
  src/core/global.h
  src/core/job_error.cpp
  src/filewidgets/knewfilemenu.cpp
  src/ioslaves/file/file.cpp

To: shubham, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18237: Fix ResultIterator

[Aleix Pol Gonzalez]

apol added a comment.


  Do you think BC is a problem here then? Won't applications be using it as you 
described start failing?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18545: [breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs

[Nathaniel Graham]

ngraham added a comment.


  I really like the effect that this gives--only only for notifications, but 
also for plasma popups, OSDs, window switchers, etc. It's subtle and classy. 
Let us know when the remaining bugs are worked out!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  Then we should define a new error message specifically for this case. That's 
probably material for another patch.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a comment.


  In D18163#398206 , @dhaumann wrote:
  
  > Is KateRenderer::setPrinterFriendly() only called in print preview mode? I 
think not.
  >
  > What is the bahavior currently when you print a page with another schema, 
and then print a page again? Does it always fallback to Printing without the 
patch, or does it remember the previous schema?
  
  
  Print -> Options -> Layout, the schema is always remembered with and without 
the patch.
  
  But I see your point, even though setting the schema in setPrinterFriendly() 
wouldn't change the behaviour for the File -> Print dialog anyway, it's 
probably much safer to just set the schema to Printing only in Print Preview 
and be done with it.
  
  I'll update the diff shortly.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham added a comment.


  @ngraham The message you suggested is specific, on the other hand failure in 
creation of directory may also be due to the file/directory name reserved by OS 
(eg  .. )

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18317: Display an error message if loading a dictionary fails

[Ahmad Samir]

ahmadsamir added a reviewer: loh.tar.
ahmadsamir added a subscriber: pino.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Display an error message if loading a dictionary fails

[Ahmad Samir]

ahmadsamir updated this revision to Diff 50486.
ahmadsamir retitled this revision from "Don't fail if defaultLanguage 
dictionary can't be loaded" to "Display an error message if loading a 
dictionary fails".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir removed a reviewer: loh.tar.
ahmadsamir removed a subscriber: pino.
ahmadsamir added a comment.


  Rework the patch:
  
  - so as not to change the config file without the user's intervention
  - core libs shouldn't depend on Gui bits

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18317?vs=49714=50486

BRANCH
  invalid-defaultLanguage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18317

AFFECTED FILES
  src/core/loader.cpp
  src/core/loader_p.h
  src/ui/dictionarycombobox.cpp
  src/ui/dictionarycombobox.h

To: ahmadsamir, sandsmark, loh.tar
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, pino

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  How about "Could not create  because slashes are not allowed in 
file and folder names."

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Shubham]

shubham added a comment.


  @ngraham Okay with changing error message string, please provide me with the 
best suitable string.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham retitled this revision from "Don't allow '/' in new directory's name" 
to "Don't create directory tree when a new folder has a '/' in the name".
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added reviewers: dfaure, elvisangelaccio, pino.
ngraham added subscribers: pino, elvisangelaccio, dfaure.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to me. Please don't land this until you receive approval from 
@dfaure, @elvisangelaccio, @pino, or another experienced Frameworks dev.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  We might want to also consider improving the error message for this 
situation. I think it would be appropriate to do so in this patch.

REPOSITORY
  R241 KIO

BRANCH
  dir

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: dfaure, elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, 
bruns

D12950: add test which checks the property types

[Alexander Stippich]

astippich added a comment.


  ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12950

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17245: Add string formatting function to property info

[Alexander Stippich]

astippich added a comment.


  ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17991: Refactor the way device backends are built and registered

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good to me. +1

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D17991

To: pino
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

[Anthony Fieroni]

anthonyfieroni added a comment.


  +1

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18475: Add AsciiDoc support

[Andreas Gratzer]

andreasgr added a comment.


  In D18475#401517 , @dhaumann wrote:
  
  > 1. I apply your patch: arc patch D18475 
  
  
  Thanks for the information.
  And many thanks for your time spent on reviewing.
  
  Cheers

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18475

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, nibags, kwrite-devel, kde-frameworks-devel, 
#framework_syntax_highlighting, bmortimer, hase, michaelh, genethomas, ngraham, 
bruns, demsking, cullmann, vkrause, sars

D18089: KLauncher: handle processes exiting without error

[Ahmad Samir]

ahmadsamir added a comment.


  Ping.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns