D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

[Krešimir Čohar]

rooty added a comment.


  In D18545#402636 , @ngraham wrote:
  
  > So this is now working for me as intended, yay! The effect is very strongly 
positive. Huge improvement IMO.
  >
  > But do we know why? It there indeed a bug in the KWin effect somewhere? Or 
was the SVG previously broken somehow? Or was the prior corner radius too small 
to make a difference so nobody saw it? Etc.
  
  
  There's something about the Kwin effect that renders a rectangle //without// 
the rounded corners. I hope David's able to uncover why because I don't 
understand it at all.
  And yeah I think you're right - seeing as it wasn't rounded before, nobody 
could notice.
  
  The corner were very slightly rounded, but the circle arc didn't extend 
beyond the borders of a single pixel so it really was a true rectangle, for all 
intents and purposes.
  
  It works for me too, both dark and light, if I turn off the effect.
  I really like Breeze Dark this way. It's not pitch black without the effect 
hahaha

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18617: AsciiDoc: Fix highlighting of include directive

[Andreas Gratzer]

andreasgr added a comment.


  In D18617#402600 , @dhaumann wrote:
  
  > Looks good to me. Please increase the "version" number whenever you change 
an highlighting file.
  
  
  Ooops, sorry.
  Many thanks for the quick review.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18617

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

[Nathaniel Graham]

ngraham added a comment.


  So this is now working for me as intended, yay! The effect is very strongly 
positive. Huge improvement IMO.
  
  But do we know why? It there indeed a bug in the KWin effect somewhere? Or 
was the SVG previously broken somehow? Or was the prior corner radius too small 
to make a difference so nobody saw it? Etc.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Mélanie Chauvel]

achauvel updated this revision to Diff 50581.

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15189?vs=50580=50581

REVISION DETAIL
  https://phabricator.kde.org/D15189

AFFECTED FILES
  kioclient/kioclient.cpp

To: achauvel, #frameworks, dfaure, cfeck
Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Mélanie Chauvel]

achauvel updated this revision to Diff 50580.
achauvel added a comment.


  Added an `ifdef` so that it could compile with older version of KIO.

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15189?vs=47987=50580

REVISION DETAIL
  https://phabricator.kde.org/D15189

AFFECTED FILES
  kioclient/kioclient.cpp

To: achauvel, #frameworks, dfaure, cfeck
Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[David Faure]

dfaure added a comment.


#include 

#if KIO_VERSION >= QT_VERSION_CHECK(5,55,0)
...
#endif

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18617: AsciiDoc: Fix highlighting of include directive

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ab0b36345229: AsciiDoc: Fix highlighting of include 
directive (authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18617?vs=50556=50578#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18617?vs=50556=50578

REVISION DETAIL
  https://phabricator.kde.org/D18617

AFFECTED FILES
  autotests/folding/asciidoc.adoc.fold
  autotests/html/asciidoc.adoc.html
  autotests/input/asciidoc.adoc
  autotests/reference/asciidoc.adoc.ref
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18617: AsciiDoc: Fix highlighting of include directive

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me. Please increase the "version" number whenever you change an 
highlighting file.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18617

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18563: Don't create directory tree when a new folder has a '/' in the name

[Andrius da Costa Ribas]

andriusr added a comment.


  Also, Windows does not allow filenames with either `\` or `/`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Andrius da Costa Ribas]

andriusr added inline comments.

INLINE COMMENTS

> ngraham wrote in knewfilemenu.cpp:907
> If Windows allows slashes in the filename, shouldn't they just be a part of 
> the filename and not create a directory tree? If so, then we don't even need 
> this `#ifdef` condition at all; `KIO::mkdir(url);` will take care of the 
> behavior on each individual platform

if this is a QUrl, then `/` is the separator on every platform (e.g.: 
`file://C:/WINDOWS/System32`)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Emirald Mateli]

emateli added a comment.


  Agree, something similar is being proposed over at D18384 
. These dialogs are getting out of hand.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: emateli, cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

[Mélanie Chauvel]

achauvel added a comment.


  @dfaure I don’t see how to do that, since there does not seem to have such 
`ifdef` in the actual codebase. However I can make `set(KF5_MIN_VERSION 
"5.55.0")` instead of 5.54.0 in the `CMakeLists.txt`.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D15189

To: achauvel, #frameworks, dfaure, cfeck
Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, 
GB_2, ragreen, Pitel, michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  Here's an idea for an overall nicer user experience: instead of letting 
people choose whatever name they want in the new file & new folder dialogs and 
then displaying an error message (inline or in dialog form) once they click 
"OK", we could have the new file & new folder dialogs display an inline error 
message using a KMessageWidget if the name is invalid, and then disable the 
"OK" button until they change the name. Then for ambiguous cases like this one, 
it could display a warning message saying something along the lines of `Since 
slashes are not permissible characters in folder names, this will create a 
folder tree rather than a folder named "a/b/c"` or something like that. With 
this, we could remove all of those annoying pop-up dialog box errors we've 
added recently too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18163: Set the color scheme to Printing when print preview'ing

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kateprinter.cpp:164
>  QPrinter printer;
> -KatePrinterPrivate p(view->doc(), view);
> +KatePrinterPrivate p(view->doc(), view, true);
>  QPrintPreviewDialog preview();

better add a setter before and then call

`p.setColorScheme(QStringLiteral("Printing"));`

here

> kateprinter.cpp:180
>  QPrinter printer;
> -KatePrinterPrivate p(doc);
> +KatePrinterPrivate p(doc, nullptr, true);
>  QPrintPreviewDialog preview();

dito

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18622: Remove monochrome preferences-system symlinks

[Noah Davis]

ndavis abandoned this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18622

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 30 Jan 2019 18:19:07 +
 Build duration:
9 min 23 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33058/48369)51%
(15906/31074)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4461/4756)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1873/3151)47%
(1566/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 30 Jan 2019 18:19:07 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[loh tar]

loh.tar added a comment.


  I often struggle with QtCreator but I can't remember what happens there, 
sorry.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

D18622: Remove monochrome preferences-system symlinks

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Instead of landing this patch, please revert the offending commit itself 
using `git revert 14bbb8f64ba2d4aa29b3a3b3b186fca36979fbef`, add the 
explanation message from here into the commit message for the reversion commit, 
and push directly. Then you can abandon this revision.
  
  That will make the git history of this issue more obvious for the future.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-preferences-system (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18622

To: ndavis, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18622: Remove monochrome preferences-system symlinks

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18622

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18622: Remove monochrome preferences-system symlinks

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Remove some monochrome preferences-system symlinks that were added for 
compatibility with 3rd party applications. For some reason, `preferences-system 
was only showing up as a monochrome icon with the Breeze icon theme (light 
version, not Breeze Dark). While I don't think the source of the problem was 
these symlinks, I am removing them to prevent the problem from affecting users 
in KF5.55.

REPOSITORY
  R266 Breeze Icons

BRANCH
  remove-monochrome-preferences-system (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18622

AFFECTED FILES
  icons-dark/actions/16/preferences-system.svg
  icons-dark/actions/22/preferences-system.svg
  icons-dark/actions/24/preferences-system.svg
  icons/actions/16/preferences-system.svg
  icons/actions/22/preferences-system.svg
  icons/actions/24/preferences-system.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kauthobjectdecorator.cpp:69
>  
> -qCWarning(KAUTH) << Q_FUNC_INFO << "We're not decorating an action or a 
> button";
> +qCWarning(KAUTHWIDGET) << Q_FUNC_INFO << "We're not decorating an action 
> or a button";
>  }

It could make sense to leave this as KAUTH and have the rest as KAUTHCORE? this 
way they all have the same name as the library.

Or we just leave them all as KAUTH, like the framework.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthCore

[Albert Astals Cid]

aacid updated this revision to Diff 50563.
aacid retitled this revision from "Introduce KF5AuthNoWidgets" to "Introduce 
KF5AuthCore".
aacid edited the summary of this revision.
aacid added a comment.


  Much better name as suggested by Aleix

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18610?vs=50536=50563

BRANCH
  arcpatch-D18610_1

REVISION DETAIL
  https://phabricator.kde.org/D18610

AFFECTED FILES
  src/CMakeLists.txt
  src/kauthobjectdecorator.cpp

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18608: Save two KFilterDev::compressionTypeForMimeType calls

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D18608

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 30 Jan 2019 17:06:47 +
 Build duration:
4 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5684/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(850/1675)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
  

D18237: Fix ResultIterator

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko, apol
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[Dominik Haumann]

dhaumann added a comment.


  Fixed: 5a6449c3b3d9bbc2b1bc15a5d5b40d7228f3a406 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 30 Jan 2019 16:19:42 +
 Build duration:
5 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 30 Jan 2019 16:19:42 +
 Build duration:
7 min 12 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33058/48369)51%
(15906/31074)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4461/4756)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1873/3151)47%
(1566/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
   

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[Dominik Haumann]

dhaumann added a comment.


  Unfortunately, the change in the .ui file introduced bug 
https://bugs.kde.org/show_bug.cgi?id=403422
  
  The minimum and maximum were set from 1...5 to -1...-1. Will post a followup 
patch.
  
  @loh.tar Did you remove and add the slider manually again, or how did that 
happen?
  
  PS: It seems we did a bad review job here ;)

INLINE COMMENTS

> textareaappearanceconfigwidget.ui:187-197
> +   
> +-1
> +   
> +   
> +-1
> +   
> +   

This introduced bug https://bugs.kde.org/show_bug.cgi?id=403422

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

D18563: Don't create directory tree when a new folder has a '/' in the name

[Mark Gaiser]

markg added a comment.


  In D18563#402216 , @ngraham wrote:
  
  > It's rather ironic that in D18571 , I 
endorse a hidden productivity booster feature, but here, I reject one. :)
  >
  > I think I'm reconsidering. It's true that people get confused when they try 
to create folders with slashes in the name, but removing the feature entirely 
is probably not the best way to handle it.
  >
  > Ideas?
  
  
  Well, one idea does com to mind. But it would be a **lot** of work!
  The concept in Plasma is iirc still "strong by default, powerful when 
needed". Or something along those lines.
  
  With that in mind, it could be an option to disable this by default and 
introduce a new tab in the dolphin settings page where you list the power 
features and allow the user to enable them all (or one by one).
  It is a lot more code logic and does fall into the micro settings category (a 
place you normally don't want to be) but would be a possible solution in this 
case.
  
  Not saying this is the right direction. Merely one idea.
  
  Another idea is to warn the user but with a checkbox: "Don't show this 
warning again".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18317: Display an error message if loading a dictionary fails

[loh tar]

loh.tar added a comment.


  My observations:
  
  - There is no hint when you activate auto spell check (yes, it's out of this 
scope)
  - Before showing the combobox by "Change Dictionary" the popup appears
  - The combobox shows then some other setting, here it was the first entry
  - When open the config dialog the new popup block the processing. So the 
expected dialog is only shown after user action
  
  F6576785: 1548859202.png 
  
  My suggestion:
  
  - For me are extra popups annoying. I would suggest to avoid them
  - Add some hint embedded to the Sonnet config dialog. IIRC I have seen in 
some config dialog a similar hint like these KTextEditor::Message, but I may 
wrong
  - Perhaps should the combobox shown an empty entry or an error hint instead 
of some (not expected) value
  - How about to emit the full message, not only the missed language? This way 
is no need to formulate everywhere an own error text
  
  Todo:
  
  - A patch to KTextEditor to show the hint as KTextEditor::Message when some 
spell check is requested

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18601: Rewrite taglib writer to use property interface

[Nathaniel Graham]

ngraham added reviewers: broulik, cfeck.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18617: AsciiDoc: Fix highlighting of include directive

[Andreas Gratzer]

andreasgr created this revision.
andreasgr added reviewers: Framework: Syntax Highlighting, dhaumann.
andreasgr added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
andreasgr requested review of this revision.

REVISION SUMMARY
  The `include` directive is //always// processed, even when within verbatim or 
passthrough blocks.
  It should therefore be highlighted in these cases too.
  
  - Fix the highlighting definition `asciidoc.xml`.
  - Adjust and improve test file `asciidoc.adoc`.
  - Update created `.fold`, `.html` and `.ref` files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18617

AFFECTED FILES
  autotests/folding/asciidoc.adoc.fold
  autotests/html/asciidoc.adoc.html
  autotests/input/asciidoc.adoc
  autotests/reference/asciidoc.adoc.ref
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, genethomas, 
ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich added a comment.


  Ping @graesslin?
  
  Martin, can you please look into this?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[René J . V . Bertin]

rjvbb added a comment.


  >   Right, but I was saying all this because I think IF_SUPPORTED (the 
keyword in the arguments) should be SUPPORTED_IF.
  
  Doh?! I thought that was the case, maybe I just restored the wrong way after 
the CONDITION experiment.
  
  Christophe: can you please be more specific why sphinx fails? Also, is there 
an existing unittest I can clone and adapt?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, 
#build_system, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[David Faure]

dfaure added a comment.


  In D16894#402209 , @rjvbb wrote:
  
  > >   In that sentence, one can read "if supported" for the macro name, ...
  >
  > That was my idea too, and the reason the macro ends in "_if_supported".
  
  
  Right, but I was saying all this because I think IF_SUPPORTED (the keyword in 
the arguments) should be SUPPORTED_IF.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, 
#build_system, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Christoph Feck]

cfeck added a comment.


  It could ask what to do.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, 
kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Emirald Mateli]

emateli added a comment.


  I am of the opinion that such dialogs are not very user friendly and honestly 
very much against them. Not commenting on the usefulness of this particular 
warning, but dolphin has quite a few of these kind of dialogs with the same 
process: `Input something -> Get error -> Restart`. Feedback should instead be 
given inplace.
  
  A new dialog built especially for Dolphin's new file/folder/X should take 
over getting the input from the user and prevent continuing or warn the user 
about his actions:
  
  - User leaves empty input? "Name cannot be empty".
  - User types existing folder name? Show him an error message on the spot
  - User types "~" as part of the file name? Show this warning
  - User types names with `/`, warn that a path will be created instead of just 
a single directory.
  - User types a name that starts with a dot? Show him the current warning 
about hidden files etc.
  
  I am strongly of the opinion that such dialog is vastly more user friendly to 
what we currently have and want to implement. Pinging @ngraham since he's 
particularly concerned with UX/Usability these days. Looking forward to 
everyone's thoughts.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18610: Introduce KF5AuthNoWidgets

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:29
>  
> +add_library(KF5AuthNoWidgets ${libkauth_no_widgets_SRCS})
> +target_link_libraries(KF5AuthNoWidgets PUBLIC Qt5::Core KF5::CoreAddons) 
>  # for KJob

How about we call it KF5AuthCore?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18610

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> ECMAddCompilerFlag.cmake:1-25
> +#=
> +# Copyright 2018  René J.V. Bertin 
> +#
> +# Redistribution and use in source and binary forms, with or without
> +# modification, are permitted provided that the following conditions
> +# are met:
> +#

Shall be moved after the module documentation

> ECMAddCompilerFlag.cmake:27-29
> +include(CMakeParseArguments)
> +include(CheckCXXCompilerFlag)
> +include(CheckCCompilerFlag)

Shall be moved after the license block

> ECMAddCompilerFlag.cmake:30-58
> +
> +# ECM_ADD_CXX_COMPILER_FLAGS_IF_SUPPORTED(FLAGS 
> +# [IF_SUPPORTED ]
> +# [QUERY_IF ]
> +# )
> +# add  or  to CMAKE_CXX_FLAGS if the compiler supports them.
> +# Support is determined by the IF_SUPPORTED expression if provided or by

Sphinx cannot parse this doc.

Also don't forget to create ECMAddCompilerFlag.rst in docs/modules/

> ECMAddCompilerFlag.cmake:58
> +# [QUERY_IF ]
> +# )
> +

Missing "Since 5.xx"

> ECMAddCompilerFlag.cmake:61
> +
> +function (ECM_ADD_CXX_COMPILER_FLAGS_IF_SUPPORTED)
> +set(_OPTIONS_ARGS)

Unneeded extra space

> ECMAddCompilerFlag.cmake:66
> +
> +cmake_parse_arguments(EASCXXFLAGS "${_OPTIONS_ARGS}" 
> "${_ONE_VALUE_ARGS}" "${_MULTI_VALUE_ARGS}" ${ARGN} )
> +if(NOT EASCXXFLAGS_FLAGS)

Unneeded extra space

> ECMAddCompilerFlag.cmake:68
> +if(NOT EASCXXFLAGS_FLAGS)
> +message( FATAL_ERROR "ecm_add_cxx_compiler_flags_if_supported: 
> 'FLAGS' is a required argument." )
> +endif()

Unneeded extra spaces

> ECMAddCompilerFlag.cmake:96
> +
> +function (ECM_ADD_C_COMPILER_FLAGS_IF_SUPPORTED)
> +set(_OPTIONS_ARGS)

Unneeded extra space

> ECMAddCompilerFlag.cmake:101
> +
> +cmake_parse_arguments(EASCFLAGS "${_OPTIONS_ARGS}" "${_ONE_VALUE_ARGS}" 
> "${_MULTI_VALUE_ARGS}" ${ARGN} )
> +if(NOT EASCFLAGS_FLAGS)

Unneeded extra space

> ECMAddCompilerFlag.cmake:103
> +if(NOT EASCFLAGS_FLAGS)
> +message( FATAL_ERROR "ecm_add_c_compiler_flags_if_supported: 'FLAGS' 
> is a required argument." )
> +endif()

Unneeded extra space

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, 
#build_system, michaelh, ngraham, bruns

D18237: Fix ResultIterator

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D18237

REVISION DETAIL
  https://phabricator.kde.org/D18237

To: aacid, #baloo, bruns, poboiko, apol
Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18608: Save two KFilterDev::compressionTypeForMimeType calls

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18608

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  PS: don't forget the unit test for the new module.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16894

To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, 
#build_system, michaelh, ngraham, bruns

D18612: Cache the default KColorScheme configuration

[Milian Wolff]

mwolff added a comment.


  I see that it's faster when I profile kate/kdev, but I cannot easily write a 
benchmark for this. It's only noticeable when the KDE_COLOR_SCHEME_PATH 
variable is set, otherwise the global application config will be used afte 
rall, which is going to be shared most probably. Any idea how I could construct 
a valid KDE_COLOR_SCHEME_PATH path to e.g. the breeze color scheme from within 
a kcolor scheme auto test?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D18612

To: mwolff, #kate, #kdevelop, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18612: Cache the default KColorScheme configuration

[Milian Wolff]

mwolff created this revision.
mwolff added reviewers: Kate, KDevelop, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mwolff requested review of this revision.

REVISION SUMMARY
  KDevelop, Kate and probably other applications too, recreate
  KColorScheme instances repeatedly. This was very costly since we
  ended up reparsing the internal color scheme configuration file
  every time - the shared configuration wasn't stored anywhere thus
  it's refcount dropped to zero after once the KColorScheme was
  fully constructed.
  
  Optimize this apparently common scenario by caching the configuration
  in a thread_local variable and only open a new configuration when the
  user changed the application color scheme.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18612

AFFECTED FILES
  src/kcolorscheme.cpp

To: mwolff, #kate, #kdevelop, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Shubham]

shubham added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

[Krešimir Čohar]

rooty retitled this revision from "[breeze desktop theme/dialogs] WIP, Add 
rounded corners to dialogs" to "[breeze desktop theme/dialogs] Add rounded 
corners to dialogs".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, ngraham, 
bruns