D18116: Add TODO KF6 note

[loh tar]

loh.tar added a comment.


  In D18116#403838 , @cullmann wrote:
  
  > Just to be sure:
  >
  > We can apply D18117  and don't need to 
change here anything or?
  
  
  It seems so :-)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18116: Add TODO KF6 note

[loh tar]

loh.tar updated this revision to Diff 50759.
loh.tar retitled this revision from "Don't show document load trouble twice" to 
"Add TODO KF6 note ".
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Revert all
  - Add TODO KF6 note to header
  - Update Summary

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18116?vs=50027=50759

REVISION DETAIL
  https://phabricator.kde.org/D18116

AFFECTED FILES
  src/include/ktexteditor/document.h

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 23:19:20 +
 Build duration:
6 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21577/45943)38%
(13023/34237)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11348/11739)50%
(7171/14363)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5545/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(743/9698)6%
(306/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 23:19:20 +
 Build duration:
3 min 33 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21577/45943)38%
(13023/34237)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11348/11739)50%
(7171/14363)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5545/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(743/9698)6%
(306/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 23:19:20 +
 Build duration:
3 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D18688: Check Exiv2::ValueType::typeId before converting it to rational

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  invalid-gps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18688

To: poboiko, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Igor Poboiko]

poboiko added a comment.


  Nice! I like it, it's definitely much better than `Q_ASSERT_X` macros that 
are just silently ignored in non-debug builds.
  
  Have some nitpicks though:
  
  1. Are we actually sure this is gonna fix all those crashes? Otherwise I 
would suggest using CCBUG instead of BUG inside the commit message.
  2. Looks like this patch is composed of two parts - introducing new logging 
category and and improving error handling. It would be also nice to split those 
into two separate patches.
  3. For now, logging is the only way to know if there's something bad going 
on. In that case I would suggest to at least increase severity of those 
messages - it would increase chances users will notice it. For example, use 
`qCCritical` (but this would also require additional check for 
okayish/non-critical return codes, such as `MDB_NOTFOUND`)
  4. There are a lot of redundant `Q_ASSERT_X` left, which could be removed. I 
suggest just `grep`'ing over the code to catch'em all. I've started marking 
them here, but then I gave up - too many of them.
  5. There are also several unchecked return codes as well, such as inside 
`*DB::size()` calls. Those can also be found by `grep`'ing over `Q_ASSERT_X`.

INLINE COMMENTS

> documentdatadb.cpp:142
>  }
>  Q_ASSERT_X(rc == 0, "DocumentDataDB::toTestMap", mdb_strerror(rc));
>  

This is not needed now, I guess

> documentdb.cpp:144
>  MDB_stat stat;
>  int rc = mdb_stat(m_txn, m_dbi, );
>  Q_ASSERT_X(rc == 0, "DocumentDB::size", mdb_strerror(rc));

This can also return something weird.

> postingdb.cpp:132
> +while (rc == 0) {
>  Q_ASSERT_X(rc == 0, "PostingDB::fetchTermsStartingWith", 
> mdb_strerror(rc));
>  

This assert is not necessary here then?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 103 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/103/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 02 Feb 2019 21:48:32 +
 Build duration:
3 min 57 sec and counting

D18688: Check Exiv2::ValueType::typeId before converting it to rational

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Baloo, Frameworks, astippich.
Herald added projects: Frameworks, Baloo.
poboiko requested review of this revision.

REVISION SUMMARY
  If one has a malformed image with GPSAltitude key present, but is not 
rational,
  an attempt to convert it to rational will cause a crash. Same with 
GPSAltitudeRef key,
  (which is supposed to be a byte).
  
  This fixes regression introduced in D16617: fix extraction of GPS altitude 
for exif data  / D18010: Fix failing test 
of exiv gps data 

TEST PLAN
  I have a picture that causes `baloo_file_extractor` to crash, with backtrace 
pointing to `toRational` call inside `fetchGpsAltitude`.
  It no longer crashes. Also, `ctest` doesn't report any oddities here.

REPOSITORY
  R286 KFileMetaData

BRANCH
  invalid-gps (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18688

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: poboiko, #baloo, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/39/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 02 Feb 2019 17:23:15 +
 Build duration:
4 hr 26 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18664: Baloo engine: treat every non-success code as a failure

[Nathaniel Graham]

ngraham added subscribers: bruns, ngraham.
ngraham added reviewers: bruns, poboiko.
ngraham added a comment.


  Conceptually this seems like it's definitely better than nothing or the 
status quo. Only checking for `MDB_NOTFOUND` and ignoring other error statuses 
seems like really bad code hygiene. @bruns?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18686: Add Cursors KCM icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:befcc3791d6a: Add Cursors KCM icon (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18686?vs=50746=50747

REVISION DETAIL
  https://phabricator.kde.org/D18686

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-cursors.svg
  icons/preferences/32/preferences-desktop-cursors.svg

To: ndavis, #vdg, ngraham
Cc: GB_2, ngraham, abetts, kde-frameworks-devel, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Björn Feber]

GB_2 added a comment.


  In D18675#404096 , @GB_2 wrote:
  
  > In D18675#404090 , @ngraham 
wrote:
  >
  > > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  >
  >
  > Yeah, it's the only X icon, I think we need to make a copy of it that is 
not red in `breeze-icons` (we could call it `edit-none` or something).
  
  
  Let's do this then.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18686: Add Cursors KCM icon

[Björn Feber]

GB_2 added a comment.


  I really like it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-cursors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18686

To: ndavis, #vdg, ngraham
Cc: GB_2, ngraham, abetts, kde-frameworks-devel, michaelh, bruns

D18686: Add Cursors KCM icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I think this is great!

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-cursors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18686

To: ndavis, #vdg, ngraham
Cc: ngraham, abetts, kde-frameworks-devel, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Nathaniel Graham]

ngraham added a comment.


  Yeah, the item already has a "None" label; we're just trying to figure out 
what the icon should be. I think an X is okay choice for suggesting "there's 
nothing here".

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Björn Feber]

GB_2 added a comment.


  In D18675#404104 , @abetts wrote:
  
  > > Seems like a bit too much. BTW, this is the Plasma login splash and there 
is no text output when disabled.
  >
  > I see, maybe the label could be more descriptive then? Use something like 
"Black", or "No splash"?
  
  
  I think "None" is fine, because you already know that you are selecting the 
splash screen and if it was specific to the splash this would be a bit more 
complicated to change and this wouldn't be for all KCMs that can have a "None" 
item then.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Andres Betts]

abetts added a comment.


  > Seems like a bit too much. BTW, this is the Plasma login splash and there 
is no text output when disabled.
  
  I see, maybe the label could be more descriptive then? Use something like 
"Black", or "No splash"?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Björn Feber]

GB_2 added a comment.


  In D18675#404097 , @abetts wrote:
  
  > In D18675#404090 , @ngraham 
wrote:
  >
  > > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  >
  >
  > I agree with you here. It may seem that you are selecting something 
different. What about a stop sign and behind it a representation of the splash 
screen. So as to signal that you are not wanting a splash screen. The concept 
is great though! Many people care little for the splash screen and prefer to 
see the booting output.
  
  
  Seems like a bit too much. BTW, this is the Plasma login splash that shows no 
text output.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Björn Feber]

GB_2 added a comment.


  In D18675#404090 , @ngraham wrote:
  
  > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  
  
  Yeah, it's the only X icon, I think we need to make a copy of it that is not 
red in `breeze-icons` (we could call it `edit-none` or something).

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18675: Use different "None" item icon in grid view KCMs

[Andres Betts]

abetts added a comment.


  In D18675#404090 , @ngraham wrote:
  
  > Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.
  
  
  I agree with you here. It may seem that you are selecting something 
different. What about a stop sign and behind it a representation of the splash 
screen. So as to signal that you are not wanting a splash screen. The concept 
is great though! Many people care little for the splash screen and prefer to 
see the booting output.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18686: Add Cursors KCM icon

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18686

To: ndavis, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D18675: Use different "None" item icon in grid view KCMs

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I like the use of an X here, but I'm not sure the red color is 
appropriate. Nothing is being removed, deleted, or destroyed.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18675

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D18686: Add Cursors KCM icon

[Noah Davis]

ndavis updated this revision to Diff 50746.
ndavis added a comment.


  Fix Breeze Dark

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18686?vs=50745=50746

BRANCH
  preferences-cursors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18686

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-cursors.svg
  icons/preferences/32/preferences-desktop-cursors.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18686: Add Cursors KCM icon

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18686

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18686: Add Cursors KCM icon

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-cursors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18686

AFFECTED FILES
  icons-dark/preferences/32/cursors.svg
  icons/preferences/32/preferences-desktop-cursors.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:25:19 +
 Build duration:
1 hr 31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

D18662: Add and rename some YaST icons and symlinks

[Noah Davis]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:cff0b5794d82: Add and rename some YaST icons and symlinks 
(authored by ndavis).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18662?vs=50739=50740#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18662?vs=50739=50740

REVISION DETAIL
  https://phabricator.kde.org/D18662

AFFECTED FILES
  icons-dark/apps/48/yast-control-center.svg
  icons-dark/preferences/32/yast-addon-extension.svg
  icons-dark/preferences/32/yast-hardware-group.svg
  icons-dark/preferences/32/yast-hardware.svg
  icons-dark/preferences/32/yast-ldap-kerberos.svg
  icons-dark/preferences/32/yast-ldap.svg
  icons-dark/preferences/32/yast-misc-group.svg
  icons-dark/preferences/32/yast-misc.svg
  icons-dark/preferences/32/yast-network-group.svg
  icons-dark/preferences/32/yast-network.svg
  icons-dark/preferences/32/yast-security-group.svg
  icons-dark/preferences/32/yast-software-group.svg
  icons-dark/preferences/32/yast-software.svg
  icons-dark/preferences/32/yast-support-group.svg
  icons-dark/preferences/32/yast-system-group.svg
  icons-dark/preferences/32/yast-system.svg
  icons-dark/preferences/32/yast-update-online-configuration.svg
  icons-dark/preferences/32/yast-update-online.svg
  icons-dark/preferences/32/yast-vm-group.svg
  icons-dark/preferences/32/yast-vm.svg
  icons/apps/48/yast-control-center.svg
  icons/preferences/32/yast-addon-extension.svg
  icons/preferences/32/yast-hardware-group.svg
  icons/preferences/32/yast-hardware.svg
  icons/preferences/32/yast-ldap-kerberos.svg
  icons/preferences/32/yast-ldap.svg
  icons/preferences/32/yast-misc-group.svg
  icons/preferences/32/yast-misc.svg
  icons/preferences/32/yast-network-group.svg
  icons/preferences/32/yast-network.svg
  icons/preferences/32/yast-security-group.svg
  icons/preferences/32/yast-software-group.svg
  icons/preferences/32/yast-software.svg
  icons/preferences/32/yast-support-group.svg
  icons/preferences/32/yast-system-group.svg
  icons/preferences/32/yast-system.svg
  icons/preferences/32/yast-update-online-configuration.svg
  icons/preferences/32/yast-update-online.svg
  icons/preferences/32/yast-vm-group.svg
  icons/preferences/32/yast-vm.svg

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icons and symlinks

[Noah Davis]

ndavis retitled this revision from "Add and rename some YaST icon symlinks" to 
"Add and rename some YaST icons and symlinks".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis updated this revision to Diff 50739.
ndavis added a comment.


  Update commit message

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18662?vs=50694=50739

BRANCH
  more-yast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18662

AFFECTED FILES
  icons-dark/apps/48/yast-control-center.svg
  icons-dark/preferences/32/yast-addon-extension.svg
  icons-dark/preferences/32/yast-hardware-group.svg
  icons-dark/preferences/32/yast-hardware.svg
  icons-dark/preferences/32/yast-ldap-kerberos.svg
  icons-dark/preferences/32/yast-ldap.svg
  icons-dark/preferences/32/yast-misc-group.svg
  icons-dark/preferences/32/yast-misc.svg
  icons-dark/preferences/32/yast-network-group.svg
  icons-dark/preferences/32/yast-network.svg
  icons-dark/preferences/32/yast-security-group.svg
  icons-dark/preferences/32/yast-software-group.svg
  icons-dark/preferences/32/yast-software.svg
  icons-dark/preferences/32/yast-support-group.svg
  icons-dark/preferences/32/yast-system-group.svg
  icons-dark/preferences/32/yast-system.svg
  icons-dark/preferences/32/yast-update-online-configuration.svg
  icons-dark/preferences/32/yast-update-online.svg
  icons-dark/preferences/32/yast-vm-group.svg
  icons-dark/preferences/32/yast-vm.svg
  icons/apps/48/yast-control-center.svg
  icons/preferences/32/yast-addon-extension.svg
  icons/preferences/32/yast-hardware-group.svg
  icons/preferences/32/yast-hardware.svg
  icons/preferences/32/yast-ldap-kerberos.svg
  icons/preferences/32/yast-ldap.svg
  icons/preferences/32/yast-misc-group.svg
  icons/preferences/32/yast-misc.svg
  icons/preferences/32/yast-network-group.svg
  icons/preferences/32/yast-network.svg
  icons/preferences/32/yast-security-group.svg
  icons/preferences/32/yast-software-group.svg
  icons/preferences/32/yast-software.svg
  icons/preferences/32/yast-support-group.svg
  icons/preferences/32/yast-system-group.svg
  icons/preferences/32/yast-system.svg
  icons/preferences/32/yast-update-online-configuration.svg
  icons/preferences/32/yast-update-online.svg
  icons/preferences/32/yast-vm-group.svg
  icons/preferences/32/yast-vm.svg

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:44 +
 Build duration:
1 hr 21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7178/9546)55%
(3543/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3044/3136)53%
(1291/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3340/4662)61%
(1947/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis added a comment.


  I think I'll just land this. It fixes a bug caused by my misunderstanding of 
how YaST currently works.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:23:26 +
 Build duration:
1 hr 15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Antonio Rojas]

arojas added a comment.


  You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to  '-Xclang 
-add-plugin -Xclang clazy' for the plugin to be actually loaded.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:20:42 +
 Build duration:
1 hr 8 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:21:05 +
 Build duration:
1 hr 6 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21603/45963)38%
(13040/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(753/9698)6%
(319/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:21:40 +
 Build duration:
1 hr 6 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3146/3848)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1175/1563)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:50:08 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: CI for prison: missing dependency

[Ben Cooksley]

On Sun, Feb 3, 2019 at 12:02 AM David Faure  wrote:
>
> On samedi 2 février 2019 11:20:28 CET CI System wrote:
> > -- The following REQUIRED packages have not been found:
> >
> > * QRencode, The QRencode library,
>
> Can this be added to the CI?

Unfortunately Android doesn't use the standard mechanisms for this - I
think we have to compile stuff ourselves.
Any idea on this Aleix?

Cheers,
Ben

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/12/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:25:19 +
 Build duration:
47 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3602/13324)18%
(1813/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:25:42 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:25:19 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> KDECMakeSettings.cmake:296
>  if(ENABLE_CLAZY)
> -set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang 
> -load -Xclang ClangLazy${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin 
> -Xclang clang-lazy")
> +set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang 
> -load -Xclang ClazyPlugin${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin 
> -Xclang clang-lazy")
>  endif()

You can use

  find_library(CLAZY ClazyPlugin${CMAKE_SHARED_LIBRARY_SUFFIX})
  if(NOT CLAZY)

  else

  endif()

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:44 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/13/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:32 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/5/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:24:44 +
 Build duration:
34 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7189/9546)56%
(3553/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3051/3136)53%
(1294/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3344/4662)61%
(1954/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/8/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:24:04 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:23:48 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/6/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:23:26 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Note: this will break with older clazy versions. I'm not sure how to prevent 
that.
  One could argue that a developer interested in clazy should probably run the 
latest version anyway...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:23:26 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: apol, smartins.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  clazy 1.5 renamed its plugin from from ClangLazy.so to ClazyPlugin.so

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18680

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: elvisangelaccio, apol, smartins
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:22:31 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/10/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:21:40 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3146/3848)48%
(4641/9713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(852/871)49%
(1855/3769)src75%
(18/24)75%
(18/24)80%
(1061/1329)45%
(478/1060)src.extractors100%
(13/13)100%
(13/13)75%
(1175/1563)47%
(2237/4723)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/9/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:21:05 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21603/45963)38%
(13040/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(753/9698)6%
(319/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » baloo » kf5-qt5 WindowsMSVCQt5.11 - Build # 102 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20WindowsMSVCQt5.11/102/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 02 Feb 2019 17:19:19 +
 Build duration:
22 min and counting
   CONSOLE OUTPUT
  [...truncated 234 lines...]VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\'VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.14.26428\'VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\VC\Redist\MSVC\14.14.26405\'VCTOOLSVERSION= '14.14.26428'VISUALSTUDIOVERSION   = '15.0'VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'VS150COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\Tools\'VSCMD_ARG_APP_PLAT= 'Desktop'VSCMD_ARG_HOST_ARCH   = 'x64'VSCMD_ARG_TGT_ARCH= 'x64'VSCMD_VER = '15.7.3'VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\'WINDIR= 'C:\WINDOWS'WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17134.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17134.0'WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'WINDOWSSDKLIBVERSION  = '10.0.17134.0\'WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17134.0\'WINDOWSSDKVERSION = '10.0.17134.0\'WORKSPACE = 'C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11'__DOTNET_ADD_64BIT= '1'__DOTNET_PREFERRED_BITNESS = '64'__VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\baloo;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils'QT_PLUGIN_PATH= 'C:\CI\Software Installs\baloo\lib\plugins;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\lib\qca-qt5'QML2_IMPORT_PATH  = 'C:\CI\Software Installs\baloo\lib\qml'XDG_DATA_DIRS = 'C:\CI\Software Installs\baloo\share;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\share;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils\share'XDG_CONFIG_DIRS   = 'C:\CI\Software Installs\baloo\etc/xdg'PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\dev-utils\lib\pkgconfig'QMAKEFEATURES = 'C:\Craft\CI-Qt511\windows-msvc2017_64-cl-debug\mkspecs/features'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/baloo/" -G "NMake Makefiles JOM" -DBUILD_QCH=TRUE "C:\CI\workspace\Frameworks\baloo\kf5-qt5 WindowsMSVCQt5.11"-- The C compiler identification is MSVC 19.14.26430.0-- The CXX compiler identification is MSVC 19.14.26430.0-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx64/x64/cl.exe -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Tried to enable sanitizers (-DECM_ENABLE_SANITIZERS=address), but compiler (MSVC) does not have sanitizer support-- Found KF5CoreAddons: C:/CI/Software Installs/baloo/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.55.0") -- Found KF5Config: C:/CI/Software 

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/8/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 02 Feb 2019 17:20:42 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/11/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:21:05 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:18:06 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33026/48362)51%
(15896/31078)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4453/4754)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1563/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)67%
(721/1069)57%
(266/465)src.search100%
(7/7)100%
 

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/7/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:21:15 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 17:19:19 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(113/168)67%
(113/168)60%
(5696/9487)43%
(2227/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file66%
(25/38)66%
(25/38)51%
(862/1677)42%
(443/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:20:42 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:20:32 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestFailed: projectroot.autotests.kconfigcore_test_kconf_updateName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 7 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/7/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 02 Feb 2019 17:25:25 +
 Build duration:
2 min 37 sec and counting
   CONSOLE OUTPUT
  [...truncated 247 lines...]QMAKEFEATURES = '/opt/Qt/5.11.3/android_armv7/mkspecs/features'NODE_NAME = 'Docker Swarm-1c65afacfad4'WORKSPACE = '/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11'JOB_BASE_NAME = 'kf5-qt5 AndroidQt5.11'HUDSON_URL= 'https://build.kde.org/'BUILD_NUMBER  = '7'QT_PATH   = '/opt/Qt'ANDROID_NDK_ROOT  = '/opt/android-ndk'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/display/redirect'BUILD_ID  = '7'NODE_LABELS   = 'AndroidQt5.11 Docker Swarm-1c65afacfad4'PKG_CONFIG_PATH   = '/opt/Qt/5.11.3/android_armv7/lib/pkgconfig:/opt/kdeandroid-deps/lib/pkgconfig'QT_ANDROID= '/opt/Qt/5.11.3/android_armv7'QT_SELECT = 'qt5'ANDROID_HOME  = '/opt/android-sdk'CMAKE_PREFIX_PATH = '/home/user/install-prefix:/opt/Qt/5.11.3/android_armv7:/opt/kdeandroid-deps'ANDROID_NDK_TOOLS_PREFIX  = 'arm-linux-androideabi'ANDROID_NDK_PLATFORM  = 'android-21'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.11.3/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Targeting API '14' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Selected GCC toolchain 'arm-linux-androideabi-4.9'-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could NOT find QRencode (missing: QRencode_LIBRARIES QRencode_INCLUDE_DIRS) -- Could NOT find Dmtx (missing: Dmtx_LIBRARIES Dmtx_INCLUDE_DIRS) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * Qt5Network (required version >= 5.11.3) * Qt5Qml (required version >= 5.11.3) * Qt5Quick-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Core * Qt5Gui * Qt5Test * Qt5Widgets * Qt5 (required version >= 5.10.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * Dmtx, The Datamatrix library, -- The following REQUIRED packages have not been found: * QRencode, The QRencode library, CMake Error at /opt/cmake/share/cmake-3.12/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:93 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/build/CMakeFiles/CMakeOutput.log".See also "/home/user/workspace/Frameworks/prison/kf5-qt5 

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/17/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Sat, 02 Feb 2019 17:23:15 +
 Build duration:
5 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 216 lines...]   Required to build text to speech notification support * PkgConfig * Qt5Test (required version >= 5.10.0)-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Gui (required version >= 5.11.3) * Qt5Widgets * Qt5AndroidExtras * Gradle * Qt5 (required version >= 5.10.0) * Qt5Core * KF5WindowSystem (required version >= 5.55.0) * KF5Config (required version >= 5.55.0) * KF5Codecs (required version >= 5.55.0) * KF5CoreAddons (required version >= 5.55.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * X11 * Canberra, Library for generating event sounds,Needed to build audio notification support * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library   Needed to build audio notification support when Canberra isn't available * dbusmenu-qt5, DBusMenuQt,Support for notification area menus via the DBusMenu protocol-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project knotifications --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target gradleScanning dependencies of target KF5Notifications_autogen[  5%] Automatic MOC for target KF5Notifications[ 10%] Generating gradle/gradlew[ 10%] Built target gradleScanning dependencies of target knotifications_aar[ 15%] Generating gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar[ 15%] Built target KF5Notifications_autogen[ 20%] Automatic RCC for knotifications.qrcScanning dependencies of target KF5Notifications[ 25%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotification.cpp.oStarting a Gradle Daemon, 1 incompatible and 1 stopped Daemons could not be reused, use --status for details[ 30%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotificationmanager.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5Notifications.dir/kpassivepopup.cpp.oFAILURE: Build failed with an exception.* Where:Build file '/home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.11/build/src/android/gradle_build/KF5Notifications/build.gradle' line: 3* What went wrong:A problem occurred evaluating root project 'KF5Notifications'.> Could not find method google() for arguments [] on repository container of type org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.* Try:Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.BUILD FAILEDTotal time: 15.897 secssrc/android/CMakeFiles/knotifications_aar.dir/build.make:65: recipe for target 'src/android/gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar' failedmake[2]: *** [src/android/gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar] Error 1CMakeFiles/Makefile2:276: recipe for target 'src/android/CMakeFiles/knotifications_aar.dir/all' failedmake[1]: *** [src/android/CMakeFiles/knotifications_aar.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[ 40%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotifyconfig.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotificationplugin.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybypopupgrowl.cpp.o[ 55%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybyexecute.cpp.o[ 60%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybylogfile.cpp.o[ 65%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybytaskbar.cpp.o[ 70%] Building CXX object src/CMakeFiles/KF5Notifications.dir/ECMQmLoader-knotifications5_qt.cpp.o[ 75%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybyandroid.cpp.o[ 80%] Building CXX object src/CMakeFiles/KF5Notifications.dir/debug_p.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybytts.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5Notifications.dir/KF5Notifications_autogen/mocs_compilation.cpp.o[ 95%] Building CXX object src/CMakeFiles/KF5Notifications.dir/KF5Notifications_autogen/EWIEGA46WW/qrc_knotifications.cpp.o[100%] Linking CXX shared library ../bin/libKF5Notifications.so[100%] Built target KF5NotificationsMakefile:140: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script 

D18676: Improve keyboard controls of the checksum widget

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:04082f3c2ce1: Improve keyboard controls of the checksum 
widget (authored by cfarrell, committed by elvisangelaccio).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18676?vs=50725=50733

REVISION DETAIL
  https://phabricator.kde.org/D18676

AFFECTED FILES
  src/widgets/checksumswidget.ui

To: cfarrell, #vdg, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 17:18:06 +
 Build duration:
5 min 43 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 60 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D18676: Improve keyboard controls of the checksum widget

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18676

To: cfarrell, #vdg, elvisangelaccio
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:19c936621729: Improve the Notfication Bell Icon by using 
the KAlarm design (authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18533?vs=50703=50727

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26, #vdg, ngraham
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I love it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg, ngraham
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Nathaniel Graham]

ngraham added a comment.


  Yes, I think people are correct that these modal dialogs are annoying. I'm 
working on something to show the errors and warnings inline at the moment when 
you're typing the file/folder name in the first place.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18676: Improve keyboard controls of the checksum widget

[Connor Farrell]

cfarrell created this revision.
cfarrell added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfarrell requested review of this revision.

REVISION SUMMARY
  Previously when using the tab key to navigate the widget,
  it would select the calculate buttons in the order:
  SHA1->SHA256->MD5
  This patch moves MD5 to be the first selection to match the visuals

TEST PLAN
  Manual testing on several files.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18676

AFFECTED FILES
  src/widgets/checksumswidget.ui

To: cfarrell, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18675: Use different "None" item icon in grid view KCMs

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Changes the icon for the "None" item in grid view KCMs (present in the Splash 
Screen KCM) to differentiate it from other items that have no preview.
  F6583130: Grid View KCM None Item Icon.png 


TEST PLAN
  Open the Splash Screen KCM.

REPOSITORY
  R296 KDeclarative

BRANCH
  use-different-icon-for-none-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18675

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D18673: Add symlinks for flatpak

[Denis Karpovskii]

GeeXT created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GeeXT requested review of this revision.

REVISION SUMMARY
  This patch creates symlinks (for every application I've
  found on Flathub and for which Breeze icon theme has an icon) to let
  flatpak-provided .desktop files point to breeze-provided icons.
  
  Flatpak-exported .desktop files use different icon names
  (e. g. org.kde.okular instead of just okular) and because of that
  flatpak-provided .desktop files show in menus and panels with their
  default icons instead of breeze-provided icons even when Breeze icon
  theme is used.

TEST PLAN
  This can be tested by applying the patch and installing the icon
  theme into ~/.local/share/icons. Reboot/relogin may be necessary.
  Then to see the changes you can install org.gimp.GIMP from flathub.
  Without the patch GIMP uses its default icon in application
  menus/panels/docks/etc. With the patch it will use the
  breeze-provided icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  flatpak-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18673

AFFECTED FILES
  icons-dark/apps/16/com.github.bajoja.indicator-kdeconnect.svg
  icons-dark/apps/22/com.github.bajoja.indicator-kdeconnect.svg
  icons-dark/apps/22/org.kde.elisa.svg
  icons-dark/apps/22/org.videolan.VLC.svg
  icons-dark/apps/32/org.videolan.VLC.svg
  icons-dark/apps/48/com.elsevier.MendeleyDesktop.svg
  icons-dark/apps/48/com.google.AndroidStudio.svg
  icons-dark/apps/48/com.sublimetext.three.svg
  icons-dark/apps/48/com.syntevo.SmartGit.svg
  icons-dark/apps/48/com.valvesoftware.Steam.svg
  icons-dark/apps/48/com.viber.Viber.svg
  icons-dark/apps/48/cx.ring.Ring.svg
  icons-dark/apps/48/fr.free.Homebank.svg
  icons-dark/apps/48/fr.handbrake.ghb.svg
  icons-dark/apps/48/io.atom.Atom.svg
  icons-dark/apps/48/io.brackets.Brackets.svg
  icons-dark/apps/48/io.github.Fontforge.svg
  icons-dark/apps/48/net.scribus.Scribus.svg
  icons-dark/apps/48/nl.openoffice.bluefish.svg
  icons-dark/apps/48/org.audacityteam.Audacity.svg
  icons-dark/apps/48/org.blender.Blender.svg
  icons-dark/apps/48/org.clementine_player.Clementine.svg
  icons-dark/apps/48/org.codeblocks.codeblocks.svg
  icons-dark/apps/48/org.darktable.Darktable.svg
  icons-dark/apps/48/org.filezillaproject.Filezilla.svg
  icons-dark/apps/48/org.gimp.GIMP.svg
  icons-dark/apps/48/org.gnu.emacs.svg
  icons-dark/apps/48/org.inkscape.Inkscape.svg
  icons-dark/apps/48/org.kde.elisa.svg
  icons-dark/apps/48/org.kde.kapman.svg
  icons-dark/apps/48/org.kde.katomic.svg
  icons-dark/apps/48/org.kde.kblocks.svg
  icons-dark/apps/48/org.kde.kdenlive.svg
  icons-dark/apps/48/org.kde.kdiamond.svg
  icons-dark/apps/48/org.kde.kjumpingcube.svg
  icons-dark/apps/48/org.kde.klines.svg
  icons-dark/apps/48/org.kde.kolourpaint.svg
  icons-dark/apps/48/org.kde.kontact.svg
  icons-dark/apps/48/org.kde.okular.svg
  icons-dark/apps/48/org.kde.skrooge.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-base.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-calc.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-draw.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-impress.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-main.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-math.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-startcenter.svg
  icons-dark/apps/48/org.libreoffice.LibreOffice-writer.svg
  icons-dark/apps/48/org.octave.Octave.svg
  icons-dark/apps/48/org.qbittorrent.qBittorrent.svg
  icons-dark/apps/48/org.qownnotes.QOwnNotes.svg
  icons-dark/apps/48/org.quassel_irc.QuasselClient.svg
  icons-dark/apps/48/org.synfig.SynfigStudio.svg
  icons-dark/apps/48/org.telegram.desktop.svg
  icons-dark/apps/48/org.tordini.flavio.Minitube.svg
  icons-dark/apps/48/org.videolan.VLC.svg
  icons/apps/16/com.github.bajoja.indicator-kdeconnect.svg
  icons/apps/22/com.github.bajoja.indicator-kdeconnect.svg
  icons/apps/22/org.kde.elisa.svg
  icons/apps/22/org.videolan.VLC.svg
  icons/apps/32/org.videolan.VLC.svg
  icons/apps/48/com.elsevier.MendeleyDesktop.svg
  icons/apps/48/com.google.AndroidStudio.svg
  icons/apps/48/com.sublimetext.three.svg
  icons/apps/48/com.syntevo.SmartGit.svg
  icons/apps/48/com.valvesoftware.Steam.svg
  icons/apps/48/com.viber.Viber.svg
  icons/apps/48/cx.ring.Ring.svg
  icons/apps/48/fr.free.Homebank.svg
  icons/apps/48/fr.handbrake.ghb.svg
  icons/apps/48/io.atom.Atom.svg
  icons/apps/48/io.brackets.Brackets.svg
  icons/apps/48/io.github.Fontforge.svg
  icons/apps/48/net.scribus.Scribus.svg
  icons/apps/48/nl.openoffice.bluefish.svg
  icons/apps/48/org.audacityteam.Audacity.svg
  icons/apps/48/org.blender.Blender.svg
  icons/apps/48/org.clementine_player.Clementine.svg
  icons/apps/48/org.codeblocks.codeblocks.svg
  icons/apps/48/org.darktable.Darktable.svg
  icons/apps/48/org.filezillaproject.Filezilla.svg
  icons/apps/48/org.gimp.GIMP.svg
  icons/apps/48/org.gnu.emacs.svg
  

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Shubham]

shubham added a comment.


  @ngraham I think this patch is behaving exactly it should be, are you trying 
for a fix so that these warnings are not used?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18384: Allow creating directory named '~' and throw a warning before creating it.

[Nathaniel Graham]

ngraham added a comment.


  I'm working on an alternative user interface for this. Stay tuned!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18384

To: shubham, ngraham
Cc: emateli, pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18563: Don't create directory tree when a new folder has a '/' in the name

[Nathaniel Graham]

ngraham added a comment.


  I'm working on an alternative user interface for this feature. Stay tuned!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D17932: Improvements to completion

[Dominik Haumann]

dhaumann added a comment.


  Well, giving it a try and merge should be postponed ubtil tomorrow: dfaure 
tags today, so we would then have 1 month of internal testing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: dhaumann, apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, 
kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, head7, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 15:24:41 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33051/48364)51%
(15907/31078)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4461/4756)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1774/3109)43%
(1162/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1873/3151)47%
(1566/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
 

D18638: Avoid using trimmed method

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> highlighter.cpp:299
>  
> +static bool hasNotEmptyText(const QString )
> +{

how about hasSpaces?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18638

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 02 Feb 2019 15:24:41 +
 Build duration:
4 min 42 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D17932: Improvements to completion

[Christoph Cullmann]

cullmann added a comment.


  Should we give this some try and merge it?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, ngraham, bruns, demsking, head7, sars, dhaumann

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f2e7a22be5e5: KateSpellCheckDialog: Remove action 
Spellcheck Selection (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18663?vs=50700=50721

REVISION DETAIL
  https://phabricator.kde.org/D18663

AFFECTED FILES
  src/spellcheck/spellcheckdialog.cpp
  src/spellcheck/spellcheckdialog.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

D18116: Don't show document load trouble twice

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Just to be sure:
  
  We can apply D18117  and don't need to 
change here anything or?

REVISION DETAIL
  https://phabricator.kde.org/D18116

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: cullmann, #ktexteditor, #vdg, loh.tar
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17437: SearchBar: Avoid malfunction with very large files

[Christoph Cullmann]

cullmann commandeered this revision.
cullmann edited reviewers, added: loh.tar; removed: cullmann.
cullmann added a comment.


  We have cancel now ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17437

To: cullmann, #ktexteditor, #vdg, loh.tar
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D18662: Add and rename some YaST icon symlinks

[Noah Davis]

ndavis retitled this revision from "Add and rename some YaST icon symlinks 
because of Qt bugs" to "Add and rename some YaST icon symlinks".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18516: Fix end of folding region in rules with lookAhead=true

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:941f17e1a979: Fix end of folding region in rules with 
lookAhead=true (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18516?vs=50226=50718

REVISION DETAIL
  https://phabricator.kde.org/D18516

AFFECTED FILES
  autotests/folding/Kconfig.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.sh.fold
  autotests/folding/highlight.y.fold
  autotests/folding/light52_muldiv.vhdl.fold
  autotests/folding/light52_tb.vhdl.fold
  autotests/folding/preprocessor-bug363280.cpp.fold
  autotests/folding/test.diff.fold
  autotests/folding/test.mss.fold
  autotests/folding/test.prolog.fold
  autotests/folding/test.yaml.fold
  src/lib/abstracthighlighter.cpp

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18516: Fix end of folding region in rules with lookAhead=true

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think that lookAhead rules don't publish their length sounds like a sane 
improvement.
  
  All in all, I think the folding still has some general issues in how we 
handle it.
  
  e.g. I have ATM "interesting" highlighted areas for the folding of doxygen 
comments.
  
  I don't think we need to have an extra bool, one might later internally 
handle it differently with extra attributes in the hl files, like a 
lookAheadEndRegion as proposed, if we really don't like the general change.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-region-lookahead

REVISION DETAIL
  https://phabricator.kde.org/D18516

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Stasiek Michalski]

hellcp added a comment.


  It's not really a workaround, all of those icons are valid when  it comes to 
YaST, however previous batch of YaST icons into Breeze was build on idea that 
icon `xyz-abc.svg` will fallback to `xyz.svg` inside the same icon theme. In 
QIcon::fromTheme that is the case IF icon `xyz-abc.svg` does not exist in 
hicolor or any other fallback theme.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

[Christoph Cullmann]

cullmann added a comment.


  ;=) given ::spellcheck() has the same magic, I don't think we really need to 
rename the function.
  And spellcheckSelectionOrFromCursor is a bit strange, too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18663

To: loh.tar, #ktexteditor
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars

D18662: Add and rename some YaST icon symlinks because of Qt bugs

[Noah Davis]

ndavis added a subscriber: hellcp.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18662

To: ndavis, #vdg
Cc: hellcp, fvogt, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:21:33 +
 Build duration:
1 hr 26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:20:02 +
 Build duration:
1 hr 21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(255/290)88%
(255/290)68%
(33058/48369)51%
(15906/31074)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4461/4756)49%
(1703/3462)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1212/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/791)0%
(0/196)src.document100%
(4/4)100%
(4/4)59%
(1873/3151)47%
(1566/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:20:47 +
 Build duration:
1 hr 20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5WindowSystem_compat_report.htmllogs/KF5WindowSystem/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7179/9546)55%
(3545/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3045/3136)53%
(1293/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3340/4662)61%
(1947/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 02 Feb 2019 13:15:40 +
 Build duration:
1 hr 20 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21603/45963)38%
(13040/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(753/9698)6%
(319/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)