D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  In D18834#407534 , @rooty wrote:
  
  > You could make it smaller? It looks fine to me at the corners, it's the 
actual sidebar that's a little thick.
  >
  > I still like this diff though, I think that the master's too 
stippled/dotted.
  
  
  I don't think I can change anything about the size in this patch. I think the 
sizes are determined elsewhere. Here's the real thickness of the portion of the 
image that is used for the top screen edge: F6599583: 
Screenshot_20190207_214454.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Krešimir Čohar]

rooty added a comment.


  You could make it smaller? It looks fine to me at the corners, it's the 
actual sidebar that's a little thick.
  
  I still like this diff though, I think that the master's too stippled/dotted.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  I suppose it's this, but it's somehow even worse with this patch: 
https://bugs.kde.org/show_bug.cgi?id=337712
  
  I had a look through the Screen Edge effect code and while I'm no expert, I 
didn't see anything that would obviously make the corners large.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Krešimir Čohar]

rooty added a comment.


  In D18834#407529 , @ndavis wrote:
  
  > For some reason, this version looks much larger in the corners. Was there a 
change to how the screen edge effect works? I didn't change the size of the 
corners in the SVGZ.
  
  
  F6599457: image.png  This is the old 
version (kind of strange)
  F6599459: image.png  and this is yours, 
much better in my opinion...

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  For some reason, this version looks much larger in the corners. Was there a 
change to how the screen edge effect works? I didn't change the size of the 
corners in the SVGZ.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Krešimir Čohar]

rooty added a comment.


  Sure thing. This seems straightforward enough to me though

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  In D18834#407524 , @rooty wrote:
  
  > Wait I can do that? I didn't know I could do that :D
  
  
  Yes, but I should have said make sure you've given patches you want to 
approve a good look first. Use `arc patch D` so you can look 
at it on your own hard drive unless you're confident that no mistakes were made 
by looking at the code on Phabricator.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Krešimir Čohar]

rooty accepted this revision.
rooty added a comment.
This revision is now accepted and ready to land.


  Wait I can do that? I didn't know I could do that :D

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg, rooty
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  If you like it, don't be afraid to hit "Approve" ;)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Krešimir Čohar]

rooty added a comment.


  In D18834#407518 , @rapiteanu 
wrote:
  
  > This looks really good!
  >  With this the bug 391343 will be fixed.
  
  
  I like it too, +1.
  Can you also CC the BUG so it gets closed?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rooty, rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Viorel-Cătălin Răpițeanu]

rapiteanu added a comment.


  This looks really good!
  With this the bug 391343 will be fixed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18835: Handle as container element in SVG

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
   is a container element as , so handle both the same.
  
  Allows to index the content of e.g.
  https://suchanek.name/programs/powerline/intro/0.svg

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18835

AFFECTED FILES
  autotests/samplefiles/test_with_container.svg
  autotests/xmlextractortest.cpp
  autotests/xmlextractortest.h
  src/extractors/xmlextractor.cpp

To: bruns, #baloo, #frameworks, astippich, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis added a comment.


  JFYI, the whole embedded stylesheet thing doesn't work on gradients, so it 
doesn't matter if colors are hardcoded.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18834

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18834: Change glowbar.svgz to smoother style

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The old style was weird. When the screen edge feature was enabled for the 
sides of screens, it looked like a bunch of dots smooshed together. Now it's 
one smooth bar.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-glowbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18834

AFFECTED FILES
  src/desktoptheme/breeze/widgets/glowbar.svgz

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger added a dependent revision: D18570: EGLStream DRM Backend Initial 
Implementation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger removed a dependency: D18570: EGLStream DRM Backend Initial 
Implementation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18833: Get rid of mostly unused filePathToStat overload

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  It is only used in one place to retrieve the device ID, which can also
  be retrieved from the fileId.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18833

AFFECTED FILES
  src/engine/experimental/databasesanitizer.cpp
  src/engine/idutils.h

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18822: Fix Windows build [hopefully]

[Albert Astals Cid]

aacid added a subscriber: albertvaka.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18822

To: aacid
Cc: albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, 
bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 07 Feb 2019 23:10:32 +
 Build duration:
7 min 29 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
  

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 07 Feb 2019 23:01:18 +
 Build duration:
9 min 13 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9485)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/944)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
  

D18828: [balooctl] Actually abort a malformed command instead of just saying so

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a040c71e353d: [balooctl] Actually abort a malformed 
command instead of just saying so (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18828?vs=51130=51141

REVISION DETAIL
  https://phabricator.kde.org/D18828

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18827: [balooctl] Add missing help for "config set", normalize string

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3a31a7ed0e29: [balooctl] Add missing help for 
config set, normalize string (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18827?vs=51129=51139

REVISION DETAIL
  https://phabricator.kde.org/D18827

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18825: Replace recursive isDirHidden with iterative one, allow const argument

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:38698b1a4c9e: Replace recursive isDirHidden with 
iterative one, allow const argument (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18825?vs=51126=51138

REVISION DETAIL
  https://phabricator.kde.org/D18825

AFFECTED FILES
  src/file/fileindexerconfig.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger added a dependency: D18570: EGLStream DRM Backend Initial 
Implementation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

[Elvis Angelaccio]

elvisangelaccio added a comment.


  Wait, do we need to add this workaround to every popup menu around? What 
about 3d-party apps?
  
  Can't we fix the actual bug in Qt/breeze/whatever instead?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18798

To: anemeth, #frameworks, kde-frameworks-devel, ngraham, davidedmundson
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, michaelh, bruns

D17245: Add string formatting function to property info

[Stefan Brüns]

bruns added a comment.


  `src/formatstrings.h` should be named `src/formatstrings_p.h`

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D18822: Fix Windows build [hopefully]

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looks fine to me from quick reading, everything done I would have thought of 
(whatever that is worth :P )
  +1

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18822

To: aacid
Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18827: [balooctl] Add missing help for "config set", normalize string

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18827

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18819: Use content to determine mime type

[Nathaniel Graham]

ngraham added a comment.


  Thanks, +1 shipit!

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18819

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18830: Handle folders matching substrings of included/excluded folders correctly

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  FileIndexerConfig::shouldFolderBeIndexe(...) calls folderInList to
  determine if the config should be included or excluded.
  
  For a config:
  [0] include: /foo
  [1] exclude: /foo/bar
  
  the folder "/foo/barbaz" would be erroneously excluded, as
  folders[1].startsWith(folder) is true, i.e. the exclude entry would be
  used, although folders[0] is the correct match (folders are matched back
  to front).
  
  This can be avoided by normalizing the config entries to always end
  with a trailing slash.
  
  For the config itself this had been handled explicitly, but is no longer
  needed.
  
  Depends on D18829 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18830

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

[Stefan Brüns]

bruns added a dependent revision: D18830: Handle folders matching substrings of 
included/excluded folders correctly.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  A directory can be added multiple times to the config by just adding a
  trailing slash to it, as the config removes any trailing slashes before
  storing it, and the `contains(path)` will not match.
  
  Normalize the path to the same format as used by the config and use it
  for both adding and removing it.
  
  While using it for removal is not necessary, it allows to use both
  variants and matches the "add" behavior, where both variants have the
  same effect.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18829

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18827: [balooctl] Add missing help for "config set", normalize string

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The "contentIndexing" command was not listed for "balooctl config set",
  although valid.
  Change the help string to match the remaining commands, remove trailing
  full stop and capitalize "Baloo".

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18827

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18828: [balooctl] Actually abort a malformed command instead of just saying so

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  A single directory entry can either be included or excluded, but never
  both. Reject any such attempt.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18828

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich edited the test plan for this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Rewrite the taglib extractor to use taglib's
  PropertyMap. Since this largely unifies the handling of the
  different tag formats, but not quite, a lot of code is removed.
  The resulting code is also faster. Additionally, this avoids the
  usage of a FileRef object, which fixes a potential crash due to
  a known bug in taglib.
  
  BUG: 403902

REPOSITORY
  R286 KFileMetaData

BRANCH
  rewrite_taglib_extractor

REVISION DETAIL
  https://phabricator.kde.org/D18826

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, ngraham, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18819: Use content to determine mime type

[Alexander Stippich]

astippich added a comment.


  In D18819#407360 , @ngraham wrote:
  
  > The default match mode tries both file extension and content 
; this would make it 
just do content. So I guess if they don't match, the default match mode uses 
the file extension rather than content? That seems kinda like the opposite of 
the behavior you'd want; might be worth a Qt bug report and aldo a comment in 
the code here explaining why we're doing this.
  >
  > The change itself seems sane since we're actually doing less, more correct 
work now.
  >
  > What more is needed to fix 403902?
  
  
  The file extension always has priority over the content according to docs 
.
  This is actually more a workaround for the bug (but still the right thing to 
do nevertheless), we now make sure that Baloo never calls the crashing 
extractor for the problematic files. The crash inside the extractor actually 
remains.
  I have the real fix for crash actually ready, but it is more a complete 
rewrite of the taglib extractor.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18819

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18819: Use content to determine mime type

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  The default match mode tries both file extension and content 
; this would make it 
just do content. So I guess if they don't match, the default match mode uses 
the file extension rather than content? That seems kinda like the opposite of 
the behavior you'd want; might be worth a Qt bug report and aldo a comment in 
the code here explaining why we're doing this.
  
  The change itself seems sane since we're actually doing less, more correct 
work now.
  
  What more is needed to fix 403902?

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18819

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18825: Replace recursive isDirHidden with iterative one, allow const argument

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit2

REVISION DETAIL
  https://phabricator.kde.org/D18825

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18825: Replace recursive isDirHidden with iterative one, allow const argument

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The non-unix implementation modifies its QDir argument to walk up the
  tree. Create a copy instead.
  The copy cost is amortized by no longer having to reset the dir in the
  calling code, for the unix-code it is a net win.

REPOSITORY
  R293 Baloo

BRANCH
  submit2

REVISION DETAIL
  https://phabricator.kde.org/D18825

AFFECTED FILES
  src/file/fileindexerconfig.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger created this revision.
ekurzinger added reviewers: romangg, davidedmundson, zzag, KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ekurzinger requested review of this revision.

REVISION SUMMARY
  This implements a wrapper class for the wl_eglstream_controller Wayland 
interface. It allows clients to inform the compositor when a new EGL Stream has 
been created with an Wayland surface attached as its producer. The compositor 
can then bind a GL texture as the stream's consumer allowing it access to the 
surface's buffer contents for presentation. The only client currently expected 
to make use of this interface is the NVIDIA EGL driver when running alongside a 
compositor supporting EGLStream-based buffer sharing.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

AFFECTED FILES
  src/client/protocols/wayland-eglstream-controller.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/eglstream_controller_interface.cpp
  src/server/eglstream_controller_interface.h
  src/server/eglstream_controller_interface_p.h

To: ekurzinger, romangg, davidedmundson, zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

[Albert Astals Cid]

aacid added subscribers: vonreth, kossebau.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D18822

To: aacid
Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18822

AFFECTED FILES
  autotests/BackendsManager.h
  src/BackendsManager.h
  src/CMakeLists.txt
  src/kauthaction.h
  src/kauthactionreply.h
  src/kauthexecutejob.h
  src/kauthhelpersupport.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 11 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/11/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Thu, 07 Feb 2019 17:52:08 +
 Build duration:
48 sec and counting
   CONSOLE OUTPUT
  [...truncated 248 lines...]HOSTNAME  = 'c682e978d7ed'EXECUTOR_NUMBER   = '0'SHELL = '/bin/sh'ANDROID_NDK_HOST  = 'linux-x86_64'RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/11/display/redirect?page=changes'JOB_URL   = 'https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/'ANDROID_NDK_ROOT  = '/opt/android-ndk'QMAKESPEC = 'android-g++'HUDSON_HOME   = '/home/production/data'ANDROID_NDK_TOOLCHAIN_PREFIX = 'arm-linux-androideabi'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'BUILD_DISPLAY_NAME= '#11'LD_LIBRARY_PATH   = '/opt/Qt/5.11.3/android_armv7/lib:/opt/kdeandroid-deps/lib'JENKINS_URL   = 'https://build.kde.org/'ANDROID_NDK   = '/opt/android-ndk'LANG  = 'en_US.UTF-8'ANDROID_SDK_ROOT  = '/opt/android-sdk'NODE_LABELS   = 'AndroidQt5.11 Docker Swarm-7583368caf0e'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/user/install-prefix/" -DBUILD_COVERAGE=ON -DCMAKE_TOOLCHAIN_FILE="/opt/kdeandroid-deps/share/ECM/toolchain/Android.cmake" -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ -DECM_ADDITIONAL_FIND_ROOT_PATH="/home/user/install-prefix;/opt/Qt/5.11.3/android_armv7;/opt/kdeandroid-deps"  "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11"-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Targeting API '14' with architecture 'arm', ABI 'armeabi-v7a', and processor 'armv7-a'-- You can export a target by specifying -DQTANDROID_EXPORTED_TARGET= and -DANDROID_APK_DIR=-- Android: Selected GCC toolchain 'arm-linux-androideabi-4.9'-- The C compiler identification is GNU 4.9.0-- The CXX compiler identification is GNU 4.9.0-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc-- Check for working C compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-gcc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++-- Check for working CXX compiler: /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Failed-- Could NOT find QRencode (missing: QRencode_LIBRARIES QRencode_INCLUDE_DIRS) -- Could NOT find Dmtx (missing: Dmtx_LIBRARIES Dmtx_INCLUDE_DIRS) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * Qt5Network (required version >= 5.11.3) * Qt5Qml (required version >= 5.11.3) * Qt5Quick-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Core * Qt5Gui * Qt5Test * Qt5Widgets * Qt5 (required version >= 5.10.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RECOMMENDED packages have not been found: * Dmtx, The Datamatrix library, -- The following REQUIRED packages have not been found: * QRencode, The QRencode library, CMake Error at /opt/cmake/share/cmake-3.12/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:93 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/build/CMakeFiles/CMakeOutput.log".See also "/home/user/workspace/Frameworks/prison/kf5-qt5 

D18702: Remove monochrome font preferences icon and improve font selection icon

[Nathaniel Graham]

ngraham added a comment.


  Nah, that has no effect on anything.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D18702: Remove monochrome font preferences icon and improve font selection icon

[Björn Feber]

GB_2 added a comment.


  In D18702#407259 , @ngraham wrote:
  
  > Can you improve the font selection icon in a separate patch please?
  
  
  Is it bad that the branch name is wrong then though?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 10 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/10/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Thu, 07 Feb 2019 17:42:12 +
 Build duration:
1 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 51 lines...] > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 466681ea2f678c2926a98c91e5c43e16498a52f1 # timeout=10Cloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Checking out Revision 0b444dbeefb0ea9418ff558766b5f77e13389616 (origin/master)Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 0b444dbeefb0ea9418ff558766b5f77e13389616 # timeout=10Commit message: "Move KDiff3 to Extragear per the completion of it's review."[Pipeline] checkoutNo credentials specifiedCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10Checking out Revision 5f3cd83fa8b6837f7d1277c03511b282fa23feca (origin/master)Commit message: "Update to reflect move of KDiff3 to Extragear." > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 5f3cd83fa8b6837f7d1277c03511b282fa23feca # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project prison --branchGroup kf5-qt5 --environment production --platform AndroidQt5.11 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Prepare Android Dependencies)[Pipeline] }[Pipeline] // stage[Pipeline] }groovy.lang.MissingPropertyException: No such property: DESTDIR for class: groovy.lang.Binding	at groovy.lang.Binding.getVariable(Binding.java:63)	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:264)	at org.kohsuke.groovy.sandbox.impl.Checker$6.call(Checker.java:288)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:292)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)	at WorkflowScript.run(WorkflowScript:79)	at ___cps.transform___(Native Method)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.get(PropertyishBlock.java:74)	at com.cloudbees.groovy.cps.LValueBlock$GetAdapter.receive(LValueBlock.java:30)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.fixName(PropertyishBlock.java:66)	at sun.reflect.GeneratedMethodAccessor301.invoke(Unknown Source)	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	at java.lang.reflect.Method.invoke(Method.java:498)	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)	at 

D18702: Remove monochrome font preferences icon and improve font selection icon

[Nathaniel Graham]

ngraham added a comment.


  Can you improve the font selection icon in a separate patch please?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18702

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/9/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Thu, 07 Feb 2019 17:33:58 +
 Build duration:
35 sec and counting
   CONSOLE OUTPUT
  [...truncated 51 lines...][Pipeline] checkoutNo credentials specifiedCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10Checking out Revision 0b444dbeefb0ea9418ff558766b5f77e13389616 (origin/master)Commit message: "Move KDiff3 to Extragear per the completion of it's review."[Pipeline] checkoutNo credentials specifiedCloning the remote Git repository > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 0b444dbeefb0ea9418ff558766b5f77e13389616 # timeout=10Cloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10Checking out Revision 5f3cd83fa8b6837f7d1277c03511b282fa23feca (origin/master)Commit message: "Update to reflect move of KDiff3 to Extragear."[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies) > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 5f3cd83fa8b6837f7d1277c03511b282fa23feca # timeout=10[Pipeline] sh+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project prison --branchGroup kf5-qt5 --environment production --platform AndroidQt5.11 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Prepare Android Dependencies)[Pipeline] }[Pipeline] // stage[Pipeline] }groovy.lang.MissingPropertyException: No such property: DESTDIR for class: groovy.lang.Binding	at groovy.lang.Binding.getVariable(Binding.java:63)	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:264)	at org.kohsuke.groovy.sandbox.impl.Checker$6.call(Checker.java:288)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:292)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)	at WorkflowScript.run(WorkflowScript:80)	at ___cps.transform___(Native Method)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.get(PropertyishBlock.java:74)	at com.cloudbees.groovy.cps.LValueBlock$GetAdapter.receive(LValueBlock.java:30)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.fixName(PropertyishBlock.java:66)	at sun.reflect.GeneratedMethodAccessor301.invoke(Unknown Source)	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	at java.lang.reflect.Method.invoke(Method.java:498)	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)	at 

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.11 - Build # 8 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/8/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Thu, 07 Feb 2019 17:23:50 +
 Build duration:
1 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 51 lines...] > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 466681ea2f678c2926a98c91e5c43e16498a52f1 # timeout=10Cloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10Checking out Revision 0b444dbeefb0ea9418ff558766b5f77e13389616 (origin/master)Commit message: "Move KDiff3 to Extragear per the completion of it's review."[Pipeline] checkout > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 0b444dbeefb0ea9418ff558766b5f77e13389616 # timeout=10No credentials specifiedCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/user/workspace/Frameworks/prison/kf5-qt5 AndroidQt5.11/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10Checking out Revision 5f3cd83fa8b6837f7d1277c03511b282fa23feca (origin/master)Commit message: "Update to reflect move of KDiff3 to Extragear."[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh > git rev-parse origin/master^{commit} # timeout=10 > git config core.sparsecheckout # timeout=10 > git checkout -f 5f3cd83fa8b6837f7d1277c03511b282fa23feca # timeout=10+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project prison --branchGroup kf5-qt5 --environment production --platform AndroidQt5.11 --installTo /home/user/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Prepare Android Dependencies)[Pipeline] }[Pipeline] // stage[Pipeline] }groovy.lang.MissingPropertyException: No such property: DESTDIR for class: groovy.lang.Binding	at groovy.lang.Binding.getVariable(Binding.java:63)	at org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SandboxInterceptor.onGetProperty(SandboxInterceptor.java:264)	at org.kohsuke.groovy.sandbox.impl.Checker$6.call(Checker.java:288)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:292)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at org.kohsuke.groovy.sandbox.impl.Checker.checkedGetProperty(Checker.java:268)	at com.cloudbees.groovy.cps.sandbox.SandboxInvoker.getProperty(SandboxInvoker.java:29)	at com.cloudbees.groovy.cps.impl.PropertyAccessBlock.rawGet(PropertyAccessBlock.java:20)	at WorkflowScript.run(WorkflowScript:79)	at ___cps.transform___(Native Method)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.get(PropertyishBlock.java:74)	at com.cloudbees.groovy.cps.LValueBlock$GetAdapter.receive(LValueBlock.java:30)	at com.cloudbees.groovy.cps.impl.PropertyishBlock$ContinuationImpl.fixName(PropertyishBlock.java:66)	at sun.reflect.GeneratedMethodAccessor301.invoke(Unknown Source)	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)	at java.lang.reflect.Method.invoke(Method.java:498)	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)	at 

D18819: Use content to determine mime type

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Determine the mime type for the
  extractors based on the content, not on the file
  extension. This avoids feeding files with a wrong
  or the same file extension into the wrong extractor.
  
  CCBUG: 403902

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18819

AFFECTED FILES
  src/file/extractor/app.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

Re: CI for prison: missing dependency

[Volker Krause]

On Saturday, 2 February 2019 19:15:36 CET Ben Cooksley wrote:
> On Sun, Feb 3, 2019 at 12:02 AM David Faure  wrote:
> > On samedi 2 février 2019 11:20:28 CET CI System wrote:
> > > -- The following REQUIRED packages have not been found:
> > > 
> > > * QRencode, The QRencode library,
> > 
> > Can this be added to the CI?
> 
> Unfortunately Android doesn't use the standard mechanisms for this - I
> think we have to compile stuff ourselves.
> Any idea on this Aleix?

looking at
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.11/7/
console

libqrencode is actually built and installed, but the unresolved $WORKSPACE and 
$HOME in the install path looks suspicious, I'm not seeing that in other 
builds:
"-- Installing: INSTALL_ROOT=$WORKSPACE/install-divert/home/user/workspace/
Frameworks/prison/kf5-qt5 AndroidQt5.11/build/libqrencode/$HOME/install-
prefix/include/qrencode.h"

Maybe that's the problem? CMake wouldn't pick up dependencies in that location 
then I guess.

Thanks,
Volker

signature.asc
Description: This is a digitally signed message part.

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Krešimir Čohar]

rooty closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  gnumeric-font-16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18804: Workaround for the bug 393630 - Framework part

[Nathaniel Graham]

ngraham added a dependent revision: D18805: Workaround for the bug 393630 - 
SystemTray part.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630 - Framework part

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 07 Feb 2019 15:38:52 +
 Build duration:
9 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/15/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 07 Feb 2019 15:38:52 +
 Build duration:
7 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
 

D18487: Do background contrast fallback at runtime

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7ca1f01ea91a: Do background contrast fallback at runtime 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18487?vs=51085=51108

REVISION DETAIL
  https://phabricator.kde.org/D18487

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/theme.cpp

To: broulik, #plasma, ngraham, mart
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 07 Feb 2019 15:38:52 +
 Build duration:
3 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D18487: Do background contrast fallback at runtime

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma, ngraham, mart
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  +1 shipit!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis, GB_2, ngraham
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  Great!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis, GB_2
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18487: Do background contrast fallback at runtime

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma, ngraham
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

[Shubham]

shubham updated this revision to Diff 51102.
shubham added a comment.


  Accept and ignore the event

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18788?vs=51039=51102

BRANCH
  arcpatch-D18788

REVISION DETAIL
  https://phabricator.kde.org/D18788

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: shubham, cullmann
Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, cullmann

D18739: Sync QML module padding to reflect system setting pages

[Valerio Pilo]

vpilo added a comment.


  As mentioned in D18458 , a KCM not based 
on KCM.GridViewKCM & friends (e.g. a KCM based on Kirigami.Page) will now get 
extra padding (on Breeze, no scaling, it's of 6px), both on KCMShell and 
SystemSettings.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D18739

To: davidedmundson, #plasma
Cc: vpilo, kde-frameworks-devel, michaelh, ngraham, bruns

D18813: Filter out invalid content in lists

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a reviewer: KNewStuff.
leinir added a project: KNewStuff.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Prior to this change, if the ocs server being queried returned a list of 
entries containing invalid entries (such as happened a few days ago for the 
otherwise empty Akonadi email providers category), the listing function would 
faithfully return that list of entries verbatim, which led consumers of that 
list to insist there were more entries to fetch, and then try again, and again, 
and again. With this patch, only valid entries get forwarded as results to the 
consumers (be they knewstuff's own dialogues, or others, such as Discover or 
Peruse).
  
  This change is in KNewStuff rather than Attica, because Attica by design does 
not apply heuristics of any sort to its functions. That, again by design, is 
what KNewStuff is for.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D18813

AFFECTED FILES
  src/attica/atticaprovider.cpp

To: leinir, #knewstuff
Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Krešimir Čohar]

rooty updated this revision to Diff 51092.
rooty added a comment.


  Implement GB_2's suggestion and use gtk-select-font as template for new icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18794?vs=51074=51092

BRANCH
  gnumeric-font-16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18794

AFFECTED FILES
  icons-dark/actions/16/font.svg
  icons-dark/actions/16/gnumeric-font.svg
  icons-dark/actions/24/font.svg
  icons/actions/16/font.svg
  icons/actions/16/gnumeric-font.svg
  icons/actions/24/font.svg

To: rooty, #vdg, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18763: [client] Fix typos

[David Edmundson]

davidedmundson added a comment.


  Ship it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18763

To: zzag, #kwin
Cc: davidedmundson, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Björn Feber]

GB_2 added a comment.


  @rooty just copy a different 16px font icon like `format-font-size-more` and 
remove the other things than the A and align it in the horizontal center.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis
Cc: GB_2, ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18487: Do background contrast fallback at runtime

[Kai Uwe Broulik]

broulik updated this revision to Diff 51085.
broulik retitled this revision from "Reparse background contrast settings when 
colors changed" to "Do background contrast fallback at runtime".
broulik edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18487?vs=50142=51085

REVISION DETAIL
  https://phabricator.kde.org/D18487

AFFECTED FILES
  src/plasma/private/theme_p.cpp
  src/plasma/theme.cpp

To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18804: Workaround for the bug 393630 - Framework part

[Tranter Madi]

trmdi added a comment.


  In D18804#406918 , @davidedmundson 
wrote:
  
  > Can you explain what you're working around?
  
  
  If SystemTray's ConfigEntries.qml accesses plasma.rootItem -> the bug happens 
(*)
  My workaround is to get plasma.rootItem.property in the C++ side, then pass 
the value to QML, so (*) will never happen

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630 - Framework part

[David Edmundson]

davidedmundson added a comment.


  Can you explain what you're working around?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630 - Framework part

[Tranter Madi]

trmdi retitled this revision from "Workaround for the bug 393630" to 
"Workaround for the bug 393630 - Framework part".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Krešimir Čohar]

rooty added a comment.


  Is this ok? I had to stretch it out a lil bit at the top and bottom
  
  F6594583: image.png 
  
  In my previous comment I just moved it and I realized it had four pixels 
above and three below it...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18487: Reparse background contrast settings when colors changed

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> mart wrote in theme_p.cpp:754
> They can be supplied from the theme too (or used to be) even though most of 
> the themes don't

err, forget everything i said, i misunderstood your comment :)
 using qgray on the theme backgroundcolor instead of a magic 0.45 is an 
excellent idea

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18794: [breeze-icons] Add 16px versions of gnumeric-font.svg and link gnumeric-font.svg to font.svg

[Krešimir Čohar]

rooty added a comment.


  Is this acceptable? I had to make it shorter to align to the grid
  
  F6594549: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18794

To: rooty, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D18487: Reparse background contrast settings when colors changed

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in theme_p.cpp:754
> If the theme does not supply background contrast values, they are 
> auto-determined from the background color (dark or light), or what do you 
> mean?

They can be supplied from the theme too (or used to be) even though most of the 
themes don't

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18738: Add ebook thumbnailer

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/kio-extras.git/commit/?id=db7e30823b8a26b1f8bec721f2079bed6132a155

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg, elvisangelaccio
Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D18804: Workaround for the bug 393630

[Tranter Madi]

trmdi added a comment.


  In D18804#406887 , @anthonyfieroni 
wrote:
  
  > Did you understand why it happen?
  
  
  Unfortunately no.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630

[Anthony Fieroni]

anthonyfieroni added a comment.


  Did you understand why it happen?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18804: Workaround for the bug 393630

[Fabian Vogt]

fvogt added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18804

To: trmdi, broulik, davidedmundson, fvogt, anthonyfieroni, ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns