D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a comment.


  Possibly the returend `EGL_INCLUDE_DIR` should possibly be stripped of the 
suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a reviewer: FreeBSD.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner created this revision.
tcberner added reviewers: Automotive, hausmann.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
  ${EGL_INCLUDE_DIR} is the path up to 'egl.h' -- so the header is
  ${EGL_INCLUDE_DIR}/egl.h
  
  The compile test on the other hand includes 'EGL/egl.h', so the path
  that needs to be passed to the compile test is "${EGL_INCLUDE_DIR}/..".

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

AFFECTED FILES
  find-modules/FindEGL.cmake

To: tcberner, #automotive, hausmann
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19075: Fix FindEGL

[Tobias C. Berner]

tcberner added a dependency: D18960: Add compile check to FindEGL.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

[Tobias C. Berner]

tcberner added a dependent revision: D19075: Fix FindEGL.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18960

To: hausmann, vkrause, apol
Cc: bcooksley, tcberner, kossebau, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

[Ben Cooksley]

bcooksley added a comment.


/usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make 
CMakeFiles/cmTC_fd24d.dir/build
gmake[1]: Entering directory 
'/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o
/usr/bin/c++   -I/usr/local/include/EGL  -DHAVE_EGL   -o 
CMakeFiles/cmTC_fd24d.dir/src.cxx.o -c 
/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx
/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx:2:10: fatal 
error: 'EGL/egl.h' file not found
#include 
 ^~~
1 error generated.
gmake[1]: *** [CMakeFiles/cmTC_fd24d.dir/build.make:66: 
CMakeFiles/cmTC_fd24d.dir/src.cxx.o] Error 1
gmake[1]: Leaving directory 
'/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
gmake: *** [Makefile:121: cmTC_fd24d/fast] Error 2
  
  The real issue here appears to be that PkgConfig information on include paths 
is being ignored by CMake (because it's right there):
  
[jenkins@freebsd-node1 ~/kwayland/build]$ cat CMakeCache.txt  | grep -i EGL
EGL_INCLUDE_DIR:PATH=/usr/local/include/EGL
EGL_LIBRARY:FILEPATH=/usr/local/lib/libEGL.so

KF5WaylandServer_LIB_DEPENDS:STATIC=general;Qt5::Gui;general;Wayland::Server;general;EGL::EGL;general;Qt5::Concurrent;
pkgcfg_lib_PKG_EGL_EGL:FILEPATH=/usr/local/lib/libEGL.so
//ADVANCED property for variable: EGL_INCLUDE_DIR
EGL_INCLUDE_DIR-ADVANCED:INTERNAL=1
//ADVANCED property for variable: EGL_LIBRARY
EGL_LIBRARY-ADVANCED:INTERNAL=1
//ADVANCED property for variable: HAVE_EGL
HAVE_EGL-ADVANCED:INTERNAL=1
//Test HAVE_EGL
HAVE_EGL:INTERNAL=

PKG_EGL_CFLAGS:INTERNAL=-I/usr/local/include;-I/usr/local/include/libdrm;-D_THREAD_SAFE;-pthread
PKG_EGL_CFLAGS_I:INTERNAL=
PKG_EGL_CFLAGS_OTHER:INTERNAL=-D_THREAD_SAFE;-pthread
PKG_EGL_FOUND:INTERNAL=1
PKG_EGL_INCLUDEDIR:INTERNAL=/usr/local/include
PKG_EGL_INCLUDE_DIRS:INTERNAL=/usr/local/include;/usr/local/include/libdrm
PKG_EGL_LDFLAGS:INTERNAL=-L/usr/local/lib;-lEGL
PKG_EGL_LDFLAGS_OTHER:INTERNAL=
PKG_EGL_LIBDIR:INTERNAL=/usr/local/lib
PKG_EGL_LIBRARIES:INTERNAL=EGL
PKG_EGL_LIBRARY_DIRS:INTERNAL=/usr/local/lib
PKG_EGL_LIBS:INTERNAL=
PKG_EGL_LIBS_L:INTERNAL=
PKG_EGL_LIBS_OTHER:INTERNAL=
PKG_EGL_LIBS_PATHS:INTERNAL=
PKG_EGL_PREFIX:INTERNAL=/usr/local

PKG_EGL_STATIC_CFLAGS:INTERNAL=-I/usr/local/include;-I/usr/local/include/libdrm;-D_THREAD_SAFE;-pthread
PKG_EGL_STATIC_CFLAGS_I:INTERNAL=
PKG_EGL_STATIC_CFLAGS_OTHER:INTERNAL=-D_THREAD_SAFE;-pthread

PKG_EGL_STATIC_INCLUDE_DIRS:INTERNAL=/usr/local/include;/usr/local/include/libdrm

PKG_EGL_STATIC_LDFLAGS:INTERNAL=-L/usr/local/lib;-lEGL;-lm;-lpthread;-pthread;-L/usr/local/lib;-ldrm;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-L/usr/local/lib;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lXdamage;-L/usr/local/lib;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-L/usr/local/lib;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-L/usr/local/lib;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lXfixes;-L/usr/local/lib;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lX11-xcb;-lX11;-pthread;-L/usr/local/lib;-pthread;-lXau;-pthread;-lXau;-lxcb;-pthread;-lXau;-lxcb-glx;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lxcb-dri2;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lXxf86vm;-L/usr/local/lib;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lXext;-L/usr/local/lib;-lX11;-pthread;-L/usr/local/lib;-lxcb;-pthread;-lXau;-lXdmcp

PKG_EGL_STATIC_LDFLAGS_OTHER:INTERNAL=-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread;-pthread
PKG_EGL_STATIC_LIBDIR:INTERNAL=

PKG_EGL_STATIC_LIBRARIES:INTERNAL=EGL;m;pthread;drm;X11;xcb;Xau;X11;xcb;Xau;Xdamage;X11;xcb;Xau;X11;xcb;Xau;X11;xcb;Xau;Xfixes;xcb;Xau;X11-xcb;X11;Xau;Xau;xcb;Xau;xcb-glx;xcb;Xau;xcb-dri2;xcb;Xau;Xxf86vm;X11;xcb;Xau;Xext;X11;xcb;Xau;Xdmcp

PKG_EGL_STATIC_LIBRARY_DIRS:INTERNAL=/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib;/usr/local/lib
PKG_EGL_STATIC_LIBS:INTERNAL=
PKG_EGL_STATIC_LIBS_L:INTERNAL=
PKG_EGL_STATIC_LIBS_OTHER:INTERNAL=
PKG_EGL_STATIC_LIBS_PATHS:INTERNAL=
PKG_EGL_VERSION:INTERNAL=18.3.2
PKG_EGL_egl_INCLUDEDIR:INTERNAL=
PKG_EGL_egl_LIBDIR:INTERNAL=
PKG_EGL_egl_PREFIX:INTERNAL=
PKG_EGL_egl_VERSION:INTERNAL=
__pkg_config_arguments_PKG_EGL:INTERNAL=QUIET;egl
__pkg_config_checked_PKG_EGL:INTERNAL=1

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18960

To: hausmann, vkrause, apol
Cc: 

D19060: Use AuthCore instead of Auth

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19060

To: aacid, apol
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19059: Use AuthCore instead of Auth

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19059

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19058: Add a note for KF6 to use the core version of KF5::Auth

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19058

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19054: Port cross-compilation support to KF5_HOST_TOOLING

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19054

To: vkrause, apol
Cc: apol, ltoscano, habacker, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19057: Compile our own helper against AuthCore and not Auth

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19057

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19048: Namespace find_file result

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19048

To: vkrause, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty added a dependency: D19020: [breeze-icons] Revamp system.svgz.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a dependent revision: D19074: [breeze-icons] Implement new suspend 
and hibernate icons in Breeze icon theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty edited the summary of this revision.
rooty edited the test plan for this revision.
rooty added reviewers: VDG, ngraham.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Implement new suspend and hibernate icons in Breeze icon theme

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch replaces the suspend and hibernate icons in the Breeze icon theme 
with the ones from system.svgz in patch D19020 
.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-suspend-hibernate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: rooty
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51821.
rooty added a comment.


  Fix suspend icon height

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51793=51821

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19065: Cleanup idempotent entries from mimetype mapper table

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The OpenDocument and OfficeXML mime types are already covered by the
  `contains("document")` statement, so no need to explicitly list these
  for the `Type::Document` again.
  
  Likewise for SVGs, which are already covered by the `startswith("image/")`.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D19065

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18883: Add PDF thumbnailer

[Albert Astals Cid]

aacid added a comment.


  The code can't be much simpler than this, there's not much places it can go 
wrong, i guess the only other thing to mention is, poppler will crash with some 
bad data, so i don't know if this is on it's own process or not, but if it's 
not it may bring down whatever app uses it, though given the gs issues lately 
it's probably not worse?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Noah Davis]

ndavis added a comment.


  In D19030#412778 , @ngraham wrote:
  
  > Now we don't need `input-gaming` anymore. :)
  
  
  What happens if an application asks for a 22px `input-gaming` icon and not 
`input-gaming-symbolic`?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19060: Use AuthCore instead of Auth

[Albert Astals Cid]

aacid created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aacid requested review of this revision.

REVISION SUMMARY
  we don't need KAuth::ObjectDecorator nor the widget dependency it brings

TEST PLAN
  Compiles

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19060

AFFECTED FILES
  src/CMakeLists.txt

To: aacid
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/10/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 Feb 2019 18:53:24 +
 Build duration:
2 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D19059: Use AuthCore instead of Auth

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  we don't need KAuth::ObjectDecorator nor the widget dependency it brings

TEST PLAN
  Compiles

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19059

AFFECTED FILES
  src/core/CMakeLists.txt
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/kauth/CMakeLists.txt

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19047: [GridDelegate] Fix long labels blending into each other

[Filip Fila]

filipf edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19054: Port cross-compilation support to KF5_HOST_TOOLING

[Luigi Toscano]

ltoscano added subscribers: habacker, ltoscano.
ltoscano added a comment.


  I trust @vkrause  that this complicated part works, but I need to ask 
@habacker too, as he contributed part of the cross-compiling code.
  
  If anyone else from the #windows  
project would like to comment to, that would be nice.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19054

To: vkrause
Cc: ltoscano, habacker, kde-frameworks-devel, kde-doc-english, gennad, 
michaelh, ngraham, bruns, skadinna

D19058: Add a note for KF6 to use the core version of KF5::Auth

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19058

AFFECTED FILES
  src/CMakeLists.txt

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:9f79f84d0800: [kio-extras] Use storage media 
instead of storages (authored by rooty).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19053?vs=51796=51798

REVISION DETAIL
  https://phabricator.kde.org/D19053

AFFECTED FILES
  mtp/kio_mtp.cpp

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19054: Port cross-compilation support to KF5_HOST_TOOLING

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This is more consistent with this is done in other frameworks, and more
  importantly it works in more scenarios. The old approach here was failing
  when target executables were also found, in which case their CMake targets
  had both LOCATION (pointing to target executables) and IMPORTED_LOCATION
  (pointing to native executables) properties set.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19054

AFFECTED FILES
  CMakeLists.txt
  KF5DocToolsConfig.cmake.in
  src/CMakeLists.txt

To: vkrause
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19053: [kio-extras] Use "storage media" instead of "storages"

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19053

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19057: Compile our own helper against AuthCore and not Auth

[Albert Astals Cid]

aacid updated this revision to Diff 51802.
aacid added a comment.


  Link our own examples against AuthCore

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19057?vs=51801=51802

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19057

AFFECTED FILES
  examples/CMakeLists.txt
  src/CMakeLists.txt

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19057: Compile our own helper against AuthCore and not Auth

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19057

AFFECTED FILES
  src/ConfigureChecks.cmake

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19056: Tell people they should mostly be using KF5::AuthCore

[Christoph Feck]

cfeck retitled this revision from "Tell people they should mostly be using 
KF5::Auth" to "Tell people they should mostly be using KF5::AuthCore".

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D19056

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19056: Tell people they should mostly be using KF5::Auth

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19056

AFFECTED FILES
  README.md

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

rooty updated this revision to Diff 51796.
rooty added a comment.


  Fix my own error (ironic?)

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19053?vs=51795=51796

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19053

AFFECTED FILES
  mtp/kio_mtp.cpp

To: rooty, #vdg
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

rooty edited the summary of this revision.
rooty added a reviewer: VDG.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19053

To: rooty, #vdg
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19053: [kio-extras] Use "storage media" instead of "storages"

[Krešimir Čohar]

rooty created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
rooty requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  typo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19053

AFFECTED FILES
  mtp/kio_mtp.cpp

To: rooty
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51793.
rooty added a comment.


  Use Zs instead of stars

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51727=51793

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 19:47:58 +
 Build duration:
27 sec and counting
   CONSOLE OUTPUT
  [...truncated 132 lines...][2019-02-15T19:48:22.396Z] EXECUTOR_NUMBER   = '0'[2019-02-15T19:48:22.396Z] SHLVL = '1'[2019-02-15T19:48:22.396Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-02-15T19:48:22.396Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-02-15T19:48:22.396Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-02-15T19:48:22.396Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2019-02-15T19:48:22.396Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2019-02-15T19:48:22.396Z] QT_SELECT = 'qt5'[2019-02-15T19:48:22.396Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-02-15T19:48:22.396Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'[2019-02-15T19:48:22.396Z] [2019-02-15T19:48:22.396Z] [2019-02-15T19:48:22.396Z] == Commencing Configuration:[2019-02-15T19:48:22.396Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/kwayland/kf5-qt5 FreeBSDQt5.12"[2019-02-15T19:48:22.657Z] -- The C compiler identification is Clang 6.0.1[2019-02-15T19:48:22.916Z] -- The CXX compiler identification is Clang 6.0.1[2019-02-15T19:48:22.916Z] -- Check for working C compiler: /usr/bin/cc[2019-02-15T19:48:22.916Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-02-15T19:48:22.916Z] -- Detecting C compiler ABI info[2019-02-15T19:48:23.204Z] -- Detecting C compiler ABI info - done[2019-02-15T19:48:23.204Z] -- Detecting C compile features[2019-02-15T19:48:23.494Z] -- Detecting C compile features - done[2019-02-15T19:48:23.494Z] -- Check for working CXX compiler: /usr/bin/c++[2019-02-15T19:48:23.754Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-02-15T19:48:23.754Z] -- Detecting CXX compiler ABI info[2019-02-15T19:48:24.023Z] -- Detecting CXX compiler ABI info - done[2019-02-15T19:48:24.023Z] -- Detecting CXX compile features[2019-02-15T19:48:24.952Z] -- Detecting CXX compile features - done[2019-02-15T19:48:24.952Z] -- [2019-02-15T19:48:24.952Z] [2019-02-15T19:48:24.952Z] -- Found PkgConfig: /usr/local/bin/pkg-config (found version "1.6.0") [2019-02-15T19:48:24.952Z] -- Found Wayland_Client: /usr/local/lib/libwayland-client.so (found version "1.16.0") [2019-02-15T19:48:24.952Z] -- Found Wayland_Server: /usr/local/lib/libwayland-server.so (found version "1.16.0") [2019-02-15T19:48:24.952Z] -- Found Wayland: /usr/local/lib/libwayland-client.so;/usr/local/lib/libwayland-server.so (found suitable version "1.16.0", minimum required is "1.13") found components:  Client Server [2019-02-15T19:48:24.952Z] -- Found WaylandScanner: /usr/local/bin/wayland-scanner  [2019-02-15T19:48:24.952Z] -- Performing Test HAVE_EGL[2019-02-15T19:48:24.952Z] -- Performing Test HAVE_EGL - Failed[2019-02-15T19:48:24.952Z] -- Could NOT find EGL (missing: HAVE_EGL) (found version "1.5")[2019-02-15T19:48:24.952Z] -- Looking for __GLIBC__[2019-02-15T19:48:24.952Z] -- Looking for __GLIBC__ - not found[2019-02-15T19:48:24.952Z] -- Performing Test _OFFT_IS_64BIT[2019-02-15T19:48:24.952Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-02-15T19:48:24.952Z] -- Performing Test HAVE_DATE_TIME[2019-02-15T19:48:24.952Z] -- Performing Test HAVE_DATE_TIME - Success[2019-02-15T19:48:24.952Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-02-15T19:48:24.952Z] -- Looking for linux/input.h[2019-02-15T19:48:24.952Z] -- Looking for linux/input.h - not found[2019-02-15T19:48:25.210Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-02-15T19:48:25.210Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-02-15T19:48:25.210Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-02-15T19:48:25.210Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-02-15T19:48:25.210Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-02-15T19:48:25.468Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-02-15T19:48:25.468Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.14", minimum required is "1.8.13") found components:  doxygen dot [2019-02-15T19:48:25.468Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2019-02-15T19:48:25.468Z] -- The weston executable was not found. Some autotests will not be executed.[2019-02-15T19:48:25.468Z] -- The following features have been enabled:[2019-02-15T19:48:25.468Z] 

D19047: [GridDelegate] Fix long labels blending into each other

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 18:53:24 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D19051: [RFC]DocumentPrivate: Auto unwrap line when text is removed

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Such patch seems to be missing to achieve the desired behavior to auto
  reformat a paragraph with enabled static word wrap.
  
  The reformat takes without this patch only place when text is added but
  not removed.

TEST PLAN
  - Enable static wrap
  - Enter enough text to force auto wrap over a couple of lines
  - Add at some point in the middle of your text a "hard wrap/new paragraph" by 
simply press ENTER
  - Add in the upper paragraph more text -> lines below will auto reformat down 
to "hard wrap"
  - Remove new added text by DEL -> with patch paragraph gets reformat too
  - New behavior also affects text which was wrapped by "Apply Word Wrap" when 
static wrap is off, but for me is that's fine
  - It's looking similar as done at other places but I'm not sure if it's best 
this way due to my goals mentioned elsewhere
  - In current state can this patch crash when do "undo"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19051

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19047: [GridDelegate] Fix long labels blending into each other

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:23942e570831: [GridDelegate] Fix long labels blending 
into each other (authored by filipf, committed by ngraham).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19047?vs=51783=51792

REVISION DETAIL
  https://phabricator.kde.org/D19047

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/18/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Feb 2019 18:53:24 +
 Build duration:
3 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D19047: [GridDelegate] Fix long labels blending into each other

[Filip Fila]

filipf added a comment.


  In D19047#413025 , @ngraham wrote:
  
  > +1, definitely the correct fix.
  >
  > Let's land this now and then we can work on the UI improvement of enabling 
multi-line strings in another patch.
  
  
  Okay! :)

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19047: [GridDelegate] Fix long labels blending into each other

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, definitely the correct fix.
  
  Let's land this now and then we can work on the UI improvement of enabling 
multi-line strings in another patch.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19047: [GridDelegate] Fix long labels blending into each other

[Filip Fila]

filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch anchors the GridDelegate's label width and height to the
  thumbnail, as opposed to the parent.
  
  NOTE: I'm running into issues making lables have two lines , but I could
  implement that if someone would help me.
  
  BUG: 404389
  FIXED-IN: 5.56

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: filipf
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19049: Namespace find_file call

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  KAuth uses the same name, getting our cached result then.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19049

AFFECTED FILES
  KF5CoreAddonsConfig.cmake.in

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19048: Namespace find_file result

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  KCoreAddons uses the same name, which causes this to use the cached result
  for the KCoreAddons find_file call, making this fail when KCoreAddons is
  present.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19048

AFFECTED FILES
  KF5AuthConfig.cmake.in

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19047: [GridDelegate] Fix long labels blending into each other

[Filip Fila]

filipf edited the summary of this revision.
filipf edited the test plan for this revision.
filipf added reviewers: Frameworks, ngraham, VDG.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added a comment.


  Could I specify, what dot is also word delimiter? Because, for example, 
"p.poly" has a wrong highlighting: "poly" highlighted as function, but it is 
not a function, it is a part of object "p".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, 
michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars

D18527: List Android as officially supported

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:aa18d0749f5c: List Android as officially supported 
(authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18527?vs=50264=51771

REVISION DETAIL
  https://phabricator.kde.org/D18527

AFFECTED FILES
  metainfo.yaml

To: vkrause, lbeltrame, apol
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D19027: Fix "Invalid URL: QUrl("some.txt")" warnings in Save dialog

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: Frameworks.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good to me, but please wait for approval by @dfaure or another 
#frameworks  person before landing.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19027

To: Lekensteyn, ngraham, dfaure, fvogt, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham added a comment.


  Yeah in and of itself, the snowflake is good. I think it just needs something 
added to it so it doesn't look like it turns on the air conditioning as Kai 
alluded to. :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/7/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 Feb 2019 16:07:07 +
 Build duration:
3 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6417/8535)44%
(10444/23958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5925/12151)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/11/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Feb 2019 16:07:07 +
 Build duration:
3 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittestFailed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6417/8535)44%
(10444/23958)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2720/2796)49%
(5925/12151)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(424/834)47%
(1013/2163)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/13/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 16:07:07 +
 Build duration:
2 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D18369: Create tel: links for phone numbers

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:5b5e87d699c5: Create tel: links for phone numbers 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18369?vs=50315=51764#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18369?vs=50315=51764

REVISION DETAIL
  https://phabricator.kde.org/D18369

AFFECTED FILES
  autotests/ktexttohtmltest.cpp
  src/lib/text/ktexttohtml.cpp
  src/lib/text/ktexttohtml.h
  src/lib/text/ktexttohtml_p.h

To: vkrause, svuorela
Cc: apol, aacid, svuorela, nicolasfella, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:07 +
 Build duration:
2 min 50 sec and counting

KDE CI: Frameworks » kcompletion » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcompletion/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:07 +
 Build duration:
3 min 53 sec and counting

KDE CI: Frameworks » attica » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:07 +
 Build duration:
3 min 50 sec and counting

KDE CI: Frameworks » kimageformats » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
3 min 5 sec and counting

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
3 min 1 sec and counting

KDE CI: Frameworks » kjobwidgets » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kjobwidgets/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
3 min 8 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
3 min 3 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/4/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
1 min 55 sec and counting

KDE CI: Frameworks » ki18n » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:07 +
 Build duration:
2 min 39 sec and counting

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
1 min 19 sec and counting

KDE CI: Frameworks » threadweaver » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:07 +
 Build duration:
1 min 20 sec and counting

KDE CI: Frameworks » kguiaddons » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kguiaddons/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 16:00:06 +
 Build duration:
1 min 14 sec and counting

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#412775 , @ngraham wrote:
  
  > +1 on the List Users icon. Perfect.
  >
  > For the Type User icon, I'm not sure it needs to be in a circle. With the 
new moon-style suspend icon on the left side, it might be better to have a 
non-round icon on the right side to balance it out.
  >
  > I like the moon iconography in general. However I'm not as big a fan of the 
stars. They feel too regular, and the whole effect makes me think of the symbol 
for Islam: F6616841: islam-symbol-300x300.jpg 

  >
  > Likewise, I don't think the new Hibernate symbol works on its own. Alone, 
it's just a snowflake, which to me means "snow" or "cooling" or "winter 
weather".
  >
  > I think both of these symbols would benefit from having three Zs in the 
top-right corner like we discussed earlier. That would tie them both together 
conceptually as well as reinforce the concept that they're both modes of sleep.
  >
  > Something like this (warning: crude icon butchery incoming):
  >
  > F6616845: Screenshot_20190215_074707.png 

  
  
  But you're okay with the snowflake?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » karchive » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:52:28 +
 Build duration:
1 min 5 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/16/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 Feb 2019 15:42:27 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 3 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5382/9501)41%
(2127/5238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)88%
(794/905)49%
(258/530)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)39%
(651/1666)36%
(386/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty added a comment.


  In D19030#412778 , @ngraham wrote:
  
  > Now we don't need `input-gaming` anymore. :)
  
  
  @hein put the "too" in parentheses :D, I was erring on the side of caution
  
  But what do I do to the 64 px version? Rename it to input-games? It's not a 
symlink

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:51:43 +
 Build duration:
55 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/23/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Feb 2019 15:42:27 +
 Build duration:
5 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 2 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5404/9501)41%
(2142/5238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)90%
(816/905)51%
(272/530)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)39%
(651/1666)37%
(387/1058)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
  

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/3/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:47:59 +
 Build duration:
33 sec and counting
   CONSOLE OUTPUT
  [...truncated 8 lines...][Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2019-02-15T15:48:18.754Z] No credentials specified[2019-02-15T15:48:18.757Z] Cloning the remote Git repository[2019-02-15T15:48:18.771Z] Cloning repository git://anongit.kde.org/knotifications[2019-02-15T15:48:18.799Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12 # timeout=10[2019-02-15T15:48:18.840Z] Fetching upstream changes from git://anongit.kde.org/knotifications[2019-02-15T15:48:18.841Z]  > git --version # timeout=10[2019-02-15T15:48:18.844Z]  > git fetch --tags --progress git://anongit.kde.org/knotifications +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-15T15:48:22.430Z]  > git config remote.origin.url git://anongit.kde.org/knotifications # timeout=10[2019-02-15T15:48:22.434Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:48:22.439Z]  > git config remote.origin.url git://anongit.kde.org/knotifications # timeout=10[2019-02-15T15:48:22.531Z] Checking out Revision 90db26c7fc67603538be9e6887d83361b57c1348 (origin/master)[2019-02-15T15:48:22.916Z] Commit message: "GIT_SILENT Upgrade KF5 version to 5.56.0."[Pipeline] checkout[2019-02-15T15:48:23.047Z] No credentials specified[2019-02-15T15:48:23.050Z] Cloning the remote Git repository[2019-02-15T15:48:22.446Z] Fetching upstream changes from git://anongit.kde.org/knotifications[2019-02-15T15:48:22.446Z]  > git fetch --tags --progress git://anongit.kde.org/knotifications +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-15T15:48:22.526Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-15T15:48:22.537Z]  > git config core.sparsecheckout # timeout=10[2019-02-15T15:48:22.540Z]  > git checkout -f 90db26c7fc67603538be9e6887d83361b57c1348 # timeout=10[2019-02-15T15:48:22.918Z]  > git rev-list --no-walk 90db26c7fc67603538be9e6887d83361b57c1348 # timeout=10[2019-02-15T15:48:23.051Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-02-15T15:48:23.051Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/ci-tooling # timeout=10[2019-02-15T15:48:23.093Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-15T15:48:23.094Z]  > git --version # timeout=10[2019-02-15T15:48:23.095Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:48:24.618Z] Checking out Revision 2f450945ce21bc62929fc1ac890426418ab02eea (origin/master)[2019-02-15T15:48:24.634Z] Commit message: "Don't enable coverage on Android"[Pipeline] checkout[2019-02-15T15:48:24.810Z] No credentials specified[2019-02-15T15:48:24.814Z] Cloning the remote Git repository[2019-02-15T15:48:24.399Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-15T15:48:24.401Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:48:24.406Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-15T15:48:24.410Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-15T15:48:24.410Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:48:24.614Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-15T15:48:24.620Z]  > git config core.sparsecheckout # timeout=10[2019-02-15T15:48:24.621Z]  > git checkout -f 2f450945ce21bc62929fc1ac890426418ab02eea # timeout=10[2019-02-15T15:48:24.815Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-02-15T15:48:24.816Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/ci-tooling/repo-metadata # timeout=10[2019-02-15T15:48:24.819Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-02-15T15:48:24.819Z]  > git --version # timeout=10[2019-02-15T15:48:24.820Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:48:26.249Z] Checking out Revision 46cb47ef6f1be6b11d6a34044d03dd2637f432ca (origin/master)[2019-02-15T15:48:26.367Z] Commit message: "Update alkimia information"[Pipeline] checkout[2019-02-15T15:48:26.589Z] No credentials specified[2019-02-15T15:48:26.592Z] Cloning the remote Git repository[2019-02-15T15:48:26.008Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-02-15T15:48:26.010Z]  > git 

KDE CI: Frameworks » kcodecs » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:44:50 +
 Build duration:
58 sec and counting

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.12 - Build # 2 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.12/2/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:42:14 +
 Build duration:
38 sec and counting
   CONSOLE OUTPUT
  [...truncated 5 lines...]All nodes of label ‘AndroidQt5.12’ are offlineRunning on Docker Swarm-a035da431955 in /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] checkout[2019-02-15T15:42:38.052Z] No credentials specified[2019-02-15T15:42:38.055Z] Cloning the remote Git repository[2019-02-15T15:42:38.068Z] Cloning repository git://anongit.kde.org/knotifications[2019-02-15T15:42:38.092Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12 # timeout=10[2019-02-15T15:42:38.125Z] Fetching upstream changes from git://anongit.kde.org/knotifications[2019-02-15T15:42:38.125Z]  > git --version # timeout=10[2019-02-15T15:42:38.127Z]  > git fetch --tags --progress git://anongit.kde.org/knotifications +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-15T15:42:42.740Z] Checking out Revision 90db26c7fc67603538be9e6887d83361b57c1348 (origin/master)[2019-02-15T15:42:42.645Z]  > git config remote.origin.url git://anongit.kde.org/knotifications # timeout=10[2019-02-15T15:42:42.648Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:42:42.653Z]  > git config remote.origin.url git://anongit.kde.org/knotifications # timeout=10[2019-02-15T15:42:42.660Z] Fetching upstream changes from git://anongit.kde.org/knotifications[2019-02-15T15:42:42.660Z]  > git fetch --tags --progress git://anongit.kde.org/knotifications +refs/heads/*:refs/remotes/origin/* # timeout=120[2019-02-15T15:42:42.735Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-15T15:42:42.744Z]  > git config core.sparsecheckout # timeout=10[2019-02-15T15:42:42.746Z]  > git checkout -f 90db26c7fc67603538be9e6887d83361b57c1348 # timeout=10[2019-02-15T15:42:43.111Z] Commit message: "GIT_SILENT Upgrade KF5 version to 5.56.0."[Pipeline] checkout[2019-02-15T15:42:43.237Z] No credentials specified[2019-02-15T15:42:43.240Z] Cloning the remote Git repository[2019-02-15T15:42:43.114Z]  > git rev-list --no-walk 90db26c7fc67603538be9e6887d83361b57c1348 # timeout=10[2019-02-15T15:42:43.241Z] Cloning repository https://anongit.kde.org/sysadmin/ci-tooling[2019-02-15T15:42:43.241Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/ci-tooling # timeout=10[2019-02-15T15:42:43.282Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-15T15:42:43.282Z]  > git --version # timeout=10[2019-02-15T15:42:43.283Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:42:44.608Z] Checking out Revision 2f450945ce21bc62929fc1ac890426418ab02eea (origin/master)[2019-02-15T15:42:44.627Z] Commit message: "Don't enable coverage on Android"[Pipeline] checkout[2019-02-15T15:42:44.748Z] No credentials specified[2019-02-15T15:42:44.752Z] Cloning the remote Git repository[2019-02-15T15:42:44.381Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-15T15:42:44.383Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:42:44.387Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10[2019-02-15T15:42:44.392Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling[2019-02-15T15:42:44.392Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:42:44.605Z]  > git rev-parse origin/master^{commit} # timeout=10[2019-02-15T15:42:44.609Z]  > git config core.sparsecheckout # timeout=10[2019-02-15T15:42:44.611Z]  > git checkout -f 2f450945ce21bc62929fc1ac890426418ab02eea # timeout=10[2019-02-15T15:42:44.754Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-02-15T15:42:44.754Z]  > git init /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.12/ci-tooling/repo-metadata # timeout=10[2019-02-15T15:42:44.757Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-02-15T15:42:44.757Z]  > git --version # timeout=10[2019-02-15T15:42:44.759Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-02-15T15:42:46.147Z] Checking out Revision 46cb47ef6f1be6b11d6a34044d03dd2637f432ca (origin/master)[2019-02-15T15:42:46.229Z] Commit message: "Update alkimia information"[Pipeline] checkout[2019-02-15T15:42:46.484Z] No credentials specified[2019-02-15T15:42:46.487Z] Cloning the remote Git 

KDE CI: Frameworks » kconfig » kf5-qt5 AndroidQt5.12 - Build # 1 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:43:45 +
 Build duration:
50 sec and counting

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/23/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Feb 2019 15:42:27 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/2/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:41:11 +
 Build duration:
51 sec and counting

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko updated this revision to Diff 51762.
poboiko added a comment.


  Forgot to define `fname` inside `EventMoveTo`

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18698?vs=51739=51762

BRANCH
  add-watch-moved (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18698

AFFECTED FILES
  autotests/unit/file/kinotifytest.cpp
  src/file/kinotify.cpp
  src/file/kinotify.h

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/2/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 15:39:12 +
 Build duration:
1 min 6 sec and counting

D18965: Guard KCompressionDevice::open being called with no backend available

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:3d5713ba3760: Guard KCompressionDevice::open being called 
with no backend available (authored by davidedmundson).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18965?vs=51529=51760

REVISION DETAIL
  https://phabricator.kde.org/D18965

AFFECTED FILES
  src/kcompressiondevice.cpp

To: davidedmundson, #plasma, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19007: Wait for DBus Reply Before Performing Computations

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> narvaez wrote in monitor.cpp:90
> The batch size is **hardcoded** at 40 so querying it at at any interval is 
> pointless, for that matter. Instead of hardcoding more magic numbers I would 
> just #define BATCH_SIZE 40 inside the Engine lib and set the update interval 
> to 5 * BATCH_SIZE.

Actually, both values are completely unrelated. They exist for similar reasons 
(commiting each file / updating the time for each file hurts performance). Just 
hardcoding e.g. 100 here would do.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D19007

To: narvaez, #baloo, bruns, astippich, poboiko
Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  +1 on the List Users icon. Perfect.
  
  For the Type User icon, I'm not sure it needs to be in a circle. With the new 
moon-style suspend icon on the left side, it might be better to have a 
non-round icon on the right side to balance it out.
  
  I like the moon iconography in general. However I'm not as big a fan of the 
stars. They feel too regular, and the whole effect makes me think of the symbol 
for Islam: F6616841: islam-symbol-300x300.jpg 

  
  Likewise, I don't think the new Hibernate symbol works on its own. Alone, 
it's just a snowflake, which to me means "snow" or "cooling" or "winter 
weather".
  
  I think both of these symbols would benefit from having three Zs in the 
top-right corner like we discussed earlier. That would tie them both together 
conceptually as well as reinforce the concept that they're both modes of sleep.
  
  Something like this (warning: crude icon butchery incoming):
  
  F6616845: Screenshot_20190215_074707.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Nathaniel Graham]

ngraham added a comment.


  Now we don't need `input-gaming` anymore. :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 14:51:04 +
 Build duration:
48 sec and counting
   CONSOLE OUTPUT
  [...truncated 273 lines...][2019-02-15T14:51:47.735Z] [  5%] Building CXX object src/desktoptojson/CMakeFiles/desktoptojson.dir/desktoptojson_autogen/mocs_compilation.cpp.o[2019-02-15T14:51:47.995Z] Scanning dependencies of target ktexttohtmltest[2019-02-15T14:51:47.995Z] [  5%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/ktexttohtmltest.cpp.o[2019-02-15T14:51:47.995Z] [  6%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/__/src/lib/text/ktexttohtml.cpp.o[2019-02-15T14:51:47.995Z] [  6%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/ktexttohtmltest_autogen/mocs_compilation.cpp.o[2019-02-15T14:51:47.995Z] [  6%] Built target KF5CoreAddons_autogen[2019-02-15T14:51:47.995Z] Scanning dependencies of target KF5CoreAddons[2019-02-15T14:51:47.995Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.o[2019-02-15T14:51:47.995Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.o[2019-02-15T14:51:47.995Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.o[2019-02-15T14:51:48.559Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.o[2019-02-15T14:51:48.559Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.o[2019-02-15T14:51:48.559Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.o[2019-02-15T14:51:48.559Z] /home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.12/src/desktoptojson/desktoptojson.cpp:70:9: warning: TODO: make it an error if one of the service type files is invalid or not found [-W#pragma-messages][2019-02-15T14:51:48.559Z] #pragma message("TODO: make it an error if one of the service type files is invalid or not found")[2019-02-15T14:51:48.559Z] ^[2019-02-15T14:51:48.817Z] 1 warning generated.[2019-02-15T14:51:48.817Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.o[2019-02-15T14:51:49.075Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.o[2019-02-15T14:51:49.075Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.o[2019-02-15T14:51:49.075Z] /home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.12/src/lib/io/kdirwatch.cpp:955:13: warning: enumeration values 'FAM' and 'INotify' not handled in switch [-Wswitch][2019-02-15T14:51:49.075Z] switch (preferredMethod) {[2019-02-15T14:51:49.075Z] ^[2019-02-15T14:51:49.333Z] /home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.12/src/lib/io/kdirwatch.cpp:2015:13: warning: enumeration values 'FAM' and 'INotify' not handled in switch [-Wswitch][2019-02-15T14:51:49.333Z] switch (d->m_preferredMethod) {[2019-02-15T14:51:49.333Z] ^[2019-02-15T14:51:49.333Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.o[2019-02-15T14:51:49.333Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.o[2019-02-15T14:51:49.333Z] [ 13%] Linking CXX executable ../../bin/desktoptojson[2019-02-15T14:51:49.333Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-02-15T14:51:49.333Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-02-15T14:51:49.333Z] /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lgcov[2019-02-15T14:51:49.590Z] /home/user/workspace/Frameworks/kcoreaddons/kf5-qt5 AndroidQt5.12/src/lib/io/kbackup.cpp:40:9: warning: KDE5 TODO: Remove KConfig correctly [-W#pragma-messages][2019-02-15T14:51:49.590Z] #pragma message("KDE5 TODO: Remove KConfig correctly")[2019-02-15T14:51:49.590Z] ^[2019-02-15T14:51:49.590Z] clang++: error: linker command failed with exit code 1 (use -v to see invocation)[2019-02-15T14:51:49.590Z] src/desktoptojson/CMakeFiles/desktoptojson.dir/build.make:128: recipe for target 'bin/desktoptojson' failed[2019-02-15T14:51:49.590Z] make[2]: *** [bin/desktoptojson] Error 1[2019-02-15T14:51:49.590Z] CMakeFiles/Makefile2:305: recipe for target 'src/desktoptojson/CMakeFiles/desktoptojson.dir/all' failed[2019-02-15T14:51:49.590Z] make[1]: *** [src/desktoptojson/CMakeFiles/desktoptojson.dir/all] Error 2[2019-02-15T14:51:49.590Z] make[1]: *** Waiting for unfinished jobs[2019-02-15T14:51:49.590Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.o[2019-02-15T14:51:49.848Z] [ 14%] Building CXX object 

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty updated this revision to Diff 51759.
rooty added a comment.


  Add input-games and input-games-symbolic

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19030?vs=51732=51759

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

AFFECTED FILES
  icons-dark/devices/16/input-games.svg
  icons-dark/devices/16/input-gaming.svg
  icons-dark/devices/22/input-games.svg
  icons-dark/devices/22/input-gaming.svg
  icons-dark/devices/64/input-games.svg
  icons-dark/devices/symbolic/input-games-symbolic.svg
  icons-dark/devices/symbolic/input-gaming-symbolic.svg
  icons/devices/16/input-games.svg
  icons/devices/16/input-gaming.svg
  icons/devices/22/input-games.svg
  icons/devices/22/input-gaming.svg
  icons/devices/64/input-games.svg
  icons/devices/symbolic/input-games-symbolic.svg
  icons/devices/symbolic/input-gaming-symbolic.svg

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.12 - Build # 1 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.12/1/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 14:45:44 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 288 lines...][2019-02-15T14:46:25.857Z] [ 48%] Built target blurbehindtest_autogen[2019-02-15T14:46:25.857Z] [ 48%] Built target backgroundcontrasttest_autogen[2019-02-15T14:46:25.857Z] [ 48%] Built target createpixmapfromhandletest_autogen[2019-02-15T14:46:25.857Z] [ 48%] Built target setmainwindowtest_autogen[2019-02-15T14:46:25.857Z] Scanning dependencies of target backgroundcontrasttest[2019-02-15T14:46:25.857Z] [ 51%] Building CXX object tests/CMakeFiles/backgroundcontrasttest.dir/backgroundcontrasttest.cpp.o[2019-02-15T14:46:25.857Z] [ 53%] Building CXX object tests/CMakeFiles/backgroundcontrasttest.dir/backgroundcontrasttest_autogen/mocs_compilation.cpp.o[2019-02-15T14:46:25.857Z] Scanning dependencies of target blurbehindtest[2019-02-15T14:46:25.857Z] Scanning dependencies of target createpixmapfromhandletest[2019-02-15T14:46:25.857Z] Scanning dependencies of target setmainwindowtest[2019-02-15T14:46:25.857Z] [ 55%] Building CXX object tests/CMakeFiles/blurbehindtest.dir/blurbehindtest.cpp.o[2019-02-15T14:46:25.857Z] [ 57%] Building CXX object tests/CMakeFiles/blurbehindtest.dir/blurbehindtest_autogen/mocs_compilation.cpp.o[2019-02-15T14:46:25.857Z] [ 62%] Building CXX object tests/CMakeFiles/createpixmapfromhandletest.dir/createpixmapfromhandletest_autogen/mocs_compilation.cpp.o[2019-02-15T14:46:25.857Z] [ 62%] Building CXX object tests/CMakeFiles/createpixmapfromhandletest.dir/createpixmapfromhandletest.cpp.o[2019-02-15T14:46:25.857Z] [ 64%] Building CXX object tests/CMakeFiles/setmainwindowtest.dir/setmainwindowtest_autogen/mocs_compilation.cpp.o[2019-02-15T14:46:25.857Z] [ 66%] Building CXX object tests/CMakeFiles/setmainwindowtest.dir/setmainwindowtest.cpp.o[2019-02-15T14:46:25.857Z] [ 66%] Built target KF5WindowSystemWaylandPlugin_autogen[2019-02-15T14:46:25.857Z] Scanning dependencies of target KF5WindowSystemWaylandPlugin[2019-02-15T14:46:25.857Z] [ 68%] Building CXX object src/platforms/wayland/CMakeFiles/KF5WindowSystemWaylandPlugin.dir/kwindowsystem.cpp.o[2019-02-15T14:46:25.857Z] [ 71%] Building CXX object src/platforms/wayland/CMakeFiles/KF5WindowSystemWaylandPlugin.dir/plugin.cpp.o[2019-02-15T14:46:25.857Z] [ 73%] Building CXX object src/platforms/wayland/CMakeFiles/KF5WindowSystemWaylandPlugin.dir/KF5WindowSystemWaylandPlugin_autogen/mocs_compilation.cpp.o[2019-02-15T14:46:26.116Z] [ 73%] Built target kwindowsystemplatformwaylandtest_autogen[2019-02-15T14:46:26.116Z] Scanning dependencies of target kwindowsystemplatformwaylandtest[2019-02-15T14:46:26.116Z] [ 77%] Building CXX object autotests/CMakeFiles/kwindowsystemplatformwaylandtest.dir/kwindowsystemplatformwaylandtest_autogen/mocs_compilation.cpp.o[2019-02-15T14:46:26.116Z] [ 77%] Building CXX object autotests/CMakeFiles/kwindowsystemplatformwaylandtest.dir/kwindowsystem_platform_wayland_test.cpp.o[2019-02-15T14:46:26.683Z] [ 80%] Linking CXX executable ../bin/blurbehindtest[2019-02-15T14:46:26.683Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-02-15T14:46:26.683Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-02-15T14:46:26.683Z] /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lgcov[2019-02-15T14:46:26.683Z] [ 82%] Linking CXX executable ../bin/backgroundcontrasttest[2019-02-15T14:46:26.683Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-02-15T14:46:26.683Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-02-15T14:46:26.683Z] /opt/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin/ld: error: cannot find -lgcov[2019-02-15T14:46:26.683Z] clang++: error: linker command failed with exit code 1 (use -v to see invocation)[2019-02-15T14:46:26.683Z] tests/CMakeFiles/blurbehindtest.dir/build.make:98: recipe for target 'bin/blurbehindtest' failed[2019-02-15T14:46:26.683Z] make[2]: *** [bin/blurbehindtest] Error 1[2019-02-15T14:46:26.683Z] CMakeFiles/Makefile2:544: recipe for target 'tests/CMakeFiles/blurbehindtest.dir/all' failed[2019-02-15T14:46:26.683Z] make[1]: *** [tests/CMakeFiles/blurbehindtest.dir/all] Error 2[2019-02-15T14:46:26.683Z] make[1]: *** Waiting for unfinished jobs[2019-02-15T14:46:26.683Z] [ 84%] Linking CXX executable ../bin/createpixmapfromhandletest[2019-02-15T14:46:26.683Z] clang++: error: linker command failed with exit code 1 (use -v to see invocation)[2019-02-15T14:46:26.683Z] 

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 AndroidQt5.12 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20AndroidQt5.12/5/
 Project:
kf5-qt5 AndroidQt5.12
 Date of build:
Fri, 15 Feb 2019 14:43:57 +
 Build duration:
40 sec and counting

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R293 Baloo

BRANCH
  add-watch-moved (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Nathaniel Graham]

ngraham added a comment.


  +1 on `input games` and `input-games-symbolic`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18845: authority: add support for passing details to polkit

[Matthias Gerstner]

mgerstner added inline comments.

INLINE COMMENTS

> bruns wrote in polkitqt1-authority.cpp:328
> nullptr

I didn't want to mix styles in the source files. It's adjusted now.

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: kde-frameworks-devel

D18845: authority: add support for passing details to polkit

[Matthias Gerstner]

mgerstner updated this revision to Diff 51753.
mgerstner added a comment.


  Incorporated review comments: replaced `NULL` by `nullptr`, removed some 
extra whitespace within parantheses, added KF6 TODO.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18845?vs=51161=51753

REVISION DETAIL
  https://phabricator.kde.org/D18845

AFFECTED FILES
  core/polkitqt1-authority.cpp
  core/polkitqt1-authority.h

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: kde-frameworks-devel

D19016: Update Android toolchain files to reality

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:81374904954b: Update Android toolchain files to reality 
(authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19016?vs=51701=51749

REVISION DETAIL
  https://phabricator.kde.org/D19016

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns