D20148: Allow line end context switches in empty lines

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D20148

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  The menu is now ok and the feature still works for me.
  And yes, the view still jumps a bit.
  :P Funny enough for me it failed during testing more because of missing file 
notifications, should not have tried it on NFS.

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D20148: Allow line end context switches in empty lines

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok for me, thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-line-continue

REVISION DETAIL
  https://phabricator.kde.org/D20148

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20148: Allow line end context switches in empty lines

[Nibaldo González]

nibags updated this revision to Diff 55253.
nibags added a comment.


  - Loop proposal
  
  I propose this combination of loops. Any detail don't hesitate to say (or 
commit)!

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20148?vs=55161=55253

BRANCH
  fix-line-continue

REVISION DETAIL
  https://phabricator.kde.org/D20148

AFFECTED FILES
  autotests/folding/test.c.fold
  autotests/html/test.c.html
  autotests/input/test.c
  autotests/reference/test.c.ref
  src/lib/abstracthighlighter.cpp

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/80/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 02 Apr 2019 00:34:08 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/79/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Apr 2019 23:32:53 +
 Build duration:
1 hr 0 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20193: Depends on D20191

[Aleix Pol Gonzalez]

apol updated this revision to Diff 55250.
apol added a comment.


  description

REPOSITORY
  R273 KGuiAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20193?vs=55249=55250

BRANCH
  wayland_keystate

REVISION DETAIL
  https://phabricator.kde.org/D20193

AFFECTED FILES
  src/CMakeLists.txt
  src/keystate.xml
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_dummy.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_wayland.cpp
  src/util/kmodifierkeyinfoprovider_wayland.h
  src/util/kmodifierkeyinfoprovider_x11.cpp
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h

To: apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20193: Depends on D20191

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REPOSITORY
  R273 KGuiAddons

BRANCH
  wayland_keystate

REVISION DETAIL
  https://phabricator.kde.org/D20193

AFFECTED FILES
  src/CMakeLists.txt
  src/keystate.xml
  src/util/kmodifierkeyinfo.cpp
  src/util/kmodifierkeyinfoprovider.cpp
  src/util/kmodifierkeyinfoprovider_dummy.cpp
  src/util/kmodifierkeyinfoprovider_p.h
  src/util/kmodifierkeyinfoprovider_wayland.cpp
  src/util/kmodifierkeyinfoprovider_wayland.h
  src/util/kmodifierkeyinfoprovider_x11.cpp
  src/util/kmodifierkeyinfoprovider_xcb.cpp
  src/util/kmodifierkeyinfoprovider_xcb.h

To: apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[Aleix Pol Gonzalez]

apol added a dependent revision: D20192: Implement the keystate protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20191

To: apol, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

TEST PLAN
  Tested with both the lock screen and the keyboard indicator plasmoid

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20191

AFFECTED FILES
  src/client/protocols/keystate.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/keystate_interface.cpp
  src/server/keystate_interface.h

To: apol, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e4a244d0460e: Replace QDateTime::to_Time_t/from_Time_t 
with to/fromSecsSinceEpoch (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20162?vs=55185=55244

REVISION DETAIL
  https://phabricator.kde.org/D20162

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/kfileitem.cpp
  src/core/udsentry.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/widgets/previewjob.cpp

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:647171a56bb1: Simplify timestamp truncation in tests, use 
currentSecsSinceEpoch() (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20164?vs=55187=55246

REVISION DETAIL
  https://phabricator.kde.org/D20164

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:38db255da55b: Replace currentDateTimeUtc().toTime_t() 
with currentSecsSinceEpoch() (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20163?vs=55186=55245

REVISION DETAIL
  https://phabricator.kde.org/D20163

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/kntlm/kntlm.cpp

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/45/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 01 Apr 2019 23:13:22 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/53/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Apr 2019 23:13:22 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/57/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Apr 2019 23:13:22 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20095: Reduce the importance of some debug information so actual warnings can be seen.

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:4f132316c561: Reduce the importance of some debug 
information so actual warnings can be seen. (authored by apol).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20095?vs=55223=55243

REVISION DETAIL
  https://phabricator.kde.org/D20095

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp

To: apol, #plasma, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Aleix Pol Gonzalez]

apol added a comment.


  In D20181#441918 , @JJRcop wrote:
  
  > In D20181#441887 , @aacid wrote:
  >
  > > Can we use 
https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of 
doing this again?
  >
  >
  > I think that's out of scope for this patch. It should be done in another 
patch so we can refactor Frequency 

 and Length 

 to use KFormat as well.
  
  
  This can't be out of scope since as soon as you add it here we'll have to 
maintain API, so it can't actually be done as an iteration.
  
  Aleix

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: apol, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Noah Davis]

ndavis added a comment.


  In D20166#441863 , @kossebau wrote:
  
  > IMHO the SVG files in the repo may contain comments and metadatas, for 
further work on them. Like source code also has all the oomments and metadata.
  >  Only the deployed graphics resource should then be limited and optimized 
for what is needed at runtime.
  >
  > At least I had dealt with quite some "final rendered" SVG files I would 
have liked to modify for some needs, but could hardly as the base resources 
where not available (and if it was only guides & Co.).
  
  
  I can see where you're coming from, but guides left by other people aren't 
that useful in my experience. I still have to guess how they made their shapes 
in the first place and there
  's no comment field that's visible from within Inkscape. Nobody ever puts 
comments in the code either. As long as you know how to use a Grid, 
Group/Ungroup and Combine/Break Apart, it's not hard to edit most existing 
icons. The few that are hard would not be improved by in-code comments or 
guides.
  
  In D20166#441875 , @bruns wrote:
  
  > [...] Also, stripping any whitespace makes diffs of minor changes quite 
large, as diffs align on lines, not tokens.
  
  
  Then we can use optimization rules that auto format and indent everything. It 
will expand the size of color icons a lot more than monochrome icons, but maybe 
we can live with that.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Jonathan Rubenstein]

JJRcop added a comment.


  In D20181#441887 , @aacid wrote:
  
  > Can we use 
https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of 
doing this again?
  
  
  I think that's out of scope for this patch. It should be done in another 
patch so we can refactor Frequency 

 and Length 

 to use KFormat as well.

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Albert Astals Cid]

aacid added a comment.


  Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html 
instead of doing this again?

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Stefan Brüns]

bruns added a comment.


  In D20166#441854 , @ndavis wrote:
  
  > In D20166#441807 , @ngraham 
wrote:
  >
  > > Strictly speaking, there's no need to optimize the SVGs as a part of 
this, so maybe, yeah, let's split that out into a separate feature (and one 
that the Breeze Icons repo would ultimately be interested in as well).
  >
  >
  > Yes. Ideally, designers should optimize their work before it is landed or 
at least not submit an SVG with tons of metadata.
  
  
  On the other hand, this makes it harder for everyone else to do any changes 
later - think of e.g guides used for alignement. Also, stripping any whitespace 
makes diffs of minor changes quite large, as diffs align on lines, not tokens.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Keep desktoptheme SVG files uncompressed 
in repo, install (stripped) svgz" to "Keep desktoptheme SVG files uncompressed 
in repo, install svgz".
kossebau edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D20166#441854 , @ndavis wrote:
  
  > In D20166#441807 , @ngraham 
wrote:
  >
  > > Strictly speaking, there's no need to optimize the SVGs as a part of 
this, so maybe, yeah, let's split that out into a separate feature (and one 
that the Breeze Icons repo would ultimately be interested in as well).
  >
  >
  > Yes. Ideally, designers should optimize their work before it is landed or 
at least not submit an SVG with tons of metadata.
  
  
  IMHO the SVG files in the repo may contain comments and metadatas, for 
further work on them. Like source code also has all the oomments and metadata.
  Only the deployed graphics resource should then be limited and optimized for 
what is needed at runtime.
  
  At least I had dealt with quite some "final rendered" SVG files I would have 
liked to modify for some needs, but could hardly as the base resources where 
not available (and if it was only guides & Co.).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 55231.
kossebau added a comment.


  Remove stripping feature

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20166?vs=55191=55231

BRANCH
  uncompressedsvginrepo

REVISION DETAIL
  https://phabricator.kde.org/D20166

AFFECTED FILES
  CMakeLists.txt
  cmake/Findgzip.cmake
  src/desktoptheme/CMakeLists.txt
  src/desktoptheme/air/CMakeLists.txt
  src/desktoptheme/breeze/CMakeLists.txt
  src/desktoptheme/oxygen/CMakeLists.txt

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Noah Davis]

ndavis added a comment.


  In D20166#441807 , @ngraham wrote:
  
  > Strictly speaking, there's no need to optimize the SVGs as a part of this, 
so maybe, yeah, let's split that out into a separate feature (and one that the 
Breeze Icons repo would ultimately be interested in as well).
  
  
  Yes. Ideally, designers should optimize their work before it is landed or at 
least not submit an SVG with tons of metadata.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this looks good to me and works great! @broulik?

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Jonathan Rubenstein]

JJRcop updated this revision to Diff 55227.
JJRcop added a comment.


  Update @since from 5.57 to 5.58

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20181?vs=55218=55227

REVISION DETAIL
  https://phabricator.kde.org/D20181

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/binary_data.cpp
  src/binary_data_p.h
  src/converter.cpp
  src/unit.h

To: JJRcop, broulik, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Nathaniel Graham]

ngraham added a comment.


  Strictly speaking, there's no need to optimize the SVGs as a part of this, so 
maybe, yeah, let's split that out into a separate feature (and one that the 
Breeze Icons repo would ultimately be interested in as well).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20095: Reduce the importance of some debug information so actual warnings can be seen.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1, these are definitely unnecessarily noisy.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20095

To: apol, #plasma, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/56/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Apr 2019 19:10:29 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Nathaniel Graham]

ngraham added reviewers: broulik, Plasma, ngraham.
ngraham added a comment.


  Thanks very much for this, it looks great! This will land in 5.58 not 5.57 
since we don't typically commit patches with string changes in the last two 
weeks before frameworks tagging (which happens in five days, see 
https://community.kde.org/Schedules/Frameworks). So please change all the 
`@since` tags. Thanks!

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop, broulik, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/44/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 01 Apr 2019 19:10:29 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3623/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/52/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Apr 2019 19:10:28 +
 Build duration:
3 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D20095: Reduce the importance of some debug information so actual warnings can be seen.

[Aleix Pol Gonzalez]

apol updated this revision to Diff 55223.
apol added a comment.


  remove warning fix

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20095?vs=54992=55223

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20095

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D20166#441733 , @GB_2 wrote:
  
  > In D20166#441715 , @ndavis wrote:
  >
  > > Be careful that you are not stripping stylesheets when you use SVG 
Cleaner. `scour` is less effective than SVG Cleaner, but it doesn't strip 
stylesheets and it's available in more distros.
  >
  >
  > Yes, see 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
  
  
  Aha, thanks for the pointer, had not yet seen that wiki page. Indeed I now 
see that svgcleaner loses the styles, that's a blocker then. I knew I should 
set the default of stripping to OFF, as I was not yet sure how to test the 
equality of the results, besides superficial visual comparisons. scour broke 
more in my eyes on first tests, so I had not continued that, also was I not 
sure about the dependencies this pulls in (e..g for packagers). Guess I should 
add another option which stripping tool to use? :P
  Or rather remove the stripping from this patch again for now, until we have 
one tool which reliably works for our needs.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Jonathan Rubenstein]

JJRcop retitled this revision from "Adds Binary Data units (bits, kilobytes, 
kibibytes ... yottabytes)" to "Add Binary Data units (bits, kilobytes, 
kibibytes ... yottabytes)".

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D20181

To: JJRcop
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20063: Sublime Merge Icon.

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much @otavva! If you've found this process enjoyable and rewarding, 
there are plenty more icons needed! :)
  
  See 
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=Icons_id=1604229=Breeze_format=advanced

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, cblack, 
arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D20181: Adds Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

[Jonathan Rubenstein]

JJRcop created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
JJRcop requested review of this revision.

REVISION SUMMARY
  New data category BinaryDataCategory featuring bits and bytes, both SI units 
and powers of two, from normal bits all the way up to Yibibytes.
  
  This only features ( positive SI prefix | IEC power of two prefix ) + ( bits 
| bytes ), and does not include units like nibbles (half a byte), octets 
(alternative form of byte), or prefixes that are less than 1. My reasoning 
behind this is to keep it clean and uncluttered, but I do not mind adding them 
if asked.
  
  FEATURE: 402798
  
  F6743030: Screenshot_20190401_134414.png 
 F6743029: Screenshot_20190401_13.png 


REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D20181

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/binary_data.cpp
  src/binary_data_p.h
  src/converter.cpp
  src/unit.h

To: JJRcop
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Björn Feber]

GB_2 added a comment.


  In D20166#441715 , @ndavis wrote:
  
  > Be careful that you are not stripping stylesheets when you use SVG Cleaner. 
`scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets 
and it's available in more distros.
  
  
  Yes, see 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Noah Davis]

ndavis added a comment.


  Be careful that you are not stripping stylesheets when you use SVG Cleaner. 
`scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets 
and it's available in more distros.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20172: use plasma icon as icon for plasma notification category

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:8ce99b1637ef: use plasma icon as icon for plasma 
notification category (authored by sitter).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20172?vs=55203=55212

REVISION DETAIL
  https://phabricator.kde.org/D20172

AFFECTED FILES
  plasma_workspace.notifyrc

To: sitter, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20176: make start-here-kde also available start-here-kde-plasma

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20176

To: sitter, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D20166#441653 , @ngraham wrote:
  
  > Strong +1 on the idea. Shouldn't we put these `Find.cmake` files in 
ECM though? The Breeze icons repo could definitely benefit from 
`FindSVGCleaner` to automatically post-process the SVGs for example.
  
  
  Agreed. Though being cautious by nature, I wanted to first see how this works 
out for the Plasma themes, before applying the same for the Breeze icons & any 
other SVG resources. Compare also the comment added in 
src/desktoptheme/CMakeLists.txt:
  
# Helper function, private for now
# Once it has matured and proven, add to public macros
  
  So not being an urgent fix, I would have waited at least 2-3 KF releases, 
before pushing this further onto the stack and silblings. But that's just me, 
if majority already wants this now, would do the needed bits.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20176: make start-here-kde also available start-here-kde-plasma

[Kai Uwe Broulik]

broulik added a comment.


  Imho when we did the rebranding we should have added a `start-here-plasma` 
icon and switch to that everywhere rather than blatantly changing the 
`start-here-kde` icon +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20176

To: sitter
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Nathaniel Graham]

ngraham added a comment.


  Strong +1 on the idea. Shouldn't we put these `Find.cmake` files in 
ECM though? The Breeze icons repo could definitely benefit from 
`FindSVGCleaner` to automatically post-process the SVGs for example.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: ngraham, fvogt, kde-frameworks-devel, michaelh, bruns

D20176: make start-here-kde also available start-here-kde-plasma

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the latter offers a less ambiguous name when we want to refer to something
  plasma specific. a recent example is D20172 
 which defines the icon for
  something related to the Plasma workspace, as such the start-here-kde icon
  may not be the most appropriate across all icon themes (i.e. if the icon
  is in fact the KDE logo it's not what we want). conversely an icon theme
  cannot offer a real start-here-kde since we use it in place of a plasma
  variant.
  
  with the additional name we'd be free to use less ambiguous icon references
  in the future.
  also, because of how icon naming works themes that provide start-here-kde
  but not start-here-kde-plasma would still fall back to start-here-kde

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20176

AFFECTED FILES
  icons-dark/places/16/start-here-kde-plasma.svg
  icons-dark/places/22/start-here-kde-plasma.svg
  icons-dark/places/64/start-here-kde-plasma.svg
  icons/places/16/start-here-kde-plasma.svg
  icons/places/22/start-here-kde-plasma.svg
  icons/places/64/start-here-kde-plasma.svg

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20172: use plasma icon as icon for plasma notification category

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  > Oh, on a related note, I actually do wonder if we should symlink 
start-here-kde in breeze to start-here-kde-plasma and use that instead to 
differentiate? As per the spec on !breeze icon themes start-here-kde-plasma 
would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So 
it's just as portable but less ambiguous perhaps.
  
  We should.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20172: use plasma icon as icon for plasma notification category

[Harald Sitter]

sitter added a comment.


  Oh, on a related note, I actually do wonder if we should symlink 
start-here-kde in breeze to start-here-kde-plasma and use that instead to 
differentiate? As per the spec on !breeze icon themes start-here-kde-plasma 
would fall back to start-here-kde if the plasma icon doesn't exist IIRC. So 
it's just as portable but less ambiguous perhaps.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20172: use plasma icon as icon for plasma notification category

[Harald Sitter]

sitter retitled this revision from "use the plasma icon as plasma icon" to "use 
plasma icon as icon for plasma notification category".

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20172: use the plasma icon as plasma icon

[Harald Sitter]

sitter added a comment.


  before
  F6742443: Screenshot_20190401_173503.png 

  
  after
  F6742444: Screenshot_20190401_173529.png 


REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D20172

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20172: use the plasma icon as plasma icon

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  kde is the kde logo, start-here-kde is our app menu icon which is the
  plasma icon

TEST PLAN
  icon lovely now

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20172

AFFECTED FILES
  plasma_workspace.notifyrc

To: sitter, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar added a comment.


  As you see, not only the menu is changed, so I update this diff for your 
approval.
  
  > I think this works well enough to be added.
  
  Harr, I found it now not good enough and spend some more time for this. Looks 
now nicely to me. The view still jumps slightly around but that may be go away 
by D17857 , but not tested.

REVISION DETAIL
  https://phabricator.kde.org/D19517

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller added a reviewer: hindenburg.
mschiller removed a subscriber: kde-frameworks-devel.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg
Cc: michaelh, ngraham, bruns, kde-frameworks-devel

D20169: Add profile support interface for TerminalInterface

[Maximilian Schiller]

mschiller created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mschiller requested review of this revision.

REVISION SUMMARY
  This enables handling profiles for the active konsolepart and has to
  be implemented by konsole.

REPOSITORY
  R306 KParts

BRANCH
  terminal-interface-profiles (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20169

AFFECTED FILES
  src/kde_terminal_interface.h

To: mschiller
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

[loh tar]

loh.tar updated this revision to Diff 55199.
loh.tar added a comment.


  - Ensure the view jumps not back when user scrolls around
  - Don't reload while user scrolls
  - Fix missing connect to auto reload slot when enabled by modOnHdHandler
  - Change menu
  
  F6742373: 1554131807.png 

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19517?vs=53891=55199

REVISION DETAIL
  https://phabricator.kde.org/D19517

AFFECTED FILES
  src/data/katepart5ui.rc
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, ngraham, bruns, demsking, sars

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  While the main purpose of this patch is to have SVG files in the repo, the 
processing to optimize runtime load is an interesting side-effect.
  
  If you are curious about some numbers, here the install size estimated with 
`du -chb` for the respective subfolders `desktoptheme/$theme`, with `strip` 
meaning the flags to svgcleaner as in the current patch:
  
  |  | breeze| air   | oxygen|
  | old: | 1.236.245 | 1.762.968 | 864.292   |
  | strip+z: | 1.105.389 | 1.605.054 | 739.340   |
  | z:   | 1.231.078 | 1.762.734 | 875.083   |
  | strip:   | 2.250.847 | 4.071.777 | 3.164.541 |
  | svg 1:1: | 3.130.982 | 5.624.588 | 4.777.657 |
  |
  
  So with Oxygen there is a small increase when using gzip only, compared to 
before. Seems for some files inkscape or what stored those files before was 
more efficient compared to `gzip -9`.
  IMHO the increase of 10791 is not that awful, after all in the long term we 
surely want to recommend the usage of the stripped variant. And for Breeze, 
after all the default, the plain gzip variant already gains 5167, so even 
without stripping the install size is in total not that much affected.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

[Volker Krause]

vkrause added a comment.


  Yep, code looks good to me too, so +1 on this :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

[Kai Uwe Broulik]

broulik added a comment.


  So, in essence you're fine with adding the enum as it is, and then have some 
mapping in the Android code? :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20149: Fix compilation

[Stefan Brüns]

bruns added a comment.


  Although s_magic **decays** to a char*, it **is not** a char*. char[n] is a 
type distinct from char*
  
  From e.g. man strlen
  
char string[32] = "hello, world";
char *ptr = string;
sizeof (string)
⇒ 32
sizeof (ptr)
⇒ 4  /* (on a machine with 4 byte pointers) */

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D20149

To: aacid, svuorela
Cc: bruns, svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 55191.
kossebau added a comment.


  Fix some naming inconsistencies one only sees when looking at a patch
  through another viewer (like the phabricator review page :))

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20166?vs=55189=55191

BRANCH
  uncompressedsvginrepo

REVISION DETAIL
  https://phabricator.kde.org/D20166

AFFECTED FILES
  CMakeLists.txt
  cmake/Findgzip.cmake
  cmake/Findsvgcleaner.cmake
  src/desktoptheme/CMakeLists.txt
  src/desktoptheme/air/CMakeLists.txt
  src/desktoptheme/breeze/CMakeLists.txt
  src/desktoptheme/oxygen/CMakeLists.txt

To: kossebau, #plasma, #vdg
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20164

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20162

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20163

To: bruns, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> fvogt wrote in CMakeLists.txt:15
> You could make this optional and set the `STRIP_DESKTOPTHEME_SVG` default 
> depending on whether it's found.

Personally I favour the buildsystem not to randomly do what it can given the 
current system state, but only do what I explicitly tell it to do or what the 
default is. But whatever majority prefers.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Fabian Vogt]

fvogt added a comment.


  I'm very much in favor of this, but don't know anything about the cmake magic 
involved, so can't really say much about that.

INLINE COMMENTS

> CMakeLists.txt:15
> +set_package_properties(svgcleaner PROPERTIES
> +TYPE REQUIRED
> +)

You could make this optional and set the `STRIP_DESKTOPTHEME_SVG` default 
depending on whether it's found.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

Heads-up: EXCLUDE_FROM_ALL behaviour change in CMake >= 3.14

[Christophe Giboudeaux]

Hi,

Short notice: the EXCLUDE_FROM_ALL behaviour changed in CMake >= 3.14.0 when 
used with add_subdirectories().

EXCLUDE_FROM_ALL now also affects all the targets inside the directory.[1][2]

e.g:
add_subdirectory(foo EXCLUDE_FROM_ALL)

Before:
Targets defined in this directory are not built when running 'make' but can be 
built using 'make -C foo'.

After:
'make -C foo' will not build anything.

Projects concerned by this change:
- kdev-pg-qt, 'make -C examples' does nothing with CMake 3.14
- kooka, 'make -C tools' won't build them

[1] https://cmake.org/cmake/help/v3.14/prop_tgt/EXCLUDE_FROM_ALL.html?
highlight=exclude_from_all
[2] https://cmake.org/cmake/help/v3.14/command/add_subdirectory.html?
highlight=add_subdirectory

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  SVGZ -> SVG conversion of all files not included in this uploaded patch, to 
keep it reviewable.
  
  Locally do this:
  
  Store a file `svgztosvg.sh` with this content in `src/desktoptheme`:
  
#!/bin/sh

SVGZ=$1

if [ ! -f "$SVGZ" ]; then
echo "File not found: \"$SVGZ\""
exit 1
fi

SVG=${SVGZ%.svgz}.svg

zcat $SVGZ > $SVG
rm $SVGZ
  
  Then on the commandline do this:
  
cd plasma-framework/src/desktoptheme
find . -name "*.svgz" -exec sh svgztosvg.sh {} \;
  
  Once done, do e.g. this to restore SVGZ files:
  
find . -name "*.svg" -exec rm {} \;
git checkout air breeze oxygen

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20149: Fix compilation

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ora.cpp:21
>  static constexpr char s_magic[] = "image/openraster";
> -static constexpr int s_magic_size = strlen(s_magic);
> +static constexpr int s_magic_size = sizeof(s_magic) - 1; // -1 to remove the 
> last \0
>  

Won't sizeof give the sizeof(char*)?

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D20149

To: aacid, svuorela
Cc: svuorela, apol, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The SVG format being based on plain text, storing the SVG in the repository
  not as .svgz, but .svg, helps both VCS tools (patching, showing diffs) as
  well as allows some developers to edit the SVG directly in any text editor,
  not only those which support automatic conversion from/to gzip format.
  
  While most artists will continue (and which shall be okay) to use GUI
  editors like inkscape, which might rewrite the complete structure on saving,
  using uncompressed format in the repo still allows the occasional direct
  edit of the text, .e.g. to change a colour, which then is also easily seen
  in the commit diff.
  
  To still keep the svgz format when deployed, a build step is introduced,
  which uses gzip to create svgz files in the build dir. This conversion can
  be controlled using the option GZIP_DESKTOPTHEME_SVG (default: ON).
  
  With such a build processing in place for SVG files, next to that an
  optional stripping of the installed SVG files is added, which removes data
  which is not needed for rendering, e.g. indentation whitespaces or
  editor-only XML data. This experimental stripping can be controlled using
  the option STRIP_DESKTOPTHEME_SVG (default: OFF).

TEST PLAN
  Themes are still working (with & without cache removed).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  uncompressedsvginrepo

REVISION DETAIL
  https://phabricator.kde.org/D20166

AFFECTED FILES
  CMakeLists.txt
  cmake/Findgzip.cmake
  cmake/Findsvgcleaner.cmake
  src/desktoptheme/CMakeLists.txt
  src/desktoptheme/air/CMakeLists.txt
  src/desktoptheme/breeze/CMakeLists.txt
  src/desktoptheme/oxygen/CMakeLists.txt

To: kossebau, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Instead of creating a full resolution timestamp and converting it to
  second granularity, just use the appropriate call directly.

REPOSITORY
  R241 KIO

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20164

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  toTime_t() is obsolete since Qt 5.8, and currentSecsSinceEpoch() is
  faster.

REPOSITORY
  R241 KIO

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20163

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/kntlm/kntlm.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

[Volker Krause]

vkrause added a comment.


  I was looking at 
https://developer.android.com/training/notify-user/channels#importance which 
also has IMPORTANCE_LOW mapped to "medium". But yes, it's basically just about 
finding a suitable mapping, even if we don't cover every possible level on 
Android.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QDateTime::toSecsSinceEpoch obsoletes to_Time_t, likewise for from_Time_t.
  Both functions are available since Qt 5.8.

REPOSITORY
  R241 KIO

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D20162

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/kfileitem.cpp
  src/core/udsentry.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/widgets/previewjob.cpp

To: bruns, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Apr 2019 10:33:09 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/55/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Apr 2019 10:02:32 +
 Build duration:
1 hr 21 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20158: Allow to set urgency for notifications

[Kai Uwe Broulik]

broulik added a comment.


  In D20158#441322 , @vkrause wrote:
  
  > Nicely fits with the Android backend too, although that has one extra level 
(low, medium, high, urgent).
  
  
  I found the following enums in `NotificationManager`:
  
  - `IMPORTANCE_NONE`: won't even show up
  - `IMPORTANCE_MIN`: could be mapped to `Low`?
  - `IMPORTANCE_DEFAULT`: well, the default, `Normal`
  - `IMPORTANCE_HIGH`: could be mapped to `Critical`
  - `IMPORTANCE_MAX` "unused"

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven updated this revision to Diff 55183.
meven marked an inline comment as done.
meven added a comment.


  Fix position of default in switch statement

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20096?vs=55182=55183

BRANCH
  creation-date

REVISION DETAIL
  https://phabricator.kde.org/D20096

AFFECTED FILES
  src/ioslaves/file/file.cpp
  tests/kioslavetest.cpp

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> bruns wrote in file.cpp:932
> statx.stx_size is __u64, and readlink uses (unsigned) size_t for the buffer 
> size.

Let me know if I have handled this correctly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven updated this revision to Diff 55182.
meven added a comment.


  Add AT_SYMLINK_NOFOLLOW flag to statx call matching lstat behavior, use 
size_t type for readlink parameter, avoid a warning correct signedness of statx 
struct accessors

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20096?vs=55147=55182

BRANCH
  creation-date

REVISION DETAIL
  https://phabricator.kde.org/D20096

AFFECTED FILES
  src/ioslaves/file/file.cpp
  tests/kioslavetest.cpp

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20047: Add X-GNOME-UsesNotifications as recognized key

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:1c783fd26c91: Add X-GNOME-UsesNotifications as recognized 
key (authored by broulik).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20047?vs=54789=55180

REVISION DETAIL
  https://phabricator.kde.org/D20047

AFFECTED FILES
  src/services/application.desktop

To: broulik, #frameworks, apol, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:dc3dd35d36c4: [KCModuleLoader] Pass args to created 
KQuickAddons::ConfigModule (authored by broulik).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20065?vs=54870=55179

REVISION DETAIL
  https://phabricator.kde.org/D20065

AFFECTED FILES
  src/kcmoduleloader.cpp

To: broulik, #frameworks, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/54/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 01 Apr 2019 07:48:44 +
 Build duration:
2 hr 13 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20158: Allow to set urgency for notifications

[Volker Krause]

vkrause added a comment.


  Nicely fits with the Android backend too, although that has one extra level 
(low, medium, high, urgent).

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, Frameworks, vkrause, ogoffart, mck182.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This lets the application set an urgency hint on the notification, which can 
be low, normal, or critical.
  The notification server can then apply different behavior, e.g. show critical 
notifications on top of full screen windows, or suppress low urgency 
notifications by default.
  
  See https://developer.gnome.org/notification-spec/#urgency-levels

TEST PLAN
  - Put `Urgency=Critical` into a notifyrc file, had it send the hint "2"

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D20158

AFFECTED FILES
  src/knotification.cpp
  src/knotification.h
  src/knotificationmanager.cpp
  src/notifybypopup.cpp

To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20039: [KConfig] Add Notify capability for revertToDefault

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:cad4889e490f: Add Notify capability to revertToDefault 
(authored by broulik).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20039?vs=54765=55167

REVISION DETAIL
  https://phabricator.kde.org/D20039

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kentrymaptest.cpp
  src/core/kconfig.cpp
  src/core/kconfig_p.h
  src/core/kconfigdata.cpp
  src/core/kconfigdata.h
  src/core/kconfiggroup.cpp
  src/core/kconfiggroup.h

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/51/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Apr 2019 08:12:52 +
 Build duration:
4 min 36 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3623/13364)18%
(1813/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/43/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 01 Apr 2019 08:12:52 +
 Build duration:
4 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D20070: [PlasmaComponents3 ComboBox] Fix textColor

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d868804a7fe4: [PlasmaComponents3 ComboBox] Fix textColor 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20070?vs=54892=55165

REVISION DETAIL
  https://phabricator.kde.org/D20070

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml

To: broulik, #plasma, mart, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/42/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 01 Apr 2019 07:48:44 +
 Build duration:
7 min 57 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/50/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Apr 2019 07:48:44 +
 Build duration:
6 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1814/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(310/1715)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%

D14724: autotests: don't fail if an unrelated window shows up.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14724

To: dfaure, hein, drosca, broulik, davidedmundson, jtamate
Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D14724: autotests: don't fail if an unrelated window shows up.

[Jaime Torres Amate]

jtamate accepted this revision.
jtamate added a comment.
This revision is now accepted and ready to land.


  As I don't have enough contiguous free time even to test it again, feel free 
to commit. 
  You can add a comment to remember that it doesn't fix all the cases but is an 
improvement over previous situation.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14724

To: dfaure, hein, drosca, broulik, davidedmundson, jtamate
Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns