D20238: device: include Reapply() in the interface

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> device.h:241
> + */
> +QDBusPendingReply<> reapplyInterface(NMVariantMapMap connection, 
> qulonglong version_id, uint flags);
>  /**

1. const NMVariantMapMap 

2. I would maybe pick a different name, because it doesn't reapply interface, 
but it reapplies or updates connection. I would maybe use "reapplyConnection()"

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: arvidhansson; removed: ndavis.
ndavis added a comment.


  Alright. I'll finish it when I have time.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: ndavis, #vdg, arvidhansson
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 55383.
kossebau added a comment.


  Remove last bit about stripping that was still in the patch

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20166?vs=55231=55383

BRANCH
  uncompressedsvginrepo

REVISION DETAIL
  https://phabricator.kde.org/D20166

AFFECTED FILES
  CMakeLists.txt
  cmake/Findgzip.cmake
  src/desktoptheme/CMakeLists.txt
  src/desktoptheme/air/CMakeLists.txt
  src/desktoptheme/breeze/CMakeLists.txt
  src/desktoptheme/oxygen/CMakeLists.txt

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

[Nibaldo González]

nibags updated this revision to Diff 55382.
nibags added a comment.


  - Update tests

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20221?vs=55378=55382

BRANCH
  arcpatch-D20221

REVISION DETAIL
  https://phabricator.kde.org/D20221

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17991: Refactor the way device backends are built and registered

[Pino Toscano]

pino added a comment.


  BTW if nobody will comment on this within one month, I will commit it as-is.
  
  4 months without a review will be enough, considering also other reviews for 
Solid got comments/approvals.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D17991

To: pino
Cc: #android, #windows, #freebsd, apol, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20238: device: include Reapply() in the interface

[Aleksander Morgado]

aleksanderm updated this revision to Diff 55379.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20238?vs=55377=55379

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20238: device: include Reapply() in the interface

[Aleksander Morgado]

aleksanderm created this revision.
aleksanderm added reviewers: jgrulich, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
aleksanderm requested review of this revision.

REVISION SUMMARY
  The NetworkManager::Device interface was lacking the support for reapplying 
settings during runtime.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

[Nibaldo González]

nibags updated this revision to Diff 55378.
nibags added a comment.


  - Apply changes in apparmor.xml, remove selinux-*.xml changes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20221?vs=55368=55378

BRANCH
  arcpatch-D20221

REVISION DETAIL
  https://phabricator.kde.org/D20221

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17991: Refactor the way device backends are built and registered

[Pino Toscano]

pino updated this revision to Diff 55373.
pino added a comment.


  Rebase on master.

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17991?vs=51892=55373

BRANCH
  cmake-backends-refactor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17991

AFFECTED FILES
  CMakeLists.txt
  cmake/SolidBackendsMacros.cmake
  src/solid/devices/CMakeLists.txt
  src/solid/devices/backends/fakehw/CMakeLists.txt
  src/solid/devices/backends/fstab/CMakeLists.txt
  src/solid/devices/backends/hal/CMakeLists.txt
  src/solid/devices/backends/iokit/CMakeLists.txt
  src/solid/devices/backends/udev/CMakeLists.txt
  src/solid/devices/backends/udisks2/CMakeLists.txt
  src/solid/devices/backends/upower/CMakeLists.txt
  src/solid/devices/backends/win/CMakeLists.txt
  src/solid/devices/managerbase.cpp

To: pino
Cc: #android, #windows, #freebsd, apol, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20220: AppArmor & SELinux: remove one indentation in XML files

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:508be5417e67: AppArmor  SELinux: remove one 
indentation in XML files (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20220?vs=55366=55371

REVISION DETAIL
  https://phabricator.kde.org/D20220

AFFECTED FILES
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20220: AppArmor & SELinux: remove one indentation in XML files

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  remove-indentation

REVISION DETAIL
  https://phabricator.kde.org/D20220

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

[Nibaldo González]

nibags updated this revision to Diff 55368.
nibags added a comment.


  - Fix some indentations
  - Remove selinux-*.xml changes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20221?vs=55367=55368

BRANCH
  remove-indentation

REVISION DETAIL
  https://phabricator.kde.org/D20221

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

[Nibaldo González]

nibags updated this revision to Diff 55367.
nibags added a comment.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.


  - Remove "alias" in the "_end_rule" context and add some comments

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20221?vs=55327=55367

BRANCH
  update-apparmor

REVISION DETAIL
  https://phabricator.kde.org/D20221

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20230: Allow building without UDev on Linux

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  That's a good reason to do it at compile time :D

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20230

To: apol, #frameworks, davidedmundson
Cc: asturmlechner, davidedmundson, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20230: Allow building without UDev on Linux

[Aleix Pol Gonzalez]

apol added a comment.


  I don't really remember the reason why we can't use udev there, it was more 
of a "it can be there but it will be useless", then there was a very long 
discussion with "what if I..." and people saying that udev needed redesigning. 
It was few years ago.
  At the moment if we don't patch it out it just won't build.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20230

To: apol, #frameworks
Cc: asturmlechner, davidedmundson, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20220: AppArmor & SELinux: remove one indentation in XML files

[Nibaldo González]

nibags updated this revision to Diff 55366.
nibags added a comment.


  - Fix some indentations

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20220?vs=55325=55366

BRANCH
  remove-indentation

REVISION DETAIL
  https://phabricator.kde.org/D20220

AFFECTED FILES
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#439120 , @ndavis wrote:
  
  > In D19952#439031 , @arvidhansson 
wrote:
  >
  > > In D19952#438965 , @ndavis 
wrote:
  > >
  > > > The rounded corners and bold 1 are not very breeze like, so I don't 
think so, unless he changes his design. Unless you still plan to do the icon 
yourself, you should probably hand off responsibility for the patch to someone 
else.
  > >
  > >
  > > Sorry for the confusion, as I'm new to this I really need help and aren't 
able to do this alone, just just wanted to bring some attention to this and 
learn how to work with KDE. Thanks for all help, should we now use t-ask's 
first icon(the right one) or something else?
  >
  >
  > No problem, it's just unfortunate that you picked an issue where other 
people already had their own ideas planned. If there weren't more than 1 design 
to look at, it would be easier for me to work with you 1-on-1. Why don't you 
try making an icon for an app you like that doesn't already have an icon in 
Breeze Icons? Not Firefox, Thunderbird or proprietary software (although there 
might be some exceptions). If you have questions, bring them up in the VDG chat.
  
  
  Okay, I don't think I should work with this anymore, just wantet to fix this 
bug: https://bugs.kde.org/show_bug.cgi?id=391134. Please complete this yourself.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, michaelh, bruns

D20233: Add syntax highlighting for fish shell

[Arnd Diestelhorst]

adiestelhorst created this revision.
adiestelhorst added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
adiestelhorst requested review of this revision.

REVISION SUMMARY
  For fish shell version 2.7.1
  
  References
  http://fishshell.com/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D20233

AFFECTED FILES
  autotests/folding/highlight.fish.fold
  autotests/html/highlight.fish.html
  autotests/input/highlight.fish
  autotests/reference/highlight.fish.ref
  data/syntax/fish.xml

To: adiestelhorst
Cc: kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis added a comment.


  In D20226#442934 , @bruns wrote:
  
  > Diagonal or round shapes are **not** required to be pixel grid aligned. 
Actually, it is not even possible, as there is **always** some antialiasing. It 
even helps to make round shapes a little bit bit larger than the pixel grid, so 
some of the corner/edge pixels are solid color.
  
  
  I'm aware, but that's not the problem. If you look at the left side of the 
bell and the right side, the right side is wider. Maybe it's not that visible 
at 100%/96 DPI, but we should try to have resizable and reusable shapes when 
possible.
  
  F6749114: Screenshot_20190403_112343.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D20226: Add "notifications" and "notifications-disabled" icons

[Stefan Brüns]

bruns added a comment.


  In D20226#442902 , @ndavis wrote:
  
  > The proportions aren't quite right.
  >
  > F6749114: Screenshot_20190403_112343.png 

  >
  > This is one way to make a perfectly smooth bell. Subtract the red shapes 
from the black shapes.
  >
  > F6749117: Screenshot_20190403_112550.png 

  >
  > the result is this: F6749121: notifications.svg 

  
  
  Diagonal or round shapes are **not** required to be pixel grid aligned. 
Actually, it is not even possible, as there is **always** some antialiasing. It 
even helps to make round shapes a little bit bit larger than the pixel grid, so 
some of the corner/edge pixels are solid color.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, 
michaelh

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar updated this revision to Diff 55355.
loh.tar edited the test plan for this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Bring back call of view->slotTextInserted
  
  I think it's ready for a new review

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19446?vs=55346=55355

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20230: Allow building without UDev on Linux

[David Edmundson]

davidedmundson added a comment.


  What happens if this is not patched out?
  
  I'm asking because I'm hoping to use bwrap in more places outside of flatpak. 
In that case I'm going to need runtime detection.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20230

To: apol, #frameworks
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D20230: Allow building without UDev on Linux

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Flatpak has been patching this for a while, there doesn't seem to be a way to
  use it there, so we better offer the option upstream.

TEST PLAN
  Been building and using solid on flatpak runtimes for a while.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20230

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis added a comment.


  In D20226#442906 , @GB_2 wrote:
  
  > In D20226#442882 , @ngraham 
wrote:
  >
  > > Also, could we create a 22x22 version too?
  >
  >
  > How can you efficiently do that without having to realign everything to the 
new grid manually?
  
  
  You'll have to create it from scratch again, using the same method you used 
to create the 16px version. If you use the method that I just showed you, it'll 
be much easier than drawing it, but you still need to figure out how to get 
proportions that look right.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Björn Feber]

GB_2 added a comment.


  In D20226#442882 , @ngraham wrote:
  
  > Also, could we create a 22x22 version too?
  
  
  How can you efficiently do that without having to realign everything to the 
new grid manually?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Noah Davis]

ndavis added a comment.


  The proportions aren't quite right.
  
  F6749114: Screenshot_20190403_112343.png 

  
  This is one way to make a perfectly smooth bell. Subtract the red shapes from 
the black shapes.
  
  F6749117: Screenshot_20190403_112550.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, 
bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Nathaniel Graham]

ngraham added a comment.


  In D20226#442844 , @GB_2 wrote:
  
  > In D20226#442841 , @ngraham 
wrote:
  >
  > > +1 in general. However the fact that this black version doesn't match the 
outline/dimensions of the colored version 
(`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think 
you could match the dimensions of that icon?
  >
  >
  > Is that even allowed/possible with this 16x16 resolution?
  >  The padding rules of this resolution don't allow it to be higher.
  
  
  Hmm, well the big issue I see is that the bottom of the colored version 
flares out much more than the bottom of this one does:
  
  F6749058: The two icons.gif 
  
  If that's possible to change within the 16x16 margins, I'll accept it.
  
  Also, could we create a 22x22 version too?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar updated this revision to Diff 55346.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Ensure the new added brackets will not be part of the selection when 
selection was done from right->left
  - Enhance autotest
  
  There is already toVirtualColumn used by rangeOnLine() and I have no idea how 
to fix the remaining issues, maybe you. 
  F6749018: 1554301567.png 
  In the pic was the selection always done from right->left which seems to be 
the problems to increase. Everything looks good (even it looks odd) except the 
highlighted case.
  The problem occurs when the selection start/end has mixed(different) 
space/tabs. The block below the highlighted is the same but works fine. So I 
think rangeOnLine() may need an improved.
  
KTextEditor::Range 
KTextEditor::DocumentPrivate::rangeOnLine(KTextEditor::Range range, int line) 
const
{
const int col1 = toVirtualColumn(range.start());
const int col2 = toVirtualColumn(range.end());
return KTextEditor::Range(line, fromVirtualColumn(line, col1), line, 
fromVirtualColumn(line, col2));
}

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19446?vs=55303=55346

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17355: Align Plasma QML button content in center if it has an icon

[Björn Feber]

GB_2 abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17355

To: GB_2, #plasma, #vdg
Cc: mart, davidedmundson, apol, ngraham, #vdg, kde-frameworks-devel, #plasma, 
cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, michaelh, 
crozbo, ndavis, ZrenBot, firef, bruns, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, mbohlender

D20226: Add "notifications" and "notifications-disabled" icons

[Andres Betts]

abetts added a comment.


  In D20226#442854 , @GB_2 wrote:
  
  > Move bell's pendulum
  
  
  Love it!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Björn Feber]

GB_2 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Björn Feber]

GB_2 updated this revision to Diff 55347.
GB_2 added a comment.


  Move bell's pendulum

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20226?vs=55339=55347

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Andres Betts]

abetts added a comment.


  The line that goes across almost completely removes the bell's pendulum to 
the right. Maybe move the pendulum closer to the center so that even when there 
is that red strike line, the user can still make out that it is a notification 
bell

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Björn Feber]

GB_2 added a comment.


  In D20226#442841 , @ngraham wrote:
  
  > +1 in general. However the fact that this black version doesn't match the 
outline/dimensions of the colored version 
(`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think 
you could match the dimensions of that icon?
  
  
  Is that even allowed/possible with this 16x16 resolution?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Nathaniel Graham]

ngraham added a comment.


  +1 in general. However the fact that this black version doesn't match the 
outline/dimensions of the colored version 
(`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think 
you could match the dimensions of that icon?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20226

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20169: Add profile support interface for TerminalInterface

[Kurt Hindenburg]

hindenburg added a reviewer: Frameworks.

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D20169

To: mschiller, hindenburg, #konsole, #frameworks
Cc: michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/62/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 03 Apr 2019 13:25:25 +
 Build duration:
6 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3323/3975)47%
(4471/9539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1092/1120)49%
(2289/4707)src79%
(22/28)79%
(22/28)79%
(1212/1537)43%
(476/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/57/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 03 Apr 2019 13:25:25 +
 Build duration:
2 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.57.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)84%
(3323/3975)47%
(4471/9539)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1092/1120)49%
(2289/4707)src79%
(22/28)79%
(22/28)79%
(1212/1537)43%
(476/1116)src.extractors100%
(13/13)100%
(13/13)78%
(961/1233)46%
(1635/3561)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/62/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 03 Apr 2019 13:25:25 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20219: Propose Stefan Bruns as KFileMetaData maintainer

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:79db0d55b933: Propose Stefan Bruns as KFileMetaData 
maintainer (authored by apol).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20219?vs=55323=55342

REVISION DETAIL
  https://phabricator.kde.org/D20219

AFFECTED FILES
  metainfo.yaml

To: apol, #frameworks, mgallien
Cc: mgallien, bruns, ngraham, astippich, kde-frameworks-devel, #baloo, gennad, 
domson, ashaposhnikov, michaelh, spoorun, abrahams

D20225: use more appropriate plasma-specific icon for plasma category

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:bf27abdb08eb: use more appropriate plasma-specific icon 
for plasma category (authored by sitter).

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20225?vs=55336=55340

REVISION DETAIL
  https://phabricator.kde.org/D20225

AFFECTED FILES
  plasma_workspace.notifyrc

To: sitter, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20226: Add "notifications" and "notifications-disabled" icons

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  BUG: 406121
  Needed for the upcoming do not disturb mode and overhauled notifcations.
  F6748683: notifications Icon.png 
  F6748684: notifications-disabled Icon.png 


TEST PLAN
  Search for "notifications" in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-notifications-and-notifications-disabled-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20226

AFFECTED FILES
  icons-dark/actions/16/notifications-disabled.svg
  icons-dark/actions/16/notifications.svg
  icons/actions/16/notifications-disabled.svg
  icons/actions/16/notifications.svg

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

[Harald Sitter]

sitter updated this revision to Diff 55338.
sitter added a comment.


  - defaultFilePath is now static in the cpp only, the public ctor defaults to 
QString() for the filePath, which gets checked in the private ctor and diverted 
to defaultFilePath if necessary
  - Private ctor now copies filePath as we may need to change it to 
defaultFilePath
  - = and \# parsing revisitede
- new helper splitEntry mids the line at first = character only preventing 
= characters in pretty strings from tripping up the parsing
- \# characters that are not the first character in the line are now not 
explicitly causing a line skip as far as entry parsing is concerned. I think 
this is actually a more truthful implementation of the format specification. 
since the spec doesn't even mention trailing \# we can do whatever with them 
and not skipping entire lines outright seems like the nicer solution here
  - api docs updated accordingly. now clearly states that trailing comments 
result in undefined behavior
  - test and fixture updated to make sure = and \# work in pretty string and 
that completely invalid lines are skipped
  - parsing skips now produce categorized warnings
  
  I am wondering if from an API POV it'd be nicer if we maybe had two ctors 
(one default, one with QString) so we can let initalizer lists handle whether 
the defaults apply or not.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20092?vs=54993=55338

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20092

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/os-release
  autotests/kosreleasetest.cpp
  src/lib/CMakeLists.txt
  src/lib/util/kosrelease.cpp
  src/lib/util/kosrelease.h

To: sitter, apol, mpyne
Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20225: use more appropriate plasma-specific icon for plasma category

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20225

To: sitter, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20176: make start-here-kde also available start-here-kde-plasma

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:9ff7e4658ded: make start-here-kde also available 
start-here-kde-plasma (authored by sitter).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20176?vs=55209=55337

REVISION DETAIL
  https://phabricator.kde.org/D20176

AFFECTED FILES
  icons-dark/places/16/start-here-kde-plasma.svg
  icons-dark/places/22/start-here-kde-plasma.svg
  icons-dark/places/64/start-here-kde-plasma.svg
  icons/places/16/start-here-kde-plasma.svg
  icons/places/22/start-here-kde-plasma.svg
  icons/places/64/start-here-kde-plasma.svg

To: sitter, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20225: use more appropriate plasma-specific icon for plasma category

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  with D20176  landed we can now use the 
more appropriate icon variant for
  plasma here.

REPOSITORY
  R252 Framework Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20225

AFFECTED FILES
  plasma_workspace.notifyrc

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

[David Edmundson]

davidedmundson added a comment.


  > Dave, are you ok with changing the license from GPL to LGPL?
  
  Sure.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20092

To: sitter, apol, mpyne
Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

[Harald Sitter]

sitter added a subscriber: davidedmundson.
sitter added a comment.


  The only relevant change in the history not from me is from @davidedmundson 
it seems. Dave, are you ok with changing the license from GPL to LGPL?
  
  https://phabricator.kde.org/R102:65e55f0b090247263bb3ba2b45615fa3b2ff1320
  
  
https://phabricator.kde.org/source/kinfocenter/history/master/Modules/about-distro/src/OSRelease.cpp
  
https://phabricator.kde.org/source/about-distro/history/master/src/OSRelease.cpp;52066c2bd2e75bd3d3a1c44576fd87cdb0dabe58

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20092

To: sitter, apol, mpyne
Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20046: Verify mimetypes for all existing sample files, add some more

[Ben Cooksley]

bcooksley added a comment.


  Can you please file a task on the #build.kde.org 
 board so I can get this worked 
through with the FreeBSD folks? (It will likely require the package being 
updated in FreeBSD itself)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20046

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: bcooksley, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

nibags added a comment.


  Sorry, I committed this diff, but it hasn't been fully accepted. Although I 
made the changes that mwolff requested. If there is a problem, I can undo the 
commit or update it

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate, cullmann, mwolff
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, ngraham, bruns, demsking, sars

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c922bc8352ac: Fix: apply correctly the text colors of the 
chosen scheme (authored by nibags).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19876?vs=55004=55328

REVISION DETAIL
  https://phabricator.kde.org/D19876

AFFECTED FILES
  src/syntax/katehighlight.cpp
  src/syntax/katehighlight.h

To: nibags, #ktexteditor, #kate, cullmann, mwolff
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, ngraham, bruns, demsking, sars

D20220: AppArmor & SELinux: remove one indentation in XML files

[Nibaldo González]

nibags added a dependent revision: D20221: AppArmor: don't highlight variable 
assignments and alias rules within profiles.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D20220

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich updated this revision to Diff 55326.
astippich added a comment.


  - rebase on master

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=54956=55326

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20220: AppArmor & SELinux: remove one indentation in XML files

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  This only removes an indentation inside the `` tag, in the files 
"apparmor.xml", "selinux-cil.xml" & "selinux-fc.xml", since it's much more 
comfortable.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  remove-indentation

REVISION DETAIL
  https://phabricator.kde.org/D20220

AFFECTED FILES
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann