KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/49/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 06 Apr 2019 00:02:04 +
 Build duration:
6 min 28 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/41/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Apr 2019 23:38:52 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)66%
(111/168)66%
(111/168)55%
(5283/9679)36%
(1907/5232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration33%
(1/3)33%
(1/3)19%
(75/404)3%
(7/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(761/761)55%
(213/384)autotests.unit.file100%
(11/11)100%
(11/11)95%
(867/910)50%
(255/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)71%
(1576/2209)50%
(629/1259)src.file66%
(25/38)66%
(25/38)51%
(879/1712)40%
(400/1008)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/254)0%
(0/125)src.lib55%
(6/11)55%
(6/11)49%
(464/945)43%
(230/537)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
  

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 48 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/48/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Apr 2019 23:01:46 +
 Build duration:
1 hr 0 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/40/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Apr 2019 23:01:46 +
 Build duration:
37 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)65%
(110/168)65%
(110/168)54%
(5271/9677)36%
(1901/5232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration33%
(1/3)33%
(1/3)19%
(75/404)3%
(7/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(761/761)55%
(213/384)autotests.unit.file100%
(11/11)100%
(11/11)95%
(867/910)50%
(255/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)71%
(1576/2209)50%
(629/1259)src.file63%
(24/38)63%
(24/38)51%
(867/1710)39%
(394/1008)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/254)0%
(0/125)src.lib55%
(6/11)55%
(6/11)49%
(464/945)43%
(230/537)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
  

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/48/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Apr 2019 23:24:49 +
 Build duration:
4 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)66%
(111/168)66%
(111/168)55%
(5305/9679)37%
(1922/5232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration33%
(1/3)33%
(1/3)19%
(75/404)3%
(7/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(761/761)55%
(213/384)autotests.unit.file100%
(11/11)100%
(11/11)98%
(889/910)53%
(269/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)71%
(1576/2209)50%
(629/1259)src.file66%
(25/38)66%
(25/38)51%
(879/1712)40%
(401/1008)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/254)0%
(0/125)src.lib55%
(6/11)55%
(6/11)49%
(464/945)43%
(230/537)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 47 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/47/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Apr 2019 23:01:46 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Baloo-5.57.0.xmlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.integration.writetransactiontestName: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)65%
(110/168)65%
(110/168)55%
(5293/9677)37%
(1916/5232)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration33%
(1/3)33%
(1/3)19%
(75/404)3%
(7/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(761/761)55%
(213/384)autotests.unit.file100%
(11/11)100%
(11/11)98%
(889/910)53%
(269/506)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)58%
(93/160)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)71%
(1576/2209)50%
(629/1259)src.file63%
(24/38)63%
(24/38)51%
(867/1710)39%
(395/1008)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/70)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/237)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/254)0%
(0/125)src.lib55%
(6/11)55%
(6/11)49%
(464/945)43%
(230/537)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
 

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

[Stefan Brüns]

bruns added a comment.


  I don' t think there is gained much by splitting it, and as you said, there 
are also drawbacks ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20133

To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: adridg, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20281: Protect against invalid parents in the IdTreeDB

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:92850507a31d: Protect against invalid parents in the 
IdTreeDB (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20281?vs=55498=55507

REVISION DETAIL
  https://phabricator.kde.org/D20281

AFFECTED FILES
  src/engine/documenturldb.cpp
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7842142c3288: Remove document from MTimeDB/DocumentTimeDB 
even when timestamp is 0 (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20280?vs=55497=55506

REVISION DETAIL
  https://phabricator.kde.org/D20280

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Nathaniel Graham]

ngraham added a comment.


  And @mart if you have some time, I could use a hand figuring out why 
`flickable.contentHeight` is always evaluating to 0 here.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  SimpleKCM currently imposes a maximum height of `Kirigami.Units.gridUnit * 
20`, which is
  arbitrary and results in many KCMs opened standalone in kcmshell still 
getting a scrollbar
  even when there's plenty of vertical space available.
  
  This patch changes the maximum value so that it's based on a fraction of the 
available
  screen height, ensuring that tall KCMs will fill the available space as often 
as possible.
  
  CCBUG: 398820

TEST PLAN
  No actual changes can be observed because `flickable.contentHeight` always 
evaluates to
  0 due to https://bugs.kde.org/show_bug.cgi?id=398820 and I haven't yet 
figured out the
  fix for that issue. But once that's fixed, SimpleKCM KCMs will have more 
sensible
  default heights when opened in kcmshell.

REPOSITORY
  R296 KDeclarative

BRANCH
  simplekcm-better-maximum-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20283

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/SimpleKCM.qml

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20281: Protect against invalid parents in the IdTreeDB

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fix_invalid_parentid

REVISION DETAIL
  https://phabricator.kde.org/D20281

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

[Stefan Brüns]

bruns added a comment.


  In D20280#444085 , @ngraham wrote:
  
  > I wonder if this might help https://bugs.kde.org/show_bug.cgi?id=395902.
  
  
  Probably one of the issues with the lmdb freelist.

REPOSITORY
  R293 Baloo

BRANCH
  fix_timestamp_removal

REVISION DETAIL
  https://phabricator.kde.org/D20280

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20281: Protect against invalid parents in the IdTreeDB

[Stefan Brüns]

bruns added a comment.


  Would be nice to get this into KF 5.57, as this fixes a crash. Sorry, no BRs 
(none I am aware of).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20281

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20233: Add syntax highlighting for fish shell

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Thanks for the contribution.
  On a first glance, that looks ok, no hard coded colors, test case, ...
  We would prefer if the license would be MIT, is that possible?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D20233

To: adiestelhorst, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D20281: Protect against invalid parents in the IdTreeDB

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  DocumentUrlDB::put is susceptible to invalid parent ids caused by e.g.
  renaming while a file/path is added. filePathToId will return 0 for a
  (now) invalid dir, although 0 is reserved for the root folder.
  
  As Writetransaction::removeRecursively calls itself for any child document,
  having a 0 as child causes infinite recursion.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  fix_invalid_parentid

REVISION DETAIL
  https://phabricator.kde.org/D20281

AFFECTED FILES
  src/engine/documenturldb.cpp
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I wonder if this might help https://bugs.kde.org/show_bug.cgi?id=395902.

REPOSITORY
  R293 Baloo

BRANCH
  fix_timestamp_removal

REVISION DETAIL
  https://phabricator.kde.org/D20280

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20233: Add syntax highlighting for fish shell

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D20233

To: adiestelhorst, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D20280: Remove document from MTimeDB/DocumentTimeDB even when timestamp is 0

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Commit 628daced19b8 
 
("allow ctime/mtime == 0") removed the asserts
  checking for 0 (anyway only effective for debug builds), but left
  the code for the timestamp removal unchanged.

TEST PLAN
  $> touch -d '@0' xxx.txt
  $> balooshow 'mtime<1980-01-01'
  
-> xxx.txt shows up
  
  $> touch xxx.txt
  $> balooshow 'mtime<1980-01-01'
  
-> xxx.txt no longer shown

REPOSITORY
  R293 Baloo

BRANCH
  fix_timestamp_removal

REVISION DETAIL
  https://phabricator.kde.org/D20280

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19438: Add syntax definition for Elm language to syntax-highlighting

[Nibaldo González]

nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim, #framework_syntax_highlighting, dhaumann, cullmann
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Nibaldo González]

nibags added a comment.


  - Running `make test`, after adding a new file to `autotests/input`, will 
throw an error in "testhighlighter_test", "htmlhighlighter_test" and 
"folding_test", since references haven't been updated.  It's normal to show you 
that error.
  - You have to execute the `autotest/update-reference-data.sh` script to 
update the references (new files will be copied to folding, html & reference). 
When running again `make test` everything will work fine.
  
  - Having the outdated base shouldn't be a problem, although you can update it 
to the last master with:
  
git fetch
git rebase --onto origin/master master
  
  - Also: in the log you used `cmake ./`, I recommend using another folder to 
avoid problems when updating the diff  (because I wrote that you compiled with 
"cmake ./"): `cd ./syntax-highlighting/build && cmake ../`

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Apr 2019 18:53:00 +
 Build duration:
7 min 36 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6437/8556)43%
(10306/23732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2736/2812)49%
(5895/12131)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(854/1266)36%
(983/2711)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(426/835)47%
(1017/2169)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/30/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Apr 2019 18:53:00 +
 Build duration:
4 min 13 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6437/8556)43%
(10306/23732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2736/2812)49%
(5895/12131)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(854/1266)36%
(983/2711)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(426/835)47%
(1017/2169)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/31/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Apr 2019 18:53:00 +
 Build duration:
3 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D20197: Fix desktop link to file or directory

[Nathaniel Graham]

ngraham added a comment.


  Thanks, this works well now. The UI and behavior seem sane, and I've just got 
a few code changes requested:

INLINE COMMENTS

> kurlrequester.cpp:441
> +QAction *fileAction = new 
> QAction(QIcon::fromTheme(QStringLiteral("document-new")), i18n("File"));
> +QAction *dirAction = new 
> QAction(QIcon::fromTheme(QStringLiteral("document-open")), i18n("Directory"));
> +dirOrFileMenu->addAction(fileAction);

This should probably be `folder-new` for visual consistency with the file icon 
you've chosen

> kurlrequester.cpp:445
> +
> +QAction *dirOrFile = 
> dirOrFileMenu->exec(m_parent->mapToGlobal(QPoint(m_parent->width(), 
> m_parent->height(;
> +

This feels overly clever and fragile. The more typical approach would be to 
connect the actions' `triggered` signals to lambda functions that execute the 
code that you currently have in the if/else blocks below.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Sorry, I should learn to read...
  
  When following the instructions, this works flawlessly. Indeed, let's do it 
for 5.58 so we have lots of time for testing. Thanks for this very nice patch, 
@kossebau!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  uncompressedsvginrepo

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg, ngraham
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D20166#443916 , @ngraham wrote:
  
  > In D20166#443781 , @kossebau 
wrote:
  >
  > > If so, I would propose to merge it after KDE Frameworks 5.57 has been 
branched this WE, i.e. merge Friday next week for another 7 days of 
consideration, but with some weeks before the next release so people using 
master can test-drive things some more before release, not only me :)
  >
  >
  > Makes sense to me. That said, I just gave this a whirl and got a CMake 
error immediately:
  >
  >   CMake Error at src/desktoptheme/CMakeLists.txt:30 (message):
  > No files passed when calling plasma_install_desktoptheme_svgs.
  >   Call Stack (most recent call first):
  > src/desktoptheme/oxygen/CMakeLists.txt:5 
(plasma_install_desktoptheme_svgs)
  >
  
  
  Yes, because an important hint was already moved out of sight, so let my 
recite my first comment:
  
  The SVGZ -> SVG conversion of all files not included in this uploaded patch, 
to keep it reviewable.
  
  Locally do this:
  
  Store a file `svgztosvg.sh` with this content in `src/desktoptheme`:
  
#!/bin/sh

SVGZ=$1

if [ ! -f "$SVGZ" ]; then
echo "File not found: \"$SVGZ\""
exit 1
fi

SVG=${SVGZ%.svgz}.svg

zcat $SVGZ > $SVG
rm $SVGZ
  
  Then on the commandline do this:
  
cd plasma-framework/src/desktoptheme
find . -name "*.svgz" -exec sh svgztosvg.sh {} \;
  
  Once done, do e.g. this to restore SVGZ files:
  
find . -name "*.svg" -exec rm {} \;
git checkout air breeze oxygen

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Nathaniel Graham]

ngraham added a comment.


  In D20166#443781 , @kossebau wrote:
  
  > If so, I would propose to merge it after KDE Frameworks 5.57 has been 
branched this WE, i.e. merge Friday next week for another 7 days of 
consideration, but with some weeks before the next release so people using 
master can test-drive things some more before release, not only me :)
  
  
  Makes sense to me. That said, I just gave this a whirl and got a CMake error 
immediately:
  
CMake Error at src/desktoptheme/CMakeLists.txt:30 (message):
  No files passed when calling plasma_install_desktoptheme_svgs.
Call Stack (most recent call first):
  src/desktoptheme/oxygen/CMakeLists.txt:5 
(plasma_install_desktoptheme_svgs)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

[Adriaan de Groot]

adridg added a comment.


  I'd start to think about three separate files , unix_impl.cpp, 
windows_impl.cpp, stub_impl.cpp (although then you get API-syncing issues, 
probably, when only one of them is updated).

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20133

To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: adridg, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Friedrich W. H. Kossebau]

kossebau abandoned this revision.
kossebau added a comment.


  In D20261#443859 , @broulik wrote:
  
  > I don't see how this could work. IconItem uses the first section as 
filename, for `active-quassel-tray` the word `active` and looks for an 
active.svgz which there isn't. This is a bug in Quassel, a violation of the FDO 
spec, it should have ebeen `quassel-tray-inactive` or something, ordered from 
generic to most specific.
  
  
  So much for blindly done patches relying on testing by actual users :)
  
  Indeed, `IconItem` uses this logic:
  
m_svgIcon->setImagePath(QLatin1String("icons/") + 
sourceString.section(QLatin1Char('-'), 0, 0));
  
  so this change will not work.
  
  But I wonder if this isn't a rather once heuristically-driven assumption of 
Plasma, over anything specified at freedesktop.org?
  I could not find anything related in both
  
https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem/
  https://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/Icons/
  as well as
  
https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#file_formats
  
  Where should/could Quassel developers be pointed to? (Besides, they also have 
some "-inverted" variant based on a config option, which somehow complicates 
things even more, besides the complexity of Plasma theming vs. normal icon 
theming ;) ).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20196: RFC: Add Notify capability to KConfigXT

[Kai Uwe Broulik]

broulik planned changes to this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Kai Uwe Broulik]

broulik added a comment.


  I don't see how this could work. IconItem uses the first section as filename, 
for `active-quassel-tray` the word `active` and looks for an active.svgz which 
there isn't. This is a bug in Quassel, a violation of the FDO spec, it should 
have ebeen `quassel-tray-inactive` or something, ordered from generic to most 
specific.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19438: Add syntax definition for Elm language to syntax-highlighting

[Bonghyun Kim]

bonghyunkim updated this revision to Diff 55475.
bonghyunkim added a comment.


  It's been about three weeks since I've uploaded last diff but haven't 
received any response since then. I've made another diff against the most 
recent commit of KDE/syntax-highlighting 
(508be5417e67dc697166e72bde49a1fbf59c23a8 
), 
but I doubt anything would have changed. I'm including the logs of outputs from 
compiling the project and running tests. Failure seems to start from Qt library 
but I'm not sure what's going on here.
  
  I'm running Ubuntu 18.04, cmake 3.13.4, Make 4.1, and QT 5.10.0.
  
  Log for compiling and overall tests: Link 

  Log for HTMLHighlighterTest Link 

  Log for TestHighlighterTest Link 

  Log for FoldingTest Link 


REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19438?vs=53736=55475

REVISION DETAIL
  https://phabricator.kde.org/D19438

AFFECTED FILES
  autotests/input/highlight.elm
  data/syntax/elm.xml

To: bonghyunkim
Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D20133: [UserMetaData] Untangle Windows, Linux/BSD/Mac and stub code.

[Stefan Brüns]

bruns added a comment.


  Ping!

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20133

To: bruns, #baloo, #frameworks, #windows, #freebsd, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

[Nathaniel Graham]

ngraham added reviewers: Frameworks, pino, cfeck, dfaure, elvisangelaccio.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D18296

To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, 
elvisangelaccio
Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20196: RFC: Add Notify capability to KConfigXT

[Kai Uwe Broulik]

broulik added a dependent revision: D20265: Introduce libnotificationmanager.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar added a comment.


  > Edit: The issue is located here...
  > 
  >   TextBlock::insertText(...)
  >   ...
  >   // special handling if cursor behind the real line, e.g. 
non-wrapping cursor in block selection mode
  >   else if (cursor->m_column < textOfLine.size()) {
  >   cursor->m_column = textOfLine.size();
  >   }
  >   ...
  
  Removing these lines solve the issue surprising good. Test are passed too...
  But a full solution ist it not. Entering now a char after end of line did not 
move the cursor.
  F6754835: 1554469832.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19446

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Recent example where plain SVGs in the repo would have made the change 
immdiate visible, as only the strings of some id attributes where changed (to 
match the new icon names), but instead all we see with our tool is an exchange 
of the complete binary blob:  D20261 
  
  So, do I correctly see that people are rather positive about this change, at 
least no-one objecting it? If so, I would propose to merge it after KDE 
Frameworks 5.57 has been branched this WE, i.e. merge Friday next week for 
another 7 days of consideration, but with some weeks before the next release so 
people using master can test-drive things some more before release, not only me 
:)
  
  Who feels like giving  explicit +1 or the needed Accepts? :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg
Cc: bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, michaelh

D20264: Add test for "Auto Reload Document" option

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20264

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/katedocument_test.h

To: loh.tar, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Aleix Pol Gonzalez]

apol added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Friedrich W. H. Kossebau]

kossebau added a comment.


  To test this quickly, please download the files (View Options>Show Raw File 
(Right)>Download File) and place them in the respective folders 
`/usr/share/plasma/desktoptheme/{air,breeze}/icons/`, then "rm .cache/plasma* 
-r", and restart "plasmashell --replace" e.g. via krunner.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20261

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Since v0.13.0 (17 Nov 2018) quassel uses new names for the systemtray
  status icons. This patch updates the icon name ids.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  updatequasselicons

REVISION DETAIL
  https://phabricator.kde.org/D20261

AFFECTED FILES
  src/desktoptheme/air/icons/quassel.svgz
  src/desktoptheme/breeze/icons/quassel.svgz

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20260: Fix crash in KArchive::findOrCreate with broken files

[Aleix Pol Gonzalez]

apol added a comment.


  Looks good, would it be possible to get a test case?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20260

To: aacid
Cc: apol, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20260: Fix crash in KArchive::findOrCreate with broken files

[Albert Astals Cid]

aacid added a subscriber: dfaure.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20260

To: aacid
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D20260: Fix crash in KArchive::findOrCreate with broken files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  In some occassions KArchive::findOrCreate calls itself to find the parent 
KArchiveDirectory
  
  Since KArchive::findOrCreate can return null we have to take into account 
parent can be null.

TEST PLAN
  Crashy .zip doesn't crash anymore

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20260

AFFECTED FILES
  src/karchive.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/48/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Apr 2019 09:34:55 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/56/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Apr 2019 09:34:55 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3625/13364)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(308/2270)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
  

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/60/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Apr 2019 09:34:54 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20244: [AppletInterface] Check for corona before accessing it

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c65145bd3463: [AppletInterface] Check for corona before 
accessing it (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20244?vs=55392=55460

REVISION DETAIL
  https://phabricator.kde.org/D20244

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp

To: broulik, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20197: Fix desktop link to file or directory

[Robert Hoffmann]

hoffmannrobert added a comment.


  Thanks, I've learned that QFileDialog only creates a well behaving directory 
chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having 
set the fileMode to QFileDialog::Directory. If you do it the other way around, 
it doesn't add directories to the selection.
  
  Now it's necessary to delete an already created file dialog and make a new 
one, if you change your mind  and choose the file chooser after having selected 
a directory chooser, or vice versa. Otherwise it would crash.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20197

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20197: Fix desktop link to file or directory

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 55459.
hoffmannrobert added a comment.


  - Set option QFileDialog::ShowDirsOnly after setting file mode

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20197?vs=55409=55459

BRANCH
  fix_desktop_link_filter

REVISION DETAIL
  https://phabricator.kde.org/D20197

AFFECTED FILES
  src/widgets/kurlrequester.cpp

To: hoffmannrobert, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

[Nibaldo González]

nibags updated this revision to Diff 55457.
nibags added a comment.


  - Don't highlight as Error the "alias" keyword within rules
  
  Better not to highlight anything in rules.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20221?vs=55382=55457

BRANCH
  arcpatch-D20221

REVISION DETAIL
  https://phabricator.kde.org/D20221

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/29/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 05 Apr 2019 06:12:43 +
 Build duration:
8 min 30 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6428/8548)43%
(10289/23700)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2728/2804)49%
(5879/12099)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(854/1266)36%
(983/2711)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(425/835)47%
(1016/2169)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/24/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 05 Apr 2019 06:12:44 +
 Build duration:
4 min 22 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.57.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6428/8548)43%
(10289/23700)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2728/2804)49%
(5879/12099)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/926)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)67%
(854/1266)36%
(983/2711)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(52/130)src.lib.plugin100%
(7/7)100%
(7/7)85%
(662/779)42%
(924/2217)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)51%
(425/835)47%
(1016/2169)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(842/1613)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 05 Apr 2019 06:12:43 +
 Build duration:
3 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest