D20493: Introduce and use KArchiveDirectory::addEntryV2

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  arcpatch-D20493

REVISION DETAIL
  https://phabricator.kde.org/D20493

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20264: Add test for "Auto Reload Document" option

[loh tar]

loh.tar added a comment.


  I spend a couple of time for this stuff. 
  Would be nice someone else could try it or do some investigation with tools 
I'm not familiar with, and don't want to be atm. Without feedback I will push 
it in the next few days.

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 83 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/83/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 22:34:10 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.57.0.xmllogs/KF5TextEditor/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.katedocument_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)68%
(33153/48641)51%
(15854/31084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4637/4960)49%
(1759/3582)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1712/1903)76%
(1213/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)59%
(1877/3204)47%
(1578/3345)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)78%
(972/1245)67%
(637/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
 

D20477: Avoid indirection when inserting basic data

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R824:06a75822671b: Avoid indirection when inserting basic data 
(authored by bruns).

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20477?vs=56026=56106

REVISION DETAIL
  https://phabricator.kde.org/D20477

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 69 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/69/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 22:34:10 +
 Build duration:
8 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.57.0.xmllogs/KF5TextEditor/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.katedocument_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)68%
(33180/48642)51%
(15877/31084)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4637/4960)49%
(1759/3582)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1712/1903)76%
(1213/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)59%
(1879/3204)47%
(1578/3345)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(957/1245)67%
(628/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/86/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 22:34:10 +
 Build duration:
7 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.katedocument_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D19608: DocumentPrivate: Make bracket handling smart

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8f0813f6c7ed: DocumentPrivate: Make bracket handling smart 
(authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19608?vs=53444=56105#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19608?vs=53444=56105

REVISION DETAIL
  https://phabricator.kde.org/D19608

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17500: Get mobipocket extractor up-to-date, but keep disabled

[Albert Astals Cid]

aacid added a comment.


  Sure, this code is not compiled, if you think it's better just commit it 
(IMHO, not kfilemedata specialist)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17500

To: astippich, bruns
Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19691: ViewInternal: Review drop event

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:1a0da40ae3da: ViewInternal: Review drop event (authored by 
loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19691?vs=53702=56103#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19691?vs=53702=56103

REVISION DETAIL
  https://phabricator.kde.org/D19691

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D20499: Support gzipping of svgz also on windows, using 7z

[Hannah von Reth]

vonreth added a comment.


  7z will be around as it is the second core (craft) dep after wget

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20499

To: kossebau, #plasma, #windows
Cc: vonreth, cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 157 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/157/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 20:49:32 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 8 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.autotests.coronatestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_dialogstatetestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetestFailed: projectroot.autotests.plasma_themetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 65 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/65/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 20:49:32 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/72/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 20:49:32 +
 Build duration:
5 min 13 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13369)18%
(1818/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D20499: Support gzipping of svgz also on windows, using 7z

[Christoph Cullmann]

cullmann added a comment.


  I glanced at it, thought I have at home no Windows machine at hand to test if 
the command line works as planned.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20499

To: kossebau, #plasma, #windows
Cc: cullmann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/75/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 20:49:31 +
 Build duration:
2 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20499: Support gzipping of svgz also on windows, using 7z

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Given CI is currently broken for Windows, going for try & error, as usually 
windows experts to review are hard to find.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20499

To: kossebau, #plasma, #windows
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20499: Support gzipping of svgz also on windows, using 7z

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:78bec83b222f: Support gzipping of svgz also on windows, 
using 7z (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20499?vs=56097=56098

REVISION DETAIL
  https://phabricator.kde.org/D20499

AFFECTED FILES
  cmake/Find7z.cmake
  src/desktoptheme/CMakeLists.txt

To: kossebau, #plasma, #windows
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Unannounced Dependency Change - plasma-framework

[Friedrich W. H. Kossebau]

Am Freitag, 12. April 2019, 20:47:51 CEST schrieb Ben Cooksley:
> Hi all,
> 
> Recently builds of plasma-framework have started failing on Windows
> due to the absence of "gzip", which was added as a Dependency without
> any announcement as is required of all new dependencies.
> 
> With regards to Windows in particular, usually Craft based systems
> will make use of 7-Zip instead of gzip (and as such, it's already
> available)
> 
> Could we get this fixed please?

I am to blame, missed that plasma-frameworks also is used for WIndows (and 
looked at the wrong product build on CI).

Windows experts, please give https://phabricator.kde.org/D20499 a look, which 
should fix this.

Cheers
Friedrich

D20499: Support gzipping of svgz also on windows, using 7z

[Friedrich W. H. Kossebau]

kossebau added reviewers: Plasma, Windows.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20499

To: kossebau, #plasma, #windows
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20499: Support gzipping of svgz also on windows, using 7z

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 56097.
kossebau added a comment.


  search both 7z.exe & 7za.exe

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20499?vs=56096=56097

BRANCH
  supportgziponwindows

REVISION DETAIL
  https://phabricator.kde.org/D20499

AFFECTED FILES
  cmake/Find7z.cmake
  src/desktoptheme/CMakeLists.txt

To: kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 170 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/170/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 20:10:25 +
 Build duration:
6 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D20166#448914 , @cullmann wrote:
  
  > The CI is a bit unhappy with the gzip depedency on Windows.
  >  Might one just write a minimal KArchive based gzip'er for this? gzip isn't 
there on any normal Windows machine, even if you have libz.
  
  
  D20499  is currently in the works, 
needing people != me who use windows to test, please :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg, ngraham
Cc: cullmann, bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, 
michaelh

D20499: Support gzipping of svgz also on windows, using 7z

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  supportgziponwindows

REVISION DETAIL
  https://phabricator.kde.org/D20499

AFFECTED FILES
  cmake/Find7z.cmake
  src/desktoptheme/CMakeLists.txt

To: kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19511: ViewPrivate: Disable read-only mode action when doc is modified

[Christoph Cullmann]

cullmann added a comment.


  I still think we should stay with status quo, can you drop this request?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19511

To: loh.tar, #ktexteditor, cullmann
Cc: ngraham, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
gennad, domson, michaelh, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 169 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/169/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 19:38:32 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.syntaxrepository_test

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

[Christoph Cullmann]

cullmann added a comment.


  The CI is a bit unhappy with the gzip depedency on Windows.
  Might one just write a minimal KArchive based gzip'er for this? gzip isn't 
there on any normal Windows machine, even if you have libz.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20166

To: kossebau, #plasma, #vdg, ngraham
Cc: cullmann, bruns, GB_2, ndavis, ngraham, fvogt, kde-frameworks-devel, 
michaelh

Re: Unannounced Dependency Change - plasma-framework

[Christoph Cullmann]

On 2019-04-12 20:47, Ben Cooksley wrote:

Hi all,

Recently builds of plasma-framework have started failing on Windows
due to the absence of "gzip", which was added as a Dependency without
any announcement as is required of all new dependencies.

With regards to Windows in particular, usually Craft based systems
will make use of 7-Zip instead of gzip (and as such, it's already
available)

Could we get this fixed please?

Regards,
Ben

Hi,

I assume this was

38ba8beee3a595a45451d4a2d0772399df18f7c5

https://phabricator.kde.org/D20166

Perhaps this should just be optional and default off.

Greetings
Christoph

--
https://cullmann.io | https://kate-editor.org

D19608: DocumentPrivate: Make bracket handling smart

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Works for me, beside that the patch no longer cleanly applies.
  But with some false removed and the later parts skipped, it did work as 
advertised.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19608

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20264: Add test for "Auto Reload Document" option

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  I think this can go in as is, as long as the test works determinstically, 
which I assume it does.

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D19691: ViewInternal: Review drop event

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  +1, nice
  
  Played a bit here with the new behavior, MUCH better than the old one.
  
  For the block selection stuff: yes, tabs + spaces + block selection is messy, 
thought I think that is really an extreme corner case. If you find time and 
have an idea how to fix that, extra patches are welcome.
  
  This should go in as is.

REVISION DETAIL
  https://phabricator.kde.org/D19691

To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 36 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/36/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 19:35:46 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kcrashtest

D20233: Add syntax highlighting for fish shell

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0e2d7e61a256: Add syntax highlighting for fish shell 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20233?vs=55361=56093

REVISION DETAIL
  https://phabricator.kde.org/D20233

AFFECTED FILES
  autotests/folding/highlight.fish.fold
  autotests/html/highlight.fish.html
  autotests/input/highlight.fish
  autotests/reference/highlight.fish.ref
  data/syntax/fish.xml

To: adiestelhorst, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann

D20221: AppArmor: don't highlight variable assignments and alias rules within profiles

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1726c4f868f6: AppArmor: dont highlight variable 
assignments and alias rules within profiles (authored by nibags, committed by 
cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20221?vs=55457=56092

REVISION DETAIL
  https://phabricator.kde.org/D20221

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D20467: Allow to close a document whose file was deleted on disk

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2a0cf7044f75: Allow to close a document whose file was 
deleted on disk (authored by meven, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20467?vs=56042=56091

REVISION DETAIL
  https://phabricator.kde.org/D20467

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/katedialogs.h
  src/document/katedocument.cpp
  src/document/katedocument.h

To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 35 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/35/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 11 Apr 2019 18:29:43 +
 Build duration:
1 day 1 hr and counting

KCrash - test_crasher spins in a loop on Windows

[Ben Cooksley]

Hi all,

Currently we have an issue where the test_crasher test will endlessly
fork itself while trying to setup it's conditions to run.

This leads to an issue where it will occupy a single CPU core of a
builder indefinitely until it's killed (and when killed there are
always two test_crasher.exe processes running, and if not killed
simultaneously it won't move on to the next test)

Any ideas on how to resolve this?

(This has existed for some time, i've just not had the time to raise
it as an issue)

Cheers,
Ben

D20467: Allow to close a document whose file was deleted on disk

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think this should go in.
  
  For application supporting the interface, the document is removed.
  For application not supporting the interface, at least the file is closed and 
you have a empty document again.
  
  Actually for KWrite that is the wanted case, you don't want to end the 
application.

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D20467

REVISION DETAIL
  https://phabricator.kde.org/D20467

To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars

Unannounced Dependency Change - plasma-framework

[Ben Cooksley]

Hi all,

Recently builds of plasma-framework have started failing on Windows
due to the absence of "gzip", which was added as a Dependency without
any announcement as is required of all new dependencies.

With regards to Windows in particular, usually Craft based systems
will make use of 7-Zip instead of gzip (and as such, it's already
available)

Could we get this fixed please?

Regards,
Ben

D20498: Change namespace of MobileCursor

[Dimitris Kardarakos]

dkardarakos edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20498

To: dkardarakos, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20498: Change namespace of MobileCursor

[Dimitris Kardarakos]

dkardarakos created this revision.
dkardarakos added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Looking for MobileCursor in the Private namespace, results TextField and 
TextArea components to be unavailable. Changing namespace fixes the problem

TEST PLAN
  On Plasma Mobile, open a component containing Controls 2 TextField or 
TextArea. 
  Before the patch, components are unavailable. 
  After patching, the components are back,

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20498

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml

To: dkardarakos, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/74/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 17:37:46 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/64/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 17:37:46 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/84/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 17:05:44 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 156 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/156/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 17:37:46 +
 Build duration:
2 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 334 lines...][2019-04-12T17:40:31.982Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T17:40:31.982Z] [2019-04-12T17:40:31.982Z] [2019-04-12T17:40:31.982Z] -- No such tag file "C:/CI/Software Installs/kconfig/bin/data/doc/qch/KF5Config.tags" found for KF5Config_QCH when calling ecm_add_qch().[2019-04-12T17:40:31.982Z] CMake Warning at C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:391 (message):[2019-04-12T17:40:31.982Z]   No linking to API dox of KF5Config_QCH.[2019-04-12T17:40:31.982Z] Call Stack (most recent call first):[2019-04-12T17:40:31.982Z]   C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)[2019-04-12T17:40:31.982Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T17:40:31.982Z] [2019-04-12T17:40:31.982Z] [2019-04-12T17:40:31.982Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5CoreAddons.tags" found for KF5CoreAddons_QCH when calling ecm_add_qch().[2019-04-12T17:40:31.982Z] CMake Warning at C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:391 (message):[2019-04-12T17:40:31.982Z]   No linking to API dox of KF5CoreAddons_QCH.[2019-04-12T17:40:31.982Z] Call Stack (most recent call first):[2019-04-12T17:40:31.982Z]   C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)[2019-04-12T17:40:31.982Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T17:40:31.982Z] [2019-04-12T17:40:31.982Z] [2019-04-12T17:40:31.982Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-04-12T17:40:31.982Z] -- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.[2019-04-12T17:40:32.242Z] -- The following features have been enabled:[2019-04-12T17:40:32.242Z] [2019-04-12T17:40:32.242Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-04-12T17:40:32.242Z] [2019-04-12T17:40:32.242Z] -- The following OPTIONAL packages have been found:[2019-04-12T17:40:32.242Z] [2019-04-12T17:40:32.242Z]  * KF5DocTools (required version >= 5.57.0), Tools to generate documentation[2019-04-12T17:40:32.242Z]  * OpenGL, The OpenGL libraries, [2019-04-12T17:40:32.242Z]  * PkgConfig[2019-04-12T17:40:32.242Z] [2019-04-12T17:40:32.242Z] -- The following REQUIRED packages have been found:[2019-04-12T17:40:32.242Z] [2019-04-12T17:40:32.242Z]  * Qt5Network (required version >= 5.11.2)[2019-04-12T17:40:32.242Z]  * Qt5Quick[2019-04-12T17:40:32.242Z]  * Qt5Gui[2019-04-12T17:40:32.242Z]  * Qt5Sql[2019-04-12T17:40:32.242Z]  * Qt5Qml[2019-04-12T17:40:32.242Z]  * Qt5Svg[2019-04-12T17:40:32.242Z]  * Qt5QuickControls2[2019-04-12T17:40:32.242Z]  * Qt5 (required version >= 5.10.0)[2019-04-12T17:40:32.242Z]  * KF5Activities (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Archive (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Config (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5ConfigWidgets (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5DBusAddons (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Declarative (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5GlobalAccel (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5GuiAddons (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * Gettext[2019-04-12T17:40:32.242Z]  * KF5I18n (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5IconThemes (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5KIO (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Service (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5WindowSystem (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Notifications (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Package (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5Kirigami2 (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * KF5 (required version >= 5.57.0)[2019-04-12T17:40:32.242Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-04-12T17:40:32.242Z]  * Doxygen (required version >= 1.8.13)[2019-04-12T17:40:32.242Z]Needed for API dox QCH file generation[2019-04-12T17:40:32.242Z]  * QHelpGenerator, Part of Qt5 tools[2019-04-12T17:40:32.242Z]Needed for API dox QCH file generation[2019-04-12T17:40:32.242Z]  * Qt5Test (required version >= 5.10.0)[2019-04-12T17:40:32.242Z]Required for tests[2019-04-12T17:40:32.242Z]  * KF5CoreAddons[2019-04-12T17:40:32.242Z]  * KF5XmlGui[2019-04-12T17:40:32.242Z]  * Qt5Widgets[2019-04-12T17:40:32.242Z] [2019-04-12T17:40:32.242Z] -- The following 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/71/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 17:37:46 +
 Build duration:
5 min 12 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D20496: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:37a1845bc40a: Air/Oxygen desktoptheme: fix hand offsets 
with hint-*-rotation-center-offset (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20496?vs=56077=56086#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20496?vs=56077=56086

REVISION DETAIL
  https://phabricator.kde.org/D20496

AFFECTED FILES
  src/desktoptheme/air/widgets/clock.svg
  src/desktoptheme/oxygen/widgets/clock.svg

To: kossebau, #plasma, mart, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20496: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixairclock

REVISION DETAIL
  https://phabricator.kde.org/D20496

To: kossebau, #plasma, mart, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20477: Avoid indirection when inserting basic data

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  lol

REPOSITORY
  R824 Baloo Widgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20477

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/85/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 17:05:45 +
 Build duration:
9 min 38 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.57.0.xmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32970/60623)39%
(17152/44486)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9315/9772)48%
(4366/9111)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8459/14443)51%
(4764/9355)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1927/4829)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 72 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/72/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 17:05:45 +
 Build duration:
9 min 14 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.57.0.xmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32964/60629)39%
(17136/44489)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9317/9772)48%
(4364/9111)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8451/14450)51%
(4751/9358)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4352/8049)40%
(1934/4829)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0cb9fe93e190: [KUrlNavigator] Fix URL navigation when 
exiting archive with krarc and Dolphin (authored by nhiga, committed by 
ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20424?vs=55875=56080

REVISION DETAIL
  https://phabricator.kde.org/D20424

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, kde-frameworks-devel, ngraham
Cc: bcooksley, aacid, ngraham, michaelh, bruns

D20424: [KUrlNavigator] Fix URL navigation when exiting archive with krarc and Dolphin

[Nathaniel Graham]

ngraham added a comment.


  Since the hardcoded list of affected protocols is already there, let's add 
the new one for now. In the future we'll look into moving this information into 
a more appropriate place.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20424

To: nhiga, kde-frameworks-devel, ngraham
Cc: bcooksley, aacid, ngraham, michaelh, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[Nathaniel Graham]

ngraham added reviewers: cfeck, dfaure.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20426: Improve "widget-alternatives" icon

[Björn Feber]

GB_2 added a dependent revision: D17410: Add alternatives button to applet 
configuration in panel edit mode.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20426

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: zzag, ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, 
michaelh, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger updated this revision to Diff 56078.
ekurzinger added a comment.


  Changed the dynamic_cast in create() to static_cast. Since the Private is 
created in the constructor of EglStreamControllerInterface, it should be safe 
to assume it is of the correct type.
  Also marked Private as Q_DECL_HIDDEN.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18824?vs=56075=56078

REVISION DETAIL
  https://phabricator.kde.org/D18824

AFFECTED FILES
  src/client/protocols/wayland-eglstream-controller.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/eglstream_controller_interface.cpp
  src/server/eglstream_controller_interface.h
  src/server/eglstream_controller_interface_p.h

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: zzag, ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, 
michaelh, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> eglstream_controller_interface.cpp:103
> +{
> +dynamic_cast(*d).create();
> +}

Can we avoid dynamic casting a reference? Is it possible to use static_cast 
instead?

> eglstream_controller_interface_p.h:33
> +
> +class EglStreamControllerInterface::Private : public Global::Private
> +{

Should be marked with Q_DECL_HIDDEN.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: zzag, ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, 
michaelh, bruns

D20496: Air/Oxygen desktoptheme: fix hand offsets with hint-*-rotation-center-offset

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Air desktoptheme: fix offset of hands 
with hint-*-rotation-center-offset" to "Air/Oxygen desktoptheme: fix hand 
offsets with hint-*-rotation-center-offset".
kossebau edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20496

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20496: Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 56077.
kossebau added a comment.


  Oxygen clock has the same issue

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20496?vs=56076=56077

BRANCH
  fixairclock

REVISION DETAIL
  https://phabricator.kde.org/D20496

AFFECTED FILES
  src/desktoptheme/air/widgets/clock.svg
  src/desktoptheme/oxygen/widgets/clock.svg

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger updated this revision to Diff 56075.
ekurzinger added a comment.


  Ok, now we will bail out early during create()  if we fail to dynamically 
load the interface (before calling wl_global_create). The compositor can then 
use isValid() to check if whether creating the interface succeeded or not, it 
will also print a warning if it fails. Unfortunately, as Roman has pointed out, 
since Global::create is not virtual the compositor technically *could* still 
break things by calling the parent class method, but I'm not sure if it's worth 
changing that for just this one somewhat special case, especially considering 
that this will probably only ever actually be used by KWin's EGLStream backend 
anyway.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18824?vs=56067=56075

REVISION DETAIL
  https://phabricator.kde.org/D18824

AFFECTED FILES
  src/client/protocols/wayland-eglstream-controller.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/eglstream_controller_interface.cpp
  src/server/eglstream_controller_interface.h
  src/server/eglstream_controller_interface_p.h

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

D20496: Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looks like this with Plasma 5.16:
  F6768883: Screenshot_20190412_174053.png 

  which gets us again to what it looked originally, cmp. 
https://kde.org/announcements/4.3/images/kde430-desktop.png

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20496

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20496: Air desktoptheme: fix offset of hands with hint-*-rotation-center-offset

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The hands of the clock still relied on the KDE4 times rule that the
  position in y-axis relativ to the clock center would define the relative
  rotation point for the hands.
  
  With the default in Plasma 5 being (width/2, width/2) from topleft of the
  hand shape, using hints of upcoming Plasma 5.16 allows to override that
  again to match the original definition, without the need to enlarge
  the pixmaps of the hand shapes.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixairclock

REVISION DETAIL
  https://phabricator.kde.org/D20496

AFFECTED FILES
  src/desktoptheme/air/widgets/clock.svg

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20264: Add test for "Auto Reload Document" option

[loh tar]

loh.tar added a comment.


  In D20264#448583 , @dhaumann wrote:
  
  > I think KateViewInternal::updateView is called for cursor blinking for 
instance. May that be an issue?
  
  
  Regarding ...
  
  > KateViewInternal::updateView is very often called
  
  ...I don't think so. It was much more frequently than some blinking. That 
observation was only a general notice, not to this test...IIRC
  So, what do with this? Commit as it is?

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/63/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 14:47:22 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/73/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 14:47:21 +
 Build duration:
5 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/70/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 14:47:23 +
 Build duration:
5 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13369)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger marked an inline comment as done.
ekurzinger added a comment.


  In D18824#448597 , @romangg wrote:
  
  > In the first revision the interface failed to create when the dynamically 
loaded library was not present (we said the class should always be created 
though). Now it just fails silently on bind. Why is it ok to fail silently on 
bind?
  
  
  
  
  In D18824#448755 , @davidedmundson 
wrote:
  
  > > Now it just fails silently on bind. Why is it ok to fail silently on bind?
  >
  > We wouldn't get that far. 
  >  If the library didn't load then we wouldn't have sent an interface to 
wl_global_create
  >
  > I don't know how that behaves, but we would have either crashed already 
(which might warrant a guard in Global::Private::create) or the client wouldn't 
be seeing a global registered to bind to
  
  
  Actually, that was an oversight on my part. It looks like wl_global_create() 
doesn't actually check whether the interface is null, so right now it'll just 
segfault if the library can't be loaded. Probably not what we want.
  I'm re-working it right now to load the library in create() and bail out 
there if it's not successful to avoid this. I'll update the diff shortly.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 155 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/155/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 14:47:23 +
 Build duration:
3 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 334 lines...][2019-04-12T14:50:43.945Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T14:50:43.945Z] [2019-04-12T14:50:43.945Z] [2019-04-12T14:50:43.945Z] -- No such tag file "C:/CI/Software Installs/kconfig/bin/data/doc/qch/KF5Config.tags" found for KF5Config_QCH when calling ecm_add_qch().[2019-04-12T14:50:43.945Z] CMake Warning at C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:391 (message):[2019-04-12T14:50:43.945Z]   No linking to API dox of KF5Config_QCH.[2019-04-12T14:50:43.945Z] Call Stack (most recent call first):[2019-04-12T14:50:43.945Z]   C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)[2019-04-12T14:50:43.945Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T14:50:43.945Z] [2019-04-12T14:50:43.945Z] [2019-04-12T14:50:43.945Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5CoreAddons.tags" found for KF5CoreAddons_QCH when calling ecm_add_qch().[2019-04-12T14:50:43.945Z] CMake Warning at C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:391 (message):[2019-04-12T14:50:43.945Z]   No linking to API dox of KF5CoreAddons_QCH.[2019-04-12T14:50:43.945Z] Call Stack (most recent call first):[2019-04-12T14:50:43.945Z]   C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)[2019-04-12T14:50:43.945Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T14:50:43.945Z] [2019-04-12T14:50:43.945Z] [2019-04-12T14:50:43.945Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-04-12T14:50:43.945Z] -- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.[2019-04-12T14:50:44.937Z] -- The following features have been enabled:[2019-04-12T14:50:44.937Z] [2019-04-12T14:50:44.937Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-04-12T14:50:44.937Z] [2019-04-12T14:50:44.937Z] -- The following OPTIONAL packages have been found:[2019-04-12T14:50:44.937Z] [2019-04-12T14:50:44.937Z]  * KF5DocTools (required version >= 5.57.0), Tools to generate documentation[2019-04-12T14:50:44.937Z]  * OpenGL, The OpenGL libraries, [2019-04-12T14:50:44.937Z]  * PkgConfig[2019-04-12T14:50:44.937Z] [2019-04-12T14:50:44.937Z] -- The following REQUIRED packages have been found:[2019-04-12T14:50:44.937Z] [2019-04-12T14:50:44.937Z]  * Qt5Network (required version >= 5.11.2)[2019-04-12T14:50:44.937Z]  * Qt5Quick[2019-04-12T14:50:44.937Z]  * Qt5Gui[2019-04-12T14:50:44.937Z]  * Qt5Sql[2019-04-12T14:50:44.937Z]  * Qt5Qml[2019-04-12T14:50:44.937Z]  * Qt5Svg[2019-04-12T14:50:44.937Z]  * Qt5QuickControls2[2019-04-12T14:50:44.937Z]  * Qt5 (required version >= 5.10.0)[2019-04-12T14:50:44.937Z]  * KF5Activities (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Archive (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Config (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5ConfigWidgets (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5DBusAddons (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Declarative (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5GlobalAccel (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5GuiAddons (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * Gettext[2019-04-12T14:50:44.937Z]  * KF5I18n (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5IconThemes (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5KIO (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Service (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5WindowSystem (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Notifications (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Package (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5Kirigami2 (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * KF5 (required version >= 5.57.0)[2019-04-12T14:50:44.937Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-04-12T14:50:44.937Z]  * Doxygen (required version >= 1.8.13)[2019-04-12T14:50:44.937Z]Needed for API dox QCH file generation[2019-04-12T14:50:44.937Z]  * QHelpGenerator, Part of Qt5 tools[2019-04-12T14:50:44.937Z]Needed for API dox QCH file generation[2019-04-12T14:50:44.937Z]  * Qt5Test (required version >= 5.10.0)[2019-04-12T14:50:44.937Z]Required for tests[2019-04-12T14:50:44.937Z]  * KF5CoreAddons[2019-04-12T14:50:44.937Z]  * KF5XmlGui[2019-04-12T14:50:44.937Z]  * Qt5Widgets[2019-04-12T14:50:44.937Z] [2019-04-12T14:50:44.937Z] -- The following 

D20495: KateIconBorder: Fix folding popup width and height

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Now take the popup the whole width of the view instead of the half
  - The height computation is fixed to use all possible space left and allow 
slightly overpainting of the view bottom to cover all lines properly
  
  I hope the latter point cause no distaste.
  When other lines are still visible is that for me always confusing.
  There is a patch left which fix the not correct end of the folding range,
  where the closing brace is not covered. (No pic sorry)
  Works for the preview nicely but cause trouble while perform the fold,
  so need some more work/ideas...

TEST PLAN
  F6768794: pic.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20495

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20417: Add invokable public API for emitting contextualActionsAboutToShow

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:83d85dc2288c: Add invokable public API for emitting 
contextualActionsAboutToShow (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20417?vs=55857=56072

REVISION DETAIL
  https://phabricator.kde.org/D20417

AFFECTED FILES
  src/scriptengines/qml/plasmoid/appletinterface.cpp
  src/scriptengines/qml/plasmoid/appletinterface.h

To: davidedmundson, #plasma, broulik
Cc: GB_2, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D18824: Implement wl_eglstream_controller Server Interface

[David Edmundson]

davidedmundson added a comment.


  > Now it just fails silently on bind. Why is it ok to fail silently on bind?
  
  We wouldn't get that far. 
  If the library didn't load then we wouldn't have sent an interface to 
wl_global_create
  
  I don't know how that behaves, but we would have either crashed already 
(which might warrant a guard in Global::Private::create) or the client wouldn't 
be seeing a global registered to bind to

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

D18824: Implement wl_eglstream_controller Server Interface

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> eglstream_controller_interface.h:49
> +public:
> +virtual ~EglStreamControllerInterface();
> +

pedantically that should be:

~EglStreamControllerInterface() override;

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

ekurzinger updated this revision to Diff 56067.
ekurzinger added a comment.


  Re-added protocol XML file to diff and corrected version in display.h

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18824?vs=56009=56067

REVISION DETAIL
  https://phabricator.kde.org/D18824

AFFECTED FILES
  src/client/protocols/wayland-eglstream-controller.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/eglstream_controller_interface.cpp
  src/server/eglstream_controller_interface.h
  src/server/eglstream_controller_interface_p.h

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

D20493: Introduce and use KArchiveDirectory::addEntryV2

[Albert Astals Cid]

aacid updated this revision to Diff 56065.
aacid added a comment.


  remove friend, don't need it with this current approach

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20493?vs=56064=56065

BRANCH
  arcpatch-D20493

REVISION DETAIL
  https://phabricator.kde.org/D20493

AFFECTED FILES
  src/k7zip.cpp
  src/karchive.cpp
  src/karchivedirectory.h
  src/krcc.cpp
  src/kzip.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20493: Introduce and use KArchiveDirectory::addEntryV2

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  The original addEntry can delete the entry that is passed in, but we have no 
way to know
  about it, so when that happens if we try to use the entry afterwards it will 
crash
  
  This patch changes all the cases where addEntry was used and the entry passed 
to it is used later in the code

TEST PLAN
  Broken file doesn't crash anymore

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20493

AFFECTED FILES
  src/k7zip.cpp
  src/karchive.cpp
  src/karchivedirectory.h
  src/krcc.cpp
  src/kzip.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make it compile without foreach (Step 1)

[Laurent Montel]

mlaurent retitled this revision from "[KIO] Make to compile without foreach 
(Step 1)" to "[KIO] Make it compile without foreach (Step 1)".
mlaurent edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20489

To: mlaurent, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make to compile without foreach (Step 1)

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D20489#448703 , @mlaurent wrote:
  
  > what is the problem with title ?
  
  
  "Make to compile without foreach"
  
  it's missing words or some have to be changed.
  The summary also lacks explanations *why* this change is needed (like almost 
*all* the commits in the pim repositories)
  
  we're not using SVN anymore where a commit had to be pushed before preparing 
the next one, there's time to explain things.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20489

To: mlaurent, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make to compile without foreach (Step 1)

[Laurent Montel]

mlaurent added a comment.


  what is the problem with title ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20489

To: mlaurent, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20467: Allow to close a document whose file was deleted on disk

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20467

To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars

D20467: Allow to close a document whose file was deleted on disk

[Méven Car]

meven added a comment.


  kdevelop supports this interface already 
https://cgit.kde.org/kdevelop.git/tree/shell/ktexteditorpluginintegration.h?id=e2bcd581bb8a9bb0005a9fcdce3167fc6be77e40#n56
  
  But not kile as far as greping kile source for KTextEditor::Application has 
shown.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20467

To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars

D20489: [KIO] Make to compile without foreach (Step 1)

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Please fix the summary

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20489

To: mlaurent, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D20484: Mark archive and directory as const

[Albert Astals Cid]

aacid added a comment.


  In D20484#448629 , @apol wrote:
  
  > The patch is fine, I wonder how you ended up deciding this was a change to 
be done. :P
  
  
  That's coming up next ;)

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D20484

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20484: Mark archive and directory as const

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R301:808e4463afb1: Mark archive and directory as const 
(authored by aacid).

REPOSITORY
  R301 KEmoticons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20484?vs=56039=56062

REVISION DETAIL
  https://phabricator.kde.org/D20484

AFFECTED FILES
  src/core/kemoticons.cpp

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20489: [KIO] Make to compile without foreach (Step 1)

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port a lot of foreach/FOREACH (still 220 items)

TEST PLAN
  autotest ok

REPOSITORY
  R241 KIO

BRANCH
  port_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20489

AFFECTED FILES
  autotests/batchrenamejobtest.cpp
  autotests/clipboardupdatertest.cpp
  autotests/dataprotocoltest.cpp
  autotests/fileundomanagertest.cpp
  autotests/globaltest.cpp
  autotests/http/httpheaderdispositiontest.cpp
  autotests/jobtest.cpp
  autotests/kdirmodeltest.cpp
  autotests/kfilewidgettest.cpp
  autotests/kmountpointtest.cpp
  autotests/kurifiltersearchprovideractionstest.cpp
  autotests/kurlcompletiontest.cpp
  src/core/kcoredirlister.cpp
  src/core/kfileitemlistproperties.cpp
  src/core/kioglobal_p.cpp
  src/core/kprotocolmanager.cpp
  src/core/ksslcertificatemanager.cpp
  src/core/ktcpsocket.cpp
  src/core/slavebase.cpp
  src/core/tcpslavebase.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kencodingfiledialog.cpp
  src/filewidgets/kfilecopytomenu.cpp
  src/filewidgets/kfilemetapreview.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfilepreviewgenerator.cpp
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/knewfilemenu.cpp
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorplacesselector.cpp
  src/filewidgets/kurlnavigatorprotocolcombo.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/http/http_cache_cleaner.cpp
  src/ioslaves/http/httpauthentication.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookieserver.cpp
  src/kcms/kio/kcookiesmanagement.cpp
  src/kcms/kio/kproxydlg.cpp
  src/kiod/kiod_main.cpp
  src/kpac/script.cpp
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp
  src/kssld/kssld.cpp
  src/protocoltojson/main.cpp
  src/urifilters/ikws/ikwsopts.cpp
  src/urifilters/ikws/searchprovider.cpp
  src/urifilters/ikws/searchproviderdlg.cpp
  src/widgets/accessmanager.cpp
  src/widgets/accessmanagerreply_p.cpp
  src/widgets/dropjob.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/kdirmodel.cpp
  src/widgets/kfileitemactions.cpp
  src/widgets/kpropertiesdialog.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/kurifilter.cpp
  src/widgets/kurlcompletion.cpp
  src/widgets/paste.cpp
  src/widgets/previewjob.cpp
  tests/getalltest.cpp
  tests/udsentrybenchmark.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/84/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 10:40:40 +
 Build duration:
34 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.57.0.xmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32990/60625)39%
(17156/44478)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9315/9772)48%
(4366/9111)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8478/1)51%
(4771/9355)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4352/8050)40%
(1921/4821)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1306/3690)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

D20484: Mark archive and directory as const

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  The patch is fine, I wonder how you ended up deciding this was a change to be 
done. :P

REPOSITORY
  R301 KEmoticons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20484

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/83/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 10:40:40 +
 Build duration:
6 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 71 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/71/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 10:40:40 +
 Build duration:
1 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 524 lines...][2019-04-12T10:41:54.641Z] Scanning dependencies of target KF5Auth_QCH[2019-04-12T10:41:54.641Z] [  2%] Built target KF5Solid_QCH[2019-04-12T10:41:54.641Z] [  2%] Built target KF5ItemViews_QCH[2019-04-12T10:41:54.641Z] Scanning dependencies of target KF5Completion_QCH[2019-04-12T10:41:54.641Z] Scanning dependencies of target KF5Bookmarks_QCH[2019-04-12T10:41:54.641Z] [  2%] Built target KF5WidgetsAddons_QCH[2019-04-12T10:41:54.641Z] Scanning dependencies of target KF5JobWidgets_QCH[2019-04-12T10:41:54.641Z] Scanning dependencies of target KF5Codecs_QCH[2019-04-12T10:41:54.641Z] Scanning dependencies of target KF5KIOCore_autogen[2019-04-12T10:41:54.641Z] [  2%] Built target KF5Auth_QCH[2019-04-12T10:41:54.641Z] Scanning dependencies of target protocoltojson_autogen[2019-04-12T10:41:54.641Z] [  2%] Built target KF5Bookmarks_QCH[2019-04-12T10:41:54.641Z] [  2%] Built target KF5Completion_QCH[2019-04-12T10:41:54.899Z] Scanning dependencies of target KF5KIONTLM_autogen[2019-04-12T10:41:54.899Z] [  2%] Generating moc_predefs.h[2019-04-12T10:41:54.899Z] Scanning dependencies of target kded_kcookiejar_autogen[2019-04-12T10:41:54.899Z] [  2%] Built target KF5Codecs_QCH[2019-04-12T10:41:54.899Z] [  2%] Automatic MOC for target protocoltojson[2019-04-12T10:41:54.899Z] [  2%] Built target KF5JobWidgets_QCH[2019-04-12T10:41:54.899Z] Scanning dependencies of target kcookiejar5_autogen[2019-04-12T10:41:54.899Z] Scanning dependencies of target ktelnetservice5_autogen[2019-04-12T10:41:54.899Z] Scanning dependencies of target kpac_dhcp_helper_autogen[2019-04-12T10:41:54.899Z] [  2%] Automatic MOC for target kded_kcookiejar[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target KF5KIONTLM[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target kcookiejar5[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target KF5KIOCore[2019-04-12T10:41:54.899Z] Scanning dependencies of target lockingtest_autogen[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target ktelnetservice5[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target kpac_dhcp_helper[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target lockingtest[2019-04-12T10:41:54.899Z] [  3%] Built target protocoltojson_autogen[2019-04-12T10:41:54.899Z] [  3%] Built target KF5KIONTLM_autogen[2019-04-12T10:41:54.899Z] Scanning dependencies of target httpheaderdispositiontest_autogen[2019-04-12T10:41:54.899Z] [  3%] Built target ktelnetservice5_autogen[2019-04-12T10:41:54.899Z] Scanning dependencies of target httpheadertokenizetest_autogen[2019-04-12T10:41:54.899Z] [  3%] Built target kcookiejar5_autogen[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target httpheaderdispositiontest[2019-04-12T10:41:54.899Z] Scanning dependencies of target httpfiltertest_autogen[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target httpheadertokenizetest[2019-04-12T10:41:54.899Z] [  3%] Built target kpac_dhcp_helper_autogen[2019-04-12T10:41:54.899Z] Scanning dependencies of target KF5KIO_QCH[2019-04-12T10:41:54.899Z] [  3%] Automatic MOC for target httpfiltertest[2019-04-12T10:41:54.899Z] [  3%] Built target kded_kcookiejar_autogen[2019-04-12T10:41:55.157Z] [  3%] Built target lockingtest_autogen[2019-04-12T10:41:55.157Z] [  3%] Generating src/KF5KIO.qch, src/KF5KIO.tags[2019-04-12T10:41:55.157Z] Scanning dependencies of target protocoltojson[2019-04-12T10:41:55.157Z] [  3%] Generating org.kde.KCookieServer.xml[2019-04-12T10:41:55.157Z] [  3%] Built target httpheaderdispositiontest_autogen[2019-04-12T10:41:55.157Z] Scanning dependencies of target KF5KIONTLM[2019-04-12T10:41:55.157Z] [  3%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.o[2019-04-12T10:41:55.157Z] [  3%] Built target httpheadertokenizetest_autogen[2019-04-12T10:41:55.157Z] [  3%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[2019-04-12T10:41:55.157Z] [  3%] Generating org.kde.KCookieServer.xml[2019-04-12T10:41:55.157Z] qdbusxml2cpp: Cannot process input: '/home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.[2019-04-12T10:41:55.157Z] make[2]: *** [src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/build.make:66: src/ioslaves/http/kcookiejar/kcookieserverinterface.cpp] Error 1[2019-04-12T10:41:55.157Z] make[1]: *** [CMakeFiles/Makefile2:2782: src/ioslaves/http/kcookiejar/CMakeFiles/kcookiejar5.dir/all] Error 2[2019-04-12T10:41:55.157Z] make[1]: *** Waiting for unfinished jobs[2019-04-12T10:41:55.157Z] [  3%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.o[2019-04-12T10:41:55.157Z] Scanning dependencies of target ktelnetservice5[2019-04-12T10:41:55.157Z] [  3%] 

D20465: [KDynamicJobTracker] When kuiserver isn't available, also fall back to widget dialog

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:580fec7c0b20: [KDynamicJobTracker] When kuiserver 
isnt available, also fall back to widget… (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20465?vs=55984=56052

REVISION DETAIL
  https://phabricator.kde.org/D20465

AFFECTED FILES
  src/widgets/kdynamicjobtracker.cpp

To: broulik, #frameworks, dfaure, lbeltrame
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20462: [KUiServerJobTracker] Track kuiserver service life time and re-register jobs if needed

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R288:130809f97e6f: [KUiServerJobTracker] Track kuiserver 
service life time and re-register jobs if… (authored by broulik).

REPOSITORY
  R288 KJobWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20462?vs=55976=56051

REVISION DETAIL
  https://phabricator.kde.org/D20462

AFFECTED FILES
  src/kuiserverjobtracker.cpp
  src/kuiserverjobtracker_p.h

To: broulik, #frameworks, dfaure, lbeltrame, kossebau, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20467: Allow to close a document whose file was deleted on disk

[Christoph Cullmann]

cullmann added a comment.


  The current implementation at least closes the file, in all applications.
  It just doesn't remove in in all of them from the document list.
  I think that is ok enough, more can't be done in KTextEditor.
  Extra reviews for extending the applications are welcome.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20467

To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars

D18824: Implement wl_eglstream_controller Server Interface

[Roman Gilg]

romangg added a comment.


  The xml file is missing form the diff now. Don't forget to add it when 
pushing.
  
  In the first revision the interface failed to create when the dynamically 
loaded library was not present. Now it just fails silently on bind. Why is this 
ok?

INLINE COMMENTS

> romangg wrote in display.h:310
> 5.56

Now it would be 5.58 (change it when pushing).

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18824

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, michaelh, 
bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 WindowsMSVCQt5.11 - Build # 154 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20WindowsMSVCQt5.11/154/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Apr 2019 09:21:52 +
 Build duration:
30 min and counting
   CONSOLE OUTPUT
  [...truncated 336 lines...][2019-04-12T09:52:23.356Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T09:52:23.356Z] [2019-04-12T09:52:23.356Z] [2019-04-12T09:52:23.356Z] -- No such tag file "C:/CI/Software Installs/kconfig/bin/data/doc/qch/KF5Config.tags" found for KF5Config_QCH when calling ecm_add_qch().[2019-04-12T09:52:23.356Z] CMake Warning at C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:391 (message):[2019-04-12T09:52:23.356Z]   No linking to API dox of KF5Config_QCH.[2019-04-12T09:52:23.356Z] Call Stack (most recent call first):[2019-04-12T09:52:23.357Z]   C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)[2019-04-12T09:52:23.357Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T09:52:23.357Z] [2019-04-12T09:52:23.357Z] [2019-04-12T09:52:23.357Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5CoreAddons.tags" found for KF5CoreAddons_QCH when calling ecm_add_qch().[2019-04-12T09:52:23.357Z] CMake Warning at C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:391 (message):[2019-04-12T09:52:23.357Z]   No linking to API dox of KF5CoreAddons_QCH.[2019-04-12T09:52:23.357Z] Call Stack (most recent call first):[2019-04-12T09:52:23.357Z]   C:/CI/Software Installs/plasma-framework/share/ECM/modules/ECMAddQch.cmake:566 (_ecm_collect_linkable_qch_targets)[2019-04-12T09:52:23.357Z]   src/plasma/CMakeLists.txt:205 (ecm_add_qch)[2019-04-12T09:52:23.357Z] [2019-04-12T09:52:23.357Z] [2019-04-12T09:52:23.357Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-04-12T09:52:23.357Z] -- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.[2019-04-12T09:52:23.655Z] -- The following features have been enabled:[2019-04-12T09:52:23.655Z] [2019-04-12T09:52:23.655Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-04-12T09:52:23.655Z] [2019-04-12T09:52:23.655Z] -- The following OPTIONAL packages have been found:[2019-04-12T09:52:23.655Z] [2019-04-12T09:52:23.655Z]  * KF5DocTools (required version >= 5.57.0), Tools to generate documentation[2019-04-12T09:52:23.655Z]  * OpenGL, The OpenGL libraries, [2019-04-12T09:52:23.655Z]  * PkgConfig[2019-04-12T09:52:23.655Z] [2019-04-12T09:52:23.655Z] -- The following REQUIRED packages have been found:[2019-04-12T09:52:23.655Z] [2019-04-12T09:52:23.655Z]  * Qt5Network (required version >= 5.11.2)[2019-04-12T09:52:23.655Z]  * Qt5Quick[2019-04-12T09:52:23.655Z]  * Qt5Gui[2019-04-12T09:52:23.655Z]  * Qt5Sql[2019-04-12T09:52:23.655Z]  * Qt5Qml[2019-04-12T09:52:23.655Z]  * Qt5Svg[2019-04-12T09:52:23.656Z]  * Qt5QuickControls2[2019-04-12T09:52:23.656Z]  * Qt5 (required version >= 5.10.0)[2019-04-12T09:52:23.656Z]  * KF5Activities (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Archive (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Config (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5ConfigWidgets (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5DBusAddons (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Declarative (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5GlobalAccel (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5GuiAddons (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * Gettext[2019-04-12T09:52:23.656Z]  * KF5I18n (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5IconThemes (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5KIO (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Service (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5WindowSystem (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Notifications (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Package (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5Kirigami2 (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * KF5 (required version >= 5.57.0)[2019-04-12T09:52:23.656Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-04-12T09:52:23.656Z]  * Doxygen (required version >= 1.8.13)[2019-04-12T09:52:23.656Z]Needed for API dox QCH file generation[2019-04-12T09:52:23.656Z]  * QHelpGenerator, Part of Qt5 tools[2019-04-12T09:52:23.656Z]Needed for API dox QCH file generation[2019-04-12T09:52:23.656Z]  * Qt5Test (required version >= 5.10.0)[2019-04-12T09:52:23.656Z]Required for tests[2019-04-12T09:52:23.656Z]  * KF5CoreAddons[2019-04-12T09:52:23.656Z]  * KF5XmlGui[2019-04-12T09:52:23.656Z]  * Qt5Widgets[2019-04-12T09:52:23.656Z] [2019-04-12T09:52:23.656Z] -- The following 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/62/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Apr 2019 09:21:52 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13367)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/72/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 12 Apr 2019 09:21:52 +
 Build duration:
5 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/69/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 12 Apr 2019 09:21:52 +
 Build duration:
4 min 48 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.57.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13367)18%
(1818/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2273)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1182)0%
(0/1022)tests.dpi0%
 

D20264: Add test for "Auto Reload Document" option

[Dominik Haumann]

dhaumann added a comment.


  I think KateViewInternal::updateView is called for cursor blinking for 
instance. May that be an issue?

REVISION DETAIL
  https://phabricator.kde.org/D20264

To: loh.tar, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20478: Breeze desktoptheme clock: support hand shadow offset hint of Plasma 5.16

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:417a82b1b947: Breeze desktoptheme clock: support hand 
shadow offset hint of Plasma 5.16 (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20478?vs=56027=56047

REVISION DETAIL
  https://phabricator.kde.org/D20478

AFFECTED FILES
  src/desktoptheme/breeze/widgets/clock.svg

To: kossebau, #plasma, #vdg, mart, davidedmundson, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20467: Allow to close a document whose file was deleted on disk

[Dominik Haumann]

dhaumann added a comment.


  Hm, the correct fix is to implement this function for KWrite.
  
  And: There is also KDevelop and Kile...
  Having only a half-working solution sounds suboptimal to me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20467

To: meven, cullmann, #kate, #frameworks, dhaumann
Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars