D20586: Sharpen Z's in system-suspend* icons

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sharp-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20589: Add QML to source code types

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  qml

REVISION DETAIL
  https://phabricator.kde.org/D20589

To: nicolasfella, #baloo, ngraham
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[David Edmundson]

davidedmundson added a comment.


  > And @mart if you have some time, I could use a hand figuring out why 
flickable.contentHeight is always evaluating to 0 here.
  
  so right now this patch does nothing?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart
Cc: davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D20092: New class KOSRelease - a parser for os-release files

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20092

To: sitter, apol, mpyne
Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, 
ngraham, bruns

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D20524

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20524: [FileMetaDataWidget] Allow inline configuration of visible properties

[Stefan Brüns]

bruns updated this revision to Diff 56337.
bruns added a comment.


  correct since version

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20524?vs=56206=56337

BRANCH
  metadata_config_inline

REVISION DETAIL
  https://phabricator.kde.org/D20524

AFFECTED FILES
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: bruns, #baloo, #dolphin, #frameworks, ngraham, astippich
Cc: elvisangelaccio, gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20589: Add QML to source code types

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  qml

REVISION DETAIL
  https://phabricator.kde.org/D20589

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: nicolasfella, #baloo
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20586

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  They weren't aligned to the pixel grid before.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sharp-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20586

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: grantlee commit access

[David Faure]

[CC kde-frameworks-devel for information]

Hi Stephen,

Thanks for the merge of the Qt 5.13 build fix.

I would certainly welcome grantlee as a KF5 framework, I think it makes things 
easier from a KDE point of view, and it reduces the bus factor in terms of who 
can actually push to the repository. At the same time, we still need you as 
the maintainer, so I hope this isn't a push-and-forget, but just a different 
contribution model and a different release model.

My releasing of KF5 is very very automated, I certainly don't mind one more 
framework, if it follows the rules :)

Some reorganization will be needed, see
https://community.kde.org/Frameworks/Policies#Framework_directory_structure

Then there is the checklist at
https://community.kde.org/Frameworks/CreationGuidelines

I also noted that the current README.md mentions "Grantlee Templates and 
Grantlee TextDocument" but then only explains what the first one is, nothing 
else is said about TextDocument?

Cheers,
David.

On lundi 15 avril 2019 09:59:15 CEST Stephen Kelly wrote:
> Hi David,
> 
> I'm just merging that now. Thanks for the heads-up.
> 
> I have been thinking of putting making Grantlee a KF5 Framework, as I
> haven't been fast with maintenance lately.
> 
> My idea would be that I'll go through the github issues/PRs etc and make
> one more release, then push it to KDE.
> 
> That would have a few implications, such as you would be releasing it
> etc. Do you think that would work?
> 
> Thanks,
> 
> Stephen.
> 
> On 15/04/2019 08:01, David Faure wrote:
> > Hi Stephen,
> > 
> > can you merge https://github.com/steveire/grantlee/pull/48 ?
> > 
> > This is blocking builds with Qt 5.13.
> > 
> > Can you give me push access so we're not blocked if you have moved on?
> > Alternatively we'll have to fork it on kde.org

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D20428: separe mobile text selection to avoid recursive imports

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ComboBox.qml:174
>  id: mobileCursor
>  Private.MobileCursor {
>  target: textField

Does this not need to be adjusted? `ComboBox` is broken here.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20428

To: mart, #plasma, hein
Cc: broulik, hein, kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart
Cc: GB_2, kde-frameworks-devel, michaelh, ngraham, bruns

D20565: Ensure not to fold the end marker

[Christoph Cullmann]

cullmann added reviewers: dhaumann, ngraham.
cullmann added a comment.


  I like the idea, its nice for e.g. if then else cascades, you get then out of 
stuff like
  
if (blockwise || range.onSingleLine()) {
lineStart = range.start().column();
remainingChars = range.columnWidth();
} else if (i == range.start().line()) {
lineStart = range.start().column();
} else if (i == range.end().line()) {
remainingChars = range.end().column();
}

if (blockwise || range.onSingleLine()) {
} else if (i == range.start().line()) {
} else if (i == range.end().line()) {
}
  
  which is still nicely readable.
  
  Are others ok with this, too?
  
  For the code: Perhaps one should only adjust at all, if the ranges spans more 
than one line, to avoid accidents.

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20534: avoid conflicting shortcuts for switching tabs

[Nathaniel Graham]

ngraham added a comment.


  Thank you for this!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20534

To: cullmann, #kate, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20534: avoid conflicting shortcuts for switching tabs

[Dominik Haumann]

dhaumann added a comment.


  lgtm

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20534

To: cullmann, #kate, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

[Noah Davis]

ndavis added a comment.


  In D20140#450349 , @GB_2 wrote:
  
  > Ping
  
  
  Sorry, I'm just busy right now and I'm not that familiar with QML, so it 
won't be quick and easy for me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: GB_2, ngraham, kde-frameworks-devel, michaelh, bruns

D20558: Bug fix: find c++ stl using regex

[Sharaf Zaman]

sh-zam updated this revision to Diff 56311.
sh-zam added a comment.


  - disallow whitespaces in path

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20558?vs=56257=56311

BRANCH
  arcpatch-D20558

REVISION DETAIL
  https://phabricator.kde.org/D20558

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: sh-zam, apol
Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20579: [FrameSvgItem] Update filtering on smooth changes

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, broulik, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  When just the smooth property is changed, this also results in a call of
  QQuickItem::updatePaintNode reimplementations. So always just set the
  filtering flag to match the current value of the smooth property.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  updateframesvgitemsonsmoothchange

REVISION DETAIL
  https://phabricator.kde.org/D20579

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma, broulik, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20565: Ensure not to fold the end marker

[loh tar]

loh.tar updated this revision to Diff 56306.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  - Adjust only on token based folding

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20565?vs=56267=56306

REVISION DETAIL
  https://phabricator.kde.org/D20565

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/32/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Apr 2019 14:26:30 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5Wayland-5.58.0.xmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(238/262)91%
(238/262)82%
(25866/31444)51%
(10272/20181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)94%
(11702/12390)48%
(6138/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client97%
(72/74)97%
(72/74)81%
(5971/7372)59%
(1658/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7739/9029)66%
(2299/3506)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/28/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 15 Apr 2019 14:26:30 +
 Build duration:
5 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5Wayland-5.58.0.xmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(26874/31490)53%
(10783/20181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12323/12393)50%
(6487/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6284/7396)65%
(1810/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7813/9048)66%
(2309/3506)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/36/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 15 Apr 2019 14:26:29 +
 Build duration:
5 min 35 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D18824: Implement wl_eglstream_controller Server Interface

[Erik Kurzinger]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:e208389cc68c: Implement wl_eglstream_controller Server 
Interface (authored by ekurzinger).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18824?vs=56078=56299

REVISION DETAIL
  https://phabricator.kde.org/D18824

AFFECTED FILES
  src/client/protocols/wayland-eglstream-controller.xml
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/eglstream_controller_interface.cpp
  src/server/eglstream_controller_interface.h
  src/server/eglstream_controller_interface_p.h

To: ekurzinger, romangg, davidedmundson, #kwin
Cc: zzag, ngraham, mati865, schernikov, guilhermesi, kde-frameworks-devel, 
michaelh, bruns

Re: New framework: KCalCore

[Aleix Pol]

On Mon, Apr 15, 2019 at 2:52 PM David Jarvie  wrote:
>
>
>
> On 15 April 2019 13:25:56 BST, Allen Winter  wrote:
> > On Monday, April 15, 2019 6:40:06 AM EDT Daniel Vrátil wrote:
> > > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote:
> > > > On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote:
> > > > > On 14 April 2019 12:31:41 BST, David Faure 
> > wrote:
> > > > > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I'd like to propose KCalCore for review to move from KDE PIM
> > to KF5.
> > > > > > >
> > > > > > > KCalCore is an implementation of the iCalendar standard
> > based on
> > > > > >
> > > > > > libical,
> > > > > >
> > > > > > I wonder about the name, which doesn't mean much outside the
> > circle of
> > > > > > PIM people. Shouldn't this be called KCalendar ?
> > > > > >
> > > > > > If the "Core" simply means non-GUI, we certainly don't have
> > that word
> > > > > > in every non-GUI framework.
> > > > >
> > > > > Renaming makes sense. KCalendar suggests it could be about
> > calendar
> > > > > systems,
> > > > Indeed.
> > > >
> > > > > so to avoid that confusion, perhaps call it KiCalendar?
> > > >
> > > > Doesn't read very well
> > > > I would want to say KCalendarEvents but I guess the more correct
> > generic
> > > > term would be KCalendarIncidences ... not convicing either.
> > > >
> > > > Maybe KCal is enough? Reminds of iCal.
> > >
> > > Wasn't KCal the original name of the library from pre-Akonadi times?
> > KCalCore
> > > was a fork of KCal with the pre-Akonadi "Resources" system
> > removed...
> > >
> > Yep.  Back to the Future.  Let's stay away from "KCal" and "KCalendar"
> >
> > commit 6b4c1896211075fcd0b88b2c617eaacd831c9f6d
> > Author: Allen Winter 
> > Date:   Sat Jul 17 17:00:14 2010 +
> >
> > Add the new KCalCore library.
> >
> >  The KCalCore library deprecates and mostly replaces the KCal library.
> > KCalCore is free of any relation to the old Calendar resources and
> > focuses entirely on iCalendar and vCalendar storage and data
> > manipulation.
> >  KCalCore used QSharedPointers for safe memory access, is free of i18n
> >  strings and contains no methods for user interaction: KCalCore is all
> > about the calendar data.
>
> Would KCalendarSerialization be a better name? I think that sums up its 
> purpose.
>
> --
> David Jarvie
> KAlarm author, KDE developer
> http://www.astrojar.org.uk/kalarm

KContacts is the framework dealing with vcards (which are equivalent
to iCal, for contacts). It makes sense to follow the same naming.

If we really don't want calendaring functions there, we could consider
calling it KiCal, I don't think it's that bad either and it's
definitely more self-explanatory. Or we call it KCalendar and allow
having calendar building blocks in it which could make sense as well,
if required.

Aleix

Re: New framework: KCalCore

[David Jarvie]

On 15 April 2019 13:25:56 BST, Allen Winter  wrote:
> On Monday, April 15, 2019 6:40:06 AM EDT Daniel Vrátil wrote:
> > On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote:
> > > On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote:
> > > > On 14 April 2019 12:31:41 BST, David Faure 
> wrote:
> > > > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote:
> > > > > > Hi,
> > > > > > 
> > > > > > I'd like to propose KCalCore for review to move from KDE PIM
> to KF5.
> > > > > > 
> > > > > > KCalCore is an implementation of the iCalendar standard
> based on
> > > > > 
> > > > > libical,
> > > > > 
> > > > > I wonder about the name, which doesn't mean much outside the
> circle of
> > > > > PIM people. Shouldn't this be called KCalendar ?
> > > > > 
> > > > > If the "Core" simply means non-GUI, we certainly don't have
> that word
> > > > > in every non-GUI framework.
> > > > 
> > > > Renaming makes sense. KCalendar suggests it could be about
> calendar
> > > > systems,
> > > Indeed.
> > > 
> > > > so to avoid that confusion, perhaps call it KiCalendar?
> > > 
> > > Doesn't read very well
> > > I would want to say KCalendarEvents but I guess the more correct
> generic
> > > term would be KCalendarIncidences ... not convicing either.
> > > 
> > > Maybe KCal is enough? Reminds of iCal.
> > 
> > Wasn't KCal the original name of the library from pre-Akonadi times?
> KCalCore 
> > was a fork of KCal with the pre-Akonadi "Resources" system
> removed...
> > 
> Yep.  Back to the Future.  Let's stay away from "KCal" and "KCalendar"
> 
> commit 6b4c1896211075fcd0b88b2c617eaacd831c9f6d
> Author: Allen Winter 
> Date:   Sat Jul 17 17:00:14 2010 +
> 
> Add the new KCalCore library.
> 
>  The KCalCore library deprecates and mostly replaces the KCal library.
> KCalCore is free of any relation to the old Calendar resources and
> focuses entirely on iCalendar and vCalendar storage and data
> manipulation.
>  KCalCore used QSharedPointers for safe memory access, is free of i18n
>  strings and contains no methods for user interaction: KCalCore is all
> about the calendar data.

Would KCalendarSerialization be a better name? I think that sums up its purpose.

--
David Jarvie
KAlarm author, KDE developer
http://www.astrojar.org.uk/kalarm

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/79/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 15 Apr 2019 11:40:11 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/86/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 15 Apr 2019 10:22:00 +
 Build duration:
1 hr 28 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/78/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 15 Apr 2019 09:31:46 +
 Build duration:
2 hr 8 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/76/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Apr 2019 10:46:41 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13355)18%
(1818/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/69/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 15 Apr 2019 10:46:47 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

D20570: [FrameSvgItem] Respect smooth property

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:2a636d66712f: [FrameSvgItem] Respect smooth property 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20570?vs=56289=56290

REVISION DETAIL
  https://phabricator.kde.org/D20570

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: broulik, #plasma, mart
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> framesvgitem.cpp:95
>  {
> +setFiltering(filtering);
>  m_lastParent->appendChildNode(this);

could have here
frameSvg->smooth() ? QSGTexture::Linear : QSGTexture::Nearest;

to make the patch smaller?

anyways, i'm fine with either.. this one calculates the sace only once so may 
be arguued to be better

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20570

To: broulik, #plasma, mart
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

[Kai Uwe Broulik]

broulik updated this revision to Diff 56289.
broulik added a comment.


  - Also update corner nodes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20570?vs=56288=56289

REVISION DETAIL
  https://phabricator.kde.org/D20570

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: broulik, #plasma
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 68 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/68/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 15 Apr 2019 07:51:29 +
 Build duration:
2 hr 49 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

Re: New framework: KCalCore

[Daniel Vrátil]

On Sunday, 14 April 2019 20:17:54 CEST David Faure wrote:
> On dimanche 14 avril 2019 19:46:02 CEST David Jarvie wrote:
> > On 14 April 2019 12:31:41 BST, David Faure  wrote:
> > > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote:
> > > > Hi,
> > > > 
> > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> > > > 
> > > > KCalCore is an implementation of the iCalendar standard based on
> > > 
> > > libical,
> > > 
> > > I wonder about the name, which doesn't mean much outside the circle of
> > > PIM people. Shouldn't this be called KCalendar ?
> > > 
> > > If the "Core" simply means non-GUI, we certainly don't have that word
> > > in every non-GUI framework.
> > 
> > Renaming makes sense. KCalendar suggests it could be about calendar
> > systems,
> Indeed.
> 
> > so to avoid that confusion, perhaps call it KiCalendar?
> 
> Doesn't read very well
> I would want to say KCalendarEvents but I guess the more correct generic
> term would be KCalendarIncidences ... not convicing either.
> 
> Maybe KCal is enough? Reminds of iCal.

Wasn't KCal the original name of the library from pre-Akonadi times? KCalCore 
was a fork of KCal with the pre-Akonadi "Resources" system removed...

-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

D20570: [FrameSvgItem] Respect smooth property

[Marco Martin]

mart added a comment.


  FrameItemNode needs the same

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20570

To: broulik, #plasma
Cc: mart, kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

[Kai Uwe Broulik]

broulik planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20570

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20570: [FrameSvgItem] Respect smooth property

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  Set `smooth: true`, rotated it, didn't look jagged anymore

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20570

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/85/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 13 Apr 2019 10:00:20 +
 Build duration:
2 days 0 hr and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_threadtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/68/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 15 Apr 2019 09:31:46 +
 Build duration:
40 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3636/13354)18%
(1822/9854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2257)6%
(91/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(689/1579)29%
(304/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in informationpanelcontent.cpp:237
> Coding style: brace should go to next line (the function below is also 
> wrong...)

The glory of copy and paste ;-)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns updated this revision to Diff 56287.
bruns marked 3 inline comments as done.
bruns added a comment.


  bump baloo widgets version
  cleanup

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20525?vs=56194=56287

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20525

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/panels/information/filemetadataconfigurationdialog.cpp
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanel.cpp
  src/panels/information/informationpanelcontent.cpp
  src/panels/information/informationpanelcontent.h

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/75/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 15 Apr 2019 09:31:46 +
 Build duration:
3 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13353)18%
(1819/9854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2257)6%
(91/1454)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D20550: Oxygen desktoptheme: add padding to hands, against jagged outline on rotation

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b9ac83d4d7f5: Oxygen desktoptheme: add padding to hands, 
against jagged outline on rotation (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20550?vs=56224=56285

REVISION DETAIL
  https://phabricator.kde.org/D20550

AFFECTED FILES
  src/desktoptheme/oxygen/widgets/clock.svg

To: kossebau, #vdg, #plasma, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20542: Retitle button "Close" to "Close file" when a file has been removed on disk

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e70ebb44a17d: Retitle button Close to 
Close file when a file has been removed on disk (authored by meven).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20542?vs=56231=56279

REVISION DETAIL
  https://phabricator.kde.org/D20542

AFFECTED FILES
  src/dialogs/katedialogs.cpp

To: meven, #ktexteditor, ngraham, cullmann
Cc: cullmann, kossebau, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D20556: Keep empty Json metadata docs out of DocumentData DB

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:5a8f402b56de: Keep empty Json metadata docs out of 
DocumentData DB (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20556?vs=56241=56278

REVISION DETAIL
  https://phabricator.kde.org/D20556

AFFECTED FILES
  src/file/extractor/result.cpp
  src/lib/file.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams