D20693: Remove pixelated border

[Anthony Fieroni]

anthonyfieroni added a comment.


  Will be good see how it looks in dark theme, especially dark pictures.

REPOSITORY
  R304 KNewStuff

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: anthonyfieroni, mmustac, ndavis, kde-frameworks-devel, #knewstuff, 
michaelh, ZrenBot, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas added a comment.


  In D20209#455579 , @aacid wrote:
  
  > @hallas but tests are still failing since your previous commit. Can you 
have a look? 
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/
  
  
  @aacid - Sorry about that :/ I will take a look at it today - and thanks for 
fixing compilation!

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

Re: MacOS Builds - KArchive & KDocTools

[Ben Cooksley]

On Thu, Apr 25, 2019 at 11:36 AM Luigi Toscano  wrote:
>
> Ben Cooksley ha scritto:
> > Hi all,
> >
> > While getting Mac builds back on their feet this morning we've run
> > into a rather terminal build failure issue, centering around KArchive
> > and KDocTools.
> >
> > The issue is struck during the build of KDocTools, when the linking of
> > libKF5DocTools.dylib fails with the following message:
> >
> > Undefined symbols for architecture x86_64:
> > "KFilterDev::KFilterDev(QString const&)", referenced from:
> >  KDocTools::saveToCache(QString const&, QString const&) in 
> > xslt_kde.cpp.o
> >  "KCompressionDevice::open(QFlags)",
> > referenced from:
> >  KDocTools::saveToCache(QString const&, QString const&) in 
> > xslt_kde.cpp.o
> >  "KCompressionDevice::close()", referenced from:
> >  KDocTools::saveToCache(QString const&, QString const&) in 
> > xslt_kde.cpp.o
> >  "KCompressionDevice::~KCompressionDevice()", referenced from:
> >  KDocTools::saveToCache(QString const&, QString const&) in 
> > xslt_kde.cpp.o
> >ld: symbol(s) not found for architecture x86_64
> > clang: error: linker command failed with exit code 1 (use -v to see 
> > invocation)
> >
> > Anyone got any ideas?
> >
>
> It was reported as https://bugs.kde.org/show_bug.cgi?id=406663 less than one
> week ago, but to be honest I have no idea. Is it a new issue, or have the
> failure started recently?
> The only relevant change to KFilterDev is:
> https://commits.kde.org/karchive/710ffdc3c45a1c683ccca988138798f9945c26b1
> The code of KDocTools has been pretty stable for a while.

The failure only started recently, however that's a little bit of a
red herring because the Binary Factory doesn't regularly do rebuilds
of things, so the last time this would have been validated as working
would have been the last Frameworks release.

Not helping things is that we recently upgraded the Binary Factory
node from MacOS Sierra to Mojave, and then updated XCode, so this
could be more due to those changing rather than things changing on the
KDE side.

Having a look with 'nm' makes it looks like this is a symbol
visibility/export issue in KArchive:

KDEs-Mac-mini:macos-64-clang kdeosxci$ nm -demangle
lib/libKF5Archive.dylib  | grep -i KFilterDev
0002ab70 s qt_meta_data_KFilterDev
0002c818 d qt_meta_stringdata_KFilterDev
00028800 t KFilterDev::qt_metacall(QMetaObject::Call, int, void**)
000287a0 t KFilterDev::qt_metacast(char const*)
0002c140 s KFilterDev::staticMetaObject
00028770 t KFilterDev::qt_static_metacall(QObject*,
QMetaObject::Call, int, void**)
c550 t KFilterDev::compressionTypeForMimeType(QString const&)
c540 t KFilterDev::KFilterDev(QString const&)
c480 t KFilterDev::KFilterDev(QString const&)
000288a0 t KFilterDev::~KFilterDev()
00028890 t KFilterDev::~KFilterDev()
00028780 t KFilterDev::metaObject() const
0002c3a0 s typeinfo for KFilterDev
0002ac05 s typeinfo name for KFilterDev
0002c2a8 s vtable for KFilterDev
0002c4f0 d KFilterDev::compressionTypeForMimeType(QString
const&)::$_0::operator()() const::qstring_literal
0002c530 d KFilterDev::compressionTypeForMimeType(QString
const&)::$_1::operator()() const::qstring_literal
0002c570 d KFilterDev::compressionTypeForMimeType(QString
const&)::$_2::operator()() const::qstring_literal
0002c5b0 d KFilterDev::compressionTypeForMimeType(QString
const&)::$_3::operator()() const::qstring_literal

Does this seem consistent?

(Running nm -g doesn't include any of the KFilterDev classes)

>
> Ciao
> --
> Luigi

Cheers,
Ben

Re: MacOS Builds - KArchive & KDocTools

[Luigi Toscano]

Ben Cooksley ha scritto:

Hi all,

While getting Mac builds back on their feet this morning we've run
into a rather terminal build failure issue, centering around KArchive
and KDocTools.

The issue is struck during the build of KDocTools, when the linking of
libKF5DocTools.dylib fails with the following message:

Undefined symbols for architecture x86_64:
"KFilterDev::KFilterDev(QString const&)", referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
 "KCompressionDevice::open(QFlags)",
referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
 "KCompressionDevice::close()", referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
 "KCompressionDevice::~KCompressionDevice()", referenced from:
 KDocTools::saveToCache(QString const&, QString const&) in 
xslt_kde.cpp.o
   ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Anyone got any ideas?



It was reported as https://bugs.kde.org/show_bug.cgi?id=406663 less than one 
week ago, but to be honest I have no idea. Is it a new issue, or have the 
failure started recently?

The only relevant change to KFilterDev is:
https://commits.kde.org/karchive/710ffdc3c45a1c683ccca988138798f9945c26b1
The code of KDocTools has been pretty stable for a while.

Ciao
--
Luigi

MacOS Builds - KArchive & KDocTools

[Ben Cooksley]

Hi all,

While getting Mac builds back on their feet this morning we've run
into a rather terminal build failure issue, centering around KArchive
and KDocTools.

The issue is struck during the build of KDocTools, when the linking of
libKF5DocTools.dylib fails with the following message:

Undefined symbols for architecture x86_64:
   "KFilterDev::KFilterDev(QString const&)", referenced from:
KDocTools::saveToCache(QString const&, QString const&) in xslt_kde.cpp.o
"KCompressionDevice::open(QFlags)",
referenced from:
KDocTools::saveToCache(QString const&, QString const&) in xslt_kde.cpp.o
"KCompressionDevice::close()", referenced from:
KDocTools::saveToCache(QString const&, QString const&) in xslt_kde.cpp.o
"KCompressionDevice::~KCompressionDevice()", referenced from:
KDocTools::saveToCache(QString const&, QString const&) in xslt_kde.cpp.o
  ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Anyone got any ideas?

Cheers,
Ben

D20693: Remove pixelated border

[Nathaniel Graham]

ngraham added a comment.


  Looks great, though I would put the search field on top. It's a lot like the 
new GridView KCMs; maybe we can even use that template for it. The current 
Colors KCM looks a lot like that.

REPOSITORY
  R304 KNewStuff

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: mmustac, ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, 
ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[Albert Astals Cid]

aacid added a comment.


  @hallas but tests are still failing since your previous commit. Can you have 
a look? 
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/testReport/

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.10 - Build # 21 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/21/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Apr 2019 20:33:36 +
 Build duration:
2 min 34 sec and counting
   BUILD ARTIFACTS
  acc/KF5Bookmarks-5.58.0.xmllogs/KF5Bookmarks/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarkmenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)28%
(9/32)28%
(9/32)28%
(569/1999)19%
(218/1177)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)96%
(126/131)32%
(47/146)src24%
(7/29)24%
(7/29)24%
(443/1864)17%
(171/1031)tests0%
(0/1)0%
(0/1)0%
(0/4)100%
(0/0)

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.12/18/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Apr 2019 20:33:36 +
 Build duration:
2 min 47 sec and counting
   BUILD ARTIFACTS
  acc/KF5Bookmarks-5.58.0.xmllogs/KF5Bookmarks/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarkmenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)28%
(9/32)28%
(9/32)28%
(569/1999)19%
(218/1177)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)96%
(126/131)32%
(47/146)src24%
(7/29)24%
(7/29)24%
(443/1864)17%
(171/1031)tests0%
(0/1)0%
(0/1)0%
(0/4)100%
(0/0)

KDE CI: Frameworks » kbookmarks » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 24 Apr 2019 20:33:36 +
 Build duration:
49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarkmenutest

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[Albert Astals Cid]

aacid added a comment.


  I just fixed it FWIW

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Marijo Mustac]

mmustac added a comment.


  @ngraham: Fo sure, I will add my post from the forum here for better 
reference.
  
  > Today I thougtht about the design of the "Get new Hot Stuff" dialog. I 
think there is some room for improvements and to get a better overview.
  >  I tried to put my thought into a quick mockup. There are two screenshots 
to compare.
  > 
  > At first I think the "Get new Hot Stuff" needs to be an own application. No 
we have the KDE Store. Google has it's Play Store, Apple it's Appstore but what 
has KDE ?
  >  You could start the KDE Store directly or all other places would link to 
it's section. The first dropdown menu would provide access to all other 
categorys.
  >  The filter become also a dropdown menu and with the option to choose if I 
want to have an ascending or descening sorting.
  > 
  > The "new stuff" would be displayed in two columns to see more content at 
one time.
  >  Search is displayed at the bottom and a "filter by" option would you a 
quick overview about "all", "uninstalled" or "installed" content.
  >  And some smaller changes, you will see.
  
  F6791329: plasma-5.8-hotnewstuff-NEW.png 


REPOSITORY
  R304 KNewStuff

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: mmustac, ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, 
ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[Albert Astals Cid]

aacid added a comment.


  @hallas you seem to have broken compilation 
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/20/

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:2cbbfe2351a6: Rename edit-remove icon to 
edit-delete-remove to support Oxygen and other… (authored by GB_2).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20791?vs=56905=56907#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20791?vs=56905=56907

REVISION DETAIL
  https://phabricator.kde.org/D20791

AFFECTED FILES
  icons-dark/actions/16/edit-delete-remove.svg
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/22/edit-delete-remove.svg
  icons-dark/actions/22/edit-remove.svg
  icons/actions/16/edit-delete-remove.svg
  icons/actions/16/edit-remove.svg
  icons/actions/22/edit-delete-remove.svg
  icons/actions/22/edit-remove.svg

To: GB_2, #vdg, ngraham
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20791

To: GB_2, #vdg, ngraham
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a subscriber: mmustac.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D20693#455251 , @leinir wrote:
  
  > i'm afraid the "it works" is an illusion brought on by looking at content 
which doesn't show the issue... The main problem here is that we're dealing 
with user-generated content, and we can't assume that just because an image has 
a certain size, that space is actually filled with image data :/ F6790301: 
image.png 
  
  
  Sounds like we could handle that on the server side, to sanitize the image 
and delete any "empty space" around the image before handing it off to GHNS or 
Discover. Without that, I see what you mean that we actually can't add a frame 
and shadow though. So ship it!
  
  In D20693#455251 , @leinir wrote:
  
  > ! In D20693#455251 , @ngraham 
wrote:
  >
  > > Rewriting this in QML would be lovely (not in this patch though, 
obviously). I think we have a mockup of a new UI for it somewhere which I can't 
find right now but I'll try to dig it up.
  >
  > Thanks a bunch, just toss it at me when you've found it :)
  
  
  Found it at https://forum.kde.org/viewtopic.php?t=137732, but the link to the 
mockup is dead. @mmustac, would you be able to dig up the original and post it 
here?
  
  Also, rewriting this in QML would allow us to easily use its own tools to add 
a frame and drop shadow

REPOSITORY
  R304 KNewStuff

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: mmustac, ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, 
ngraham, bruns

D20791: Rename "edit-remove" icon to "edit-delete-remove" to support Oxygen and other icon themes

[Björn Feber]

GB_2 created this revision.
GB_2 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Icon themes that don't have the icon will now fall back to `edit-delete`.

TEST PLAN
  Search for `edit-delete-remove` in Cuttlefish.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20791

AFFECTED FILES
  icons-dark/actions/16/edit-delete-remove.svg
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/22/edit-delete-remove.svg
  icons-dark/actions/22/edit-remove.svg
  icons/actions/16/edit-delete-remove.svg
  icons/actions/16/edit-remove.svg
  icons/actions/22/edit-delete-remove.svg
  icons/actions/22/edit-remove.svg

To: GB_2, #vdg
Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D19812: Add a web page to view and compare icons of different sizes

[Nathaniel Graham]

ngraham added subscribers: GB_2, trickyricky26.
ngraham added a comment.


  TBH I wonder how useful this actually is. Hopefully some of the other folks 
involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on 
whether or not this would be useful for them.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, 
michaelh, bruns

D20626: Refactor and cleanup

[Shubham]

shubham added a comment.


  @dfaure Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20626: Refactor and cleanup

[Shubham]

shubham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20626

To: shubham, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kbookmarks » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 24 Apr 2019 14:41:46 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarkmenutest

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.12 - Build # 17 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.12/17/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Apr 2019 14:41:46 +
 Build duration:
3 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5Bookmarks-5.58.0.xmllogs/KF5Bookmarks/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarkmenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)28%
(9/32)28%
(9/32)28%
(569/1999)19%
(218/1177)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)96%
(126/131)32%
(47/146)src24%
(7/29)24%
(7/29)24%
(443/1864)17%
(171/1031)tests0%
(0/1)0%
(0/1)0%
(0/4)100%
(0/0)

KDE CI: Frameworks » kbookmarks » kf5-qt5 SUSEQt5.10 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Apr 2019 14:41:46 +
 Build duration:
2 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 278 lines...][2019-04-24T14:43:46.559Z]  * Qt5Gui (required version >= 5.10.1)[2019-04-24T14:43:46.559Z]  * Qt5Widgets[2019-04-24T14:43:46.559Z]  * Qt5Xml[2019-04-24T14:43:46.559Z]  * Qt5DBus[2019-04-24T14:43:46.559Z]  * Qt5 (required version >= 5.10.0)[2019-04-24T14:43:46.559Z]  * KF5Config (required version >= 5.57.0)[2019-04-24T14:43:46.559Z]  * KF5CoreAddons (required version >= 5.57.0)[2019-04-24T14:43:46.559Z]  * KF5Codecs (required version >= 5.57.0)[2019-04-24T14:43:46.559Z]  * KF5ConfigWidgets (required version >= 5.57.0)[2019-04-24T14:43:46.560Z]  * KF5WidgetsAddons (required version >= 5.57.0)[2019-04-24T14:43:46.560Z]  * KF5XmlGui (required version >= 5.57.0)[2019-04-24T14:43:46.560Z]  * Doxygen (required version >= 1.8.13)[2019-04-24T14:43:46.560Z]Needed for API dox QCH file generation[2019-04-24T14:43:46.560Z]  * QHelpGenerator, Part of Qt5 tools[2019-04-24T14:43:46.560Z]Needed for API dox QCH file generation[2019-04-24T14:43:46.560Z] [2019-04-24T14:43:46.560Z] -- Configuring done[2019-04-24T14:43:46.560Z] -- Generating done[2019-04-24T14:43:46.560Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kbookmarks/kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-04-24T14:43:49.351Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kbookmarks --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/[2019-04-24T14:43:49.620Z] Scanning dependencies of target KF5WidgetsAddons_QCH[2019-04-24T14:43:49.620Z] Scanning dependencies of target KF5Bookmarks_autogen[2019-04-24T14:43:49.620Z] [  0%] Built target KF5WidgetsAddons_QCH[2019-04-24T14:43:49.620Z] [  2%] Automatic MOC for target KF5Bookmarks[2019-04-24T14:43:49.620Z] Scanning dependencies of target KF5Bookmarks_QCH[2019-04-24T14:43:49.620Z] [  5%] Generating src/KF5Bookmarks.qch, src/KF5Bookmarks.tags[2019-04-24T14:43:50.190Z] [  5%] Built target KF5Bookmarks_autogen[2019-04-24T14:43:50.190Z] Scanning dependencies of target KF5Bookmarks[2019-04-24T14:43:50.190Z] [  8%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmark.cpp.o[2019-04-24T14:43:50.190Z] [ 11%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkaction.cpp.o[2019-04-24T14:43:50.190Z] [ 14%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkactioninterface.cpp.o[2019-04-24T14:43:50.190Z] [ 17%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkactionmenu.cpp.o[2019-04-24T14:43:50.453Z] [ 20%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkcontextmenu.cpp.o[2019-04-24T14:43:50.713Z] Building up file structure...[2019-04-24T14:43:50.713Z] Insert custom filters...[2019-04-24T14:43:50.713Z] Insert help data for filter section (1 of 1)...[2019-04-24T14:43:50.713Z] Insert files...[2019-04-24T14:43:50.713Z] Insert contents...[2019-04-24T14:43:50.713Z] Insert indices...[2019-04-24T14:43:50.713Z] Documentation successfully generated.[2019-04-24T14:43:50.713Z] [ 20%] Built target KF5Bookmarks_QCH[2019-04-24T14:43:51.688Z] [ 23%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkowner.cpp.o[2019-04-24T14:43:51.688Z] [ 26%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkmenu.cpp.o[2019-04-24T14:43:51.688Z] [ 29%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkmanager.cpp.o[2019-04-24T14:43:51.946Z] [ 32%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/konqbookmarkmenu.cpp.o[2019-04-24T14:43:51.946Z] [ 35%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkimporter_opera.cpp.o[2019-04-24T14:43:52.204Z] [ 38%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkimporter.cpp.o[2019-04-24T14:43:52.204Z] [ 41%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkimporter_ie.cpp.o[2019-04-24T14:43:52.204Z] [ 44%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkimporter_ns.cpp.o[2019-04-24T14:43:53.576Z] [ 47%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkdombuilder.cpp.o[2019-04-24T14:43:53.834Z] [ 50%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkdialog.cpp.o[2019-04-24T14:43:54.402Z] [ 52%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/ECMQmLoader-kbookmarks5_qt.cpp.o[2019-04-24T14:43:55.032Z] [ 55%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarkmanageradaptor.cpp.o[2019-04-24T14:43:56.433Z] [ 58%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/KF5Bookmarks_autogen/mocs_compilation.cpp.o[2019-04-24T14:43:57.812Z] [ 61%] Building CXX object src/CMakeFiles/KF5Bookmarks.dir/kbookmarks_debug.cpp.o[2019-04-24T14:43:58.756Z] [ 64%] Linking CXX shared library 

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas closed this revision.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20196: Add Notify capability to KConfigXT

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:5d2ed13479a4: Add Notify capability to KConfigXT 
(authored by broulik).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20196?vs=55730=56898

REVISION DETAIL
  https://phabricator.kde.org/D20196

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test_notifiers.cpp.ref
  autotests/kconfig_compiler/test_notifiers.h.ref
  autotests/kconfig_compiler/test_notifiers.kcfg
  autotests/kconfig_compiler/test_notifiers.kcfgc
  autotests/kconfig_compiler/test_notifiers_main.cpp
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 100 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/100/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Apr 2019 13:42:41 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.58.0.xmllogs/KF5TextEditor/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)68%
(33306/48701)51%
(15919/31087)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4710/5003)49%
(1781/3606)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1711/1903)76%
(1215/1602)src.completion100%
(11/11)100%
(11/11)57%
(1783/3125)43%
(1166/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)60%
(1927/3207)48%
(1616/3349)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(958/1246)67%
(631/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
(7/7)74%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 102 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/102/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 24 Apr 2019 13:42:41 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 85 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/85/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Apr 2019 13:42:41 +
 Build duration:
9 min 49 sec and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.58.0.xmllogs/KF5TextEditor/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)69%
(33373/48703)51%
(15963/31087)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4710/5003)49%
(1781/3606)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1711/1903)76%
(1215/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)60%
(1929/3207)48%
(1616/3349)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)78%
(973/1246)68%
(640/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
(7/7)74%
  

D20697: Review IconBorder

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0d70744ed67b: Fix broken InlineNoteTest (authored by 
loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20697?vs=56843=56895#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56843=56895

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  autotests/src/inlinenote_test.cpp

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: dfaure, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D19812: Add a web page to view and compare icons of different sizes

[Yunhe Guo]

guoyunhe added a comment.


  Hi @ngraham @pino @bcooksley , I have updated the script/configuration. Can 
you give some further opinion?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20628: Add CriticalNotification window type to PlasmaShellSurface protocol

[Kai Uwe Broulik]

broulik updated this revision to Diff 56884.
broulik edited the test plan for this revision.
broulik added a comment.


  - do proper versioning

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20628?vs=56422=56884

REVISION DETAIL
  https://phabricator.kde.org/D20628

AFFECTED FILES
  autotests/client/test_plasmashell.cpp
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/protocols/plasma-shell.xml
  src/client/registry.cpp
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  tests/plasmasurfacetest.cpp

To: broulik, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/85/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Apr 2019 09:55:33 +
 Build duration:
7 min 53 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13358)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2262)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/78/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Apr 2019 09:55:33 +
 Build duration:
7 min 21 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13358)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2262)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/88/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 24 Apr 2019 09:55:33 +
 Build duration:
5 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20735: [KPropertiesDialog] Add octal permissions

[Marijo Mustac]

mmustac added a comment.


  We could also make the permissions interactive and explaining at the same 
time.
  I could imagine something like this:
  F6790404: permissions.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20735

To: shubham, ngraham, pino
Cc: mmustac, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20693#454874 , @ngraham wrote:
  
  > To show that a thumbnail clickable, switching to the pointing hand cursor 
when hovering over a thumbnail could work.
  >
  > However I notice that the actual list delegates in the browse view seem to 
add frames and shadows to the thumbnails there, and they look okay. The frame's 
proportions even perfectly match the aspect ratio of the thumbnail:
  >
  > Why doesn't any of that work here?
  
  
  i'm afraid the "it works" is an illusion brought on by looking at content 
which doesn't show the issue... The main problem here is that we're dealing 
with user-generated content, and we can't assume that just because an image has 
a certain size, that space is actually filled with image data :/ F6790301: 
image.png 
  
  > Aesthetics-wise, I'm okay deleting the shadow, but I'm less thrilled about 
also deleting the frame surrounding the image. Without that, the images look 
naked in the view, like they're just floating there, disconnected from 
everything: F6788651: Screenshot_20190423_074053.png 

  
  Hmm... i guess we could put an outline around things, though which would be 
the question, and i don't have an answer to that... (i personally like the 
floating thing, though i realise that's just me liking the space, without 
having any particularly good explicitly defined reason for it)
  
  > Rewriting this in QML would be lovely (not in this patch though, 
obviously). I think we have a mockup of a new UI for it somewhere which I can't 
find right now but I'll try to dig it up.
  
  Thanks a bunch, just toss it at me when you've found it :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20748: Fix wrong "Unable to find service type" warnings

[David Faure]

dfaure updated this revision to Diff 56867.
dfaure added a comment.


  Improve unittest - which no longer prints a warning about example/servicetype

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20748?vs=56770=56867

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20748

AFFECTED FILES
  autotests/data/servicetypes/example-input.desktop
  autotests/data/servicetypes/example-servicetype.desktop
  autotests/kpluginmetadatatest.cpp
  src/lib/plugin/desktopfileparser.cpp
  src/lib/plugin/desktopfileparser_p.h

To: dfaure, mart, arichardson, davidedmundson, mpyne
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20697: Review IconBorder

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  loh.tar, can you take a look?
  If it is too complex to fix easily, we can still revert this and apply it 
again later together with a fix.
  Thanks for pointing the CI fail out David!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: dfaure, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[Christoph Cullmann]

cullmann added a comment.


  :( Sorry, I didn't run them again, just tried out if it works in KDevelop.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: dfaure, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[David Faure]

dfaure added a comment.


  This commit appears to have introduced a unittest regression
  
  FAIL!  : InlineNoteTest::testInlineNote() Compared values are not the same
  
Actual   (newCoordCol04): QPoint(51,1)
Expected (coordCol04)   : QPoint(33,1)
Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 
SUSEQt5.10/autotests/src/inlinenote_test.cpp(171)]
  
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.10/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/98/testReport/junit/projectroot/autotests/inlinenote_test/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: dfaure, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/99/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Apr 2019 06:58:35 +
 Build duration:
6 min 3 sec and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.58.0.xmllogs/KF5TextEditor/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)68%
(33238/48695)51%
(15886/31087)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4658/4998)49%
(1753/3606)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1711/1903)76%
(1215/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)60%
(1927/3207)48%
(1616/3349)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)78%
(973/1246)68%
(640/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
  

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/87/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Apr 2019 05:54:57 +
 Build duration:
2 min 53 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2541/5207)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/86/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 24 Apr 2019 05:54:57 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/81/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Apr 2019 05:54:57 +
 Build duration:
4 min 22 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2541/5207)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)