D20838: Allow to drop one file or one folder on KDirOperator

2019-05-05 Thread Méven Car 
meven updated this revision to Diff 57625.
meven added a comment.


  review feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57599=57625

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-05 Thread Méven Car 
meven marked 5 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ngraham wrote in kdiroperator.cpp:418
> Yep, I'd say so now.

Any idea where I should add this information ?
An example would suffice.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-05 Thread Aleix Pol Gonzalez 
apol added a comment.


  It could make sense to run clazy on these, I'm pretty sure we'd find 
interesting stuff.

INLINE COMMENTS

> koneandtwofingerswipe.h:36
> +{
> +//Q_PROPERTY(bool left READ left WRITE left)
> +//Q_PROPERTY(bool right READ right WRITE right)

Why is this commented out?

> koneandtwofingerswipe.h:50
> +private:
> +bool left;
> +bool right;

If classes are installed and exported they should have a d-pointer.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-05 Thread Stefan Brüns 
bruns added a comment.


  F6810948: Screenshot_20190506_000345.png 


REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21041

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21041: [Fstab] Use folder-decrypted icon for encrypting fuse mounts

2019-05-05 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Frameworks, ngraham, hallas.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When Vaults are mounted and show up in the mtab, use the matching icon.
  As these mounts are only visible in the decrypted state, use the
  folder-decrypted icon.

TEST PLAN
  Vault shows up with matching icon

REPOSITORY
  R245 Solid

BRANCH
  fstab_generic

REVISION DETAIL
  https://phabricator.kde.org/D21041

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

2019-05-05 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/28/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 05 May 2019 21:57:59 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D20995: [Fstab] Add support for non-network filesystems

2019-05-05 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:116c805ba461: [Fstab] Add support for non-network 
filesystems (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20995?vs=57478=57620

REVISION DETAIL
  https://phabricator.kde.org/D20995

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-05 Thread Nibaldo González 
nibags updated this revision to Diff 57618.
nibags added a comment.


  - Allow to select an item with a single click, regardless of the 
configuration of the system.
  
  I had forgotten that it's possible to change the settings for the 
click/double-click actions, now I correct it. 
  Then it looks like this:
  
  - Return/Enter or One-click: select an item and hide the menu.
  - Double-click: no action (that is, it acts as a single click).
  - Ctrl, Alt, Shift or Meta + Return: select an item without hiding the menu.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20958?vs=57561=57618

BRANCH
  new-mode-menu

REVISION DETAIL
  https://phabricator.kde.org/D20958

AFFECTED FILES
  src/CMakeLists.txt
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp
  src/view/katestatusbar.cpp
  src/view/kateview.h

To: nibags, #ktexteditor, #kate, #vdg, ngraham
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-05 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Still works great, and I have just a few code change requests. Then let's aim 
to land this early in the 5.59 cycle so it gets lots of testing.

INLINE COMMENTS

> meven wrote in kdiroperator.cpp:418
> Not sure I have done this correctly.

Yep, I'd say so now.

> kdiroperator.cpp:1404
> +
> +this->setFocus();
> +

`this->` not needed

> kdiroperator.cpp:1418
> +auto urlSetterClosure = [this, url](){
> +this->setCurrentItem(url);
> +QObject::disconnect(d->m_connection);

`this->` not needed

> kdiroperator.cpp:1423
> +} else {
> +this->setCurrentItem(url);
> +}

`this->` not needed

> kdiroperator.cpp:1558
>  
> +if (this->acceptDrops()) {
> +newView->setAcceptDrops(true);

`this->` not needed

> kfilewidgettest_gui.cpp:36
>  }
> -

Unnecessary whitespace change.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

2019-05-05 Thread Thomas Surrel 
thsurrel added a comment.


  It is still missing the '/' for me, but I am on the latest releases, not on 
master right now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D20995: [Fstab] Add support for non-network filesystems

2019-05-05 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Hmm yeah, feels like maybe it should happen in the Panel code to use the 
Product rather than the Description.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

2019-05-05 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Still needs the menu items to apply and close on single-click even when using 
the systemwide double-click mode. The option itself in System Settings Provides 
a clue regarding when it's appropriate to use double-click:
  
  > Double-click to open **files and folders** (single-click to select)
  
  This isn't a file or a folder. Single-clicking on a menu item should always 
choose that thing and close the menu.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg, ngraham
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D20995: [Fstab] Add support for non-network filesystems

2019-05-05 Thread Stefan Brüns 
bruns added a comment.


  In D20995#460439 , @ngraham wrote:
  
  > Nice! Can we make the Places panel display the product rather than the 
description? I don't think it's necessary to have the fs type listed there in 
the label. Interested parties can always look that up in the Properties dialog.
  
  
  The open question is if this should happen in solid or in the panel code ... 
I have no strong preference here.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

2019-05-05 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> pino wrote in kfilewidget.cpp:2804-2806
> why is this limited to the saving mode? you can perfectly use a mimetype 
> filter when opening files

When opening, the mimetype chooser still has filtering functionality and isn't 
a drop-down menu combobox like it is when saving. I couldn't come up with an 
adequate string to communicate both purposes and figured "Filter" was good 
enough.

REPOSITORY
  R241 KIO

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-05 Thread Nicolas Fella 
nicolasfella added a comment.


  The name "KTouch" is already used for 
https://kde.org/applications/education/ktouch/

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

2019-05-05 Thread Pino Toscano 
pino added inline comments.

INLINE COMMENTS

> kfilewidget.cpp:2804-2806
> +if (operationMode == KFileWidget::Saving && 
> filterWidget->isMimeFilter()) {
> +label = i18n(" type:");
> +whatsThisText = i18n("This is the file type selector. It is used 
> to select the format that the file will be saved as.");

why is this limited to the saving mode? you can perfectly use a mimetype filter 
when opening files

REPOSITORY
  R241 KIO

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: pino, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-05 Thread Nathaniel Graham 
ngraham added a reviewer: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

2019-05-05 Thread Nathaniel Graham 
ngraham added a comment.


  Yep, will do. Thanks!

REPOSITORY
  R241 KIO

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

2019-05-05 Thread Elvis Angelaccio 
elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  Please wait the tagging before pushing.

REPOSITORY
  R241 KIO

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

2019-05-05 Thread Stefan Brüns 
bruns added a comment.


  I think this is the wrong way round:
  
  man mount.cifs:
  
  > The mount.cifs utility attaches the UNC name (exported network resource) 
specified as service (using //server/share syntax, where "server" is the server 
name or IP address and "share" is the name of the share) to the local directory 
mount-point.
  
  man mount.nfs
  
  > remotetarget is a server share usually in the form of 
servername:/path/to/share.  dir is the directory on which the file system is to 
be mounted.
  
  In general, the "device" has no trailing slash. Apparently the kernel (or 
mount?) strips it for CIFS, but not for NFS.
  
  The correct approach, to avoid double entries in case the user has added a 
'/' to the device, is to compare the entries slash-insensitive.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20301

To: meven, bruns, lukas, broulik
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

2019-05-05 Thread Méven Car 
meven added a comment.


  What do you think @bruns  ?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20301

To: meven, bruns, lukas, broulik
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-05 Thread Méven Car 
meven updated this revision to Diff 57599.
meven added a comment.


  oops

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57597=57599

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-05 Thread Méven Car 
meven updated this revision to Diff 57597.
meven added a comment.


  Clean up test code

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57589=57597

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19420: Fix KCompressionDevice::atEnd() for uncompressed .gz files

2019-05-05 Thread Christoph Roick 
croick added a comment.


  In D19420#460766 , @apol wrote:
  
  > Looks good to me, have you checked that it's now not breaking what @broulik 
found?
  
  
  Yes, I tested loading systemsettings.svg 
(`/usr/share/icons/breeze/apps/48/systemsettings.svg`) by using #kate 
 and renaming the suffix to `.svgz`. 
With my previous commit 96083005e90e 
, 
the file would not be loaded entirely. Using this patch, all of the file is 
loaded.
  I don't compile plasma myself, so I didn't check whether the icons are 
displayed now. But the reason for not rendering the icons is gone.

REVISION DETAIL
  https://phabricator.kde.org/D19420

To: croick, broulik, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

2019-05-05 Thread Méven Car 
meven updated this revision to Diff 57589.
meven added a comment.


  Clean up and fix test

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57442=57589

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

2019-05-05 Thread Mélanie Chauvel 
achauvel added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  I opened a bug  but I didn’t 
have any answer so far.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10910

To: achauvel
Cc: kde-frameworks-devel, ngraham, michaelh, bruns, #frameworks

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-05 Thread Christoph Feck 
cfeck added a comment.


  Did you try to submit the additional gesture types to Qt? We should only add 
them here if they rejected the idea to add new types in Qt.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D21028

To: steffenh
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D21028: add multiple gestures and a handler class to KWidgetsAddons

2019-05-05 Thread Steffen Hartleib 
steffenh created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
steffenh requested review of this revision.

REVISION SUMMARY
  This patch adds the gestures and handler class from gwenview to 
KWidgetsAddons, so another program you can use this.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  rebasetomaster

REVISION DETAIL
  https://phabricator.kde.org/D21028

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ktouchautotest.cpp
  autotests/ktouchautotest.h
  src/CMakeLists.txt
  src/kdoubletap.cpp
  src/kdoubletap.h
  src/koneandtrwofingerswipe.cpp
  src/koneandtwofingerswipe.h
  src/konefingerpan.cpp
  src/konefingerpan.h
  src/ktapholdandmoving.cpp
  src/ktapholdandmoving.h
  src/ktouch.cpp
  src/ktouch.h
  src/ktouch_helper.h
  src/ktwofingerpan.cpp
  src/ktwofingerpan.h
  src/ktwofingertap.cpp
  src/ktwofingertap.h
  tests/CMakeLists.txt
  tests/ktouchtest.cpp

To: steffenh
Cc: kde-frameworks-devel, michaelh, ngraham, bruns