D22093: Don't show progress window for jobs that don't report progress

2019-06-25 Thread Aleix Pol Gonzalez 
apol added a comment.


  I think it's valuable information that the job is in progress. How about 
making the progress bar indeterminate?
  
  
https://doc.qt.io/qt-5/qml-qtquick-controls2-progressbar.html#indeterminate-prop

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D22093

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 110 - Fixed!

2019-06-25 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/110/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 25 Jun 2019 21:27:56 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 203 - Fixed!

2019-06-25 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/203/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 25 Jun 2019 21:27:56 +
 Build duration:
8 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 105 - Fixed!

2019-06-25 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/105/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 25 Jun 2019 21:27:56 +
 Build duration:
7 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.60.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2714/3480)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/293)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

2019-06-25 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/101/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Jun 2019 21:27:56 +
 Build duration:
4 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.60.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2713/3480)67%
(1802/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)91%
(706/772)59%
(407/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/293)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2019-06-25 Thread Nathaniel Graham 
ngraham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

2019-06-25 Thread Méven Car 
meven planned changes to this revision.
meven added a comment.


  I have started D22082  enrolling the plan 
set in the previous comment.
  
  Once this task has done enough progress and has landed some of its work, I 
will be able to revisit this diff.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, fbampaloukas, alexde, feverfew, michaelh, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22095: Fix CMake add_custom_command() paren highlighting

2019-06-25 Thread Steve Mokris 
smokris updated this revision to Diff 60669.
smokris added a comment.


  Updated cmake.xml + cmake.xml.tpl version number.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22095?vs=60662=60669

REVISION DETAIL
  https://phabricator.kde.org/D22095

AFFECTED FILES
  generators/cmake.xml.tpl
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref
  syntax/cmake.xml

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D22069: Localize long number strings

2019-06-25 Thread Safa Alfulaij 
safaalfulaij added a comment.


  This is great! Thanks!
  Same issue in here: https://phabricator.kde.org/D13219
  I'm not sure if this is the correct way of fixing it, but I think there isn't 
any other prvoided by Qt, other then `QLocale::toString`. Maybe it's the easy 
way here :)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: safaalfulaij, mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, 
LeGast00n, michaelh, ngraham, bruns

D22095: Fix CMake add_custom_command() paren highlighting

2019-06-25 Thread Christoph Cullmann 
cullmann added a comment.


  Ah, I missed: the version should be updated.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22095

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

D22095: Fix CMake add_custom_command() paren highlighting

2019-06-25 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable to me. Thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22095

To: smokris, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, 
domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 136 - Fixed!

2019-06-25 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/136/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 25 Jun 2019 18:38:59 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.60.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33243/48872)51%
(15754/31193)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4770/5063)49%
(1809/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/814)0%
(0/208)src.document100%
(4/4)100%
(4/4)61%
(1939/3183)50%
(1593/3209)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(949/1238)67%
(608/912)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 120 - Fixed!

2019-06-25 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/120/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Jun 2019 18:38:59 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.60.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33284/48868)51%
(15787/31189)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4770/5063)49%
(1809/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5472/5513)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/814)0%
(0/208)src.document100%
(4/4)100%
(4/4)61%
(1941/3183)50%
(1593/3209)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(949/1238)67%
(608/912)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%

D21861: Add default variables for variables interface

2019-06-25 Thread Christoph Cullmann 
cullmann added a comment.


  Ok, use now some self-defined env var with value set by the test itself, that 
should help on all operating systems.
  We don't need to check if HOME is ok.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

2019-06-25 Thread Christoph Cullmann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f58c2af9b4de: fix unit test for all operating systems 
(authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21861?vs=60614=60665#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21861?vs=60614=60665

REVISION DETAIL
  https://phabricator.kde.org/D21861

AFFECTED FILES
  autotests/src/variable_test.cpp

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D21861: Add default variables for variables interface

2019-06-25 Thread Christoph Cullmann 
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Actually my fix will only help for Unices, on Windows, this will still fail 
;=)
  Either we guard that for Windows or we check there more env vars.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21861

To: dhaumann, cullmann, gregormi
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D22095: Fix CMake add_custom_command() paren highlighting

2019-06-25 Thread Steve Mokris 
smokris added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22095

To: smokris, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D22095: Fix CMake add_custom_command() paren highlighting

2019-06-25 Thread Steve Mokris 
smokris created this revision.
smokris added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
smokris requested review of this revision.

REVISION SUMMARY
  The CMake syntax highlighter was getting confused by balanced
  parentheses in add_custom_command()'s COMMAND arguments.
  This patch turns on the 'nested-parentheses' flag for that
  command, enabling parentheses to be parsed correctly.

TEST PLAN
  Added a test in `autotests/input/highlight.cmake` and updated the 
corresponding reference output files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D22095

AFFECTED FILES
  generators/cmake.yaml
  html/highlight.cmake.html
  input/highlight.cmake
  reference/highlight.cmake.ref
  syntax/cmake.xml

To: smokris
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D22093: Don't show progress window for jobs that don't report progress

2019-06-25 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: apol, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Most plugins (all but the youtube one) don't report any progress in their 
jobs. This results in a window with an empty progress bar flashing for a few 
seconds. Let's hide the window by default and allow plugins to enable it.

TEST PLAN
  Shared stuff via imgur/telegram. No window appears. Share stuff via KDE 
Connect. Window disappears after selecting a device

REPOSITORY
  R495 Purpose Library

BRANCH
  noprogress

REVISION DETAIL
  https://phabricator.kde.org/D22093

AFFECTED FILES
  src/job.cpp
  src/job.h
  src/plugins/youtube/youtubejobcomposite.cpp
  src/quick/AlternativesView.qml
  src/quick/RunningJob.qml
  src/widgets/JobDialog.qml
  src/widgets/menu.cpp

To: nicolasfella, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22083: introduce concept of header and footer for kpageview

2019-06-25 Thread Christoph Feck 
cfeck added inline comments.

INLINE COMMENTS

> kpageview.cpp:458
> +
> +if (d->pageHeader == header) {
> +return;

This check is duplicated.

> kpageview.cpp:476
> +}
> +
> +}

Please remove this empty line.

> kpageview.h:163
> +/**
> + * Set a widget as the header for this Page view
> + * It will replace the standard page title

Does this transfer ownership of the widget? If yes, is ownership transferred 
back for any previously set widget? Or is it even automatically deleted? It 
needs to be clarified in the docs.

> kpageview_p.h:81
>  
> +QPointer  pageHeader;
> +QPointer  pageFooter;

No space before `<`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg
Cc: cfeck, ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22083: introduce concept of header and footer for kpageview

2019-06-25 Thread Nathaniel Graham 
ngraham added a subscriber: ndavis.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22083: introduce concept of header and footer for kpageview

2019-06-25 Thread Nathaniel Graham 
ngraham accepted this revision as: VDG.
ngraham added a comment.


  This seems to work quite well. For the remaining padding on the left, top, 
and bottom, does that come from Breeze, or would it need to be removed here? Or 
does it come from here and we should work around it in Breeze?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22083

To: mart, #plasma, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D10747: Implement zwp_linux_dmabuf_v1

2019-06-25 Thread Roman Gilg 
romangg edited the test plan for this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D10747

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D10747: Implement zwp_linux_dmabuf_v1

2019-06-25 Thread Roman Gilg 
romangg updated this revision to Diff 60654.
romangg added a comment.


  - D-pointer DmaBufBuffer
  - Only allow one create request in any case
  - Params in private interface class
  - typedef for LinuxDmabufUnstableV1Interface
  - Small cleanup
  - Set buffer privates and delete impl on interface destroy

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10747?vs=60429=60654

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10747

AFFECTED FILES
  src/client/protocols/linux-dmabuf-unstable-v1.xml
  src/server/CMakeLists.txt
  src/server/buffer_interface.cpp
  src/server/buffer_interface.h
  src/server/display.cpp
  src/server/display.h
  src/server/drm_fourcc.h
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, #plasma, graesslin, davidedmundson, mart, fredrik
Cc: kde-frameworks-devel, romangg, plasma-devel, LeGast00n, hannahk, jraleigh, 
sgureev, fbampaloukas, GB_2, ragreen, Pitel, schernikov, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, eliasp, sebas, apol, mart, hein

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

2019-06-25 Thread Nathaniel Graham 
ngraham added reviewers: ivan, broulik, Plasma, Frameworks.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22091

To: meven, ivan, broulik, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven updated this revision to Diff 60653.
meven added a comment.


  Add activity filtering

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60646=60653

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22091: Fix a crash in KactivityTestApp when Result has strings with non-ASCII

2019-06-25 Thread Méven Car 
meven created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22091

AFFECTED FILES
  tests/model/window.cpp

To: meven
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

2019-06-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

2019-06-25 Thread Nathaniel Graham 
ngraham marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  Abandoning in favor of D13048 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

2019-06-25 Thread Nathaniel Graham 
ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of D13048 

REVISION DETAIL
  https://phabricator.kde.org/D13083

To: ngraham, #frameworks, apol, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

2019-06-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
ngraham added reviewers: meven, apol, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik, meven, apol, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

2019-06-25 Thread Nathaniel Graham 
ngraham updated this revision to Diff 60649.
ngraham added a comment.


  - Don't stat non-local files
  - Reduce the size of the change
  - Still works

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13048?vs=34715=60649

REVISION DETAIL
  https://phabricator.kde.org/D13048

AFFECTED FILES
  src/core/global.cpp

To: ngraham, #frameworks, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13048: Move redundant logic in KIO::iconNameForUrl() into KFileItem::iconName()

2019-06-25 Thread Nathaniel Graham 
ngraham reclaimed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13048

To: ngraham, #frameworks, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven updated this revision to Diff 60646.
meven added a comment.


  Implement proper logging, add url filter parameter

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60633=60646

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham, ivan
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 100 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/100/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Jun 2019 14:10:36 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.60.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2714/3480)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/293)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 104 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/104/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 25 Jun 2019 14:10:36 +
 Build duration:
3 min 51 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.60.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2714/3480)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/293)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 109 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/109/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 25 Jun 2019 14:10:37 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 201 - Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/201/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 25 Jun 2019 14:00:06 +
 Build duration:
4 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 103 - Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/103/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 25 Jun 2019 14:00:05 +
 Build duration:
3 min 56 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.60.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2714/3480)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/293)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 99 - Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/99/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Jun 2019 14:00:05 +
 Build duration:
3 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5SyntaxHighlighting-5.60.0.xmlcompat_reports/KF5SyntaxHighlighting_compat_report.htmllogs/KF5SyntaxHighlighting/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)76%
(34/45)76%
(34/45)78%
(2714/3480)67%
(1803/2684)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests75%
(6/8)75%
(6/8)92%
(707/772)59%
(408/694)examples.codeeditor0%
(0/2)0%
(0/2)0%
(0/203)0%
(0/88)examples.codepdfprinter0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/6)src.cli0%
(0/1)0%
(0/1)0%
(0/85)0%
(0/28)src.indexer100%
(1/1)100%
(1/1)76%
(222/293)76%
(198/260)src.lib90%
(27/30)90%
(27/30)85%
(1785/2088)74%
(1197/1608)

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 108 - Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/108/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 25 Jun 2019 14:00:05 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.htmlhighlighter_testFailed: projectroot.autotests.testhighlighter_test

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven edited reviewers, added: ivan; removed: lunakl.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, ivan, lunakl
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, I do.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven added a subscriber: ivan.
meven added a comment.


  I have added you @ivan as you were the main author of KAcvitiesStat and might 
be interested in the review.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, lunakl
Cc: ivan, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 127 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/127/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 25 Jun 2019 10:33:33 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13389)18%
(1823/9907)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3501)28%
(793/2847)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2020)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven added a reviewer: lunakl.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22082

To: meven, #frameworks, ngraham, lunakl
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 120 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/120/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Jun 2019 10:33:32 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.60.0.xmlacc/KF5PlasmaQuick-5.60.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.60.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13389)18%
(1823/9907)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3501)28%
(793/2847)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1580)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2020)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%

D22073: [KCM GridDelegate] Silence warning

2019-06-25 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:94479bd7f3e2: [KCM GridDelegate] Silence warning 
(authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22073?vs=60585=60639

REVISION DETAIL
  https://phabricator.kde.org/D22073

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

2019-06-25 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:3df42d7f0eb6: [KCM GridDelegate] Take into account 
implicitCellHeight for inner delegate… (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22076?vs=60590=60638

REVISION DETAIL
  https://phabricator.kde.org/D22076

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: broulik, #plasma, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 130 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/130/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 25 Jun 2019 10:33:33 +
 Build duration:
4 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D22049: pluginloader: Change behavior of X-KDE-ParentApp

2019-06-25 Thread Bhushan Shah 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7ae271987ca2: pluginloader: Change behavior of 
X-KDE-ParentApp (authored by bshah).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22049?vs=60501=60636

REVISION DETAIL
  https://phabricator.kde.org/D22049

AFFECTED FILES
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h

To: bshah, mart, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22076: [KCM GridDelegate] Take into account implicitCellHeight for inner delegate height

2019-06-25 Thread Marco Martin 
mart accepted this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22076

To: broulik, #plasma, mart, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven updated this revision to Diff 60633.
meven added a comment.


  Allow to override default 30 results limit

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60631=60633

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

2019-06-25 Thread Chusslove Illich 
ilic added a comment.


  I'm not sure about what happens with global state, but at any rate, what I 
expected is that in klocalizedstringtest.cpp exactly one character is modified, 
replacing dot with comma in string " 4.20". Do you have fr_FR.utf8 glibc locale 
installed on your system?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns

D22082: WIP Add an ioslave to access KActivityStat data

2019-06-25 Thread Méven Car 
meven updated this revision to Diff 60631.
meven added a comment.


  Allow to filter mimetype with ?type=mimetype1[,mimetype2]

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22082?vs=60602=60631

BRANCH
  recents-docs-ioslave

REVISION DETAIL
  https://phabricator.kde.org/D22082

AFFECTED FILES
  src/CMakeLists.txt
  src/ioslave/CMakeLists.txt
  src/ioslave/recentdocumentsactivities.cpp
  src/ioslave/recentdocumentsactivities.h
  src/ioslave/recentdocumentsactivities.protocol

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 43 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/43/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 25 Jun 2019 09:02:39 +
 Build duration:
2 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 42 - Still Unstable!

2019-06-25 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/42/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 25 Jun 2019 09:00:58 +
 Build duration:
1 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D22081: [Fstab] Select appropriate icon for home or root directory

2019-06-25 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:541a3d3a0573: [Fstab] Select appropriate icon for home or 
root directory (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22081?vs=60601=60628

REVISION DETAIL
  https://phabricator.kde.org/D22081

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  @ilic As far as I can tell, the locale needs to be set again to french 
because it's in a new function. At the end of the function, it doesn't matter 
that English was set as the default locale because the next test won't be 
re-using that state; it will revert to the global state.
  
  If my understanding is incorrect, I'll need a bit more hand-holding to 
implement your requested changes.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

2019-06-25 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:54a501f00bbe: [Fstab] Show mounted overlay 
filesystems (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22080?vs=60600=60627

REVISION DETAIL
  https://phabricator.kde.org/D22080

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

2019-06-25 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  fstab_overlayfs

REVISION DETAIL
  https://phabricator.kde.org/D22081

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

2019-06-25 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Yep, looks good to me too.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D22080

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22049: pluginloader: Change behavior of X-KDE-ParentApp

2019-06-25 Thread Marco Martin 
mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22049

To: bshah, mart, apol
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

2019-06-25 Thread Kai Uwe Broulik 
broulik accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  fstab_overlayfs

REVISION DETAIL
  https://phabricator.kde.org/D22081

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

2019-06-25 Thread Kai Uwe Broulik 
broulik accepted this revision.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D22080

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

2019-06-25 Thread Chusslove Illich 
ilic added inline comments.

INLINE COMMENTS

> klocalizedstringtest.cpp:222
> +
> +QLocale::setDefault(QLocale(QLocale::French));
> +QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(),

The French locale is already being set in line 45 using setlocale, for which 
the system has to have fr_FR.utf8 glibc locale installed. Any further setting 
up of locale details, if needed, should happen in lines 70-76, which are 
currently commented out with "until locale system is ready" (and if not needed, 
this whole commented out part should be deleted).

> klocalizedstringtest.cpp:226
> +
> +QLocale::setDefault(QLocale(QLocale::English, QLocale::UnitedStates));
>  QCOMPARE(ki18n("%1").subs(4.2, 5, 'f', 2).toString(),

The tests work with French locale, there is no reason introduce English here 
only. It also clobbers the globaly set locale elements in initTestCase.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns

D22080: [Fstab] Show mounted "overlay" filesystems

2019-06-25 Thread Fabian Vogt 
fvogt accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D22080

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

2019-06-25 Thread Fabian Vogt 
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  With this and D22080  applied, there's an 
entry for / now:
  
  F6932935: Screenshot_20190625_092256.png 

  
  On a regular system, nothing seems to have changed, so the changes seem to be 
fine.

REPOSITORY
  R245 Solid

BRANCH
  fstab_overlayfs

REVISION DETAIL
  https://phabricator.kde.org/D22081

To: bruns, ngraham, fvogt, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22069: Localize long number strings

2019-06-25 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns

D22069: Localize long number strings

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks :)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: mikeroyal, aspotashev, ilic, kde-frameworks-devel, broulik, LeGast00n, 
michaelh, ngraham, bruns