KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Still Unstable!

2019-07-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/2/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 12 Jul 2019 05:48:30 +
 Build duration:
4 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.kformattestFailed: projectroot.autotests.kprocesslisttest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 51 - Failure!

2019-07-11 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/51/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 12 Jul 2019 05:49:26 +
 Build duration:
3 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 322 lines...][2019-07-12T05:51:39.587Z] Insert indices...[2019-07-12T05:51:39.587Z] Documentation successfully generated.[2019-07-12T05:51:39.587Z] [  5%] Built target KF5CoreAddons_QCH[2019-07-12T05:51:39.587Z] Scanning dependencies of target KF5CoreAddons[2019-07-12T05:51:39.587Z] [  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.o[2019-07-12T05:51:39.587Z] [  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/KF5CoreAddons_autogen/mocs_compilation.cpp.o[2019-07-12T05:51:39.587Z] [  6%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.o[2019-07-12T05:51:39.849Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/desktoptojson/desktoptojson.cpp: In member function ���int DesktopToJson::runMain()���:[2019-07-12T05:51:39.849Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/desktoptojson/desktoptojson.cpp:68:98: note: #pragma message: TODO: make it an error if one of the service type files is invalid or not found[2019-07-12T05:51:39.849Z]68 | #pragma message("TODO: make it an error if one of the service type files is invalid or not found")[2019-07-12T05:51:39.849Z]   |  ^[2019-07-12T05:51:39.849Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.o[2019-07-12T05:51:40.107Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.o[2019-07-12T05:51:40.107Z] In file included from /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/kaboutdata.cpp:27:[2019-07-12T05:51:40.107Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/plugin/kpluginmetadata.h:404:36: warning: extra ���;��� [-Wpedantic][2019-07-12T05:51:40.107Z]   404 | Q_DECLARE_METATYPE(KPluginMetaData);[2019-07-12T05:51:40.107Z]   |^[2019-07-12T05:51:40.107Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.o[2019-07-12T05:51:40.367Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.o[2019-07-12T05:51:40.628Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.o[2019-07-12T05:51:41.190Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/io/kdirwatch.cpp: In member function ���void KDirWatchPrivate::addWatch(KDirWatchPrivate::Entry*)���:[2019-07-12T05:51:41.190Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/io/kdirwatch.cpp:955:12: warning: enumeration value ���FAM��� not handled in switch [-Wswitch][2019-07-12T05:51:41.190Z]   955 | switch (preferredMethod) {[2019-07-12T05:51:41.190Z]   |^[2019-07-12T05:51:41.446Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/io/kdirwatch.cpp: In member function ���KDirWatch::Method KDirWatch::internalMethod() const���:[2019-07-12T05:51:41.446Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/io/kdirwatch.cpp:2015:12: warning: enumeration value ���FAM��� not handled in switch [-Wswitch][2019-07-12T05:51:41.446Z]  2015 | switch (d->m_preferredMethod) {[2019-07-12T05:51:41.446Z]   |^[2019-07-12T05:51:41.446Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.o[2019-07-12T05:51:41.446Z] [ 10%] Linking CXX executable ../../bin/desktoptojson[2019-07-12T05:51:41.446Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.o[2019-07-12T05:51:41.702Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.o[2019-07-12T05:51:41.702Z] [ 12%] Built target desktoptojson[2019-07-12T05:51:41.702Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.o[2019-07-12T05:51:41.962Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.o[2019-07-12T05:51:41.962Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.o[2019-07-12T05:51:42.220Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.o[2019-07-12T05:51:42.220Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/io/kbackup.cpp: In function ���bool KBackup::backupFile(const QString&, const QString&)���:[2019-07-12T05:51:42.220Z] /home/jenkins/workspace/Frameworks/kcoreaddons/kf5-qt5 SUSEQt5.12/src/lib/io/kbackup.cpp:40:54: note: #pragma message: KDE5 TODO: Remove KConfig correctly[2019-07-12T05:51:42.220Z]40 | #pragma message("KDE5 TODO: Remove

KDE CI: Frameworks » kcoreaddons » kf5-qt5 WindowsMSVCQt5.11 - Build # 90 - Failure!

2019-07-11 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20WindowsMSVCQt5.11/90/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 12 Jul 2019 05:49:30 +
 Build duration:
2 min 10 sec and counting
   CONSOLE OUTPUT
  [...truncated 312 lines...][2019-07-12T05:51:33.319Z] [  5%] Building CXX object src/desktoptojson/CMakeFiles/desktoptojson.dir/desktoptojson_autogen/mocs_compilation.cpp.obj[2019-07-12T05:51:33.319Z] main.cpp[2019-07-12T05:51:33.319Z] mocs_compilation.cpp[2019-07-12T05:51:33.588Z] Scanning dependencies of target ktexttohtmltest[2019-07-12T05:51:33.588Z] [  6%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/ktexttohtmltest.cpp.obj[2019-07-12T05:51:33.588Z] [  7%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/__/src/lib/text/ktexttohtml.cpp.obj[2019-07-12T05:51:33.588Z] [  7%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/ktexttohtmltest_autogen/mocs_compilation.cpp.obj[2019-07-12T05:51:33.588Z] ktexttohtmltest.cpp[2019-07-12T05:51:33.845Z] Scanning dependencies of target KF5CoreAddons[2019-07-12T05:51:34.417Z] desktoptojson.cpp[2019-07-12T05:51:34.417Z] TODO: make it an error if one of the service type files is invalid or not found[2019-07-12T05:51:34.417Z] desktopfileparser.cpp[2019-07-12T05:51:34.674Z] mocs_compilation.cpp[2019-07-12T05:51:34.931Z] [ 11%] Linking CXX executable ..\..\bin\desktoptojson.exe[2019-07-12T05:51:35.188Z] ktexttohtml.cpp[2019-07-12T05:51:35.753Z] [ 14%] Built target KF5CoreAddons_QCH[2019-07-12T05:51:35.753Z] [  7%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kaboutdata.cpp.obj[2019-07-12T05:51:35.753Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/kcoreaddons.cpp.obj[2019-07-12T05:51:35.753Z] [  8%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kautosavefile.cpp.obj[2019-07-12T05:51:35.753Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kdirwatch.cpp.obj[2019-07-12T05:51:35.753Z] kaboutdata.cpp[2019-07-12T05:51:35.753Z] [  9%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kfilesystemtype.cpp.obj[2019-07-12T05:51:35.753Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kmessage.cpp.obj[2019-07-12T05:51:35.753Z] [ 10%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kprocess.cpp.obj[2019-07-12T05:51:35.753Z] [ 11%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kbackup.cpp.obj[2019-07-12T05:51:35.753Z] kcoreaddons.cpp[2019-07-12T05:51:35.753Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/io/kurlmimedata.cpp.obj[2019-07-12T05:51:35.753Z] [ 12%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kcompositejob.cpp.obj[2019-07-12T05:51:35.753Z] kmessage.cpp[2019-07-12T05:51:35.753Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjob.cpp.obj[2019-07-12T05:51:35.753Z] kfilesystemtype.cpp[2019-07-12T05:51:35.753Z] [ 13%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobtrackerinterface.cpp.obj[2019-07-12T05:51:35.753Z] kautosavefile.cpp[2019-07-12T05:51:35.753Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/jobs/kjobuidelegate.cpp.obj[2019-07-12T05:51:35.753Z] [ 14%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginfactory.cpp.obj[2019-07-12T05:51:36.010Z] [ 14%] Built target desktoptojson[2019-07-12T05:51:36.010Z] kjobuidelegate.cpp[2019-07-12T05:51:36.010Z] kdirwatch.cpp[2019-07-12T05:51:36.010Z] kpluginfactory.cpp[2019-07-12T05:51:36.010Z] kprocess.cpp[2019-07-12T05:51:36.010Z] kbackup.cpp[2019-07-12T05:51:36.010Z] KDE5 TODO: Remove KConfig correctly[2019-07-12T05:51:36.010Z] kurlmimedata.cpp[2019-07-12T05:51:36.010Z] kcompositejob.cpp[2019-07-12T05:51:36.010Z] kjob.cpp[2019-07-12T05:51:36.010Z] kjobtrackerinterface.cpp[2019-07-12T05:51:36.010Z] [ 15%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginloader.cpp.obj[2019-07-12T05:51:36.010Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/kpluginmetadata.cpp.obj[2019-07-12T05:51:36.268Z] kpluginmetadata.cpp[2019-07-12T05:51:36.268Z] kpluginloader.cpp[2019-07-12T05:51:36.268Z] [ 16%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/plugin/desktopfileparser.cpp.obj[2019-07-12T05:51:36.527Z] [ 17%] Linking CXX executable ..\bin\ktexttohtmltest.exe[2019-07-12T05:51:36.527Z] desktopfileparser.cpp[2019-07-12T05:51:36.527Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandom.cpp.obj[2019-07-12T05:51:36.787Z] krandom.cpp[2019-07-12T05:51:37.045Z] [ 18%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/randomness/krandomsequence.cpp.obj[2019-07-12T05:51:37.045Z] [ 19%] Building CXX object src/lib/CMakeFiles/KF5CoreAddons.dir/text/kmacroexpander.cpp.obj[2019-07-12T05:51:37.045Z] krandomsequence.cpp[2019-07-12T05:51:37.045Z] kmacroexpander.cpp[2019-07-12T05:51:37.045Z] [ 19%] Building

D22339: Make sure solid backends are reentrant

2019-07-11 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D22339#494252 , @bruns wrote:
  
  > The invalidation has to be done per thread then as well, which you don't 
do. See fstabmanager.cpp
  
  
  As you can see in fstabmanager.cpp:40, FstabWatcher::instance() stays a 
singleton. It will notify about changes and each thread's backend will react to 
it accordingly.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-07-11 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck, apol
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-11 Thread Aleix Pol Gonzalez 
apol accepted this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham, apol
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-07-11 Thread Harald Sitter 
sitter updated this revision to Diff 61603.
sitter added a comment.


  get rid of need for decl_hidden and extend the test to play with visiblity

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22375?vs=61522=61603

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22375

AFFECTED FILES
  src/CMakeLists.txt
  src/kbusyindicatorwidget.cpp
  src/kbusyindicatorwidget.h
  tests/CMakeLists.txt
  tests/kbusyindicatorwidgettest.cpp

To: sitter, cfeck
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
michaelh, bruns

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-07-11 Thread Harald Sitter 
sitter added inline comments.

INLINE COMMENTS

> broulik wrote in kbusyindicatorwidget.cpp:62
> Is that legal in the C++ standard allowed by frameworks?

Well, it builds at least under c++11 which is what kf5 is compatible with.

According to this page 
 
it should be fine (assuming the caveats mentioned are exhaustive anyway).

> kossebau wrote in kbusyindicatorwidget.h:40
> Any chance of getting some samples how this class is supposed to be used?
> 
> Sounds one should show & hide the complete widget when needed? How to best 
> integrate in one's layout? As overlay?
> 
> BTW, the KDE HIG does not mention such a spinner. So the purpose from a KDE 
> developer following the HIG raises a question with me wearing my naive hat :)
> https://hig.kde.org/components/assistance/progress.html

I am not sure there is a generally useful code sample to give here. Certainly 
not a helpful one.

  auto indicator = KBusyIndicatorWidget(this);
  layout().addWidget(indicator);
  auto label = QLabel("Busy watering the folowers", this);
  layout().addWidget(this);

Maybe this, but then I am not convinced of its usefulessness. That's just how 
one would use any widget ^^

You could overlay it on something, or HBox it next to a label, or add it as 
permanent widget to a StatusBar, or VBox it with something. Sky's the limit 
really.

> broulik wrote in kbusyindicatorwidget.h:65
> I heard for good measure one should always re-implement the generic `event` 
> just in case

Do we have this document somewhere? That's the sort of thing that sounds like 
an urban myth someone started in the 90's ^^

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22375

To: sitter, cfeck
Cc: ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n, 
michaelh, bruns

D22339: Make sure solid backends are reentrant

2019-07-11 Thread Stefan Brüns 
bruns added a comment.


  In D22339#494149 , @apol wrote:
  
  > In D22339#494142 , @bruns wrote:
  >
  > > How do you guarantee *each thread local* copy now is connected to the 
right signals, i.e. the socket notifier for the mtab and inotify for fstab?
  >
  >
  > each backend will create things separately now, so it should work like it 
used to so far when there was just one thread involved.
  
  
  The invalidation has to be done per thread then as well, which you don't do. 
See fstabmanager.cpp

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-07-11 Thread Nathaniel Graham 
ngraham added reviewers: dfaure, cfeck.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck
Cc: mreeves, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

2019-07-11 Thread Nathaniel Graham 
ngraham added a comment.


  Ping :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21782: Add a warning dialog with details, continue, and cancel button

2019-07-11 Thread Nathaniel Graham 
ngraham added a comment.


  Can we get this in?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21782

To: chinmoyr, #vdg, #frameworks, dfaure, ngraham
Cc: mreeves, ngraham, GB_2, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-11 Thread Stefan Brüns 
bruns added a comment.


  In D21427#494010 , @poboiko wrote:
  
  > Ping!
  >
  > Apparently, it does fix bug 409257, which is pretty serious one (db 
corruption, after all).
  
  
  The DB corruption is already fixed in KF5.60.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20238: device: include reapplyConnection() in the interface

2019-07-11 Thread Jan Grulich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R282:2d5a66004425: device: include reapplyConnection() in the 
interface (authored by aleksanderm, committed by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20238?vs=55395=61585

REVISION DETAIL
  https://phabricator.kde.org/D20238

AFFECTED FILES
  src/device.cpp
  src/device.h

To: aleksanderm, jgrulich, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22339: Make sure solid backends are reentrant

2019-07-11 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D22339#494142 , @bruns wrote:
  
  > How do you guarantee *each thread local* copy now is connected to the right 
signals, i.e. the socket notifier for the mtab and inotify for fstab?
  
  
  each backend will create things separately now, so it should work like it 
used to so far when there was just one thread involved.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22339: Make sure solid backends are reentrant

2019-07-11 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  How do you guarantee *each thread local* copy now is connected to the right 
signals, i.e. the socket notifier for the mtab and inotify for fstab?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson, bruns
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Jan Grulich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R281:a3d262f58d2f: Allow updating default DBus timeout on 
every interface (authored by aleksanderm, committed by jgrulich).

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22395?vs=61582=61583

REVISION DETAIL
  https://phabricator.kde.org/D22395

AFFECTED FILES
  src/bearer.cpp
  src/bearer.h
  src/call.cpp
  src/call.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/sim.cpp
  src/sim.h
  src/sms.cpp
  src/sms.h

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  aleksander/dbus-timeout

REVISION DETAIL
  https://phabricator.kde.org/D22395

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado 
aleksanderm updated this revision to Diff 61582.
aleksanderm added a comment.


  Renamed methods and made the getter const.

REPOSITORY
  R281 ModemManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22395?vs=61580=61582

BRANCH
  aleksander/dbus-timeout

REVISION DETAIL
  https://phabricator.kde.org/D22395

AFFECTED FILES
  src/bearer.cpp
  src/bearer.h
  src/call.cpp
  src/call.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/sim.cpp
  src/sim.h
  src/sms.cpp
  src/sms.h

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Jan Grulich 
jgrulich added a comment.


  I think all the methods should be called timeout() and setTimeout(), you are 
not changing default timeout which will always be 25s if -1 is set as timeout 
value. Also the getters should be const methods.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D22395

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado 
aleksanderm added a comment.


  F7006291: test.cpp  attaching a tester 
program to exercise the new API in one of the interfaces.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D22395

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado 
aleksanderm created this revision.
aleksanderm added reviewers: Frameworks, jgrulich, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
aleksanderm requested review of this revision.

REVISION SUMMARY
  Some methods in the ModemManager API (e.g. network scan) may take
  longer to complete than the default DBus timeout configured for the
  QDBusAbstractInterface, which is 25s usually.
  
  Allow clients to update this default timeout on every interface.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  aleksander/dbus-timeout

REVISION DETAIL
  https://phabricator.kde.org/D22395

AFFECTED FILES
  src/bearer.cpp
  src/bearer.h
  src/call.cpp
  src/call.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/sim.cpp
  src/sim.h
  src/sms.cpp
  src/sms.h

To: aleksanderm, #frameworks, jgrulich, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

2019-07-11 Thread Nicolas Fella 
nicolasfella added inline comments.

INLINE COMMENTS

> brute4s99 wrote in CMakeLists.txt:38
> Update: nope. I think it's still use for the dbus interfaces. I confirmed by 
> ending the `dbus-daemon.exe` process by hand to see it. Turns out, dbus is 
> quite important for KDE Connect regardless of the OS. (:

But this is KNotifications, not KDE Connect. So we need DBus for KNotifications 
on Windows?

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21660

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21660: change audio dep logic wrt win32

2019-07-11 Thread Piyush Aggarwal 
brute4s99 added inline comments.

INLINE COMMENTS

> brute4s99 wrote in CMakeLists.txt:38
> I'm looking into the DBus problem, we currently use DBus for the system tray 
> icon on Windows. Once that is resolved, I should be able to completely remove 
> DBus from the Windows build

Update: nope. I think it's still use for the dbus interfaces. I confirmed by 
ending the `dbus-daemon.exe` process by hand to see it. Turns out, dbus is 
quite important for KDE Connect regardless of the OS. (:

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D21660

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D22339: Make sure solid backends are reentrant

2019-07-11 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22339

To: apol, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22392: [balooctl/baloo_file_extractor] Consolidate code that performs actual indexing

2019-07-11 Thread Igor Poboiko 
poboiko created this revision.
poboiko added reviewers: Baloo, bruns, ngraham.
Herald added projects: Frameworks, Baloo.
poboiko requested review of this revision.

REVISION SUMMARY
  The file contents can be indexed in two ways: either by `baloo_file_extractor`
  after being added to `ContentIndexngDB`, or by calling `balooctl index fname`.
  The code is duplicated, yet with slight difference, between two places.
  
  This patch introduces and `Indexer` class, which is shared between extractor
  and `balooctl`, and does all the necessary routine in a unified way.
  
  It also removes checks if the file is already inside `ContentIndexingDB` from
  `balooctl index` command, and performs indexing even if it is (removing it
  from `ContentIndexingDB` afterwards), which is useful for debugging 
extractors.
  
  Note that as it unifies behavior of `extractor` and `balooctl`, it also now
  explicitly forbids indexing of files that are excluded or has invalid
  mimetypes via `balooctl index`; which is useless anyways, because such files
  will be removed from the index by `IndexCleaner`.
  Now it prints "failed" message to the user in that case

TEST PLAN
  - It compiles.
  - `balooctl index fname` no longer tells useless "the file is already 
scheduled for indexing" message, reindexing file anyways.

REPOSITORY
  R293 Baloo

BRANCH
  indexer-consolidate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22392

AFFECTED FILES
  src/file/CMakeLists.txt
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/indexer.cpp
  src/file/indexer.h
  src/tools/balooctl/CMakeLists.txt
  src/tools/balooctl/indexer.cpp
  src/tools/balooctl/indexer.h
  src/tools/balooctl/main.cpp

To: poboiko, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-11 Thread Jonathan Marten 
marten added a comment.


  Confirmed that man:clang(1) now correctly displays the man page with no 
spurious numbers shown.  Would be happy to abandon this review request.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel, mkoller
Cc: ltoscano, kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, 
fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven, michaelh, spoorun, 
navarromorales, ZrenBot, firef, ngraham, andrebarros, bruns, himcesjf, 
emmanuelp, lesliezhai, ali-mohamed, mikesomov, jensreuterberg, abetts, sebas, 
apol, mart

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-11 Thread Igor Poboiko 
poboiko added a comment.


  Ping!
  
  Apparently, it does fix bug 409257, which is pretty serious one (db 
corruption, after all).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21427: Always skip trailing slashes in FilderedDirIterator

2019-07-11 Thread Igor Poboiko 
poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21427

To: poboiko, #frameworks, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams