D23688: Allow to customize attributes for KSyntaxHighligting themes

[Nibaldo González]

nibags retitled this revision from "Allow customizing theme attributes in 
KSyntaxHighligting themes" to "Allow to customize attributes for 
KSyntaxHighligting themes".

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23688

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23688: Allow customizing theme attributes in KSyntaxHighligting themes

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  The diff D23516  introduce a regression: 
it isn't possible to customize the bold, italic, underline and strikeout 
attributes from the settings (Settings > Configure Kate... > Fonts & Colors > 
Default Text Styles), for KSyntaxHighligting themes.
  
  By using `format.isValid()`, the attributes of the KSyntaxHighligting theme 
are being overwritten to the theme already applied by KTextEditor and to the 
theme customizations by the user.
  
  The `format.isValid()` verification is removed, only the attributes set in 
the syntax definition files are applied.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-attributes

REVISION DETAIL
  https://phabricator.kde.org/D23688

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: nibags, #ktexteditor, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D21760: Add KListOpenFiles::ListOpenFilesJob

[David Hallas]

hallas retitled this revision from "Add 
KListOpenFiles::listProcessesWithOpenFiles" to "Add 
KListOpenFiles::ListOpenFilesJob".
hallas edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in klistopenfilestest_unix.cpp:83
> I usually just use "/does/not/exist" as a path ;-)
> 
> This might actually be better because Windows has weird race conditions with 
> the filesystem stuff.

This test is unix only anyway so there shouldn't be any race conditions. But it 
might be a little more expressive to use "/does/not/exist" so I have changed it 
anyway ;)

> dfaure wrote in klistopenfiles.h:94
> KIO is designed like this for some reason, but I would just document the job 
> constructor and let people create the job with new, outside KIO.
> 
> That's e.g. what akonadi does.

Would it make sense to rename the ListOpenFilesJob class to simply Job? It is 
already inside a KListOpenFiles namespace so the current name seems a little 
long and duplicated? Do we have any general naming convention for these things?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas updated this revision to Diff 65284.
hallas marked 3 inline comments as done.
hallas added a comment.


  Review comments

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21760?vs=65237=65284

BRANCH
  add_list_processes_with_open_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21760

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klistopenfilestest_unix.cpp
  autotests/klistopenfilestest_unix.h
  autotests/klistopenfilestest_win.cpp
  autotests/klistopenfilestest_win.h
  src/lib/CMakeLists.txt
  src/lib/util/klistopenfiles.h
  src/lib/util/klistopenfiles_unix.cpp
  src/lib/util/klistopenfiles_win.cpp

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23667: Add == and != operators to KIO::UDSEntry

[Pino Toscano]

pino added a comment.


  Oh, and also please add tests for them in UDSEntryTest.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23667

To: meven, #frameworks
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

[Pino Toscano]

pino added a comment.


  Please move the implementations in the cpp file, otherwise it will be 
impossible to change/fix the implementation later on in a binary compatible way.
  
  Also:
  
  - both the operators ought to be const, since they do not mutate the object 
(and otherwise they cannot be used to compare const objects)
  - please fix the style in the declarations: `const UDSEntry& other` -> `const 
UDSEntry `

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23667

To: meven, #frameworks
Cc: pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23658: Make notification icons use outline style

[Nathaniel Graham]

ngraham added a comment.


  If you're going to change the clapper position, don't forget about 
`preferences-desktop-notification-bell`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23658

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham updated this revision to Diff 65283.
ngraham added a comment.


  Correct test and don't run it if it can't succeed

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22069?vs=60622=65283

BRANCH
  localized-long-number-strings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22069

AFFECTED FILES
  autotests/klocalizedstringtest.cpp
  src/klocalizedstring.cpp

To: ngraham, #localization, #frameworks, broulik
Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham marked 2 inline comments as done.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham added a comment.


  Thanks @aacid!

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik
Cc: aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D23667: Add == and != operators to KIO::UDSEntry

[Nathaniel Graham]

ngraham added a comment.


  I know it seems silly for such tiny functions, but can you follow the pattern 
and keep only the function definitions in the header file and move the actual 
logic into the .cpp file?

INLINE COMMENTS

> udsentry.h:118
> +/**
> + * Returns true if the entry contains the same data as other
> + * @since 5.62.0

as other -> as the other

> udsentry.h:119
> + * Returns true if the entry contains the same data as other
> + * @since 5.62.0
> + */

Just `5.62` (Frameworks don't have minor versions)

> udsentry.h:127
> +/**
> + * Returns true if the entry does not contain the same data as other
> + * @since 5.62.0

ditto

> udsentry.h:128
> + * Returns true if the entry does not contain the same data as other
> + * @since 5.62.0
> + */

ditto

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23667

To: meven, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23685: Make user-trash icons look like trashcans

[Nathaniel Graham]

ngraham added a comment.


  Yay real trashcans The appearance is definitely more appropriate compared 
to before. I really like it.
  
  However I'm afraid the visual recognizability of the full state compared to 
the empty state is worsened compared to the status quo:
  
  Empty: F7310762: Screenshot_20190902_184712.png 

  
  Full: F7310757: Screenshot_20190902_184510.png 

  
  Before, the red folder background made it instantly recognizable that the 
trash was full--even if this wasn't really an appropriate visual metaphor. I 
wonder if we could play with other effects to make the full state look more 
obvious at a glance. Ideas:
  
  - Tint the can red
  - Add more stuff overflowing from the top
  - Color the overflowing stuff red
  - Move the lid that's on the ground so that we're looking at it head-on 
rather than from the side
  - Make the trashcan itself get fat like the classic mac OS 6 trashcan: 
F7310775: Screenshot_20190902_185108.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23685

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22968: Make it possible to modify contacts

[Aleix Pol Gonzalez]

apol abandoned this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22968

To: apol, #frameworks, jbbgameich, bshah
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

[Aleix Pol Gonzalez]

apol added a comment.


  Committed as 
https://commits.kde.org/kpeople/7cf00a2cb27dcc11c8cd5b06423ce69c41537c82.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D22968

To: apol, #frameworks, jbbgameich, bshah
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/23/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Sep 2019 22:00:00 +
 Build duration:
3 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22510: Added dialog to set execute permission for executable file when trying to run it.

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in krun.cpp:147
> I wonder why this doesn't use isExecutable(mimetype)...

Hmm, because isExecutable(mimetype) also returns true for desktop files.

So this would change behaviour for users of this API. (see why we try to limit 
public API...).

Most users found in https://lxr.kde.org/ident?_i=isExecutableFile would 
actually see this as a bugfix (they warn about, or forbid, local execution), but
https://lxr.kde.org/source/extragear/utils/krusader/krusader/Panel/panelfunc.cpp
would try to run the desktop file with runCommand which uses KProcess, this 
will fail.

So... I was just wondering (and hinting at an investigation, not requesting a 
change), but I have my answer now..

I suggest to revert your last change, and maybe add a comment about why we 
can't use isExecutable. (Or we could extract a common function...)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

[Albert Astals Cid]

aacid added a comment.


  In D23119#519676 , @asemke wrote:
  
  > The original problem in LabPlot was reported by a windows user. The 
proposed fix won't fix the problem on windows. I think the only way to get the 
proper strings on Windows is to get the current language of the application, to 
create a QLocale with the proper language and to use QLocale::toString(const 
QDateTime , const QString )... If this is correct, then we're 
are back to my original question I asked on IRC/Matrix - how to determine the 
current application language?
  
  
  Are you saying that the old code actually half works on Windows?
  
  I find that surprising since it means that setting the LANGUAGE environment 
variable on Windows does things, which according to a quick internet search 
doesn't seem to be the case

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: yurchor, apol, kde-frameworks-devel, asemke, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  You're getting there.
  
  - 16px: needs 2px margins on the top and bottom
  - 22px: needs 3px margins on the top and bottom
  - 32px: needs to be lined up with the pixel grid and needs 2px margins on the 
top and bottom. You'd really be better off basing the background shape on 
another 32px icon and then applying the colors you want to use rather than 
trying to use a shrunken version of the the 64px background.
  
  In case you didn't see it before, there is an HIG and we recently improved 
the structure of the icon design section. 
https://hig.kde.org/style/icons/mimetype.html

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23685: Make user-trash icons look like trashcans

[Noah Davis]

ndavis updated this revision to Diff 65268.
ndavis added a comment.


  Add breeze dark icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23685?vs=65267=65268

BRANCH
  trash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23685

AFFECTED FILES
  icons-dark/places/32/user-trash-full.svg
  icons-dark/places/32/user-trash.svg
  icons-dark/places/64/user-trash-full.svg
  icons-dark/places/64/user-trash.svg
  icons/places/32/user-trash-full.svg
  icons/places/32/user-trash.svg
  icons/places/64/user-trash-full.svg
  icons/places/64/user-trash.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23685

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23685

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  BUG: 399613

REPOSITORY
  R266 Breeze Icons

BRANCH
  trash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23685

AFFECTED FILES
  icons/places/32/user-trash-full.svg
  icons/places/32/user-trash.svg
  icons/places/64/user-trash-full.svg
  icons/places/64/user-trash.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: Introduce cloning and replication of output devices

[Roman Gilg]

romangg added a dependent revision: D23684: WIP: Add presenting event to 
output-device protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: kpiwowarski, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23684: WIP: Add presenting event to output-device protocol

[Roman Gilg]

romangg retitled this revision from "Add presenting event to output-device 
protocol" to "WIP: Add presenting event to output-device protocol".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23684

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23684: WIP: Add presenting event to output-device protocol

[Roman Gilg]

romangg added a dependency: D23619: Introduce cloning and replication of output 
devices.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23684

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23684: Add presenting event to output-device protocol

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The idea for this event is to inform output managing clients about the current
  state of the output device in regards to it being part of the overall
  compositor space and presenting content or if the output is currently not for
  some reason.
  
  This helps in presenting a managable overview to clients and on state change
  reapply an optimal config.

TEST PLAN
  Compiles.

REPOSITORY
  R127 KWayland

BRANCH
  outputPresentingEvent

REVISION DETAIL
  https://phabricator.kde.org/D23684

AFFECTED FILES
  src/client/protocols/outputdevice.xml

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23661: Port away from Qt's foreach all loops over method-local containers

[Dominik Haumann]

dhaumann added a comment.


  Also did a review and it looks good to me, thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23661

To: kossebau, #kate, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski marked 6 inline comments as done.
mdlubakowski added a comment.


  Fixed according to comments, hope I haven't forget anything this time.
  Sorry for the API change, I thought it may make sense to add it like this 
since `isExecutableFile` and `isExecutable` are a part of it.
  I also added showing the errorString from `setExecuteBit` to 
`makeServiceExecutable`, since it used similar dialog to `KRun::runUrl`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski updated this revision to Diff 65265.
mdlubakowski added a comment.


  - Incorporated feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22510?vs=65260=65265

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

AFFECTED FILES
  src/widgets/krun.cpp

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D23464

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23464: Add breeze icons for ROOT cern files

[Alex Debus]

alexde updated this revision to Diff 65264.
alexde edited the test plan for this revision.
alexde added a comment.


  Remove all circles and only use root symbol.
  This makes the root symbol less faint and the icons fit better to Breeze 
overall.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23464?vs=64946=65264

BRANCH
  ROOT (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23464

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-root.svg
  icons-dark/mimetypes/22/application-x-root.svg
  icons-dark/mimetypes/32/application-x-root.svg
  icons-dark/mimetypes/64/application-x-root.svg
  icons/mimetypes/16/application-x-root.svg
  icons/mimetypes/22/application-x-root.svg
  icons/mimetypes/32/application-x-root.svg
  icons/mimetypes/64/application-x-root.svg

To: alexde, #vdg, ndavis, ngraham
Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> containmentactions.h:70
>   * including name, pluginName and icon
> - * @since 5.0
> + * @since 5.0 use metadata
>   */

@deprecated since 5.62 use metadata

> dataengine.cpp:70
>  : QObject(parent),
> -  d(new DataEnginePrivate(this, KPluginInfo(args), args))
> +  d(new DataEnginePrivate(this, KPluginInfo(args).toMetaData(), args))
>  {

Where is this constructor used?

> dataengine.h:80
> +
> +explicit DataEngine(const KPluginMetaData , QObject *parent = 
> nullptr);
>  

Docs, with `@since`

> dataengine.h:112
> + *
> + * @since 4.62
>   */

5

> dataenginescript.cpp:91
>  
>  KPluginInfo DataEngineScript::description() const
>  {

Does this need a `KPluginMetadata` getter?

> theme.cpp:444
>  
>  KPluginInfo Theme::pluginInfo() const
>  {

Does this need a separate `metadata()` getter?

> theme.h:321
>   * name, description, author, website etc
> - * @since 5.0
> + * @since 5.0 use KPluginMetaData
> + */

Separate `@deprecated since` line

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: Introduce cloning and replication of output devices

[Roman Gilg]

romangg updated this revision to Diff 65263.
romangg marked 2 inline comments as done.
romangg added a comment.


  - Fix enum ordering, typo. Thx @kpiwowarski.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23619?vs=65118=65263

BRANCH
  clone

REVISION DETAIL
  https://phabricator.kde.org/D23619

AFFECTED FILES
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: romangg, #kwin
Cc: kpiwowarski, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[David Faure]

dfaure added a comment.


  Pino is right, I hadn't noticed that you added it as API.
  
  Yes please make the requested changes, we'll land it when it's perfect :-)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

Re: Proposing Quick Charts as a new framework

[Luigi Toscano]

Arjen Hiemstra ha scritto:
> Hi,
> 
> I have been working on a library the past few months that provides a QtQuick
> module for rendering gpu-accelerated charts. It currently lives in a 
> playground
> repository, here: https://invent.kde.org/kde/kf5quickcharts . I would like for
> this library to be included as a Tier 1 Framework.

Hi,
I've noticed that some time ago (I didn't enable the translations yet, but
maybe it's not needed). I have a question and a comment:

- what is the difference between this one and the existing kqtquickcharts,
part of the KDE Applications bundle, from the KDEEdu project? At least their
description overlaps. Is there any transition path? Having two duplicate
libraries with the exact same goal may not be the best scenario.
- I don't think that "5" should be part of the name; in two years from now we
may have a Frameworks 6, and having a kf5quickchart as part of it may be
confusing.

Ciao
-- 
Luigi

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski added a comment.


  Thanks for your guidance!
  I don't have developer account, so can't land myself.
  Should I fix those two other comments before landing?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> krun.cpp:164
>  
> +bool KRun::hasExecuteBit(const QString )
> +{

please make this function as file static, so there is no need to expose it as 
API of the KRun class

> krun.cpp:310
> +// Helper function that attempts to set execute bit for given file.
> +static bool setExecuteBit(const QString )
> +{

maybe this function could return the error string on failure as out parameter, 
so ...

> krun.cpp:372
> +window,
> +i18n("Unable to make file %1 
> executable!", u.toLocalFile())
> +);

... here this dialog can show the error to the user

(also, please drop the exclamation mark from the message)

> krun.cpp:1439
>  }
> +
>  if (!KRun::runUrl(d->m_strURL, type, d->m_window, runFlags, 
> d->m_suggestedFileName, d->m_asn)) {

extra empty line

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

Proposing Quick Charts as a new framework

[Arjen Hiemstra]

Hi,

I have been working on a library the past few months that provides a 
QtQuick
module for rendering gpu-accelerated charts. It currently lives in a 
playground
repository, here: https://invent.kde.org/kde/kf5quickcharts . I would 
like for

this library to be included as a Tier 1 Framework.

Current features are that it supports rendering of three different chart 
types:
pie, line and bar, which can be fed from multiple types of data sources. 
There
is also support for axis labels, an axis grid and a legend. 
Additionally, there

is a submodule that contains some convenience items.

The pie and line charts are rendered using a technique called signed 
distance
fields, which allows efficient GPU-accelerated rendering of 2D shapes 
without

loss of quality.

I would like to hear what people think about it and if this is something 
others

would also like to have included in Frameworks.

- Arjen

D22510: Added dialog to set execute permission for executable file when trying to run it.

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the changes. Looks ok to me now, despite some more nitpicks ;)
  Do you have a developer account to submit this?

INLINE COMMENTS

> krun.cpp:147
>  QMimeDatabase db;
>  QMimeType mimeType = db.mimeTypeForName(mimetype);
>  if (!mimeType.inherits(QStringLiteral("application/x-executable"))

I wonder why this doesn't use isExecutable(mimetype)...

> krun.cpp:167
> +QFileInfo file(fileName);
> +if (!file.isExecutable()) {
> +return false;

This could now be simplified to `return file.isExecutable();`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23682: Make use of KPluginMetaData where we can

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead of relying on the older KPluginInfo which is slower (parses de 
metadata twice) and comes from a much higher tier.

TEST PLAN
  Running plasmashell with it

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

AFFECTED FILES
  src/plasma/containment.cpp
  src/plasma/containmentactions.cpp
  src/plasma/containmentactions.h
  src/plasma/dataengine.cpp
  src/plasma/dataengine.h
  src/plasma/private/dataengine_p.h
  src/plasma/private/storage.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/scripting/dataenginescript.cpp
  src/plasma/theme.cpp
  src/plasma/theme.h

To: apol, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski updated this revision to Diff 65260.
mdlubakowski added a comment.


  - Removed leftover kfileitem.h include

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22510?vs=65258=65260

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski marked 6 inline comments as done.
mdlubakowski added a comment.


  Reversed my changes to `isExecutableFile` method as per D23660 
, since my changes aren't needed anymore. 
Also added `hasExecuteBit` method.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski updated this revision to Diff 65258.
mdlubakowski added a comment.


  - Reverse change to KRun::isExeutableFile
  - Incorporated feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22510?vs=64930=65258

BRANCH
  arcpatch-D22510

REVISION DETAIL
  https://phabricator.kde.org/D22510

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23670: [KPropertiesDialog] Always check mount point being null

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3b571aacf7e9: [KPropertiesDialog] Always check mount 
point being null (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23670?vs=65223=65254

REVISION DETAIL
  https://phabricator.kde.org/D23670

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: broulik, #frameworks, dfaure, shubham
Cc: PureTryOut, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23670: [KPropertiesDialog] Always check mount point being null

[Bart Ribbers]

PureTryOut added a comment.


  I tested this patch as a fix for https://bugs.kde.org/show_bug.cgi?id=411517 
and it did the trick, it doesn't crash anymore.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23670

To: broulik, #frameworks, dfaure, shubham
Cc: PureTryOut, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23660: [KRun] Check mime type for isExecutableFile first

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9b12a872da35: [KRun] Check mime type for isExecutableFile 
first (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23660?vs=65206=65241

REVISION DETAIL
  https://phabricator.kde.org/D23660

AFFECTED FILES
  src/widgets/krun.cpp

To: broulik, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23660: [KRun] Check mime type for isExecutableFile first

[Kai Uwe Broulik]

broulik added a comment.


  > will still be used by isPromptNeeded, so this can go in.
  
  Speaking of which, that prompt check should be done after the mimetypejob has 
finished, not casually blocking everything in synchronous mime type 
determination beforehand :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23660

To: broulik, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Nice job. Final comments.

INLINE COMMENTS

> klistopenfilestest_unix.cpp:51
> +QCOMPARE(processInfoAvailableSpy.at(0).at(0).value(), 
> path.path());
> +KProcessList::KProcessInfoList processInfoList = 
> processInfoAvailableSpy.at(0).at(1).value();
> +QVERIFY(!processInfoList.empty());

prepend `const` so begin/end below don't detach

> klistopenfilestest_unix.cpp:83
> +QTemporaryDir tempDir;
> +tempDir.remove();
> +auto job = KListOpenFiles::listProcessesWithOpenFiles(tempDir.path());

I usually just use "/does/not/exist" as a path ;-)

This might actually be better because Windows has weird race conditions with 
the filesystem stuff.

> klistopenfiles.h:94
> + */
> +KCOREADDONS_EXPORT ListOpenFilesJob *listProcessesWithOpenFiles(const 
> QString );
> +

KIO is designed like this for some reason, but I would just document the job 
constructor and let people create the job with new, outside KIO.

That's e.g. what akonadi does.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas added a comment.


  I have added a minimal Windows implementation which always emits an error, 
along with a unit test. Please review it thoroughly and then I think it is 
ready to land :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Hallas]

hallas updated this revision to Diff 65237.
hallas marked 2 inline comments as done.
hallas added a comment.


  Review comments. Added minimal Windows implementation which basically always 
reports failure with the error code Unsupported.

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21760?vs=64973=65237

BRANCH
  add_list_processes_with_open_files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21760

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/klistopenfilestest_unix.cpp
  autotests/klistopenfilestest_unix.h
  autotests/klistopenfilestest_win.cpp
  autotests/klistopenfilestest_win.h
  src/lib/CMakeLists.txt
  src/lib/util/klistopenfiles.h
  src/lib/util/klistopenfiles_unix.cpp
  src/lib/util/klistopenfiles_win.cpp

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 65236.
leinir added a comment.


  - Make sure to import the right version of newstuff

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=65219=65236

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[David Faure]

dfaure added a comment.


  In D22144#520773 , @meven wrote:
  
  > This "magic" precisely is what I would have wished to find, it seemed to me 
something other ioslaves might want, to have contextual log or error message at 
least.
  >  The pid of the calling application could be a minimum.
  
  
  This can be done: http://www.davidfaure.fr/2019/app_pid.diff works for me, 
feel free to use it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, 
kfm-devel, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> normalvimode.cpp:3848
>  } else {
> -cAfter.setColumn(textLines.last().length() - 0);
> -cAfter.setLine(cAfter.line() + textLines.length() - 1);
> +const int lastLineLength = pastedText.size() - 
> pastedText.lastIndexOf(QLatin1Char('\n')) + 1;
> +cAfter.setColumn(lastLineLength);

oh I see, how about just using splitRef? This way we don't have to allocate all 
the strings but the code still is more readable.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23674

To: kossebau, #kate
Cc: apol, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23664: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23664

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23660: [KRun] Check mime type for isExecutableFile first

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Makes sense.
  In D22510  I actually suggested splitting 
this method into two, but the all-in-one method will still be used by 
isPromptNeeded, so this can go in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23660

To: broulik, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krun.cpp:186
> +protected:
> +void showEvent(QShowEvent *e) override
> +{

_pre-existing) this code will also be triggered when switching virtual 
desktops, and we don't want a resize then. So this should test for 
`e->spontaneous()` and return early if true.

> krun.cpp:218
> +m_textEdit->setSizePolicy(QSizePolicy::Expanding, 
> QSizePolicy::Minimum);
> +updateGeometry();
> +}

Is this line necessary? (I wouldn't think so)

> krun.cpp:288
> +{
> +QFile desktopFile(fileName);
> +

rename to `file` now that it's used for both

> krun.cpp:337
> +bool canRun = true;
> +bool isFileExecutable = isExecutableFile(u, _mimetype);
> +

At this point checking the mimetype again is redundant, it was done on line 
328. I guess we need a simple QFileInfo::isExecutable call or wrapper.

> mdlubakowski wrote in krun.cpp:1105
> isExecutableFile will return false if the file doesn't have +x bit, which 
> will result in prompt not being show, so I dont think this should be removed.

Ah. Hmm. I see. This code is confusing.
isFileExecutable will then be true for a non-+x desktop file.

But other than the naming, it makes sense, this code is actually about the 
edit-or-execute prompt for +x scripts and (any) desktop files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23661: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2ee34748cdb8: Port away from Qts foreach all loops 
over method-local containers (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23661?vs=65207=65234

REVISION DETAIL
  https://phabricator.kde.org/D23661

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/emulatedcommandbar.cpp
  src/buffer/katetextbuffer.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionwidget.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/export/exporter.cpp
  src/mode/katemodemanager.cpp
  src/printing/printpainter.cpp
  src/schema/kateschemaconfig.cpp
  src/script/katescriptaction.cpp
  src/spellcheck/ontheflycheck.cpp
  src/syntax/katehighlight.cpp
  src/utils/katesedcmd.cpp
  src/utils/katetemplatehandler.cpp
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/vimode/appcommands.cpp
  src/vimode/commandrangeexpressionparser.cpp
  src/vimode/config/configtab.cpp
  src/vimode/emulatedcommandbar/commandmode.cpp
  src/vimode/emulatedcommandbar/emulatedcommandbar.cpp
  src/vimode/emulatedcommandbar/searchmode.cpp
  src/vimode/keyparser.cpp
  src/vimode/macros.cpp
  src/vimode/modes/modebase.cpp
  src/vimode/searcher.cpp

To: kossebau, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I admit that I never understood why this was using KConfig. I guess Waldo had 
a hammer and everything looked like nails ;-)

INLINE COMMENTS

> slavebase.cpp:191
> +delete configGroup;
> +delete config;
>  }

missing `config = nullptr` so the `delete config` in the destructor doesn't 
crash.

Same with configGroup.

> slavebase.cpp:411
>  
> +QMap ::mapConfig() const
> +{

That is a weird abuse of const. If the member wasn't in a d pointer, this 
wouldn't compile.

If the slave is supposed to only read from the map, then it should be a value 
or const ref.
If the slave can write into the map, then this method shouldn't conceptually be 
`const`.

> slavebase.h:342
> + * relevant for the current protocol and host.
> + */
> +QMap () const;

missing @since

> slavebase.h:353
> + * TODO KF6: remove
> + * @deprecated use mapConfig(StatSide side)
>   */

@deprecated since 5.xx

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23661: Port away from Qt's foreach all loops over method-local containers

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks ok for me, thanks for taking care.

REPOSITORY
  R39 KTextEditor

BRANCH
  plainporttorangeloop

REVISION DETAIL
  https://phabricator.kde.org/D23661

To: kossebau, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D23625: Use QString::count(QChar) over QString::split().length() - 1

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in normalvimode.cpp:3844
> Ah, no, textLines.last().length() needs the string section, so just a plain 
> count would not be enough, only if combining with a QString::section call 
> later, I now remember.
> And some other patch simply turned this into splitRef, so just one alloc here 
> currently.
> 
> So rather something where I messed up during patch juggling.
> 
> Perhaps still can be µ-optimized with using lastindexof instead :)

Given we talked about it and my brain has created an item, D23674 
 is to get rid of it again :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23625

To: kossebau, #kate, cullmann
Cc: apol, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  GIT_SILENT

REPOSITORY
  R39 KTextEditor

BRANCH
  morecountoversplit

REVISION DETAIL
  https://phabricator.kde.org/D23674

AFFECTED FILES
  src/vimode/modes/normalvimode.cpp

To: kossebau, #kate
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23625: Use QString::count(QChar) over QString::split().length() - 1

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in normalvimode.cpp:3844
> Guess the complete change missed to enter the commit, and review did not 
> catch it,
> Well spotted, I shall do a follow-up.

Ah, no, textLines.last().length() needs the string section, so just a plain 
count would not be enough, only if combining with a QString::section call 
later, I now remember.
And some other patch simply turned this into splitRef, so just one alloc here 
currently.

So rather something where I messed up during patch juggling.

Perhaps still can be µ-optimized with using lastindexof instead :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23625

To: kossebau, #kate, cullmann
Cc: apol, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23670: [KPropertiesDialog] Always check mount point being null

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23670

To: broulik, #frameworks, dfaure, shubham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23625: Use QString::count(QChar) over QString::split().length() - 1

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> apol wrote in normalvimode.cpp:3844
> you didn't port this one to count?

Guess the complete change missed to enter the commit, and review did not catch 
it,
Well spotted, I shall do a follow-up.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23625

To: kossebau, #kate, cullmann
Cc: apol, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23625: Use QString::count(QChar) over QString::split().length() - 1

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> normalvimode.cpp:3844
>  KTextEditor::Cursor cAfter = pasteLocation;
> -const QStringList textLines = pastedText.split(QStringLiteral("\n"));
> +const QStringList textLines = pastedText.split(QLatin1Char('\n'));
>  if (textLines.length() == 1) {

you didn't port this one to count?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23625

To: kossebau, #kate, cullmann
Cc: apol, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23619: Introduce cloning and replication of output devices

[Kamil Piwowarski]

kpiwowarski added inline comments.

INLINE COMMENTS

> outputdevice.xml:318
> + +summary="change due to hotplug of involved devices"/>
> +

It's not the same ;)

  None= 0,
  Explicit= 1 << 0,
  Hotplug = 1 << 1,
  Dpms= 1 << 2,
  Enablement  = 1 << 3

> outputdevice.xml:330
> + +summary="property switched into up state"/>
> +

> down

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: kpiwowarski, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23670: [KPropertiesDialog] Always check mount point being null

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure, shubham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  File type got added after the fact and outside the guard.
  
  BUG: 411517

TEST PLAN
  - Set mp to null, didn't crash anymore

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23670

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: broulik, #frameworks, dfaure, shubham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 23 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/23/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 02 Sep 2019 10:17:30 +
 Build duration:
18 min and counting

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/21/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Sep 2019 10:15:11 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/22/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 01 Sep 2019 02:57:57 +
 Build duration:
1 day 7 hr and counting
   CONSOLE OUTPUT
  [...truncated 593 lines...][2019-09-01T03:01:45.708Z] [  3%] Generating index.cache.bz2[2019-09-01T03:01:45.708Z] [  3%] Generating src/KF5KIO.qch, src/KF5KIO.tags[2019-09-01T03:01:45.708Z] [  4%] Automatic MOC for target protocoltojson[2019-09-01T03:01:45.708Z] [  4%] Automatic MOC for target KF5KIONTLM[2019-09-01T03:01:45.708Z] [  4%] Automatic MOC for target kded_kcookiejar[2019-09-01T03:01:45.708Z] Scanning dependencies of target kcookiejar5_autogen[2019-09-01T03:01:45.708Z] [  3%] Built target copy_protocols[2019-09-01T03:01:45.708Z] Scanning dependencies of target ktelnetservice5_autogen[2019-09-01T03:01:45.708Z] [  4%] Built target KF5KIONTLM_autogen[2019-09-01T03:01:45.708Z] [  5%] Automatic MOC for target kcookiejar5[2019-09-01T03:01:45.975Z] [  5%] Built target protocoltojson_autogen[2019-09-01T03:01:45.975Z] [  5%] Automatic MOC for target ktelnetservice5[2019-09-01T03:01:45.975Z] Scanning dependencies of target httpheadertokenizetest_autogen[2019-09-01T03:01:45.975Z] [  5%] Built target kcookiejar5_autogen[2019-09-01T03:01:45.975Z] Scanning dependencies of target httpfiltertest_autogen[2019-09-01T03:01:45.975Z] [  5%] Built target ktelnetservice5_autogen[2019-09-01T03:01:45.975Z] [  5%] Automatic MOC for target httpheadertokenizetest[2019-09-01T03:01:45.975Z] [  5%] Automatic MOC for target httpfiltertest[2019-09-01T03:01:46.258Z] Scanning dependencies of target httpheaderdispositiontest_autogen[2019-09-01T03:01:46.259Z] [  5%] Automatic MOC for target httpheaderdispositiontest[2019-09-01T03:01:46.259Z] [  5%] Built target docs-kcontrol5-netpref-index-cache-bz2[2019-09-01T03:01:46.259Z] Scanning dependencies of target KF5KIOCore_autogen[2019-09-01T03:01:46.259Z] [  5%] Built target docs-kcontrol5-proxy-index-cache-bz2[2019-09-01T03:01:46.259Z] [  5%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2[2019-09-01T03:01:46.259Z] [  5%] Built target docs-kcontrol5-trash-index-cache-bz2[2019-09-01T03:01:46.259Z] [  5%] Automatic MOC for target KF5KIOCore[2019-09-01T03:01:46.259Z] [  5%] Built target docs-kcontrol5-smb-index-cache-bz2[2019-09-01T03:01:46.259Z] [  5%] Generating org.kde.KCookieServer.xml[2019-09-01T03:01:46.523Z] [  5%] Built target docs-kcontrol5-useragent-index-cache-bz2[2019-09-01T03:01:46.523Z] [  5%] Built target httpheadertokenizetest_autogen[2019-09-01T03:01:46.523Z] [  5%] Built target httpheaderdispositiontest_autogen[2019-09-01T03:01:46.787Z] Scanning dependencies of target KF5KIONTLM[2019-09-01T03:01:47.063Z] [  5%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.obj[2019-09-01T03:01:47.063Z] [  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/des.cpp.obj[2019-09-01T03:01:47.063Z] [  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_autogen/mocs_compilation.cpp.obj[2019-09-01T03:01:47.063Z] kntlm.cpp[2019-09-01T03:01:47.063Z] Scanning dependencies of target protocoltojson[2019-09-01T03:01:47.063Z] Scanning dependencies of target ktelnetservice5[2019-09-01T03:01:47.063Z] [  6%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.obj[2019-09-01T03:01:47.063Z] main.cpp[2019-09-01T03:01:47.327Z] [  6%] Built target kded_kcookiejar_autogen[2019-09-01T03:01:47.327Z] [  6%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.obj[2019-09-01T03:01:47.327Z] [  6%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.obj[2019-09-01T03:01:47.327Z] ktelnetservice.cpp[2019-09-01T03:01:47.327Z] mocs_compilation.cpp[2019-09-01T03:01:47.327Z] [  6%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice5_autogen/mocs_compilation.cpp.obj[2019-09-01T03:01:47.327Z] mocs_compilation.cpp[2019-09-01T03:01:47.327Z] mocs_compilation.cpp[2019-09-01T03:01:48.272Z] [  6%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h[2019-09-01T03:01:48.272Z] qdbusxml2cpp: Cannot process input: 'C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.[2019-09-01T03:01:48.272Z] jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.13\build\src\ioslaves\http\kcookiejar\CMakeFiles\kded_kcookiejar.dir\build.make [src\ioslaves\http\kcookiejar\kcookieserveradaptor.cpp] Error 1[2019-09-01T03:01:48.272Z] des.cpp[2019-09-01T03:01:48.544Z] [  6%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[2019-09-01T03:01:48.808Z] [  6%] Linking CXX shared library ..\..\bin\KF5KIONTLM.dll[2019-09-01T03:01:48.808Z] Scanning dependencies of target httpheaderdispositiontest[2019-09-01T03:01:48.808Z] Scanning dependencies of target 

D13867: [KMessageWidget] Pass widget to standardIcon()

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:dbee23dd939b: [KMessageWidget] Pass widget to 
standardIcon() (authored by broulik).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13867?vs=61989=65220

REVISION DETAIL
  https://phabricator.kde.org/D13867

AFFECTED FILES
  src/kmessagewidget.cpp

To: broulik, #frameworks, cfeck, ngraham, dhaumann
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 65219.
leinir added a comment.


  - Whole lot of @since-ing
  - Adopt Qt-style KF5-version-aligned import versioning

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21721?vs=64986=65219

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  CMakeLists.txt
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/author.cpp
  src/core/author.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/author.cpp
  src/qtquick/author.h
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/commentsmodel.cpp
  src/qtquick/commentsmodel.h
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DialogContent.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/QuestionAsker.qml
  src/qtquick/qml/private/ConditionalLoader.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/EntryScreenshots.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/Shadow.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra
Cc: ahiemstra, anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D23667: Add == and != operators to KIO::UDSEntry

[Méven Car]

meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  I felt it was missing.

TEST PLAN
  Compiles

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23667

AFFECTED FILES
  src/core/udsentry.cpp
  src/core/udsentry.h

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: Introduce cloning and replication of output devices

[Roman Gilg]

romangg added a dependent revision: D23665: [platforms/drm] Support output 
replication.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23664: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The simple porting, as those containers are not shared with anyone,
  so the removal of the container copying has no risks
  
  GIT_SILENT

REPOSITORY
  R263 KXmlGui

BRANCH
  plainporttorangeloop

REVISION DETAIL
  https://phabricator.kde.org/D23664

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  src/kedittoolbar.cpp
  src/kkeysequencewidget.cpp
  src/kmainwindow.cpp
  src/kmainwindowiface.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutseditor.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguifactory.cpp
  src/kxmlguiversionhandler.cpp

To: kossebau, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23619: Introduce cloning and replication of output devices

[Roman Gilg]

romangg added a dependent revision: D23662: Wayland: Support output replication.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Méven Car]

meven added a comment.


  D23578  is the next step, but it is not 
in great shape.
  To do things properly, it will require quite some changes I fear.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:d9cb570cbef4: Add property lastScanTime and 
lastRequestTime to WirelessDevice (authored by meven).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23576?vs=65208=65210

REVISION DETAIL
  https://phabricator.kde.org/D23576

AFFECTED FILES
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.cpp
  src/wirelessdevice.h
  src/wirelessdevice_p.h

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich accepted this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23661: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

kossebau added a comment.


  There are quite a lot of foreachs in ktexteditor, so IMHO it makes sense to 
split up the porting in multiple commits, so in case of regressions one can 
bisect in the overall changes a bit and then has fewer changes to reason about 
where something might have been broken.
  So my plan for further commits is:
  
  - one commit where method-local copies would be made explicit ,where 
currently they are done implicitly in the foreach() by some call -> minimal 
risk, as not shared
  - commits where new structures are generated by iterating shared containers, 
without method calls which might modify the containers potentially
  - commits per classes/submodules where each change needs careful review, as 
recursive non-const calls happen

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23661

To: kossebau, #kate
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Méven Car]

meven updated this revision to Diff 65208.
meven added a comment.


  Add a ref to the returned date

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23576?vs=65204=65208

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

AFFECTED FILES
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.cpp
  src/wirelessdevice.h
  src/wirelessdevice_p.h

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23661: Port away from Qt's foreach all loops over method-local containers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The simple porting, as those containers are not shared with anyone,
  so the removal of the container copying has no risks

REPOSITORY
  R39 KTextEditor

BRANCH
  plainporttorangeloop

REVISION DETAIL
  https://phabricator.kde.org/D23661

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/emulatedcommandbar.cpp
  src/buffer/katetextbuffer.cpp
  src/completion/katecompletionmodel.cpp
  src/completion/katecompletionwidget.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/export/exporter.cpp
  src/mode/katemodemanager.cpp
  src/printing/printpainter.cpp
  src/schema/kateschemaconfig.cpp
  src/script/katescriptaction.cpp
  src/spellcheck/ontheflycheck.cpp
  src/syntax/katehighlight.cpp
  src/utils/katesedcmd.cpp
  src/utils/katetemplatehandler.cpp
  src/view/kateview.cpp
  src/view/kateviewhelpers.cpp
  src/view/kateviewinternal.cpp
  src/vimode/appcommands.cpp
  src/vimode/commandrangeexpressionparser.cpp
  src/vimode/config/configtab.cpp
  src/vimode/emulatedcommandbar/commandmode.cpp
  src/vimode/emulatedcommandbar/emulatedcommandbar.cpp
  src/vimode/emulatedcommandbar/searchmode.cpp
  src/vimode/keyparser.cpp
  src/vimode/macros.cpp
  src/vimode/modes/modebase.cpp
  src/vimode/searcher.cpp

To: kossebau, #kate
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Sorry, I missed that last one. Once it's fixed it's ready to go.

INLINE COMMENTS

> wirelessdevice.h:232
> + */
> +void lastScanChanged(const QDateTime timestamp);
>  

const QDateTime 

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/48/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Sep 2019 08:31:39 +
 Build duration:
7 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23660: [KRun] Check mime type for isExecutableFile first

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: dfaure, meven.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The mime type is passed into the function, so it's already known. Checking 
mime type inheritance then is quick.
  This avoids accessing the file in `QFileInfo::isExecutable()` potentially 
blocking just to then realize it's none of the mime types we care about.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23660

AFFECTED FILES
  src/widgets/krun.cpp

To: broulik, dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Méven Car]

meven updated this revision to Diff 65204.
meven marked an inline comment as done.
meven added a comment.


  Review, remove incorrect doc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23576?vs=65002=65204

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23576

AFFECTED FILES
  src/utils.cpp
  src/utils.h
  src/wirelessdevice.cpp
  src/wirelessdevice.h
  src/wirelessdevice_p.h

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23650: Add an icon for the trash root and a proper label

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a9f8aeb11776: Add an icon for the trash root and a proper 
label (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23650?vs=65144=65205

REVISION DETAIL
  https://phabricator.kde.org/D23650

AFFECTED FILES
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/trashimpl.cpp

To: meven, ngraham, #frameworks, broulik
Cc: Codezela, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23576: Add property lastScanTime and lastRequestTime to WirelessDevice

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> utils.h:86
> +
> +QDateTime clockBootTimeToQDateTime(const qlonglong );
>  }

1. Missing NETWORKMANAGERQT_EXPORT
2. I would remove 'Q' from the name → clockBootTimeToDateTime
3. just qlonglong clockBoottime, no const and &

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D23576

To: meven, jgrulich
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23650: Add an icon for the trash root and a proper label

[Méven Car]

meven added a comment.


  In D23650#524092 , @Codezela wrote:
  
  > Why trash icon don't look like trash
  >  Like any other os
  
  
  This is not related to this patch. Open a design bug if you'd like.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23650

To: meven, ngraham, #frameworks, broulik
Cc: Codezela, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23650: Add an icon for the trash root and a proper label

[Hazem Salem]

Codezela added a comment.


  Why trash icon don't look like trash
  Like any other os

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23650

To: meven, ngraham, #frameworks, broulik
Cc: Codezela, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23650: Add an icon for the trash root and a proper label

[Méven Car]

meven added a reviewer: broulik.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23650

To: meven, ngraham, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven marked 3 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> broulik wrote in slavebase.cpp:281
> This is initialized automatically like this

That's on purpose, the first use of mapConfig is in rebuildConfig and is a 
clear() call.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven updated this revision to Diff 65200.
meven marked an inline comment as done.
meven added a comment.


  Review feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23523?vs=65006=65200

BRANCH
  arcpatch-D23523_1

REVISION DETAIL
  https://phabricator.kde.org/D23523

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65199.
meven added a comment.


  arc amend

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65198=65199

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65198.
meven added a comment.


  Better variable naming

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65197=65198

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65197.
meven added a comment.


  Add recentlyused:/ entry to Recent group to existing users

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65191=65197

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov