D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, in that case just add a `// TODO: remove this in KF6` comment.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1
  
  In D23851#529463 , @ngraham wrote:
  
  > If the on;y thing that `EmptyTrashJob::slotFinished()` does now is call 
`SimpleJob::slotFinished()`, do we even still need to override the base class's 
implementation of `slotFinished()`?
  
  
  Yeah we don't, but we can't remove it because it would be a BIC.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23851

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

[Albert Astals Cid]

aacid added a comment.


  In D23894#530619 , @dfaure wrote:
  
  > Not that QML code will get any warning for using a deprecated property 
though...
  
  
  Maybe something we can suggest for KF6 to add a DEPRECATED to properties?
  
  Anyhow this looks good to me, not a very kdeclartive knowledgeable person so 
maybe wait for the others to accept :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23894

To: dfaure, mart, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Sep 2019 17:04:10 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham added reviewers: cfeck, pino.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham, cfeck, pino
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw updated this revision to Diff 66003.
mthw added a comment.


  Don't move the commented-out code, better description in header, formatting.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=65988=66003

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/25/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 13 Sep 2019 15:51:09 +
 Build duration:
3 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.62.0.xmllogs/KF5WindowSystem/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)76%
(7265/9597)55%
(3521/6351)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3078/3164)53%
(1292/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(826/1380)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3354/4695)60%
(1925/3197)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

D23930: Set XCB to required if building the X backend

[Allen Winter]

winterz added a comment.


  +1
  will fix the problem I reported.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D23930

To: davidedmundson, zzag
Cc: winterz, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:aaacf7d5c206: Set XCB to required if building the X 
backend (authored by davidedmundson).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23930?vs=65999=66002

REVISION DETAIL
  https://phabricator.kde.org/D23930

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23930

To: davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23930: Set XCB to required if building the X backend

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Otherwise builds could fail on missing dependencies at build time,
  rather than configure time.
  
  This was previously broken, but my extra dependency on XCB::Res made it
  noticable.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23930

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven updated this revision to Diff 65991.
meven added a comment.


  Update @deprecated message to be more clear

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23523?vs=65931=65991

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:240
> +continue;
> +} else {
> +// deviceName will or won't end with / depending if device ended 
> with one

No need to put this in `.. else {` after `continue`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21795: [KAuth] Add support for action details in Polkit1 backend.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  polkit-qt-1-0.113.0 has been released, so I believe now we can move over with 
this patch.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R311:ef7ec39e9be1: Port from KIconLoader to QIcon::fromTheme 
(authored by vkrause).

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23899?vs=65985=65990

REVISION DETAIL
  https://phabricator.kde.org/D23899

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/kbetterthankdialog.cpp
  src/runtime/kwalletd/kwalletd.cpp
  src/runtime/kwalletd/kwalletwizard.cpp
  tests/kwalletd/CMakeLists.txt

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw updated this revision to Diff 65988.
mthw added a comment.


  Changes made, if clause still not there

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=65986=65988

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham added a comment.


  More or less! A new things:
  
  1. Don't forget to add the function definition for 
`KPropertiesDialog::insertPluginAt(KPropertiesDialogPlugin *plugin, int index)` 
to the header file
  2. Revert the change where you moved that section; it's now unnecessary
  3. Instead of unconditionally doing `q->insertPluginAt(plugin, 1);`, you'd 
want to do something more like this:
  
  
  
if (plugin == "details"  /* this is pseudocode */) {
q->insertPluginAt(plugin, 1);
} else {
q->insertPlugin(plugin);
}
  
  I'm actually not sure how to check for what the plugin is though. Maybe 
someone from #frameworks  can help.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw added a comment.


  I didn't know what to do with this
  
  > ...check to see if the plugin we've just created is the Details plugin,...
  
  Also the "Generator" should probably go back where it was right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23899: Port from KIconLoader to QIcon::fromTheme

[David Faure]

dfaure added a comment.


  You can land it as soon as the underlying API changes are in. KF5 is treated 
like a single repo in terms of inter-framework dependencies.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23899

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23899

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> dhaumann wrote in ktitlewidget.h:45
> Could you also fix the documentation here? This is typically copy & pasted 
> later ;)

Sorry, race condition on the push :) Will do that in a separate commit.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23896: [KDeclarative] Port away from deprecated QQuickWindow::sendEvent

[David Faure]

dfaure closed this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23896

To: dfaure, mart, davidedmundson, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw updated this revision to Diff 65986.
mthw added a comment.


  Do you mean something like this? Only a wild guess, C lang is not my strength.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23926?vs=65977=65986

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23899: Port from KIconLoader to QIcon::fromTheme

[Volker Krause]

vkrause updated this revision to Diff 65985.
vkrause added a comment.


  Adapt to widgetaddons changes.
  When can this land considering it depends on brand new API in another 
framework?

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23899?vs=65920=65985

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23899

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/kbetterthankdialog.cpp
  src/runtime/kwalletd/kwalletd.cpp
  src/runtime/kwalletd/kwalletwizard.cpp
  tests/kwalletd/CMakeLists.txt

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21695: Add FindTaglib.cmake

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in FindTaglib.cmake:84
> ( this searches for it both ways, so it's unclear what the include dir 
> will be --- with or without taglib at the end?)

BTW since then it was determined that applications should use , so you 
should NOT search for taglib/tag.h

> dfaure wrote in FindTaglib.cmake:94
> ... and this then adds another /taglib/ to the path.
> 
> I've always had that problem with taglib. It's not clear to me if the C/C++ 
> code should use #include  or #include  and therefore 
> it's not clear whether the include path should contain the /taglib subdir or 
> not.

In light of the above, this should be ${Taglib_INCLUDE_DIRS}/taglib.h

(though it's weird to use a plural form variable in such a way; there should 
probably be a singular form variable in this file, and then the plural one 
exported for users)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21695

To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure
Cc: ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, GB_2, bencreasy, 
michaelh, bruns

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

[David Faure]

dfaure updated this revision to Diff 65984.
dfaure added a comment.


  Add deltaY property (good idea).
  
  Not that QML code will get any warning for using a deprecated property 
though...

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23894?vs=65899=65984

BRANCH
  qwheelevent

REVISION DETAIL
  https://phabricator.kde.org/D23894

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h

To: dfaure, mart, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21695: Add FindTaglib.cmake

[Nathaniel Graham]

ngraham added a comment.


  Can we move forward on this?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21695

To: heikobecker, kde-buildsystem, kde-frameworks-devel, dfaure
Cc: ngraham, elvisangelaccio, cgiboudeaux, dfaure, LeGast00n, GB_2, bencreasy, 
michaelh, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[David Faure]

dfaure added a comment.


  Yes, I see the "see" :-)
  But that's just a generic way to say "also look at these other methods", it 
doesn't constitute a clear statement like "use B instead of A".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

[Elvis Angelaccio]

elvisangelaccio added a comment.


  LGTM besides the inline nitpicks.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:686
>  KBookmark device = root.first(); // The device we'll move is the 6th 
> bookmark
> -for (int i = 0; i < 5; i++) {
> +int stop = m_hasRecentlyUsedKio ? 7 : 5;
> +for (int i = 0; i < stop; i++) {

`const`, and maybe a more descriptive name (`count` or similar?)

> kfileplacesmodeltest.cpp:967
>  // places
> -QTest::newRow("Places - Home") << m_places->index(0, 0)
> +int idx = 0;
> +QTest::newRow("Places - Home") << m_places->index(idx++, 0)

I'd avoid cryptic names. If we can't use `index`, maybe just `i`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23927: Improve naming of KTitleWidget icon methods

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> ktitlewidget.h:45
>  titleWidget->setText(i18n("Title"));
>  titleWidget->setPixmap(QIcon::fromTheme("screen").pixmap(22, 22));
>   * @endcode

Could you also fix the documentation here? This is typically copy & pasted 
later ;)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:10753c73409d: Improve naming of KTitleWidget icon methods 
(authored by vkrause).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23927?vs=65979=65983

REVISION DETAIL
  https://phabricator.kde.org/D23927

AFFECTED FILES
  src/ktitlewidget.cpp
  src/ktitlewidget.h

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23927

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  +1 for the general idea. However this implementation only incidentally does 
what you want it to do. I apologize for steering you this way in the bug 
report, because it looks a bit more complicated than I thought, and we may have 
to puzzle through a more complex change.
  
  So right now, the ordering goes like this:
  
  - General tab
  - Permissions tab
  - Checksums tab
  - Auto-generated tabs that depend on the context (of which Details is one)
  
  So if we just move the auto-generated section to the second position, we 
can't actually guarantee that Details always comes first in that list.
  
  What you could maybe do is add a new function 
`KPropertiesDialog::insertPluginAt()` that takes an int value `index` and 
inserts the plugin at that position in the index with 
`d->m_pageList.insert(index, plugin);`, then around line 628, check to see if 
the plugin we've just created is the Details plugin, and use the new function 
to specifically insert it at index 1 (which is position 2 since we start 
counting from zero).
  
  Does that sound like a plan? I'll be happy to help you through it!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg, ngraham
Cc: ngraham, GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, 
fprice, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, 
Codezela, feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, 
ndavis, navarromorales, firef, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65981.
meven added a comment.


  Update since version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65980=65981

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

[Nathaniel Graham]

ngraham added a comment.


  Please do! It's already accepted. :)

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Méven Car]

meven updated this revision to Diff 65980.
meven added a comment.


  add recentlyused:/ bookmarks only in plasma, update following D23742 
 changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=65602=65980

BRANCH
  arcpatch-D7446

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23927: Improve naming of KTitleWidget icon methods

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  As suggested by David in D23899 .

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23927

AFFECTED FILES
  src/ktitlewidget.cpp
  src/ktitlewidget.h

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23904: Add QIcon setters for the password dialogs

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:001335535dae: Add QIcon setters for the password dialogs 
(authored by vkrause).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23904?vs=65966=65978

REVISION DETAIL
  https://phabricator.kde.org/D23904

AFFECTED FILES
  src/knewpassworddialog.cpp
  src/knewpassworddialog.h
  src/kpassworddialog.cpp
  src/kpassworddialog.h
  src/kpassworddialog.ui

To: vkrause, dfaure
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in slavebase.h:353
> Can you update the docu as suggested above, to point more clearly to the 
> replacement? This makes things easier for people doing porting. Thanks.

I have a `@see mapConfig` on the line below, did you see ? Or do you mean I 
should have all this on the same line.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added a comment.


  +1
  Next time please also add VDG as a subsriber and reviewer if there is a UI 
related change :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg
Cc: GB_2, #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, Codezela, 
feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, 
navarromorales, firef, ngraham, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23926: Move "Details" tab to second place in Properties dialog

[Björn Feber]

GB_2 added reviewers: Frameworks, VDG.
GB_2 added a project: VDG.
GB_2 added subscribers: Frameworks, Dolphin, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin, #frameworks, #vdg
Cc: #vdg, #dolphin, #frameworks, kde-frameworks-devel, iasensio, fprice, 
LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, 
feverfew, trickyricky26, mglb, meven, michaelh, crozbo, spoorun, ndavis, 
navarromorales, firef, ngraham, andrebarros, bruns, skadinna, emmanuelp, 
mikesomov, aaronhoneycutt, mbohlender

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dfaure wrote in slavebase.h:353
>   @deprecated since 5.63, use mapConfig() instead.

Can you update the docu as suggested above, to point more clearly to the 
replacement? This makes things easier for people doing porting. Thanks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw edited the summary of this revision.
mthw added a reviewer: Dolphin.
mthw added a project: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23926

To: mthw, #dolphin
Cc: kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23926: Move "Details" tab to second place in Properties dialog

[Matej Mrenica]

mthw created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mthw requested review of this revision.

REVISION SUMMARY
  This change moves the "Details" tab to second place because it makes more 
sense. //more later

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23926

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: mthw
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23713: strongswan support for custom proposals

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:9d88ac7082cf: strongswan support for custom proposals 
(authored by rrichmond, committed by aacid).
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23713?vs=65799=65969#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23713?vs=65799=65969

REVISION DETAIL
  https://phabricator.kde.org/D23713

AFFECTED FILES
  vpn/strongswan/nm-strongswan-service.h
  vpn/strongswan/strongswanprop.ui
  vpn/strongswan/strongswanwidget.cpp

To: rrichmond, fvogt, jgrulich
Cc: plasma-devel, pino, kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, michaelh, ZrenBot, ngraham, 
bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D23904: Add QIcon setters for the password dialogs

[Volker Krause]

vkrause updated this revision to Diff 65966.
vkrause added a comment.


  Fix typos.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23904?vs=65948=65966

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23904

AFFECTED FILES
  src/knewpassworddialog.cpp
  src/knewpassworddialog.h
  src/kpassworddialog.cpp
  src/kpassworddialog.h
  src/kpassworddialog.ui

To: vkrause, dfaure
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23915: Add some docstrings

[Roman Gilg]

romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> zzag wrote in dpms.h:44
> Not sure that this is valid documentation for org_kde_kwin_dpms_manager 
> because it's nothing more but a factory.

Yea, maybe just write that this class is meant to create the DPMS object below 
only. You already have the information you provided here there then.

> zzag wrote in dpms_interface.h:38-41
> While it's sort of true, I don't think it's valid description. The line above 
> precisely describes what DpmsManagerInterface is.

Not sure why it should not be valid. Maybe add that the code interaction 
//server-side// happens only via the OutputInterface. Because client-side in 
KWayland the respective Dpms class provides the API.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23811: [KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  The test fails here because the autotests/read/hdr/rgb.png file is 0 bytes, 
but if that is a phabricator artifact and it's really not a 0 bytes size, go 
ahead and commit :)

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D23811

To: cfeck, #frameworks, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, tommo, GB_2, clintmoyer, tdarboux, 
huoni, michaelh, muhlenpfordt, rkflx, ngraham, bruns

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

[Albert Astals Cid]

aacid added a comment.


  maybe add the angleX property so we can tell people to move from angle to 
angleX and in KF6 we can remove angle and all is nice?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23894

To: dfaure, mart, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23896: [KDeclarative] Port away from deprecated QQuickWindow::sendEvent

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  quickwindow_sendevent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23896

To: dfaure, mart, davidedmundson, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

[Méven Car]

meven marked 2 inline comments as done.
meven added a comment.


  I will land this soonish if no one has any objections.

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

[Méven Car]

meven updated this revision to Diff 65959.
meven added a comment.


  Allow users to use ?type filter with /files path

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65597=65959

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

[David Faure]

dfaure added a comment.


  @broulik, do you want to rebase and update this merge request, to add the 
missing fallback to "application-octet-stream" fallback to QIcon::fromTheme() 
calls?
  
  This change request is very much in line with other work being done in T11637 
.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15451

To: broulik, #frameworks, dfaure, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Beautiful :-)

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23899

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/82/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Sep 2019 08:24:26 +
 Build duration:
9 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D23915: Add some docstrings

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> dpms.h:44
>   *
> + * Display Power Management Signaling allows power management for monitors.
> + *

Not sure that this is valid documentation for org_kde_kwin_dpms_manager because 
it's nothing more but a factory.

> dpms_interface.h:38-41
> + * Display Power Management Signaling allows power management for monitors.
> + * A DpmsManagerInterface allows a client to query the DPMS state
> + * on a given OutputInterface and request changes to it.
> + * The code interaction happens only via the OutputInterface.

While it's sort of true, I don't think it's valid description. The line above 
precisely describes what DpmsManagerInterface is.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23904: Add QIcon setters for the password dialogs

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> knewpassworddialog.h:97
> +/**
> + * Sets the icon that appears next to the prompt in the dialog.  The 
> default icon represent a simple key.
> + * @since 5.63

typo: `represents`

> knewpassworddialog.h:103
> +/**
> + * Returns the icon that appears next to the prompt in the dialog.  The 
> default icon represent a simple key.
> + * @since 5.63

same

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23904

To: vkrause, dfaure
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Méven Car]

meven updated this revision to Diff 65955.
meven added a comment.


  Rebase on master, review feedback

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21204?vs=62027=65955

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23920: Deprecate the KSslError::Error ctor of KSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23920

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23920: Deprecate the KSslError::Error ctor of KSslError

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This encourages to use the QSslError ctor, which has no loss of information
  and will be straightforward to port to QSslError entirely eventually.
  
  There's one more user left in KIO, that requires a resolution of the human
  readable error string question in T11620 .

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23920

AFFECTED FILES
  src/core/ktcpsocket.cpp
  src/core/ktcpsocket.h
  src/core/tcpslavebase.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/70/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 13 Sep 2019 07:28:19 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23919: Make KSslError hold a QSslError internally

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1a70d5f0e4ec: Make KSslError hold a QSslError internally 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23919?vs=65950=65952

REVISION DETAIL
  https://phabricator.kde.org/D23919

AFFECTED FILES
  src/core/ktcpsocket.cpp

To: vkrause, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns