D24355: TypeScript: update grammar and fixes

2019-10-01 Thread Nibaldo González 
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  TypeScript:
  
  - Add asserts: https://github.com/microsoft/TypeScript/pull/32695
  - Highlight types after `as` expression.
  - Add type helpers: 
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-5.html#the-omit-helper-type
  
  TypeScript React (TSX):
  
  - When `https://github.com/microsoft/TypeScript-TmLanguage/commit/11b1a4f8dc3a3eaa4df71e8cc1ad6f01a688961d
  
  JavaScript React (JSX):
  
  - Use non-capture groups in RegExpr rules.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-01 Thread Nibaldo González 
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Using `WordDetect` rules for Tags causes them not to be highlighted after 
text. This only affects the folding of some tags.
  I also used non-capture groups in RegExpr rules.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-delimiters-mustache

REVISION DETAIL
  https://phabricator.kde.org/D24354

AFFECTED FILES
  autotests/folding/test.mustache.fold
  autotests/html/test.mustache.html
  autotests/input/test.mustache
  autotests/reference/test.mustache.ref
  data/syntax/mustache.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Fixed!

2019-10-01 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.13/6/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 01 Oct 2019 18:59:08 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 491 test(s)

D24350: [src/kpac/*] replace deprecated foreach with range for

2019-10-01 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added a reviewer: dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Add convience function that returns const QList&, since that list is
  iterated over in several places in the code.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach-kpac (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24350

AFFECTED FILES
  src/kpac/script.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

2019-10-01 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/6/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 01 Oct 2019 18:59:08 +
 Build duration:
3 min 34 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.63.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13173)48%
(4093/8574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2657/2779)52%
(743/1438)src94%
(44/47)94%
(44/47)61%
(6384/10394)47%
(3350/7136)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 6 - Fixed!

2019-10-01 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 01 Oct 2019 18:59:08 +
 Build duration:
3 min 41 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.63.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9041/13173)48%
(4093/8574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2657/2779)52%
(743/1438)src94%
(44/47)94%
(44/47)61%
(6384/10394)47%
(3350/7136)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still unstable!

2019-10-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/6/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 01 Oct 2019 18:59:08 +
 Build duration:
1 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed:

D24348: Use range for loop instead of ugly sizeof arithmetic

2019-10-01 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D24348

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24348: Use range for loop instead of ugly sizeof arithmetic

2019-10-01 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24348

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24349: More (and last) fixes to compile without implicit conversion from ASCII/ByteArray

2019-10-01 Thread Ahmad Samir 
ahmadsamir created this revision.
ahmadsamir added reviewers: dfaure, kossebau.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  ahmad/ascii-cast2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24349

AFFECTED FILES
  src/core/forwardingslavebase.cpp
  src/core/kremoteencoding.cpp
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/filewidgets/kencodingfiledialog.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/ioslaves/ftp/CMakeLists.txt
  src/ioslaves/ftp/ftp.cpp
  src/kcms/kio/kcookiespolicies.cpp
  src/kcms/kio/smbrodlg.cpp
  src/kioexec/main.cpp
  src/kpasswdserver/autotests/CMakeLists.txt
  src/kpasswdserver/autotests/kpasswdservertest.cpp

To: ahmadsamir, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22365: KNotification macOS native support by NSNotificationCenter

2019-10-01 Thread Weixuan Xiao 
Inoki added a comment.


  Updating with new incoming code.
  
  Will try landing it this week

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: lnj, nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

2019-10-01 Thread David Hallas 
hallas added a comment.


  In D21235#536576 , @hallas wrote:
  
  > In D21235#535951 , @bruns wrote:
  >
  > > In D21235#535861 , @hallas 
wrote:
  > >
  > > > I have been resurrecting this patch again :) and have run into an issue 
I need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would 
like to use the `KMountPoint` class, but this class currently resides in KIO 
which Solid doesn't depend on. But, KIO actually depends on Solid so would it 
be an option to move this class from KIO to Solid?
  > >
  > >
  > > What do you gain by using KMountPoints? Solid already has code for 
parsing fstab style files.
  >
  >
  > Hi @bruns , no you are right that I should be able to do with the code that 
is in Solid already. It just needs to be updated to be able parse an arbitrary 
mtab file. But anyhow, the fstab/mtab code in Solid seems kind of duplicated 
with the code in KIO, so we might consolidate at some point.
  >
  > But let me look into the mtab code in Solid and see if I can make it work 
there :)
  
  
  Ok, I have been playing around with the code and using getmntent for parsing 
the `~/.mtab.fuseiso` file, but the getmntent function doesn't give me the 
first field, which is the path to the iso (this is the information I am looking 
for). So currently I am looking at just reading in the file, splitting the 
space separated lines and extracting the two first fields. If anyone has ideas 
to do this in a smarter way, please let me know ;) I will post an updated 
review once I have some working code.

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 5 - Failure!

2019-10-01 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/5/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 01 Oct 2019 17:38:27 +
 Build duration:
4 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 190 lines...][2019-10-01T17:42:56.319Z] XCURSOR_THEME = 'DMZ-Black'[2019-10-01T17:42:56.319Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-10-01T17:42:56.319Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-10-01T17:42:56.319Z] PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-10-01T17:42:56.319Z] PROFILEREAD   = 'true'[2019-10-01T17:42:56.319Z] MAIL  = '/var/mail/jenkins'[2019-10-01T17:42:56.319Z] HOSTTYPE  = 'x86_64'[2019-10-01T17:42:56.319Z] BUILD_ID  = '5'[2019-10-01T17:42:56.319Z] LESSKEY   = '/etc/lesskey.bin'[2019-10-01T17:42:56.319Z] OLDPWD= '/home/jenkins'[2019-10-01T17:42:56.319Z] LC_CTYPE  = 'C.UTF-8'[2019-10-01T17:42:56.319Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-01T17:42:56.319Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-10-01T17:42:56.319Z] QT_SELECT = 'qt5'[2019-10-01T17:42:56.319Z] LANG  = 'en_US.UTF-8'[2019-10-01T17:42:56.319Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-01T17:42:56.319Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-01T17:42:56.319Z] [2019-10-01T17:42:56.319Z] [2019-10-01T17:42:56.319Z] == Commencing Configuration:[2019-10-01T17:42:56.319Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.12"[2019-10-01T17:42:56.834Z] -- The C compiler identification is GNU 9.2.1[2019-10-01T17:42:56.834Z] -- The CXX compiler identification is GNU 9.2.1[2019-10-01T17:42:56.834Z] -- Check for working C compiler: /usr/bin/cc[2019-10-01T17:42:57.407Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-01T17:42:57.407Z] -- Detecting C compiler ABI info[2019-10-01T17:42:57.407Z] -- Detecting C compiler ABI info - done[2019-10-01T17:42:57.407Z] -- Detecting C compile features[2019-10-01T17:42:57.407Z] -- Detecting C compile features - done[2019-10-01T17:42:57.407Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-01T17:42:57.918Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-01T17:42:57.918Z] -- Detecting CXX compiler ABI info[2019-10-01T17:42:58.436Z] -- Detecting CXX compiler ABI info - done[2019-10-01T17:42:58.436Z] -- Detecting CXX compile features[2019-10-01T17:42:58.436Z] -- Detecting CXX compile features - done[2019-10-01T17:42:58.436Z] -- [2019-10-01T17:42:58.436Z] [2019-10-01T17:42:58.436Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for KCalendarCore.[2019-10-01T17:42:58.436Z] -- Looking for __GLIBC__[2019-10-01T17:42:58.436Z] -- Looking for __GLIBC__ - found[2019-10-01T17:42:58.436Z] -- Performing Test _OFFT_IS_64BIT[2019-10-01T17:42:58.950Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-01T17:42:58.950Z] -- Performing Test HAVE_DATE_TIME[2019-10-01T17:42:58.950Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-01T17:42:59.461Z] CMake Warning at CMakeLists.txt:49 (find_package):[2019-10-01T17:42:59.461Z]   Could not find a configuration file for package "LibIcal" that is[2019-10-01T17:42:59.461Z]   compatible with requested version "2.0".[2019-10-01T17:42:59.461Z] [2019-10-01T17:42:59.461Z]   The following configuration files were considered but not accepted:[2019-10-01T17:42:59.461Z] [2019-10-01T17:42:59.461Z] /usr/lib64/cmake/LibIcal/LibIcalConfig.cmake, version: 3.0.5[2019-10-01T17:42:59.461Z] [2019-10-01T17:42:59.461Z] [2019-10-01T17:42:59.461Z] [2019-10-01T17:42:59.461Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-01T17:42:59.461Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-01T17:42:59.461Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-01T17:42:59.976Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-01T17:42:59.976Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-01T17:43:00.488Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-01T17:43:00.488Z] -- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-10-01T17:43:00.488Z] -- Found

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Failure!

2019-10-01 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.13/5/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Tue, 01 Oct 2019 17:38:27 +
 Build duration:
4 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 190 lines...][2019-10-01T17:42:50.663Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-10-01T17:42:50.663Z] WINDIR= 'C:\WINDOWS'[2019-10-01T17:42:50.663Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-10-01T17:42:50.663Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-10-01T17:42:50.663Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-10-01T17:42:50.663Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-10-01T17:42:50.663Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-10-01T17:42:50.663Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-10-01T17:42:50.663Z] WORKSPACE = 'C:\CI\workspace\Frameworks\kcalendarcore\kf5-qt5 WindowsMSVCQt5.13'[2019-10-01T17:42:50.663Z] __DOTNET_ADD_64BIT= '1'[2019-10-01T17:42:50.663Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-10-01T17:42:50.663Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\ProgramData\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-10-01T17:42:50.663Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\kcalendarcore;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils'[2019-10-01T17:42:50.663Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\kcalendarcore\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\share'[2019-10-01T17:42:50.663Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\lib\pkgconfig'[2019-10-01T17:42:50.663Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\bin\plugins'[2019-10-01T17:42:50.663Z] QMAKEFEATURES = 'C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\mkspecs/features'[2019-10-01T17:42:50.663Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\kcalendarcore\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\share;C:\Craft\CI-Qt513\windows-msvc2017_64-cl-debug\dev-utils\share'[2019-10-01T17:42:50.663Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-01T17:42:50.663Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-01T17:42:50.663Z] [2019-10-01T17:42:50.663Z] [2019-10-01T17:42:50.663Z] == Commencing Configuration:[2019-10-01T17:42:50.663Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/kcalendarcore/" -G "NMake Makefiles JOM" -DBUILD_QCH=TRUE "C:\CI\workspace\Frameworks\kcalendarcore\kf5-qt5 WindowsMSVCQt5.13"[2019-10-01T17:42:51.227Z] -- The C compiler identification is MSVC 19.16.27031.1[2019-10-01T17:42:51.740Z] -- The CXX compiler identification is MSVC 19.16.27031.1[2019-10-01T17:42:52.259Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe[2019-10-01T17:42:54.001Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-10-01T17:42:54.002Z] -- Detecting C compiler ABI info[2019-10-01T17:42:55.718Z] -- Detecting C compiler ABI info - done[2019-10-01T17:42:55.718Z] -- Detecting C compile features[2019-10-01T17:42:58.131Z] -- Detecting C compile features - done[2019-10-01T17:42:58.131Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe[2019-10-01T17:42:59.855Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.16.27023/bin/HostX64/x64/cl.exe -- works[2019-10-01T17:42:59.855Z] -- Detecting CXX compiler ABI info[2019-10-01T17:43:02.424Z] -- Detecting CXX compiler ABI info - done[2019-10-01T17:43:02.424Z] -- Detecting CXX compile features[2019-10-01T17:43:04.131Z] -- Detecting CXX compile features - done[2019-10-01T17:43:04.131Z] -- [2019-10-01T17:43:04.131Z]

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 5 - Failure!

2019-10-01 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/5/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 01 Oct 2019 17:38:27 +
 Build duration:
4 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 190 lines...][2019-10-01T17:42:57.081Z] XCURSOR_THEME = 'DMZ-Black'[2019-10-01T17:42:57.081Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-10-01T17:42:57.081Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-10-01T17:42:57.081Z] PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-10-01T17:42:57.081Z] PROFILEREAD   = 'true'[2019-10-01T17:42:57.081Z] MAIL  = '/var/mail/jenkins'[2019-10-01T17:42:57.081Z] HOSTTYPE  = 'x86_64'[2019-10-01T17:42:57.081Z] BUILD_ID  = '5'[2019-10-01T17:42:57.081Z] LESSKEY   = '/etc/lesskey.bin'[2019-10-01T17:42:57.081Z] OLDPWD= '/home/jenkins'[2019-10-01T17:42:57.081Z] LC_CTYPE  = 'C.UTF-8'[2019-10-01T17:42:57.081Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-01T17:42:57.081Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-10-01T17:42:57.081Z] QT_SELECT = 'qt5'[2019-10-01T17:42:57.081Z] LANG  = 'en_US.UTF-8'[2019-10-01T17:42:57.081Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-01T17:42:57.081Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-10-01T17:42:57.081Z] [2019-10-01T17:42:57.081Z] [2019-10-01T17:42:57.081Z] == Commencing Configuration:[2019-10-01T17:42:57.081Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.13"[2019-10-01T17:42:59.478Z] -- The C compiler identification is GNU 9.2.1[2019-10-01T17:43:01.864Z] -- The CXX compiler identification is GNU 9.2.1[2019-10-01T17:43:01.864Z] -- Check for working C compiler: /usr/bin/cc[2019-10-01T17:43:01.864Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-01T17:43:01.864Z] -- Detecting C compiler ABI info[2019-10-01T17:43:01.864Z] -- Detecting C compiler ABI info - done[2019-10-01T17:43:01.864Z] -- Detecting C compile features[2019-10-01T17:43:01.864Z] -- Detecting C compile features - done[2019-10-01T17:43:01.864Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-01T17:43:02.378Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-01T17:43:02.378Z] -- Detecting CXX compiler ABI info[2019-10-01T17:43:02.378Z] -- Detecting CXX compiler ABI info - done[2019-10-01T17:43:02.378Z] -- Detecting CXX compile features[2019-10-01T17:43:02.378Z] -- Detecting CXX compile features - done[2019-10-01T17:43:02.378Z] -- [2019-10-01T17:43:02.378Z] [2019-10-01T17:43:02.378Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for KCalendarCore.[2019-10-01T17:43:02.378Z] -- Looking for __GLIBC__[2019-10-01T17:43:03.451Z] -- Looking for __GLIBC__ - found[2019-10-01T17:43:03.452Z] -- Performing Test _OFFT_IS_64BIT[2019-10-01T17:43:03.452Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-01T17:43:03.452Z] -- Performing Test HAVE_DATE_TIME[2019-10-01T17:43:03.452Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-01T17:43:03.962Z] CMake Warning at CMakeLists.txt:49 (find_package):[2019-10-01T17:43:03.962Z]   Could not find a configuration file for package "LibIcal" that is[2019-10-01T17:43:03.962Z]   compatible with requested version "2.0".[2019-10-01T17:43:03.962Z] [2019-10-01T17:43:03.962Z]   The following configuration files were considered but not accepted:[2019-10-01T17:43:03.962Z] [2019-10-01T17:43:03.962Z] /usr/lib64/cmake/LibIcal/LibIcalConfig.cmake, version: 3.0.5[2019-10-01T17:43:03.962Z] [2019-10-01T17:43:03.962Z] [2019-10-01T17:43:03.962Z] [2019-10-01T17:43:03.962Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-01T17:43:04.472Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-01T17:43:04.472Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-01T17:43:04.472Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-01T17:43:04.472Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-01T17:43:04.472Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-01T17:43:05.542Z] -- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-10-01T17:43:05.542Z] -- Found

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Failure!

2019-10-01 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 01 Oct 2019 17:38:27 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 133 lines...][2019-10-01T17:39:50.117Z] WORKSPACE = '/usr/home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 FreeBSDQt5.13'[2019-10-01T17:39:50.117Z] MM_CHARSET= 'UTF-8'[2019-10-01T17:39:50.117Z] STAGE_NAME= 'Configuring Build'[2019-10-01T17:39:50.117Z] NODE_NAME = 'FreeBSD Builder 1'[2019-10-01T17:39:50.117Z] BLOCKSIZE = 'K'[2019-10-01T17:39:50.117Z] EXECUTOR_NUMBER   = '0'[2019-10-01T17:39:50.117Z] SHLVL = '0'[2019-10-01T17:39:50.117Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-10-01T17:39:50.117Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-10-01T17:39:50.117Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-10-01T17:39:50.117Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2019-10-01T17:39:50.117Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2019-10-01T17:39:50.117Z] QT_SELECT = 'qt5'[2019-10-01T17:39:50.117Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-10-01T17:39:50.117Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-10-01T17:39:50.117Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-10-01T17:39:50.117Z] [2019-10-01T17:39:50.117Z] [2019-10-01T17:39:50.117Z] == Commencing Configuration:[2019-10-01T17:39:50.117Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 FreeBSDQt5.13"[2019-10-01T17:39:50.423Z] -- The C compiler identification is Clang 6.0.1[2019-10-01T17:39:50.692Z] -- The CXX compiler identification is Clang 6.0.1[2019-10-01T17:39:50.692Z] -- Check for working C compiler: /usr/bin/cc[2019-10-01T17:39:51.010Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-10-01T17:39:51.010Z] -- Detecting C compiler ABI info[2019-10-01T17:39:51.010Z] -- Detecting C compiler ABI info - done[2019-10-01T17:39:51.331Z] -- Detecting C compile features[2019-10-01T17:39:52.005Z] -- Detecting C compile features - done[2019-10-01T17:39:52.005Z] -- Check for working CXX compiler: /usr/bin/c++[2019-10-01T17:39:52.005Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-10-01T17:39:52.005Z] -- Detecting CXX compiler ABI info[2019-10-01T17:39:52.335Z] -- Detecting CXX compiler ABI info - done[2019-10-01T17:39:52.335Z] -- Detecting CXX compile features[2019-10-01T17:39:53.376Z] -- Detecting CXX compile features - done[2019-10-01T17:39:53.376Z] -- [2019-10-01T17:39:53.376Z] [2019-10-01T17:39:53.376Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/kcalendarcore/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for KCalendarCore.[2019-10-01T17:39:53.376Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-10-01T17:39:53.376Z] -- Looking for __GLIBC__[2019-10-01T17:39:53.376Z] -- Looking for __GLIBC__ - not found[2019-10-01T17:39:53.376Z] -- Performing Test _OFFT_IS_64BIT[2019-10-01T17:39:53.644Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-10-01T17:39:53.644Z] -- Performing Test HAVE_DATE_TIME[2019-10-01T17:39:53.644Z] -- Performing Test HAVE_DATE_TIME - Success[2019-10-01T17:39:53.919Z] CMake Warning at CMakeLists.txt:49 (find_package):[2019-10-01T17:39:53.919Z]   Could not find a configuration file for package "LibIcal" that is[2019-10-01T17:39:53.919Z]   compatible with requested version "2.0".[2019-10-01T17:39:53.919Z] [2019-10-01T17:39:53.919Z]   The following configuration files were considered but not accepted:[2019-10-01T17:39:53.919Z] [2019-10-01T17:39:53.919Z] /usr/local/lib/cmake/LibIcal/LibIcalConfig.cmake, version: 3.0.4[2019-10-01T17:39:53.919Z] [2019-10-01T17:39:53.919Z] [2019-10-01T17:39:53.919Z] [2019-10-01T17:39:53.919Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-01T17:39:53.919Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-01T17:39:53.920Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-01T17:39:54.234Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-01T17:39:54.234Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-01T17:39:54.519Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-01T17:39:54.519Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13")

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

2019-10-01 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D24347

To: aacid, vkrause
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

2019-10-01 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D24346

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

2019-10-01 Thread Albert Astals Cid 
aacid closed this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D24344

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24348: Use range for loop instead of ugly sizeof arithmetic

2019-10-01 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R310 KTextWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24348

AFFECTED FILES
  src/findreplace/kfinddialog.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

2019-10-01 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24347

To: aacid, vkrause
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24347: Use range for loop instead of sizeof(x) / sizeof(x[0])

2019-10-01 Thread Albert Astals Cid 
aacid created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24347

AFFECTED FILES
  man/man2html.cpp

To: aacid
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

2019-10-01 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24346

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

2019-10-01 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24344

To: aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

2019-10-01 Thread Noah Davis 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e0ef6b7ed41a: Make 22px squiggle more like 16px squiggle 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24253?vs=66931=67148

REVISION DETAIL
  https://phabricator.kde.org/D24253

AFFECTED FILES
  icons-dark/actions/22/format-text-underline-squiggle.svg
  icons/actions/22/format-text-underline-squiggle.svg

To: ndavis, #vdg
Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24346: Use range for instead of sizeof(aztec_code_double_symbols) / sizeof(aztec_code_double_symbols[0])

2019-10-01 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24346

AFFECTED FILES
  src/lib/aztecbarcode.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24344: Use range for instead of sizeof(buttons) / sizeof(buttons[0])

2019-10-01 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24344

AFFECTED FILES
  src/kdatepicker.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 113 - Still Unstable!

2019-10-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/113/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 01 Oct 2019 16:55:37 +
 Build duration:
8 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 112 - Still Unstable!

2019-10-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/112/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 01 Oct 2019 16:44:26 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

2019-10-01 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:9713ea02e49e: Consider the usage of WebDAV methods 
sufficient for assuming WebDAV (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24316?vs=67079=67143

REVISION DETAIL
  https://phabricator.kde.org/D24316

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24315: REPORT also supports the Depth header

2019-10-01 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ac0462180c0d: REPORT also supports the Depth header 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24315?vs=67078=67141

REVISION DETAIL
  https://phabricator.kde.org/D24315

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24308: [DataProtocol] compile without implicit coversion from ascii

2019-10-01 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 67125.
ahmadsamir added a comment.


  Make it faster by comparing char's directly

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24308?vs=67062=67125

BRANCH
  ahmad/compile-without-ascii-cast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24308

AFFECTED FILES
  src/core/dataprotocol.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

2019-10-01 Thread Nathaniel Graham 
ngraham added a comment.


  "Customize Layout" is fine IMO. :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-10-01 Thread David Edmundson 
davidedmundson added a comment.


  How does kio-fuse know when to unmount?

INLINE COMMENTS

> krun.cpp:529
> +// Lets try a KIOFuse mount instead.
> +QDBusInterface 
> kiofused(QStringLiteral("org.kde.kded5"), 
> +
> QStringLiteral("/modules/kiofuse"), 

Generally QDBusInterface is a class to be avoided.

I would recommend  copy/pasting your XML file and then using the generated 
interface from that.

QDBusInterface sucks as it makes a blocking call introspecting (which isn't a 
huge problem considering we're going to block anyway!) but also leads to going 
crazy figuring out typos in methods/arguments.

> krun.cpp:533
> +
> QDBusConnection::sessionBus());
> +if (!kiofused.isValid() || 
> kiofused.lastError().isValid()) {
> +// Module isn't loaded...

We rarely check lastError(), that's for if you use the lower level API calls.

> krun.cpp:556
> +// Empty string means mounting failed...
> +if(reply.isValid() && !reply.value().isEmpty()) {
> +*it = QUrl::fromLocalFile(reply.value());

All DBus replies are a union of their success value and an error.

Returning an error reply when mounting fails would allow us to provide a more 
helpful message back to the user

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, chinmoyr
Cc: davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, 
bruns

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-10-01 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  2019_09_okbutton_configurable

REVISION DETAIL
  https://phabricator.kde.org/D24252

To: dfaure, cfeck, vkrause, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24159: new module ECMSourceVersionControl

2019-10-01 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:f3f4893b5bd2: new module ECMSourceVersionControl 
(authored by sitter).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24159?vs=4=67114

REVISION DETAIL
  https://phabricator.kde.org/D24159

AFFECTED FILES
  docs/module/ECMSourceVersionControl.rst
  kde-modules/KDECompilerSettings.cmake
  modules/ECMSourceVersionControl.cmake

To: sitter, kde-buildsystem, dfaure
Cc: apol, kossebau, kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, 
ngraham, bruns

D23512: Avoid overloading KCModule::changed

2019-10-01 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23512

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

2019-10-01 Thread Piyush Aggarwal 
brute4s99 added a comment.


  we need this because the symbols being currently used are Unix-only. Porting 
to Qt supplied ones allows this plugin to work on other OSes (my concern: 
Windows) as well. 

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D24159: new module ECMSourceVersionControl

2019-10-01 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  vcs

REVISION DETAIL
  https://phabricator.kde.org/D24159

To: sitter, kde-buildsystem, dfaure
Cc: apol, kossebau, kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, 
ngraham, bruns

D24308: [DataProtocol] compile without implicit coversion from ascii

2019-10-01 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dataprotocol.cpp:120
>  {
> -int size = buf.length();
> -while (pos < size && buf[pos].isSpace()) {
> +const QString  = QString::fromLatin1(buf);
> +int size = str.length();

It would be faster to keep a QByteArray here and just compare to ' ' and 
possibly \t.

> dataprotocol.cpp:196
>  // jump over delimiter token and return if data reached
> -if (raw_url[header_info.data_offset++] == QLatin1Char(',')) {
> +if (QLatin1Char(raw_url[header_info.data_offset++]) == QLatin1Char(',')) 
> {
>  return header_info;

Better remove both QLatin1Char and just compare chars.

> dataprotocol.cpp:206
>  if (header_info.data_offset >= raw_url_len
> -|| raw_url[header_info.data_offset] != QLatin1Char('=')) {
> +|| QLatin1Char(raw_url[header_info.data_offset]) != 
> QLatin1Char('=')) {
>  // no assignment, must be base64 option

Same here, and more that follow

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24308

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

2019-10-01 Thread Marco Martin 
mart updated this revision to Diff 67113.
mart added a comment.


  - Customize Layout

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24263?vs=67051=67113

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h

To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

2019-10-01 Thread Marco Martin 
mart added a comment.


  i think in the end
  Customize Layout/Finish Customizing Layout
  
  i prefer not to name the term "mode" at all if i can, both because is kinda a 
nerdy term and because modes are an ux cardinal sin, so at least not being too 
proud of it ;)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

2019-10-01 Thread Marco Martin 
mart added a comment.


  the last, "the least the name "edit mode" is user facing, the better it is

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma
Cc: GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

2019-10-01 Thread David Faure 
dfaure added a comment.


  I'm not sure what the QFileDevice enum gives us compared to the octal 
permissions as int? Is this just because it looks nicer, to save a conversion, 
or because you actually need the differenciation between ReadUser and 
ReadOwner, on Windows?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-10-01 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:52175ce07389: Add two special cases url 
recentlyused:/files and recentlyused:/folders (authored by meven).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=67102=67103

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24245: Add support for passing Unix file descriptors

2019-10-01 Thread Alexander Volkov 
volkov added a comment.


  It will require adding the following methods:
  
Action::setFileDescriptors()
Action::addFileDescriptor()
Action::fileDescriptors()
ActionReply::setFileDescriptors()
ActionReply::addFileDescriptor()
ActionReply::fileDescriptors()
  
  and
  
ExecuteJob::fileDescriptors()
ExecuteJob::newFileDescriptors()
  
  with the condition that for progress data they can be used only with direct 
signal-slot connections,
  because without `UnixFileDescriptor` we cannot guarantee the open state of 
file descriptors.
  It doesn't seem better than exposing this class.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D24245

To: volkov, fvogt, chinmoyr, cfeck, #frameworks, security-team
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-10-01 Thread Méven Car 
meven added a comment.


  The /folders path is /locations in fact

REPOSITORY
  R320 KIO Extras

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23742: Add two special cases url recentlyused:/files and recentlyused:/folders

2019-10-01 Thread Méven Car 
meven updated this revision to Diff 67102.
meven added a comment.


  Correct ?type use with /files : ?type overrules /files, since they are 
aggregated with ORs

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23742?vs=65959=67102

BRANCH
  arcpatch-D23742

REVISION DETAIL
  https://phabricator.kde.org/D23742

AFFECTED FILES
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h

To: meven, ivan, ngraham, #frameworks
Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov