D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-09 Thread Kevin Ottens 
ervin added a comment.


  Any chance to get another round of reviews now that this patch changed quite 
a bit?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24490

To: ervin, #plasma, #frameworks, dfaure, mart, apol
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-09 Thread Kevin Ottens 
ervin added a comment.


  Any chance to get another round of reviews now that this patch changed quite 
a bit?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24494

To: ervin, #plasma, #frameworks, dfaure, mart
Cc: kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Nibaldo González 
nibags updated this revision to Diff 67588.
nibags added a comment.


  - TypeScript React: fix end-line regex

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24355?vs=67587=67588

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

2019-10-09 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 10 Oct 2019 03:26:51 +
 Build duration:
1 hr 26 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Nibaldo González 
nibags updated this revision to Diff 67587.
nibags added a comment.


  typescript-react: increase version.
  javascript: use non-capturing groups in RegExpr

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24355?vs=67162=67587

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Nibaldo González 
nibags added a comment.


  ups! i will correct it

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 60 - Unstable!

2019-10-09 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/60/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 10 Oct 2019 03:27:17 +
 Build duration:
20 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.63.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltestFailed: projectroot.autotests.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(445/2045)18%
(168/947)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)89%
(139/156)51%
(51/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis 
ndavis added a comment.


  Thanks

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7fea43c57c59: Add PATH/LD_LIBRARY_PATH to qrcAlias 
invocation (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24477?vs=67456=67586

REVISION DETAIL
  https://phabricator.kde.org/D24477

AFFECTED FILES
  CMakeLists.txt

To: masonm, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis 
ndavis retitled this revision from "[PATCH] Add PATH/LD_LIBRARY_PATH to 
qrcAlias invocation" to "Add PATH/LD_LIBRARY_PATH to qrcAlias invocation".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis 
ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24477

To: masonm, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-10-09 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 67584.
kossebau added a comment.


  improve documentation, especially about the generated C++ macros

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=67554=67584

BRANCH
  addgenerateexportheader

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake
  tests/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/main.cpp
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake
  tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/format_version/main.cpp
  tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/library/library.cpp
  tests/ECMGenerateExportHeaderTest/library/library.hpp
  tests/ECMGenerateExportHeaderTest/library/main.cpp

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

2019-10-09 Thread Stuart 
Dear development team,

As per the PostgreSQL release documents:
E.1. Release 12
https://www.postgresql.org/docs/12/release-12.html#id-1.11.6.5.5

PostgreSQL Version 12 removes:

obsolete pg_constraint.consrc column
obsolete pg_attrdef.adsrc column


Akonadi executes this query that fails due to changes in the PostgreSQL
schema

DB=akonadi USER=akonadi SELECT pg_attribute.attname,
pg_attribute.atttypid::int, pg_attribute.attnotnull, pg_attribute.attlen,
pg_attribute.atttypmod, pg_attrdef.adsrc FROM pg_class, pg_attribute LEFT
JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND
pg_attrdef.adnum = pg_attribute.attnum) WHERE
pg_table_is_visible(pg_class.oid) AND pg_class.relname =
'schemaversiontable' AND pg_attribute.attnum > 0 AND pg_attribute.attrelid
= pg_class.oid AND pg_attribute.attisdropped = false ORDER BY
pg_attribute.attnum
DB=akonadi USER=akonadi SELECT ERROR:  42703: column pg_attrdef.adsrc does
not exist at character 128
DB=akonadi USER=akonadi SELECT pg_attribute.attname,
pg_attribute.atttypid::int, pg_attribute.attnotnull, pg_attribute.attlen,
pg_attribute.atttypmod, pg_attrdef.adsrc FROM pg_class, pg_attribute LEFT
JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND
pg_attrdef.adnum = pg_attribute.attnum) WHERE
pg_table_is_visible(pg_class.oid) AND pg_class.relname =
'schemaversiontable' AND pg_attribute.attnum > 0 AND pg_attribute.attrelid
= pg_class.oid AND pg_attribute.attisdropped = false ORDER BY
pg_attribute.attnum
DB=akonadi USER=akonadi ALTER TABLE SchemaVersionTable ADD COLUMN version
INTEGER NOT NULL DEFAULT 0
DB=akonadi USER=akonadi ALTER TABLE ERROR:  42701: column "version" of
relation "schemaversiontable" already exists


This causes akonadi to repeatedly try to update the SchemaVersionTable and
quits with error.

org.kde.pim.akonadiserver: Starting up the Akonadi Server...
org.kde.pim.akonadiserver: Running DB initializer
org.kde.pim.akonadiserver: "\nSql error: ERROR:  column \"version\" of
relation \"schemaversiontable\" already exists\n(42701) QPSQL: Unable to
create query\nQuery: ALTER TABLE SchemaVersionTable ADD COLUMN version
INTEGER NOT NULL DEFAULT 0"
org.kde.pim.akonadiserver: Unable to initialize database.
org.kde.pim.akonadiserver: Shutting down AkonadiServer...


The schema information for these dropped columes can be obtained using the
functions

pg_constraint.consrc pg_get_constraintdef(pg_constraint.oid)
pg_attrdef.adsrc pg_get_expr(pg_attrdef.adbin, pg_class.oid)

So the Akonadi query:

SELECT pg_attribute.attname, pg_attribute.atttypid::int,
pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod,
pg_attrdef.adsrc
FROM pg_class, pg_attribute
LEFT JOIN pg_attrdef ON (pg_attrdef.adrelid = pg_attribute.attrelid AND
pg_attrdef.adnum = pg_attribute.attnum)
WHERE pg_table_is_visible(pg_class.oid)
AND pg_class.relname = 'schemaversiontable'
AND pg_attribute.attnum > 0
AND pg_attribute.attrelid = pg_class.oid
AND pg_attribute.attisdropped = false ORDER BY pg_attribute.attnum ;

should probably be changed to something like:

SELECT pg_attribute.attname, pg_attribute.atttypid::int,
pg_attribute.attnotnull, pg_attribute.attlen, pg_attribute.atttypmod,
pg_get_expr(pg_attrdef.adbin, pg_class.oid) AS adsrc
FROM pg_class
LEFT JOIN pg_attribute ON ( pg_attribute.attrelid = pg_class.oid )
LEFT JOIN pg_attrdef ON  ( pg_attrdef.adrelid = pg_attribute.attrelid
 AND   pg_attrdef.adnum = pg_attribute.attnum )
WHERE pg_table_is_visible(pg_class.oid)
AND pg_class.relname = 'schemaversiontable'
AND pg_attribute.attnum > 0
AND pg_attribute.attisdropped = false
ORDER BY pg_attribute.attnum;

This will produce something like the following table:

  attname   | atttypid | attnotnull | attlen | atttypmod | adsrc
+--+++---+---
 version|   23 | t  |  4 |-1 | 0
 generation |   23 | t  |  4 |-1 | 0
(2 rows)

D24524: Add a common widget config control library starting with ConfigIcon.qml

2019-10-09 Thread Chris Holland 
Zren created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I'm submitting this to start discussion on creating a common config control 
library.
  
  I've started with a more common use case, an Icon control, to start us off.
  
  - This is based on the kickoff icon control. 
https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml
  - I added:
- The preview size and padding can be changed
- The default icon that used when "cleared" can be changed.
- A TextField (Would be easier for power users, but I understand not adding 
it)
- A dedicated browse button (I'm not against removing)
- Preset values in the dropdown (I don't really need it)
  - No idea if creating a new module is best. Nor if the name is okay. 
"configuration" is already in use.
  - `contents/config/config.qml` has `ConfigModel` and `ConfigCategory` under a 
`org.kde.plasma.configuration` module, however it is declared using C++ 
classes. 
https://github.com/KDE/plasma-framework/blob/acdaefa221cc3e4b60542b4805e53ed966ea23b7/autotests/configmodeltest.cpp#L40
  - I'm not sure why `MenuSeparator { visible: false }` leaves leftover 
whitespace.
  
  I currently have a QQC1 library 

 that assigns directly to `plasmoid.configuration[configKey]` without the user 
needing to click "Apply" (Like on Gnome). I'm not expecting "auto-serialize" to 
get merged to KDE however, which is unfortunate. `ConfigIcon { configKey: 
'icon' }` is very nice and compact, and clicking Apply feels pointless.
  
  Screenshots
  ===
  
  F7558454: 2019-10-09___12-45-11.png 
  F7558455: 2019-10-09___14-41-15.png 
  
  Use Cases
  =
  
  - Kicker, Kickoff
  - Present Windows T11776 
  - I use a modified version of this in Tiled Menu. I make the `ColumnLayout` 
the default property so I can optionally add a checkbox below the `TextField`. 
There's no need for this feature if we remove the TextField though. 
https://github.com/Zren/plasma-applet-tiledmenu/blob/master/package/contents/ui/lib/ConfigIcon.qml
 
https://github.com/Zren/plasma-applet-tiledmenu/blob/master/package/contents/ui/config/ConfigGeneral.qml#L73-L81
  
RowLayout
IconPreview
ColumnLayout
RowLayout
TextField
Button
CheckBox

TEST PLAN
  Not yet tested via `cmake` and importing, but the QML is tested in a widget.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24524

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmaconfig/ConfigIcon.qml
  src/declarativeimports/plasmaconfig/qmldir

To: Zren
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D4363: Don't set gnu style parameter with Clang and MSVC

2019-10-09 Thread Christoph Cullmann 
cullmann added a comment.
Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; 
removed: Frameworks, Build System.


  Is this still relevant? If yes, from the diff, looks ok for me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4363

To: vonreth, #windows, dfaure, bcooksley, alexmerry
Cc: kde-frameworks-devel, kde-buildsystem, cullmann, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns, #frameworks, #build_system

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Seems fine.
  Does typescript-react.xml lack a version update?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D24355

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24357: KateModeMenuList: force the vertical position above the button

2019-10-09 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok with that.

REPOSITORY
  R39 KTextEditor

BRANCH
  menu-vertical-position

REVISION DETAIL
  https://phabricator.kde.org/D24357

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23835: Add TabKCM

2019-10-09 Thread Nathaniel Graham 
ngraham added a dependent revision: D24224: Start of the accessibility KCM.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23835

To: nicolasfella, mart
Cc: onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-09 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh I see.

REPOSITORY
  R276 KItemViews

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok, ngraham
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-09 Thread David Redondo 
davidre added a comment.


  In D24453#544251 , @ngraham wrote:
  
  > +1. Can you do the same thing for the similar header that's seen in System 
Settings' icon view?
  >
  > F7556761: Screenshot_20191009_085522.png 

  
  
  Of course. This has to be done in systemsettings directly then  because it 
uses a custom CategoryDrawer.
  https://cgit.kde.org/systemsettings.git/tree/icons/CategoryDrawer.cpp

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24522: Add presentwindows icon (old "task view" from windows)

2019-10-09 Thread Chris Holland 
Zren added a comment.


  > `preferences-system-windows-effect-presentwindows`
  
  That would look like the `homerun` icon, which looks like the "windows" logo.
  
  F7557693: 2019-10-09___13-01-07.png 
  
  When you clicked on "Task View" in Windows, the 2 "obscured" windows would 
animate left/right a little to demonstrate that all windows are now visible. 
There isn't really a good way to know when the KWin Effect is active like that 
though to do a similar animation.
  
  Nowadays, Windows has a different icon for their "task history" view.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

To: Zren, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24502: Replace recursion in FilteredDirIterator with loop iteration

2019-10-09 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:3319b6656043: Replace recursion in FilteredDirIterator 
with loop iteration (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24502?vs=67506=67569

REVISION DETAIL
  https://phabricator.kde.org/D24502

AFFECTED FILES
  src/file/filtereddiriterator.cpp

To: bruns, #baloo, ngraham, astippich
Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Unstable!

2019-10-09 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/26/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 09 Oct 2019 16:30:24 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still Unstable!

2019-10-09 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/12/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 09 Oct 2019 16:13:29 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed:

D24522: Add presentwindows icon (old "task view" from windows)

2019-10-09 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks!
  
  However I'm not sure this is the most accurate icon to depict the Present 
Windows effect. It shows one window in the front obscuring two windows behind 
it. This would seem to depict the macOS "coverflow" effect 
(https://www.ecosia.org/images?q=coverflow#id=_) rather than Present Windows, 
which doesn't allow windows to overlap. I wonder if a monochrome version of the 
existing `preferences-system-windows-effect-presentwindows` icon would be 
better:
  
  F7557256: Screenshot_20191009_100759.png 

  
  What do you think?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

To: Zren, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24522: Add presentwindows icon (old "task view" from windows)

2019-10-09 Thread Chris Holland 
Zren created this revision.
Zren added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Needed for T11776 , but only we we want 
the widget for the "Windows" Look and Feel. The "Unity" Look and Feel would not 
need this icon.
  
  - I made the SVG, but it's obviously a copy. Windows doesn't even use this 
icon anymore.
  - https://commons.wikimedia.org/wiki/File:Windows_10_Task_View_Icon.svg
  - Wikipedia's licensing bit: "This image consists only of simple geometric 
shapes or text. It does not meet the threshold of originality needed for 
copyright protection, and is therefore in the public domain. Although it is 
free of copyright restrictions, this image may still be subject to other 
restrictions. See Fonts and typefaces for more information."
  - https://commons.wikimedia.org/wiki/File:Windows_10_Task_View_Icon.png
  - The PNG does have a disclaimer the SVG does not: " This work includes 
material that may be protected as a trademark in some jurisdictions. If you 
want to use it, you have to ensure that you have the legal right to do so and 
that you do not infringe any trademark rights. See our general disclaimer."
  
  F7557038: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

AFFECTED FILES
  icons/actions/16/presentwindows.svg
  icons/actions/22/presentwindows.svg
  icons/actions/24/presentwindows.svg

To: Zren, #vdg, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24502: Replace recursion in FilteredDirIterator with loop iteration

2019-10-09 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  This makes sense to me.

REPOSITORY
  R293 Baloo

BRANCH
  iterative_filtereddiriterator

REVISION DETAIL
  https://phabricator.kde.org/D24502

To: bruns, #baloo, ngraham, astippich
Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24263: edit mode action

2019-10-09 Thread Marco Martin 
mart added inline comments.

INLINE COMMENTS

> broulik wrote in corona.cpp:378
> Why is this switch to explicitly stating all the cases?
> The action is always visible and enabled only when Mutable

ah, it wanted to be setVisible(false) in case of systemimmutable, so they 
should be all different

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-09 Thread Nathaniel Graham 
ngraham added a comment.


  +1. Can you do the same thing for the similar header that's seen in System 
Settings' icon view?
  
  F7556761: Screenshot_20191009_085522.png 


REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24263: edit mode action

2019-10-09 Thread Marco Martin 
mart updated this revision to Diff 67557.
mart added a comment.


  - add parameter to editModeChanged
  - hide action on systemimmutable

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24263?vs=67113=67557

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h

To: mart, #plasma, #vdg
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24492: [FilteredDirIterator] Reduce stack pressure

2019-10-09 Thread Kai Krakow 
hurikhan77 abandoned this revision.
hurikhan77 added a comment.


  Let's close this in favor of https://phabricator.kde.org/D24502

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24492

To: hurikhan77, #baloo
Cc: bruns, cullmann, shubham, kde-frameworks-devel, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-10-09 Thread Friedrich W. H. Kossebau 
kossebau marked 2 inline comments as done.
kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in ECMGenerateExportHeader.cmake:269
> Really? Isn't doWhat excluded only if EXCLUDE_DEPRECATED_BEFORE_AND_AT is set 
> to 5.12.0?
> With 5.0.0 it's still available, no?
> 
> I'm also surprised this paragraph talks about doWhat but not doBar, they both 
> get disabled together, right?

Hm, indeed that text is bogus. Guess that was in draft mode still when I 
shuffled a lot with code snippets for the examples, but then I forgot to finish 
it up and missed the bits when skimming the doc text for completeness. Brushed 
over text coming in.

And going to give the whole documentation another calm concentrated read 
tonight myself again, seeing such things still in.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23789

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23789: Add ECMGenerateExportHeaders, for improved handling of deprecated API

2019-10-09 Thread Friedrich W. H. Kossebau 
kossebau updated this revision to Diff 67554.
kossebau marked an inline comment as done.
kossebau added a comment.


  - update to David's findings in the docs

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23789?vs=67523=67554

BRANCH
  addgenerateexportheader

REVISION DETAIL
  https://phabricator.kde.org/D23789

AFFECTED FILES
  docs/module/ECMGenerateExportHeader.rst
  modules/ECMGenerateExportHeader.cmake
  tests/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/consumer/main.cpp
  
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake
  tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake
  tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/format_version/main.cpp
  tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt
  tests/ECMGenerateExportHeaderTest/library/library.cpp
  tests/ECMGenerateExportHeaderTest/library/library.hpp
  tests/ECMGenerateExportHeaderTest/library/main.cpp

To: kossebau, #frameworks, #build_system
Cc: chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D24263: edit mode action

2019-10-09 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> corona.cpp:378
> +switch (d->immutability) {
> +case Types::UserImmutable:
> +action->setEnabled(false);

Why is this switch to explicitly stating all the cases?
The action is always visible and enabled only when Mutable

> corona.cpp:379
> +case Types::UserImmutable:
> +action->setEnabled(false);
> +action->setVisible(true);

fall-through?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24492: [FilteredDirIterator] Reduce stack pressure

2019-10-09 Thread Stefan Brüns 
bruns added a comment.


  In D24492#543641 , @hurikhan77 
wrote:
  
  > Let me change that into a proper loop.
  
  
  See D24502 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24492

To: hurikhan77, #baloo
Cc: bruns, cullmann, shubham, kde-frameworks-devel, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D24502: Replace recursion in FilteredDirIterator with loop iteration

2019-10-09 Thread Stefan Brüns 
bruns added reviewers: ngraham, astippich.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24502

To: bruns, #baloo, ngraham, astippich
Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-09 Thread David Redondo 
davidre marked an inline comment as done.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-09 Thread David Redondo 
davidre updated this revision to Diff 67529.
davidre added a comment.


  Make code more expressive and add comments

REPOSITORY
  R276 KItemViews

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24453?vs=67480=67529

BRANCH
  newcategorystyle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24453

AFFECTED FILES
  src/kcategorizedview.cpp
  src/kcategorydrawer.cpp

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 121 - Still Unstable!

2019-10-09 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/121/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 09 Oct 2019 07:16:20 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)