D24652: Add folder-recent, extend hand of clock in folder-temp

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24652

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24652: Add folder-recent, extend hand of clock in folder-temp

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  folder-recent is merely a symlink to folder-temp since they both normally use 
the same iconography. I don't like that they are identical and have completely 
different meanings though. If I can do it without breaking anything, I'll 
replace folder-temp with folder-recent in the future.

REPOSITORY
  R266 Breeze Icons

BRANCH
  recent-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24652

AFFECTED FILES
  icons-dark/places/32/folder-recent.svg
  icons-dark/places/32/folder-temp.svg
  icons-dark/places/64/folder-recent.svg
  icons/places/32/folder-recent.svg
  icons/places/32/folder-temp.svg
  icons/places/64/folder-recent.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:15ed55b4cb71: [icons/media.svg] Add 16  32px icons, 
update style (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24627?vs=67885=67938

REVISION DETAIL
  https://phabricator.kde.org/D24627

AFFECTED FILES
  src/desktoptheme/breeze/icons/media.svg

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Heh, I never noticed that these were blurry, but now I can't un-see it!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  media-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 15 Oct 2019 01:15:44 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D24651: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, mirko.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to ThreadWeaver to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DTHREADWEAVER_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DTHREADWEAVER_NO_DEPRECATED
- -DTHREADWEAVER_DEPRECATED_WARNINGS_SINCE
- -DTHREADWEAVER_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build ThreadWeaver optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0,
  CURRENT.

REPOSITORY
  R279 ThreadWeaver

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24651

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/collection.cpp
  src/collection.h

To: kossebau, #frameworks, mirko
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, gladhorn, leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to Attica to hide deprecated API up to a given version or 
silence deprecation warnings after a given version, using
- -DATTICA_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DATTICA_NO_DEPRECATED
- -DATTICA_DEPRECATED_WARNINGS_SINCE
- -DATTICA_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build Attica optionally with deprecated API excluded from the build, 
using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 0.2.0, 5.4.0,
  5.23.0, CURRENT.

REPOSITORY
  R235 Attica

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24650

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h

To: kossebau, #frameworks, gladhorn, leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 149 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/149/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 14 Oct 2019 20:15:46 +
 Build duration:
3 hr 43 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33951/61584)39%
(16992/43504)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9557/10118)47%
(4461/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8672/14502)51%
(4514/8805)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4675/8302)43%
(2021/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 47 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/47/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 14 Oct 2019 14:33:17 +
 Build duration:
8 hr 56 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6885/9076)43%
(10769/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2872/2964)48%
(6171/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.13 - Build # 14 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.13/14/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 14 Oct 2019 21:23:47 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D24621: [RFC] New Konsole and Yakuake icons

[Mariusz Glebocki]

mglb edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D24621: [RFC] New Konsole and Yakuake icons

[Mariusz Glebocki]

mglb added a comment.


  Please note that Konsole icon is intended to be personalized icon/"logo" (see 
T10243 ).
  The prompt symbol is thick as it is main symbol (like symbols in e.g Plasma, 
Akregator, Kile, "K" icons/logos) - the window-like background (or just square 
in var C) is just secondary addition.
  
  I did Yakuake symbol first and this is the only one I really like. Konsole 
symbol is just an attempt to make something similar, so ideas how to modify it 
are welcome.
  
  In D24621#546750 , @ndavis wrote:
  
  > I think that green color is not particularly Breeze-like and there's no 
clear reason why green would be a symbol for Konsole.
  
  
  This is  "Icon Green" (the prompt slightly lighter, K slightly darker), 
breeze secondary color.
  In terminals era, monochrome monitors were usually green, amber or white. 
Green one was apparently most popular. Green terminal is also a thing in pop 
culture today.
  
  > I do like the idea of tabs on the bottom, but they look a bit off somehow. 
Maybe it's because they don't look like Breeze tabs? We may want to consider 
changing the look of Breeze tabs in the future though, so it's probably best if 
we don't try too hard to match the look of the Breeze widget theme.
  >  Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 
  
  Intentional - I wanted to make it more symbolic than real-looking. Realistic 
widget representations are good for utility icons (e.g preferences) IMO. Also, 
when I look at this dark background and ">_" in variant B, I see something like 
squarish Konsole-Konqui :P
  
  In D24621#546894 , @trickyricky26 
wrote:
  
  > gradients with bigger differences between the colors.
  
  
  Changed, now the ligthness difference in dark gradient is similar to other 
icons.
  
  > IIRC the discussion about the redesign of these icons started with the 
problem that they are not recognizable enough as standalone apps, not just as 
genric terminal emulators. I think we should try to experiment some more with 
the "K" symbol until we maybe find a variant that we like and fits well enough 
with other Breeze icons. Otherwise, I don't necessarily think or one of the 
variant B icons will be an improvement over the current Konsole icon, which I 
personally like because of it's simplicity.
  
  There were also complaints that there is no Konsole icon in Breeze, only 
generic utilities-terminal.
  
  ---
  
  Update: lighter background
  F7595525: konsole-icon.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 135 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/135/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 14 Oct 2019 17:37:41 +
 Build duration:
3 hr 2 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24621: [RFC] New Konsole and Yakuake icons

[Mariusz Glebocki]

mglb updated this revision to Diff 67926.
mglb added a comment.


  Brighten background

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24621?vs=67871=67926

BRANCH
  mglb/add-konsole-yakuake-icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

AFFECTED FILES
  icons/apps/48/konsole.svg
  icons/apps/48/yakuake.svg

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 148 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/148/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 14 Oct 2019 13:58:31 +
 Build duration:
6 hr 17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33957/61585)39%
(16997/43504)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9557/10118)47%
(4461/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8669/14502)51%
(4520/8805)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4674/8302)43%
(2020/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D24643: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows
  
  - projects linking to KGlobalAccel to hide deprecated API up to a given 
version or silence deprecation warnings after a given version, using
- -DKGLOBALACCEL_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKGLOBALACCEL_NO_DEPRECATED
- -DKGLOBALACCEL_DEPRECATED_WARNINGS_SINCE
- -DKGLOBALACCEL_NO_DEPRECATED_WARNINGS
- -DKGLOBALACCELPRIVATE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKGLOBALACCELPRIVATE_NO_DEPRECATED
- -DKGLOBALACCELPRIVATE_DEPRECATED_WARNINGS_SINCE
- -DKGLOBALACCELPRIVATE_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
  - to build KGlobalAccel optionally with deprecated API excluded from the 
build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

TEST PLAN
  Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 4.2.0, 4.3.0,
  4.4.0, 5.9.0, CURRENT.

REPOSITORY
  R268 KGlobalAccel

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24643

AFFECTED FILES
  CMakeLists.txt
  autotests/kglobalshortcuttest.cpp
  src/CMakeLists.txt
  src/kglobalaccel.cpp
  src/kglobalaccel.h
  src/kglobalaccel_p.h
  src/runtime/CMakeLists.txt
  src/runtime/kglobalaccel_interface.h
  src/runtime/kglobalacceld.cpp
  src/runtime/kglobalacceld.h

To: kossebau, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added a comment.


  For the record, I get
  
WARNING: QObject::connect|main QObject::connect: Connecting from COMPAT 
signal (Object::signalIt())
  
  But indeed that's because I build my Qt in debug mode. The only mode that 
truly matters for developers :-)
  
  Maybe Qt shouldn't use QT_NO_DEBUG for this. But oh well, as you noticed all 
of this only matters for the Qt4 macro. Yet another reason to use PMF connect 
instead

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:83c8768b2a70: Fix incorrect margins in 16/22px media 
icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24628?vs=67887=67924

REVISION DETAIL
  https://phabricator.kde.org/D24628

AFFECTED FILES
  icons-dark/actions/16/media-eject.svg
  icons-dark/actions/16/media-mount.svg
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/16/media-record.svg
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-eject.svg
  icons-dark/actions/22/media-mount.svg
  icons-dark/actions/22/media-mout.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons-dark/actions/22/media-record.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons/actions/16/media-eject.svg
  icons/actions/16/media-mount.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/16/media-record.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-eject.svg
  icons/actions/22/media-mount.svg
  icons/actions/22/media-mout.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg
  icons/actions/22/media-record.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

[Thomas Fischer]

thomasfischer edited the summary of this revision.
thomasfischer added reviewers: sitter, kossebau.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24641

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24466#547084 , @dfaure wrote:
  
  > check_and_warn_compat does not warn for this testcase because the slot is 
deprecated too.
  >  Try a deprecated signal and a non-deprecated slot :-)
  >
  >   2714│ if (signal.attributes() & QMetaMethod::Compatibility) {
  >   2715│ if (!(method.attributes() & QMetaMethod::Compatibility))
  >   2716│ qWarning("QObject::connect: Connecting from COMPAT 
signal (%s::%s)",
  >   2717│  sender->className(), 
signal.methodSignature().constData());
  
  
  Ah, missed that combination condition in the code. Though actually, I had 
tested all combinations before, disabling all or either of the QT_MOC_COMPAT 
(as you can see, blackbox testing without looking at the Qt code ;) ) , same 
with Q_DECL_DEPRECATED.  And then read that configure --release sets 
QT_NO_DEBUG, at which point I stopped looking more.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

[Thomas Fischer]

thomasfischer created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
thomasfischer requested review of this revision.

REVISION SUMMARY
  In KBibTeX, there is a `getgit.cmake` 
 file to collect 
information from Git regarding the source's history assuming that the source 
code came from a Git repository. `ECMSourceVersionControl.cmake` can be 
expanded making `getgit.cmake`'s functionality available to all KDE projects.
  Code from KBibTeX's `getgit.cmake` was refactored to fit 
`ECMSourceVersionControl.cmake` and similar code has been added to support 
Subversion and other version control systems.
  
  Different version control systems are supported to different degrees:
  
  - Git is fully supported thanks to the mature code from `getgit.cmake`
  - Subversion is well supported except for the question wheter to use 
`last-changed-revision` or just `revision` and how to correctly compute the 
commit count (some `svn log ... | grep -c ...` won't be available)
  - Mercurial support only covers `ECM_SOURCE_VERSION_CONTROL_BRANCH` but not 
`ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT` or 
`ECM_SOURCE_VERSION_CONTROL_REVISION`
  - Bazaar is virtually incomplete. However, this seems to be a dead project 
anyway.

TEST PLAN
  1. Create a temporary directory and copy either a .git, .svn, or .hg 
directory from another project into this directory.
  2. Copy the patched `ECMSourceVersionControl.cmake` into this temporary 
directory.
  3. Create a `CMakeLists.txt` file which may look like this:
  
cmake_minimum_required(VERSION 3.7.2)
project(ECMSourceVersionControlTest)
find_package(ECM ${KF5_MIN_VERSION} REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR})
include(ECMSourceVersionControl)
message(${ECM_SOURCE_UNDER_VERSION_CONTROL})
message(${ECM_SOURCE_VERSION_CONTROL_REVISION})
message(${ECM_SOURCE_VERSION_CONTROL_BRANCH})
message(${ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT})
  
  In another temporary directory, run `cmake` referring to the first temporary 
directory.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24641

AFFECTED FILES
  modules/ECMSourceVersionControl.cmake

To: thomasfischer
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added a comment.


  Thanks for the investigation.
  
  check_and_warn_compat does not warn for this testcase because the slot is 
deprecated too.
  Try a deprecated signal and a non-deprecated slot :-)
  
2714│ if (signal.attributes() & QMetaMethod::Compatibility) {
2715│ if (!(method.attributes() & QMetaMethod::Compatibility))
2716│ qWarning("QObject::connect: Connecting from COMPAT signal 
(%s::%s)",
2717│  sender->className(), 
signal.methodSignature().constData());

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:7dc38306b5b6: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24465?vs=67718=67921#toc

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24465?vs=67718=67921

REVISION DETAIL
  https://phabricator.kde.org/D24465

AFFECTED FILES
  CMakeLists.txt
  autotests/kstartupinfo_unittest.cpp
  autotests/kwindowsystemx11test.cpp
  autotests/kxmessages_unittest.cpp
  autotests/netwininfotestclient.cpp
  src/CMakeLists.txt
  src/kstartupinfo.cpp
  src/kstartupinfo.h
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h
  src/kwindowsystem_dummy_p.h
  src/kwindowsystem_p.h
  src/netwm_def.h
  src/platforms/osx/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem_p_wayland.h
  src/platforms/windows/kwindowsystem.cpp
  src/platforms/xcb/kkeyserver.cpp
  src/platforms/xcb/kkeyserver_x11.h
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/kwindowsystem_p_x11.h
  src/platforms/xcb/kxmessages.cpp
  src/platforms/xcb/kxmessages.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 266 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/266/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 17:35:06 +
 Build duration:
45 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33967/61585)39%
(17001/43508)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9557/10118)47%
(4457/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8673/14502)51%
(4522/8805)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4680/8302)43%
(2026/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 134 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/134/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 14 Oct 2019 12:09:16 +
 Build duration:
5 hr 28 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 265 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/265/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 15:44:14 +
 Build duration:
1 hr 50 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33954/61586)39%
(16983/43510)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9557/10118)47%
(4461/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8671/14504)51%
(4510/8807)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4674/8302)43%
(2022/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 111 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/111/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 14 Oct 2019 17:22:07 +
 Build duration:
13 min and counting

D24590: Port KSslErrorUiData to QSslError

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:77fce361d9ba: Port KSslErrorUiData to QSslError (authored 
by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24590?vs=67828=67918#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24590?vs=67828=67918

REVISION DETAIL
  https://phabricator.kde.org/D24590

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslerroruidata.cpp
  src/core/ksslerroruidata_p.h
  src/widgets/sslui.cpp

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 70 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/70/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 14:50:55 +
 Build duration:
2 hr 19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.64.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(240/268)90%
(240/268)85%
(27130/32008)53%
(10912/20544)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12455/12530)50%
(6562/13047)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6336/7471)64%
(1824/2828)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7885/9351)64%
(2349/3678)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 94 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 14:50:53 +
 Build duration:
2 hr 11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6884/9077)43%
(10766/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2871/2964)48%
(6168/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24466#546952 , @dfaure wrote:
  
  > Maybe Qt doesn't have any deprecated signals?
  
  
  That would be nice :) A few there are though, e.g. see here some for 
QComboBox, only using `QT_DEPRECATED_SINCE` & `QT_DEPRECATED_VERSION_X`, but 
not `QT_MOC_COMPAT`:
  https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qcombobox.h.html#223
  
  Perhaps people forgot about it, the macro also not being documented anywhere.
  
  Now finally got around to do some test code to check deprecation with 
signal/slots:
  
#include 
#include 
#include 

class Object : public QObject
{
Q_OBJECT

public Q_SLOTS:
Q_DECL_DEPRECATED
QT_MOC_COMPAT
void slotIt() {
qDebug() << "handling signal";
}

Q_SIGNALS:
Q_DECL_DEPRECATED
QT_MOC_COMPAT
void signalIt();
};

int main(int argc, char *argv[])
{
QCoreApplication app(argc, argv);

Object object;
QObject::connect(, SIGNAL(signalIt()), , SLOT(slotIt()));
QObject::connect(, ::signalIt, , ::slotIt);

emit object.signalIt();

return 0;
}

#include "main.moc"
  
  When building this gives:
  
main.cpp: In function ‘int main(int, char**)’:
main.cpp:29:40: warning: ‘void Object::signalIt()’ is deprecated 
[-Wdeprecated-declarations]
   29 | QObject::connect(, ::signalIt, , 
::slotIt);
  |^~~~
main.cpp:20:10: note: declared here
   20 | void signalIt();
  |  ^~~~
main.cpp:29:68: warning: ‘void Object::slotIt()’ is deprecated 
[-Wdeprecated-declarations]
   29 | QObject::connect(, ::signalIt, , 
::slotIt);
  |
^~
main.cpp:13:10: note: declared here
   13 | void slotIt() {
  |  ^~
main.cpp:31:26: warning: ‘void Object::signalIt()’ is deprecated 
[-Wdeprecated-declarations]
   31 | emit object.signalIt();
  |  ^
main.cpp:20:10: note: declared here
   20 | void signalIt();
  |  ^~~~
  
  and when running just
  
handling signal
handling signal
  
  so no runtime warning about the compat signal or slot. Possibly as 
QT_NO_DEBUG is said to be defined for Qt release builds, so 
`check_and_warn_compat` will not be run.
  
  So having a _DEPRECATED with signal makes sense also for consumers connecting 
to the signal with memberfunction-pointer based connect. Will adapt the other 
patches accordingly.
  
  Not sure what to do about the QT_MOC_COMPAT, so far it should not hurt to 
keep them, but the question is how useful adding new ones is and whether this 
is future-proof.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 264 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/264/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 13:58:31 +
 Build duration:
1 hr 45 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33955/61586)39%
(16986/43510)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9557/10118)47%
(4453/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8673/14504)51%
(4514/8807)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4679/8302)43%
(2025/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

D24628: Fix incorrect margins in 16/22px media icons

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24628

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added a comment.


  Maybe Qt doesn't have any deprecated signals?

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 110 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/110/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 14 Oct 2019 13:58:31 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 597 lines...][2019-10-14T14:11:32.822Z] Scanning dependencies of target docs-kcontrol5-smb-index-cache-bz2[2019-10-14T14:11:32.822Z] [  3%] Generating index.cache.bz2[2019-10-14T14:11:32.822Z] Scanning dependencies of target docs-kcontrol5-trash-index-cache-bz2[2019-10-14T14:11:34.022Z] [  3%] Built target docs-kcontrol5-cache-index-cache-bz2[2019-10-14T14:11:34.022Z] [  3%] Generating index.cache.bz2[2019-10-14T14:11:34.022Z] [  3%] Generating index.cache.bz2[2019-10-14T14:11:34.022Z] [  3%] Built target docs-kioslave5-webdav-index-cache-bz2[2019-10-14T14:11:34.022Z] [  3%] Built target docs-kioslave5-telnet-index-cache-bz2[2019-10-14T14:11:34.022Z] Scanning dependencies of target docs-kcontrol5-useragent-index-cache-bz2[2019-10-14T14:11:34.022Z] Scanning dependencies of target docs-kcontrol5-webshortcuts-index-cache-bz2[2019-10-14T14:11:34.022Z] [  3%] Built target docs-kcontrol5-cookies-index-cache-bz2[2019-10-14T14:11:34.603Z] Scanning dependencies of target KF5KIO_QCH[2019-10-14T14:11:34.603Z] [  3%] Generating index.cache.bz2[2019-10-14T14:11:34.603Z] [  3%] Generating index.cache.bz2[2019-10-14T14:11:34.603Z] [  3%] Generating src/KF5KIO.qch, src/KF5KIO.tags[2019-10-14T14:11:35.442Z] [  3%] Built target docs-kcontrol5-netpref-index-cache-bz2[2019-10-14T14:11:35.442Z] Scanning dependencies of target copy_protocols[2019-10-14T14:11:35.442Z] [  3%] Built target docs-kcontrol5-proxy-index-cache-bz2[2019-10-14T14:11:35.442Z] [  3%] Built target copy_protocols[2019-10-14T14:11:35.442Z] [  3%] Built target docs-kcontrol5-trash-index-cache-bz2[2019-10-14T14:11:35.442Z] Scanning dependencies of target protocoltojson_autogen[2019-10-14T14:11:35.965Z] [  3%] Built target docs-kcontrol5-smb-index-cache-bz2[2019-10-14T14:11:35.965Z] Scanning dependencies of target KF5KIONTLM_autogen[2019-10-14T14:11:35.965Z] [  4%] Automatic MOC for target protocoltojson[2019-10-14T14:11:35.965Z] Scanning dependencies of target kded_kcookiejar_autogen[2019-10-14T14:11:35.965Z] Scanning dependencies of target ktelnetservice5_autogen[2019-10-14T14:11:35.965Z] [  4%] Automatic MOC for target KF5KIONTLM[2019-10-14T14:11:36.514Z] [  4%] Automatic MOC for target kded_kcookiejar[2019-10-14T14:11:36.514Z] [  4%] Built target docs-kcontrol5-useragent-index-cache-bz2[2019-10-14T14:11:36.514Z] [  4%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2[2019-10-14T14:11:36.514Z] [  4%] Built target protocoltojson_autogen[2019-10-14T14:11:36.514Z] Scanning dependencies of target kcookiejar5_autogen[2019-10-14T14:11:36.514Z] [  4%] Automatic MOC for target ktelnetservice5[2019-10-14T14:11:36.514Z] [  4%] Built target KF5KIONTLM_autogen[2019-10-14T14:11:37.040Z] [  4%] Built target ktelnetservice5_autogen[2019-10-14T14:11:37.040Z] [  5%] Automatic MOC for target kcookiejar5[2019-10-14T14:11:37.040Z] Scanning dependencies of target httpfiltertest_autogen[2019-10-14T14:11:37.040Z] Scanning dependencies of target httpheadertokenizetest_autogen[2019-10-14T14:11:37.562Z] [  5%] Built target kcookiejar5_autogen[2019-10-14T14:11:37.562Z] [  5%] Automatic MOC for target httpfiltertest[2019-10-14T14:11:37.562Z] Scanning dependencies of target KF5KIOCore_autogen[2019-10-14T14:11:37.562Z] Scanning dependencies of target httpheaderdispositiontest_autogen[2019-10-14T14:11:38.086Z] [  5%] Automatic MOC for target KF5KIOCore[2019-10-14T14:11:38.086Z] [  5%] Automatic MOC for target httpheaderdispositiontest[2019-10-14T14:11:38.086Z] [  5%] Automatic MOC for target httpheadertokenizetest[2019-10-14T14:11:38.086Z] [  5%] Built target kded_kcookiejar_autogen[2019-10-14T14:11:38.882Z] Scanning dependencies of target protocoltojson[2019-10-14T14:11:39.846Z] [  5%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.obj[2019-10-14T14:11:39.846Z] Scanning dependencies of target ktelnetservice5[2019-10-14T14:11:39.846Z] [  5%] Built target httpheadertokenizetest_autogen[2019-10-14T14:11:39.846Z] main.cpp[2019-10-14T14:11:40.409Z] [  5%] Built target httpfiltertest_autogen[2019-10-14T14:11:40.409Z] [  5%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.obj[2019-10-14T14:11:40.409Z] [  5%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.obj[2019-10-14T14:11:40.409Z] [  5%] Built target httpheaderdispositiontest_autogen[2019-10-14T14:11:42.094Z] Scanning dependencies of target KF5KIONTLM[2019-10-14T14:11:42.094Z] [  5%] Generating org.kde.KCookieServer.xml[2019-10-14T14:11:42.094Z] ktelnetservice.cpp[2019-10-14T14:11:42.094Z] [  5%] Building CXX object 

D24631: exclude ioslaves directory from api docs

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d05d03f2f13e: exclude ioslaves directory from api docs 
(authored by sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24631?vs=67895=67900

REVISION DETAIL
  https://phabricator.kde.org/D24631

AFFECTED FILES
  docs/Doxyfile.local

To: sitter, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24631: exclude ioslaves directory from api docs

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  no-slave-dox

REVISION DETAIL
  https://phabricator.kde.org/D24631

To: sitter, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 147 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/147/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 14 Oct 2019 12:09:15 +
 Build duration:
1 hr 10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33957/61587)39%
(16992/43506)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9557/10118)47%
(4461/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8670/14504)51%
(4512/8807)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4679/8302)43%
(2023/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 263 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/263/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 12:09:15 +
 Build duration:
1 hr 6 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(266/405)66%
(266/405)55%
(33952/61586)39%
(16990/43510)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)94%
(9555/10118)47%
(4459/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8671/14504)51%
(4515/8807)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4674/8302)43%
(2022/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in kactioncollection.h:314
> Okay, so "QT_MOC_COMPAT" is still a (just undocumented) thing, and thus 
> something we should use for deprecated signal/slots then as before, right?
> 
> Had now another look based on your info, and found that the magic to map 0x10 
> onto 0x1 happens in the getter of the method attributes:
> 
>   int QMetaMethod::attributes() const
>   {
>   if (!mobj)
>   return false;
>   return ((mobj->d.data[handle + 4])>>4);
>   }
> 
> So that mystery seems solved :)
> 
> For adding deprecation attributes via _DEPRECATED to signals, yes, would 
> agree to do this consistently then, following your argumentation. Will add 
> this to the howtodeprecateallkindsofapi text I yet have to write, so far 
> delayed to first gather experience.

Just remembered though: seems that Qt code itself no longer uses QT_MOC_COMPAT? 
At least I had no hits for actual usages in Qt classes when searching in my 
local Qt headers, via code.woboq.org or github search, there only for the old 
unsplit qt repo (which once made me think this is a Qt3 relict).

And given the `#ifndef QT_NO_DEBUG` does this warning land in normal Qt builds? 
(sorry, not build Qt in a decade). 
till have to test with my openSUSE TW, will do later today.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in kactioncollection.h:314
> Taking this from the other side: warnings when connecting to deprecated 
> signals actually work. They happen in check_and_warn_compat in qobject.cpp
> 
> ... this does support warning about connecting to compat slots, so my comment 
> was bogus, this is fine.
> 
> For the usual case, compat signals, the code checks `signal.attributes() & 
> QMetaMethod::Compatibility`.
> 
> Ah and I found where `MethodCompatibility` (which has the value 0x10) is 
> actually set...
> the generated moc code says
> 
>   6,2,   89,2, 0x06 /* Public */,
>   8,2,   94,2, 0x16 /* Public | MethodCompatibility */,
> 
> See the second line, it has the 0x10 value in there, which means 
> `MethodCompatibility` is set by value, not by name.
> 
> I'm just still a bit confused about the relation between the 0x10 metaobject 
> flag and the signal attribute which has value 0x1...
> 
>   enum Attributes { Compatibility = 0x1, Cloned = 0x2, Scriptable = 0x4 };
> 
> But it must work, tst_qobject.cpp tests that QT_MOC_COMPAT ends up setting 
> `QMetaMethod::Compatibility` in attributes().
> 
> Anyhow, I still believe that using the *_DEPRECATED macro on a signal only 
> makes sense if we want to prevent subclasses from emitting the signal. 
> Theoretical possibility, extremely unlikely for KActionCollection, but... why 
> not. We can do this consistently everywhere without the need to consider the 
> likeliness of subclasses, I suppose.

Okay, so "QT_MOC_COMPAT" is still a (just undocumented) thing, and thus 
something we should use for deprecated signal/slots then as before, right?

Had now another look based on your info, and found that the magic to map 0x10 
onto 0x1 happens in the getter of the method attributes:

  int QMetaMethod::attributes() const
  {
  if (!mobj)
  return false;
  return ((mobj->d.data[handle + 4])>>4);
  }

So that mystery seems solved :)

For adding deprecation attributes via _DEPRECATED to signals, yes, would agree 
to do this consistently then, following your argumentation. Will add this to 
the howtodeprecateallkindsofapi text I yet have to write, so far delayed to 
first gather experience.

REPOSITORY
  R263 KXmlGui

BRANCH
  deprecatedapi

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24631: exclude ioslaves directory from api docs

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24631

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

[Marco Martin]

mart marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24263: edit mode action

[Marco Martin]

mart updated this revision to Diff 67896.
mart added a comment.


  - add ellipsis

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24263?vs=67557=67896

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag abandoned this revision.
zzag added a comment.


  Okay

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Aleix Pol Gonzalez]

apol added a comment.


  It feels weird to create a class directly into KF5 when it hasn't even 
started to be used.
  It could make sense to develop it within some of the apps and when we are 
sure the API is stable and it wants to be used on other components/products, we 
can promote it to the right framework.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: apol, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24630: Replace all qWarning and related calls with categorised logging

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  categorised_logging

REVISION DETAIL
  https://phabricator.kde.org/D24630

To: ahiemstra, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24631: exclude ioslaves directory from api docs

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  they do not feature (public) api

TEST PLAN
  kapidox_generate no longer lists slave classes that happen to have 
documentation

REPOSITORY
  R241 KIO

BRANCH
  no-slave-dox

REVISION DETAIL
  https://phabricator.kde.org/D24631

AFFECTED FILES
  docs/Doxyfile.local

To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

[Ahmad Samir]

ahmadsamir added reviewers: dfaure, vkrause.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24621: [RFC] New Konsole and Yakuake icons

[TrickyRicky]

trickyricky26 requested changes to this revision.
trickyricky26 added a comment.
This revision now requires changes to proceed.


  Before this is can be landed, you will have to also add/change the Konsole 
and Yakuake icons in the icons-dark directory.
  
  While I think these icons do look nice on their own and I quite like the 
clever design of the Yakuake Prompt / "Y" symbol, I don't think they fit the 
Breeze icon style very well. I think they are too boxy and flat (even though 
you used gradients) to fit in. I would suggest you try to use more slim lines, 
similar to the current Konsole icon, as well as gradients with bigger 
differences between the colors.
  
  In D24621#546750 , @ndavis wrote:
  
  > Maybe something like this? I'm not sure. F7592258: 
Screenshot_20191014_011043.png  F7592287: 
konsole.svg 
  
  
  I think these tabs look more Breeze-y, but still the icon looks quite flat 
and imo the thickness of the prompt symbol does not look right for a Breeze 
icon.
  
  In D24621#546750 , @ndavis wrote:
  
  > I think the K in most of the Konsole variants is a bit too much and I think 
it would be too distracting. It's not immediately obvious that it's a K. When I 
look at it, the first thing my eyes see is "**>**__|**<**__", rather than 
"**>**__K__", which is confusing. IIRC the discussion about the redesign of 
these icons started with the problem that they are not recognizable enough as 
standalone apps, not just as genric terminal emulators. I think we should try 
to experiment some more with the "K" symbol until we maybe find a variant that 
we like and fits well enough with other Breeze icons. Otherwise, I don't 
necessarily think F7592258: Screenshot_20191014_011043.png 
  or one of the variant B icons will be 
an improvement over the current Konsole icon, which I personally like because 
of it's simplicity.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24621

To: mglb, #vdg, #konsole, #yakuake, trickyricky26
Cc: trickyricky26, ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

[Ralf Habacker]

habacker updated this revision to Diff 67894.
habacker added a comment.


  - Another attempt after 9 minor releases have elapsed.

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19504?vs=53327=67894

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19504

AFFECTED FILES
  src/khtmlview.cpp
  src/khtmlview.h

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 133 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/133/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 14 Oct 2019 10:58:37 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24630: Replace all qWarning and related calls with categorised logging

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This replaces all uncategorised qWarning() calls with calls to qCWarning(), 
using the 
  kf5.ki18n category for the main warnings, with kf5.ki18n.kuit used for 
warnings 
  produced by the kuit code.

TEST PLAN
  Tests still pass, warnings printed by ki18n during tests now use categorised 
logging.

REPOSITORY
  R249 KI18n

BRANCH
  categorised_logging

REVISION DETAIL
  https://phabricator.kde.org/D24630

AFFECTED FILES
  CMakeLists.txt
  ki18n.categories
  src/CMakeLists.txt
  src/kcatalog.cpp
  src/klocalizedcontext.cpp
  src/klocalizedstring.cpp
  src/kuitmarkup.cpp

To: ahiemstra
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[David Edmundson]

davidedmundson added a comment.


  We have similar code in plasma-workspace/dataengines/time
  
  that has a faux BSD implementation by using a combination of the legacy, but 
working:
  
QDBusConnection dbus = QDBusConnection::sessionBus();
dbus.connect(QString(), QString(), QStringLiteral("org.kde.KTimeZoned"), 
QStringLiteral("timeZoneChanged"), this, SLOT(tzConfigChanged()));
  
  and equally legacy, but working
  
dbus.connect(QStringLiteral("org.kde.Solid.PowerManagement"),
 
QStringLiteral("/org/kde/Solid/PowerManagement/Actions/SuspendSession"),
 
QStringLiteral("org.kde.Solid.PowerManagement.Actions.SuspendSession"),
 QStringLiteral("resumingFromSuspend"),
 this,
 SLOT(clockSkewed()))
  
  Obviously this doesn't cover all the cases (like some ntp service kicking in) 
but it's better than nothing.
  
  ---
  
  AFAIK all the usecases above could use the existing dataengine, but I'm not 
against replacing dataengines with library code.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24629

To: zzag, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c38591b9d2a9: [SslUi] Add api docs for 
askIgnoreSslErrors() (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24588?vs=67834=67892

REVISION DETAIL
  https://phabricator.kde.org/D24588

AFFECTED FILES
  src/widgets/sslui.h

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24629: RFC: Introduce KClockSkewNotifier class

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  The new class provides a way for monitoring system clock changes. This
  class can be useful for applications that build their logic around time,
  for example dynamic wallpapers, so reacting to system clock changes is
  quite crucial for them.
  
  The new class can also be useful for Night Color in KWin and time data
  engine as they two don't have support for FreeBSD. KClockSkewNotifier
  also doesn't have support for FreeBSD at this moment, however when it
  gains that, we'll have to patch only one place rather than two.
  
  All good stuff happens in so called "notifier engines." A notifier
  engine is responsible for detecting system clock changes and all
  platform-specific code must reside there. KClockSkewNotifier is just a
  thin wrapper around the corresponding engine, which is loaded and
  unloaded as needed.
  
  In long term, we need to add a couple more notifier engines. One for
  Windows(?), one for FreeBSD(?), and one that doesn't use any platform
  specific APIs but QTimer.
  
  "KClockSkewNotifier" is not the best name. I'm open to suggestions.

TEST PLAN
  No autotests because setting time requires root privileges.

REPOSITORY
  R244 KCoreAddons

BRANCH
  kclockskewnotifier

REVISION DETAIL
  https://phabricator.kde.org/D24629

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/clock/kclockskewnotifier.cpp
  src/lib/clock/kclockskewnotifier.h
  src/lib/clock/kclockskewnotifierengine.cpp
  src/lib/clock/kclockskewnotifierengine_linux.cpp
  src/lib/clock/kclockskewnotifierengine_linux_p.h
  src/lib/clock/kclockskewnotifierengine_p.h

To: zzag, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19504: Extend KHtmlView::print() to use a predefined QPrinter instance

[Ralf Habacker]

habacker added a comment.


  ping ?

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19504

To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24628

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

ndavis added a dependent revision: D24627: [icons/media.svg] Add 16 & 32px 
icons, update style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24628

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis added a dependency: D24628: Fix incorrect margins in 16/22px media icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24628: Fix incorrect margins in 16/22px media icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For some reason, the margins on these icons were 1 px larger on each side 
than they were supposed to be.

REPOSITORY
  R266 Breeze Icons

BRANCH
  media-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24628

AFFECTED FILES
  icons-dark/actions/16/media-eject.svg
  icons-dark/actions/16/media-mount.svg
  icons-dark/actions/16/media-playback-pause.svg
  icons-dark/actions/16/media-playback-start.svg
  icons-dark/actions/16/media-playback-stop.svg
  icons-dark/actions/16/media-record.svg
  icons-dark/actions/16/media-seek-backward.svg
  icons-dark/actions/16/media-seek-forward.svg
  icons-dark/actions/16/media-skip-backward.svg
  icons-dark/actions/16/media-skip-forward.svg
  icons-dark/actions/22/media-eject.svg
  icons-dark/actions/22/media-mount.svg
  icons-dark/actions/22/media-mout.svg
  icons-dark/actions/22/media-playback-pause.svg
  icons-dark/actions/22/media-playback-start.svg
  icons-dark/actions/22/media-playback-stop.svg
  icons-dark/actions/22/media-record.svg
  icons-dark/actions/22/media-seek-backward.svg
  icons-dark/actions/22/media-seek-forward.svg
  icons-dark/actions/22/media-skip-backward.svg
  icons-dark/actions/22/media-skip-forward.svg
  icons/actions/16/media-eject.svg
  icons/actions/16/media-mount.svg
  icons/actions/16/media-playback-pause.svg
  icons/actions/16/media-playback-start.svg
  icons/actions/16/media-playback-stop.svg
  icons/actions/16/media-record.svg
  icons/actions/16/media-seek-backward.svg
  icons/actions/16/media-seek-forward.svg
  icons/actions/16/media-skip-backward.svg
  icons/actions/16/media-skip-forward.svg
  icons/actions/22/media-eject.svg
  icons/actions/22/media-mount.svg
  icons/actions/22/media-mout.svg
  icons/actions/22/media-playback-pause.svg
  icons/actions/22/media-playback-start.svg
  icons/actions/22/media-playback-stop.svg
  icons/actions/22/media-record.svg
  icons/actions/22/media-seek-backward.svg
  icons/actions/22/media-seek-forward.svg
  icons/actions/22/media-skip-backward.svg
  icons/actions/22/media-skip-forward.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 261 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/261/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 10:11:56 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/404)66%
(265/404)55%
(33934/61462)39%
(16985/43406)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9534/9993)47%
(4452/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8673/14504)51%
(4513/8807)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4675/8302)43%
(2023/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4292)36%
(1303/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24627

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24627: [icons/media.svg] Add 16 & 32px icons, update style

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Fixes blurry icons in the desktop shell

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  media-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24627

AFFECTED FILES
  src/desktoptheme/breeze/icons/media.svg

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 145 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/145/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 14 Oct 2019 10:11:56 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.64.0.xmllogs/KF5KIO/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/404)66%
(265/404)55%
(33935/61461)39%
(16972/43402)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9534/9993)47%
(4443/9452)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8665/14503)51%
(4510/8807)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4679/8302)43%
(2023/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1209)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1357)0%
(0/1408)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1801/4292)36%
(1301/3606)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(632/1333)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 107 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/107/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 14 Oct 2019 10:11:56 +
 Build duration:
10 min and counting

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 132 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/132/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 14 Oct 2019 10:11:56 +
 Build duration:
9 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24558: fix proxy setting loading

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d1a3b9d08158: fix proxy setting loading (authored by 
sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24558?vs=67702=67880

REVISION DETAIL
  https://phabricator.kde.org/D24558

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c904cbcb9876: simplify the url parsing (authored by 
sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24559?vs=67703=67881

REVISION DETAIL
  https://phabricator.kde.org/D24559

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24560: remove legacy space handling code

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c372fa3c4236: remove legacy space handling code (authored 
by sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24560?vs=67704=67882

REVISION DETAIL
  https://phabricator.kde.org/D24560

AFFECTED FILES
  src/kcms/kio/kproxydlg.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: port ftp slave to new error reporting system

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
sitter marked 3 inline comments as done.
Closed by commit R241:c86eedf0f92d: port ftp slave to new error reporting 
system (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23579?vs=67697=67883#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23579?vs=67697=67883

REVISION DETAIL
  https://phabricator.kde.org/D23579

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ftp/testCopy1
  autotests/ftp/testCopy2
  autotests/ftp/testOverwriteCopy1
  autotests/ftp/testOverwriteCopy2
  autotests/ftpd
  autotests/ftptest.cpp
  cmake/FindGem.cmake
  cmake/FindGem.cmake.in
  cmake/FindRubyExe.cmake
  src/ioslaves/ftp/ProxyTesting.md
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/ftp/ftp.h

To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 106 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/106/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 14 Oct 2019 10:03:06 +
 Build duration:
3 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 384 lines...][2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5ItemViews.tags" found for KF5ItemViews_QCH when calling ecm_add_qch().[2019-10-14T10:06:29.014Z] CMake Warning at C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-14T10:06:29.014Z]   No linking to API dox of KF5ItemViews_QCH.[2019-10-14T10:06:29.014Z] Call Stack (most recent call first):[2019-10-14T10:06:29.014Z]   C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-14T10:06:29.014Z]   src/CMakeLists.txt:62 (ecm_add_qch)[2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5XmlGui.tags" found for KF5XmlGui_QCH when calling ecm_add_qch().[2019-10-14T10:06:29.014Z] CMake Warning at C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-14T10:06:29.014Z]   No linking to API dox of KF5XmlGui_QCH.[2019-10-14T10:06:29.014Z] Call Stack (most recent call first):[2019-10-14T10:06:29.014Z]   C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-14T10:06:29.014Z]   src/CMakeLists.txt:62 (ecm_add_qch)[2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5Solid.tags" found for KF5Solid_QCH when calling ecm_add_qch().[2019-10-14T10:06:29.014Z] CMake Warning at C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-14T10:06:29.014Z]   No linking to API dox of KF5Solid_QCH.[2019-10-14T10:06:29.014Z] Call Stack (most recent call first):[2019-10-14T10:06:29.014Z]   C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-14T10:06:29.014Z]   src/CMakeLists.txt:62 (ecm_add_qch)[2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.[2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5Config.tags" found for KF5Config_QCH when calling ecm_add_qch().[2019-10-14T10:06:29.014Z] CMake Warning at C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-14T10:06:29.014Z]   No linking to API dox of KF5Config_QCH.[2019-10-14T10:06:29.014Z] Call Stack (most recent call first):[2019-10-14T10:06:29.014Z]   C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-14T10:06:29.014Z]   src/CMakeLists.txt:62 (ecm_add_qch)[2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such target Qt5Gui_QCH defined when calling ecm_add_qch(), ignored.[2019-10-14T10:06:29.014Z] -- No such target Qt5Xml_QCH defined when calling ecm_add_qch(), ignored.[2019-10-14T10:06:29.014Z] -- No such target Qt5DBus_QCH defined when calling ecm_add_qch(), ignored.[2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5ConfigWidgets.tags" found for KF5ConfigWidgets_QCH when calling ecm_add_qch().[2019-10-14T10:06:29.014Z] CMake Warning at C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-14T10:06:29.014Z]   No linking to API dox of KF5ConfigWidgets_QCH.[2019-10-14T10:06:29.014Z] Call Stack (most recent call first):[2019-10-14T10:06:29.014Z]   C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-14T10:06:29.014Z]   src/CMakeLists.txt:62 (ecm_add_qch)[2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5Codecs.tags" found for KF5Codecs_QCH when calling ecm_add_qch().[2019-10-14T10:06:29.014Z] CMake Warning at C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:395 (message):[2019-10-14T10:06:29.014Z]   No linking to API dox of KF5Codecs_QCH.[2019-10-14T10:06:29.014Z] Call Stack (most recent call first):[2019-10-14T10:06:29.014Z]   C:/CI/Software Installs/kio/share/ECM/modules/ECMAddQch.cmake:578 (_ecm_collect_linkable_qch_targets)[2019-10-14T10:06:29.014Z]   src/CMakeLists.txt:62 (ecm_add_qch)[2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] [2019-10-14T10:06:29.014Z] -- No such tag file "C:/CI/Software Installs/Dependencies/bin/data/doc/qch/KF5Auth.tags" found for KF5Auth_QCH when calling 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 144 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/144/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 14 Oct 2019 10:03:06 +
 Build duration:
1 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 311 lines...][2019-10-14T10:04:31.354Z] -- Looking for volmgt_running in volmgt - not found[2019-10-14T10:04:31.354Z] -- Performing Test GETMNTINFO_USES_STATVFS[2019-10-14T10:04:31.354Z] -- Performing Test GETMNTINFO_USES_STATVFS - Failed[2019-10-14T10:04:31.354Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-14T10:04:31.354Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-14T10:04:31.354Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-14T10:04:31.609Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-14T10:04:31.609Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-14T10:04:31.609Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-14T10:04:31.609Z] -- Looking for include file sys/time.h[2019-10-14T10:04:31.609Z] -- Looking for include file sys/time.h - found[2019-10-14T10:04:31.609Z] -- Looking for include file string.h[2019-10-14T10:04:31.609Z] -- Looking for include file string.h - found[2019-10-14T10:04:31.609Z] -- Looking for include file limits.h[2019-10-14T10:04:31.866Z] -- Looking for include file limits.h - found[2019-10-14T10:04:31.866Z] -- Looking for sendfile[2019-10-14T10:04:31.866Z] -- Looking for sendfile - found[2019-10-14T10:04:31.866Z] -- Looking for posix_fadvise[2019-10-14T10:04:31.866Z] -- Looking for posix_fadvise - found[2019-10-14T10:04:31.866Z] -- Performing Test HAVE_DIRENT_D_TYPE[2019-10-14T10:04:31.866Z] -- Performing Test HAVE_DIRENT_D_TYPE - Success[2019-10-14T10:04:31.866Z] -- Performing Test HAVE_STATX[2019-10-14T10:04:32.122Z] -- Performing Test HAVE_STATX - Success[2019-10-14T10:04:32.122Z] -- Found LibXslt: /usr/lib64/libxslt.so (found version "1.1.33") [2019-10-14T10:04:32.122Z] -- Found LibXml2: /usr/lib64/libxml2.so (found version "2.9.9") [2019-10-14T10:04:32.122Z] -- Looking for include file stdio.h[2019-10-14T10:04:32.122Z] -- Looking for include file stdio.h - found[2019-10-14T10:04:32.122Z] -- Looking for include file stdlib.h[2019-10-14T10:04:32.122Z] -- Looking for include file stdlib.h - found[2019-10-14T10:04:32.122Z] -- Looking for include file sys/stat.h[2019-10-14T10:04:32.122Z] -- Looking for include file sys/stat.h - found[2019-10-14T10:04:32.122Z] -- Looking for strtoll[2019-10-14T10:04:32.378Z] -- Looking for strtoll - found[2019-10-14T10:04:32.378Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/build/src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:32.378Z] -- Looking for include file sys/time.h[2019-10-14T10:04:32.378Z] -- Looking for include file sys/time.h - found[2019-10-14T10:04:32.378Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/build/src/kiod/org.kde.kiod5.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:32.378Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/build/src/kssld/org.kde.kssld5.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:32.378Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/build/src/kpasswdserver/org.kde.kpasswdserver.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:32.378Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/build/src/kioexec/org.kde.kioexecd.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:32.378Z] -- Looking for include file arpa/nameser_compat.h[2019-10-14T10:04:32.378Z] -- Looking for include file arpa/nameser_compat.h - found[2019-10-14T10:04:32.378Z] -- Looking for include file arpa/nameser8_compat.h[2019-10-14T10:04:32.378Z] -- Looking for include file arpa/nameser8_compat.h - not found[2019-10-14T10:04:32.378Z] -- Looking for include files sys/types.h, netinet/in.h[2019-10-14T10:04:32.638Z] -- Looking for include files sys/types.h, netinet/in.h - found[2019-10-14T10:04:32.638Z] -- Looking for include file stdint.h[2019-10-14T10:04:32.638Z] -- Looking for include file stdint.h - found[2019-10-14T10:04:32.638Z] -- Looking for res_init in resolv[2019-10-14T10:04:32.638Z] -- Looking for res_init in resolv - not found[2019-10-14T10:04:32.638Z] -- Looking for __res_init in resolv[2019-10-14T10:04:32.638Z] -- Looking for __res_init in resolv - found[2019-10-14T10:04:32.638Z] -- Looking for gethostbyname in nsl[2019-10-14T10:04:32.638Z] -- Looking for gethostbyname in nsl - not found[2019-10-14T10:04:32.638Z] -- Looking for connect in socket[2019-10-14T10:04:32.638Z] -- Looking 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 260 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/260/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 14 Oct 2019 10:03:06 +
 Build duration:
1 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 311 lines...][2019-10-14T10:04:36.933Z] -- Looking for volmgt_running in volmgt - not found[2019-10-14T10:04:36.933Z] -- Performing Test GETMNTINFO_USES_STATVFS[2019-10-14T10:04:36.933Z] -- Performing Test GETMNTINFO_USES_STATVFS - Failed[2019-10-14T10:04:36.933Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-10-14T10:04:36.933Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-10-14T10:04:36.933Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-10-14T10:04:37.189Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-10-14T10:04:37.189Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-10-14T10:04:37.189Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-10-14T10:04:37.189Z] -- Looking for include file sys/time.h[2019-10-14T10:04:37.444Z] -- Looking for include file sys/time.h - found[2019-10-14T10:04:37.444Z] -- Looking for include file string.h[2019-10-14T10:04:37.444Z] -- Looking for include file string.h - found[2019-10-14T10:04:37.444Z] -- Looking for include file limits.h[2019-10-14T10:04:37.444Z] -- Looking for include file limits.h - found[2019-10-14T10:04:37.444Z] -- Looking for sendfile[2019-10-14T10:04:37.444Z] -- Looking for sendfile - found[2019-10-14T10:04:37.444Z] -- Looking for posix_fadvise[2019-10-14T10:04:37.444Z] -- Looking for posix_fadvise - found[2019-10-14T10:04:37.444Z] -- Performing Test HAVE_DIRENT_D_TYPE[2019-10-14T10:04:37.700Z] -- Performing Test HAVE_DIRENT_D_TYPE - Success[2019-10-14T10:04:37.700Z] -- Performing Test HAVE_STATX[2019-10-14T10:04:37.700Z] -- Performing Test HAVE_STATX - Success[2019-10-14T10:04:37.700Z] -- Found LibXslt: /usr/lib64/libxslt.so (found version "1.1.33") [2019-10-14T10:04:37.700Z] -- Found LibXml2: /usr/lib64/libxml2.so (found version "2.9.9") [2019-10-14T10:04:37.700Z] -- Looking for include file stdio.h[2019-10-14T10:04:37.958Z] -- Looking for include file stdio.h - found[2019-10-14T10:04:37.958Z] -- Looking for include file stdlib.h[2019-10-14T10:04:37.958Z] -- Looking for include file stdlib.h - found[2019-10-14T10:04:37.958Z] -- Looking for include file sys/stat.h[2019-10-14T10:04:37.958Z] -- Looking for include file sys/stat.h - found[2019-10-14T10:04:37.958Z] -- Looking for strtoll[2019-10-14T10:04:37.958Z] -- Looking for strtoll - found[2019-10-14T10:04:37.958Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/build/src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:37.958Z] -- Looking for include file sys/time.h[2019-10-14T10:04:37.958Z] -- Looking for include file sys/time.h - found[2019-10-14T10:04:37.958Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/build/src/kiod/org.kde.kiod5.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:37.958Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/build/src/kssld/org.kde.kssld5.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:37.958Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/build/src/kpasswdserver/org.kde.kpasswdserver.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:38.214Z] -- generating /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.12/build/src/kioexec/org.kde.kioexecd.service from /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5dbus.service.in[2019-10-14T10:04:38.214Z] -- Looking for include file arpa/nameser_compat.h[2019-10-14T10:04:38.214Z] -- Looking for include file arpa/nameser_compat.h - found[2019-10-14T10:04:38.214Z] -- Looking for include file arpa/nameser8_compat.h[2019-10-14T10:04:38.214Z] -- Looking for include file arpa/nameser8_compat.h - not found[2019-10-14T10:04:38.214Z] -- Looking for include files sys/types.h, netinet/in.h[2019-10-14T10:04:38.214Z] -- Looking for include files sys/types.h, netinet/in.h - found[2019-10-14T10:04:38.214Z] -- Looking for include file stdint.h[2019-10-14T10:04:38.214Z] -- Looking for include file stdint.h - found[2019-10-14T10:04:38.214Z] -- Looking for res_init in resolv[2019-10-14T10:04:38.214Z] -- Looking for res_init in resolv - not found[2019-10-14T10:04:38.214Z] -- Looking for __res_init in resolv[2019-10-14T10:04:38.469Z] -- Looking for __res_init in resolv - found[2019-10-14T10:04:38.469Z] -- Looking for gethostbyname in nsl[2019-10-14T10:04:38.469Z] -- Looking for gethostbyname in nsl - not found[2019-10-14T10:04:38.469Z] -- Looking for connect in socket[2019-10-14T10:04:38.469Z] -- Looking 

D24465: Use ECMGenerateExportHeader to manage deprecated API better

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24465

To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24625

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24625: Fill middle mouse button area

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The negative space in the middle didn't quite look right

REPOSITORY
  R266 Breeze Icons

BRANCH
  adjust-mmb (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24625

AFFECTED FILES
  icons-dark/actions/16/input-mouse-click-middle.svg
  icons-dark/actions/22/input-mouse-click-middle.svg
  icons/actions/16/input-mouse-click-middle.svg
  icons/actions/22/input-mouse-click-middle.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24560: remove legacy space handling code

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  If you say so :-)

REPOSITORY
  R241 KIO

BRANCH
  remove-dead-proxy-load-code

REVISION DETAIL
  https://phabricator.kde.org/D24560

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24590: Port KSslErrorUiData to QSslError

[Volker Krause]

vkrause added a comment.


  In D24590#546528 , @aacid wrote:
  
  > Do we have tests for the thing you discovered breaks? Do we need them?
  
  
  There's almost no test coverage for this unfortunately, and yes, I'd feel 
much better if we had that. I looked at adding tests as part of this work, but 
unfortunately that is rather complicated as there is a D-Bus daemon involved.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24590

To: vkrause, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24588: [SslUi] Add api docs for askIgnoreSslErrors()

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/ktcpsocket-qsslsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24588

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24612: Use the text rather than highlight color for rating/star emblem

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  This icon never needed to be blue. I think I just kept it blue because that's 
what it was originally.

REPOSITORY
  R266 Breeze Icons

BRANCH
  monochrome-rating-emblem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24612

To: ngraham, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns