KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 79 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/79/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 11 Nov 2019 04:23:02 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.65.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(453/2036)18%
(170/939)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)98%
(143/146)57%
(52/92)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
(23/38)src.plugins.telegram0%
(0/1)0%

D25249: KDirModel: port to qCDebug, with its own category

2019-11-10 Thread David Faure 
dfaure created this revision.
dfaure added reviewers: mlaurent, sandsmark.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds, and I was able to enable this category in kdebugsettings
  and see the debug output from _k_slotNewItems printed out.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25249

AFFECTED FILES
  kio.categories
  src/widgets/kdirmodel.cpp

To: dfaure, mlaurent, sandsmark
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-10 Thread Noah Davis 
ndavis added a comment.


  In D25226#560363 , @ngraham wrote:
  
  > Or maybe should the UI be changed to show a clickable link and an "edit" 
button that temporarily turns it into a text field that lets you edit it?
  
  
  So like this?
  
  __​/media/external-drive/Pictures__ ​ {icon pencil-square-o}

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

2019-11-10 Thread Noah Davis 
ndavis added inline comments.

INLINE COMMENTS

> kpropertiesdialog.cpp:1120
> +QPushButton *goThereButton = new QPushButton(d->m_frame);
> +goThereButton->setIcon(QIcon::fromTheme(QStringLiteral("go-next")));
> +

`go-jump` is more semantically correct.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25226

To: ngraham, #vdg, #frameworks
Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

2019-11-10 Thread Konrad Materka 
kmaterka added inline comments.

INLINE COMMENTS

> kdeplatformsystemtrayicon.cpp:191
> +if (!m_visible.isNull()) {
> +m_menu->setVisible(m_visible.value());
> +}

This line was causing issues, even if menu is (or should be) visible, setting 
true has side effects.
I checked the code of QMenu, QPlatformMenu::setVisible is never used anyway...

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: cgiboudeaux, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25223: Avoid side effects during menu initialization

2019-11-10 Thread Konrad Materka 
kmaterka updated this revision to Diff 69548.
kmaterka added a comment.


  Use QVariant for tri-state boolean. This way atributes are set only when they 
were really changed in the past.

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25223?vs=69489&id=69548

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25223

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp
  src/platformtheme/kdeplatformsystemtrayicon.h

To: kmaterka, #plasma, #frameworks, broulik
Cc: cgiboudeaux, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 154 - Failure!

2019-11-10 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/154/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 16:55:18 +
 Build duration:
1 hr 44 min and counting
   CONSOLE OUTPUT
  [...truncated 616 lines...][2019-11-10T18:39:29.039Z] [  3%] Built target copy_protocols[2019-11-10T18:39:29.039Z] [  4%] Automatic MOC for target protocoltojson[2019-11-10T18:39:29.039Z] Scanning dependencies of target kded_kcookiejar_autogen[2019-11-10T18:39:29.040Z] [  4%] Automatic MOC for target KF5KIONTLM[2019-11-10T18:39:29.301Z] [  4%] Built target docs-kioslave5-mailto-index-cache-bz2[2019-11-10T18:39:29.301Z] Scanning dependencies of target kcookiejar5_autogen[2019-11-10T18:39:29.301Z] [  4%] Automatic MOC for target kded_kcookiejar[2019-11-10T18:39:29.301Z] [  5%] Automatic MOC for target kcookiejar5[2019-11-10T18:39:29.301Z] [  5%] Built target protocoltojson_autogen[2019-11-10T18:39:29.566Z] Scanning dependencies of target ktelnetservice5_autogen[2019-11-10T18:39:29.566Z] [  5%] Built target KF5KIONTLM_autogen[2019-11-10T18:39:29.836Z] [  5%] Built target kcookiejar5_autogen[2019-11-10T18:39:29.836Z] Scanning dependencies of target httpheadertokenizetest_autogen[2019-11-10T18:39:29.836Z] Scanning dependencies of target httpfiltertest_autogen[2019-11-10T18:39:29.836Z] [  5%] Automatic MOC for target ktelnetservice5[2019-11-10T18:39:29.836Z] [  5%] Automatic MOC for target httpfiltertest[2019-11-10T18:39:29.836Z] [  5%] Automatic MOC for target httpheadertokenizetest[2019-11-10T18:39:30.097Z] Scanning dependencies of target httpheaderdispositiontest_autogen[2019-11-10T18:39:30.097Z] [  5%] Built target ktelnetservice5_autogen[2019-11-10T18:39:30.356Z] [  5%] Automatic MOC for target httpheaderdispositiontest[2019-11-10T18:39:30.356Z] [  5%] Built target docs-kcontrol5-webshortcuts-index-cache-bz2[2019-11-10T18:39:30.356Z] Scanning dependencies of target KF5KIOCore_autogen[2019-11-10T18:39:30.356Z] [  5%] Built target docs-kcontrol5-smb-index-cache-bz2[2019-11-10T18:39:30.621Z] [  5%] Built target docs-kcontrol5-trash-index-cache-bz2[2019-11-10T18:39:30.621Z] [  5%] Built target docs-kcontrol5-proxy-index-cache-bz2[2019-11-10T18:39:30.621Z] [  5%] Built target kded_kcookiejar_autogen[2019-11-10T18:39:30.621Z] [  5%] Built target docs-kcontrol5-useragent-index-cache-bz2[2019-11-10T18:39:30.621Z] [  5%] Generating org.kde.KCookieServer.xml[2019-11-10T18:39:30.621Z] [  5%] Automatic MOC for target KF5KIOCore[2019-11-10T18:39:30.621Z] Scanning dependencies of target protocoltojson[2019-11-10T18:39:30.621Z] [  5%] Built target docs-kcontrol5-netpref-index-cache-bz2[2019-11-10T18:39:30.621Z] [  5%] Generating org.kde.KCookieServer.xml[2019-11-10T18:39:30.621Z] Scanning dependencies of target KF5KIONTLM[2019-11-10T18:39:30.889Z] [  5%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h[2019-11-10T18:39:30.889Z] [  5%] Built target httpheadertokenizetest_autogen[2019-11-10T18:39:30.889Z] qdbusxml2cpp: Cannot process input: 'C:/CI/workspace/Frameworks/kio/kf5-qt5 WindowsMSVCQt5.13/build/src/ioslaves/http/kcookiejar/org.kde.KCookieServer.xml'. Stop.[2019-11-10T18:39:30.889Z] Scanning dependencies of target ktelnetservice5[2019-11-10T18:39:30.889Z] [  5%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/main.cpp.obj[2019-11-10T18:39:30.889Z] jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.13\build\src\ioslaves\http\kcookiejar\CMakeFiles\kcookiejar5.dir\build.make [src\ioslaves\http\kcookiejar\kcookieserverinterface.cpp] Error 1[2019-11-10T18:39:30.889Z] jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.13\build\CMakeFiles\Makefile2 [src\ioslaves\http\kcookiejar\CMakeFiles\kcookiejar5.dir\all] Error 2[2019-11-10T18:39:30.889Z] [  6%] Built target httpheaderdispositiontest_autogen[2019-11-10T18:39:30.889Z] main.cpp[2019-11-10T18:39:30.889Z] [  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/KF5KIONTLM_autogen/mocs_compilation.cpp.obj[2019-11-10T18:39:30.889Z] [  5%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/kntlm.cpp.obj[2019-11-10T18:39:30.889Z] [  6%] Building CXX object src/kntlm/CMakeFiles/KF5KIONTLM.dir/des.cpp.obj[2019-11-10T18:39:30.889Z] [  6%] Generating kcookieserveradaptor.cpp, kcookieserveradaptor.h[2019-11-10T18:39:31.148Z] [  6%] Building CXX object src/protocoltojson/CMakeFiles/protocoltojson.dir/protocoltojson_autogen/mocs_compilation.cpp.obj[2019-11-10T18:39:31.148Z] kntlm.cpp[2019-11-10T18:39:31.148Z] [  6%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice.cpp.obj[2019-11-10T18:39:31.148Z] ktelnetservice.cpp[2019-11-10T18:39:31.148Z] Scanning dependencies of target httpheadertokenizetest[2019-11-10T18:39:31.423Z] [  6%] Building CXX object src/ioslaves/telnet/CMakeFiles/ktelnetservice5.dir/ktelnetservice5_autogen/mocs_compilation.cpp.obj[2019-11-10T18:39:31.698Z] [  6%] Built target httpfil

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-10 Thread Christoph Cullmann 
cullmann added reviewers: Frameworks, vonreth.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25244

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-10 Thread Christoph Cullmann 
cullmann created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  Provide ISpellChecker backend for Sonnet on Windows
  This avoids to ship all the hunspell dictionaries for Windows.

REPOSITORY
  R246 Sonnet

BRANCH
  sonnet_ispellchecker_win

REVISION DETAIL
  https://phabricator.kde.org/D25244

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/ispellchecker/CMakeLists.txt
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerclient.h
  src/plugins/ispellchecker/ispellcheckerdict.cpp
  src/plugins/ispellchecker/ispellcheckerdict.h

To: cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 179 - Still Unstable!

2019-11-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/179/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 10 Nov 2019 17:40:22 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 178 - Still Unstable!

2019-11-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/178/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 10 Nov 2019 16:03:23 +
 Build duration:
1 hr 36 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25236: Remove the last traces of KSslError from TCPSlaveBase

2019-11-10 Thread Volker Krause 
vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25236

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d074873f4703: Port ssl_cert_errors meta data from 
KSslError to QSslError (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24980?vs=69534&id=69536

REVISION DETAIL
  https://phabricator.kde.org/D24980

AFFECTED FILES
  src/core/ksslerror_p.h
  src/core/tcpslavebase.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-10 Thread Volker Krause 
vkrause added a task: T11544: Remove KTcpSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25237

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-10 Thread Volker Krause 
vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25237

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Nicolas Fella 
nicolasfella accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause 
vkrause updated this revision to Diff 69534.
vkrause added a comment.


  bump the right version numbers, sorry

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24980?vs=69531&id=69534

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D24980

AFFECTED FILES
  src/core/ksslerror_p.h
  src/core/tcpslavebase.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Nicolas Fella 
nicolasfella added inline comments.

INLINE COMMENTS

> ksslinfodialog.h:113
>  
> -static QList > errorsFromString(const QString 
> &s);
> +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64)
> +/** @deprecated since 5.64, use certificateErrorsFromString */

You missed a spot

REPOSITORY
  R241 KIO

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause 
vkrause updated this revision to Diff 69531.
vkrause added a comment.


  bump deprecation version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24980?vs=69526&id=69531

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D24980

AFFECTED FILES
  src/core/ksslerror_p.h
  src/core/tcpslavebase.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-10 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  We have ported usage of those to their Qt equivalents now, so what remains
  here is just the removal of all this with KF6 I think.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D25237

AFFECTED FILES
  src/core/ktcpsocket.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Nicolas Fella 
nicolasfella added inline comments.

INLINE COMMENTS

> ksslinfodialog.h:113
>  
> -static QList > errorsFromString(const QString 
> &s);
> +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64)
> +/** @deprecated since 5.64, use certificateErrorsFromString */

Shouldn't this be 65 now?

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24980

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8b206d84efb6: Deprecate KTcpSocket overload of 
KSslErrorUiData ctor (authored by nicolasfella).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25234?vs=69528&id=69529

REVISION DETAIL
  https://phabricator.kde.org/D25234

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/ksslerroruidata.h

To: nicolasfella, #frameworks, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Nicolas Fella 
nicolasfella edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25234

To: nicolasfella, #frameworks
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  dpe

REVISION DETAIL
  https://phabricator.kde.org/D25234

To: nicolasfella, #frameworks, vkrause
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 69528.
nicolasfella added a comment.


  - Add 5.65 to deprecation versions

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25234?vs=69522&id=69528

BRANCH
  dpe

REVISION DETAIL
  https://phabricator.kde.org/D25234

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/ksslerroruidata.h

To: nicolasfella, #frameworks
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Nicolas Fella 
nicolasfella retitled this revision from "[WIP] Deprecate KTcpSocket overload 
of KSslErrorUiData ctor" to "Deprecate KTcpSocket overload of KSslErrorUiData 
ctor".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25234

To: nicolasfella, #frameworks
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25236: Remove the last traces of KSslError from TCPSlaveBase

2019-11-10 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D25236

AFFECTED FILES
  src/core/tcpslavebase.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause 
vkrause updated this revision to Diff 69526.
vkrause added a comment.


  rebase to latest master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24980?vs=69514&id=69526

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24980

AFFECTED FILES
  src/core/ksslerror_p.h
  src/core/tcpslavebase.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Volker Krause 
vkrause added a comment.


  I suspect src/core/CMakeLists.txt:139

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25234

To: nicolasfella, #frameworks
Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25225: Symlink microphone to audio-input-microphone on all sizes

2019-11-10 Thread Luigi Toscano 
This revision was automatically updated to reflect the committed changes.
Closed by commit R267:99f892b26058: Symlink microphone to 
audio-input-microphone on all sizes (authored by ltoscano).

REPOSITORY
  R267 Oxygen Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25225?vs=69492&id=69525

REVISION DETAIL
  https://phabricator.kde.org/D25225

AFFECTED FILES
  128x128/devices/microphone.png
  48x48/devices/microphone.png
  64x64/devices/microphone.png

To: ltoscano, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D20508: [udisks2] fix media change detection for external optical drives

2019-11-10 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I'm very sorry that this patch appears to have been lost along the way. I've 
tested it and it works for me. @bruns, are you okay with this?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20508

To: rokmandeljc, bruns, broulik, dfaure, #frameworks, ngraham
Cc: ngraham, bugseforuns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

2019-11-10 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  This does not build as-is, but I don't understand why

REPOSITORY
  R241 KIO

BRANCH
  dpe

REVISION DETAIL
  https://phabricator.kde.org/D25234

AFFECTED FILES
  src/core/ksslerroruidata.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 151 - Successful!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/151/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 08:37:39 +
 Build duration:
5 hr 46 min and counting

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.13 - Build # 25 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.13/25/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 07:43:34 +
 Build duration:
6 hr 33 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 491 test(s)

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/31/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 08:12:38 +
 Build duration:
6 hr 1 min and counting

KDE CI: Frameworks » kdoctools » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20WindowsMSVCQt5.13/18/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 08:12:37 +
 Build duration:
5 hr 58 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/26/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 08:12:35 +
 Build duration:
5 hr 55 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kinit » kf5-qt5 WindowsMSVCQt5.13 - Build # 16 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20WindowsMSVCQt5.13/16/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 08:12:34 +
 Build duration:
5 hr 52 min and counting

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.13 - Build # 87 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.13/87/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 08:12:33 +
 Build duration:
5 hr 46 min and counting

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 64 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/64/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 07:30:43 +
 Build duration:
6 hr 24 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)

D25233: [kded] Port plugin metadata to JSON

2019-11-10 Thread Nicolas Fella 
nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.
nicolasfella added reviewers: Frameworks, dantti.

REPOSITORY
  R363 Print Manager

REVISION DETAIL
  https://phabricator.kde.org/D25233

To: nicolasfella, #frameworks, dantti
Cc: kde-utils-devel

D25233: [kded] Port plugin metadata to JSON

2019-11-10 Thread Nicolas Fella 
nicolasfella added a task: T11919: Port KDED modules from .desktop files to 
JSON metadata.

REPOSITORY
  R363 Print Manager

REVISION DETAIL
  https://phabricator.kde.org/D25233

To: nicolasfella, #frameworks, dantti
Cc: kde-utils-devel

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Unstable!

2019-11-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/26/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 06:37:14 +
 Build duration:
6 hr 47 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.persondatatest

Re: New Framework Review: KDAV

2019-11-10 Thread David Faure 
On samedi 9 novembre 2019 21:14:46 CET Alexander Potashev wrote:
> сб, 9 нояб. 2019 г. в 14:37, Volker Krause :
> > during Akademy there was a request to promote KDAV from KDE PIM to
> > Frameworks for use by Plasma Mobile. KDAV is a framework that implements
> > the CalDav/ CardDav/GroupDav protocol on top of KIO's WebDav support. It
> > would be classified as a functional tier 3 framework.
> 
> Hi Volker,
> 
> The name "KDAV" suggests that it might implement WebDAV. Do you think
> if it should be renamed to something like "DAVExtensions" or let's say
> "AnyDAV"?

The name seems fine to me. The substring "DAV" appears just as much in WebDAV 
as it does in CalDav/CardDav/GroupDav. So there's no reason to infer "WebDAV" 
from "KDAV".

"Extensions" sounds very optional, and "AnyDAV" looks like yet-another WebDAV-
based protocol in itself.

The issue you see is that someone looking for WebDAV support might end up 
thinking KDAV is the right thing to use? Well, maybe it should be, i.e. this 
would probably be the right place for some proper future WebDAV API compared 
to using kio_http with metadata directly

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.13/22/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 06:06:08 +
 Build duration:
6 hr 37 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 10 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 177 - Still Unstable!

2019-11-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/177/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 10 Nov 2019 11:28:05 +
 Build duration:
9 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-11-10 Thread Ahmad Samir 
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

2019-11-10 Thread Ahmad Samir 
ahmadsamir added reviewers: Frameworks, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24951

To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

2019-11-10 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f39eb884fecc: [http kio slave] use QSslSocket instead of 
KTcpSocket (deprecated) (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24873?vs=68702&id=69517

REVISION DETAIL
  https://phabricator.kde.org/D24873

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 191 - Fixed!

2019-11-10 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/191/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 10 Nov 2019 11:14:25 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34682/61626)40%
(17601/43546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9658/10118)47%
(4506/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)60%
(8670/14529)52%
(4554/8831)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4671/8288)43%
(2024/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1797/4291)36%
(1307/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

2019-11-10 Thread Ahmad Samir 
ahmadsamir added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24828

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 176 - Still Unstable!

2019-11-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/176/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 10 Nov 2019 11:14:24 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

2019-11-10 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:14c6c0007c42: [TcpSlaveBase] port from KTcpSocket 
(deprecated) to QSslSocket (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24928?vs=68836&id=69515

REVISION DETAIL
  https://phabricator.kde.org/D24928

AFFECTED FILES
  src/core/tcpslavebase.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

2019-11-10 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  tested successfully locally. I don't see menus opening on the top left corner 
when running vlc or hp-systray.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D25223

To: kmaterka, #plasma, #frameworks, broulik
Cc: cgiboudeaux, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Unstable!

2019-11-10 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/20/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 10 Nov 2019 03:57:34 +
 Build duration:
6 hr 32 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.providertest

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

2019-11-10 Thread Volker Krause 
vkrause updated this revision to Diff 69514.
vkrause added a comment.


  add comment requested during review

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24980?vs=68817&id=69514

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24980

AFFECTED FILES
  src/core/ksslerror_p.h
  src/core/tcpslavebase.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause, nicolasfella
Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

2019-11-10 Thread Volker Krause 
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Let's get this in now that 5.64 is out.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/tcpslavebase (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

2019-11-10 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/kio_http-ktcpsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24873

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

2019-11-10 Thread Björn Feber 
GB_2 added reviewers: Plasma, Frameworks.
GB_2 added a project: Plasma.
GB_2 added a subscriber: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava, #plasma, #frameworks
Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, 
kde-frameworks-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25149: Add a new template for KCMs

2019-11-10 Thread Björn Feber 
GB_2 added a comment.


  In D25149#559684 , @tcanabrava 
wrote:
  
  > We need a better icon. it's the icon for the `Plasmoid` template.
  
  
  Why not use the system settings icon as it's a KCM template?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava
Cc: GB_2, yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns

Windows CI Breakages

2019-11-10 Thread Ben Cooksley 
Hi all,

Apologies for the recent crop of CI failures on Windows.

These were caused by Windows Defender's engine eating a significant
proportion of the system memory (to the extent the builders were
swapping to disk even though they have 24GB of RAM available to them)

I have now rebooted the builders and put in place measures to ensure
this issue doesn't recur again (the previous mitigation for this was
broken by the update to Windows 10 version 1908)

Replacement builds have been ordered and should be carried out by the
system once they've caught up with their work queue.

Cheers,
Ben