D25500: Remove dependency on QtWidgets

[Méven Car]

meven planned changes to this revision.
meven added a comment.


  In D25500#566823 , @broulik wrote:
  
  > -1 There's UI shown by kded, like network manager prompts and other bits. 
Also, some bits probably need windowing capabilities. 
  >  Certainly something to look into (e.g. use `QGuiApplication` and turn off 
platform awareness) but not something we can "just" do in a minor update.
  
  
  You are right this breaks ABI basically.
  And I found the project wacomtablet would break because of this change (but 
only this one that I could see).
  
  This change could happen once KF6 has been branched though.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25500

To: meven, mart, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar edited the summary of this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25500: Remove dependency on QtWidgets

[Kai Uwe Broulik]

broulik added a comment.


  -1 There's UI shown by kded, like network manager prompts and other bits. 
Also, some bits probably need windowing capabilities. 
  Certainly something to look into (e.g. use `QGuiApplication` and turn off 
platform awareness) but not something we can "just" do in a minor update.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D25500

To: meven, mart, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25500: Remove dependency on QtWidgets

[Méven Car]

meven created this revision.
meven added reviewers: mart, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Remove unnecessary dependency on QtWidgets.
  It should allow the kde daemons to start quicker.
  
  T12191 

TEST PLAN
  kdesrc-build kded
  kdesrc-build kio plasma-desktop plasma-workspace powerdevil kinit 
print-manager plasma-nm kio-extras kscreen kdbusaddons plasma-vault 
plasma-browser-integration kmix kaccounts-integration kdelibs4support baloo 
bluedevil

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25500

AFFECTED FILES
  src/CMakeLists.txt
  src/kded.cpp

To: meven, mart, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25493: EBN kmoretools cleanup transport protocol

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25493

To: jhayes, dhaumann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Dominik Haumann]

dhaumann added a comment.


  In D17595#542142 , @meven wrote:
  
  > I received the agreements of all contributors including the original code 
author, to relicense this code and hence upstream it.
  
  
  Playing the bad guy here: where are these agreements? On a public mailing 
list, or in your private inbox? If on a public mailing list, you could 
reference these mails on our mail archives in your commit message.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/33/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 24 Nov 2019 00:31:45 +
 Build duration:
1 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 172 lines...][2019-11-24T00:32:28.268Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-11-24T00:32:28.268Z] -- Looking for __GLIBC__[2019-11-24T00:32:28.268Z] -- Looking for __GLIBC__ - not found[2019-11-24T00:32:28.268Z] -- Performing Test _OFFT_IS_64BIT[2019-11-24T00:32:28.268Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-11-24T00:32:28.268Z] -- Performing Test HAVE_DATE_TIME[2019-11-24T00:32:28.524Z] -- Performing Test HAVE_DATE_TIME - Success[2019-11-24T00:32:28.524Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-11-24T00:32:31.203Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for KPackage.[2019-11-24T00:32:31.203Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-11-24T00:32:31.203Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-11-24T00:32:31.203Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-11-24T00:32:31.203Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-11-24T00:32:31.203Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-24T00:32:31.203Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-11-24T00:32:31.203Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-11-24T00:32:31.203Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2019-11-24T00:32:31.203Z] -- The following features have been enabled:[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z] -- The following OPTIONAL packages have been found:[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z]  * KF5DocTools (required version >= 5.64.0), Tools to generate documentation[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z] -- The following REQUIRED packages have been found:[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z]  * Qt5DBus[2019-11-24T00:32:31.203Z]  * Qt5 (required version >= 5.11.0)[2019-11-24T00:32:31.203Z]  * KF5Archive (required version >= 5.64.0)[2019-11-24T00:32:31.203Z]  * Gettext[2019-11-24T00:32:31.203Z]  * KF5I18n (required version >= 5.64.0)[2019-11-24T00:32:31.203Z]  * KF5CoreAddons (required version >= 5.64.0)[2019-11-24T00:32:31.203Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-11-24T00:32:31.203Z]  * Doxygen (required version >= 1.8.13)[2019-11-24T00:32:31.203Z]Needed for API dox QCH file generation[2019-11-24T00:32:31.203Z]  * QHelpGenerator, Part of Qt5 tools[2019-11-24T00:32:31.203Z]Needed for API dox QCH file generation[2019-11-24T00:32:31.203Z]  * Qt5Core[2019-11-24T00:32:31.203Z]  * Qt5Test (required version >= 5.11.0)[2019-11-24T00:32:31.203Z]Required for tests[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z] -- Configuring done[2019-11-24T00:32:31.203Z] CMake Warning (dev) in src/kpackage/CMakeLists.txt:[2019-11-24T00:32:31.203Z]   AUTOMOC: CMAKE_AUTOMOC_RELAXED_MODE is deprecated an will be removed in the[2019-11-24T00:32:31.203Z]   future.  Consider disabling it and converting the target KF5Package to[2019-11-24T00:32:31.203Z]   regular mode.[2019-11-24T00:32:31.203Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-11-24T00:32:31.203Z] [2019-11-24T00:32:31.203Z] -- Generating done[2019-11-24T00:32:31.203Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-24T00:32:36.933Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2019-11-24T00:32:38.684Z] Scanning dependencies of target KF5CoreAddons_QCH[2019-11-24T00:32:38.684Z] Scanning dependencies of target KF5Package_autogen[2019-11-24T00:32:38.684Z] Scanning dependencies of target Qt5Core_QCH[2019-11-24T00:32:38.684Z] Scanning dependencies of target docs-kpackagetool-kpackagetool5-1[2019-11-24T00:32:38.684Z] Scanning dependencies of target mockhandler_autogen[2019-11-24T00:32:38.684Z] Scanning dependencies of target testpackage-rcc[2019-11-24T00:32:38.684Z] [  1%] Automatic MOC for target KF5Package[2019-11-24T00:32:38.684Z] [  1%] Built target KF5CoreAddons_QCH[2019-11-24T00:32:38.684Z] [  1%] Built target Qt5Core_QCH[2019-11-24T00:32:38.684Z] [  3%] Automatic MOC for target 

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

[David Faure]

dfaure closed this revision.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25489

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

[David Faure]

dfaure added a comment.


  I doubt anyone will read that docu, but sure, done :-)

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25489

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Seems fine by pure patch reading.

INLINE COMMENTS

> konqbookmarkmenu.h:51
>   * @param collec parent collection for the KActions.
>   */
> +KBOOKMARKS_DEPRECATED_VERSION(5, 65, "This class has moved to Konqueror")

Should also be noted in the API dox with a @since, for good example purpose.

Actually best to be done in the class API dox, though KonqBookmarkMenu does not 
have one yet (and thus also not picked up by kapidox/ecm_add_qch doxygen 
usage). So would just add to both constructors' API dox.

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25489

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 334 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/334/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 22:08:37 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34636/61666)40%
(17575/43574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9645/10105)47%
(4506/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)59%
(8643/14555)51%
(4506/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4664/8286)43%
(2023/4745)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(674/1206)40%
(381/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 66 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/66/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 21:45:03 +
 Build duration:
4 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.65.0.xmllogs/KF5Parts/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)37%
(19/51)37%
(19/51)22%
(604/2779)13%
(179/1357)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)95%
(183/192)49%
(65/132)src41%
(17/41)41%
(17/41)19%
(421/2255)10%
(114/1143)tests0%
(0/8)0%
(0/8)0%
(0/332)0%
(0/82)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 217 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/217/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 23 Nov 2019 19:12:05 +
 Build duration:
2 hr 16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(271/404)67%
(271/404)56%
(34659/61667)40%
(17604/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9645/10105)47%
(4506/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(104/117)89%
(104/117)60%
(8663/14556)51%
(4523/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4669/8286)43%
(2024/4741)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(678/1206)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(522/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 65 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/65/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 20:48:25 +
 Build duration:
15 min and counting
   CONSOLE OUTPUT
  [...truncated 450 lines...][2019-11-23T21:03:33.493Z] [ 52%] Automatic MOC for target spellcheckplugin[2019-11-23T21:03:33.749Z] [ 52%] Built target partviewer_autogen[2019-11-23T21:03:33.749Z] Scanning dependencies of target parttest_autogen[2019-11-23T21:03:33.749Z] [ 53%] Automatic MOC for target parttest[2019-11-23T21:03:33.749Z] [ 53%] Built target kpartstest_autogen[2019-11-23T21:03:33.749Z] [ 53%] Built target spellcheckplugin_autogen[2019-11-23T21:03:33.749Z] [ 53%] Built target notepadpart_autogen[2019-11-23T21:03:33.749Z] Scanning dependencies of target partviewer[2019-11-23T21:03:33.749Z] [ 55%] Building CXX object tests/CMakeFiles/partviewer.dir/partviewer_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:33.749Z] Scanning dependencies of target spellcheckplugin[2019-11-23T21:03:33.749Z] Scanning dependencies of target kpartstest[2019-11-23T21:03:33.749Z] [ 56%] Building CXX object tests/CMakeFiles/spellcheckplugin.dir/spellcheckplugin_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:33.749Z] [ 57%] Building CXX object tests/CMakeFiles/kpartstest.dir/kpartstest_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:33.749Z] [ 59%] Building CXX object tests/CMakeFiles/spellcheckplugin.dir/plugin_spellcheck.cpp.o[2019-11-23T21:03:33.749Z] [ 59%] Built target parttest_autogen[2019-11-23T21:03:34.005Z] [ 60%] Building CXX object tests/CMakeFiles/partviewer.dir/partviewer.cpp.o[2019-11-23T21:03:34.005Z] Scanning dependencies of target openorsavequestion_unittest_autogen[2019-11-23T21:03:34.005Z] Scanning dependencies of target openorsavequestion_autogen[2019-11-23T21:03:34.005Z] [ 61%] Automatic MOC for target openorsavequestion_unittest[2019-11-23T21:03:34.005Z] [ 63%] Automatic MOC for target openorsavequestion[2019-11-23T21:03:34.005Z] [ 63%] Built target openorsavequestion_autogen[2019-11-23T21:03:34.005Z] Scanning dependencies of target notepadpart[2019-11-23T21:03:34.005Z] [ 64%] Building CXX object tests/CMakeFiles/kpartstest.dir/testmainwindow.cpp.o[2019-11-23T21:03:34.005Z] Scanning dependencies of target terminal_test_autogen[2019-11-23T21:03:34.005Z] [ 65%] Automatic MOC for target terminal_test[2019-11-23T21:03:34.005Z] [ 67%] Building CXX object tests/CMakeFiles/notepadpart.dir/notepadpart_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:34.005Z] [ 67%] Built target terminal_test_autogen[2019-11-23T21:03:34.005Z] [ 67%] Built target openorsavequestion_unittest_autogen[2019-11-23T21:03:34.261Z] [ 68%] Building CXX object tests/CMakeFiles/notepadpart.dir/notepad.cpp.o[2019-11-23T21:03:34.261Z] Scanning dependencies of target normalktmtest_autogen[2019-11-23T21:03:34.261Z] [ 69%] Automatic MOC for target normalktmtest[2019-11-23T21:03:34.261Z] [ 71%] Building CXX object tests/CMakeFiles/kpartstest.dir/parts.cpp.o[2019-11-23T21:03:34.520Z] [ 71%] Built target normalktmtest_autogen[2019-11-23T21:03:34.520Z] Scanning dependencies of target parttest[2019-11-23T21:03:34.520Z] [ 72%] Building CXX object autotests/CMakeFiles/parttest.dir/parttest_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:35.089Z] [ 73%] Building CXX object autotests/CMakeFiles/parttest.dir/parttest.cpp.o[2019-11-23T21:03:35.089Z] [ 75%] Building CXX object tests/CMakeFiles/kpartstest.dir/notepad.cpp.o[2019-11-23T21:03:40.426Z] [ 76%] Linking CXX shared module ../bin/spellcheckplugin.so[2019-11-23T21:03:40.426Z] [ 77%] Linking CXX executable ../bin/parttest[2019-11-23T21:03:40.426Z] [ 78%] Linking CXX shared module ../bin/notepadpart.so[2019-11-23T21:03:40.426Z] [ 80%] Linking CXX executable ../bin/partviewer[2019-11-23T21:03:40.426Z] [ 81%] Linking CXX executable ../bin/kpartstest[2019-11-23T21:03:40.681Z] [ 81%] Built target spellcheckplugin[2019-11-23T21:03:40.681Z] [ 81%] Built target notepadpart[2019-11-23T21:03:40.681Z] Scanning dependencies of target terminal_test[2019-11-23T21:03:40.681Z] Scanning dependencies of target openorsavequestion[2019-11-23T21:03:40.681Z] Scanning dependencies of target openorsavequestion_unittest[2019-11-23T21:03:40.681Z] [ 82%] Building CXX object tests/CMakeFiles/terminal_test.dir/terminal_test_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:40.681Z] [ 84%] Building CXX object tests/CMakeFiles/terminal_test.dir/terminal_test.cpp.o[2019-11-23T21:03:40.681Z] [ 85%] Building CXX object tests/CMakeFiles/openorsavequestion.dir/openorsavequestion_autogen/mocs_compilation.cpp.o[2019-11-23T21:03:40.681Z] [ 86%] Building CXX object tests/CMakeFiles/openorsavequestion.dir/openorsavequestion.cpp.o[2019-11-23T21:03:40.681Z] Scanning dependencies of target normalktmtest[2019-11-23T21:03:40.681Z] [ 88%] Building CXX object 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 333 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/333/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 19:12:05 +
 Build duration:
1 hr 44 min and counting
   CONSOLE OUTPUT
  [...truncated 2930 lines...][2019-11-23T20:56:31.666Z] [ 81%] Automatic MOC for target kfilecopytomenutest[2019-11-23T20:56:31.666Z] [ 81%] Automatic MOC for target kfileplacesmodeltest[2019-11-23T20:56:31.927Z] [ 81%] Built target knewfilemenutest_autogen[2019-11-23T20:56:31.927Z] Scanning dependencies of target kdiroperatortest_autogen[2019-11-23T20:56:31.927Z] [ 82%] Automatic MOC for target kdiroperatortest[2019-11-23T20:56:32.499Z] [ 82%] Built target kfileplacesmodeltest_autogen[2019-11-23T20:56:32.499Z] Scanning dependencies of target kurlcomboboxtest_autogen[2019-11-23T20:56:32.499Z] Scanning dependencies of target kfilewidgettest_autogen[2019-11-23T20:56:32.499Z] Scanning dependencies of target kurlnavigatortest_autogen[2019-11-23T20:56:32.499Z] [ 82%] Built target kfilecopytomenutest_autogen[2019-11-23T20:56:32.499Z] [ 83%] Automatic MOC for target kurlcomboboxtest[2019-11-23T20:56:32.499Z] [ 83%] Automatic MOC for target kurlnavigatortest[2019-11-23T20:56:32.499Z] [ 83%] Automatic MOC for target kfilewidgettest[2019-11-23T20:56:32.499Z] Scanning dependencies of target kfilecustomdialogtest_autogen[2019-11-23T20:56:32.499Z] [ 83%] Automatic MOC for target kfilecustomdialogtest[2019-11-23T20:56:32.499Z] [ 83%] Built target kdiroperatortest_autogen[2019-11-23T20:56:32.755Z] Scanning dependencies of target kdirmodeltest_gui_autogen[2019-11-23T20:56:32.755Z] [ 83%] Automatic MOC for target kdirmodeltest_gui[2019-11-23T20:56:32.755Z] [ 83%] Built target kurlcomboboxtest_autogen[2019-11-23T20:56:32.755Z] Scanning dependencies of target previewtest_autogen[2019-11-23T20:56:32.755Z] [ 83%] Automatic MOC for target previewtest[2019-11-23T20:56:32.755Z] [ 83%] Built target kurlnavigatortest_autogen[2019-11-23T20:56:33.011Z] Scanning dependencies of target ksycocaupdatetest_autogen[2019-11-23T20:56:33.011Z] [ 83%] Automatic MOC for target ksycocaupdatetest[2019-11-23T20:56:33.011Z] [ 83%] Built target ksycocaupdatetest_autogen[2019-11-23T20:56:33.011Z] [ 83%] Built target kfilecustomdialogtest_autogen[2019-11-23T20:56:33.011Z] [ 83%] Built target kdirmodeltest_gui_autogen[2019-11-23T20:56:33.011Z] [ 83%] Built target kfilewidgettest_autogen[2019-11-23T20:56:33.267Z] [ 83%] Built target previewtest_autogen[2019-11-23T20:56:33.523Z] [ 84%] Linking CXX shared module ../../../bin/kf5/urifilters/localdomainurifilter.so[2019-11-23T20:56:33.781Z] [ 84%] Built target localdomainurifilter[2019-11-23T20:56:33.781Z] Scanning dependencies of target kdirlistertest_gui_autogen[2019-11-23T20:56:33.781Z] [ 84%] Automatic MOC for target kdirlistertest_gui[2019-11-23T20:56:34.039Z] [ 84%] Built target kdirlistertest_gui_autogen[2019-11-23T20:56:34.039Z] Scanning dependencies of target kioslavetest_autogen[2019-11-23T20:56:34.039Z] [ 84%] Automatic MOC for target kioslavetest[2019-11-23T20:56:34.039Z] [ 84%] Built target kioslavetest_autogen[2019-11-23T20:56:34.296Z] Scanning dependencies of target getalltest_autogen[2019-11-23T20:56:34.296Z] [ 84%] Automatic MOC for target getalltest[2019-11-23T20:56:34.296Z] [ 84%] Built target getalltest_autogen[2019-11-23T20:56:34.296Z] Scanning dependencies of target kencodingfiledialogtest_gui_autogen[2019-11-23T20:56:34.296Z] [ 84%] Automatic MOC for target kencodingfiledialogtest_gui[2019-11-23T20:56:34.296Z] [ 84%] Built target kencodingfiledialogtest_gui_autogen[2019-11-23T20:56:34.296Z] Scanning dependencies of target kopenwithtest_autogen[2019-11-23T20:56:34.296Z] [ 84%] Automatic MOC for target kopenwithtest[2019-11-23T20:56:34.296Z] [ 84%] Built target kopenwithtest_autogen[2019-11-23T20:56:34.296Z] Scanning dependencies of target listrecursivetest_autogen[2019-11-23T20:56:34.296Z] [ 84%] Automatic MOC for target listrecursivetest[2019-11-23T20:56:34.554Z] [ 84%] Built target listrecursivetest_autogen[2019-11-23T20:56:34.554Z] Scanning dependencies of target kfilewidgettest_saving_gui_autogen[2019-11-23T20:56:34.554Z] [ 84%] Automatic MOC for target kfilewidgettest_saving_gui[2019-11-23T20:56:34.554Z] [ 84%] Built target kfilewidgettest_saving_gui_autogen[2019-11-23T20:56:34.554Z] Scanning dependencies of target kurlrequestertest_gui_autogen[2019-11-23T20:56:34.554Z] [ 85%] Automatic MOC for target kurlrequestertest_gui[2019-11-23T20:56:34.554Z] [ 85%] Built target kurlrequestertest_gui_autogen[2019-11-23T20:56:34.554Z] Scanning dependencies of target kmountpoint_debug_autogen[2019-11-23T20:56:34.554Z] [ 85%] Automatic MOC for target kmountpoint_debug[2019-11-23T20:56:34.554Z] [ 85%] Built target kmountpoint_debug_autogen[2019-11-23T20:56:34.555Z] Scanning dependencies of target kionetrctest_autogen[2019-11-23T20:56:34.555Z] [ 85%] Automatic MOC for target kionetrctest[2019-11-23T20:56:34.555Z] [ 85%] 

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kaboutapplicationdialog.cpp:72
>  q->setWindowTitle(i18n("About %1", aboutData.displayName()));
>  q->setModal(false);
>  

(this line does nothing, dialogs aren't modal by default)

> kaboutplugindialog.cpp:78
> +q->setWindowTitle(i18n("About %1", pluginMetaData.name()));
> +q->setModal(false);
> +

(this line does nothing, dialogs aren't modal by default)

REPOSITORY
  R263 KXmlGui

BRANCH
  addaboutplugindialog

REVISION DETAIL
  https://phabricator.kde.org/D25058

To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25334: Added transparent blue background to tabbars

[Noah Davis]

ndavis added a comment.


  In D25334#566524 , @niccolove 
wrote:
  
  > F7780227: Screenshot_20191123_130602.png 

  >  I'm sorry, isn't this right?
  >  The top one was like that before, and I just edited the bottom one, and 
they seem to be the same; shouldn't it be right then?
  
  
  Yes, that's right, it's the panel that doesn't look right.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 202 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/202/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 19:12:05 +
 Build duration:
7 min 49 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25432: Fix HTTP proxy settings

[David Faure]

dfaure added a comment.


  Done in https://commits.kde.org/kio/48b8cab8da5e264f233d59cf2aff2b981255f6bf
  
  Please check if other places are affected.
  
  This code could be simplified by using `configValue()` instead, no? Right now 
the QString() argument serves no purpose, it gets converted to QVariant.
  This would allow removing the toString() call.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25432

To: trufanov, meven, #frameworks
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Christoph Cullmann]

cullmann added a reviewer: mludwig.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25432: Fix HTTP proxy settings

[David Faure]

dfaure added a comment.


  This doesn't appear to fix the bug for me. I get a stringlist with one empty 
string in it, which goes to the "else" branch on line 2712.
  This is very probably the reason for the ftp and http tests being broken in 
CI too.
  
  I'll a SkipEmptyParts to the split(), but this is getting a bit hairy...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25432

To: trufanov, meven, #frameworks
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar updated this revision to Diff 70238.
waqar edited the summary of this revision.
waqar added a comment.


  Fix Sonnet autodetect completely failing when no trigrams found

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25495?vs=70237=70238

BRANCH
  fix-176537 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25495

AFFECTED FILES
  src/core/guesslanguage.cpp

To: waqar
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar edited the summary of this revision.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
waqar requested review of this revision.

REVISION SUMMARY
  Fixes Bug 176537. Sonnet fails to autodetect a language if there are no 
trigrams available for the language. In some cases, the script of the language 
is detected exactly but only because no trigrams were found for the language in 
question, autodetection fails.

REPOSITORY
  R246 Sonnet

BRANCH
  fix-176537 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25495

AFFECTED FILES
  src/core/guesslanguage.cpp

To: waqar
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Noah Davis]

ndavis added a comment.


  In that case, maybe 5% opacity for minimized?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25340: Added background colors to active and inactive icon view

[Nathaniel Graham]

ngraham added a comment.


  I can accept this as-is, but I think I'd still prefer the background color of 
minimized apps/windows to be a bit lighter or more transparent.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D24884: Undeprecate I18N_NOOP2

[David Faure]

dfaure updated this revision to Diff 70234.
dfaure retitled this revision from "Provide I18NC_NOOP_STRIP as a new name for 
the deprecated I18N_NOOP2" to "Undeprecate I18N_NOOP2".
dfaure added a comment.


  keep old macro name

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24884?vs=70212=70234

BRANCH
  arcpatch-D24884

REVISION DETAIL
  https://phabricator.kde.org/D24884

AFFECTED FILES
  src/klocalizedstring.h

To: dfaure, ilic, aacid, mlaurent
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25492: Remove a redundant check

[Nathaniel Graham]

ngraham added a reviewer: broulik.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25492

To: waqar, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

[David Faure]

dfaure added a comment.


  OK, to avoid having to change scripty, I'll stick to the 2 name.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: dfaure, ilic, aacid, mlaurent
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

[Albert Astals Cid]

aacid added a comment.


  As mentioned i don't see the point.
  
  Doint this won't work, since needs an associated change in scripty, just 
undeprecated NOOP2 if you'll agree that this is what you want

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: dfaure, ilic, aacid, mlaurent
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25493: EBN kmoretools cleanup transport protocol

[John Hayes]

jhayes created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jhayes requested review of this revision.

REVISION SUMMARY
  Cleanup of kmoretools tranport protocol from http to https

REPOSITORY
  R304 KNewStuff

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25493

AFFECTED FILES
  tests/kmoretools/kmoretoolstest_interactive.cpp

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

[Méven Car]

meven updated this revision to Diff 70224.
meven added a comment.


  Update copyright/licensing, update @since, add a TODO KF6

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=63895=70224

BRANCH
  arcpatch-D17595_1

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D25492: Remove a redundant check

[Waqar Ahmed]

waqar created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
waqar requested review of this revision.

REVISION SUMMARY
  Removed a redundant check from textbreaks.cpp

REPOSITORY
  R246 Sonnet

BRANCH
  perf (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25492

AFFECTED FILES
  src/core/textbreaks.cpp

To: waqar
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25491: Remove kdeinit dependency from kded.

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, cordlandwehr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Just make it a normal executable.

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25491

AFFECTED FILES
  CMakeLists.txt
  KDEDConfig.cmake.in
  src/CMakeLists.txt
  src/kded.cpp

To: dfaure, mart, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KF6 Blogs

[Dominik Haumann]

Hi everyone,

could you who currently are at the KF6 sprint blog a bit more?

Even if it's just about small details like "app X does not depend on Y
anymore and this is how we got rid of the dependency" already is valuable
information, since it helps other contributors to not introduce such code
anymore.

The KDE Frameworks are our foundations for pretty much everything we do. It
deserves more press coverage, including maybe a final dot story.

Keep it up :-)
Dominik

D25448: EBN cleanup of autotests transfer protocol

[John Hayes]

jhayes updated this revision to Diff 70220.
jhayes retitled this revision from "EBN cleanup of autests transfer protocol" 
to "EBN cleanup of autotests transfer protocol".
jhayes added a comment.


  Corrected summary typo

REPOSITORY
  R267 Oxygen Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25448?vs=70121=70220

BRANCH
  ebn-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25448

AFFECTED FILES
  autotests/newlinetest.cpp

To: jhayes, apol
Cc: meven, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25490: Remove legacy plugin loading code

[Nicolas Fella]

nicolasfella updated this revision to Diff 70219.
nicolasfella added a comment.


  - Remove

REPOSITORY
  R307 KPeople

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25490?vs=70218=70219

BRANCH
  service

REVISION DETAIL
  https://phabricator.kde.org/D25490

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/personpluginmanager.cpp
  src/widgets/CMakeLists.txt
  src/widgets/actions.cpp
  src/widgets/persondetailsview.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25490: Remove legacy plugin loading code

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  All plugins (even ktp) use the proper system now. This allows to get rid of 
the kservice dependency

REPOSITORY
  R307 KPeople

BRANCH
  service

REVISION DETAIL
  https://phabricator.kde.org/D25490

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/personpluginmanager.cpp
  src/widgets/CMakeLists.txt
  src/widgets/actions.cpp
  src/widgets/persondetailsview.cpp

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 216 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/216/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 23 Nov 2019 13:58:05 +
 Build duration:
6 min 40 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32518/61669)37%
(16024/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4364/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8314/14553)49%
(4317/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4671/8289)43%
(2023/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 332 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/332/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 13:54:40 +
 Build duration:
7 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32523/61670)37%
(16034/43574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4364/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8314/14553)49%
(4318/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4671/8289)43%
(2025/4745)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 201 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/201/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 13:52:43 +
 Build duration:
7 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 215 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/215/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 23 Nov 2019 13:35:59 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32539/61670)37%
(16033/43570)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9337/10107)46%
(4368/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8326/14553)49%
(4321/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4667/8289)43%
(2021/4741)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 331 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/331/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 23 Nov 2019 13:35:59 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_ftptestFailed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(263/404)65%
(263/404)53%
(32532/61670)37%
(16031/43574)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)92%
(9335/10107)46%
(4356/9556)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)57%
(8322/14553)49%
(4322/8819)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4672/8289)43%
(2026/4745)src.gui0%
(0/2)0%
(0/2)0%
(0/103)0%
(0/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(680/1208)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)11%
(149/1368)4%
(58/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)21%
(892/4278)16%
(594/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(74/268)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 200 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/200/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 23 Nov 2019 13:35:59 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_http_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

[David Faure]

dfaure updated this revision to Diff 70212.
dfaure retitled this revision from "I18N_NOOP2 was deprecated but we can't 
replace by I18NC_NOOP as it expends it as 2 elements (context + text)" to 
"Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2".
dfaure edited the summary of this revision.
dfaure added a reviewer: aacid.
dfaure added a comment.


  Improve docu, update version, change commit log

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24884?vs=68594=70212

BRANCH
  arcpatch-D24884

REVISION DETAIL
  https://phabricator.kde.org/D24884

AFFECTED FILES
  src/klocalizedstring.h

To: mlaurent, dfaure, ilic, aacid
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

[David Faure]

dfaure commandeered this revision.
dfaure edited reviewers, added: mlaurent; removed: dfaure.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: dfaure, ilic, aacid, mlaurent
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

[David Faure]

dfaure added a comment.


  I don't exactly mind if we resurrect NOOP2 or rename it to STRIP, but STRIP 
kind of makes sense because the name explicitly says something is being 
stripped (and the documentation should warn loudly about the risks of doing 
that). It's a better name than "2" where the "2" means nothing else than "oops 
I can't overload macros".
  
  I didn't realize one solution was to store a KLocalizedString, but that 
wouldn't work for KFilePlacesItem anyway, it uses KBookmark as storage (which 
takes a QString and can't be changed, it makes sense for it to be a QString, 
for actual user bookmarks).
  
  I agree that the risk here is typos. The documentation should warn about 
that. But it's a logical risk when having a number of I18N markers (all of 
which have to repeat the context anyway), and then *one* call to i18nc for all 
of them (where repeating the context is IMHO an acceptable tradeoff for the 
complexity of storing the context in each string, when the underlying storage 
doesn't allow it).

INLINE COMMENTS

> klocalizedstring.h:69
>   *
> - * \deprecated Since 5.0, use \c I18NC_NOOP.
> + * \deprecated Since 5.0, use \c I18NC_NOOP_TRIP.
>   */

typo: *S*TRIP

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

[David Faure]

dfaure updated this revision to Diff 70210.
dfaure added a comment.


  Oops the next version is 65, not 64.
  
  You'd think *I* would know that... :-)
  
  Yes I did mean "next version", I just picked the wrong number.

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25489?vs=70208=70210

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25489

AFFECTED FILES
  src/CMakeLists.txt
  src/konqbookmarkmenu.cpp
  src/konqbookmarkmenu.h
  src/konqbookmarkmenu_p.h

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove added a comment.


  > Might be too subtle, maybe more opacity would be needed
  
  This should have a 13% vs 23% opacity, what do you think?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

[Friedrich W. H. Kossebau]

kossebau added a comment.


  That should be upcoming 5.65 here though, not 5.64.
  Moving things into visibility-protection guards of recent versions will break 
things for people who used DISABLE_DEPRECATED_BEFORE_AND_AT after having 
properly checked their source is properly building against released versions 
with the value used for that flag. See also 
https://mail.kde.org/pipermail/kde-frameworks-devel/2019-November/096701.html

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25489

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

[David Faure]

dfaure created this revision.
dfaure added reviewers: vkrause, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I copied them into Konqueror (the only user), after adding
  namespacing there to avoid clashing with KBookmarks.

TEST PLAN
  Builds with and without -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.64.0

REPOSITORY
  R294 KBookmarks

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25489

AFFECTED FILES
  src/CMakeLists.txt
  src/konqbookmarkmenu.cpp
  src/konqbookmarkmenu.h
  src/konqbookmarkmenu_p.h

To: dfaure, vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25340: Added background colors to active and inactive icon view

[Niccolò Venerandi]

niccolove updated this revision to Diff 70207.
niccolove added a comment.


  Changed opacity of inactive vs non-visible application background color

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25340?vs=69882=70207

BRANCH
  backrgound-color-iconviewer (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25340

AFFECTED FILES
  src/desktoptheme/breeze/widgets/tasks.svg

To: niccolove, #vdg, ngraham
Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25334: Added transparent blue background to tabbars

[Niccolò Venerandi]

niccolove added a comment.


  F7780227: Screenshot_20191123_130602.png 

  I'm sorry, isn't this right?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25334

To: niccolove, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, KonqiDragon, #vdg, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  F7780181: image.png 
  I just can't get the padding right on angles when changing their size. What 
size should I change of the colored rectangles?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

Re: KInit - Current state and benchmarks

[Milian Wolff]

On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote:
> El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va 
escriure:
> > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i
> > > own, only 2 have SSD.> 
> > It's at least safe to assume it's the trend moving forward.
> > 
> > > Do you think it's worth me trying in one of the two that don't have SSD?
> > 
> > More data is normally a good thing. If you or anyone else wants to
> > collect stats:
> > From my git link above, it's as simple as running the normal ; cmake;
> > make ; ./kinittest -median 5
> 
> On my very old/very slow computer seems to make a lot of difference
> 
> RESULT : DaveTest::testQProcess():
>  2,625 msecs per iteration (total: 2,625, iterations: 1)
> RESULT : DaveTest::testKInit():
>  1,852 msecs per iteration (total: 1,852, iterations: 1)
> 
> 
> RESULT : DaveTest::testQProcess():
>  2,390 msecs per iteration (total: 2,390, iterations: 1)
> RESULT : DaveTest::testKInit():
>  1,846 msecs per iteration (total: 1,846, iterations: 1)

Hey Albert,

these numbers are quite impressive but I can't quite explain those. Are you 
measuring maybe a full debug build without any compiler optimizations? Then 
the library sizes will be _much_ larger and thus trigger more page faults. If 
every one of those is extremely slow on that machine compared to more modern 
machines?

May I ask how old this machine is and what the speed of the HDD is?

Thanks

-- 
Milian Wolff
m...@milianw.de
http://milianw.de

signature.asc
Description: This is a digitally signed message part.

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

[David Faure]

dfaure added a comment.


  @cfeck Can you review this again?
  
  I guess this could be improved with `if (text == d->fullText) return;` but 
the patch is already an improvement as is.

REVISION DETAIL
  https://phabricator.kde.org/D7010

To: brauch, cfeck, dfaure
Cc: rkflx, dfaure, dhaumann, aacid, #frameworks, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25485: Remove KIconThemes use

[Dominik Haumann]

dhaumann added a comment.


  Makes sense, thanks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25485

To: broulik, #frameworks, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D25485: Remove KIconThemes use

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c7d64230aa34: Remove KIconThemes use (authored by broulik).
Herald added a project: Kate.
Herald added a subscriber: kwrite-devel.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25485?vs=70198=70199

REVISION DETAIL
  https://phabricator.kde.org/D25485

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/dialogs/katedialogs.cpp
  src/variableeditor/katehelpbutton.cpp
  src/variableeditor/katehelpbutton.h

To: broulik, #frameworks, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25485: Remove KIconThemes use

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D25485

To: broulik, #frameworks, cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25485: Remove KIconThemes use

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, cullmann.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It was effectively unused.

TEST PLAN
  - help button on the variable editor still shows and hides as I enter and 
leave

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D25485

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/dialogs/katedialogs.cpp
  src/variableeditor/katehelpbutton.cpp
  src/variableeditor/katehelpbutton.h

To: broulik, #frameworks, cullmann
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24046: Allow triggering sort from QML

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> broulik wrote in personssortfilterproxymodel.h:53
> ... which people say is ABI-compatible

"You can ... reimplement virtual functions defined in the primary base class 
hierarchy (that is, virtuals defined in the first non-virtual base class, or in 
that class's first non-virtual base class, and so forth) if it is safe that 
programs linked with the prior version of the library call the implementation 
in the base class rather than the derived one. This is tricky and might be 
dangerous. Think twice before doing it. Alternatively see below for a 
workaround."
Now I'm confused :(

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D24046

To: nicolasfella, apol
Cc: jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24046: Allow triggering sort from QML

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> broulik wrote in personssortfilterproxymodel.h:53
> Can you just forward the entire thing:
> 
>   Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) 
> override;

... which people say is ABI-compatible

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D24046

To: nicolasfella, apol
Cc: jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D24046: Allow triggering sort from QML

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> personssortfilterproxymodel.h:53
>  bool filterAcceptsRow(int source_row, const QModelIndex _parent) 
> const override;
> +Q_INVOKABLE void sortNow();
>  

Can you just forward the entire thing:

  Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) 
override;

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D24046

To: nicolasfella, apol
Cc: jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns