KDE CI: Frameworks » kinit » kf5-qt5 SUSEQt5.13 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20SUSEQt5.13/28/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 07:34:29 +
 Build duration:
2 min 30 sec and counting
   BUILD ARTIFACTS
  acc/KF5Init-5.65.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/8)0%
(0/8)0%
(0/1924)0%
(0/1185)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/2)0%
(0/2)0%
(0/294)0%
(0/157)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/945)0%
(0/583)src.klauncher0%
(0/4)0%
(0/4)0%
(0/685)0%
(0/445)

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25632: Fix module imports with Python3

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:f8ff31dc9af0: Fix module imports with Python3 (authored 
by cordlandwehr).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25632?vs=70625=70721

REVISION DETAIL
  https://phabricator.kde.org/D25632

AFFECTED FILES
  src/kapidox/depdiagram/__init__.py
  src/kapidox/depdiagram/frameworkdb.py

To: cordlandwehr, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis added a dependent revision: D25677: [KColorScheme/KStatefulBrush] Switch 
hardcoded numbers for enum items.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis added a dependency: D25676: [KColorScheme] Add items to ColorSet and 
Role enums for the total number of items.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25677

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25677: [KColorScheme/KStatefulBrush] Switch hardcoded numbers for enum items

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This also replaces some for-loops with C++11 range based for-loops and 
switches for simpler if/else control blocks.

TEST PLAN
  Open colorscheme editor in the Colors KCM to see if any colors or effects 
look broken.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  remove-hardcoded-values (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25677

AFFECTED FILES
  src/kcolorscheme.cpp

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis updated this revision to Diff 70718.
ndavis added a comment.


  - Split up Effects enum

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25676?vs=70717=70718

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: [KColorScheme] Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis retitled this revision from "Add items to ColorSet and Role enums for 
the total number of items" to "[KColorScheme] Add items to ColorSet and Role 
enums for the total number of items".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis updated this revision to Diff 70717.
ndavis added a comment.


  - Also do Effects enum

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25676?vs=70716=70717

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25676

To: ndavis, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25676: Add items to ColorSet and Role enums for the total number of items

[Noah Davis]

ndavis created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  I noticed that QPalette had these, but KColorScheme didn't. Since there is no 
function to get the number of items in an enum for C++, it seems like it would 
be useful to have a built-in way to get the total number of items. I will make 
a follow up patch to reduce the amount of hardcoded values in KColorScheme.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  enum-item-counts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25676

AFFECTED FILES
  src/kcolorscheme.h

To: ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/31/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 02:52:55 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9108/13159)49%
(4200/8620)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6363/10292)48%
(3426/7124)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 115 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/115/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 02:52:42 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.65.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6877/9073)43%
(10784/24837)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2874/2966)49%
(6178/12735)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(867/1296)36%
(1002/2811)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/787)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(992/1214)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D25673: Deprecate KServiceTypeProfile

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kservicetypeprofile.h:50
>   * @param disabledServices List of services which are normally associated 
> with this serviceType,
>   * but which should be disabled, i.e. trader queries will not return them.
>   */

@deprecated 5.65

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25673

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/79/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 02:52:26 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/73/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 02:52:16 +
 Build duration:
8 min 52 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.65.0.xmllogs/KF5WindowSystem/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7188/9615)54%
(3458/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3029/3164)51%
(1258/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3332/4719)59%
(1896/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 84 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 02:52:07 +
 Build duration:
6 min 17 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.65.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)84%
(27110/32220)53%
(10899/20711)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12383/12591)50%
(6503/13115)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6324/7468)65%
(1835/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7949/9505)63%
(2384/3769)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/78/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Dec 2019 02:04:53 +
 Build duration:
3 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/27/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 01 Dec 2019 23:53:41 +
 Build duration:
1 hr 39 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:10 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/21/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 01 Dec 2019 23:53:38 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/64/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:03 +
 Build duration:
1 hr 3 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/33/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 00:08:18 +
 Build duration:
44 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 491 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezones
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9108/13159)49%
(4200/8620)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6363/10292)48%
(3426/7124)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/52/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:03 +
 Build duration:
1 hr 1 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:02 +
 Build duration:
58 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » threadweaver » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:02 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:01 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/46/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:51:01 +
 Build duration:
52 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:59 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/44/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 00:07:58 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 152 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/152/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:57 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/45/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 00:07:55 +
 Build duration:
23 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.65.0.xmllogs/KF5WindowSystem/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7192/9615)55%
(3468/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3033/3164)52%
(1266/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(819/1374)47%
(302/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(/4719)59%
(1897/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kinit » kf5-qt5 SUSEQt5.13 - Build # 27 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20SUSEQt5.13/27/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 00:07:54 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   CONSOLE OUTPUT
  [...truncated 487 lines...][2019-12-02T00:26:12.556Z] [ 19%] Built target start_kdeinit_autogen[2019-12-02T00:26:12.556Z] [ 26%] Built target kdeinit5_shutdown[2019-12-02T00:26:12.556Z] [ 36%] Built target kdeinit5[2019-12-02T00:26:12.556Z] [ 43%] Built target kwrapper5[2019-12-02T00:26:12.556Z] [ 50%] Built target kdeinit5_wrapper[2019-12-02T00:26:12.556Z] [ 56%] Built target kshell5[2019-12-02T00:26:12.556Z] [ 63%] Built target start_kdeinit_wrapper[2019-12-02T00:26:12.556Z] [ 84%] Built target kdeinit_klauncher[2019-12-02T00:26:12.556Z] [ 91%] Built target start_kdeinit[2019-12-02T00:26:12.556Z] [ 93%] Automatic MOC for target klauncher[2019-12-02T00:26:12.556Z] [ 93%] Built target klauncher_autogen[2019-12-02T00:26:12.556Z] [100%] Built target klauncher[2019-12-02T00:26:12.556Z] Install the project...[2019-12-02T00:26:12.556Z] -- Install configuration: "Debug"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitMacros.cmake[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfigVersion.cmake[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Init/kde5init_dummy.cpp.in[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/share/qlogging-categories5/kinit.categories[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/bin/kdeinit5[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert//home/jenkins/install-prefix/bin/kdeinit5" to "/home/jenkins/install-prefix/lib64"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/bin/kdeinit5_shutdown[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert//home/jenkins/install-prefix/bin/kdeinit5_shutdown" to "/home/jenkins/install-prefix/lib64"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/bin/kdeinit5_wrapper[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert//home/jenkins/install-prefix/bin/kdeinit5_wrapper" to "/home/jenkins/install-prefix/lib64"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/bin/kwrapper5[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert//home/jenkins/install-prefix/bin/kwrapper5" to "/home/jenkins/install-prefix/lib64"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/lib64/libkdeinit5_klauncher.so[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert//home/jenkins/install-prefix/lib64/libkdeinit5_klauncher.so" to "/home/jenkins/install-prefix/lib64"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/lib64/libexec/kf5/klauncher[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert//home/jenkins/install-prefix/lib64/libexec/kf5/klauncher" to "/home/jenkins/install-prefix/lib64"[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/share/dbus-1/interfaces/kf5_org.kde.KLauncher.xml[2019-12-02T00:26:12.556Z] -- Installing: /home/jenkins/workspace/Frameworks/kinit/kf5-qt5 SUSEQt5.13/install-divert/home/jenkins/install-prefix/bin/kshell5[2019-12-02T00:26:12.556Z] -- Set runtime path of "/home/jenkins/workspace/Frameworks/kinit/kf5-qt5 

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 42 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/42/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Dec 2019 00:07:50 +
 Build duration:
7 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.65.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27254/32223)53%
(10999/20711)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12500/12591)50%
(6590/13115)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6329/7469)65%
(1834/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7971/9507)64%
(2398/3769)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/21/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:56 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:56 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_netrootinfotestwm

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:54 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 208 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/208/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:54 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/37/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 23:50:53 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D25673: Deprecate KServiceTypeProfile

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It's unused. See T12287 

REPOSITORY
  R309 KService

BRANCH
  dep

REVISION DETAIL
  https://phabricator.kde.org/D25673

AFFECTED FILES
  src/CMakeLists.txt
  src/services/kservicetypeprofile.cpp
  src/services/kservicetypeprofile.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25671: Fix git builds against Qt 5.14

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  It's not really acceptable to just error on everything since some of the
  solutions (like in this case) might not be retrocompatible.
  
  The error was:
  kdecoration/src/decoration.cpp:386:37: error: no member named 'posF' in 
'QWheelEvent'

TEST PLAN
  Builds now

REPOSITORY
  R129 Window Decoration Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25671

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/77/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 01 Dec 2019 23:05:03 +
 Build duration:
6 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/43/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 01 Dec 2019 23:05:02 +
 Build duration:
4 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25589#570375 , @dfaure wrote:
  
  > My head hurts a bit but I think I understand this now ;)
  
  
  Indeed, this gets more & more complex, I hope in time for ECM6 there are 
enough samples collected from real-world usage to trim down things a bit again, 
to match known usage pattern with some simple setup options again. For now it's 
still try & error phase I guess, at least I still meet new constellations every 
week I had not thought of when initially designing this.
  
  > I'm not sure what's the use case for disabling this though? (I'm wondering 
the same about the existing NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE)
  
  With some non-KDE projects I experimented this with, having control to 
disable the setting or build-internal export of these flags was needed.
  E.g. in  some the examples wanted to have all deprecated API be invisible, to 
make sure examples only demonstrate latest non-deprecated API. So the exported 
flags were not wanted, instead are explicitly set per tests & examples.
  In others deprecated API was more separate and should not be used from other 
parts, so having a global deprecation warning/visibility flag by default got in 
the way, where instead deprecation warnings/visibility trigger is individually 
configured per file (warnings vs. visibiity to allow smooth porting in the 
library).

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE

REVISION DETAIL
  https://phabricator.kde.org/D25589

To: kossebau, #build_system, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:23d868a07712: ECMGenerateExportHeader: add 
NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25589?vs=70495=70704

REVISION DETAIL
  https://phabricator.kde.org/D25589

AFFECTED FILES
  modules/ECMGenerateExportHeader.cmake

To: kossebau, #build_system, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25630: Port to json metadata

[Nicolas Fella]

nicolasfella updated this revision to Diff 70698.
nicolasfella added a comment.


  - Use kcoreaddons_desktop_to_json

REPOSITORY
  R150 KDE Telepathy KDE Daemon Module

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25630?vs=70623=70698

BRANCH
  json

REVISION DETAIL
  https://phabricator.kde.org/D25630

AFFECTED FILES
  CMakeLists.txt
  telepathy-module.cpp

To: nicolasfella, #frameworks, #kde_telepathy
Cc: akulichalexandr, ltoscano

D25599: Fix plugin-metadata translations on windows

[Albert Astals Cid]

aacid added a comment.


  In D25599#570372 , @sars wrote:
  
  > ki18n does not seem to use QLocale to get the language for translation
  
  
  It already does that on non unix
  
  appendLanguagesFromQLocale(localeLanguages, QLocale::system());
  
  the other big question is why it's using QLocale::system and not QLocale() 
itself

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25660: Decouple KBookmarksMenu from KActionCollection

[Nicolas Fella]

nicolasfella updated this revision to Diff 70694.
nicolasfella added a comment.


Rebase

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25660?vs=70693=70694

BRANCH
  addd

REVISION DETAIL
  https://phabricator.kde.org/D25660

AFFECTED FILES
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Decouple KBookmarksMenu from KActionCollection

[Nicolas Fella]

nicolasfella retitled this revision from "Add member for editbookmarks action" 
to "Decouple KBookmarksMenu from KActionCollection".
nicolasfella edited the summary of this revision.
nicolasfella edited the test plan for this revision.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25660

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

[Nicolas Fella]

nicolasfella updated this revision to Diff 70693.
nicolasfella added a comment.


  - Decouple from KActionCollection

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25660?vs=70680=70693

BRANCH
  addd

REVISION DETAIL
  https://phabricator.kde.org/D25660

AFFECTED FILES
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/5/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 01 Dec 2019 20:39:27 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectrootC_.CI.workspace.Frameworks.kquickcharts.kf5-qt5_WindowsMSVCQt513 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/4/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 01 Dec 2019 20:27:47 +
 Build duration:
1 min 45 sec and counting
   BUILD ARTIFACTS
  acc/KF5QuickCharts-5.58.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)42%
(14/33)42%
(14/33)16%
(305/1950)10%
(85/855)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(56/56)64%
(27/42)controls0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/4)src100%
(9/9)100%
(9/9)38%
(218/576)22%
(45/202)src.datasource33%
(3/9)33%
(3/9)8%
(31/373)6%
(13/236)src.decorations0%
(0/4)0%
(0/4)0%
(0/392)0%
(0/199)src.scenegraph0%
(0/8)0%
(0/8)0%
(0/536)0%
(0/172)

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 3 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/3/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 01 Dec 2019 20:17:12 +
 Build duration:
2 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectrootC_.CI.workspace.Frameworks.kquickcharts.kf5-qt5_WindowsMSVCQt513 Failed: 3 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectrootC_.CI.workspace.Frameworks.kquickcharts.kf5-qt5_WindowsMSVCQt513.autotests.BarChartFailed: projectrootC_.CI.workspace.Frameworks.kquickcharts.kf5-qt5_WindowsMSVCQt513.autotests.LineChartFailed: projectrootC_.CI.workspace.Frameworks.kquickcharts.kf5-qt5_WindowsMSVCQt513.autotests.PieChart

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 3 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/3/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 01 Dec 2019 20:17:12 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 358 lines...][2019-12-01T20:18:07.188Z] Start 5: PieChart[2019-12-01T20:18:07.188Z] 5/5 Test #5: PieChart .   Passed0.10 sec[2019-12-01T20:18:07.188Z] [2019-12-01T20:18:07.188Z] 100% tests passed, 0 tests failed out of 5[2019-12-01T20:18:07.188Z] [2019-12-01T20:18:07.188Z] Total Test time (real) =   0.38 sec[2019-12-01T20:18:07.188Z] XIO:  fatal IO error 4 (Interrupted system call) on X server ":90"[2019-12-01T20:18:07.188Z]   after 1491 requests (1491 known processed) with 0 events remaining.[Pipeline] junit[2019-12-01T20:18:07.240Z] Recording test results[2019-12-01T20:18:07.799Z] Remote call on Docker Swarm-3420a54be220 failed[Pipeline] }[Pipeline] // stage[Pipeline] }[2019-12-01T20:18:08.352Z] java.io.IOException: Bad file descriptor[2019-12-01T20:18:08.352Z] 	at java.io.FileInputStream.readBytes(Native Method)[2019-12-01T20:18:08.352Z] 	at java.io.FileInputStream.read(FileInputStream.java:255)[2019-12-01T20:18:08.352Z] 	at java.io.BufferedInputStream.read1(BufferedInputStream.java:284)[2019-12-01T20:18:08.352Z] 	at java.io.BufferedInputStream.read(BufferedInputStream.java:345)[2019-12-01T20:18:08.352Z] 	at java.io.FilterInputStream.read(FilterInputStream.java:107)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.Util.copy(Util.java:55)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.Checksum.forURL(Checksum.java:79)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.Checksum.forFile(Checksum.java:69)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.FileSystemJarCache.retrieve(FileSystemJarCache.java:121)[2019-12-01T20:18:08.352Z] Caused: java.io.IOException: Failed to write to /home/jenkins/remoting/jarCache/DB/4812EC5E2EB71C7E37F4036A790838.jar[2019-12-01T20:18:08.352Z] 	at hudson.remoting.FileSystemJarCache.retrieve(FileSystemJarCache.java:150)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.JarCacheSupport$DownloadRunnable.run(JarCacheSupport.java:110)[2019-12-01T20:18:08.352Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-12-01T20:18:08.352Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:111)[2019-12-01T20:18:08.352Z] Caused: java.util.concurrent.ExecutionException[2019-12-01T20:18:08.352Z] 	at hudson.remoting.AsyncFutureImpl.get(AsyncFutureImpl.java:77)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.FutureAdapter.get(FutureAdapter.java:55)[2019-12-01T20:18:08.352Z] 	at hudson.remoting.RemoteClassLoader.findResource(RemoteClassLoader.java:437)[2019-12-01T20:18:08.352Z] Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to Docker Swarm-3420a54be220[2019-12-01T20:18:08.352Z] 		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)[2019-12-01T20:18:08.352Z] 		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:356)[2019-12-01T20:18:08.352Z] 		at hudson.remoting.Channel.call(Channel.java:955)[2019-12-01T20:18:08.352Z] 		at hudson.FilePath.act(FilePath.java:1069)[2019-12-01T20:18:08.352Z] 		at hudson.FilePath.act(FilePath.java:1058)[2019-12-01T20:18:08.352Z] 		at hudson.tasks.junit.JUnitParser.parseResult(JUnitParser.java:114)[2019-12-01T20:18:08.352Z] 		at hudson.tasks.junit.JUnitResultArchiver.parse(JUnitResultArchiver.java:137)[2019-12-01T20:18:08.352Z] 		at hudson.tasks.junit.JUnitResultArchiver.parseAndAttach(JUnitResultArchiver.java:167)[2019-12-01T20:18:08.352Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:52)[2019-12-01T20:18:08.352Z] 		at hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:25)[2019-12-01T20:18:08.352Z] 		at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)[2019-12-01T20:18:08.352Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[2019-12-01T20:18:08.352Z] Caused: java.lang.Error: Unable to load resource hudson/model/Messages.properties[2019-12-01T20:18:08.352Z] 	at hudson.remoting.RemoteClassLoader.findResource(RemoteClassLoader.java:445)[2019-12-01T20:18:08.352Z] 	at java.lang.ClassLoader.getResource(ClassLoader.java:1089)[2019-12-01T20:18:08.352Z] 	at java.lang.Class.getResource(Class.java:2267)[2019-12-01T20:18:08.352Z] 	at org.jvnet.localizer.ResourceProvider$1.getResource(ResourceProvider.java:53)[2019-12-01T20:18:08.352Z] 	at org.jvnet.localizer.ResourceProvider.findResource(ResourceProvider.java:45)[2019-12-01T20:18:08.352Z] 	at org.jvnet.localizer.ResourceBundleHolder.get(ResourceBundleHolder.java:107)[2019-12-01T20:18:08.352Z] 	at 

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.13 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.13/2/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 01 Dec 2019 20:03:37 +
 Build duration:
1 min 54 sec and counting
   BUILD ARTIFACTS
  acc/KF5QuickCharts-5.58.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_SUSEQt513 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)42%
(14/33)42%
(14/33)16%
(305/1952)10%
(85/855)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(56/56)64%
(27/42)controls0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/4)src100%
(9/9)100%
(9/9)38%
(218/576)22%
(45/202)src.datasource33%
(3/9)33%
(3/9)8%
(31/373)6%
(13/236)src.decorations0%
(0/4)0%
(0/4)0%
(0/394)0%
(0/199)src.scenegraph0%
(0/8)0%
(0/8)0%
(0/536)0%
(0/172)

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/2/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Sun, 01 Dec 2019 20:03:37 +
 Build duration:
2 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 287 lines...][2019-12-01T20:05:14.407Z] mocs_compilation.cpp[2019-12-01T20:05:14.665Z] [ 16%] Built target QuickCharts_autogen[2019-12-01T20:05:14.665Z] [ 11%] Building CXX object controls/CMakeFiles/chartscontrolsplugin.dir/ChartsControlsPlugin.cpp.obj[2019-12-01T20:05:14.665Z] [ 11%] Building CXX object controls/CMakeFiles/chartscontrolsplugin.dir/chartscontrolsplugin_autogen/mocs_compilation.cpp.obj[2019-12-01T20:05:14.665Z] ChartsControlsPlugin.cpp[2019-12-01T20:05:16.110Z] mocs_compilation.cpp[2019-12-01T20:05:16.369Z] [ 18%] Generating qrc_shaders.cpp[2019-12-01T20:05:16.369Z] Scanning dependencies of target QuickCharts[2019-12-01T20:05:16.628Z] [ 20%] Linking CXX shared library ..\bin\chartscontrolsplugin.dll[2019-12-01T20:05:18.084Z]Creating library ..\lib\chartscontrolsplugin.lib and object ..\lib\chartscontrolsplugin.exp[2019-12-01T20:05:20.685Z]Creating library ..\lib\chartscontrolsplugin.lib and object ..\lib\chartscontrolsplugin.exp[2019-12-01T20:05:20.685Z] [ 44%] Built target chartscontrolsplugin[2019-12-01T20:05:20.685Z] [ 27%] Building CXX object src/CMakeFiles/QuickCharts.dir/RangeGroup.cpp.obj[2019-12-01T20:05:20.685Z] [ 23%] Building CXX object src/CMakeFiles/QuickCharts.dir/BarChart.cpp.obj[2019-12-01T20:05:20.685Z] [ 30%] Building CXX object src/CMakeFiles/QuickCharts.dir/Chart.cpp.obj[2019-12-01T20:05:20.685Z] [ 27%] Building CXX object src/CMakeFiles/QuickCharts.dir/PieChart.cpp.obj[2019-12-01T20:05:20.685Z] [ 39%] Building CXX object src/CMakeFiles/QuickCharts.dir/ChartsPlugin.cpp.obj[2019-12-01T20:05:20.685Z] [ 37%] Building CXX object src/CMakeFiles/QuickCharts.dir/XYChart.cpp.obj[2019-12-01T20:05:20.685Z] [ 41%] Building CXX object src/CMakeFiles/QuickCharts.dir/decorations/AxisLabels.cpp.obj[2019-12-01T20:05:20.685Z] [ 44%] Building CXX object src/CMakeFiles/QuickCharts.dir/decorations/LegendModel.cpp.obj[2019-12-01T20:05:20.685Z] [ 37%] Building CXX object src/CMakeFiles/QuickCharts.dir/decorations/GridLines.cpp.obj[2019-12-01T20:05:20.685Z] [ 32%] Building CXX object src/CMakeFiles/QuickCharts.dir/LineChart.cpp.obj[2019-12-01T20:05:20.685Z] ChartsPlugin.cpp[2019-12-01T20:05:20.943Z] XYChart.cpp[2019-12-01T20:05:21.229Z] [ 46%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ChartDataSource.cpp.obj[2019-12-01T20:05:21.229Z] [ 48%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ModelSource.cpp.obj[2019-12-01T20:05:21.798Z] Chart.cpp[2019-12-01T20:05:21.798Z] PieChart.cpp[2019-12-01T20:05:21.798Z] LineChart.cpp[2019-12-01T20:05:21.798Z] BarChart.cpp[2019-12-01T20:05:21.798Z] RangeGroup.cpp[2019-12-01T20:05:21.798Z] GridLines.cpp[2019-12-01T20:05:21.798Z] AxisLabels.cpp[2019-12-01T20:05:21.798Z] LegendModel.cpp[2019-12-01T20:05:21.798Z] ChartDataSource.cpp[2019-12-01T20:05:21.798Z] ModelSource.cpp[2019-12-01T20:05:21.798Z] [ 51%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/SingleValueSource.cpp.obj[2019-12-01T20:05:22.074Z] SingleValueSource.cpp[2019-12-01T20:05:22.363Z] [ 53%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ArraySource.cpp.obj[2019-12-01T20:05:22.648Z] ArraySource.cpp[2019-12-01T20:05:22.922Z] C:\CI\workspace\Frameworks\kquickcharts\kf5-qt5 WindowsMSVCQt5.13\src\decorations\LegendModel.cpp(49): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data[2019-12-01T20:05:23.509Z] [ 55%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ModelHistorySource.cpp.obj[2019-12-01T20:05:23.509Z] ModelHistorySource.cpp[2019-12-01T20:05:23.767Z] [ 58%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ChartAxisSource.cpp.obj[2019-12-01T20:05:24.550Z] ChartAxisSource.cpp[2019-12-01T20:05:24.550Z] [ 60%] Building CXX object src/CMakeFiles/QuickCharts.dir/scenegraph/PieChartMaterial.cpp.obj[2019-12-01T20:05:24.823Z] [ 62%] Building CXX object src/CMakeFiles/QuickCharts.dir/scenegraph/PieChartNode.cpp.obj[2019-12-01T20:05:24.823Z] PieChartMaterial.cpp[2019-12-01T20:05:24.823Z] PieChartNode.cpp[2019-12-01T20:05:24.823Z] [ 65%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ColorGradientSource.cpp.obj[2019-12-01T20:05:25.086Z] [ 67%] Building CXX object src/CMakeFiles/QuickCharts.dir/datasource/ValueHistorySource.cpp.obj[2019-12-01T20:05:25.086Z] [ 72%] Building CXX object src/CMakeFiles/QuickCharts.dir/scenegraph/LineGridNode.cpp.obj[2019-12-01T20:05:25.086Z] [ 72%] Building CXX object src/CMakeFiles/QuickCharts.dir/scenegraph/LineChartMaterial.cpp.obj[2019-12-01T20:05:25.086Z] [ 74%] Building CXX object src/CMakeFiles/QuickCharts.dir/scenegraph/LineChartNode.cpp.obj[2019-12-01T20:05:25.347Z] [ 76%] Building CXX object 

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/2/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 01 Dec 2019 20:03:37 +
 Build duration:
1 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.usr.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_FreeBSDQt513 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 2 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/2/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 01 Dec 2019 20:03:37 +
 Build duration:
1 min 39 sec and counting
   BUILD ARTIFACTS
  acc/KF5QuickCharts-5.58.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)42%
(14/33)42%
(14/33)16%
(305/1952)10%
(85/855)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(56/56)64%
(27/42)controls0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/4)src100%
(9/9)100%
(9/9)38%
(218/576)22%
(45/202)src.datasource33%
(3/9)33%
(3/9)8%
(31/373)6%
(13/236)src.decorations0%
(0/4)0%
(0/4)0%
(0/394)0%
(0/199)src.scenegraph0%
(0/8)0%
(0/8)0%
(0/536)0%
(0/172)

D25599: Fix plugin-metadata translations on windows

[Hannah von Reth]

vonreth added a comment.


  Well it sounds to me like we might need both.
  But the issue this pr tries to tackle would probably be gone with setDefault

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D24489: KAutosaveFile not respecting maximum filename length

[David Faure]

dfaure added a comment.


  A unittest would be very welcome.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  My head hurts a bit but I think I understand this now ;)
  
  I'm not sure what's the use case for disabling this though? (I'm wondering 
the same about the existing NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE)

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE

REVISION DETAIL
  https://phabricator.kde.org/D25589

To: kossebau, #build_system, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D25599: Fix plugin-metadata translations on windows

[Kåre Särs]

sars added a comment.


  ki18n does not seem to use QLocale to get the language for translation, but 
uses LANGUAGE env. Also gettext uses the env variable.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25599: Fix plugin-metadata translations on windows

[Albert Astals Cid]

aacid added a comment.


  To be honest i don't remember why we don't use setDefault.
  
  It's a solution we could investigate

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew added a comment.


  In D23384#570347 , @ngraham wrote:
  
  > In D23384#570119 , @feverfew 
wrote:
  >
  > > In D23384#570016 , @ngraham 
wrote:
  > >
  > > > In D23384#569929 , @feverfew 
wrote:
  > > >
  > > > > This isn't reaching KIOFuse at all. I believe this is related to this 
bug and that you've also blogged about:
  > > > >  https://bugs.kde.org/show_bug.cgi?id=330192
  > > > >  https://pointieststick.com/2018/01/17/videos-on-samba-shares/
  > > > >
  > > > > This can be solved in this patch (and I did, although I removed it at 
Harald's request). I think I'll move it back in, and will leave it if it does 
solve this issue for you.
  > > >
  > > >
  > > > Great! Once it's back in, I'll re-test that.
  > >
  > >
  > > Updated the diff. give it a go...
  > >  Also I assume that if it does work for you it resolves 330192 
?
  >
  >
  > Yay case #1 is fixed now! VLC and SMPlayer still unnecessarily download the 
URL locally like Totem does, but the large video file does at least open now 
when accesses from the non-FUSE location in Dolphin.
  
  
  This seems like the best solution. From what I understand, not sending the 
credentials is a security feature, so doing it via KIOFuse is unavoidable

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Alexander Saoutkin]

feverfew added a comment.


  In D23384#570349 , @ngraham wrote:
  
  > In D23384#570125 , @dfaure wrote:
  >
  > > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path 
is passed to the application being started, and the application, if it supports 
gvfs, re-translates that into a URL and uses that instead if it makes more 
sense. This way "dumb" apps get a local file (with all the limitations of doing 
synchronous I/O over the network) and network-transparent applications use URLs.
  > >  On the other hand, the KDE logic is "if the app takes %f and not %u in 
the Exec line, it doesn't support remote URLs, so we need to download the file 
first" (that's done by kioexec). If you see a "download first" check if kioexec 
is running. But if it's the app doing it, then I have no idea.
  >
  >
  > `kioexec` is not running during any of these lengthy downloads. Totem, VLC, 
and SMplayer all have %U in their desktop files, FWIW.
  >
  > We may want to rethink this logic anyway. Any app that doesn't integrate 
with ioslaves should get the FUSE path rather than a locally-downloaded file, 
irrespective of whether or not its desktop file has %f or %u IMO. There are 
just too many disadvantages to the locally downloaded file approach, which is 
why we're doing this FUSE thing in the first place.
  >
  > Perhaps the "lengthy local download first" issue is caused by not having 
https://invent.kde.org/kde/kio-fuse/merge_requests/2 yet.
  
  
  Yes, that's precisely why. !2 
 implements seeking to 
any point in the file without having to download all of it. I'll rebase all of 
it such that you can test all of it easily tomorrow.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  In D23384#570125 , @dfaure wrote:
  
  > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is 
passed to the application being started, and the application, if it supports 
gvfs, re-translates that into a URL and uses that instead if it makes more 
sense. This way "dumb" apps get a local file (with all the limitations of doing 
synchronous I/O over the network) and network-transparent applications use URLs.
  >  On the other hand, the KDE logic is "if the app takes %f and not %u in the 
Exec line, it doesn't support remote URLs, so we need to download the file 
first" (that's done by kioexec). If you see a "download first" check if kioexec 
is running. But if it's the app doing it, then I have no idea.
  
  
  `kioexec` is not running during any of these lengthy downloads. Totem, VLC, 
and SMplayer all have %U in their desktop files, FWIW.
  
  We may want to rethink this logic anyway. Any app that doesn't integrate with 
ioslaves should get the FUSE path rather than a locally-downloaded file, 
irrespective of whether or not its desktop file has %f or %u IMO. There are 
just too many disadvantages to the locally downloaded file approach, which is 
why we're doing this FUSE thing in the first place.
  
  Perhaps the "lengthy local download first" issue is caused by not having 
https://invent.kde.org/kde/kio-fuse/merge_requests/2 yet.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  In D23384#570119 , @feverfew wrote:
  
  > In D23384#570016 , @ngraham 
wrote:
  >
  > > In D23384#569929 , @feverfew 
wrote:
  > >
  > > > This isn't reaching KIOFuse at all. I believe this is related to this 
bug and that you've also blogged about:
  > > >  https://bugs.kde.org/show_bug.cgi?id=330192
  > > >  https://pointieststick.com/2018/01/17/videos-on-samba-shares/
  > > >
  > > > This can be solved in this patch (and I did, although I removed it at 
Harald's request). I think I'll move it back in, and will leave it if it does 
solve this issue for you.
  > >
  > >
  > > Great! Once it's back in, I'll re-test that.
  >
  >
  > Updated the diff. give it a go...
  >  Also I assume that if it does work for you it resolves 330192 
?
  
  
  Yay case #1 is fixed now! VLC and SMPlayer still unnecessarily download the 
URL locally like Totem does, but the large video file does at least open now 
when accesses from the non-FUSE location in Dolphin.
  
  > Also this patch doesn't seem to solve 398446? I'd downgrade that to a 
CCBUG. A fix can be done via the Solid repo though to display the mount in 
Places. I'll create a patch when appropriate.
  
  I guess it doesn't //fully// fix 398446. It mostly does since the open or 
save dialog from the app will still begin in the FUSE location so you can see 
nearby files or Save As to a new file in the same location. But if you navigate 
away from that location, it will be next to impossible for a regular user to 
find again, so we would want to expose the mount in the file dialog for 
completeness' sake, yeah.
  
  > That's just an annoying issue locally, which is resolved by that hack. On 
the system level this won't be a problem at all.
  
  Ok good.
  
  > Also, pls put debug output into an attachment in the future (and probably 
edit your comment above), it's now quite hard to scroll through this diff.
  
  Done, sorry about that.
  
  >>> I'm a bit confused. Which one of the three are you doing:
  >>> 
  >>> 1. Opening a KIO Url via Dolphin.
  >>> 2. Opening a KIOFuse mount local URL via Dolphin.
  >>> 3. Opening a KIOFuse URL via the media players file picker.
  >> 
  >> #2.
  > 
  > So as in, you're Dolphin is browsing inside 
`/run/user//kio-fuse-XX/some/location` and you open a file from there?
  
  Yes. testing further, I am able to reproduce this dolphin hang when I 
right-click > open in > Totem, but not in VLC or SMPlayer.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D25572: [KFileWidget] Allow double quotes in filenames

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I think this needs more work, we lost some tolerance here, AFAICS.

INLINE COMMENTS

> kfilewidget.cpp:1751
>  
> -const int count = line.count(QLatin1Char('"'));
> -if (count == 0) {   // no " " -> assume one single file
> +if (!line.contains(QStringLiteral("\" \""))) {
>  if (!QDir::isAbsolutePath(line)) {

What if I had `"file1.txt" "file2.txt"` and I manually edit that to remove the 
second file, ending up with just `"file1.txt"`? The double-quotes will no 
longer be removed, because of this modified condition.

> kfilewidget.cpp:1767
>  while (true) {
> -index1 = line.indexOf(QLatin1Char('"'), start);
> -index2 = line.indexOf(QLatin1Char('"'), index1 + 1);
> +index1 = line.indexOf(QStringLiteral("\""), index1);
> +// find next word separator

Isn't there a `"` at this position, always?
Initially, at position 0, and then later, we know we hit `" "` so `index1 = 
index2+2` could be done at the end of the loop (instead of +1), and here we 
don't need an `indexOf` call anymore.
I assume this was done in order to be tolerant to things like two spaces or 
something, but now the separator is hardcoded to `" "` so we *know* there's a 
quote at `index2`+2 after finding a quote at `index2`.

Well, I guess we can keep an initial indexOf (outside the loop) in case there's 
a leading space (because a user manually removed the first file).

So this needs additional unittests for leading space, trailing space, 
single-quoted-file  and I wonder if we are OK with no longer supporting two 
spaces (e.g. because the user manually removed some intermediate file in the 
list).

The separator is in fact `" +"` in regexp syntax, then?

> kfilewidget.cpp:1769
> +// find next word separator
> +index2 = line.indexOf(QStringLiteral("\" \""), index1 + 1);
>  

this could move to after the if() block on the next line.
If index1 < 0, there's no point in calculating index2.

> kfilewidget.cpp:1777
> +// grab everything left until last character
> +index2 = line.length() -1;
> +}

Isn't the last character a double-quote (in the normal case)? Don't we want to 
stop just before it, to avoid grabbing it?

Of course this opens the question of what to do if the last character is NOT a 
double-quote, but
`"file1.txt" "file2.txt` looks weird. Well, getting `file2.tx` as a result 
would be even weirder, so better go backwards from the end of the string until 
"not space and not double-quote", for some tolerance. (another case for the 
unittest)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25572

To: meven, #frameworks, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

[Nathaniel Graham]

ngraham added a comment.


  In D23384#570118 , @fvogt wrote:
  
  > Please try both of the following:
  
  
  Done. Here are the log files:
  
  F7793378: kio-fuse.log 
  
  F7793379: strace output.log 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23384

To: feverfew, fvogt, davidedmundson, dfaure, ngraham
Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, 
michaelh, bruns

D25599: Fix plugin-metadata translations on windows

[Hannah von Reth]

vonreth added a comment.


  Why can't we use setDefault?
  Your linked patch does not look like it would change the behaviour on Windows?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25661: Simplify null check

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:4b8609a04c31: Simplify null check (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25661?vs=70687=70688

REVISION DETAIL
  https://phabricator.kde.org/D25661

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25661: Simplify null check

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  nulll

REVISION DETAIL
  https://phabricator.kde.org/D25661

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

[Nicolas Fella]

nicolasfella planned changes to this revision.
nicolasfella added a comment.


  I can do it with the rest of the patch

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25660

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25572: [KFileWidget] Allow double quotes in filenames

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks Méven. I can confirm that it works in Gwenview with no other changes. 
I have to re-compile Kolourpaint, but then it works from there too. Odd.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D25572_1

REVISION DETAIL
  https://phabricator.kde.org/D25572

To: meven, #frameworks, ngraham, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25661: Simplify null check

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

TEST PLAN
  builds, Dolphin's bookmark menu stil opens

REPOSITORY
  R294 KBookmarks

BRANCH
  nulll

REVISION DETAIL
  https://phabricator.kde.org/D25661

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

[Aleix Pol Gonzalez]

apol added a comment.


  Maybe  this is too of an intermediate step? this patch doesn't really do 
anything.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25660

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25657: Clean up includes

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:a195de5012b1: Clean up includes (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25657?vs=70677=70684

REVISION DETAIL
  https://phabricator.kde.org/D25657

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25656: Remove unneeded moc include

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:1ee83cf07143: Remove unneeded moc include (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25656?vs=70676=70683

REVISION DETAIL
  https://phabricator.kde.org/D25656

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

[Nicolas Fella]

nicolasfella marked an inline comment as done.
nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in CMakeLists.txt:72
> This comment looks wrong

Fixed

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D25650

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25659: Add TODO KF6 note

[Aleix Pol Gonzalez]

apol added a comment.


  I'm unsure such comments are useful. :/
  Maybe it would work better as a phabricator task or so?

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25659

To: nicolasfella, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:6ba0d9371f74: Port foreach (authored by nicolasfella).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25650?vs=70664=70682

REVISION DETAIL
  https://phabricator.kde.org/D25650

AFFECTED FILES
  CMakeLists.txt
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kkeysequencewidget.cpp
  src/kmainwindow.cpp
  src/ktoolbar.cpp
  src/ktoolbarhandler.cpp
  src/kxmlguifactory.cpp
  src/kxmlguifactory_p.cpp

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25657: Clean up includes

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  incl

REVISION DETAIL
  https://phabricator.kde.org/D25657

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25656: Remove unneeded moc include

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  moc

REVISION DETAIL
  https://phabricator.kde.org/D25656

To: nicolasfella, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25650: Port foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:72
>  add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00)
>  # Subdirectories
>  add_definitions(-DTRANSLATION_DOMAIN=\"kxmlgui5\")

This comment looks wrong

REPOSITORY
  R263 KXmlGui

BRANCH
  fore

REVISION DETAIL
  https://phabricator.kde.org/D25650

To: nicolasfella, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

[Nicolas Fella]

nicolasfella added a task: T12056: KBookmarks.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D25660

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25658: Remove superflous private

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R294:29139b7b8f66: Remove superflous private (authored by 
nicolasfella).

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25658?vs=70678=70681

REVISION DETAIL
  https://phabricator.kde.org/D25658

AFFECTED FILES
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25660: Add member for editbookmarks action

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  First step towards getting rid of KActionCollection dependency. Save the 
action in a member variable so we can expose it in the API so clients can add 
it int their action collection

TEST PLAN
  Action still shows up in shortcut editor in Dolphin

REPOSITORY
  R294 KBookmarks

BRANCH
  addd

REVISION DETAIL
  https://phabricator.kde.org/D25660

AFFECTED FILES
  src/kbookmarkmenu.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25658: Remove superflous private

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  pri

REVISION DETAIL
  https://phabricator.kde.org/D25658

To: nicolasfella, #frameworks, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24489: KAutosaveFile not respecting maximum filename length

[Ahmad Samir]

ahmadsamir added a comment.


  IIUC, FILENAME_MAX corresponds to PATH_MAX, 4096 (bytes; or chars in an 
array).
  
  NAME_MAX is the max. filename (the filename part only, without the canonical 
path) length, this is 255 on Linux.
  
  So using FILENAME_MAX is correct in the code.
  
  See:
  https://www.gnu.org/software/libc/manual/html_node/Limits-for-Files.html , 
which talks about FILENAME_MAX, NAME_MAX and PATH_MAX  \o/
  /usr/include/stdio.h (from glibc-devel)
  /usr/include/bits/stdio_lim.h
  
  And:
  /usr/include/linux/limits.h:
  #define NAME_MAX 255  /* # chars in a file name */
  #define PATH_MAX4096  /* # chars in a path name including nul */

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D24489

To: mardelle, #frameworks, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23457: Port regex search to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  In D23457#568067 , @dhaumann wrote:
  
  > Any news here?
  
  
  For starters, this needs to be rebased; I'll try and get to it soon.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23457

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25599: Fix plugin-metadata translations on windows

[Albert Astals Cid]

aacid added a comment.


  Right, but we set it in initializeLanguages.
  
  https://github.com/KDE/kxmlgui/blob/master/src/kswitchlanguagedialog_p.cpp#L81
  
  I think the bug is that initializeLanguages should set the proper stuff in 
QLocale for windows too.
  
  I had this that fixes part of a similar problem 
https://phabricator.kde.org/D23119 can you check if that helps at all on 
windows?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25599

To: sars, aacid, vonreth
Cc: kde-frameworks-devel, LeGast00n, GB_2, sdepiets, michaelh, ngraham, bruns, 
cullmann, kfunk

D25632: Fix module imports with Python3

[Olivier Churlaud]

ochurlaud accepted this revision.
ochurlaud added a comment.
This revision is now accepted and ready to land.


  If it still works it's OK to push.

REPOSITORY
  R264 KApiDox

BRANCH
  bugfix/graphvizImportPython3

REVISION DETAIL
  https://phabricator.kde.org/D25632

To: cordlandwehr, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna

D25659: Add TODO KF6 note

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R294 KBookmarks

BRANCH
  toto

REVISION DETAIL
  https://phabricator.kde.org/D25659

AFFECTED FILES
  src/kbookmarkmenu.h

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns