D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Nibaldo González]

nibags updated this revision to Diff 71333.
nibags added a comment.


  - Improve number delimiters (use lookbehind)

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25869?vs=71242=71333

BRANCH
  python-numbers

REVISION DETAIL
  https://phabricator.kde.org/D25869

AFFECTED FILES
  autotests/folding/test.py.fold
  autotests/html/test.py.html
  autotests/input/test.py
  autotests/reference/test.py.ref
  data/syntax/python.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis added a comment.


  In D25897#575934 , @ngraham wrote:
  
  > Thanks. However I wonder if the stroke width ought to increase for the 
larger sizes? Having such skinny lines looks a tad odd to me IMO:
  >
  > F7813271: Screenshot_20191211_235533.png 

  
  
  If you look to the left, the other 32px icons also use lines that are that 
thin. The difference is that the desktop icon is so empty compared to the other 
icons. I don't know what to do about this TBH.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[Nathaniel Graham]

ngraham added a comment.


  Lovely. Any chance you could actually add the name of the current system 
color scheme into the menu item? Like "System color scheme (Breeze)"

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson updated this revision to Diff 71329.
davidedmundson added a comment.


  Implement new arguments for filterAcceptsRow passing source_row, 
source_parent.
  
  It makes for slightly heavier messier JS, but it also allows for super 
flexibility 
  beyond just having the value retried and it's familiar for Qt programmers.
  
  Maybe we should add an invokable
  sourceData(int source_row, int source_column, QModelIndex source_parent) to 
save a
  bit of boilerplate?

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25326?vs=71327=71329

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25326

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksortfilterproxymodel_qml.cpp
  autotests/ksortfilterproxymodeltest.qml
  src/qml/CMakeLists.txt
  src/qml/ksortfilterproxymodel.cpp
  src/qml/ksortfilterproxymodel.h
  src/qml/plugin.cpp

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson updated this revision to Diff 71327.
davidedmundson added a comment.


  update

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25326?vs=71326=71327

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25326

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksortfilterproxymodel_qml.cpp
  autotests/ksortfilterproxymodeltest.qml
  src/qml/CMakeLists.txt
  src/qml/ksortfilterproxymodel.cpp
  src/qml/ksortfilterproxymodel.h
  src/qml/plugin.cpp

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks. However I wonder if the stroke width ought to increase for the larger 
sizes? Having such skinny lines looks a tad odd to me IMO:
  
  F7813271: Screenshot_20191211_235533.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

[David Edmundson]

davidedmundson updated this revision to Diff 71326.
davidedmundson added a comment.


  All changes except the parameters of filterRowCallback

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25326?vs=69918=71326

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25326

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksortfilterproxymodel_qml.cpp
  autotests/ksortfilterproxymodeltest.qml
  src/qml/CMakeLists.txt
  src/qml/ksortfilterproxymodel.cpp
  src/qml/ksortfilterproxymodel.h
  src/qml/plugin.cpp

To: davidedmundson
Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25902: Fix decrement index and not iterator as discussed with David

[Laurent Montel]

mlaurent updated this revision to Diff 71322.
mlaurent added a comment.


  Fix other code

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25902?vs=71312=71322

BRANCH
  fix_kioslave_notifier (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25902

AFFECTED FILES
  network/kded/kioslavenotifier.cpp

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 218 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/218/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 11 Dec 2019 18:10:15 +
 Build duration:
2 hr 21 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25323: [text thumbnail] Force Syntax Highligthing when no definition for file was found

[Friedrich W. H. Kossebau]

kossebau added a comment.


  See D25891  (not tested by myself, only 
saw it) for another approach to this. So seems in general setTheme() always 
needs an explicit rehighlight() afterwards (but why only in some cases)?
  AbstractHighlighter::setTheme claims that "Subclasses can re-implement this 
method to e.g. trigger re-highlighing or to do general palette color setup. ", 
so SyntaxHighlighter actually is missing to comply here?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25323

To: meven, kossebau, cullmann, vkrause
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25891: fix preview of plain text files when using dark theme

[Ilia Kats]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:4ec12a850e25: fix preview of plain text files when using 
dark theme (authored by iliakats).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25891?vs=71295=71317

REVISION DETAIL
  https://phabricator.kde.org/D25891

AFFECTED FILES
  thumbnail/textcreator.cpp

To: iliakats, #dolphin, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25902: Fix decrement index and not iterator as discussed with David

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kioslavenotifier.cpp:114
>  else
>  *it++;
>  }

Same here

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25902

To: mlaurent, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 11 Dec 2019 17:58:00 +
 Build duration:
2 hr 9 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D25891: fix preview of plain text files when using dark theme

[Anthony Fieroni]

anthonyfieroni accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25891

To: iliakats, #dolphin, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25902: Fix decrement index and not iterator as discussed with David

[Laurent Montel]

mlaurent created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Fix decrement index and not iterator

REPOSITORY
  R320 KIO Extras

BRANCH
  fix_kioslave_notifier (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25902

AFFECTED FILES
  network/kded/kioslavenotifier.cpp

To: mlaurent
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25902: Fix decrement index and not iterator as discussed with David

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25902

To: mlaurent, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 233 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/233/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 11 Dec 2019 18:10:15 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.65.0.xmllogs/KF5KIO/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34643/61662)40%
(17593/43559)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9645/10105)47%
(4507/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8658/14558)51%
(4517/8823)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4658/8284)43%
(2028/4744)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(678/1206)40%
(386/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1418)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D25870: SELinux: add "glblub" keyword and update permissions list

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6f9022a66567: SELinux: add glblub keyword and 
update permissions list (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25870?vs=71243=71307

REVISION DETAIL
  https://phabricator.kde.org/D25870

AFFECTED FILES
  autotests/folding/test.cil.fold
  autotests/folding/test.te.fold
  autotests/html/test.cil.html
  autotests/html/test.te.html
  autotests/input/test.cil
  autotests/input/test.te
  autotests/reference/test.cil.ref
  autotests/reference/test.te.ref
  data/syntax/selinux-cil.xml
  data/syntax/selinux.xml

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25858: Use QStyle for determining icon sizes

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:34aeee14693b: Use QStyle for determining icon sizes 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25858?vs=71214=71308

REVISION DETAIL
  https://phabricator.kde.org/D25858

AFFECTED FILES
  src/filewidgets/kfileplacesview.cpp

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25858: Use QStyle for determining icon sizes

[Volker Krause]

vkrause added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25858

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.12 - Build # 38 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.12/38/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 11 Dec 2019 17:58:00 +
 Build duration:
5 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9107/13158)49%
(4198/8618)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6362/10291)48%
(3424/7122)

KDE CI: Frameworks » kcalendarcore » kf5-qt5 SUSEQt5.13 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20SUSEQt5.13/40/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 11 Dec 2019 17:58:00 +
 Build duration:
4 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CalendarCore-5.65.0.xmlcompat_reports/KF5CalendarCore_compat_report.htmllogs/KF5CalendarCore/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 492 test(s), Skipped: 0 test(s), Total: 492 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)96%
(82/85)96%
(82/85)69%
(9107/13158)49%
(4198/8618)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(38/38)100%
(38/38)96%
(2745/2867)52%
(774/1496)src94%
(44/47)94%
(44/47)62%
(6362/10291)48%
(3424/7122)

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25897

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25897: Add 32, 48 and 64 px user-desktop icons

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This prevents the icon from becoming blurry at fairly normal panel widths.

TEST PLAN
  - make/ninja install
  - rm -r ~/.cache/plasma*
  - plasmashell --replace &

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  show-desktop-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25897

AFFECTED FILES
  src/desktoptheme/breeze/icons/user.svg

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25891: fix preview of plain text files when using dark theme

[Ilia Kats]

iliakats updated this revision to Diff 71295.
iliakats added a comment.


  performance improvement: only do one round of highlighting (skip the one run 
in the constructor of QSyntaxHighlighter)

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25891?vs=71288=71295

REVISION DETAIL
  https://phabricator.kde.org/D25891

AFFECTED FILES
  thumbnail/textcreator.cpp

To: iliakats, #dolphin
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25891: fix preview of plain text files when using dark theme

[Ilia Kats]

iliakats added a reviewer: Dolphin.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25891

To: iliakats, #dolphin
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25891: fix preview of plain text files when using dark theme

[Ilia Kats]

iliakats created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
iliakats requested review of this revision.

REVISION SUMMARY
  When using a dark theme, plain text files without an associated highlighting 
theme are rendered in white on a white background (see also bugs 409380 and 
406821). This patch forces a re-highlighting of the preview after the theme is 
set and before it is drawn into the preview area.

TEST PLAN
  opened dolphin, checked several text files for correct preview colors

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D25891

AFFECTED FILES
  thumbnail/textcreator.cpp

To: iliakats
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D25888: Support multiple children elements in comment elements

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:268195d2d5e2: Support multiple children elements in 
comment elements (authored by leinir).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25888?vs=71283=71285

REVISION DETAIL
  https://phabricator.kde.org/D25888

AFFECTED FILES
  src/commentparser.cpp

To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25888: Support multiple children elements in comment elements

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Awesome!

REPOSITORY
  R235 Attica

BRANCH
  support-multiple-comment-children-elements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25888

To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25888: Support multiple children elements in comment elements

[Dan Leinir Turthra Jensen]

leinir edited the test plan for this revision.
leinir added reviewers: Frameworks, KNewStuff, ngraham.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D25888

To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25888: Support multiple children elements in comment elements

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This may seem strange, however we are dealing with a situation where we may
  receive multiple children subsections (the standard accepts this, and certain
  server implementations do do this)

REPOSITORY
  R235 Attica

BRANCH
  support-multiple-comment-children-elements (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25888

AFFECTED FILES
  src/commentparser.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25887: [ColorScope] Work with plain QObjects again

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8f7b2c9ae099: [ColorScope] Work with plain QObjects again 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25887?vs=71280=71281

REVISION DETAIL
  https://phabricator.kde.org/D25887

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25887: [ColorScope] Work with plain QObjects again

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise `colorScope` doesn't attach to things like `Plasma.Svg`.
  Also remove superfluous cast as `parentItem()` returns a `QQuickItem *`.

TEST PLAN
  - Battery on lock screen gets proper complementary color group again
  - didn't actually test the applet background stuff that this change was 
originally made for

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25887

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e44cab6ab55b: [Breeze Desktop Theme] Add monochrome 
user-desktop icon (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25885?vs=71274=71278

REVISION DETAIL
  https://phabricator.kde.org/D25885

AFFECTED FILES
  src/desktoptheme/breeze/icons/user.svg

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25887: [ColorScope] Work with plain QObjects again

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25887

To: broulik, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Nathaniel Graham]

ngraham updated this revision to Diff 71276.
ngraham added a comment.


  Don't use relative dates farther than three days back

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25878?vs=71262=71276

BRANCH
  better-relative-dates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25878

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Also some nitpicks on the style... remember that API dox tool and compiler 
both need all data duplicated sadly, both deprecated-at version and 
what-to-do-instead.
  
  Please also compare 
https://community.kde.org/Policies/Library_Code_Policy#Deprecation_of_API and 
improve where needed,

INLINE COMMENTS

> containmentactions.h:73
> + *
> + * @deprecated use metadata
> + */

Also add Since note to deprecation, for people reading the generated API dox.
So:

  @deprecated Since 5.66, use metadata()

> containmentactions.h:75
> + */
> +PLASMA_DEPRECATED_VERSION(5, 64, "use metadata()") KPluginInfo 
> pluginInfo() const;
> +#endif

Also recommended: put PLASMA_DEPRECATED_VERSION onto own line, makes parsing 
the code more easy

  PLASMA_DEPRECATED_VERSION(5, 64, "use metadata()")
  KPluginInfo pluginInfo() const;

> dataengine.h:77
> + *
> + * @deprecated since 5.64
>   **/

For people reading the generated API dox, we need to duplicate the 
recommendation what to do:

  @deprecated Since 5.66, use xyz

> dataengine.h:79
>   **/
> -explicit DataEngine(const KPluginInfo , QObject *parent = 
> nullptr);
> +PLASMA_DEPRECATED_VERSION(5, 64, "Use KPluginMetaData") explicit 
> DataEngine(const KPluginInfo , QObject *parent = nullptr);
> +#endif

own line again recommended

> dataengine.h:118
> + */
> +PLASMA_DEPRECATED_VERSION(5, 64, "Use metadata()") KPluginInfo 
> pluginInfo() const;
> +#endif

own line

> dataenginescript.h:113
>  
>  /**
> + * @return the KPluginInfo associated with this dataengine

No visibility wrappers here? (#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 66))

> dataenginescript.h:116
> + *
> + * @deprecated use metadata()
>   */

@deprecated Since 5.66, use metadata()

> theme.h:326
> + */
> +PLASMA_DEPRECATED_VERSION(5, 64, "Use KPluginMetaData metadata()") 
> KPluginInfo pluginInfo() const;
> +#endif

own line

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Do not forget to bump 5.64 to 5.66 in all places :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma, mart
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice work!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25885

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This ensures the "show desktop" plasmoid remains monochrome in the panel at 
any size.

TEST PLAN
  Icon is black and white and good looking now, checked that the color CSS 
still works.
  
  F7812547: Screenshot_20191211_151607.png 

  F7812550: Screenshot_20191211_151619.png 

  
  F7812544: Screenshot_20191211_151527.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25885

AFFECTED FILES
  src/desktoptheme/breeze/icons/user.svg

To: broulik, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23682

To: apol, #plasma, mart
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25870: SELinux: add "glblub" keyword and update permissions list

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-selinux

REVISION DETAIL
  https://phabricator.kde.org/D25870

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25869: Python: improve numbers, add octals, binaries and "breakpoint" keyword

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  python-numbers

REVISION DETAIL
  https://phabricator.kde.org/D25869

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25878: Use clearer relative dates

[Nathaniel Graham]

ngraham added a comment.


  So no "in two days"/"two days ago"? That's too confusing?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Kai Uwe Broulik]

broulik added a comment.


  Yeah i think yesterday and tomorrow is fine but everything beyond that 
becomes more annoying than helpful

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Nathaniel Graham]

ngraham added a comment.


  I was on the fence about that too. We could move to absolute dates after 
three days, maybe.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf added a comment.


  Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into 
account complementary color schemes (authored by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25699?vs=70789=71268

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Filip Fila]

filipf edited the summary of this revision.
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre added a dependency: D25875: [KColorschemeManager] Prevent changes to 
the palette if a custom one is set.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

[David Redondo]

davidre added a dependent revision: D25877: [KColorschemeManager] Add option to 
reenable following global theme.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25875

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Kai Uwe Broulik]

broulik added a comment.


  Not a fan of Mathematics there. "Five days ago" I first have to open my 
calendar and count what day that was.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D25878

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

[David Redondo]

davidre edited the test plan for this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25875

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25878: Use clearer relative dates

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: davidedmundson, VDG, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Right now relative dated within +/- one week use "last/next " which is 
inherently 
  ambiguous in English. This patch changes it to use clearer terminology: dates 
within a
  week say "n days ago"/"in n days", and dates a week older or in the future 
use the
  normal style.
  
  Closes T12349 

TEST PLAN
  F7812358: clearer relative dates.png 

REPOSITORY
  R244 KCoreAddons

BRANCH
  better-relative-dates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25878

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

To: ngraham, davidedmundson, #vdg, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Because the style will always follow the global scheme (see D25875 
) we need only
  to only change the titlebar hint back to "kdeglobals" and we simply don't 
react
  to palette changes.

TEST PLAN
  Select "System color scheme" in Kate, change scheme in colors kcm

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

AFFECTED FILES
  src/kcolorschememanager.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[Fabian Vogt]

fvogt added a comment.


  In D25699#575278 , @davidedmundson 
wrote:
  
  > Please don't link external sites (GitHub) in the committed message.
  >
  > RE: Menu
  >  There is nothing in QQC2::Button to add a menu
  >
  > If we want that it would have to be a custom button subclass, rather than 
something we support in the style.
  
  
  Or as a simple hack for this case, adding "▾" to the button's label.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

[David Redondo]

davidre added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25875

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Currently if an application has set a custom color scheme and the global one 
is
  changed, the new global color scheme is also applied to this application.
  Resulting in an application with the contents drawn in the new global color
  scheme and the titlebar still in the colors of the custom one. To prevent this
  we simply activate the custom one again if something changes the palette.

TEST PLAN
  Select a color scheme in Kate, change the global color scheme

REPOSITORY
  R265 KConfigWidgets

BRANCH
  preventchanges (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25875

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager_p.h

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Marco Martin]

mart added a comment.


  In D25015#568865 , @niccolove 
wrote:
  
  > Got it. The shape is actually rounded BUT the desktop contract effect is 
applied in the whole rectangle underneath, and it makes everything look like a 
rectangle. Here's the widget with fully transparent background, but with the 
contract effect on:
  >  F7788618: Screenshot_20191128_153515.png 

  >  Of course, I can't just turn off the contrast desktop effect. I'm unsure 
how to move forward with this.
  >  Here's Plasma without desktop effect:
  >  F7788630: Screenshot_20191128_154652.png 

  >  As you can see, shadows are working!
  
  
  Not sure why it looks rectangular, on current theme the mark prefix is 
correctly used and the blur is correctly shaped with rounded borders

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25865: kfilemetadata EBN transport protocol cleanup

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> xmlextractor.cpp:33
> +inline QString rdfNS(){ return 
> QStringLiteral("https://www.w3.org/1999/02/22-rdf-syntax-ns#;); }
> +inline QString ccNS() { return 
> QStringLiteral("https://creativecommons.org/ns#;); }
>  

sure about those? they look suspiciously like XML namespace URIs, not URLs?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25865

To: jhayes
Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Please don't link external sites (GitHub) in the committed message.
  
  RE: Menu
  There is nothing in QQC2::Button to add a menu
  
  If we want that it would have to be a custom button subclass, rather than 
something we support in the style.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:c3e6627e598b: [QImageItem/QPixmapItem] Dont lose 
precision during calculation (authored by broulik).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25685?vs=70758=71252

REVISION DETAIL
  https://phabricator.kde.org/D25685

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp
  src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25829: kconfig EBN transport protocol cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:975aaeeff483: kconfig EBN transport protocol cleanup 
(authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25829?vs=71148=71249

REVISION DETAIL
  https://phabricator.kde.org/D25829

AFFECTED FILES
  src/core/kconfig.h
  src/core/kdesktopfile.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: jhayes, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25864: kdeclarative EBN spelling cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:ab35bc727cb7: kdeclarative EBN spelling cleanup (authored 
by jhayes, committed by cgiboudeaux).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25864?vs=71227=71248

REVISION DETAIL
  https://phabricator.kde.org/D25864

AFFECTED FILES
  src/quickaddons/managedconfigmodule.h

To: jhayes, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25866: kholidays EBN transport protocol cleanup

[Christophe Giboudeaux]

This revision was automatically updated to reflect the committed changes.
Closed by commit R175:98e731d68581: kholidays EBN transport protocol cleanup 
(authored by jhayes, committed by cgiboudeaux).

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25866?vs=71237=71247

REVISION DETAIL
  https://phabricator.kde.org/D25866

AFFECTED FILES
  src/astroseasons.h
  src/holidayregion.h
  src/lunarphase.h
  src/parsers/qcalendarsystem.cpp
  src/sunriseset.cpp
  src/zodiac.h

To: jhayes, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25864: kdeclarative EBN spelling cleanup

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  ebn-spelling-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25864

To: jhayes, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25866: kholidays EBN transport protocol cleanup

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R175 KHolidays

BRANCH
  ebn-transport-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25866

To: jhayes, cgiboudeaux
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns