Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Friedrich W. H. Kossebau]

Am Samstag, 21. Dezember 2019, 23:32:10 CET schrieb Stephen Kelly:
> On 21/12/2019 19:12, Friedrich W. H. Kossebau wrote:
> > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
> >> Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> >> 
> >> I've pushed a few commits to make it depend on ECM etc.
> >> 
> >> Once the review period is finished it can be part of KF5 releases.
> > 
> > There are quite some things which yet need to be done for now:
> > to be a true KF module there is a set of policies which needs to be met,
> > see https://community.kde.org/Frameworks/Policies
> > 
> > 1) Framework directory structure:
> > moving stuff into src/, autotests/ & docs/
> > 
> > 2) Framework documentation:
> > current system needs adaption to both online (KApiDox) and
> > offline (ECMAddQCH) systems
> 
> Cool, I wonder if there's another multi-library framework for comparison?

With ECMAddQCH, Sonnet & KNewStuff create separate QCH files for their 
multiple libs.

With KApiDox, IIRC it has the assumption 1 module <=> 1 documentation unit 
(not involved there),
Olivier (cc:ed) should be able to hint you what is possible.

> > Another challenge would be moving into the KF5 namespace for the library
> > artifacts (at least I would expect/recommend this to happen, for
> > consistent
> > user experience)
> > a) include dirs below subdir KF5/
> > b) CMake modules with KF5 prefix
> > c) CMake imported target in KF5 namespace
> 
> I don't support changing things like this in the KF5 timeframe.

IMHO not sharing the namespace "KF5" spoils the story of KDE Frameworks, where 
the namespace gives consistent developer experience and product messaging.

Having Grantlee being a special kid, with unregular CMake modules names and 
differently namespace imported CMake targets, makes things more complex.

Being consistent is what we so like about Qt, and KF should not stay behind, 
no?

Perhaps joining the "Release Service" (formerly known as "KDE Applications") 
is a better place then, it also contains a set of libraries already.
That would serve the purpose of having releases happening regularly.

Cheers
Friedrich

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Stephen Kelly]

On 21/12/2019 19:12, Friedrich W. H. Kossebau wrote:

Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:

Great, Grantlee is now available at g...@git.kde.org:grantlee.git.

I've pushed a few commits to make it depend on ECM etc.

Once the review period is finished it can be part of KF5 releases.

There are quite some things which yet need to be done for now:
to be a true KF module there is a set of policies which needs to be met, see
https://community.kde.org/Frameworks/Policies

1) Framework directory structure:
moving stuff into src/, autotests/ & docs/
2) Framework documentation:
current system needs adaption to both online (KApiDox) and
offline (ECMAddQCH) systems



Cool, I wonder if there's another multi-library framework for comparison?



Another challenge would be moving into the KF5 namespace for the library
artifacts (at least I would expect/recommend this to happen, for consistent
user experience)
a) include dirs below subdir KF5/
b) CMake modules with KF5 prefix
c) CMake imported target in KF5 namespace



I don't support changing things like this in the KF5 timeframe.



Now, the question is if we want Grantlee to be backwards-compatible after the
move into KDE Frameworks, or if some breakage is possible?

When it comes to CMake targets & modules, the first challenge is:

Grantlee5 supports components, "Templates" & "TextDocument". To allow people
doing e.g.
--- 8< ---
find_package(Grantlee5 CONFIG COMPONENTS Templates)
--- 8< ---
So when Grantlee becomes a component in KF5 itself, so people would use for
finding it
--- 8< ---
find_package(KF5 CONFIG COMPONENTS Grantlee)
--- 8< ---
these two, "Templates" & "TextDocument", would need to become subcomponents.
Which though is a concept CMake does not support.

So what to do here? Split Grantlee into two separate libs, with separate CMake
config files? Done by KF5NewStuff, where one repo provides 2 separate configs.
Or just merge and do not allow making dep chain more narrow (Grantlee's
TextDocument pulls in QtGui as dep, so fails if no devel package not present)?


Then Grantlee's CMake module brings two namespaced imported targets:
* Grantlee5::Templates
* Grantlee5::TextDocument
With Grantlee being part of KDE Frameworks, one would expect to have targets
named like
* KF5::GrantleeTemplates
* KF5::GrantleeTextDocument
or similar.


I'm fine with any of this kind of stuff in the KF6 timeframe.



Just, seems CMake does not expect the use case of exporting targets with
different names, there is only one property available to set the base name,
cmp. current
--- 8< ---
set_property(TARGET Grantlee_Templates PROPERTY EXPORT_NAME Templates)
--- 8< ---
So when wanting to keep backward compatibility, we are stuck here with the old
basenames.
Do you know any simple trick to have a separate CMake config file with
separate imported targets, which still refer to the same library executable?
Never done myself, so no idea what could be done. Doing a separate target and
exporting that one will fail possibly once trying to set OUTPUT_NAME property
to the same,
Perhaps one could do a manual cmake config file which has the old one as
find_dependency and then defines an alias target on the imported target?



I don't think any of this matters in the KF6 timeframe.

Thanks,

Stephen.

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Stephen Kelly]

On 21/12/2019 21:33, Volker Krause wrote:

* Attracting external components and having them opt to move under the
Frameworks umbrella is a sign that we are doing things right IMHO. So let's
make this easy for people and avoid scaring off their users by forcing a
larger migration on them when joining Frameworks.



I definitely want to keep things as they are. Grantlee has lots of 
users. The mutual advantages of making Grantlee a KF5 Framework without 
changing how it's used in CMake (aside from a few minor details like the 
fact of the ECM dependency) are what makes KF5 attractive.




* We are less than two years away from KF6, a time where people expect to have
to do a larger migration anyway. Deferring some of the necessary changes to
then might be a compromise that works for now.



This seems like the right way to me. Let's make the fundamental changes 
for KF6. The timing of KF6 and the introduction of Grantlee to KF5 are 
favorable to that.



Another option is to skip KF5 and make Grantlee a KF6 frameworks 
whenever that opens.




Thoughts?

Thanks,
Volker

PS: @Steve: I missed the doxygen discussion on IRC earlier, customizing
doxygen is possible via docs/Doxyfile.local, which just gets appended to the
Doxyfile from kapidox IIUC, maybe that helps already?



Cool, I'll look into it.

Thanks,

Stephen.

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre updated this revision to Diff 71976.
davidre added a comment.


  remove qdebug

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25877?vs=71975=71976

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre updated this revision to Diff 71975.
davidre added a comment.


  Remove stuff that was just for testing and included in the diff by mistake

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25877?vs=71974=71975

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Volker Krause]

On Saturday, 21 December 2019 20:12:48 CET Friedrich W. H. Kossebau wrote:
> Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
> > Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> > 
> > I've pushed a few commits to make it depend on ECM etc.
> > 
> > Once the review period is finished it can be part of KF5 releases.
> 
> There are quite some things which yet need to be done for now:
> to be a true KF module there is a set of policies which needs to be met, see
> https://community.kde.org/Frameworks/Policies
> 
> 1) Framework directory structure:
>moving stuff into src/, autotests/ & docs/
> 2) Framework documentation:
>current system needs adaption to both online (KApiDox) and
>offline (ECMAddQCH) systems
> 
> I could do 1) if you like, and help with 2) on the ECMAddQCH part.
> 
> Another challenge would be moving into the KF5 namespace for the library
> artifacts (at least I would expect/recommend this to happen, for consistent
> user experience)
> a) include dirs below subdir KF5/
> b) CMake modules with KF5 prefix
> c) CMake imported target in KF5 namespace
> 
> Now, the question is if we want Grantlee to be backwards-compatible after
> the move into KDE Frameworks, or if some breakage is possible?
> 
> When it comes to CMake targets & modules, the first challenge is:
> 
> Grantlee5 supports components, "Templates" & "TextDocument". To allow people
> doing e.g.
> --- 8< ---
> find_package(Grantlee5 CONFIG COMPONENTS Templates)
> --- 8< ---
> So when Grantlee becomes a component in KF5 itself, so people would use for
> finding it
> --- 8< ---
> find_package(KF5 CONFIG COMPONENTS Grantlee)
> --- 8< ---
> these two, "Templates" & "TextDocument", would need to become subcomponents.
> Which though is a concept CMake does not support.
> 
> So what to do here? Split Grantlee into two separate libs, with separate
> CMake config files? Done by KF5NewStuff, where one repo provides 2 separate
> configs. Or just merge and do not allow making dep chain more narrow
> (Grantlee's TextDocument pulls in QtGui as dep, so fails if no devel
> package not present)?
> 
> 
> Then Grantlee's CMake module brings two namespaced imported targets:
> * Grantlee5::Templates
> * Grantlee5::TextDocument
> With Grantlee being part of KDE Frameworks, one would expect to have targets
> named like
> * KF5::GrantleeTemplates
> * KF5::GrantleeTextDocument
> or similar.
> 
> Just, seems CMake does not expect the use case of exporting targets with
> different names, there is only one property available to set the base name,
> cmp. current
> --- 8< ---
> set_property(TARGET Grantlee_Templates PROPERTY EXPORT_NAME Templates)
> --- 8< ---
> So when wanting to keep backward compatibility, we are stuck here with the
> old basenames.
> Do you know any simple trick to have a separate CMake config file with
> separate imported targets, which still refer to the same library executable?
> Never done myself, so no idea what could be done. Doing a separate target
> and exporting that one will fail possibly once trying to set OUTPUT_NAME
> property to the same,
> Perhaps one could do a manual cmake config file which has the old one as
> find_dependency and then defines an alias target on the imported target?

Backward compatibility with new frameworks coming in with an existing internal 
and external user base is a good question though, this also came up with 
QKeychain recently.

That is, do we break ABI/API as part of the inclusion into Frameworks, to make 
them fully comply with all Framework policies, or do we allow for exemptions 
for the current major release in this case? Ultimately it's a tradeoff between 
ease of migration for existing code bases (which aren't just our own, but also 
those of the users the new framework brings in), and consistency in 
Frameworks.

I'm undecided on this myself still:

* Consistency is an important part of the Frameworks product story (even if we 
aren't perfectly following this everywhere).

* Attracting external components and having them opt to move under the 
Frameworks umbrella is a sign that we are doing things right IMHO. So let's 
make this easy for people and avoid scaring off their users by forcing a 
larger migration on them when joining Frameworks.

* We are less than two years away from KF6, a time where people expect to have 
to do a larger migration anyway. Deferring some of the necessary changes to 
then might be a compromise that works for now.

Thoughts?

Thanks,
Volker

PS: @Steve: I missed the doxygen discussion on IRC earlier, customizing 
doxygen is possible via docs/Doxyfile.local, which just gets appended to the 
Doxyfile from kapidox IIUC, maybe that helps already?

signature.asc
Description: This is a digitally signed message part.

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre updated this revision to Diff 71974.
davidre added a comment.
This revision is now accepted and ready to land.


  remove comment

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25877?vs=71355=71974

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager.h
  src/kcolorschememanager_p.h

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre added a comment.


  Nevermind confused myself, I was not changing the `UserRole` data but the 
data of the actions of the menu. For that there are no guarantees documented.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25877: [KColorschemeManager] Add option to reenable following global theme

[David Redondo]

davidre planned changes to this revision.
davidre added a comment.


  Changing the `UserRole` is not the best

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: Show more details in warning dialog shown before starting a privileged operation

[Nathaniel Graham]

ngraham retitled this revision from "[WIP]Show more details in warning dialog 
shown before starting a privileged operation" to "Show more details in warning 
dialog shown before starting a privileged operation".

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D21783: [WIP]Show more details in warning dialog shown before starting a privileged operation

[David Faure]

dfaure added a comment.


  (remember to remove the [WIP] from the commit log, if you still have it 
locally)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

[Christoph Cullmann]

cullmann added a comment.


  In D24568#580338 , @kossebau wrote:
  
  > This has been missing the link from an rst file  in docs/, so the 
documentation generation picks up the file. Fixed with 
c4890d5c03ed79f0c87da861b6608bbd46c2162c 

  
  
  Thanks for adding that!
  
  Any feedback on the other issues people?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure, broulik, davidedmundson
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

[Nathaniel Graham]

ngraham added a comment.


  In D26113#581227 , @bruns wrote:
  
  > The mount path is the only useful identifier. There is no filesystem label 
or similar.
  >
  > As Vaults are not backed by an fstab entry, it would be the responsibility 
of Vaults to set a useful name (via x-gvfs-name).
  
  
  What I'm saying is that I think it makes sense for Solid to provide a better 
default display string so each app doesn't have to do this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26113: Places: For mounted volume display mount points instead of description

[Stefan Brüns]

bruns added a comment.


  The mount path is the only useful identifier. There is no filesystem label or 
similar.
  
  As Vaults are not backed by an fstab entry, it would be the responsibility of 
Vaults to set a useful name (via x-gvfs-name).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

[Friedrich W. H. Kossebau]

Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
> Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> 
> I've pushed a few commits to make it depend on ECM etc.
> 
> Once the review period is finished it can be part of KF5 releases.

There are quite some things which yet need to be done for now:
to be a true KF module there is a set of policies which needs to be met, see 
https://community.kde.org/Frameworks/Policies

1) Framework directory structure:
   moving stuff into src/, autotests/ & docs/
2) Framework documentation:
   current system needs adaption to both online (KApiDox) and
   offline (ECMAddQCH) systems

I could do 1) if you like, and help with 2) on the ECMAddQCH part.

Another challenge would be moving into the KF5 namespace for the library 
artifacts (at least I would expect/recommend this to happen, for consistent 
user experience)
a) include dirs below subdir KF5/
b) CMake modules with KF5 prefix
c) CMake imported target in KF5 namespace

Now, the question is if we want Grantlee to be backwards-compatible after the 
move into KDE Frameworks, or if some breakage is possible?

When it comes to CMake targets & modules, the first challenge is:

Grantlee5 supports components, "Templates" & "TextDocument". To allow people 
doing e.g.
--- 8< ---
find_package(Grantlee5 CONFIG COMPONENTS Templates)
--- 8< ---
So when Grantlee becomes a component in KF5 itself, so people would use for 
finding it
--- 8< ---
find_package(KF5 CONFIG COMPONENTS Grantlee)
--- 8< ---
these two, "Templates" & "TextDocument", would need to become subcomponents. 
Which though is a concept CMake does not support.

So what to do here? Split Grantlee into two separate libs, with separate CMake 
config files? Done by KF5NewStuff, where one repo provides 2 separate configs.
Or just merge and do not allow making dep chain more narrow (Grantlee's 
TextDocument pulls in QtGui as dep, so fails if no devel package not present)?


Then Grantlee's CMake module brings two namespaced imported targets:
* Grantlee5::Templates
* Grantlee5::TextDocument
With Grantlee being part of KDE Frameworks, one would expect to have targets 
named like
* KF5::GrantleeTemplates
* KF5::GrantleeTextDocument
or similar.

Just, seems CMake does not expect the use case of exporting targets with 
different names, there is only one property available to set the base name, 
cmp. current
--- 8< ---
set_property(TARGET Grantlee_Templates PROPERTY EXPORT_NAME Templates)
--- 8< ---
So when wanting to keep backward compatibility, we are stuck here with the old 
basenames.
Do you know any simple trick to have a separate CMake config file with 
separate imported targets, which still refer to the same library executable?
Never done myself, so no idea what could be done. Doing a separate target and 
exporting that one will fail possibly once trying to set OUTPUT_NAME property 
to the same,
Perhaps one could do a manual cmake config file which has the old one as 
find_dependency and then defines an alias target on the imported target?

Cheers
Friedrich

D26146: Delete icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:77058387f41c: Delete icon (authored by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26146?vs=71960=71971

REVISION DETAIL
  https://phabricator.kde.org/D26146

AFFECTED FILES
  CMakeLists.txt
  icons/128-apps-baloo.png
  icons/CMakeLists.txt

To: ngraham, #baloo, #vdg, IlyaBizyaev, ndavis
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 234 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/234/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 18:56:27 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25683: KDirOperator: Use a fixed line height for scroll speed

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:59b944470470: KDirOperator: Use a fixed line height for 
scroll speed (authored by ahiemstra, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25683?vs=70753=71969

REVISION DETAIL
  https://phabricator.kde.org/D25683

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp
  src/filewidgets/kdiroperatoriconview.cpp

To: ahiemstra, ngraham, elvisangelaccio
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26148: Add truncation support to FileJob

[Alexander Saoutkin]

feverfew created this revision.
feverfew added reviewers: fvogt, dfaure, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
feverfew requested review of this revision.

REVISION SUMMARY
  This patch adds support for truncation for FileJob.
  It also implements this function in the file slave.

TEST PLAN
  Tested in conjunction with KIOFuse, does truncation
  correctly.

REPOSITORY
  R241 KIO

BRANCH
  TruncateSupport

REVISION DETAIL
  https://phabricator.kde.org/D26148

AFFECTED FILES
  src/core/commands_p.h
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/global.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, fvogt, dfaure, sitter
Cc: ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, 
michaelh, bruns

D26146: Delete icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  delete-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26146

To: ngraham, #baloo, #vdg, IlyaBizyaev, ndavis
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Nathaniel Graham]

ngraham added a comment.


  I'm using your Dolphin branch but I don't see it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26146: Delete icon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Baloo, VDG, IlyaBizyaev.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  There's a Breeze icon now, so we don't need to ship an old, different, raster 
image with
  Baloo itself anymore.

TEST PLAN
  There's no longer a `/usr/share/icons/hicolor/128x128/apps/baloo.png` icon

REPOSITORY
  R293 Baloo

BRANCH
  delete-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26146

AFFECTED FILES
  CMakeLists.txt
  icons/128-apps-baloo.png
  icons/CMakeLists.txt

To: ngraham, #baloo, #vdg, IlyaBizyaev
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Kai Uwe Broulik]

broulik added a comment.


  I added icon size context menu in dolphin

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

[Nathaniel Graham]

ngraham added a comment.


  One thing I notice has been lost is the ability to choose the size of the 
icons. Dolphin currently exposes this in the context menu for places panel 
headers. The File dialog does something different and automatically resizes the 
icons according to how much vertical space is available in the dialog. However 
with this patch and your Dolphin branch, neither one is available and the icon 
sizes appear to be immutable.
  
  It would be nice to unify the behavior between Dolphin and the file dialog 
with this patchset. We get bugs about them being different.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26145: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: mlaurent, vkrause.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  With QRegularExpression \x escape sequences that use more than two
  hex digists have be in the form \x{}.

TEST PLAN
  make && ctest
  All unit tests pass except kcontacts-addresstest, but it fails with the
  same exact error on master too, so it's not any worse.

REPOSITORY
  R174 KContacts

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26145

AFFECTED FILES
  src/addressee.cpp

To: ahmadsamir, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

[Nathaniel Graham]

ngraham added a comment.


  We can make the name override more discoverable for sure. But IMO we should 
also improve the default presentation, because this is just yucky: F7828189: 
Screenshot_20191221_092825.png 
  
  None of my other mounted devices insist on showing their full path or the 
format of the mount/device.
  
  Maybe we should discuss that in a phab task before submitting patches.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26044: Set breeze as default theme when reading from configuration file

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26044

To: bport, #plasma, ervin, crossi, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

[Benjamin Port]

bport marked 2 inline comments as done.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D26044

To: bport, #plasma, ervin, crossi
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26044: Set breeze as default theme when reading from configuration file

[Benjamin Port]

bport updated this revision to Diff 71955.
bport added a comment.


  QString to QStringLiteral

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26044?vs=71671=71955

REVISION DETAIL
  https://phabricator.kde.org/D26044

AFFECTED FILES
  src/kiconloader.cpp
  src/kicontheme.cpp

To: bport, #plasma, ervin, crossi
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  I guess I was confused because I saw KItemModels has the min. Qt version 
5.12.0

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26099

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26099: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71954.
ahmadsamir added a comment.


  Don't assign inside if condition

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26099?vs=71943=71954

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26099

AFFECTED FILES
  src/kioslaves/timeline/timelinetools.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26113: Places: For mounted volume display mount points instead of description

[Méven Car]

meven added a comment.


  In D26113#581021 , @bruns wrote:
  
  > I would consider an item changing its name based on the state a bug.
  >
  > As said, the name *is*configurable.
  
  
  I am leaning towards abandoning this and D26114 
.
  
  Instead we might want to improve discoverability and documentation of  
`x-gvfs-name` configuration path.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26099: Port QRegExp to QRegularExpression

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> timelinetools.cpp:119
> +QRegularExpressionMatch match;
> +if ((match = s_dateRegexp.match(sections.last())).hasMatch()) {
>  dateString = sections.last();

Pleae avoid assigning in an `if (...)` expression, just move it to the previous 
line.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26099

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26118: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71948.
ahmadsamir added a comment.


  KF5 now requires Qt 5.12

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26118?vs=71884=71948

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26118

AFFECTED FILES
  src/kauthaction.cpp
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

[Stefan Brüns]

bruns added a comment.


  I think the Summary is very poor.
  
  You only give a phenomenological reason (it no longer crashes), but thats 
insufficient. State what happens without the change (i.e. who owns what), and 
why doing it differently is **always** correct.
  
  Giving a good summary makes reviewing much easier, and also helps any later 
contributors.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26117

To: anthonyfieroni, broulik, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26117: [solid] Clarify referencing of DeviceInterface

[Stefan Brüns]

bruns requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26117

To: anthonyfieroni, broulik, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26113: Places: For mounted volume display mount points instead of description

[Stefan Brüns]

bruns added a comment.


  I would consider an item changing its name based on the state a bug.
  
  As said, the name *is*configurable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

Re: Submitting Grantlee as a KF5 Framework

[laurent Montel]

Le samedi 21 décembre 2019, 13:03:17 CET Stephen Kelly a écrit :
> On 08/12/2019 10:12, laurent Montel wrote:
> > Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit :
> >> Hi,
> >> 
> >> very happy to see Grantlee "coming home" :)
> >> 
> >> Technically I think it's largely in line with Frameworks requirements
> >> already, and it has been reliably powering e.g. KMail's message viewer
> >> for
> >> years. Moving to a faster and, more importantly, predictable release
> >> cycle
> >> would help us a lot with upstreaming extensions and improvements though,
> >> and would allow us to get rid of some repeated code in applications.
> > 
> > Indeed same for kaddressbook/knotes/akregator :)
> > 
> >> Longer term I'd also hope we can add the support for QtGui types (icons,
> >> colors, palettes, etc) that is currently spread around application code,
> >> either as a plugin in the Grantlee repo directly, or as a tier 2
> >> framework
> >> on top.
> >> 
> >> So, definitely a +1 from me!
> > 
> > +1 for me too
> 
> Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> 
> I've pushed a few commits to make it depend on ECM etc.
> 
> Once the review period is finished it can be part of KF5 releases.
> 
> Thanks,
> 
> Stephen.


Thanks a lot Stephen !
Regards

-- 
Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer 
KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, 
 www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent 
software solutions 

D26099: Port QRegExp to QRegularExpression

[Méven Car]

meven accepted this revision.
meven added a comment.


  Seems fine to me

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26099

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26099: Port QRegExp to QRegularExpression

[Méven Car]

meven added a comment.


  In D26099#581001 , @ahmadsamir 
wrote:
  
  > Frameworks now require Qt 5.12
  
  
  Indeed since 65da5bf151fa934bbdcac82543e3cd9f5cc4ab43 
 in 
baloo

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26099

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

Re: Submitting Grantlee as a KF5 Framework

[Friedrich W. H. Kossebau]

Hi Stephen,

Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
> Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> 
> I've pushed a few commits to make it depend on ECM etc.

You pushed only to github though it seems :) Forwarded your commits now to the 
master branch on the main KDE repo. And did some commits to make things even 
more (current) KF-like.

Speaking of making sure all is synced & moved from github to KDE systems:

There are still some merge requests open on https://github.com/steveire/
grantlee/pulls. Also are there some open issues which might be wanted to be 
moved over to bugs.kde.org?

Cheers
Friedrich

D26106: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir edited reviewers, added: Frameworks; removed: Framework: Syntax 
Highlighting.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26106

To: ahmadsamir, drosca, #frameworks, #framework_syntax_highlighting
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26099: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71943.
ahmadsamir added a comment.


  Frameworks now require Qt 5.12

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26099?vs=71936=71943

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26099

AFFECTED FILES
  src/kioslaves/timeline/timelinetools.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26123: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71941.
ahmadsamir added a comment.


  Frameworks min. required Qt has just been raised to 5.12

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26123?vs=71934=71941

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26123

AFFECTED FILES
  autotests/kemailaddresstest.cpp
  src/kemailaddress.cpp

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26123: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  Sorry, I did reply to your inline comments but didn't "submit" the replies 
only "save draft"ed.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D26123

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26123: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kemailaddress.cpp:631
> Message from Giuseppe D'Angelo  (author of QRegularExpression) : if you can 
> depend from Qt 5.12, there's QRegularExpression::anchoredPattern instead of 
> manual wrapping in \A and \z
> 
> We can't require 5.12 yet but this could be a TODO to simplify this code 
> slightly at some point.

Yep, I added the Qt 5.12 TODO in some QRegExp porting diffs but not all (kind 
of got boring (lots of QRegExp::exactMatch()), but that's not an excuse to be 
lazy and make it harder for the next guy who modifies that code :)).

> dfaure wrote in kemailaddress.cpp:639
> `{,3}` would be `{0,3}`, not `{1,3}`
> 
> Would this allow to minimize the amount of changes made here? I'm worried 
> about regressions.

From the unit test, this is to match literal domains, [123.123.123.123]; but 
the old code would match:
[.123.123.123]
[..123.123]
which seems wrong to me; as proven by this snippet in qtcreator (best way to 
test regex's is to just literally test them, that is more idiot-proof for me 
:)):

  const QString str = QStringLiteral("[1.1.1.1]");
  const QString str2 = QStringLiteral("[.1.1.1]");
  const QString str3 = QStringLiteral("[..1.1]");
  
  const QString pattern = QStringLiteral("\\[[0-9]{,3}(\\.[0-9]{,3}){3}\\]");
  QRegExp re(pattern);
  
  qDebug() << re.exactMatch(str); // true
  qDebug() << re.exactMatch(str2); // true
  qDebug() << re.exactMatch(str3); // true

So I dare say even in the old code it should have been {1,3}.

And I found that:

- {,3} in QRegExp is equivalent to {0,3}
- {,3} in QRegularExpression is equivalent to {1,3}

  const QString str = QStringLiteral("a");
  const QString oldPattern = QStringLiteral("\\d{,3}"); // QRegExp _is_ old
  QRegExp oldRe(oldPattern);
  qDebug() << (oldRe.indexIn(str) != -1); // true, because it's {0,3}
  
  const QString pattern = QStringLiteral("\\d{,3}");
  QRegularExpression re(pattern);
  qDebug() << re.match(str).hasMatch(); // false, because it's {1,3}

(^ candidate for QRegExp (its docs literally mention {,n}) to 
QRegularExpression porting notes in QRegularExpression docs, if you can pass 
that to Giuseppe D'Angelo :)).

> dfaure wrote in kemailaddress.cpp:639
> `{,3}` would be `{0,3}`, not `{1,3}`
> 
> Would this allow to minimize the amount of changes made here? I'm worried 
> about regressions.

I added two more rows to the literal domain test code and found that, my code 
is wrong too:

  addrRx += QStringLiteral("\\[([0-9]{1,3}\\.){1,3}([0-9]{1,3})\\]");
  is wrong, it should be:
  addrRx += QStringLiteral("\\[([0-9]{1,3}\\.){3}([0-9]{1,3})\\]");
  ^^^

I'll upload a new diff.

> dfaure wrote in kemailaddress.cpp:639
> I'm confused, you still have `1,3` here, rather than `0,3`

I had replied to your comment but didn't "submit" my comments (stooopid, sorry).

> dfaure wrote in kemailaddress.cpp:1119
> Also from Giuseppe : the `\\x0080-\\x` requires changes to 
> `\\x{0080}-\\x{}`

Thank him for me, and thank you for asking him to take a look at it :D; from 
https://perldoc.perl.org/perlre.html:

> Similarly, \xnn, where nn are hexadecimal digits, matches the character whose 
> native ordinal is nn. Again, not using exactly two digits is a recipe for 
> disaster, but you can use \x{...} to specify any number of hex digits.

so, disaster averted.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D26123

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/48/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Dec 2019 11:38:08 +
 Build duration:
1 hr 3 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.66.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)84%
(27108/32221)53%
(10897/20713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12381/12592)50%
(6501/13117)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6324/7468)65%
(1835/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7949/9505)63%
(2384/3769)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 233 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/233/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 12:02:42 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:39:25 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D26123: Port QRegExp to QRegularExpression

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dfaure wrote in kemailaddress.cpp:639
> `{,3}` would be `{0,3}`, not `{1,3}`
> 
> Would this allow to minimize the amount of changes made here? I'm worried 
> about regressions.

I'm confused, you still have `1,3` here, rather than `0,3`

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D26123

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:38:07 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.13 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.13/36/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Dec 2019 11:32:41 +
 Build duration:
44 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Codecs-5.66.0.xmlcompat_reports/KF5Codecs_compat_report.htmllogs/KF5Codecs/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kencodingprobertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)85%
(50/59)85%
(50/59)73%
(2796/3827)54%
(1183/2207)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)97%
(650/667)60%
(111/184)src81%
(13/16)81%
(13/16)74%
(1493/2008)63%
(840/1344)src.probers84%
(31/37)84%
(31/37)57%
(653/1152)34%
(232/679)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 90 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/90/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Dec 2019 11:38:07 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.66.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27277/32224)53%
(11011/20713)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12517/12592)50%
(6598/13117)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6332/7469)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7974/9507)64%
(2400/3769)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:37:06 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

Re: Submitting Grantlee as a KF5 Framework

[Stephen Kelly]

On 08/12/2019 10:12, laurent Montel wrote:

Le dimanche 8 décembre 2019, 10:52:19 CET Volker Krause a écrit :

Hi,

very happy to see Grantlee "coming home" :)

Technically I think it's largely in line with Frameworks requirements
already, and it has been reliably powering e.g. KMail's message viewer for
years. Moving to a faster and, more importantly, predictable release cycle
would help us a lot with upstreaming extensions and improvements though,
and would allow us to get rid of some repeated code in applications.

Indeed same for kaddressbook/knotes/akregator :)


Longer term I'd also hope we can add the support for QtGui types (icons,
colors, palettes, etc) that is currently spread around application code,
either as a plugin in the Grantlee repo directly, or as a tier 2 framework
on top.

So, definitely a +1 from me!

+1 for me too



Great, Grantlee is now available at g...@git.kde.org:grantlee.git.

I've pushed a few commits to make it depend on ECM etc.

Once the review period is finished it can be part of KF5 releases.

Thanks,

Stephen.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 232 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/232/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:35:30 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/46/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:36:41 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/27/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:35:16 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/53/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:33:43 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:33:54 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 131 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/131/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Dec 2019 11:33:12 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6881/9062)43%
(10735/24717)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2882/2974)49%
(6147/12629)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(868/1307)35%
(992/2823)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(670/787)42%
(948/2251)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)83%
(987/1184)51%
(1008/1993)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/79/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:33:12 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » kcodecs » kf5-qt5 SUSEQt5.12 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20SUSEQt5.12/64/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 21 Dec 2019 11:32:41 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Codecs-5.66.0.xmlcompat_reports/KF5Codecs_compat_report.htmllogs/KF5Codecs/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kencodingprobertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)85%
(50/59)85%
(50/59)73%
(2796/3827)54%
(1183/2207)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)97%
(650/667)60%
(111/184)src81%
(13/16)81%
(13/16)74%
(1493/2008)63%
(840/1344)src.probers84%
(31/37)84%
(31/37)57%
(653/1152)34%
(232/679)

Frameworks minimum Qt version raised to 5.12

[Albert Astals Cid]

I just executed the policy that says last three Qt versions, i.e. 5.12, 5.13 
and 5.14

Cheers,
  Albert

P.S: Since we have the new Qt LTS exception to the policy we won't be raising 
the minimum requirement until Qt 5.16 is released (assuming Qt 5.15 is LTS and 
there is a Qt 5.16) and then we will support QT 5.14, 5.15 and 5.16

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:32:28 +
 Build duration:
9 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 489 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kcodecs » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcodecs/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:32:40 +
 Build duration:
8 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 6 test(s)Failed: projectroot.autotests.kencodingprobertest

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 56 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/56/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 11:31:24 +
 Build duration:
4 min 52 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 0 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 33 test(s)

D26099: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71936.
ahmadsamir added a comment.


  Add TODO for when we can depend on Qt 5.12

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26099?vs=71888=71936

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26099

AFFECTED FILES
  src/kioslaves/timeline/timelinetools.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26106: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26106

To: ahmadsamir, drosca, #framework_syntax_highlighting
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

[Ahmad Samir]

ahmadsamir added a reviewer: mlaurent.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26102

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D26123: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 71934.
ahmadsamir marked 4 inline comments as done.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Address review comments

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26123?vs=71907=71934

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26123

AFFECTED FILES
  autotests/kemailaddresstest.cpp
  src/kemailaddress.cpp

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26138: qrand is deprecated. Port to QRandomGenerator

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:fb25d833103b: qrand is deprecated. Port to 
QRandomGenerator (authored by mlaurent).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26138?vs=71929=71930

REVISION DETAIL
  https://phabricator.kde.org/D26138

AFFECTED FILES
  src/postfiledata.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26138: qrand is deprecated. Port to QRandomGenerator

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R235 Attica

BRANCH
  port_to_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26138

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.13/55/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Dec 2019 08:22:51 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.filewatchtest

D26138: qrand is deprecated. Port to QRandomGenerator

[Laurent Montel]

mlaurent edited the test plan for this revision.
mlaurent added a reviewer: dfaure.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D26138

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26138: qrand is deprecated. Port to QRandomGenerator

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QRandomGenerator

REPOSITORY
  R235 Attica

BRANCH
  port_to_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26138

AFFECTED FILES
  src/postfiledata.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26060: Port to QRandomGenerator (qrand was deprecated in qt5.15)

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:82fdd07d387d: Port to QRandomGenerator (qrand was 
deprecated in qt5.15) (authored by mlaurent).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26060?vs=71830=71928

REVISION DETAIL
  https://phabricator.kde.org/D26060

AFFECTED FILES
  autotests/kfiltertest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26062: Port to QRandomGenerator

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b5c7c6b7012a: Port to QRandomGenerator (authored by 
mlaurent).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26062?vs=71829=71927

REVISION DETAIL
  https://phabricator.kde.org/D26062

AFFECTED FILES
  autotests/unit/lib/filemonitortest.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams