D26137: Add KPluginMetaData::supportsMimeType

2019-12-22 Thread David Faure
dfaure closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26137

To: dfaure, arichardson, aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R174:66ed335757c5: Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26145?vs=71996&id=72038

REVISION DETAIL
  https://phabricator.kde.org/D26145

AFFECTED FILES
  src/addressee.cpp

To: ahmadsamir, mlaurent, vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir marked 2 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> apol wrote in docbookl10nhelper.cpp:184
> Just do `QRegularExpressionMatch match = rxEntity.match(line);`

I did it that way to indicate match is going to be re-assigned-to later on, but 
it does look off a bit. :)

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26156

To: ahmadsamir, #documentation, ltoscano
Cc: apol, kde-doc-english, kde-frameworks-devel, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 72037.
ahmadsamir added a comment.


  Make QRegularExpression objects const.
  
  Declare and assign on one line.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26156?vs=72004&id=72037

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26156

AFFECTED FILES
  src/docbookl10nhelper.cpp
  src/xslt.cpp

To: ahmadsamir, #documentation, ltoscano
Cc: apol, kde-doc-english, kde-frameworks-devel, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D26158: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:6d6327868c8c: Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26158?vs=72006&id=72036

REVISION DETAIL
  https://phabricator.kde.org/D26158

AFFECTED FILES
  src/extractors/officeextractor.cpp

To: ahmadsamir, #baloo, bruns, apol
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D26136: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir added a comment.


  In D26136#581721 , @apol wrote:
  
  > I'm a bit confused as to why the regex needs to be different. Explain in 
the commit message?
  
  
  Fair point. Done.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26136

To: ahmadsamir, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26136: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 72035.
ahmadsamir added a comment.


  Explain why the regex was changed

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26136?vs=71923&id=72035

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26136

AFFECTED FILES
  src/ktipdialog.cpp

To: ahmadsamir, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 252 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/252/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 23 Dec 2019 04:33:10 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_privilegejobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34606/61743)40%
(17575/43590)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9635/10105)47%
(4494/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8612/14561)51%
(4505/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4662/8294)43%
(2028/4744)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(686/1249)40%
(384/965)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 370 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/370/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 23 Dec 2019 04:33:10 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_privilegejobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34591/61741)40%
(17571/43594)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9635/10105)47%
(4498/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8603/14560)51%
(4502/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4661/8294)43%
(2029/4748)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(686/1249)40%
(384/965)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 237 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/237/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 23 Dec 2019 04:33:10 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_privilegejobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26170: i18n: Add more semantic context strings

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-more-msgctxt

REVISION DETAIL
  https://phabricator.kde.org/D26170

To: aspotashev, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26159: Drop KWindowSystem dependency

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R310 KTextWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26159

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26158: Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26158

To: ahmadsamir, #baloo, bruns, apol
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> docbookl10nhelper.cpp:158
>   **/
> -QRegExp rxEntity, rxEntity2, rxDocType, rxDocType2;
> -
> rxDocType.setPattern(QStringLiteral("^\\s* -
> rxDocType2.setPattern(QStringLiteral("^\\s*$"));
> -
> rxEntity.setPattern(QStringLiteral("^\\s*\\s*$"));
> -rxEntity2.setPattern(QStringLiteral("^\\s* language=\"([^\\s]+)\"\\s+href=\"([^\\s]+)\"/>\\s*$"));
> +QRegularExpression 
> rxDocType(QStringLiteral("^\\s* +QRegularExpression 
> rxDocType2(QStringLiteral("^\\s*$"));

const all of these?

> docbookl10nhelper.cpp:184
>  QString langCode, langFile;
> -if (rxEntity.indexIn(line) != -1 && !foundRxEntity2) {
> +QRegularExpressionMatch match;
> +match = rxEntity.match(line);

Just do `QRegularExpressionMatch match = rxEntity.match(line);`

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D26156

To: ahmadsamir, #documentation, ltoscano
Cc: apol, kde-doc-english, kde-frameworks-devel, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R174 KContacts

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26145

To: ahmadsamir, mlaurent, vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26137: Add KPluginMetaData::supportsMimeType

2019-12-22 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26137

To: dfaure, arichardson, aacid, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26136: Port QRegExp to QRegularExpression

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment.


  I'm a bit confused as to why the regex needs to be different. Explain in the 
commit message?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26136

To: ahmadsamir, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26133: Enable Auto Save

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment.


  It could make sense to add a test.
  
  Also for an application (system settings or kconfig dialogs) it's already 
possible to just trigger save when the kcm has changed (we already have signals 
for this). Why do you think it's needed?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26133

To: tcanabrava
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26122: Add utility text function KShell::tildeCollapse

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment.


  I might be missing something, explaining why it's necessary would be useful 
for the commit log as well as for lost reviewers like me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26122

To: meven, #frameworks, broulik, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

2019-12-22 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> kconfig_compiler.cpp:1122
> +// Types that `{}` are ok as return type for default value.
> +if (QVector({
> +QLatin1String("stringlist"),

If instead of creating a QVector you used an initializer list directly, you 
could use std::find_if without having to initialize it entirely. Also you'd be 
able to use QLatin1String which would save constructing unneeded QStrings.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26128

To: tcanabrava
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26126: Simplify param method: Return Early, Use a Map and Assert.

2019-12-22 Thread Aleix Pol Gonzalez
apol added a comment.


  I'd make the types static const, or at least const.
  Also are you sure that here std::map is better than QHash?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26126

To: tcanabrava
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg added a task: T4456: Implement viewporter protocol.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26171

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg added inline comments.

INLINE COMMENTS

> surface_interface.h:130
> + **/
> +BufferInterface *constBuffer() const;
>  QPoint offset() const;

Needed for a call in a const function in KWin. Do we want to do it like that? 
Other suggestions?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26171

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26151: LaTeX: fix brackets in some commands

2019-12-22 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6ddf50d243dd: LaTeX: fix brackets in some commands 
(authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26151?vs=71983&id=72031

REVISION DETAIL
  https://phabricator.kde.org/D26151

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann


D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg added a dependent revision: D26172: Add wp_viewporter support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26171

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26171: Implement wp_viewporter

2019-12-22 Thread Roman Gilg
romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  This patch adds interfaces for specifying viewports via the wp_viewporter
  protocol extension. This allows to make surface size and buffer independent
  from each other. For example a video player can send 1080p video data while
  the window of the player is of different size.
  
  The server interface ViewportInterface is directly integrated with
  SurfaceInterface. Viewport changes are double-buffered by that.

TEST PLAN
  Added auto tests and with weston-scaler.

REPOSITORY
  R127 KWayland

BRANCH
  viewporter

REVISION DETAIL
  https://phabricator.kde.org/D26171

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_viewporter.cpp
  src/client/CMakeLists.txt
  src/client/registry.cpp
  src/client/registry.h
  src/client/viewporter.cpp
  src/client/viewporter.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h
  src/server/viewporter_interface.cpp
  src/server/viewporter_interface.h

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a comment.


  In D26168#581665 , @kossebau wrote:
  
  > Seems you went fully "at it", good work :)
  >
  > "after string freeze" meant "after relase tagging for string freeze 
reasons" , right? ;)
  
  
  Yes, of course.

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  Seems you went fully "at it", good work :)
  
  "after string freeze" meant "after relase tagging for string freeze reasons" 
, right? ;)

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a comment.


  will try to push around January 5, 2020 after string freeze

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26170: i18n: Add more semantic context strings

2019-12-22 Thread Alexander Potashev
aspotashev added a comment.


  will try to push around January 5, 2020 after string freeze

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26170

To: aspotashev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a comment.


  In D26168#581637 , @kossebau wrote:
  
  > Looks good to me for what I know as programmer, but none-translator :)
  >  While at it, for consistency the other tab titles could also get a 
"@title:tab" UI marker context?
  
  
  While at it, yes
  
  https://phabricator.kde.org/D26170

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26170: i18n: Add more semantic context strings

2019-12-22 Thread Alexander Potashev
aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  it compiles

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-more-msgctxt

REVISION DETAIL
  https://phabricator.kde.org/D26170

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kaboutapplicationpersonlistdelegate_p.cpp
  src/kaboutkdedialog_p.cpp
  src/kaboutplugindialog.cpp
  src/kactionconflictdetector.cpp
  src/kbugreport.cpp
  src/kedittoolbar.cpp
  src/kkeysequencewidget.cpp
  src/klicensedialog_p.cpp
  src/kmenumenuhandler_p.cpp
  src/kshortcuteditwidget.cpp
  src/kshortcutschemeseditor.cpp
  src/kshortcutsdialog.cpp
  src/kswitchlanguagedialog_p.cpp
  src/ktoolbar.cpp

To: aspotashev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26167: Update holidays and add flagdays and namedays for Sweden

2019-12-22 Thread Luigi Toscano
ltoscano added a comment.


  Try to use 
  [easter] + 50 days
  
  Example (from Italian holidays):
  
  "Ascensione (Chiesa Cattolica)"   religious on ((year >= 1977) ? ([easter] + 
42 days): noop)
  
  https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?#n47

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D26167

To: riiga
Cc: ltoscano, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Looks good to me for what I know as programmer, but none-translator :)
  While at it, for consistency the other tab titles could also get a 
"@title:tab" UI marker context?
  
  In general I am surprised how little usage of the UI markers are made in 
general. At the time when I wrote the main code of Okteta, it seemed good 
practice to add them everywhere, and so I did. Working on other KDE projects 
since I am confused why no-one else seems to use it... so a bit unsure when to 
use and when not.

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev added a subscriber: kossebau.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26168

To: aspotashev
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26168: i18n: Split translations for strings "Translation"

2019-12-22 Thread Alexander Potashev
aspotashev created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

TEST PLAN
  it compiles

REPOSITORY
  R263 KXmlGui

BRANCH
  i18n-split

REVISION DETAIL
  https://phabricator.kde.org/D26168

AFFECTED FILES
  src/kaboutapplicationdialog.cpp
  src/kaboutplugindialog.cpp
  src/kbugreport.cpp

To: aspotashev
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26167: Update holidays and add flagdays and namedays for Sweden

2019-12-22 Thread Felix Riiga
riiga created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
riiga requested review of this revision.

REVISION SUMMARY
  Holidays for Sweden have been corrected and updated. Flag days have been 
added along with a few other significant cultural days. A separate name day 
calendar has been added. Where known, support has been added for holidays in 
the recent past.
  
  I wasn't able to add support for both versions of "Annandag pingst". It 
changed in 2005 from a public religious holiday to just a religious holiday 
(the public holiday was moved to Nationaldagen instead), but something with the 
calculation of "easter plus 50 days" in brackets seem to result in a syntax 
error. If someone knows how to solve this, I'll fix it, otherwise the best is 
just to leave it as is (religious in entire calendar).

TEST PLAN
  Tested locally with the testholidayregions tool for syntax errors.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D26167

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_se_sv
  holidays/plan2/holiday_se_sv_nameday

To: riiga
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26155: Add RPM support to Krarc

2019-12-22 Thread Nathaniel Graham
ngraham added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26155

To: gengisdave, #frameworks, dfaure
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns


D26054: partial fix for accentuated characters in file name on Windows

2019-12-22 Thread Matthieu Gallien
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:8c066c834c64: partial fix for accentuated characters in 
file name on Windows (authored by mgallien).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26054?vs=71684&id=72019

REVISION DETAIL
  https://phabricator.kde.org/D26054

AFFECTED FILES
  src/writers/taglibwriter.cpp

To: mgallien, bruns, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D26006: Deprecate KPixmapProvider

2019-12-22 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  KIO's KUrlPixmapProvider needs to be deprecated too, preferably before this 
commit lands.

REPOSITORY
  R284 KCompletion

BRANCH
  pmp

REVISION DETAIL
  https://phabricator.kde.org/D26006

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26006: Deprecate KPixmapProvider

2019-12-22 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D26006

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26034: Replace KLocalSocket with QLocalSocket

2019-12-22 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26034

To: nicolasfella, #frameworks, dfaure
Cc: cullmann, vonreth, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns


D26117: [solid] Clarify referencing of DeviceInterface

2019-12-22 Thread Stefan Brüns
bruns added a comment.


  No reason for being rude.
  
  You should know how a reasonable commit message looks like. It should be self 
contained and easy to understand, without requiring everyone to setup a test 
bed first, also in retrospective.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26117

To: anthonyfieroni, broulik, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes.
Closed by commit R1048:4e0aed086c30: Port qrand deprecated method to 
QRandomGenerator (authored by mlaurent).

REPOSITORY
  R1048 Grantlee

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26154?vs=71991&id=72015

REVISION DETAIL
  https://phabricator.kde.org/D26154

AFFECTED FILES
  templates/defaultfilters/lists.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-22 Thread Nathaniel Graham
ngraham accepted this revision as: VDG.
ngraham added a comment.


  Yep, my branches weren't up to date. Works fine now!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread David Faure
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R1048 Grantlee

BRANCH
  port_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26154

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26159: Drop KWindowSystem dependency

2019-12-22 Thread David Edmundson
davidedmundson added a task: T12413: RFC: Split KWindowSystem into KX11 and 
KHighLevelWindowStuff.

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26159

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26159: Drop KWindowSystem dependency

2019-12-22 Thread David Edmundson
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KWindowSystem activateWindow does the same thing as the QPA does when
  calling QWindow::requestActivate.
  
  We can save a dependency.

TEST PLAN
  Windows: 
  Read code for windows QPA + kwindowsystem and it seemed like the 
  same underlying call
  
  X11:
   Ran ./ktextedittest. pressed control+f. Window had focus
  
  Wayland:
  Both calls will no-op. It needs new API, but when that does exist
  I'll make sure it's in QWayland.

REPOSITORY
  R310 KTextWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26159

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/findreplace/kfinddialog.h
  src/widgets/ktextedit.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 22 Dec 2019 18:43:33 +
 Build duration:
1 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

D26157: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R299:8376e5f664a9: Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26157?vs=72005&id=72007

REVISION DETAIL
  https://phabricator.kde.org/D26157

AFFECTED FILES
  src/client.cpp
  src/kdesud/kdesud.cpp

To: ahmadsamir, sitter, fvogt, jriddell
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26157: Port QRegExp to QRegularExpression

2019-12-22 Thread Fabian Vogt
fvogt accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R299 KDESu

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26157

To: ahmadsamir, sitter, fvogt, jriddell
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-22 Thread Nathaniel Graham
ngraham added a comment.


  I agree. If and when this lands, you could commandeer and close D15645 


REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D26158: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Baloo, bruns.
Herald added projects: Frameworks, Baloo.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R286 KFileMetaData

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26158

AFFECTED FILES
  src/extractors/officeextractor.cpp

To: ahmadsamir, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D26157: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: sitter, fvogt, jriddell.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R299 KDESu

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26157

AFFECTED FILES
  src/client.cpp
  src/kdesud/kdesud.cpp

To: ahmadsamir, sitter, fvogt, jriddell
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26156: [KDocTools] Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added reviewers: Documentation, ltoscano.
Herald added projects: Frameworks, Documentation.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  xslt.cpp didn't really use QRegExp as the line using it has been commented
  out since 2013, removed now.

REPOSITORY
  R238 KDocTools

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26156

AFFECTED FILES
  src/docbookl10nhelper.cpp
  src/xslt.cpp

To: ahmadsamir, #documentation, ltoscano
Cc: kde-doc-english, kde-frameworks-devel, LeGast00n, gennad, fbampaloukas, 
GB_2, michaelh, ngraham, bruns, skadinna


D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-12-22 Thread Nathaniel Graham
ngraham added a comment.


  @chinmoyr now that D21783  has landed, 
this is all that's left before we can turn on the feature, right?

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: chinmoyr, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns


D26117: [solid] Clarify referencing of DeviceInterface

2019-12-22 Thread Anthony Fieroni
anthonyfieroni added a comment.


  You can't run kinfocenter or what?
  
Application: Info Center (kinfocenter), signal: Segmentation fault
Using host libthread_db library "/lib/libthread_db.so.1".
[Current thread is 1 (Thread 0x7f4c245a2840 (LWP 318849))]

Thread 4 (Thread 0x7f4bf9c42700 (LWP 318852)):
#0  0x7f4c1b898115 in pthread_cond_wait@@GLIBC_2.3.2 () from 
/lib/libpthread.so.0
#1  0x7f4bfac7ae8b in ?? () from /usr/lib/dri/i965_dri.so
#2  0x7f4bfac7aaf7 in ?? () from /usr/lib/dri/i965_dri.so
#3  0x7f4c1b891be4 in start_thread () from /lib/libpthread.so.0
#4  0x7f4c2042033f in clone () from /lib/libc.so.6

Thread 3 (Thread 0x7f4c067a7700 (LWP 318851)):
#0  0x7f4c204122ac in read () from /lib/libc.so.6
#1  0x7f4c17b41e4f in ?? () from /usr/lib/libglib-2.0.so.0
#2  0x7f4c17afc84e in g_main_context_check () from 
/usr/lib/libglib-2.0.so.0
#3  0x7f4c17afcc5a in ?? () from /usr/lib/libglib-2.0.so.0
#4  0x7f4c17afcdcf in g_main_context_iteration () from 
/usr/lib/libglib-2.0.so.0
#5  0x7f4c20dab21b in 
QEventDispatcherGlib::processEvents(QFlags) () 
from /usr/lib/libQt5Core.so.5
#6  0x7f4c20d562eb in 
QEventLoop::exec(QFlags) () from 
/usr/lib/libQt5Core.so.5
#7  0x7f4c20b852ae in QThread::exec() () from /usr/lib/libQt5Core.so.5
#8  0x7f4c1fc3f7f7 in ?? () from /usr/lib/libQt5DBus.so.5
#9  0x7f4c20b8627d in ?? () from /usr/lib/libQt5Core.so.5
#10 0x7f4c1b891be4 in start_thread () from /lib/libpthread.so.0
#11 0x7f4c2042033f in clone () from /lib/libc.so.6

Thread 2 (Thread 0x7f4c0f6fa700 (LWP 318850)):
#0  0x7f4c204165af in poll () from /lib/libc.so.6
#1  0x7f4c1bcb9827 in ?? () from /usr/lib/libxcb.so.1
#2  0x7f4c1bcbb3ba in xcb_wait_for_event () from /usr/lib/libxcb.so.1
#3  0x7f4c124da960 in ?? () from 
/usr/lib/qt5/plugins/platforms/../../../libQt5XcbQpa.so.5
#4  0x7f4c20b8627d in ?? () from /usr/lib/libQt5Core.so.5
#5  0x7f4c1b891be4 in start_thread () from /lib/libpthread.so.0
#6  0x7f4c2042033f in clone () from /lib/libc.so.6

Thread 1 (Thread 0x7f4c245a2840 (LWP 318849)):
[KCrash Handler]
#6  0x7f4c241399dc in QWeakPointer::internalData (this=0x28) 
at /usr/include/qt5/QtCore/qsharedpointer_impl.h:701
#7  0x7f4c24141d88 in QPointer::data (this=0x28) at 
/usr/include/qt5/QtCore/qpointer.h:77
#8  0x7f4c24141c0e in Solid::DeviceInterfacePrivate::backendObject 
(this=0x20) at 
/home/toni/solid/src/solid/devices/frontend/deviceinterface.cpp:110 // 
<- invalid this pointer
#9  0x7f4c24138c99 in Solid::DevicePrivate::~DevicePrivate 
(this=0xe766c0, __in_chrg=) at 
/home/toni/solid/src/solid/devices/frontend/device.cpp:222
#10 0x7f4c24138d48 in Solid::DevicePrivate::~DevicePrivate 
(this=0xe766c0, __in_chrg=) at 
/home/toni/solid/src/solid/devices/frontend/device.cpp:225
#11 0x7f4c2413ab1b in 
Solid::DeviceManagerPrivate::~DeviceManagerPrivate (this=0xde4230, 
__in_chrg=) at 
/home/toni/solid/src/solid/devices/frontend/devicemanager.cpp:58
#12 0x7f4c2413abe6 in 
Solid::DeviceManagerPrivate::~DeviceManagerPrivate (this=0xde4230, 
__in_chrg=) at 
/home/toni/solid/src/solid/devices/frontend/devicemanager.cpp:63
#13 0x7f4c2413f9be in 
qThreadStorage_deleteData (d=0xde4230) at 
/usr/include/qt5/QtCore/qthreadstorage.h:92
#14 0x7f4c2413e6c8 in 
QThreadStorage::deleteData (x=0xde4230) at 
/usr/include/qt5/QtCore/qthreadstorage.h:135
#15 0x7f4c20b8b240 in QThreadStorageData::finish(void**) () from 
/usr/lib/libQt5Core.so.5
#16 0x7f4c20d59819 in QCoreApplicationPrivate::cleanupThreadData() () 
from /usr/lib/libQt5Core.so.5
#17 0x7f4c21348e64 in QGuiApplicationPrivate::~QGuiApplicationPrivate() 
() from /usr/lib/libQt5Gui.so.5
#18 0x7f4c21c0f8b9 in QApplicationPrivate::~QApplicationPrivate() () 
from /usr/lib/libQt5Widgets.so.5
#19 0x7f4c20d888fe in QObject::~QObject() () from 
/usr/lib/libQt5Core.so.5
#20 0x7f4c20d595dc in QCoreApplication::~QCoreApplication() () from 
/usr/lib/libQt5Core.so.5
#21 0x7f4c21c1171e in QApplication::~QApplication() () from 
/usr/lib/libQt5Widgets.so.5
#22 0x0040e645 in ?? ()
#23 0x7f4c2034e2cb in __libc_start_main () from /lib/libc.so.6
#24 0x0040e67a in _start ()
[Inferior 1 (process 318849) detached]

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26117

To: anthonyfieroni, broulik, bruns
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 251 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/251/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 22 Dec 2019 16:41:27 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_privilegejobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34605/61742)40%
(17559/43590)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9635/10105)47%
(4486/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8616/14561)51%
(4503/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4662/8294)43%
(2028/4744)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(686/1249)40%
(384/965)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 250 - Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/250/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 22 Dec 2019 08:16:29 +
 Build duration:
8 hr 24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_privilegejobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34629/61744)40%
(17583/43590)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9635/10105)47%
(4493/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8641/14563)51%
(4516/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4667/8294)43%
(2031/4744)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(686/1249)40%
(384/965)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-22 Thread Friedrich W. H. Kossebau
Am Sonntag, 22. Dezember 2019, 17:08:15 CET schrieb Stephen Kelly:
> On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote:
> > Perhaps joining the "Release Service" (formerly known as "KDE
> > Applications") is a better place then, it also contains a set of
> > libraries already. That would serve the purpose of having releases
> > happening regularly.
> The goals of making Grantlee a Framework are:
> 
> * Make more frequent releases which don't depend on me
> 
> * Make it more easy for others to contribute to development
> 
> 
> I think at the point that renaming happens, the name Grantlee will
> disappear, and we'll have two libraries (KF5::TextDocument and
> KF5::TextTemplates or so in CMake and probably removing the C++ namespace).

There is no need to drop the name "Grantlee", IMHO that is a well-known 
product/solution identifier by now for the needs it solves. There are other 
non-generic-name identifiers in KDE Frameworks (Sonnet, Purpose, Prison, 
Attica, Solid, Baloo, Syndication) instead of "K" + generic descriptive 
english name, so it is also nothing new in concept.

KF5::TextDocument & KF5::TextTemplates as target/lib names e.g. would be less 
useful, as they could describe a lot of things and would need to be longer to 
be more exact :)

So having "Grantlee" as easily searchable term which also is properly defined 
what solution scope it is about can be actually seen as an advantage.

> I think all of that should be done together and I don't think that
> should be done until compatibility is broken to become Qt6-based (KF6).
> 
> If joining the Release Service helps reach the goals, and there is
> consensus that Grantlee can't be a framework without partial renaming
> (ie renaming the CMake interface but little else) in KF5, then that
> might be the way to go.

So far I was hoping we could have both for KF5 already, backward-compatible 
CMake config files with old imported targets as well as parallel new KF5-
namespaced CMake names. Myself still no good idea how to do this in CMake 
without too much manual complicated fragile hackery.

Cheers
Friedrich




Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-22 Thread Stephen Kelly



On 21/12/2019 23:55, Friedrich W. H. Kossebau wrote:

Perhaps joining the "Release Service" (formerly known as "KDE Applications")
is a better place then, it also contains a set of libraries already.
That would serve the purpose of having releases happening regularly.



The goals of making Grantlee a Framework are:

* Make more frequent releases which don't depend on me

* Make it more easy for others to contribute to development


I think at the point that renaming happens, the name Grantlee will 
disappear, and we'll have two libraries (KF5::TextDocument and 
KF5::TextTemplates or so in CMake and probably removing the C++ namespace).


I think all of that should be done together and I don't think that 
should be done until compatibility is broken to become Qt6-based (KF6).


If joining the Release Service helps reach the goals, and there is 
consensus that Grantlee can't be a framework without partial renaming 
(ie renaming the CMake interface but little else) in KF5, then that 
might be the way to go.


Thanks,

Stephen.




D26155: Add RPM support to Krarc

2019-12-22 Thread Davide Gianforte
gengisdave created this revision.
gengisdave added a reviewer: Frameworks.
gengisdave added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gengisdave requested review of this revision.

REVISION SUMMARY
  This fix the conflict between file: and krarc: protocols when and RPM is 
opened
  
  FIXED: [ 408082 ] krarc stopped working with rpm
  BUG: 408082

TEST PLAN
  Compile and test with and without krusader installed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26155

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: gengisdave, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns


D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

2019-12-22 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:de269bf48e58: QAtomicInteger::loadRelaxed() and 
storeRelaxed() are available since Qt 5.14 (authored by ahmadsamir).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26102?vs=71836&id=72000

REVISION DETAIL
  https://phabricator.kde.org/D26102

AFFECTED FILES
  src/file/filecontentindexer.cpp
  src/file/filecontentindexer.h
  src/lib/queryrunnable.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D26102: QAtomicInteger::loadRelaxed() and storeRelaxed() are available since Qt 5.14

2019-12-22 Thread Laurent Montel
mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  l-qt14-deprecated-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26102

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2019-12-22 Thread Kai Uwe Broulik
broulik added a comment.


  F7831018: Screenshot_20191222_162523.png 

  Works fine here. Are both branches up to date and are you clicking an empty 
area?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D26123: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71999.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R270 KCodecs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26123?vs=71941&id=71999

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26123

AFFECTED FILES
  autotests/kemailaddresstest.cpp
  src/kemailaddress.cpp

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71996.
ahmadsamir added a task: T12279: Port frameworks away from QRegExp.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26145?vs=71995&id=71996

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26145

AFFECTED FILES
  src/addressee.cpp

To: ahmadsamir, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26106: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71997.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26106?vs=71994&id=71997

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26106

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Methods.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, drosca, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26145: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71995.
ahmadsamir added a comment.


  Link to KF6 task

REPOSITORY
  R174 KContacts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26145?vs=71959&id=71995

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26145

AFFECTED FILES
  src/addressee.cpp

To: ahmadsamir, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26106: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71994.
ahmadsamir added a comment.


  Link to KF6 task

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26106?vs=71843&id=71994

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26106

AFFECTED FILES
  tools/bluezapi2qt/CppGenerator.cpp
  tools/bluezapi2qt/Interface.cpp
  tools/bluezapi2qt/Method.cpp
  tools/bluezapi2qt/Methods.cpp
  tools/bluezapi2qt/Properties.cpp

To: ahmadsamir, drosca, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26099: Port QRegExp to QRegularExpression

2019-12-22 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 71992.
ahmadsamir added a comment.


  Link to KF6 task

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26099?vs=71954&id=71992

BRANCH
  l-qregexp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26099

AFFECTED FILES
  src/kioslaves/timeline/timelinetools.cpp

To: ahmadsamir, #baloo, meven, bruns, astippich, mlaurent
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams


KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 236 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/236/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 22 Dec 2019 11:42:05 +
 Build duration:
2 hr 39 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_privilegejobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-22 Thread David Redondo
davidre added a comment.


  In D25877#581355 , @kossebau wrote:
  
  > D15645  tried something similar from 
what I understood without looking at details, you might want to compare at 
least :) Sorry, no time myself to look at things currently beyond this comment.
  
  
  Thanks for the pointer! Looking at that diff what it tried to do was reading 
the currently active color scheme from kdeglobals. That approach has two 
problems imo. First it only is correct on Plasma, secondly it sets the wrong 
scheme when the global color scheme changes. To fix the second issue one could 
listen to the settings changed signal on DBus but that also only works on 
Plasma. Just using the `standardPalette()` is much simpler and more reliable.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau added a comment.


  D15645  tried something similar from what 
I understood without looking at details, you might want to compare at least :) 
Sorry, no time myself to look at things currently beyond this comment.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  systemthem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25877

To: davidre, #frameworks, ngraham
Cc: kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread Laurent Montel
mlaurent added a reviewer: dfaure.

REPOSITORY
  R1048 Grantlee

REVISION DETAIL
  https://phabricator.kde.org/D26154

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26154: Port qrand deprecated method to QRandomGenerator

2019-12-22 Thread Laurent Montel
mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port to QRandomGenerator

REPOSITORY
  R1048 Grantlee

BRANCH
  port_QRandomGenerator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26154

AFFECTED FILES
  templates/defaultfilters/lists.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26148: Add truncation support to FileJob

2019-12-22 Thread Alexander Saoutkin
feverfew updated this revision to Diff 71990.
feverfew added a comment.


  Add unit test for truncation

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26148?vs=71963&id=71990

BRANCH
  TruncateSupport

REVISION DETAIL
  https://phabricator.kde.org/D26148

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobremotetest.h
  src/core/commands_p.h
  src/core/filejob.cpp
  src/core/filejob.h
  src/core/global.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h

To: feverfew, fvogt, dfaure, sitter
Cc: ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, 
michaelh, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 369 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/369/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 22 Dec 2019 10:50:28 +
 Build duration:
1 hr 55 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_privilegejobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34618/61743)40%
(17586/43594)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9637/10105)47%
(4492/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8614/14561)51%
(4509/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4667/8294)43%
(2033/4748)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(686/1249)40%
(384/965)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1805/4288)36%
(1317/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D26054: partial fix for accentuated characters in file name on Windows

2019-12-22 Thread Alexander Stippich
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  fixWriterAccentuatedFileName

REVISION DETAIL
  https://phabricator.kde.org/D26054

To: mgallien, bruns, astippich
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 235 - Still Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/235/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 22 Dec 2019 08:16:29 +
 Build duration:
3 hr 25 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiocore_privilegejobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26151: LaTeX: fix brackets in some commands

2019-12-22 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  latex-brackets

REVISION DETAIL
  https://phabricator.kde.org/D26151

To: nibags, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann


D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d25bc3ce2138: Sync QWindow flag WindowDoesNotAcceptFocus 
to wayland plasmashell interface (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26153?vs=71986&id=71988

REVISION DETAIL
  https://phabricator.kde.org/D26153

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: davidedmundson, #kwin, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread Roman Gilg
romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26153

To: davidedmundson, #kwin, #plasma, romangg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread David Edmundson
davidedmundson edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26153

To: davidedmundson, #kwin, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D26153: Sync QWindow flag WindowDoesNotAcceptFocus to wayland plasmashell interface

2019-12-22 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added reviewers: KWin, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently the widget explorer relied on some QML code calling
  KWindowSystem::forceActiveWindow which on plasma implicitly set this
  hint.
  
  This works for the first show, but the order of events is somewhat
  unreliable. It's invoked from QML when the window is ready, but for the
  second show this is before the wl_surface is created and it no-ops.
  
  By syncing the flags in applyType() we can guarantee we call this both
  when setFlags is called and when the wl_surface is created in the
  correct order.
  
  BUG: 415124

TEST PLAN
  Ran plasmashell
  Opened widget explorer twice
  Had focus each time

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26153

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: davidedmundson, #kwin, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 368 - Unstable!

2019-12-22 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/368/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 22 Dec 2019 08:16:29 +
 Build duration:
2 hr 33 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_privilegejobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34605/61742)40%
(17564/43594)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9635/10105)47%
(4496/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8616/14561)51%
(4500/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8294)43%
(2032/4748)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(682/1249)39%
(379/965)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(631/1330)56%
(576/1027)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D26151: LaTeX: fix brackets in some commands

2019-12-22 Thread Nibaldo González
nibags created this revision.
nibags added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 415384
  
  In the parameter of some commands, such as `\input{\a{}}`, the brackets are 
closed incorrectly, which causes the pairs of brackets to be marked incorrectly.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  latex-brackets

REVISION DETAIL
  https://phabricator.kde.org/D26151

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann


D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-22 Thread David Faure
dfaure added a comment.


  Fixed.
  
  https://commits.kde.org/kio/e2a38d7726e33f637576f254575c2c0743d205b8

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-22 Thread Dominik Haumann
Hi all,

in any case, maybe the discussed points should go to the KF6 workboard?
https://phabricator.kde.org/project/view/310/

I indeed believe that consistency in the KF5 world is an important feature,
so Friedrich does have a point here. Other framework additions had to adapt
as well (what comes to my mind is renaming of KQuickCharts or
KCalendarCore).

Whatever decision is made here, imho there should/must be the objective to
get it fixed for KF6.

Best regards
Dominik

Friedrich W. H. Kossebau  schrieb am So., 22. Dez. 2019,
00:55:

> Am Samstag, 21. Dezember 2019, 23:32:10 CET schrieb Stephen Kelly:
> > On 21/12/2019 19:12, Friedrich W. H. Kossebau wrote:
> > > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly:
> > >> Great, Grantlee is now available at g...@git.kde.org:grantlee.git.
> > >>
> > >> I've pushed a few commits to make it depend on ECM etc.
> > >>
> > >> Once the review period is finished it can be part of KF5 releases.
> > >
> > > There are quite some things which yet need to be done for now:
> > > to be a true KF module there is a set of policies which needs to be
> met,
> > > see https://community.kde.org/Frameworks/Policies
> > >
> > > 1) Framework directory structure:
> > > moving stuff into src/, autotests/ & docs/
> > >
> > > 2) Framework documentation:
> > > current system needs adaption to both online (KApiDox) and
> > > offline (ECMAddQCH) systems
> >
> > Cool, I wonder if there's another multi-library framework for comparison?
>
> With ECMAddQCH, Sonnet & KNewStuff create separate QCH files for their
> multiple libs.
>
> With KApiDox, IIRC it has the assumption 1 module <=> 1 documentation unit
> (not involved there),
> Olivier (cc:ed) should be able to hint you what is possible.
>
> > > Another challenge would be moving into the KF5 namespace for the
> library
> > > artifacts (at least I would expect/recommend this to happen, for
> > > consistent
> > > user experience)
> > > a) include dirs below subdir KF5/
> > > b) CMake modules with KF5 prefix
> > > c) CMake imported target in KF5 namespace
> >
> > I don't support changing things like this in the KF5 timeframe.
>
> IMHO not sharing the namespace "KF5" spoils the story of KDE Frameworks,
> where
> the namespace gives consistent developer experience and product messaging.
>
> Having Grantlee being a special kid, with unregular CMake modules names
> and
> differently namespace imported CMake targets, makes things more complex.
>
> Being consistent is what we so like about Qt, and KF should not stay
> behind,
> no?
>
> Perhaps joining the "Release Service" (formerly known as "KDE
> Applications")
> is a better place then, it also contains a set of libraries already.
> That would serve the purpose of having releases happening regularly.
>
> Cheers
> Friedrich
>
>
>


D26113: Places: For mounted volume display mount points instead of description

2019-12-22 Thread Méven Car
meven added a comment.


  In D26113#581077 , @ngraham wrote:
  
  > We can make the name override more discoverable for sure. But IMO we should 
also improve the default presentation, because this is just yucky: F7828189: 
Screenshot_20191221_092825.png 
  >
  > None of my other mounted devices insist on showing their full path or the 
format of the mount/device.
  >
  > Maybe we should discuss that in a phab task before submitting patches.
  
  
  So your concern is plasma vault / fuse specific ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: bruns, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham


D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-22 Thread Ben Cooksley
bcooksley added a comment.


  This changes FTBFS - see 
https://build.kde.org/job/Administration/job/Dependency%20Build%20Applications%20kf5-qt5%20SUSEQt5.12/47/
  There are currently a large number of Dependency Builds underway to correct 
changes in the tree as a consequence of Grantlee changing to be a first party 
repository, so this needs to be corrected urgently.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21783

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: bcooksley, mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D21783: Show more details in warning dialog shown before starting a privileged operation

2019-12-22 Thread Chinmoy Ranjan Pradhan
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:82aae02e2114: Show more details in warning dialog shown 
before starting a privileged operation (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21783?vs=71754&id=71981

REVISION DETAIL
  https://phabricator.kde.org/D21783

AFFECTED FILES
  autotests/kiotesthelper.h
  src/core/jobuidelegateextension.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface_p.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/jobuidelegate.cpp
  src/widgets/jobuidelegate.h

To: chinmoyr, #vdg, #frameworks, dfaure
Cc: mreeves, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns