KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 264 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/264/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 04 Jan 2020 06:56:33 +
 Build duration:
7 min 6 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34757/61872)40%
(17677/43724)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9687/10144)47%
(4516/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8696/14613)51%
(4529/8855)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4681/8309)43%
(2070/4798)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 263 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/263/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 01 Jan 2020 19:06:15 +
 Build duration:
2 days 11 hr and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_http_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)66%
(267/405)66%
(267/405)56%
(34426/61752)40%
(17484/43632)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(55/58)95%
(55/58)94%
(9476/10096)47%
(4452/9556)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8644/14563)51%
(4503/8826)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4672/8298)43%
(2047/4762)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(674/1249)40%
(387/971)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1745/4287)34%
(1232/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
 

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileitem.cpp:782
>  if (!path.isEmpty()) {
> -const KFileSystemType::Type fsType = 
> KFileSystemType::fileSystemType(path);
> -m_slow = (fsType == KFileSystemType::Nfs || fsType == 
> KFileSystemType::Smb) ? Slow : Fast;
> +const auto  = KMountPoint::currentMountPoints();
> +auto mp = mountPoints.findByPath(path);

I think you wanna use `getMountPoints`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

[Nathaniel Graham]

ngraham added reviewers: broulik, dfaure.
ngraham added inline comments.

INLINE COMMENTS

> kfileitem.cpp:47
> +/**
> + * A coche of currently mounted filesystems
> + */

cache

> kfileitem.cpp:1245
>  
> -if (d->m_bSkipMimeTypeFromContent) {
> +// avoid potential bloqing stat on network mount
> +if (d->m_bSkipMimeTypeFromContent && d->isSlow()) {

blocking

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

[Nathaniel Graham]

ngraham added a comment.


  Having been a sysadmin setting up computers for new users, let me tell you 
that there is a 0% chance that I would use this feature. I would (and did, and 
have) *by far* prefer to document anything slightly confusing using an internal 
company-wide knowledge-base or wiki. That way I could actually point users to 
the explanation accessible in a web browser in a page I could send people the 
link to, and I could refine the documentation myself over time effortlessly.
  
  Besides, this feature has no UI to discover it, so I would wager that 
approximately 0 people are actually using it. Of course, yes, if there was any 
telemetry, this wouldn't have to be a guess. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26410: Port KLanguageButton from KConfig to QSettings

[Nicolas Fella]

nicolasfella added a task: T12197: Move KLanguageButton from KConfig -> 
QSettings.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26410

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26410: Port KLanguageButton from KConfig to QSettings

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Implement T12197 

TEST PLAN
  Still see proper language name in Dolpin's switch language dialog

REPOSITORY
  R265 KConfigWidgets

BRANCH
  klb

REVISION DETAIL
  https://phabricator.kde.org/D26410

AFFECTED FILES
  src/klanguagebutton.cpp

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.13 - Build # 41 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.13/41/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 03 Jan 2020 23:13:46 +
 Build duration:
2 hr 42 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.parttest

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/51/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 04 Jan 2020 00:14:16 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/52/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:16:05 +
 Build duration:
1 hr 41 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 91 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/91/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 03 Jan 2020 23:10:52 +
 Build duration:
1 hr 35 min and counting
   BUILD ARTIFACTS
  acc/KF5CoreAddons-5.66.0.xmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6895/9073)43%
(10751/24743)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2893/2985)49%
(6176/12687)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(678/794)42%
(952/2255)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(422/827)47%
(988/2121)src.lib.util100%
(15/15)100%
(15/15)83%
(986/1183)51%
(1006/1989)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/45/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:14:56 +
 Build duration:
1 hr 28 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[David Faure]

dfaure added a comment.


  See D26408  for a unittest. But maybe the 
code can just be killed...

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26408: ki18n: add unittest for KUitSetup::setFormatForMarker

[David Faure]

dfaure created this revision.
dfaure added a reviewer: ilic.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  This is to test the port to QRegularExpression in D26366 
.
  
  HOWEVER setFormatForMarker wasn't used anywhere (part of a class
  whose getter Kuit::setupForDomain wasn't exported). So the alternative
  would be to just remove it, as well as formatForMarker(), no?

TEST PLAN
  test passes

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26408

AFFECTED FILES
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  src/kuitmarkup.h

To: dfaure, ilic
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/86/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 04 Jan 2020 00:14:16 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:14:02 +
 Build duration:
1 hr 17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 256 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/256/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:12:41 +
 Build duration:
1 hr 18 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/49/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:13:40 +
 Build duration:
1 hr 16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D26407: KFileItem: improve isSlow to never block, make SkipMimeTypeFromContent skip only network fs

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Alternative to D23198 
  BUG: 401579

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/28/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:12:29 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

D26402: [android] Fix apk install target

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c427b4e94ebb: [android] Fix apk install target (authored 
by nicolasfella).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26402?vs=72703=72718

REVISION DETAIL
  https://phabricator.kde.org/D26402

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26402: [android] Fix apk install target

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  androidinstall

REVISION DETAIL
  https://phabricator.kde.org/D26402

To: nicolasfella, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/33/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:11:27 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/54/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:11:17 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/86/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:10:48 +
 Build duration:
47 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.13 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.13/32/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Fri, 03 Jan 2020 23:09:44 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.frameworkintegration_kstyle_unittest

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/46/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 23:10:12 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 51 test(s), Passed: 441 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase54.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase55.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurPrev_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase54.icsFailed: projectroot.autotests.RecurPrev_LibICal_TestCase55.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecursOn_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase01.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase02.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase06.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase07.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase15.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase54.icsFailed: projectroot.autotests.RecursOn_LibICal_TestCase55.icsFailed: projectroot.autotests.testcalendarobserverFailed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 138 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/138/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Jan 2020 23:10:52 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6895/9074)43%
(10751/24743)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2893/2985)49%
(6176/12687)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(678/795)42%
(952/2255)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(422/827)47%
(988/2121)src.lib.util100%
(15/15)100%
(15/15)83%
(986/1183)51%
(1006/1989)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 89 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/89/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 03 Jan 2020 22:03:51 +
 Build duration:
7 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.66.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6894/9073)43%
(10748/24743)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2892/2985)49%
(6173/12687)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(678/794)42%
(952/2255)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(422/827)47%
(988/2121)src.lib.util100%
(15/15)100%
(15/15)83%
(986/1183)51%
(1006/1989)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 50 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/50/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 03 Jan 2020 22:04:00 +
 Build duration:
6 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.66.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27280/32231)53%
(11005/20683)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12522/12597)50%
(6593/13085)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6329/7469)65%
(1834/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7975/9509)64%
(2401/3771)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D11156: add autotest for zips within zips

[David Faure]

dfaure added a comment.


  The command you're looking for is `arc patch D11156` (tested, works)

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11156

To: sandsmark, dfaure, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

[David Faure]

dfaure added a comment.


  I don't understand this line of argumentation. Are you saying that all 
documentation in the world is useless?
  
  You're setting up a computer for a new employee, with a whole lot of folders. 
Having some room to document "inline" the purpose of some folders sounds 
useful, doesn't it? (even more so with the translation support, but even 
without). You do that in .directory files which are part of the checkout and 
it's even directly useful for the next employee :)
  
  What's missing however is that there's no GUI for setting those, one has to 
know about the hidden .directory feature (right?).
  
  On the other hand I see that the dolphin GUI has an editable "Comment" on the 
right side, unfortunately it doesn't show in the treeview even after enabling 
the "Comments" column (bug?). And that's local, so not reusable for another 
user.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26405: Add mime type for backtraces saved from DrKonqi

[Kai Uwe Broulik]

broulik edited the test plan for this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26405

To: broulik, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26405: Add mime type for backtraces saved from DrKonqi

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

TEST PLAN
  There's also text/x-apport
  
  - My saved crash reports now have a nice icon
  
  F7858683: Screenshot_20200103_225422.png 

  
  - Normal text files are unchanged

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26405

AFFECTED FILES
  src/mimetypes/kde5.xml

To: broulik, #frameworks, sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 72715.
tcanabrava edited the test plan for this revision.
tcanabrava added a comment.


  - Add Hack for Enums
  - Fix Whitespace diff
  - Move some raw scopes to start/end scope()

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=72711=72715

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> dfaure wrote in jobtest.cpp:2171
> Always use QVERIFY() around spy.wait().
> Well, I'm assuming we actually expect the signal to be emitted :-)
> I would also remove the 500 then, the default value will be fine.

Why the short 500ms timeout? CI can be slow sometimes.

> file_unix.cpp:356
> +}
> +finished();
> +return;

shouldn't this be error(KIO::ERR_USER_CANCELED) instead? It's not like the copy 
actually succeeded...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> broulik wrote in ktoolbar.cpp:908
> I just realized this is false-y deprecated. The feature adds the 
> configuration options for toolbar buttons.
> What needs to be done here for proper deprecation is port that over to 
> `customContextMenuRequested` or checking for policy being not `NoContextMenu` 
> or so.

For reference:

Deprecation of custom context menu enabling methods in favor of 
QWidget::contextMenuPolicy was done 2007: 
R446:41c7dd48afbf2794dbe260466d569d808d851c04 

And implementation code wrapped in 2010: 
R446:52905e8d94ee6d7a08ff1b793c5dd226f0c3fbc1 


Guess best is to add a TODO into the code for now, unless you are already on it?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26364: SlaveBase::dispatchLoop: Fix timeout calculation

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Yep. Bug in D9983 .

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26364

To: kfunk, chinmoyr, davidedmundson, dfaure, broulik
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ktoolbar.cpp:908
>  {
> -#ifndef KXMLGUI_NO_DEPRECATED
> +#if KXMLGUI_BUILD_DEPRECATED_SINCE(5, 0)
>  if (mainWindow() && d->enableContext) {

I just realized this is false-y deprecated. The feature adds the configuration 
options for toolbar buttons.
What needs to be done here for proper deprecation is port that over to 
`customContextMenuRequested` or checking for policy being not `NoContextMenu` 
or so.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24466

To: kossebau, #frameworks, dfaure, mlaurent
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26404: Turn application/x-ms-shortcut into an actual shortcut icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Rather than a banknote or money symbol. Git log suggests this was added for 
GNU cash, but .lnk files are windows shortcut files, effectively links.

TEST PLAN
  Don't know what to do about icons-dark. Do the symbolic 16/22 mimetype icons 
colorize? are they always dark? always white?
  
  F7858556: Screenshot_20200103_213025.png 

  F7858557: Screenshot_20200103_213032.png 

  F7858568: Screenshot_20200103_213239.png 

  F7858569: Screenshot_20200103_213248.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26404

AFFECTED FILES
  icons/mimetypes/16/application-x-ms-shortcut.svg
  icons/mimetypes/22/application-x-ms-shortcut.svg
  icons/mimetypes/32/application-x-ms-shortcut.svg
  icons/mimetypes/64/application-x-ms-shortcut.svg

To: broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava edited the summary of this revision.
tcanabrava edited the test plan for this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 72711.
tcanabrava added a comment.


  - Add missing .h
  - Fixes placement of code
  - Change how tests save tests
  - Change how the Indentation is done
  - Fix filename in the preamble
  - Separate logic to make function readable
  - Fix more newlines
  - Add Hacks around code to generate the same amount of Empty Space

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=72377=72711

BRANCH
  arcpatch-D26202

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KCFGXmlParser.cpp
  src/kconfig_compiler/KCFGXmlParser.h
  src/kconfig_compiler/KConfigCodeGenerator.cpp
  src/kconfig_compiler/KConfigCodeGenerator.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXTParameters.cpp
  src/kconfig_compiler/KConfigXTParameters.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[Ahmad Samir]

ahmadsamir added a comment.


  About the unit test, I couldn't think of a way to test it, unless I use a 
snippet to check the regex (like you did in D26332 
), which doesn't seem to fit in a unit test 
for KLocalizedString...

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[Ahmad Samir]

ahmadsamir updated this revision to Diff 72709.
ahmadsamir added a comment.


  Use a meaningful name for the QRegularExpression object
  
  Explain the (my) logic behind the changes in parseUiMarker() in the commit 
message

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26366?vs=72616=72709

BRANCH
  l-parseUiM (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26366

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[Ahmad Samir]

ahmadsamir updated this revision to Diff 72710.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26366?vs=72709=72710

BRANCH
  l-parseUiM (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26366

AFFECTED FILES
  src/kuitmarkup.cpp

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 388 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/388/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Jan 2020 18:59:47 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.66.0.xmllogs/KF5KIO/5.66.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/405)67%
(270/405)56%
(34761/61873)40%
(17682/43728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10144)47%
(4514/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8697/14613)51%
(4528/8855)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4681/8309)43%
(2072/4802)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(644/1370)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 255 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/255/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 18:59:47 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3a6e3f927111: [KFilePlacesModel] Fix supported scheme 
check for devices (authored by broulik).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25991?vs=71522=72708#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25991?vs=71522=72708

REVISION DETAIL
  https://phabricator.kde.org/D25991

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: kde-frameworks-devel, bruns, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Nathaniel Graham]

ngraham added a comment.


  No response, I think you can land this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26397: Change XHTML icon to be a purple HTML icon

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:fdaded68913f: Change XHTML icon to be a purple HTML icon 
(authored by broulik).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26397?vs=72693=72707

REVISION DETAIL
  https://phabricator.kde.org/D26397

AFFECTED FILES
  icons-dark/mimetypes/16/application-xhtml+xml.svg
  icons-dark/mimetypes/22/application-xhtml+xml.svg
  icons-dark/mimetypes/32/application-xhtml+xml.svg
  icons-dark/mimetypes/64/application-xhtml+xml.svg
  icons/mimetypes/16/application-xhtml+xml.svg
  icons/mimetypes/22/application-xhtml+xml.svg
  icons/mimetypes/32/application-xhtml+xml.svg
  icons/mimetypes/64/application-xhtml+xml.svg

To: broulik, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

[Luca Beltrame]

lbeltrame added a reviewer: bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26400

To: bport, ervin, crossi, meven, #plasma, bruns
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D26402: [android] Fix apk install target

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The APK output path changed at some point

TEST PLAN
  can do make install-apk-appname again

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  androidinstall

REVISION DETAIL
  https://phabricator.kde.org/D26402

AFFECTED FILES
  toolchain/ECMAndroidDeployQt.cmake

To: nicolasfella, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

[Benjamin Port]

bport added a dependent revision: D26401: KCM Baloo: Migrate to KConfigXT and 
add immutability.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26400

To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

[Benjamin Port]

bport added reviewers: ervin, crossi, meven, Plasma.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26400

To: bport, ervin, crossi, meven, #plasma
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

[Benjamin Port]

bport created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
bport requested review of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26400

AFFECTED FILES
  src/file/CMakeLists.txt
  src/file/baloosettings.kcfgc
  src/file/extractor/CMakeLists.txt
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/lib/CMakeLists.txt
  src/lib/baloosettings.kcfg
  src/lib/baloosettings.kcfgc
  src/lib/indexerconfig.cpp
  src/tools/balooctl/main.cpp

To: bport
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D26397: Change XHTML icon to be a purple HTML icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice idea!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26397

To: broulik, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26123: Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  FTR; in one of my inline comments I said:
  
  > And I found that:
  > 
  > - {,3} in QRegExp is equivalent to {0,3}
  > - {,3} in QRegularExpression is equivalent to {1,3}
  
  The second part is actually wrong (as I was told by dfaure who was told by 
upstream QRegularExpression author); in QRegularExpression {,3} would be 
treated as a literal string, you must specify the first number before "," in {} 
expressions; so e.g.:
  {0,3}
  {1,3}
  {2,3}
  
  It's explained much better by upstream, see 
https://codereview.qt-project.org/c/qt/qtbase/+/285293

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D26123

To: ahmadsamir, #frameworks, dfaure, mlaurent, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar marked an inline comment as done.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig, cullmann
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar marked an inline comment as done.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig, cullmann
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar added inline comments.

INLINE COMMENTS

> mludwig wrote in guesslanguage.cpp:589
> Couldn't this if-statement can be dropped? I guess one can argue that 
> sometimes there may be a language without trigrams that would even be a 
> better language guess?

Yeah, I think so too

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig, cullmann
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:128ed7ce3a1e: Remove endl in qDebug as its already 
add \n + port to Qt::endl in qt5.15 (authored by mlaurent).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26303?vs=72419=72694

REVISION DETAIL
  https://phabricator.kde.org/D26303

AFFECTED FILES
  src/sycoca/vfolder_menu.cpp
  tests/pluginlocator/plugintest.cpp

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26397: Change XHTML icon to be a purple HTML icon

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Currently, XHTML is just using the XML icon, but XHTML is more of a "website" 
than an "XML file".
  This patch changes it to use a purple HTML icon. The purple still makes it 
somewhat "different " (it's XML) but focuses on the essence that it's pretty 
much a webseite, too.

TEST PLAN
  Oxygen had a mixture icon of a globe in angle brackets which was an 
interesting idea:
  F7858093: application-xhtml+xml.png 
  
  F7858087: Screenshot_20200103_165402.png 

  
  F7858089: Screenshot_20200103_165413.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26397

AFFECTED FILES
  icons-dark/mimetypes/16/application-xhtml+xml.svg
  icons-dark/mimetypes/22/application-xhtml+xml.svg
  icons-dark/mimetypes/32/application-xhtml+xml.svg
  icons-dark/mimetypes/64/application-xhtml+xml.svg
  icons/mimetypes/16/application-xhtml+xml.svg
  icons/mimetypes/22/application-xhtml+xml.svg
  icons/mimetypes/32/application-xhtml+xml.svg
  icons/mimetypes/64/application-xhtml+xml.svg

To: broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D11156: add autotest for zips within zips

[Martin Tobias Holmedahl Sandsmark]

sandsmark added a comment.


  In D11156#501817 , @dfaure wrote:
  
  > @sandsmark can you add an expected list of files like other tests do?
  
  
  Yeah, I just need to find out which machine I wrote this on because it is 
hard to download patches with binaries from phabricator for fixing. :-P
  
  And I just got a file that I think got broken by the fix this test is for, so 
I think the zip stuff is overdue for a tiny rewrite (the seeking for two magic 
bytes and failing everything is a bit brittle).

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11156

To: sandsmark, dfaure, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

[Nathaniel Graham]

ngraham added a comment.


  In D26331#586842 , @broulik wrote:
  
  > I doubt naming a folder "Technobabble" and then adding a helpful comment 
"This is where your cat pictures go" is very useful to the inexperienced user
  
  
  100% agree

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26394: ECMGeneratePriFile: Fix static configurations

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26394

To: kfunk, dfaure, winterz, vkrause, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26303

To: mlaurent, dfaure, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26394: ECMGeneratePriFile: Fix static configurations

[Kevin Funk]

kfunk added reviewers: winterz, vkrause.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26394

To: kfunk, dfaure, winterz, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26394: ECMGeneratePriFile: Fix static configurations

[Kevin Funk]

kfunk created this revision.
kfunk added a reviewer: dfaure.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  Populate module_config with staticlib. This is needed for Qt 5.12, as
  Makefiles contain the full path to the library instead of just the base
  name. QMake needs to be aware of the build type. This issue was found in
  KDStateMachineEditor's .pri files.
  
  Before this patch the linker tried to link against .so files even for
  static libraries.
  
  Note: Probably not very relevenat to KDE Frameworks (since it's all
  about shared libraries, but I'd like to keep the original
  ECMGeneratePriFile version up-to-date)
  
  Compare:
  
% cat kdsme-qmake-test.pro
QT += KDSMEDebugInterfaceSource

!qtHaveModule(KDSMEDebugInterfaceSource): warning("Library not found")

SOURCES += main.cpp

% qmake --version
QMake version 3.1
Using Qt version 5.9.8 in /home/kfunk/devel/build/qt5.9/qtbase/lib
% qmake .
% make
...
g++ -Wl,-rpath,/home/kfunk/devel/build/qt5.9/qtbase/lib ...  -L.../lib 
-lkdstatemachineeditor_debuginterfacesource ...

% make clean

% env-qt5.12
% qmake --version
QMake version 3.1
Using Qt version 5.12.5 in /home/kfunk/devel/build/qt5.12/qtbase/lib

% qmake .
% make
...
g++ -Wl,-rpath,/home/kfunk/devel/build/qt5.12/qtbase/lib ... 
.../lib/libkdstatemachineeditor_debuginterfacesource.a ...

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26394

AFFECTED FILES
  modules/ECMGeneratePriFile.cmake

To: kfunk, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kuitmarkup.cpp:90
> Interesting idea, this simplifies the code.
> 
> However the name "wsRx" no longer matches what this regexp does.
> 
> Also, the old trimming is missing here, isn't it?
> I guess \s*:?\s* is needed, and \s*/?\s*
> 
> Can you look into adding unittests for this stuff? Although I'm not sure if 
> that's possible.

Ah, yes, ws is white-space, I haven't figured it out except now :), I'll change 
it.

The code first trimmed the string, so any leading white space is gone; the 
original code didn't expect any white-space inside "@role:cue/format", because 
the code cut the string off right before the first occurrence of \s:

  context = context.mid(1, wsRx.indexIn(context) - 1);

so there can't be any white space in the context part. Also looking at the 
guide, https://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt , 
that's how usage is demonstrated, e.g. "@info:whatsthis/plain".

I did look at the unit test, but i18nc() calls don't seem to fail on the 
context part, it just consumes it. I'll see if I can call parseUiMarker() 
directly and feed it some good and some bad strings.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Waqar Ahmed]

waqar updated this revision to Diff 72684.
waqar added a comment.


  Apply requested changes

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25495?vs=72545=72684

BRANCH
  fix-176537 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25495

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/test_autodetect.cpp
  src/core/guesslanguage.cpp

To: waqar, mludwig, cullmann
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[Laurent Montel]

mlaurent added a comment.


  So what I need to change in this patch ? (if I need to change a code :) )

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Michel Ludwig]

mludwig added a comment.


  Thanks for the updated patch!
  
  In D25495#585855 , @waqar wrote:
  
  > > There is also a bug in GuessLanguagePrivate::guessFromTrigrams(const 
QString , const QStringList ): if m_minConfidence is left to 
its default value of '0', that function will always return an empty list. I 
will propose a fix shortly.
  >
  > Alright, I am excited to hear.
  
  
  Here is my proposal:
  
  https://phabricator.kde.org/D26346
  
  > 
  > 
  >> The real issue behind Bug 176537 is a different one, however. On-the-fly 
spell checking in Kate(Part) will only check one line at a time, potentially 
not providing enough text for a meaningful language detection.
  > 
  > To be honest, I haven't ever had an issue with that. I mostly test on 
QOwnNotes, and spellchecking works the same way there i.e., one line at a time. 
If there is a dictionary present, sonnet will guess the language correctly most 
of the times. But you are right in that,..more text would enable sonnet to be 
more accurate. However, autodetection works on a sentence basis, and sentences 
can sometimes be quite short.
  
  With your patch, language detection works much better in KatePart. However, 
due to way Sonnet is used in KatePart for on-the-fly spell checking, one issue 
still is that every word is basically checked against every dictionary. So, in 
the sentence "English is an interesting langage", "langage" may not be 
considered to be misspelled since "langage" is a correctly spelled French word, 
for example. I will still work on that.

INLINE COMMENTS

> guesslanguage.cpp:589
> +//if guessing from trigrams fail
> +if (candidateLanguages.isEmpty() && !scriptsList.isEmpty()) {
> +for (const QChar::Script script : scriptsList) {

Couldn't this if-statement can be dropped? I guess one can argue that sometimes 
there may be a language without trigrams that would even be a better language 
guess?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig, cullmann
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 103 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/103/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 03 Jan 2020 11:09:47 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 109 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/109/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 03 Jan 2020 11:09:47 +
 Build duration:
2 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(231/300)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(191/245)58%
(95/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 217 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/217/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 Jan 2020 11:09:47 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(231/300)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(191/245)58%
(95/164)

D26331: Removed reading description from desktop files

[Kai Uwe Broulik]

broulik added a comment.


  In D26331#586783 , @count wrote:
  
  > I thought, the !d->isSlow() would skip that part for (fsType == 
KFileSystemType::Nfs || fsType == KFileSystemType::Smb) as seen in 
kfileitem.cpp:763. So I would leave that here.
  
  
  The is slow check itself blocks...
  
  > I could imagine setting up a computer for an inexperienced user
  
  Do you know anyone doing this? Oh if only we had some telemetry :)
  I doubt naming a folder "Technobabble" and then adding a helpful comment 
"This is where your cat pictures go" is very useful to the inexperienced user

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D17595: Upstream Dolphin's file rename dialog

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in renamefiledialog.h:47
> @since 5.62

I hope this comment (between docu and class) doesn't break apidox generation.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D17595_1

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: lydia, dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, 
dhaumann, pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26373: Port endl to \n

[David Faure]

dfaure added a comment.


  I would just use std::cout and std::cerr. Yes, at the price of a call to 
qPrintable(), but that's less ugly and more standard IMHO.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D26373

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26331: Removed reading description from desktop files

[David Faure]

dfaure added a comment.


  Also, I see a lot more use cases for showing the comment from .directory 
files.
  I could imagine setting up a computer for an inexperienced user, and adding 
.directory files to document what some directories are about.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26331

To: count, broulik, #frameworks, #dolphin, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

[David Faure]

dfaure added a comment.


  Doesn't flushing happen automatically when internal buffers are full enough? 
i.e. I don't think the app should have to think about that, except when it 
*wants* partial results to be visible (which isn't the case in a code 
generator).
  
  About replace('\n', '\r\n') vs endl doing that, well, this is what makes it 
possible to use "\n" in code and still get \r\n on Windows :)

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D26320

To: mlaurent, dfaure
Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven added a comment.


  ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25117

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26366: [Kuit] Port QRegExp to QRegularExpression, third pass

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kuitmarkup.cpp:90
>  
> -// Role.
> -roleName = context;
> +static const QRegularExpression 
> wsRx(QStringLiteral("^@(\\w+):?(\\w*)/?(\\w*)"));
> +const QRegularExpressionMatch match = wsRx.match(context);

Interesting idea, this simplifies the code.

However the name "wsRx" no longer matches what this regexp does.

Also, the old trimming is missing here, isn't it?
I guess \s*:?\s* is needed, and \s*/?\s*

Can you look into adding unittests for this stuff? Although I'm not sure if 
that's possible.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D26366

To: ahmadsamir, #frameworks, ilic, dfaure, mlaurent, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns