D26623: KEMailSettings: group names in kconfig files should not be localized

[David Faure]

dfaure added a subscriber: mlaurent.
dfaure added a comment.


  @mlaurent Does KMail show the profile name in the UI? I think this is why the 
profile name was translated, back then.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f5f43514af0d: [Plasma Quick] Add WaylandIntegration class 
(authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D26491?vs=72969=74068#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26491?vs=72969=74068

REVISION DETAIL
  https://phabricator.kde.org/D26491

AFFECTED FILES
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/dialog.cpp
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/dialogshadows_p.h
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/53/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 22 Jan 2020 00:32:26 +
 Build duration:
5 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 52 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/52/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Wed, 22 Jan 2020 00:32:26 +
 Build duration:
3 min 3 sec and counting

KDE CI: Frameworks » kwindowsystem » kf5-qt5 AndroidQt5.13 - Build # 51 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20AndroidQt5.13/51/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Wed, 22 Jan 2020 00:17:36 +
 Build duration:
13 min and counting
   CONSOLE OUTPUT
  [...truncated 195 lines...][2020-01-22T00:29:19.967Z] -- Looking for __GLIBC__ - not found[2020-01-22T00:29:19.967Z] -- Performing Test _OFFT_IS_64BIT[2020-01-22T00:29:19.967Z] -- Performing Test _OFFT_IS_64BIT - Failed[2020-01-22T00:29:19.967Z] -- Performing Test HAVE_DATE_TIME[2020-01-22T00:29:19.967Z] -- Performing Test HAVE_DATE_TIME - Success[2020-01-22T00:29:19.967Z] -- Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB) [2020-01-22T00:29:19.967Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-01-22T00:29:19.967Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-01-22T00:29:19.967Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-01-22T00:29:19.967Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-01-22T00:29:19.967Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-01-22T00:29:19.967Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-01-22T00:29:19.967Z] -- Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB) [2020-01-22T00:29:19.967Z] -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1") [2020-01-22T00:29:19.967Z] -- Could NOT find XCB_XCB (missing: XCB_XCB_LIBRARY XCB_XCB_INCLUDE_DIR) (found version "")[2020-01-22T00:29:19.967Z] -- Could NOT find XCB_ICCCM (missing: XCB_ICCCM_LIBRARY XCB_ICCCM_INCLUDE_DIR XCB_XCB_FOUND) (found version "")[2020-01-22T00:29:19.967Z] -- Could NOT find XCB_KEYSYMS (missing: XCB_KEYSYMS_LIBRARY XCB_KEYSYMS_INCLUDE_DIR XCB_XCB_FOUND) (found version "")[2020-01-22T00:29:19.967Z] -- Could NOT find XCB (missing: XCB_LIBRARIES XCB ICCCM KEYSYMS) [2020-01-22T00:29:19.967Z] -- The following OPTIONAL packages have been found:[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z]  * PkgConfig[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] -- The following REQUIRED packages have been found:[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z]  * ECM (required version >= 5.66.0), Extra CMake Modules., [2020-01-22T00:29:19.967Z]  * Qt5Gui (required version >= 5.13.2)[2020-01-22T00:29:19.967Z]  * Qt5Widgets[2020-01-22T00:29:19.967Z]  * Qt5Test[2020-01-22T00:29:19.967Z]  * Qt5 (required version >= 5.12.0)[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] -- The following features have been disabled:[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] -- The following OPTIONAL packages have not been found:[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z]  * X11[2020-01-22T00:29:19.967Z]  * XCB, X protocol C-language Binding, [2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] -- Configuring done[2020-01-22T00:29:19.967Z] -- Generating done[2020-01-22T00:29:19.967Z] CMake Warning:[2020-01-22T00:29:19.967Z]   Manually-specified variables were not used by the project:[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] KF5_HOST_TOOLING[2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] [2020-01-22T00:29:19.967Z] -- Build files have been written to: /home/user/workspace/Frameworks/kwindowsystem/kf5-qt5 AndroidQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-22T00:30:12.851Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kwindowsystem --branchGroup kf5-qt5 --platform AndroidQt5.13 --usingInstall /home/user/install-prefix/[2020-01-22T00:30:12.851Z] Scanning dependencies of target KF5WindowSystem_autogen[2020-01-22T00:30:12.851Z] [  2%] Automatic MOC for target KF5WindowSystem[2020-01-22T00:30:13.783Z] [  2%] Built target KF5WindowSystem_autogen[2020-01-22T00:30:14.723Z] Scanning dependencies of target KF5WindowSystem[2020-01-22T00:30:14.723Z] [  4%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o[2020-01-22T00:30:14.723Z] [  6%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kusertimestamp.cpp.o[2020-01-22T00:30:14.723Z] [  8%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kstartupinfo.cpp.o[2020-01-22T00:30:14.723Z] [ 10%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindoweffects.cpp.o[2020-01-22T00:30:14.723Z] [ 13%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindoweffects_dummy.cpp.o[2020-01-22T00:30:14.723Z] [ 15%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kkeyserver.cpp.o[2020-01-22T00:30:15.686Z] [ 17%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindowinfo.cpp.o[2020-01-22T00:30:15.687Z] [ 19%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindowshadow.cpp.o[2020-01-22T00:30:15.687Z] [ 21%] Building CXX object 

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/52/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 22 Jan 2020 00:17:32 +
 Build duration:
11 min and counting
   CONSOLE OUTPUT
  [...truncated 194 lines...][2020-01-22T00:26:00.858Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-01-22T00:26:00.858Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-01-22T00:26:00.858Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-01-22T00:26:00.858Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-01-22T00:26:00.858Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-01-22T00:26:00.858Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components: doxygen dot [2020-01-22T00:26:01.126Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2020-01-22T00:26:01.126Z] -- Found XCB_ICCCM: /usr/local/lib/libxcb-icccm.so (found version "0.4.1") [2020-01-22T00:26:01.126Z] -- Found XCB: /usr/local/lib/libxcb.so;/usr/local/lib/libxcb-keysyms.so;/usr/local/lib/libxcb-res.so;/usr/local/lib/libxcb-icccm.so (found version "1.13.1") found components: XCB ICCCM KEYSYMS [2020-01-22T00:26:01.126Z] -- The following features have been enabled:[2020-01-22T00:26:01.126Z] [2020-01-22T00:26:01.126Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-01-22T00:26:01.126Z] [2020-01-22T00:26:01.126Z] -- The following OPTIONAL packages have been found:[2020-01-22T00:26:01.126Z] [2020-01-22T00:26:01.126Z]  * X11[2020-01-22T00:26:01.126Z]  * PkgConfig[2020-01-22T00:26:01.126Z] [2020-01-22T00:26:01.126Z] -- The following REQUIRED packages have been found:[2020-01-22T00:26:01.126Z] [2020-01-22T00:26:01.126Z]  * ECM (required version >= 5.66.0), Extra CMake Modules., [2020-01-22T00:26:01.126Z]  * Qt5Gui (required version >= 5.13.2)[2020-01-22T00:26:01.126Z]  * Qt5Widgets[2020-01-22T00:26:01.126Z]  * Qt5X11Extras[2020-01-22T00:26:01.126Z]  * Doxygen (required version >= 1.8.13)[2020-01-22T00:26:01.126Z]Needed for API dox QCH file generation[2020-01-22T00:26:01.126Z]  * QHelpGenerator, Part of Qt5 tools[2020-01-22T00:26:01.126Z]Needed for API dox QCH file generation[2020-01-22T00:26:01.126Z]  * XCB, X protocol C-language Binding, [2020-01-22T00:26:01.126Z]  * Qt5Test[2020-01-22T00:26:01.126Z]  * Qt5 (required version >= 5.12.0)[2020-01-22T00:26:01.126Z] [2020-01-22T00:26:01.126Z] -- Configuring done[2020-01-22T00:26:01.398Z] -- Generating done[2020-01-22T00:26:01.398Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kwindowsystem/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-22T00:28:15.160Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kwindowsystem --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-01-22T00:28:15.160Z] Scanning dependencies of target Qt5Core_QCH[2020-01-22T00:28:15.160Z] Scanning dependencies of target Qt5Gui_QCH[2020-01-22T00:28:15.160Z] Scanning dependencies of target KF5WindowSystem_autogen[2020-01-22T00:28:15.160Z] [  1%] Built target Qt5Gui_QCH[2020-01-22T00:28:15.160Z] [  1%] Automatic MOC for target KF5WindowSystem[2020-01-22T00:28:15.160Z] [  1%] Built target Qt5Core_QCH[2020-01-22T00:28:15.160Z] Scanning dependencies of target KF5WindowSystem_QCH[2020-01-22T00:28:15.160Z] [  2%] Generating src/KF5WindowSystem.qch, src/KF5WindowSystem.tags[2020-01-22T00:28:15.734Z] [  2%] Built target KF5WindowSystem_autogen[2020-01-22T00:28:15.734Z] Scanning dependencies of target KF5WindowSystem[2020-01-22T00:28:15.734Z] [  3%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kkeyserver.cpp.o[2020-01-22T00:28:15.734Z] [  3%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_autogen/mocs_compilation.cpp.o[2020-01-22T00:28:15.734Z] [  4%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kstartupinfo.cpp.o[2020-01-22T00:28:15.734Z] [  5%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindowinfo.cpp.o[2020-01-22T00:28:15.734Z] [  7%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindoweffects_dummy.cpp.o[2020-01-22T00:28:15.734Z] [  7%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindoweffects.cpp.o[2020-01-22T00:28:15.734Z] [  7%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kusertimestamp.cpp.o[2020-01-22T00:28:15.734Z] [  8%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindowshadow.cpp.o[2020-01-22T00:28:16.672Z] [  8%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/kwindowsystem.cpp.o[2020-01-22T00:28:16.672Z] [  9%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/wayland/kwindowsystem.cpp.o[2020-01-22T00:28:16.672Z] [ 10%] Building CXX object 

D26457: Introduce shadows API

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:493452e98f99: Introduce shadows API (authored by zzag).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=74055=74060

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26457: Introduce shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 74055.
zzag added a comment.


  Set padding of 1 for missing borders

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26457?vs=73733=74055

BRANCH
  kwindowshadow

REVISION DETAIL
  https://phabricator.kde.org/D26457

AFFECTED FILES
  src/CMakeLists.txt
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/platforms/xcb/CMakeLists.txt
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25814: [KColorScheme] Add SeparatorColor

[Christoph Feck]

cfeck added a comment.


  > Why don't focus and hover colors belong?
  
  Because an application cannot know if and how a style does indicate focus or 
hovering.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26491: [Plasma Quick] Add WaylandIntegration class

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26491

To: zzag, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 410 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/410/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Jan 2020 23:17:41 +
 Build duration:
9 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.67.0.xmllogs/KF5KIO/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34762/62035)40%
(17681/43792)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9685/10146)47%
(4516/9576)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)59%
(8698/14622)51%
(4530/8863)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4684/8322)43%
(2072/4806)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(687/1260)40%
(396/978)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(524/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 277 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/277/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 21 Jan 2020 23:17:41 +
 Build duration:
7 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[David Faure]

dfaure added a comment.


  Fixed, thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: iasensio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[David Faure]

dfaure added a reviewer: mlaurent.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T12567: Reduce code/effort duplication around color scheme support

[Noah Davis]

ndavis added a comment.


  In T12567#218405 , @davidedmundson 
wrote:
  
  > The former won't know when to update, the latter can.
  
  
  So we'll need to make property bindings anyway? Or maybe we can use arrays 
instead of writing 108 individual variables?
  
  > As for the duplication a lot is simply down to layering and dependency 
issues of the time. If we can move this, then we're sorted.
  >  Extending QPalette would be the ideal solution to that.
  
  I'm a little confused. Are you saying we should contribute new ColorRoles to 
QPalette and deprecate KColorScheme?

TASK DETAIL
  https://phabricator.kde.org/T12567

To: ndavis
Cc: davidedmundson, ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, 
ekasprzak, ragreen, domson, michaelh, ahmadsamir, dkardarakos, ZrenBot, 
ngraham, bruns, alexeymin, kpiwowarski, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, asturmlechner, jucato, cfeck, abetts, cgiboudeaux, cullmann, 
vkrause, sebas, cordlandwehr, apol, ahiemstra, mart, hein, knauss, dfaure

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ismael Asensio]

iasensio added a comment.


  Hi! This change fails to build for me, and also in CI  
(https://build.kde.org/view/Failing/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/console)
  
kcoredirlister_p.h:148:37: error: field 'lstFilters' has incomplete type 
'QVector'
09:29:39148 | QVector lstFilters;
  
  I just needed to `#include ` to fix it

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26659

To: ahmadsamir, dfaure
Cc: iasensio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:68c1cfd0d8dc: Fix python bindings build after 
ebd14f29f8052ff5119bf97b42e61f404f223615 (authored by arojas).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26815?vs=74042=74048

REVISION DETAIL
  https://phabricator.kde.org/D26815

AFFECTED FILES
  cmake/rules_PyKF5.py

To: arojas, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T12567: Reduce code/effort duplication around color scheme support

[David Edmundson]

davidedmundson added a comment.


  > QML can use C++ functions right? Would we still need to make property 
bindings for all the colors if we had color() functions?
  
  C++ functions can be exposed to QML.
  
  However:
  
color: myObject.color(fooBar);
  
  has one behaviour big behavioural difference to
  
color: myObject.fooBarColor;
  
  The former won't know when to update, the latter can.
  
  As for the duplication a lot is simply down to layering and dependency issues 
of the time. If we can move this, then we're sorted.
  Extending QPalette would be the ideal solution to that.

TASK DETAIL
  https://phabricator.kde.org/T12567

To: ndavis, davidedmundson
Cc: davidedmundson, ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, 
ekasprzak, ragreen, domson, michaelh, ahmadsamir, dkardarakos, ZrenBot, 
ngraham, bruns, alexeymin, kpiwowarski, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, asturmlechner, jucato, cfeck, abetts, cgiboudeaux, cullmann, 
vkrause, sebas, cordlandwehr, apol, ahiemstra, mart, hein, knauss, dfaure

D26047: Expose KConfig settings to allow registration in KCM Notification

[Kai Uwe Broulik]

broulik added a comment.


  Other than the seemingly missing `config`, looks good

INLINE COMMENTS

> settings.cpp:173
> -if (!s_settingsInited) {
> -DoNotDisturbSettings::instance(config);
> -NotificationSettings::instance(config);

I still want to be able to specify what `config` (constructor argument) to use 
for autotests

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

[Nicolas Fella]

nicolasfella accepted this revision.
nicolasfella added a comment.
This revision is now accepted and ready to land.


  looks sensible, but I haven't tried it myself

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26815

To: arojas, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26101: Port away from Qt 5.14 deprecated QList methods

[Ahmad Samir]

ahmadsamir added a comment.


  FTR, a recent discussion on #kde-devel on Freenode, which involved QSet and 
toSet(), made me understand why the original code was using toSet(), then 
fromSet(), it was to remove duplicates as QSet doesn't allow duplicates.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D26101

To: ahmadsamir, #baloo, meven, bruns, astippich, dfaure
Cc: alexeymin, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

[Antonio Rojas]

arojas created this revision.
arojas added reviewers: nicolasfella, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  The new API breaks python bindings compilation since sip can't understand 
KSharedConfig::Ptr type

TEST PLAN
  Builds

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26815

AFFECTED FILES
  cmake/rules_PyKF5.py

To: arojas, nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T12567: Reduce code/effort duplication around color scheme support

[Noah Davis]

ndavis added a comment.


  QML can use C++ functions right? Would we still need to make property 
bindings for all the colors if we had color() functions?

TASK DETAIL
  https://phabricator.kde.org/T12567

To: ndavis
Cc: ognarb, plasma-devel, kde-frameworks-devel, ndavis, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, davidre, fbampaloukas, GB_2, ekasprzak, 
ragreen, domson, michaelh, ahmadsamir, dkardarakos, ZrenBot, ngraham, bruns, 
alexeymin, kpiwowarski, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
asturmlechner, jucato, cfeck, abetts, cgiboudeaux, cullmann, vkrause, sebas, 
cordlandwehr, apol, ahiemstra, davidedmundson, mart, hein, knauss, dfaure

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  I think this is still ultimately the right thing to do. Making the 
frame/separator color a mix of 2 other colors makes it harder to get just the 
right color for both the light and dark variations of a theme unless you design 
the color palettes to solve problems in the QStyle. That makes it more 
difficult for users/3rd parties to design color schemes unless you're very 
familiar with the way the QStyle works.
  
  I missed this from before:
  
  In D25814#574152 , @cfeck wrote:
  
  > I also agree with the concerns rised by Hugo. An application will use 
various frame primitives, and the style decides how to draw them. It doesn't 
belong in the API, though (but neither do Focus and Hover colors).
  
  
  Why don't focus and hover colors belong?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi marked an inline comment as done.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 74036.
trmdi marked 2 inline comments as done.
trmdi added a comment.


  - Address comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=74030=74036

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26812: Variable expansion: Add variable PercentEncoded

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b0055e8476bb: Variable expansion: Add variable 
PercentEncoded (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26812?vs=74032=74034

REVISION DETAIL
  https://phabricator.kde.org/D26812

AFFECTED FILES
  autotests/src/variable_test.cpp
  src/utils/katevariableexpansionmanager.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26811: Fix crash in variable expansion (used by external tools)

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:22fa707eb7e2: Fix crash in variable expansion (used by 
external tools) (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26811?vs=74031=74033

REVISION DETAIL
  https://phabricator.kde.org/D26811

AFFECTED FILES
  autotests/src/variable_test.cpp
  src/utils/katevariableexpansionhelpers.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26812: Variable expansion: Add variable PercentEncoded

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  variable-percent-encoded

REVISION DETAIL
  https://phabricator.kde.org/D26812

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26812: Variable expansion: Add variable PercentEncoded

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  This can be used to encode the input text such that it can
  be used in URIs. This is useful e.g. for the external tool
  "Google Selected Text", where '&' and similar characters
  are problematic in the url.
  
  CCBUG: 416509

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  variable-percent-encoded

REVISION DETAIL
  https://phabricator.kde.org/D26812

AFFECTED FILES
  autotests/src/variable_test.cpp
  src/utils/katevariableexpansionmanager.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26811: Fix crash in variable expansion (used by external tools)

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-variable-expansion

REVISION DETAIL
  https://phabricator.kde.org/D26811

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26691: Optimize code when dropping files into the desktop

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Cool cool. I think there's potential to move more logic from 
ContainmentInterface into DropMenu object, but we can spread that task out.
  
  We actually have some crashers in this mime handling code, so I'm happy to 
see someone spending some time on it.
  
  (Somewhere in 
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED_id=1705725=ContainmentInterface_type=allwordssubstr=frameworks-plasma=plasmashell_format=advanced)
 might be worth taking a look.

INLINE COMMENTS

> dropmenu.cpp:66
> +{
> +if (m_urls != urls) {
> +m_urls = urls;

This is slower than just assigning

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi marked 3 inline comments as done.
trmdi added inline comments.

INLINE COMMENTS

> davidedmundson wrote in containmentinterface.cpp:548
> can you be sure urls has at least 1 at this point?

Yes, because all `clearDataForMimeJob` are called from inside of 
`mimeTypeRetrieved` which is only called from here: 
https://phabricator.kde.org/source/plasma-framework/browse/master/src/scriptengines/qml/plasmoid/containmentinterface.cpp$454

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26811: Fix crash in variable expansion (used by external tools)

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  findClosing() is already called with +2 to account for the
  starting %{ characters. So we start at the given pos and
  increment it only after the while loop. Unbalanced cases
  of '{' and '}' are now also unit tested.

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-variable-expansion

REVISION DETAIL
  https://phabricator.kde.org/D26811

AFFECTED FILES
  autotests/src/variable_test.cpp
  src/utils/katevariableexpansionhelpers.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 74030.
trmdi added a comment.


  - Code style

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=74025=74030

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Nathaniel Graham]

ngraham added a comment.


  In D26782#597916 , @meven wrote:
  
  > In D26782#597811 , @ngraham 
wrote>
  >
  > > But should we just hide them, or not even create them in the first place? 
Creating hidden-by-default entries seems a bit off.
  >
  >
  > I chose hidden by value just to keep the feature somewhat more discoverable 
than if it was not present at all.
  >  I would be fine not adding those in the first place too. It may be simpler 
also.
  
  
  I would recommend it. Anything that's hidden by default isn't actually 
discoverable at all, and it sends the wrong message too; it means that we don't 
actually have confidence in the feature (as indeed, we do not for these old 
entries). I think it would be simpler and more appropriate to just not add them 
at all.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 74025.
trmdi added a comment.


  - Handle the case in which the menu is not shown

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=73815=74025

BRANCH
  improve-file-drop-menu

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 74023.
crossi added a comment.


  Remove unneeded forward declaration

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=74021=74023

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  I like it, just an unwanted change to clean up still. @broulik what say you?

INLINE COMMENTS

> settings.h:33
>  
> +class KCoreConfigSkeleton;
> +

This change isn't needed anymore.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

crossi updated this revision to Diff 74021.
crossi added a comment.


  Following discussion with @ervin and @broulik, export generated KConfig 
settings, remove singleton option. The KCM will have its own KConfig settings' 
instance like other KCMs.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=73214=74021

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp
  libnotificationmanager/settings.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26794

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74016.
leinir added a comment.


  - Allow clearing the Rating control when editable
  - Initial new-comment sheet (needs some layout work)

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26794?vs=73944=74016

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26794

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/provider.h
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/ui/entrydetailsdialog.cpp
  src/ui/itemsviewdelegate.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26066: [KProcessInfo] Add parent PID

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Am now using ksysguard..

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D26066

To: broulik, #frameworks, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven added a task: T12551: Revamp KCM/Component chooser.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26801: Really fix the Windows backend for KNotifications

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:90
> +KNotification *notification = m_notifications.value(id);
> +if (notification == 0) {
>  qCDebug(LOG_KNOTIFICATIONS) << "Notification not found!";

if (!notification) or at least compare with nullptr
And remove the commented KNotificaion*

> vonreth wrote in notifybysnore.h:48
> m_notificationsRev
> m_counter
> 
> KDE and Qt uses cammelCase and member vars are prefixed with an "m_".
> 
> m_notifications it only used to see which notification was closed by a user 
> interaction to snoretoast (this part i probably broken right now).
> There is no need to keep two maps.

now add white space around the = :)

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 marked an inline comment as done.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 74005.
brute4s99 marked 3 inline comments as done.
brute4s99 added a comment.


  update the diff.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26801?vs=73983=74005

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26801

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/99/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Jan 2020 10:36:38 +
 Build duration:
2 min 57 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(71/86)83%
(71/86)61%
(4908/8079)39%
(2015/5175)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)72%
(1138/1588)31%
(416/1340)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services93%
(28/30)93%
(28/30)50%
(1505/3040)31%
(550/1796)src.sycoca83%
(24/29)83%
(24/29)75%
(2069/2743)60%
(997/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/73/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 21 Jan 2020 10:36:39 +
 Build duration:
2 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(71/86)83%
(71/86)61%
(4908/8079)39%
(2013/5175)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)72%
(1138/1588)31%
(414/1340)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services93%
(28/30)93%
(28/30)50%
(1505/3040)31%
(550/1796)src.sycoca83%
(24/29)83%
(24/29)75%
(2069/2743)60%
(997/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/70/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 21 Jan 2020 10:36:39 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R309:f10db4e6f0af: Make Default Applications in 
mimeapps.list the preferred applications (authored by meven).

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26690?vs=74002=74003

REVISION DETAIL
  https://phabricator.kde.org/D26690

AFFECTED FILES
  autotests/kmimeassociationstest.cpp
  src/kdeinit/ktoolinvocation_x11.cpp
  src/sycoca/kmimeassociations.cpp

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven updated this revision to Diff 74002.
meven added a comment.


  Fix indentation issue

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26690?vs=73996=74002

BRANCH
  arcpatch-D26690

REVISION DETAIL
  https://phabricator.kde.org/D26690

AFFECTED FILES
  autotests/kmimeassociationstest.cpp
  src/kdeinit/ktoolinvocation_x11.cpp
  src/sycoca/kmimeassociations.cpp

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Kevin Ottens]

ervin accepted this revision.

REPOSITORY
  R309 KService

BRANCH
  arcpatch-D26690

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26800: autotests: use local desktop file to avoid relying on konsole

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in kservicetest.cpp:73
> (to expand on my previous reply: this line ensures that we copy the desktop 
> files into a test-specific directory)

Thanks, did not notice this line and did not know setTestModeEnabled
Learning every day...

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26800

To: dfaure, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26800: autotests: use local desktop file to avoid relying on konsole

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kservicetest.cpp:73
>  setupXdgDirs();
>  QStandardPaths::setTestModeEnabled(true);
>  

(to expand on my previous reply: this line ensures that we copy the desktop 
files into a test-specific directory)

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26800

To: dfaure, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in notifybysnore.cpp:143
> So the problem isn't here. notification id should be always valid and not 
> calculated here.

I'm not sure what would be correct here but just ignoring those notifications 
sounds like a bad idea.

This is really a question for @broulik

> notifybysnore.cpp:148
> +Q_UNUSED(config);
> +int new_ID = counter;
> +counter++;

const newId = m_counter++;

> notifybysnore.cpp:201
> +if (rev_m_notifications.constFind(notification) == 
> rev_m_notifications.constEnd()) {
>  return;
>  }

At least warn?

> notifybysnore.cpp:203
>  }
> -qCDebug(LOG_KNOTIFICATIONS) << "SnoreToast closing notification with ID: 
> " << notification->id();
> +int new_ID = rev_m_notifications.value(notification);
> +qCDebug(LOG_KNOTIFICATIONS) << "SnoreToast closing notification with ID: 
> " << new_ID;

const int newId

> notifybysnore.h:48
>  QTemporaryDir m_iconDir;
> +QHash rev_m_notifications;
> +int counter=0;

m_notificationsRev
m_counter

KDE and Qt uses cammelCase and member vars are prefixed with an "m_".

m_notifications it only used to see which notification was closed by a user 
interaction to snoretoast (this part i probably broken right now).
There is no need to keep two maps.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven marked 6 inline comments as done.

REPOSITORY
  R309 KService

BRANCH
  arcpatch-D26690

REVISION DETAIL
  https://phabricator.kde.org/D26690

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26690: Make "Default Applications" in mimeapps.list the preferred applications

[Méven Car]

meven updated this revision to Diff 73996.
meven added a comment.


  Add explanatory comment regarding 25 magic number

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26690?vs=73913=73996

BRANCH
  arcpatch-D26690

REVISION DETAIL
  https://phabricator.kde.org/D26690

AFFECTED FILES
  autotests/kmimeassociationstest.cpp
  src/kdeinit/ktoolinvocation_x11.cpp
  src/sycoca/kmimeassociations.cpp

To: meven, dfaure, dvratil, ervin, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

meven updated this revision to Diff 73995.
meven marked an inline comment as done.
meven added a comment.


  Added missing spaces

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=73917=73995

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

meven added a comment.


  In D26782#597811 , @ngraham wrote>
  
  > But should we just hide them, or not even create them in the first place? 
Creating hidden-by-default entries seems a bit off.
  
  
  I chose hidden by value just to keep the feature somewhat more discoverable 
than if it was not present at all.
  I would be fine not adding those in the first place too. It may be simpler 
also.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 276 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/276/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 21 Jan 2020 08:34:05 +
 Build duration:
6 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 72 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/72/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 21 Jan 2020 08:33:38 +
 Build duration:
2 min 24 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(71/86)83%
(71/86)61%
(4909/8082)39%
(2017/5185)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)72%
(1139/1587)31%
(418/1340)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/333)0%
(0/235)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services93%
(28/30)93%
(28/30)50%
(1505/3040)31%
(550/1796)src.sycoca83%
(24/29)83%
(24/29)75%
(2069/2743)60%
(997/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 98 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/98/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Jan 2020 08:33:38 +
 Build duration:
2 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(71/86)83%
(71/86)61%
(4907/8082)39%
(2013/5185)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)72%
(1137/1587)31%
(414/1340)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/333)0%
(0/235)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services93%
(28/30)93%
(28/30)50%
(1505/3040)31%
(550/1796)src.sycoca83%
(24/29)83%
(24/29)75%
(2069/2743)60%
(997/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/69/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 21 Jan 2020 08:33:38 +
 Build duration:
2 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 275 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/275/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 21 Jan 2020 08:26:18 +
 Build duration:
7 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26800: autotests: use local desktop file to avoid relying on konsole

[David Faure]

dfaure closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26800

To: dfaure, meven, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 409 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/409/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Jan 2020 08:28:32 +
 Build duration:
1 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 670 lines...][2020-01-21T08:29:33.874Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/usernotificationhandler.cpp.o[2020-01-21T08:29:33.874Z] [ 11%] Linking CXX executable ../../../../bin/kcookiejar5[2020-01-21T08:29:33.874Z] [ 11%] Built target httpheadertokenizetest[2020-01-21T08:29:33.874Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/ksambasharedata.cpp.o[2020-01-21T08:29:34.130Z] [ 11%] Linking CXX shared module ../../../../bin/kf5/kded/kcookiejar.so[2020-01-21T08:29:34.386Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/ksambashare.cpp.o[2020-01-21T08:29:34.386Z] [ 11%] Built target httpheaderdispositiontest[2020-01-21T08:29:34.386Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/knfsshare.cpp.o[2020-01-21T08:29:34.386Z] [ 11%] Built target kcookiejar5[2020-01-21T08:29:34.386Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kfileitem.cpp.o[2020-01-21T08:29:34.386Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/davjob.cpp.o[2020-01-21T08:29:34.642Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/deletejob.cpp.o[2020-01-21T08:29:34.642Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/copyjob.cpp.o[2020-01-21T08:29:34.897Z] [ 13%] Built target kded_kcookiejar[2020-01-21T08:29:34.897Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filejob.cpp.o[2020-01-21T08:29:34.897Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkdirjob.cpp.o[2020-01-21T08:29:34.897Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkpathjob.cpp.o[2020-01-21T08:29:34.897Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverloop.cpp.o[2020-01-21T08:29:35.152Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverclient.cpp.o[2020-01-21T08:29:35.152Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kremoteencoding.cpp.o[2020-01-21T08:29:35.152Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/sessiondata.cpp.o[2020-01-21T08:29:35.408Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slavebase.cpp.o[2020-01-21T08:29:35.663Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataslave.cpp.o[2020-01-21T08:29:35.663Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o[2020-01-21T08:29:35.918Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/desktopexecparser.cpp.o[2020-01-21T08:29:35.918Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/emptytrashjob.cpp.o[2020-01-21T08:29:35.918Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/authinfo.cpp.o[2020-01-21T08:29:35.918Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slaveinterface.cpp.o[2020-01-21T08:29:35.918Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slave.cpp.o[2020-01-21T08:29:36.174Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job_error.cpp.o[2020-01-21T08:29:36.174Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job.cpp.o[2020-01-21T08:29:36.735Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filecopyjob.cpp.o[2020-01-21T08:29:36.735Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/listjob.cpp.o[2020-01-21T08:29:36.735Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mimetypejob.cpp.o[2020-01-21T08:29:36.735Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/multigetjob.cpp.o[2020-01-21T08:29:36.991Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/restorejob.cpp.o[2020-01-21T08:29:36.991Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/specialjob.cpp.o[2020-01-21T08:29:36.991Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/simplejob.cpp.o[2020-01-21T08:29:37.246Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/statjob.cpp.o[2020-01-21T08:29:37.806Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/storedtransferjob.cpp.o[2020-01-21T08:29:37.806Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/transferjob.cpp.o[2020-01-21T08:29:37.806Z] [ 17%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filesystemfreespacejob.cpp.o[2020-01-21T08:29:37.806Z] [ 17%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/scheduler.cpp.o[2020-01-21T08:29:37.806Z] [ 17%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slaveconfig.cpp.o[2020-01-21T08:29:37.806Z] [ 17%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kprotocolmanager.cpp.o[2020-01-21T08:29:38.062Z] [ 17%] Building CXX object 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 408 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/408/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 21 Jan 2020 08:26:17 +
 Build duration:
2 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 663 lines...][2020-01-21T08:28:06.304Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connectionbackend.cpp.o[2020-01-21T08:28:06.562Z] [ 11%] Built target httpheaderdispositiontest[2020-01-21T08:28:06.562Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connection.cpp.o[2020-01-21T08:28:06.819Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/connectionserver.cpp.o[2020-01-21T08:28:07.077Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/krecentdocument.cpp.o[2020-01-21T08:28:07.334Z] [ 11%] Linking CXX executable ../../bin/httpheadertokenizetest[2020-01-21T08:28:07.590Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kfileitemlistproperties.cpp.o[2020-01-21T08:28:07.862Z] [ 11%] Built target httpheadertokenizetest[2020-01-21T08:28:07.862Z] [ 11%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/tcpslavebase.cpp.o[2020-01-21T08:28:07.862Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/directorysizejob.cpp.o[2020-01-21T08:28:08.125Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/forwardingslavebase.cpp.o[2020-01-21T08:28:08.383Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/chmodjob.cpp.o[2020-01-21T08:28:08.947Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kdiskfreespaceinfo.cpp.o[2020-01-21T08:28:09.203Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/usernotificationhandler.cpp.o[2020-01-21T08:28:09.769Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/ksambasharedata.cpp.o[2020-01-21T08:28:10.029Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/ksambashare.cpp.o[2020-01-21T08:28:10.288Z] [ 12%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/knfsshare.cpp.o[2020-01-21T08:28:10.288Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kfileitem.cpp.o[2020-01-21T08:28:10.288Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/davjob.cpp.o[2020-01-21T08:28:10.850Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/deletejob.cpp.o[2020-01-21T08:28:11.106Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/copyjob.cpp.o[2020-01-21T08:28:12.047Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filejob.cpp.o[2020-01-21T08:28:12.047Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkdirjob.cpp.o[2020-01-21T08:28:12.314Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mkpathjob.cpp.o[2020-01-21T08:28:13.246Z] [ 13%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverloop.cpp.o[2020-01-21T08:28:13.508Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kpasswdserverclient.cpp.o[2020-01-21T08:28:13.764Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/kremoteencoding.cpp.o[2020-01-21T08:28:13.764Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/sessiondata.cpp.o[2020-01-21T08:28:14.021Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slavebase.cpp.o[2020-01-21T08:28:14.282Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataslave.cpp.o[2020-01-21T08:28:14.848Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/dataprotocol.cpp.o[2020-01-21T08:28:15.410Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/desktopexecparser.cpp.o[2020-01-21T08:28:15.666Z] [ 14%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/emptytrashjob.cpp.o[2020-01-21T08:28:16.246Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/authinfo.cpp.o[2020-01-21T08:28:16.246Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slaveinterface.cpp.o[2020-01-21T08:28:16.511Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/slave.cpp.o[2020-01-21T08:28:17.079Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job_error.cpp.o[2020-01-21T08:28:17.336Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/job.cpp.o[2020-01-21T08:28:18.712Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/filecopyjob.cpp.o[2020-01-21T08:28:18.712Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/listjob.cpp.o[2020-01-21T08:28:18.968Z] [ 15%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/mimetypejob.cpp.o[2020-01-21T08:28:19.224Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/multigetjob.cpp.o[2020-01-21T08:28:19.224Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/restorejob.cpp.o[2020-01-21T08:28:19.791Z] [ 16%] Building CXX object src/core/CMakeFiles/KF5KIOCore.dir/simplejob.cpp.o[2020-01-21T08:28:20.358Z] [ 16%] Building CXX object 

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0d2959c96b6b: Fix 
QRegularExpression::wildcardToRegularExpression() usage (authored by 
ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26692?vs=73991=73992

REVISION DETAIL
  https://phabricator.kde.org/D26692

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/kpac/script.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26692: Fix QRegularExpression::wildcardToRegularExpression() usage

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73991.
ahmadsamir added a comment.


  Rebase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26692?vs=73650=73991

BRANCH
  l-qregularexpression-too-wildcard (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26692

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp
  src/kpac/script.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 73989.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Rebase and tweak the commit message

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73796=73989

BRANCH
  l-qregexp-deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26659: [KCoreDirLister] Port QRegExp to QRegularExpression

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:df383663d14e: [KCoreDirLister] Port QRegExp to 
QRegularExpression (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26659?vs=73989=73990

REVISION DETAIL
  https://phabricator.kde.org/D26659

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister.h
  src/core/kcoredirlister_p.h

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns