D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent added a comment.


  it replace D26432 
  I don't know why it created a new version

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

[Laurent Montel]

mlaurent abandoned this revision.
mlaurent added a comment.


  created a new one D26860 

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26432

To: mlaurent, dfaure, tcanabrava
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Port endl to "\n" as it's qt namespaced

TEST PLAN
  autotest ok

REPOSITORY
  R237 KConfig

BRANCH
  port_endl (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26860

AFFECTED FILES
  autotests/kconfigtest.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

[Laurent Montel]

mlaurent added a reviewer: dfaure.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26860

To: mlaurent, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 updated this revision to Diff 74190.
brute4s99 marked 2 inline comments as done.
brute4s99 added a comment.


  updated

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26801?vs=74005=74190

BRANCH
  arcpatch-D26801

REVISION DETAIL
  https://phabricator.kde.org/D26801

AFFECTED FILES
  src/notifybysnore.cpp
  src/notifybysnore.h

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis added a comment.


  In D26758#599231 , @davidedmundson 
wrote:
  
  > Please be sure to run the relevant tests in
  >
  > tests/components/
  >
  > with qmlscene
  >
  > It'll find more than running random applets
  
  
  Unfortunately, those have visual glitches, even for widgets that are normally 
perfectly fine.
  `qmlscene button.qml` (untouched by this patch): The position of the left 
side is off by half a pixel.
  F7918757: Screenshot_20200123_002724.PNG 

  `qmlscene checkbox.qml` (patch vs git master): these unchecked checkboxes are 
normally perfectly fine, but are somehow very wrong. I'm not sure what's going 
there.
  F7918911: Screenshot_20200123_003405.PNG 

  
  I can't figure out what might be wrong with the tests just by looking at the 
source code of the QML files.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26839: demote plugin load errors from warning to debug level + reword

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.


  Agreed, let's commit.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26839

To: sitter, mpyne, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26858: Provide an implementation for the tablet interface

[Aleix Pol Gonzalez]

apol added a dependent revision: D26859: Implement the tablet wayland protocol 
in kwin.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26858

To: apol, #kwin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev, ndavis
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26858: Provide an implementation for the tablet interface

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Implements the necessary classes to have proper support for the tablet and 
pen.
  Doesn't implement yet the ring/slider/totem bits.

TEST PLAN
  Used it with Plasma and GTK clients, together with the kwin patch I'll submit 
soon.
  https://youtu.be/GGx0TlNJlzs
  
  Also I added a test.

REPOSITORY
  R127 KWayland

BRANCH
  apol/tablet-unstable-v2

REVISION DETAIL
  https://phabricator.kde.org/D26858

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_tablet_interface.cpp
  src/server/tablet_interface.cpp
  src/server/tablet_interface.h

To: apol, #kwin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  If @ndavis says it's okay, I say shipit!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26855: Add icon for KTrip

[Nicolas Fella]

nicolasfella added reviewers: Breeze, ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26855

To: nicolasfella, #breeze, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26855: Add icon for KTrip

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The icon itself is not new, it has been shipped in the ktrip repo already. To 
include KTrip in kde.org/applications it needs to be in breeze-icons though

REPOSITORY
  R266 Breeze Icons

BRANCH
  ktrip

REVISION DETAIL
  https://phabricator.kde.org/D26855

AFFECTED FILES
  icons-dark/apps/48/ktrip.svg
  icons/apps/48/ktrip.svg

To: nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[David Edmundson]

davidedmundson added a comment.


  Please be sure to run the relevant tests in
  
  tests/components/
  
  with qmlscene
  
  It'll find more than running random applets

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D26841: hardware tool: define syntax via syntax arg

[Harald Sitter]

sitter edited the summary of this revision.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

[Noah Davis]

ndavis retitled this revision from "[WIP] Fix the size and pixel alignment of 
checkboxes and radiobuttons" to "Fix the size and pixel alignment of checkboxes 
and radiobuttons".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26670: ki18n_wrap_ui: error when file doesn't exist

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think this ok the way it is now, or?

REPOSITORY
  R249 KI18n

BRANCH
  error (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26670

To: davidre, #framework_syntax_highlighting, #localization, #build_system, 
cullmann
Cc: cullmann, ngraham, kossebau, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D26779: Updates nasm.xml with the latest instructions

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7a4b9f691733: Updates nasm.xml with the latest 
instructions (authored by meganomic, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26779?vs=73910=74166

REVISION DETAIL
  https://phabricator.kde.org/D26779

AFFECTED FILES
  data/syntax/nasm.xml

To: meganomic, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D26779: Updates nasm.xml with the latest instructions

[Christoph Cullmann]

cullmann added a comment.


  I will push this, thanks for the patch!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  nasm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26779

To: meganomic, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D26840: Correctly set underMouse() for inline notes

[Sven Brauch]

brauch added a comment.


  My guess is right now the view updates when the cursor blinks, so that's why 
it updates after a short moment (of varying length, though, if you look at the 
video). Since the line is tagged dirty, it gets repainted correctly, but too 
late.

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor, cullmann
Cc: brauch, cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26840: Correctly set underMouse() for inline notes

[Sven Brauch]

brauch added a comment.


  Hm, yeah, looking at the code I think you might need to call `updateView()` 
in case a focus in or out happened. Can you try if that makes a difference?

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor, cullmann
Cc: brauch, cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26793: Exclude the KSharedConfig::openStateConfig from the sip parser

[Juraj Oravec]

SGOrava abandoned this revision.
SGOrava added a comment.


  Done in https://phabricator.kde.org/D26815

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26793

To: SGOrava, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26848: Don't assume the manager and menu have the same lifetime

[David Redondo]

davidre added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D26848

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26848: Don't assume the manager and menu have the same lifetime

[David Redondo]

davidre created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The menu we retun can outlive the manager. So we can't use it or its members 
in
  slots when connecting to signals of the menu or it's actions. This also 
switches
  the actions' data() back to being the schemePaths instead of the rows of the
  corresponding indices.

TEST PLAN
  Open Labplot which currently triggers this crash.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  menumanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26848

AFFECTED FILES
  src/kcolorschememanager.cpp
  src/kcolorschememanager_p.h

To: davidre
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26841: hardware tool: define syntax via syntax arg

[Stefan Brüns]

bruns added a comment.


  Please do proper capitalization in the summary.
  
  And "nothing infurates me more" is not relevant for a commit message.
  
  Otherwise LGTM.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D26841

To: sitter
Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D26840: Correctly set underMouse() for inline notes

[David Redondo]

davidre added a comment.


  In D26840#599082 , @brauch wrote:
  
  > Is the video the new behaviour? It still looks a bit weird to me, there is 
a slight delay between the mouse entering the area and the highlight changing.
  >
  > Is it possible that the line (and thus the note) is not properly marked for 
repaint when the underMouse property changes?
  
  
  Yes it's the new behavior, before it wouldn't change at all. I think the 
tagLines marks the line for repainting but I didn't yet look if the this also 
triggers painting of lines. Or maybe it's a bit slow because of my debug setup?

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor, cullmann
Cc: brauch, cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26840: Correctly set underMouse() for inline notes

[Sven Brauch]

brauch added a comment.


  Is the video the new behaviour? It still looks a bit weird to me, there is a 
slight delay between the mouse entering the area and the highlight changing.
  
  Is it possible that the line (and thus the note) is not properly marked for 
repaint when the underMouse property changes?

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor, cullmann
Cc: brauch, cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D25015: Update breeze theme shadows

[Dominic Hayes]

The-Feren-OS-Dev accepted this revision.
The-Feren-OS-Dev added a comment.


  I feel like the shadows might be slightly overcompensating in shadow strength 
for the small shadow span (it looks kinda weird on first glance), but apart 
from that minor nitpick, I'd say this is good to go.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  I found a way to make masks that follow the current shape by copying it and 
making them slightly bigger than original ones. 
  Regarding panels and tooltips: using different roundings (1px vs 3px) seemed 
inconsistent to me, so I tried to ask in the VDG chat if they though that 
moving panels and tooltips to 3px was a good idea, which I also think (e.g.: 
panel endings should be rounded rather than sharp). I thus moved them to 3px 
rounding as well. I think it's barely noticeable but it looks better than 
before. I put it in this patch as it was closely related and on the same files, 
but I could create a different patch if you think it's more appropriate.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 74153.
niccolove added a comment.


  Corrected masks to be more similiar to original shapes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25015?vs=73844=74153

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove, #vdg, ngraham
Cc: mart, broulik, cblack, ndavis, manueljlin, ngraham, filipf, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26840: Correctly set underMouse() for inline notes

[David Redondo]

davidre added a comment.


  I stumbled upon while doing 
https://invent.kde.org/kde/kdevelop/merge_requests/92

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26400: Migrate config from KConfig to KConfigXt in order to allow KCM to use it

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:71fb41ae9ae8: Migrate config from KConfig to KConfigXt in 
order to allow KCM to use it (authored by bport).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26400?vs=72909=74139

REVISION DETAIL
  https://phabricator.kde.org/D26400

AFFECTED FILES
  src/file/CMakeLists.txt
  src/file/baloosettings.kcfgc
  src/file/extractor/CMakeLists.txt
  src/file/fileindexerconfig.cpp
  src/file/fileindexerconfig.h
  src/lib/CMakeLists.txt
  src/lib/baloosettings.kcfg
  src/lib/baloosettings.kcfgc
  src/lib/indexerconfig.cpp
  src/tools/balooctl/main.cpp

To: bport, ervin, crossi, meven, #plasma, bruns
Cc: meven, crossi, ervin, kde-frameworks-devel, #baloo, #plasma, hurikhan77, 
lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D26840: Correctly set underMouse() for inline notes

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks reasonable.
  Btw., does somebody use that now for something useful?

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Kevin Ottens]

ervin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26832: Add icon for application/sql

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6be022ac5f4a: Add icon for application/sql (authored by 
broulik).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26832?vs=74093=74129

REVISION DETAIL
  https://phabricator.kde.org/D26832

AFFECTED FILES
  icons-dark/mimetypes/16/application-sql.svg
  icons-dark/mimetypes/22/application-sql.svg
  icons-dark/mimetypes/32/application-sql.svg
  icons-dark/mimetypes/64/application-sql.svg
  icons/mimetypes/16/application-sql.svg
  icons/mimetypes/22/application-sql.svg
  icons/mimetypes/32/application-sql.svg
  icons/mimetypes/64/application-sql.svg

To: broulik, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 74128.
crossi added a comment.


  code style

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=74125=74128

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Just a tiny nitpick left.

INLINE COMMENTS

> managedconfigmodule.cpp:175
> +   , d->_skeletons.end()
> +   , [](const QPointer 
> ){ return value.isNull(); });
> +d->_skeletons.erase(toRemove, d->_skeletons.end());

Nitpicking but in function call we generally don't have commas at the start of 
line but at the end of the line before. Also there should be a space after the 
closing parenthesis of the lambda declaration.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi updated this revision to Diff 74125.
crossi added a comment.


  Clean the list properly

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26046?vs=73411=74125

REVISION DETAIL
  https://phabricator.kde.org/D26046

AFFECTED FILES
  src/quickaddons/managedconfigmodule.cpp
  src/quickaddons/managedconfigmodule.h

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 278 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/278/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 22 Jan 2020 14:42:35 +
 Build duration:
9 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3dfa0c1c2f87: KFilePlacesModel: On new profile in recent 
show only recentlyused:/ based… (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=74123=74124

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D26782_1

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

meven updated this revision to Diff 74123.
meven added a comment.


  Fix comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=74072=74123

BRANCH
  arcpatch-D26782_1

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kfileplacesmodel.cpp:358
> +
> +// don't add by default "Modifield Today" and "Modifield Yesterday" 
> when recentlyused:/ is present
> +if (root.metaDataItem(QStringLiteral("withRecentlyUsed")) != 
> QLatin1String("true")) {

`s/Modifield/Modified/`

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26832: Add icon for application/sql

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26832

To: broulik, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26839: demote plugin load errors from warning to debug level + reword

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to me.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26839

To: sitter, mpyne, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: Refactor KConfigXT

[Tomaz Canabrava]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:95aee1294e32: Refactor KConfigXT (authored by tcanabrava).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=74118=74121

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_emptyentries.cpp.ref
  autotests/kconfig_compiler/test_emptyentries.h.ref
  autotests/kconfig_compiler/test_emptyentries.kcfg
  autotests/kconfig_compiler/test_emptyentries.kcfgc
  autotests/kconfig_compiler/test_emptyentries_main.cpp
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfigtest.h
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigParameters.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: davidre, bcooksley, cgiboudeaux, kossebau, bport, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26794

To: leinir
Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74119.
leinir added a comment.


  - Add a voting method to the Ratings component (separate to editable)
  - Use the votable prop to add voting UI to entry details
  - Hook up to the functions which do the actual vote/comment work

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26794?vs=74113=74119

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26794

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/provider.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/ui/entrydetailsdialog.cpp
  src/ui/itemsviewdelegate.cpp

To: leinir
Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 74118.
tcanabrava marked an inline comment as done.
tcanabrava retitled this revision from "Refactor KConfigXT " to "Refactor 
KConfigXT".
tcanabrava added a comment.


  - Rebase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26202?vs=73846=74118

BRANCH
  rework_kconfig_compiler

REVISION DETAIL
  https://phabricator.kde.org/D26202

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test1.h.ref
  autotests/kconfig_compiler/test10.h.ref
  autotests/kconfig_compiler/test11.h.ref
  autotests/kconfig_compiler/test11a.h.ref
  autotests/kconfig_compiler/test12.h.ref
  autotests/kconfig_compiler/test13.h.ref
  autotests/kconfig_compiler/test9.h.ref
  autotests/kconfig_compiler/test_dpointer.cpp.ref
  autotests/kconfig_compiler/test_emptyentries.cpp.ref
  autotests/kconfig_compiler/test_emptyentries.h.ref
  autotests/kconfig_compiler/test_emptyentries.kcfg
  autotests/kconfig_compiler/test_emptyentries.kcfgc
  autotests/kconfig_compiler/test_emptyentries_main.cpp
  autotests/kconfig_compiler/test_translation_kde.h.ref
  autotests/kconfig_compiler/test_translation_kde_domain.h.ref
  autotests/kconfig_compiler/test_translation_qt.h.ref
  autotests/kconfigtest.h
  src/kconfig_compiler/CMakeLists.txt
  src/kconfig_compiler/KConfigCodeGeneratorBase.cpp
  src/kconfig_compiler/KConfigCodeGeneratorBase.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigHeaderGenerator.cpp
  src/kconfig_compiler/KConfigHeaderGenerator.h
  src/kconfig_compiler/KConfigParameters.cpp
  src/kconfig_compiler/KConfigParameters.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigSourceGenerator.h
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/KConfigXmlParser.h
  src/kconfig_compiler/kconfig_compiler.cpp

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: davidre, bcooksley, cgiboudeaux, kossebau, bport, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26768: Revert "Revert "WIP: Refactor KConfigXT""

[Tomaz Canabrava]

tcanabrava abandoned this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26768

To: tcanabrava
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D26794

To: leinir
Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26794: [WIP] Implement comment posting (and reenable voting)

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74113.
leinir added a subscriber: mart.
leinir added a comment.


  Progressing steadily, with some layout fixing assistance from Marco.
  Also, ensure you're using kirigami master for the best experience ;)
  
  - Forward the userCanComment information from the items model
  - Clean up the layouting of the comments sheet (thanks for the help, @mart!)
  - Add reply request functionality to the comment delegate

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26794?vs=74016=74113

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26794

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/provider.h
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/Rating.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/ui/entrydetailsdialog.cpp
  src/ui/itemsviewdelegate.cpp

To: leinir
Cc: mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26841: hardware tool: define syntax via syntax arg

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this way the commands syntax is always immediately visible
  in the help text.
  nothing infurates me more than help that doesn't help, and
  previously the help would essentially just end up telling you to
  run --commands to actually get help -.-
  
  the existing syntax argument of addPositionArgument will simply
  print the syntax help undearneath the usage line, thus giving
  immediate access to information on how to use the application
  without first having to go through the --commands argument
  
  (--commands still exists for backwards compat)

TEST PLAN
  -h now useful

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26841

AFFECTED FILES
  src/tools/solid-hardware/solid-hardware.cpp

To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26840: Correctly set underMouse() for inline notes

[David Redondo]

davidre edited the test plan for this revision.
davidre added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26840

To: davidre, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26840: Correctly set underMouse() for inline notes

[David Redondo]

davidre created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Before it was always false for every inline note.

REPOSITORY
  R39 KTextEditor

BRANCH
  underMouse (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26840

AFFECTED FILES
  autotests/src/inlinenote_test.cpp
  src/view/kateview.cpp
  src/view/kateviewinternal.cpp

To: davidre
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26623: KEMailSettings: group names in kconfig files should not be localized

[Laurent Montel]

mlaurent added a comment.


  It's not used in kmail it seems.
  we use this class in kmail-account-wizard only.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26623

To: meven, #frameworks, ervin, dfaure
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26701: Add KFileCustomDialog constructor with a startDir parameter.

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.


  it's ok for me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26701

To: dfaure, broulik, pino, mlaurent
Cc: alexeymin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26839: demote plugin load errors from warning to debug level + reword

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: mpyne.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  while they are errors from our POV the callers POV may be that
  they'll simply try another name. with the previous behavior
  we would always end up printing the message because warnings
  are visible by default and then on top of that the warning
  would use the word error.
  
  this lead to users getting confused about the actual impact:
  https://bugs.kde.org/show_bug.cgi?id=364637
  
  when the caller has additional handling:
  https://phabricator.kde.org/D26791
  
  the latter ought to always be the case as far as error reporting
  goes because the class documentation even suggests as much
  in its example snippet.
  
  as a result of all this it seems way more appropriate to
  consider this a debug message on a kcoreaddons level.
  additionally, the message now talks about failure to load rather
  than error loading so as to make it a bit less important
  sounding.

TEST PLAN
  -

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26839

AFFECTED FILES
  src/lib/plugin/kpluginloader.cpp

To: sitter, mpyne
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

[Vlad Zahorodnii]

zzag updated this revision to Diff 74098.
zzag added a comment.


  Specify the parent object

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26503?vs=73010=74098

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26503

AFFECTED FILES
  src/plasmaquick/dialogshadows.cpp
  src/plasmaquick/waylandintegration.cpp
  src/plasmaquick/waylandintegration_p.h

To: zzag, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava marked 26 inline comments as done.
tcanabrava added inline comments.

INLINE COMMENTS

> ervin wrote in KConfigCodeGeneratorBase.cpp:80
> This is an odd indentation logic, is it to stay close to the original? (which 
> I'd actually support, just trying to understand where that's coming from).

it's to stay close to the original. originally all the indentation was done 
manually, but first 4 spaces and later 2 spaces. This code is bogus and I would 
like to get rid of it spporting only one indentation style. I'm adding a TODO: 
for that here.

REPOSITORY
  R237 KConfig

BRANCH
  rework_kconfig_compiler

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: davidre, bcooksley, cgiboudeaux, kossebau, bport, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: Refactor KConfigXT

[Kevin Ottens]

ervin added a comment.


  Well a couple of them are a bit more invasive than just dealing with spaces 
but fair enough.
  
  I wouldn't mind an answer to my question though just to feel less stupid: 
https://phabricator.kde.org/D26202#inline-151385

REPOSITORY
  R237 KConfig

BRANCH
  rework_kconfig_compiler

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: davidre, bcooksley, cgiboudeaux, kossebau, bport, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26832: Add icon for application/sql

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This is an alias to `text/x-sql` but we don't resolve those when looking up 
icons.

TEST PLAN
  My *.sql files have icons now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26832

AFFECTED FILES
  icons-dark/mimetypes/16/application-sql.svg
  icons-dark/mimetypes/22/application-sql.svg
  icons-dark/mimetypes/32/application-sql.svg
  icons-dark/mimetypes/64/application-sql.svg
  icons/mimetypes/16/application-sql.svg
  icons/mimetypes/22/application-sql.svg
  icons/mimetypes/32/application-sql.svg
  icons/mimetypes/64/application-sql.svg

To: broulik, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi planned changes to this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi reclaimed this revision.
This revision now requires changes to proceed.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: Refactor KConfigXT

[Tomaz Canabrava]

tcanabrava added a comment.


  @ervin since they are just nitpicks I'll fix in code and land the patch.

REPOSITORY
  R237 KConfig

BRANCH
  rework_kconfig_compiler

REVISION DETAIL
  https://phabricator.kde.org/D26202

To: tcanabrava, #frameworks, ervin, bport, dfaure
Cc: davidre, bcooksley, cgiboudeaux, kossebau, bport, ngraham, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Kevin Ottens]

ervin added a comment.


  Well, even though you didn't have a direct use anymore it doesn't mean this 
patch was useless. I think it'd be worth fixing the last issue I pointed out 
and merging it. I seem to remember someone else requested this feature.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26082: Provide a method to query isImmutable attribute of a setting related to notification.

[Cyril Rossi]

crossi abandoned this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26082

To: crossi, #plasma, #frameworks, ervin, mart, davidedmundson, broulik, meven
Cc: plasma-devel, meven, bport, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26046: Allow ManagedConfigModule derived class to register explicitly KCoreConfigSkeleton.

[Cyril Rossi]

crossi abandoned this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D26046

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26047: Expose KConfig settings to allow registration in KCM Notification

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ee3176ce5641: Expose KConfig settings to allow 
registration in KCM Notification (authored by crossi).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26047?vs=74023=74079

REVISION DETAIL
  https://phabricator.kde.org/D26047

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/kcfg/badgesettings.kcfg
  libnotificationmanager/kcfg/badgesettings.kcfgc
  libnotificationmanager/kcfg/donotdisturbsettings.kcfg
  libnotificationmanager/kcfg/donotdisturbsettings.kcfgc
  libnotificationmanager/kcfg/jobsettings.kcfg
  libnotificationmanager/kcfg/jobsettings.kcfgc
  libnotificationmanager/kcfg/notificationsettings.kcfg
  libnotificationmanager/kcfg/notificationsettings.kcfgc
  libnotificationmanager/settings.cpp

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26047: Expose KConfig settings to allow registration in KCM Notification

[Kevin Ottens]

ervin accepted this revision.
ervin added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in settings.cpp:173
> I still want to be able to specify what `config` (constructor argument) to 
> use for autotests

After discussing with kai, let's mark the ctor taking the config parameter as 
deprecated instead. Should be done in another patch, this one can go as is.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26047

To: crossi, #plasma, #frameworks, ervin, bport, davidedmundson, mart
Cc: broulik, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25698: New query mechanism for applications: KApplicationTrader

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dfaure wrote in kapplicationtrader.cpp:87
> Order is very important here, it's the order of preference.
> 
> But doesn't erase(remove_if()) preserve order? I thought it did.

cppreference says it does:

> Relative order of the elements that remain is preserved and the physical size 
> of the container is unchanged

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25698: New query mechanism for applications: KApplicationTrader

[David Faure]

dfaure updated this revision to Diff 74073.
dfaure added a comment.


  Improve docu

REPOSITORY
  R309 KService

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25698?vs=73890=74073

BRANCH
  kapplicationtrader

REVISION DETAIL
  https://phabricator.kde.org/D25698

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kapplicationtradertest.cpp
  autotests/kservicetest.cpp
  src/CMakeLists.txt
  src/services/kapplicationtrader.cpp
  src/services/kapplicationtrader.h
  src/services/kmimetypetrader.cpp
  src/services/kservicefactory.cpp
  src/services/kservicefactory_p.h
  src/services/ktraderparsetree.cpp
  src/services/ktraderparsetree_p.h
  src/sycoca/ksycocaentry.h

To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25698: New query mechanism for applications: KApplicationTrader

[David Faure]

dfaure marked 2 inline comments as done.
dfaure added inline comments.

INLINE COMMENTS

> dhaumann wrote in kapplicationtrader.cpp:87
> I would prefer the std::erase(std::remove_if(...), ...end()); idiom here.
> 
> Assuming the list is a vector this will be much faster, or do you have to 
> preserve the order? I fear I know the answer :-)

Order is very important here, it's the order of preference.

But doesn't erase(remove_if()) preserve order? I thought it did.

> dhaumann wrote in kapplicationtrader.h:80
> method without training e.

LOL, I'm trying but sometimes the French in me takes over :)

> dhaumann wrote in kapplicationtrader.h:90
> Maybe mention when this function is useful? For me it looks like a private 
> helper function. Why is it public?

It's not a private helper, it's one of the things you might want to call from 
your lambda filter function. See the unittest (which is a bit of a "porting 
guide" from the old traders).

Added a line of docu about that.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

meven updated this revision to Diff 74071.
meven added a comment.


  Don't add by default 'Modifield Today' and 'Modifield Yesterday' when 
recentlyused:/ is present

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=73995=74071

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26782: KFilePlacesModel: On new profile in recent show only recentlyused:/ based entries by default

[Méven Car]

meven updated this revision to Diff 74072.
meven added a comment.


  Clean up

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26782?vs=74071=74072

BRANCH
  arcpatch-D26782

REVISION DETAIL
  https://phabricator.kde.org/D26782

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: meven, ngraham, #vdg, #plasma, hein
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns