D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 added inline comments.

INLINE COMMENTS

> broulik wrote in notifybysnore.cpp:200
> Does the notification still end up with an `id` eventually?

yes. I've used the id in the new patch

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26801: Really fix the Windows backend for KNotifications

[Piyush Aggarwal]

brute4s99 abandoned this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26801

To: brute4s99, vonreth, broulik, #kde_connect
Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, 
ankit, aliencode, Orage, ritwizsinha, LeGast00n, ewentzel, dshelley, 
pawelkwiecinski, ctakano, vporvaznik, mschroeder, varunp, shivanshukantprasad, 
skymoore, fbampaloukas, GB_2, brute4s99, wistak, anoopv, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, Danial0_0, johnq, Pitel, domson, adeen-s, 
michaelh, SemperPeritus, daniel.z.tg, jeanv, seebauer, ngraham, bruns, bugzy, 
MayeulC, lemuel, menasshock, mikesomov, tctara, apol

D26888: work around to fully support the windows backend

[Piyush Aggarwal]

brute4s99 reclaimed this revision.
brute4s99 added a comment.


  sorry. abandoned wrong diff

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26888

To: brute4s99, vonreth, broulik, #kde_connect
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent updated this revision to Diff 74406.
mlaurent added a comment.


  Use QStringRef::compare

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26890?vs=74349=74406

BRANCH
  port_QXmlStreamReader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26890

AFFECTED FILES
  src/gui/kconfigloader.cpp
  src/gui/kconfigloaderhandler_p.h

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Laurent Montel]

mlaurent marked 4 inline comments as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Introducing SPDX License Headers

[Vlad Zahorodnii]

Hi,

On 1/26/20 7:59 PM, Andreas Cord-Landwehr wrote:

Does this approach sound reasonable? If anybody wants to review my conversion
tool and the license-header-to-SPDX-translations, I am happy for feedback!


+1

It appears like the SPDX markers are not used in the source code of your 
licensedigger tool ;-). It would be great to have an option or something 
that could be used to replace all instances of "Copyright (C)" with 
"SPDX-FileCopyrightText:" for consistency sake.


Cheers,
vlad

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 104 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/104/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 27 Jan 2020 00:21:13 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5629/8097)47%
(2444/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1505/1590)48%
(651/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/78/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 27 Jan 2020 00:21:01 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5630/8097)47%
(2443/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1505/1590)48%
(649/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1854/3056)41%
(737/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 27 Jan 2020 00:21:09 +
 Build duration:
8 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 77 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/77/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 26 Jan 2020 23:58:17 +
 Build duration:
3 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5629/8097)47%
(2444/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1505/1590)48%
(651/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 103 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/103/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 26 Jan 2020 23:58:17 +
 Build duration:
2 min 59 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5629/8097)47%
(2442/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1505/1590)48%
(649/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 26 Jan 2020 23:58:17 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21381: use org.freedesktop.appstream-glib package to validate appstream data

[Matthieu Gallien]

mgallien abandoned this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D21381

To: mgallien, aacid, yurchor, apol
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  LGTM

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26650: Use KService to look for Filelight

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> sitter wrote in kpropertiesdialog.cpp:1114
> I'm pretty sure that isn't true.
> 
> KFilePropsPlugin are the tabs inside the properties dialog. They get 
> instantiated for each dialog and destroyed when the dialog is destroyed. They 
> are not persistent throughout the life time of the process. 
> The lamda in this case is scoped to the internal QFunctorSlotObject or 
> whatever it's called and that is held by the QObject. When the dialog gets 
> destroyed, it destroys the KFilePropsPlugin instance and that disconnects the 
> signal triggering the QFunctorSlotObject to get deleted, which in turn causes 
> the lambda to lose scope and clean up, destroying its pointer copies.
> TLDR: the lambda and all its copies do not outlive the property dialog it 
> belongs to.

@shubham reimplement slotSizeDetails with 
`KService::serviceByDesktopName(QStringLiteral("org.kde.filelight"));` + 
`Krun::runApplication`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26650

To: shubham, broulik, ngraham
Cc: sitter, meven, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D26931: Introduce SPDX license headers

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Introducing SPDX License Headers

[Andreas Cord-Landwehr]

Hi, as discussed during last Akademy's KF6 BoF and the KF6 sprint, as well as 
on the KDE community list, SPDX license information can help us a lot in 
maintaining a (automatically checkable) good license quality throughout our 
libraries. Since today, SPDX markers are also known in the KDE licensing 
policy and I want to start porting the existing license headers to the new 
language.

For anybody without SPDX marker experience, there are now the following good 
starting pages:
- KDE Licensing Policy: https://community.kde.org/Policies/Licensing_Policy
- (a very new) Licensing HowTo: https://community.kde.org/
Guidelines_and_HOWTOs/Licensing
- REUSE.software: http://reuse.software

The question now is, how to introduce the SPDX markers in a reasonable way. 
Since some time, I worked on a conversion tooling, which works quite well 
right now (it converts about 98% of the headers and leaves the remaining ones 
for manual work) [1]. The approach I followed was:

1. For every license header in KF5 (about 130 versions of statements), I 
created a plain text file that contains that license statement.
2. All license header files with the same meaning (e.g. all LGPL-2.0-or-later 
headers) are combined in a regular expression that also matches all possible 
whitespaces, linebreaks and "*" characters.
3. For every individual license header there is a reference original source 
code file included, which is used inside a unit test to verify that the license 
is correctly detected.
4. My tool has a "--convert" option that replaces all matched regular 
expressions (only if they could be detected unambiguously!) to the 
corresponding SPDX expression and adds the respective license files to the root 
folder of the project.

In the KF5 repositories there are slightly more than 9000 files with copyright 
information that I want to convert. I plan to provide a patch for every single 
(non porting-aid) KF5 repository, starting with the Tier 1 repositories. Each 
patch will contain the changes created by my licensedigger tool, possibly a 
few style changes (meaning whitespace removal or removal of "*" characters).
Any license that I had to state by hand will be in a different commit and 
explicitly stated in the pull request.

Does this approach sound reasonable? If anybody wants to review my conversion 
tool and the license-header-to-SPDX-translations, I am happy for feedback!

As a first test-balloon, I created a patch for KIdletime [2], mostly because it 
is one of the repositories that nearly never sees a change and allows to keep 
a pull request open for a longer time, if discussions are needed.

Cheers,
Andreas

[1] https://cgit.kde.org/scratch/cordlandwehr/licensedigger.git/
[2] https://phabricator.kde.org/D26931

D26931: Introduce SPDX license headers

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REPOSITORY
  R274 KIdleTime

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26931

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/MIT.txt
  examples/KIdleTest.cpp
  examples/KIdleTest.h
  examples/main.cpp
  src/abstractsystempoller.cpp
  src/abstractsystempoller.h
  src/kidletime.cpp
  src/kidletime.h
  src/plugins/osx/macpoller.cpp
  src/plugins/osx/macpoller.h
  src/plugins/windows/windowspoller.cpp
  src/plugins/windows/windowspoller.h
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp
  src/plugins/xscreensaver/xscreensaverbasedpoller.h
  src/plugins/xsync/fixx11h.h
  src/plugins/xsync/xsyncbasedpoller.cpp
  src/plugins/xsync/xsyncbasedpoller.h
  src/widgetbasedpoller.cpp
  src/widgetbasedpoller.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 73 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/73/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 26 Jan 2020 17:22:06 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 235 lines...][2020-01-26T17:22:56.427Z]   For compatibility, CMake is excluding the GENERATED source file(s):[2020-01-26T17:22:56.427Z] [2020-01-26T17:22:56.427Z] "/usr/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 FreeBSDQt5.13/build/src/yacc.c"[2020-01-26T17:22:56.427Z] "/usr/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 FreeBSDQt5.13/build/src/lex.c"[2020-01-26T17:22:56.427Z] [2020-01-26T17:22:56.427Z]   from processing by AUTOMOC.  If any of the files should be processed, set[2020-01-26T17:22:56.427Z]   CMP0071 to NEW.  If any of the files should not be processed, explicitly[2020-01-26T17:22:56.427Z]   exclude them by setting the source file property SKIP_AUTOMOC:[2020-01-26T17:22:56.427Z] [2020-01-26T17:22:56.427Z] set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)[2020-01-26T17:22:56.427Z] [2020-01-26T17:22:56.427Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-01-26T17:22:56.427Z] [2020-01-26T17:22:56.697Z] -- Generating done[2020-01-26T17:22:56.697Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-26T17:22:57.392Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kservice --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-01-26T17:22:57.677Z] Scanning dependencies of target docs-desktoptojson-desktoptojson-8[2020-01-26T17:22:57.677Z] Scanning dependencies of target copy_menu[2020-01-26T17:22:57.677Z] Scanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8[2020-01-26T17:22:57.677Z] [  0%] Generating desktoptojson.8[2020-01-26T17:22:57.677Z] [  1%] Generating kbuildsycoca5.8[2020-01-26T17:22:57.677Z] Scanning dependencies of target copy_servicetypes[2020-01-26T17:22:57.677Z] [  1%] Built target copy_menu[2020-01-26T17:22:57.677Z] Scanning dependencies of target Qt5Xml_QCH[2020-01-26T17:22:57.677Z] Scanning dependencies of target KF5Config_QCH[2020-01-26T17:22:57.677Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-01-26T17:22:57.947Z] [  1%] Built target KF5CoreAddons_QCH[2020-01-26T17:22:57.947Z] Scanning dependencies of target Qt5Core_QCH[2020-01-26T17:22:57.947Z] [  1%] Built target KF5Config_QCH[2020-01-26T17:22:57.947Z] [  1%] Built target Qt5Xml_QCH[2020-01-26T17:22:57.947Z] [  1%] Built target copy_servicetypes[2020-01-26T17:22:57.947Z] [  1%] Built target Qt5Core_QCH[2020-01-26T17:22:57.947Z] Scanning dependencies of target KF5Service_autogen[2020-01-26T17:22:57.947Z] Scanning dependencies of target Qt5Gui_QCH[2020-01-26T17:22:57.947Z] [  2%] Automatic MOC for target KF5Service[2020-01-26T17:22:57.947Z] [  2%] Built target Qt5Gui_QCH[2020-01-26T17:22:57.947Z] Scanning dependencies of target KF5Service_QCH[2020-01-26T17:22:57.947Z] [  3%] Generating src/KF5Service.qch, src/KF5Service.tags[2020-01-26T17:22:58.551Z] Note: Writing kbuildsycoca5.8[2020-01-26T17:22:58.551Z] Note: Writing desktoptojson.8[2020-01-26T17:22:58.551Z] [  3%] Built target docs-kbuildsycoca5-kbuildsycoca5-8[2020-01-26T17:22:58.551Z] [  3%] Built target docs-desktoptojson-desktoptojson-8[2020-01-26T17:22:59.135Z] [  3%] Built target KF5Service_autogen[2020-01-26T17:22:59.135Z] [  4%] Generating klauncher_iface.cpp, klauncher_iface.h[2020-01-26T17:22:59.135Z] [  4%] [BISON][TraderParser] Building parser with bison 3.4.2[2020-01-26T17:22:59.135Z] services/yacc.y:83.1-12: warning: deprecated directive, use ���%define api.pure��� [-Wdeprecated][2020-01-26T17:22:59.135Z]83 | %pure-parser[2020-01-26T17:22:59.135Z]   | ^~~~[2020-01-26T17:22:59.135Z] [  5%] [FLEX][TraderLexer] Building scanner with flex 2.5.37[2020-01-26T17:22:59.135Z] [  6%] Generating klauncher_iface.moc[2020-01-26T17:22:59.397Z] services/yacc.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother][2020-01-26T17:22:59.657Z] Scanning dependencies of target KF5Service[2020-01-26T17:22:59.657Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/KF5Service_autogen/mocs_compilation.cpp.o[2020-01-26T17:22:59.657Z] [  7%] Building CXX object src/CMakeFiles/KF5Service.dir/kdeinit/ktoolinvocation.cpp.o[2020-01-26T17:22:59.932Z] [  8%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kautostart.cpp.o[2020-01-26T17:22:59.932Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kmimetypefactory.cpp.o[2020-01-26T17:22:59.932Z] [  9%] Building CXX object src/CMakeFiles/KF5Service.dir/services/kserviceoffer.cpp.o[2020-01-26T17:22:59.932Z] [ 10%] Building CXX object 

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 102 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/102/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 26 Jan 2020 17:22:06 +
 Build duration:
54 sec and counting
   CONSOLE OUTPUT
  [...truncated 290 lines...][2020-01-26T17:22:55.221Z] -- Configuring done[2020-01-26T17:22:55.221Z] CMake Warning (dev) in src/CMakeLists.txt:[2020-01-26T17:22:55.221Z]   Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.[2020-01-26T17:22:55.221Z]   Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy[2020-01-26T17:22:55.221Z]   command to set the policy and suppress this warning.[2020-01-26T17:22:55.221Z] [2020-01-26T17:22:55.221Z]   For compatibility, CMake is excluding the GENERATED source file(s):[2020-01-26T17:22:55.221Z] [2020-01-26T17:22:55.221Z] "/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.12/build/src/yacc.c"[2020-01-26T17:22:55.221Z] "/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.12/build/src/lex.c"[2020-01-26T17:22:55.221Z] [2020-01-26T17:22:55.221Z]   from processing by AUTOMOC.  If any of the files should be processed, set[2020-01-26T17:22:55.221Z]   CMP0071 to NEW.  If any of the files should not be processed, explicitly[2020-01-26T17:22:55.221Z]   exclude them by setting the source file property SKIP_AUTOMOC:[2020-01-26T17:22:55.221Z] [2020-01-26T17:22:55.221Z] set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)[2020-01-26T17:22:55.221Z] [2020-01-26T17:22:55.221Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-01-26T17:22:55.221Z] [2020-01-26T17:22:55.221Z] -- Generating done[2020-01-26T17:22:55.221Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-26T17:22:55.990Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kservice --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-01-26T17:22:55.990Z] Scanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8[2020-01-26T17:22:55.990Z] Scanning dependencies of target docs-desktoptojson-desktoptojson-8[2020-01-26T17:22:55.990Z] Scanning dependencies of target copy_menu[2020-01-26T17:22:55.990Z] [  1%] Generating kbuildsycoca5.8[2020-01-26T17:22:55.990Z] [  1%] Generating desktoptojson.8[2020-01-26T17:22:55.990Z] Scanning dependencies of target copy_servicetypes[2020-01-26T17:22:55.990Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-01-26T17:22:55.990Z] Scanning dependencies of target KF5Config_QCH[2020-01-26T17:22:56.287Z] [  1%] Built target copy_menu[2020-01-26T17:22:56.287Z] [  1%] Built target copy_servicetypes[2020-01-26T17:22:56.287Z] [  1%] Built target KF5CoreAddons_QCH[2020-01-26T17:22:56.287Z] [  1%] Built target KF5Config_QCH[2020-01-26T17:22:56.287Z] Scanning dependencies of target KF5Service_QCH[2020-01-26T17:22:56.287Z] [  2%] Generating src/KF5Service.qch, src/KF5Service.tags[2020-01-26T17:22:56.287Z] Scanning dependencies of target KF5Service_autogen[2020-01-26T17:22:56.287Z] [  3%] Automatic MOC for target KF5Service[2020-01-26T17:22:56.562Z] [  3%] Built target KF5Service_autogen[2020-01-26T17:22:56.562Z] [  4%] Generating klauncher_iface.cpp, klauncher_iface.h[2020-01-26T17:22:56.562Z] [  4%] [BISON][TraderParser] Building parser with bison 3.5[2020-01-26T17:22:56.562Z] services/yacc.y:83.1-12: warning: deprecated directive: ���%pure-parser���, use ���%define api.pure��� [-Wdeprecated][2020-01-26T17:22:56.562Z]83 | %pure-parser[2020-01-26T17:22:56.562Z]   | ^~~~[2020-01-26T17:22:56.562Z]   | %define api.pure[2020-01-26T17:22:56.562Z] [  5%] [FLEX][TraderLexer] Building scanner with flex 2.6.4[2020-01-26T17:22:56.562Z] Note: Writing kbuildsycoca5.8[2020-01-26T17:22:56.562Z] [  6%] Generating klauncher_iface.moc[2020-01-26T17:22:56.562Z] services/yacc.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother][2020-01-26T17:22:56.562Z] Note: Writing desktoptojson.8[2020-01-26T17:22:56.835Z] [  6%] Built target docs-kbuildsycoca5-kbuildsycoca5-8[2020-01-26T17:22:56.835Z] Building up file structure...[2020-01-26T17:22:56.835Z] Insert custom filters...[2020-01-26T17:22:56.835Z] Insert help data for filter section (1 of 1)...[2020-01-26T17:22:56.835Z] Insert files...[2020-01-26T17:22:56.835Z] Insert contents...[2020-01-26T17:22:56.835Z] Insert indices...[2020-01-26T17:22:56.835Z] Documentation successfully generated.[2020-01-26T17:22:56.835Z] [  6%] Built target docs-desktoptojson-desktoptojson-8[2020-01-26T17:22:56.835Z] Scanning dependencies of target KF5Service[2020-01-26T17:22:56.835Z] [  6%] Built target KF5Service_QCH[2020-01-26T17:22:56.835Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/KF5Service_autogen/mocs_compilation.cpp.o[2020-01-26T17:22:56.835Z] [ 

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 76 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/76/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 26 Jan 2020 17:22:06 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 286 lines...][2020-01-26T17:22:54.533Z]  * Qt5Concurrent[2020-01-26T17:22:54.533Z]  * Qt5Test[2020-01-26T17:22:54.533Z]  * Qt5 (required version >= 5.12.0)[2020-01-26T17:22:54.533Z] [2020-01-26T17:22:54.533Z] -- Configuring done[2020-01-26T17:22:54.789Z] CMake Warning (dev) in src/CMakeLists.txt:[2020-01-26T17:22:54.789Z]   Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.[2020-01-26T17:22:54.789Z]   Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy[2020-01-26T17:22:54.789Z]   command to set the policy and suppress this warning.[2020-01-26T17:22:54.789Z] [2020-01-26T17:22:54.789Z]   For compatibility, CMake is excluding the GENERATED source file(s):[2020-01-26T17:22:54.789Z] [2020-01-26T17:22:54.789Z] "/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.13/build/src/yacc.c"[2020-01-26T17:22:54.789Z] "/home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.13/build/src/lex.c"[2020-01-26T17:22:54.789Z] [2020-01-26T17:22:54.789Z]   from processing by AUTOMOC.  If any of the files should be processed, set[2020-01-26T17:22:54.789Z]   CMP0071 to NEW.  If any of the files should not be processed, explicitly[2020-01-26T17:22:54.789Z]   exclude them by setting the source file property SKIP_AUTOMOC:[2020-01-26T17:22:54.789Z] [2020-01-26T17:22:54.789Z] set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)[2020-01-26T17:22:54.789Z] [2020-01-26T17:22:54.789Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2020-01-26T17:22:54.789Z] [2020-01-26T17:22:54.789Z] -- Generating done[2020-01-26T17:22:54.789Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kservice/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-26T17:22:55.397Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kservice --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-01-26T17:22:55.398Z] Scanning dependencies of target copy_menu[2020-01-26T17:22:55.398Z] Scanning dependencies of target copy_servicetypes[2020-01-26T17:22:55.398Z] Scanning dependencies of target docs-kbuildsycoca5-kbuildsycoca5-8[2020-01-26T17:22:55.398Z] Scanning dependencies of target KF5Config_QCH[2020-01-26T17:22:55.398Z] Scanning dependencies of target KF5CoreAddons_QCH[2020-01-26T17:22:55.398Z] Scanning dependencies of target docs-desktoptojson-desktoptojson-8[2020-01-26T17:22:55.398Z] [  0%] Generating desktoptojson.8[2020-01-26T17:22:55.398Z] [  0%] Built target KF5Config_QCH[2020-01-26T17:22:55.398Z] [  0%] Built target KF5CoreAddons_QCH[2020-01-26T17:22:55.398Z] [  1%] Generating kbuildsycoca5.8[2020-01-26T17:22:55.398Z] [  1%] Built target copy_menu[2020-01-26T17:22:55.398Z] [  1%] Built target copy_servicetypes[2020-01-26T17:22:55.398Z] Scanning dependencies of target KF5Service_QCH[2020-01-26T17:22:55.398Z] Scanning dependencies of target KF5Service_autogen[2020-01-26T17:22:55.398Z] [  2%] Generating src/KF5Service.qch, src/KF5Service.tags[2020-01-26T17:22:55.398Z] [  3%] Automatic MOC for target KF5Service[2020-01-26T17:22:55.662Z] [  3%] Built target KF5Service_autogen[2020-01-26T17:22:55.662Z] [  3%] [BISON][TraderParser] Building parser with bison 3.5[2020-01-26T17:22:55.662Z] [  4%] Generating klauncher_iface.cpp, klauncher_iface.h[2020-01-26T17:22:55.662Z] [  5%] [FLEX][TraderLexer] Building scanner with flex 2.6.4[2020-01-26T17:22:55.663Z] services/yacc.y:83.1-12: warning: deprecated directive: ���%pure-parser���, use ���%define api.pure��� [-Wdeprecated][2020-01-26T17:22:55.663Z]83 | %pure-parser[2020-01-26T17:22:55.663Z]   | ^~~~[2020-01-26T17:22:55.663Z]   | %define api.pure[2020-01-26T17:22:55.663Z] [  6%] Generating klauncher_iface.moc[2020-01-26T17:22:55.663Z] services/yacc.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother][2020-01-26T17:22:55.663Z] Building up file structure...[2020-01-26T17:22:55.663Z] Insert custom filters...[2020-01-26T17:22:55.663Z] Insert help data for filter section (1 of 1)...[2020-01-26T17:22:55.663Z] Insert files...[2020-01-26T17:22:55.663Z] Insert contents...[2020-01-26T17:22:55.663Z] Insert indices...[2020-01-26T17:22:55.663Z] Documentation successfully generated.[2020-01-26T17:22:55.663Z] Scanning dependencies of target KF5Service[2020-01-26T17:22:55.663Z] [  6%] Built target KF5Service_QCH[2020-01-26T17:22:55.663Z] [  6%] Building CXX object src/CMakeFiles/KF5Service.dir/KF5Service_autogen/mocs_compilation.cpp.o[2020-01-26T17:22:55.663Z] [  7%] Building CXX object 

D26900: Support multiple values in XDG_CURRENT_DESKTOP

[David Faure]

dfaure closed this revision.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D26900

To: dfaure, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26900: Support multiple values in XDG_CURRENT_DESKTOP

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> apol wrote in kservice.cpp:658
> This adds a "KDE" allocation on every which isn't ideal either. I don't know, 
> maybe it doesn't matter either way...

Well, it's a QStringLiteral, AFAIK the QString just points to pre-allocated 
UTF-16 data. Not sure if it's zero-allocation but it's pretty cheap.

REPOSITORY
  R309 KService

BRANCH
  xdg_current_deskto

REVISION DETAIL
  https://phabricator.kde.org/D26900

To: dfaure, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26346: Sonnet: Fix returning from GuessLanguagePrivate::guessFromTrigrams

[Waqar Ahmed]

waqar added inline comments.

INLINE COMMENTS

> guesslanguage.cpp:745
>  
> -while (it.hasNext() && counter < m_maxItems && confidence < 
> m_minConfidence) {
> +while (it.hasNext() && counter < m_maxItems && (m_minConfidence == 0.0 
> || confidence < m_minConfidence)) {
>  it.next();

I wasn't able to see its usefulness directly, I had to change  
`MIN_RELIABILITY` to `0.0` (in LanguageFilter) to see its effects.

But how about just doing `confidence <= m_minConfidence`?

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26346

To: mludwig, #frameworks
Cc: waqar, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D15645: Add scheme selection menu with a "System" entry.

[Amish Naidu]

amhndu abandoned this revision.
amhndu added a comment.


  Superseded by D25877 

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D15645

To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino
Cc: pino, ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D26920: Change VLC icon to be more like official VLC icons

[Nathaniel Graham]

ngraham added a comment.


  Retroactive +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26920

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26855: Add icon for KTrip

[Nicolas Fella]

nicolasfella abandoned this revision.
nicolasfella added a subscriber: jriddell.
nicolasfella added a comment.


  @jriddell added the icon already

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26855

To: nicolasfella, #breeze, ndavis
Cc: jriddell, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kconfigloader.cpp:77
> +case QXmlStreamReader::Characters:
> +if (!reader.isWhitespace() && 
> !reader.text().toString().trimmed().isEmpty()) {
> +if (!characters(reader.text()))

No need to construct a QString if it's just to check if it's empty.

> kconfigloader.cpp:106
> +QString name = attrs.at(i).name().toString().toLower();
>  if (name == QLatin1String("name")) {
>  //qDebug() << "set group to" << attrs.value(i);

This comparison doesn't need to be onto a converted QString. You can compare 
against the QStringRef and use QStringRef::compare to make it case insensitive.

> kconfigloader.cpp:140
> +const QString name = attrs.at(i).name().toString().toLower();
>  if (name == QLatin1String("name")) {
> +m_choice.name = attrs.at(i).value().toString();

Use QStringRef::compare()

> kconfigloader.cpp:194
> +const QString tag = localName.toString().toLower();
>  if (tag == QLatin1String("entry")) {
>  addItem();

I'd also use QStringRef::compare here

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26890

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 174 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/174/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 26 Jan 2020 13:05:05 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D26900: Support multiple values in XDG_CURRENT_DESKTOP

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  The patch looks good to me.

INLINE COMMENTS

> apol wrote in kservice.cpp:658
> You can use QVector here, it would save us constructing a bunch 
> of strings for no reason. Maybe not in the general case of everyone having 
> just the one desktop though.

This adds a "KDE" allocation on every which isn't ideal either. I don't know, 
maybe it doesn't matter either way...

REPOSITORY
  R309 KService

BRANCH
  xdg_current_deskto

REVISION DETAIL
  https://phabricator.kde.org/D26900

To: dfaure, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/55/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 26 Jan 2020 12:54:34 +
 Build duration:
4 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 89 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/89/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 26 Jan 2020 12:54:35 +
 Build duration:
4 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

[patrick j pereira]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:e8abb9601c7d: ECMAddAppIcon: Add sc in regex to extract 
extension from valid names (authored by patrickelectric).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26751?vs=73927=74388

REVISION DETAIL
  https://phabricator.kde.org/D26751

AFFECTED FILES
  modules/ECMAddAppIcon.cmake

To: patrickelectric, tcanabrava, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D23457: Port the search interface from QRegExp to QRegularExpression

[Ahmad Samir]

ahmadsamir updated this revision to Diff 74387.
ahmadsamir added a comment.


  - Rebase
  - Match the old code and check if the pattern is empty, this lets the 
vimode_emulatedcommandbar unit test pass

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23457?vs=71618=74387

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23457

AFFECTED FILES
  autotests/src/regexpsearch_test.cpp
  autotests/src/searchbar_test.cpp
  src/CMakeLists.txt
  src/document/katedocument.cpp
  src/search/kateplaintextsearch.cpp
  src/search/kateregexp.cpp
  src/search/kateregexp.h
  src/search/kateregexpsearch.cpp
  src/search/kateregexpsearch.h
  src/search/katesearchbar.cpp
  src/search/katesearchbar.h
  src/utils/katesedcmd.cpp
  src/utils/katesedcmd.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/75/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sun, 26 Jan 2020 10:26:41 +
 Build duration:
6 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5629/8095)47%
(2446/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1507/1590)49%
(653/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1851/3054)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/101/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 26 Jan 2020 10:26:41 +
 Build duration:
6 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5627/8095)47%
(2444/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1505/1590)48%
(649/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1851/3054)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1007/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/72/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 26 Jan 2020 10:26:41 +
 Build duration:
2 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)