Re: Get Hot New Stuff - Legacy Endpoints and Multiple Requests (Discover?)

[Ben Cooksley]

On Fri, Jan 31, 2020 at 1:05 AM Michael Reeves  wrote:
>
> There seems to be some sort of ssl certificate issue with autoconfig.kde.org. 
> On kubuntu this triggers a warning as soon as discover starts that may be a 
> contributing factor.

I've checked and can find no fault with autoconfig.kde.org. Both wget
and kioclient5 raise no objections on my system, and both Chrome and
Firefox are perfectly happy with it as well.

The Qualys SSL Server Test also confirms that we have no setup issues
(aside from including the root certificate in the chain we send, which
is harmless).
The results of that test can be found at
https://www.ssllabs.com/ssltest/analyze.html?d=autoconfig.kde.org

I'm afraid the fault is either with Kubuntu (which I highly doubt) or
your local network (much more probable) in this instance.

Should you believe the fault is on our side I will need information
from the "Details" pane as to why KIO refuses to trust connections to
autoconfig.kde.org on your system.

Cheers,
Ben

>
> On Thu, Jan 30, 2020, 4:20 AM Ben Cooksley  wrote:
>>
>> Hi all,
>>
>> While diagnosing an issue this evening with cdn.kde.org, I noticed
>> that we are still getting an extremely large number of requests for
>> the legacy OCS/GHNS providers.xml endpoint, which is supposed to only
>> exist for compatibility with older applications.
>>
>> Looking on LXR i've found that a substantial number of our
>> applications are still using the old url in their most recent releases
>> (see https://lxr.kde.org/search?_filestring=&_string=%2Focs%2Fproviders.xml)
>>
>> All new code should be using autoconfig.kde.org now, and all old code
>> should be transitioning to using the new url.
>>
>> The legacy url is significantly more resource intensive for our
>> servers to support and our ability to scale this endpoint is
>> substantially more limited when compared with the new endpoint so it
>> is important that this is moved over (to the extent Enterprise/Long
>> term LTS distributions should be encouraged to patch this)
>>
>> Additionally, I believe there to be a multiple request bug somewhere
>> as this endpoint is being hit approximately 3-4 times in the same
>> second for each client we see. Based on the corresponding hit to
>> autoconfig.kde.org/discover/featured-5.9.json which happens at the
>> same time it is likely the application showing this fault the most is
>> Discover.
>>
>> If we could please get the above all fixed up that would be appreciated.
>>
>> Thanks,
>> Ben

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 102 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/102/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 31 Jan 2020 01:49:27 +
 Build duration:
5 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 154 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/154/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 31 Jan 2020 01:49:27 +
 Build duration:
4 min 30 sec and counting
   BUILD ARTIFACTS
  acc/KF5CoreAddons-5.67.0.xmllogs/KF5CoreAddons/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6928/9112)43%
(10797/24836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2898/2990)49%
(6194/12720)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/799)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

WARNING: was bad recommendation (Re: Recommendation: drop ProvidersUrl entry to rely on default value)

[Friedrich W. H. Kossebau]

Hi,

TLDR: removing the ProvidersUrl entry actually breaks things in non-Plasma 
installations, so for now has to be hardcoded, using the non-deprecated

ProvidersUrl=https://autoconfig.kde.org/ocs/providers.xml

See below for investigation results:

Am Freitag, 31. Januar 2020, 00:14:19 CET schrieb Christoph Feck:
> On 01/30/20 13:53, Friedrich W. H. Kossebau wrote:
> > as found out by discussion on irc, a good solution for everyone relying on
> > the default GHNS storage as provided by KDE is to just not hard-code any
> > value for ProvidersUrl, but leave it out and let KNewStuff default to
> > what is built into the KNewStuff library as current value.
> 
> Does it work with all KNewStuff 5.x versions? Otherwise, the required
> KF5 version would need to be bumped where this change was made.

I was to say
"Yes, works with all existing 5.x versions."
as that behaviour was there already in kdelibs4 time.
Which I remember from relying in Okteta on it.
And felt confirmed on reading again
https://techbase.kde.org/Development/Tutorials/Collaboration/HotNewStuff/
Introduction#The_Configuration_File_.28.knsrc.29
which claims:
"
The ProvidersUrl is optional, and if you just want to use what KDE provides as 
default (http://autoconfig.kde.org/ocs/providers.xml, currently 
store.kde.org), leave this out. The advantage of not specifying this field is 
that users can add more providers using the attica kcm (kcmshell5 kcm_attica). 
"
As well as getting a +1 from a KNewStuff developer ;)

Just, looking at the actual code now to confirm this, I found that actually is 
not totally true, only holds if also Plasma is installed. Why?
If ProvidersUrl is not set, KNewStuff will get the default from Attica. Attica 
has some kind of platform-support, which though is hardcoded to search only 
for a plugin called "attica_kde". That very plugin is only coming from Plasma, 
so only installed if Plasma is installed. And only that plugin provides that 
very default with the *.kde.org url.
If that plugin is not present, the code falls back to some built-in 
QtPlatformDependent object, which delivers no default provider at all.

I tested this by removing /usr/lib64/qt5/plugins/attica_kde.so, as result 
Okteta no longer had content listed in the Structures GHNS dialog. Independent 
of running in Gnome or Plasma.

So seems there is some flaw in the design of Attica when it comes to the 
concept of platforms: having a different provider for a non-Plasma platform 
does not make sense to me.
This needs to be rethought, also when it comes to defaults.

Too sleepy to think further now. And this best is sorted out by KNewStuff 
developers :)

Cheers
Friedrich

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:39
> +
> +constexpr int borderSize = 2;
> +

I don't think so:

> internal linkage
> [...]
> variables, variable templates (since C++14), functions, or function templates 
> declared static;
> non-volatile non-template (since C++14) non-inline (since C++17) non-exported 
> (since C++20) const-qualified variables (including constexpr) that aren't 
> declared extern and aren't previously declared to have external linkage;

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

Re: Recommendation: drop ProvidersUrl entry to rely on default value

[Christoph Feck]

On 01/30/20 13:53, Friedrich W. H. Kossebau wrote:

as found out by discussion on irc, a good solution for everyone relying on the
default GHNS storage as provided by KDE is to just not hard-code any value for
ProvidersUrl, but leave it out and let KNewStuff default to what is built into
the KNewStuff library as current value.


Does it work with all KNewStuff 5.x versions? Otherwise, the required
KF5 version would need to be bumped where this change was made.

--
Christoph Feck

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:39
> +
> +constexpr int borderSize = 2;
> +

Does it need to be `static` to avoid an external symbol?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

Re: Get Hot New Stuff - Legacy Endpoints and Multiple Requests (Discover?)

[Michael Reeves]

There seems to be some sort of ssl certificate issue with autoconfig.kde.org.
On kubuntu this triggers a warning as soon as discover starts that may be a
contributing factor.

On Thu, Jan 30, 2020, 4:20 AM Ben Cooksley  wrote:

> Hi all,
>
> While diagnosing an issue this evening with cdn.kde.org, I noticed
> that we are still getting an extremely large number of requests for
> the legacy OCS/GHNS providers.xml endpoint, which is supposed to only
> exist for compatibility with older applications.
>
> Looking on LXR i've found that a substantial number of our
> applications are still using the old url in their most recent releases
> (see
> https://lxr.kde.org/search?_filestring=&_string=%2Focs%2Fproviders.xml)
>
> All new code should be using autoconfig.kde.org now, and all old code
> should be transitioning to using the new url.
>
> The legacy url is significantly more resource intensive for our
> servers to support and our ability to scale this endpoint is
> substantially more limited when compared with the new endpoint so it
> is important that this is moved over (to the extent Enterprise/Long
> term LTS distributions should be encouraged to patch this)
>
> Additionally, I believe there to be a multiple request bug somewhere
> as this endpoint is being hit approximately 3-4 times in the same
> second for each client we see. Based on the corresponding hit to
> autoconfig.kde.org/discover/featured-5.9.json which happens at the
> same time it is likely the application showing this fault the most is
> Discover.
>
> If we could please get the above all fixed up that would be appreciated.
>
> Thanks,
> Ben
>

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Dominik Haumann]

dhaumann added a comment.


  Better :) with corners I mean the 1-3 pixels left due to the rounding 
corners. These pixels were once also drawn as background although they are 
outside of the frame. It may be a minor detail, but imho such details are 
important. But indeed, the screenshots look good.
  
  Next test: open a file in kate. Now either change the file externally or 
delete it. Kate should show an animated KMessageWidget. Does it also correctly 
work with a small kate? I.e. small width of kate window?

INLINE COMMENTS

> kmessagewidget.cpp:317
> +constexpr float alpha = 0.2;
> +const auto parentWidget = qobject_cast(parent());
> +const QColor parentWindowColor = (parentWidget ? parentWidget->palette() 
> : qApp->palette()).color(QPalette::Window);

Can't you use parentWidget()?
See: https://doc.qt.io/qt-5/qwidget.html#parentWidget

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b5df044e6614: create Breeze style Kate icon based on new 
design by Tyson Tan (authored by cullmann).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27044?vs=74728=74731

REVISION DETAIL
  https://phabricator.kde.org/D27044

AFFECTED FILES
  icons-dark/apps/16/kate.svg
  icons-dark/apps/22/kate.svg
  icons-dark/apps/32/kate.svg
  icons-dark/apps/48/kate.svg
  icons-dark/apps/64/kate.svg
  icons/apps/16/kate.svg
  icons/apps/22/kate.svg
  icons/apps/32/kate.svg
  icons/apps/48/kate.svg
  icons/apps/64/kate.svg

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Shipit! Shipit good! Just shipit!
  
  If the icon comes along, you must shipit
  
  Before pixels set out too long, you must ship it
  
  When something's going ~~wrong~~ right, you must ship it
  
  Now shipit! It's not too late!

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26697: Message-related methods: Use more member-function-pointer-based connect

[Dominik Haumann]

dhaumann added a comment.


  In two days we have the next KDE Frameworks tag. I'd have preferred a commit 
on Sunday ;)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D26697

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann updated this revision to Diff 74728.
cullmann added a comment.


  - use optimized version by ndavis

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27044?vs=74727=74728

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

AFFECTED FILES
  icons-dark/apps/16/kate.svg
  icons-dark/apps/22/kate.svg
  icons-dark/apps/32/kate.svg
  icons-dark/apps/48/kate.svg
  icons-dark/apps/64/kate.svg
  icons/apps/16/kate.svg
  icons/apps/22/kate.svg
  icons/apps/32/kate.svg
  icons/apps/48/kate.svg
  icons/apps/64/kate.svg

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added a comment.


  Thanks!

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM
  
  If you're not sure, use `scour` because it's the least likely to screw 
anything up. As long as the code is formatted well and not filled with useless 
noise, it's fine if it isn't as small as it could be.
  
  I optimized it a bit more with SVG Cleaner, used viewbox only for setting the 
canvas size and deleted a big invisible rectangle. Use this if you want: 
F8033944: kate.svg 

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added a comment.


  In D27044#603597 , @ngraham wrote:
  
  > LGTM now! I'll let @ndavis do the final review. He'll probably ask you to 
run the icon through an SVG optimizer. See 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization.
  >
  > Personally I use `scour`, invoked as indicated on that wiki page.
  
  
  Ok ;=)
  
  Actually, I did already "scour" this file as described on that page. For me 
scour no longer does something on it, if I don't use it wrong.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a comment.


  LGTM now! I'll let @ndavis do the final review. He'll probably ask you to run 
the icon through an SVG optimizer. See 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization.
  
  Personally I use `scour`, invoked as indicated on that wiki page.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann updated this revision to Diff 74727.
cullmann added a comment.


  - delete different sized icons, new icon scales well enough

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27044?vs=74720=74727

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

AFFECTED FILES
  icons-dark/apps/16/kate.svg
  icons-dark/apps/22/kate.svg
  icons-dark/apps/32/kate.svg
  icons-dark/apps/48/kate.svg
  icons-dark/apps/64/kate.svg
  icons/apps/16/kate.svg
  icons/apps/22/kate.svg
  icons/apps/32/kate.svg
  icons/apps/48/kate.svg
  icons/apps/64/kate.svg

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added a comment.


  >> For the other icons, I see, there are even more in other subdirs:
  >> 
  >>  cullmann  …  kde  src  breeze-icons  find . -name "kate.svg" 

   master 
  >>  ./icons/apps/32/kate.svg
  >>  ./icons/apps/64/kate.svg
  >>  ./icons/apps/16/kate.svg
  >>  ./icons/apps/22/kate.svg
  >>  ./icons/apps/48/kate.svg
  >>  ./icons-dark/apps/32/kate.svg
  >>  ./icons-dark/apps/64/kate.svg
  >>  ./icons-dark/apps/16/kate.svg
  >>  ./icons-dark/apps/22/kate.svg
  >>  ./icons-dark/apps/48/kate.svg
  >> 
  >> What to do with them?
  > 
  > Since there are already versions of the old icon in multiple sizes, we have 
two options:
  > 
  > 1. Replace them all with appropriate versions for those sizes, which may be 
easy seeing as @tysontan already made them
  > 2. Remove them all.
  
  The smaller versions Tyson has submitted in the task look all like just PNG 
exports of the SVG.
  (I generated them via ksvgtopng in kate.git, see 
https://invent.kde.org/kde/kate/tree/master/kate/icons )
  
  I think for breeze we can just remove the extra SVGs as the new icons (IMHO) 
scales well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Nathaniel Graham]

ngraham added a comment.


  Thanks, much better now.
  
  In D27044#603538 , @cullmann wrote:
  
  > In D27044#603537 , @cullmann 
wrote:
  >
  > > 2 questions:
  > >
  > > 1. should I use the same icon for dark?
  >
  
  
  Yep.
  
  > For the other icons, I see, there are even more in other subdirs:
  > 
  >  cullmann  …  kde  src  breeze-icons  find . -name "kate.svg"  

      master 
  >  ./icons/apps/32/kate.svg
  >  ./icons/apps/64/kate.svg
  >  ./icons/apps/16/kate.svg
  >  ./icons/apps/22/kate.svg
  >  ./icons/apps/48/kate.svg
  >  ./icons-dark/apps/32/kate.svg
  >  ./icons-dark/apps/64/kate.svg
  >  ./icons-dark/apps/16/kate.svg
  >  ./icons-dark/apps/22/kate.svg
  >  ./icons-dark/apps/48/kate.svg
  > 
  > What to do with them?
  
  Since there are already versions of the old icon in multiple sizes, we have 
two options:
  
  1. Replace them all with appropriate versions for those sizes, which may be 
easy seeing as @tysontan already made them
  2. Remove them all.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27034: Fix message box when passing a remote url that includes a file

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:317a899dc774: Fix message box when passing a remote url 
that includes a file (authored by apol).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27034?vs=74692=74725

REVISION DETAIL
  https://phabricator.kde.org/D27034

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: apol, #frameworks, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26697: Message-related methods: Use more member-function-pointer-based connect

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:6db5cb3ea2ba: Message-related methods: Use more 
member-function-pointer-based connect (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26697?vs=74711=74724

REVISION DETAIL
  https://phabricator.kde.org/D26697

AFFECTED FILES
  src/document/katedocument.cpp
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:da4c983d1f6b: DocumentPrivate::postMessage: avoid multiple 
hash lookups (authored by kossebau).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26696?vs=74712=74723

REVISION DETAIL
  https://phabricator.kde.org/D26696

AFFECTED FILES
  src/document/katedocument.cpp

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D26697: Message-related methods: Use more member-function-pointer-based connect

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Looks ok, too, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  moremodernconnect

REVISION DETAIL
  https://phabricator.kde.org/D26697

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann updated this revision to Diff 74720.
cullmann added a comment.


  - cut PNG part from kate.svg + update dark icon, too

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27044?vs=74719=74720

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

AFFECTED FILES
  icons-dark/apps/48/kate.svg
  icons/apps/48/kate.svg

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann marked an inline comment as done.
cullmann added a comment.


  PNG part is gone, seems to have no effect.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added a comment.


  In D27044#603537 , @cullmann wrote:
  
  > 2 questions:
  >
  > 1. should I use the same icon for dark?
  > 2. what to do with the PNG part? Can this just be stripped? And how? ;=)
  >
  >   Sorry for the noob questions, but SVG-wise I have no ideas ;=)
  
  
  Ok, I just tried to cut the PNG part, that seems to be ok.
  
  For the other icons, I see, there are even more in other subdirs:
  
   cullmann  …  kde  src  breeze-icons  find . -name "kate.svg"

    master 
  ./icons/apps/32/kate.svg
  ./icons/apps/64/kate.svg
  ./icons/apps/16/kate.svg
  ./icons/apps/22/kate.svg
  ./icons/apps/48/kate.svg
  ./icons-dark/apps/32/kate.svg
  ./icons-dark/apps/64/kate.svg
  ./icons-dark/apps/16/kate.svg
  ./icons-dark/apps/22/kate.svg
  ./icons-dark/apps/48/kate.svg
  
  What to do with them?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added a comment.


  2 questions:
  
  1. should I use the same icon for dark?
  2. what to do with the PNG part? Can this just be stripped? And how? ;=)
  
  Sorry for the noob questions, but SVG-wise I have no ideas ;=)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Nathaniel Graham]

ngraham requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Upsa, missed that, looks OK IMHO ;=)

REPOSITORY
  R39 KTextEditor

BRANCH
  avoidmultiplehashaccess

REVISION DETAIL
  https://phabricator.kde.org/D26696

To: kossebau, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added a comment.


  I tried to follow the guide on 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips and what was 
said in https://phabricator.kde.org/T12594
  
  I used the kate-source-derivatives.svg from that task as input, set the size 
to 48 (4 pixel margin inside) and piped it afterwards through scour (as 
inkscape optimize did fail for me because of some python issues).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann added reviewers: VDG, ndavis, tysontan.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27044

To: cullmann, ngraham, #vdg, ndavis, tysontan
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27044: create Breeze style Kate icon based on new design by Tyson Tan

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  details see https://phabricator.kde.org/T12594

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27044

AFFECTED FILES
  icons/apps/48/kate.svg

To: cullmann, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26903: allow programLogo property to be a QIcon, too

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Then shortly reopen this, otherwise I forget to do this ;=)
  Thanks for the feedback.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26903

To: cullmann, apol
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  Kate with this patch and Oxygen style:
  F8030118: Screenshot_20200130_181731.PNG 

  The misplacement I spotted earlier is specific to QtCurve and also happens 
with the current KMessageWidget.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre updated this revision to Diff 74714.
davidre added a comment.


  Draw opaque and mix the colors manually again.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74697=74714

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26903: allow programLogo property to be a QIcon, too

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D26903#600771 , @cullmann wrote:
  
  > Would something like this be ok?
  >
  > Not sure what to write about sizes, e.g. for the program icon we don't 
mention anything either.
  
  
  The program icon I have and such would assume others as well to be thought to 
have to satisfy the usual icon sizes (as defined for application cons in the 
xdg spec), given it is named "icon" after all.
  
  For the programLogo things are different, logo display sizes are not 
specified somewhere (unless one indirectly assumes them given that the 
application icon is named as default). So possibly best would be to hint that 
any pixmaps passed here (via direct or also via QIcon) should follow the xdg 
icon spec, so have some 48x48 icon (or multiple of).
  
  > The QPixmap case was missing in the docs, too, btw.
  
  Good catch :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D26903

To: cullmann, apol
Cc: kossebau, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[David Redondo]

davidre updated this revision to Diff 74713.
davidre added a comment.


  Fix code style

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27039?vs=74704=74713

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26696: DocumentPrivate::postMessage: avoid multiple hash lookups

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 74712.
kossebau added a comment.


  rebase to latest master
  ping? :)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26696?vs=73659=74712

BRANCH
  avoidmultiplehashaccess

REVISION DETAIL
  https://phabricator.kde.org/D26696

AFFECTED FILES
  src/document/katedocument.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26697: Message-related methods: Use more member-function-pointer-based connect

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 74711.
kossebau added a comment.


  rebase to latest master
  ping? :)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26697?vs=73660=74711

BRANCH
  moremodernconnect

REVISION DETAIL
  https://phabricator.kde.org/D26697

AFFECTED FILES
  src/document/katedocument.cpp
  src/view/katemessagewidget.cpp

To: kossebau, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  In D27035#603460 , @dhaumann wrote:
  
  > Does that also work in Kate for floating messages like when the search 
wraps? What I want to know is whether the corners behind the green frame are 
transparent in this case, or whether the corners are painted solid. If I 
remember correctly, these kind of bugs were the reason to use Qt StyleSheets. 
And it must work with all styles.
  >
  > Please do NOT yet commit, especially since we'd only have two days of 
testing period: Saturday, 1st of February is the next frameworks tag.
  
  
  Sorry forgot the screenshots, but you're right the text shines through now in 
KTextEditor and it doesn't seem to positioned correctly. For the first one I 
could go back to mixing the color manually instead of just drawing it with an 
alpha of 0.2. I will look into the second issue

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  In D27035#603460 , @dhaumann wrote:
  
  > Does that also work in Kate for floating messages like when the search 
wraps? What I want to know is whether the corners behind the green frame are 
transparent in this case, or whether the corners are painted solid. If I 
remember correctly, these kind of bugs were the reason to use Qt StyleSheets. 
And it must work with all styles.
  >
  > Please do NOT yet commit, especially since we'd only have two days of 
testing period: Saturday, 1st of February is the next frameworks tag.
  
  
  Should or shouldn't it be transparent? Also I don't understand which part 
should be transparent and which shouldn't? The border was never transparent and 
the background also not. Screenshots:
  
  In D27035#603462 , @dhaumann wrote:
  
  > Can you provide screenshots of more styles? :-)
  
  
  Of course: 
  Adwaita F8029130: Screenshot_20200130_174346.PNG 

  Adwaita Dark F8029135: Screenshot_20200130_174408.PNG 

  Fusion F8029141: Screenshot_20200130_174436.PNG 

  MS Windows 9x{F8029146 }
  Oxygen F8029149: Screenshot_20200130_174522.PNG 

  QtCurve{F8029154 }

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Dominik Haumann]

dhaumann added a comment.


  Can you provide screenshots of more styles? :-)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Dominik Haumann]

dhaumann added a comment.


  Does that also work in Kate for floating messages like when the search wraps? 
What I want to know is whether the corners behind the green frame are 
transparent in this case, or whether the corners are painted solid. If I 
remember correctly, these kind of bugs were the reason to use Qt StyleSheets. 
And it must work with all styles.
  
  Please do NOT yet commit, especially since we'd only have two days of testing 
period: Saturday, 1st of February is the next frameworks tag.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a dependent revision: D27038: [KMessageWidget] Allow the style to 
change our palette.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

davidre added a dependency: D27035: [KMessageWidget] Draw it with QPainter 
instead of using stylesheet.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[David Redondo]

davidre added a dependency: D27038: [KMessageWidget] Allow the style to change 
our palette.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

davidre added a dependent revision: D27039: [KStyle] Set the color of 
KMessageWidgets to the correct one from the current color scheme.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27038

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[David Redondo]

davidre edited the test plan for this revision.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[David Redondo]

davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  KMessageWidget has to rely on hardcoded colors because it's in a Tier 1 
framework.
  However after determining its color it will give the style a chance to set a
  better fitting color by calling polish. So set it's color to the appropriate
  one from the current color scheme.

TEST PLAN
  KmessageWidget follows Color Scheme

REPOSITORY
  R252 Framework Integration

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

AFFECTED FILES
  src/kstyle/kstyle.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

[David Redondo]

davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  After we set our palette give the current QStyle a chance to give us a better
  palette that maybe fits better because we can only use hardcoded colors. To
  avoid infinite recursion when the style calls setPalette on the widget we 
don't
  react to palette change events anymore but when the application palette is
  changed.

TEST PLAN
  N/A

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  polish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27038

AFFECTED FILES
  src/kmessagewidget.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27034: Fix message box when passing a remote url that includes a file

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27034

To: apol, #frameworks, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  In D27035#603375 , @davidre wrote:
  
  > The border radius is slightly different because I copied what Kirigami does 
for the inner rect but I can also go back to radius 4
  
  
  Nevermind that was because of above mistake

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre updated this revision to Diff 74697.
davidre added a comment.


  Tiny mistakes

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74693=74697

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre added a comment.


  The border radius is slightly different because I copied what Kirigami does 
for the inner rect but I can also go back to radius 4

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice. Much simpler and more comprehensible now.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26983: Enable adding place as first child

[Méven Car]

meven added a comment.


Before:
Adding a place as first child will place it at the end.
  
  What is after ? How do I test this exactly ?

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre edited the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre created this revision.
davidre added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  While being a prepatory step to KMessageWidget respecting the current color
  scheme via KStyle this also simplifies this widget by a huge amount. This
  includes removing the nested content Frame and the indirection via a QPixmap
  for the animations.

TEST PLAN
  kmessagewidgettest works as before

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27034: Fix message box when passing a remote url that includes a file

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  The if was negated, I assume it was a typo

TEST PLAN
  I don't get the following screenshot anymore

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27034

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo updated this revision to Diff 74690.
gvgeo added a comment.
This revision is now accepted and ready to land.


  count -1

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26983?vs=74689=74690

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo updated this revision to Diff 74689.
gvgeo added a comment.


  Revert style edit

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26983?vs=74688=74689

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo marked 3 inline comments as done.

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

[George Vogiatzis]

gvgeo retitled this revision from "[WIP]Enable adding place as first child" to 
"Enable adding place as first child".

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: [WIP]Enable adding place as first child

[George Vogiatzis]

gvgeo updated this revision to Diff 74688.
gvgeo added a comment.


  Removed duplicate code, and used count instead.
  
  I was hopping for something better, this has couple more steps to complete.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26983?vs=74549=74688

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/57/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 12:51:48 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74687.
leinir added a comment.


  Thanks to broulik for noticing (or making me notice) this
  
  - Don't change a thing that deals with legacy data

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27028?vs=74676=74687

BRANCH
  fix-dko-overload-by-switching-to-autoconfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27028

AFFECTED FILES
  src/core/cache.cpp
  src/downloaddialog.h
  src/downloadwidget.h
  tests/khotnewstuff.knsrc
  tests/khotnewstuff_upload.knsrc

To: leinir, bcooksley, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> broulik wrote in cache.cpp:160
> We use `https` everywhere these days

Yup, this wants to be left alone... i'll add a little comment to that effect.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27028

To: leinir, bcooksley, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Recommendation: drop ProvidersUrl entry to rely on default value (was: Re: Get Hot New Stuff - Legacy Endpoints)

[Friedrich W. H. Kossebau]

Hi,

as found out by discussion on irc, a good solution for everyone relying on the 
default GHNS storage as provided by KDE is to just not hard-code any value for 
ProvidersUrl, but leave it out and let KNewStuff default to what is built into 
the KNewStuff library as current value.

So:
--- 8< ---
ProvidersUrl=http://{download,autoconfig}.kde.org/ocs/providers.xml
--- 8< ---
->
--- 8< ---
--- 8< ---

Cheers
Friedrich

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> broulik wrote in cache.cpp:160
> We use `https` everywhere these days

Yes, quite, we certainly do. (i'm also wondering if this is really something 
that wants changing or not, as it's... in a bit that loads KNS2 cache files... 
from KDE3)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27028

To: leinir, bcooksley, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> cache.cpp:160
> +if 
> (e.payload().startsWith(QLatin1String("http://download.kde.org/khotnewstuff;))
> + || 
> e.payload().startsWith(QLatin1String("http://autoconfig.kde.org/khotnewstuff;)))
>  {
>  // This is 99% sure a opendesktop file, make it a real one.

We use `https` everywhere these days

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27028

To: leinir, bcooksley, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:8036f148fb66: Add signals for udev events with actions 
bind and unbind (authored by meven).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27025?vs=74684=74685

REVISION DETAIL
  https://phabricator.kde.org/D27025

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Méven Car]

meven updated this revision to Diff 74684.
meven added a comment.


  s/binded/ound

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27025?vs=74683=74684

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27025

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27025

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Kai Uwe Broulik]

broulik added a comment.


  I think it's "bound"

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27025

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Méven Car]

meven updated this revision to Diff 74683.
meven added a comment.


  Add signals for bind/unbind actions

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27025?vs=74671=74683

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27025

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27025

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

[Fabian Vogt]

fvogt marked 3 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27002

To: fvogt, #frameworks
Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27025: Add signals for udev events with actions bind and unbind

[Méven Car]

meven retitled this revision from "Ignore udev monitoring notifications with 
actions bind and unbind" to "Add signals for udev events with actions bind and 
unbind".

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27025

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

[Fabian Vogt]

fvogt edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27002

To: fvogt, #frameworks
Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D26983: [WIP]Enable adding place as first child

[George Vogiatzis]

gvgeo added a dependent revision: D27032: Enable adding a place as first item..

REPOSITORY
  R241 KIO

BRANCH
  after (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26983

To: gvgeo, #frameworks, meven, broulik, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27002: Fix memory leak in KUrlNavigatorPlacesSelector::updateMenu

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> fvogt wrote in kurlnavigatorplacesselector.cpp:75
> How would that make a difference?

Misconception on my part, .children() is not affected by .clear()

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27002

To: fvogt, #frameworks
Cc: anthonyfieroni, meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74676.
leinir added a comment.


  As suggested by frinring, do not suggest setting a ProvidersUrl unless
  it is actually needed.
  
  - Rework the knsrc description comment, suggest not setting ProvidersUrl

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27028?vs=74675=74676

BRANCH
  fix-dko-overload-by-switching-to-autoconfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27028

AFFECTED FILES
  src/core/cache.cpp
  src/downloaddialog.h
  src/downloadwidget.h
  tests/khotnewstuff.knsrc
  tests/khotnewstuff_upload.knsrc

To: leinir, bcooksley, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir added reviewers: bcooksley, Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27028

To: leinir, bcooksley, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27028: Switch from download.k.o to autoconfig

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Rather than suggest using dko for provider files, we should be
  suggesting autoconfig.k.o, which is a more capable service.
  
  This is hopefully going to help in alleviating the overload on
  the download.kde.org service, which does not handle the load as
  well as autoconfig.kde.org does (and can't be fixed due to legacy).
  
  See also https://marc.info/?l=kde-core-devel=158037601132219=2
  for further details on the situation.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-dko-overload-by-switching-to-autoconfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27028

AFFECTED FILES
  src/core/cache.cpp
  src/downloaddialog.h
  src/downloadwidget.h
  tests/khotnewstuff.knsrc
  tests/khotnewstuff_upload.knsrc

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27025: Ignore udev monitoring notifications with actions bind and unbind

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> udevqtclient.cpp:119
> +} else  if (action == "bind") {
> +// ignored
> +} else  if (action == "unbind") {

Can you instead add signals for those, just for completeness' sake? 
`deviceOnlined` is also not used but still exists

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27025

To: meven, broulik, ervin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

[Aleix Pol Gonzalez]

apol added a comment.


  In D26133#603118 , @tcanabrava 
wrote:
  
  > > That's why personally I think it's fine to assume people need to opt-in 
for GenerateProperties if they want the feature, it's closely related after all.
  >
  > I disagree here.
  >  my application can be a simple QWidget based and have a KConfigXT enabled 
configuration dialog that I want to trigger a save on any edit.
  >  I don't need properties for that.
  
  
  What's the problem with having properties though?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D26133

To: tcanabrava, ervin
Cc: ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi added a comment.


  @mart
  Do you have any objection?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improve-file-drop-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26691

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/21/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 Jan 2020 11:41:44 +
 Build duration:
1 min 54 sec and counting
   BUILD ARTIFACTS
  acc/KF5QuickCharts-5.67.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_SUSEQt512 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)45%
(15/33)45%
(15/33)18%
(356/1954)14%
(119/857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(56/56)64%
(27/42)controls0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/4)src100%
(9/9)100%
(9/9)38%
(221/577)23%
(47/202)src.datasource44%
(4/9)44%
(4/9)21%
(79/374)19%
(45/236)src.decorations0%
(0/4)0%
(0/4)0%
(0/392)0%
(0/199)src.scenegraph0%
(0/8)0%
(0/8)0%
(0/538)0%
(0/174)

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.13 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.13/21/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 30 Jan 2020 11:41:44 +
 Build duration:
1 min 29 sec and counting
   BUILD ARTIFACTS
  acc/KF5QuickCharts-5.67.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_SUSEQt513 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(3/6)45%
(15/33)45%
(15/33)18%
(356/1954)14%
(119/857)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(56/56)64%
(27/42)controls0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/4)src100%
(9/9)100%
(9/9)38%
(221/577)23%
(47/202)src.datasource44%
(4/9)44%
(4/9)21%
(79/374)19%
(45/236)src.decorations0%
(0/4)0%
(0/4)0%
(0/392)0%
(0/199)src.scenegraph0%
(0/8)0%
(0/8)0%
(0/538)0%
(0/174)

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/21/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 11:41:44 +
 Build duration:
59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.usr.home.jenkins.workspace.Frameworks.kquickcharts.kf5-qt5_FreeBSDQt513 Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D26691: Optimize code when dropping files into the desktop

[Tranter Madi]

trmdi updated this revision to Diff 74672.
trmdi added a comment.


  - Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26691?vs=74036=74672

BRANCH
  improve-file-drop-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26691

AFFECTED FILES
  src/scriptengines/qml/plasmoid/containmentinterface.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.h
  src/scriptengines/qml/plasmoid/dropmenu.cpp
  src/scriptengines/qml/plasmoid/dropmenu.h

To: trmdi, #plasma, mart, broulik, #vdg, davidedmundson
Cc: davidedmundson, anthonyfieroni, #plasma, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 Jan 2020 11:31:19 +
 Build duration:
47 sec and counting
   CONSOLE OUTPUT
  [...truncated 250 lines...][2020-01-30T11:32:01.260Z] CMake Warning:[2020-01-30T11:32:01.260Z]   Manually-specified variables were not used by the project:[2020-01-30T11:32:01.260Z] [2020-01-30T11:32:01.260Z] BUILD_QCH[2020-01-30T11:32:01.260Z] [2020-01-30T11:32:01.260Z] [2020-01-30T11:32:01.260Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kquickcharts/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-30T11:32:01.961Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kquickcharts --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-01-30T11:32:01.961Z] Scanning dependencies of target qmltest_autogen[2020-01-30T11:32:01.961Z] Scanning dependencies of target chartscontrolsplugin_autogen[2020-01-30T11:32:01.961Z] Scanning dependencies of target QuickChartsStatic_autogen[2020-01-30T11:32:01.961Z] [  2%] Automatic MOC for target qmltest[2020-01-30T11:32:01.961Z] [  4%] Automatic MOC for target chartscontrolsplugin[2020-01-30T11:32:01.961Z] [  6%] Automatic MOC for target QuickChartsStatic[2020-01-30T11:32:01.961Z] [  6%] Built target qmltest_autogen[2020-01-30T11:32:01.961Z] Scanning dependencies of target qmltest[2020-01-30T11:32:01.961Z] [  8%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-01-30T11:32:01.961Z] [ 10%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-01-30T11:32:01.961Z] [ 10%] Built target chartscontrolsplugin_autogen[2020-01-30T11:32:02.222Z] Scanning dependencies of target chartscontrolsplugin[2020-01-30T11:32:02.222Z] [ 13%] Building CXX object controls/CMakeFiles/chartscontrolsplugin.dir/chartscontrolsplugin_autogen/mocs_compilation.cpp.o[2020-01-30T11:32:02.222Z] [ 15%] Building CXX object controls/CMakeFiles/chartscontrolsplugin.dir/ChartsControlsPlugin.cpp.o[2020-01-30T11:32:02.222Z] [ 15%] Built target QuickChartsStatic_autogen[2020-01-30T11:32:02.222Z] [ 17%] Generating qrc_shaders.cpp[2020-01-30T11:32:02.222Z] Scanning dependencies of target QuickChartsStatic[2020-01-30T11:32:02.222Z] [ 19%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/XYChart.cpp.o[2020-01-30T11:32:02.222Z] [ 21%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/PieChart.cpp.o[2020-01-30T11:32:02.222Z] [ 26%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/decorations/GridLines.cpp.o[2020-01-30T11:32:02.222Z] [ 28%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/BarChart.cpp.o[2020-01-30T11:32:02.222Z] [ 28%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/Chart.cpp.o[2020-01-30T11:32:02.222Z] [ 30%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/decorations/AxisLabels.cpp.o[2020-01-30T11:32:02.222Z] [ 32%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/QuickChartsStatic_autogen/mocs_compilation.cpp.o[2020-01-30T11:32:02.222Z] [ 34%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/RangeGroup.cpp.o[2020-01-30T11:32:02.222Z] [ 36%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/LineChart.cpp.o[2020-01-30T11:32:02.789Z] [ 39%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/decorations/LegendModel.cpp.o[2020-01-30T11:32:03.048Z] [ 41%] Linking CXX shared library ../bin/libchartscontrolsplugin.so[2020-01-30T11:32:03.048Z] [ 43%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ChartDataSource.cpp.o[2020-01-30T11:32:03.617Z] [ 45%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ModelSource.cpp.o[2020-01-30T11:32:03.617Z] [ 45%] Built target chartscontrolsplugin[2020-01-30T11:32:03.617Z] [ 47%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/SingleValueSource.cpp.o[2020-01-30T11:32:03.617Z] [ 50%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ArraySource.cpp.o[2020-01-30T11:32:03.617Z] [ 52%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ModelHistorySource.cpp.o[2020-01-30T11:32:03.617Z] [ 54%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ChartAxisSource.cpp.o[2020-01-30T11:32:03.617Z] [ 56%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ValueHistorySource.cpp.o[2020-01-30T11:32:03.877Z] [ 58%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ColorGradientSource.cpp.o[2020-01-30T11:32:03.877Z] [ 60%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/scenegraph/PieChartMaterial.cpp.o[2020-01-30T11:32:03.877Z] [ 63%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/scenegraph/PieChartNode.cpp.o[2020-01-30T11:32:04.136Z] [ 65%] 

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 30 Jan 2020 11:31:19 +
 Build duration:
24 sec and counting
   CONSOLE OUTPUT
  [...truncated 193 lines...][2020-01-30T11:31:35.832Z] [2020-01-30T11:31:35.833Z] BUILD_QCH[2020-01-30T11:31:35.833Z] [2020-01-30T11:31:35.833Z] [2020-01-30T11:31:35.833Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kquickcharts/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-01-30T11:31:36.379Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kquickcharts --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-01-30T11:31:36.379Z] Scanning dependencies of target chartscontrolsplugin_autogen[2020-01-30T11:31:36.379Z] Scanning dependencies of target qmltest_autogen[2020-01-30T11:31:36.379Z] Scanning dependencies of target QuickChartsStatic_autogen[2020-01-30T11:31:36.379Z] [  2%] Automatic MOC for target qmltest[2020-01-30T11:31:36.379Z] [  4%] Automatic MOC for target chartscontrolsplugin[2020-01-30T11:31:36.379Z] [  6%] Automatic MOC for target QuickChartsStatic[2020-01-30T11:31:36.635Z] [  6%] Built target qmltest_autogen[2020-01-30T11:31:37.203Z] [  6%] Built target chartscontrolsplugin_autogen[2020-01-30T11:31:37.203Z] Scanning dependencies of target chartscontrolsplugin[2020-01-30T11:31:37.203Z] [  8%] Building CXX object controls/CMakeFiles/chartscontrolsplugin.dir/ChartsControlsPlugin.cpp.o[2020-01-30T11:31:37.203Z] [ 10%] Building CXX object controls/CMakeFiles/chartscontrolsplugin.dir/chartscontrolsplugin_autogen/mocs_compilation.cpp.o[2020-01-30T11:31:37.203Z] Scanning dependencies of target qmltest[2020-01-30T11:31:37.203Z] [ 13%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest_autogen/mocs_compilation.cpp.o[2020-01-30T11:31:37.203Z] [ 15%] Building CXX object autotests/CMakeFiles/qmltest.dir/qmltest.cpp.o[2020-01-30T11:31:37.474Z] [ 15%] Built target QuickChartsStatic_autogen[2020-01-30T11:31:37.474Z] [ 17%] Generating qrc_shaders.cpp[2020-01-30T11:31:37.474Z] Scanning dependencies of target QuickChartsStatic[2020-01-30T11:31:37.474Z] [ 19%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/XYChart.cpp.o[2020-01-30T11:31:37.474Z] [ 21%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/Chart.cpp.o[2020-01-30T11:31:37.474Z] [ 23%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/QuickChartsStatic_autogen/mocs_compilation.cpp.o[2020-01-30T11:31:37.474Z] [ 26%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/BarChart.cpp.o[2020-01-30T11:31:37.474Z] [ 28%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/PieChart.cpp.o[2020-01-30T11:31:37.474Z] [ 30%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/decorations/GridLines.cpp.o[2020-01-30T11:31:37.474Z] [ 32%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/LineChart.cpp.o[2020-01-30T11:31:37.474Z] [ 34%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/decorations/AxisLabels.cpp.o[2020-01-30T11:31:37.474Z] [ 36%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/RangeGroup.cpp.o[2020-01-30T11:31:38.070Z] [ 39%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/decorations/LegendModel.cpp.o[2020-01-30T11:31:38.070Z] [ 41%] Linking CXX shared library ../bin/libchartscontrolsplugin.so[2020-01-30T11:31:38.335Z] [ 41%] Built target chartscontrolsplugin[2020-01-30T11:31:38.335Z] [ 43%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ChartDataSource.cpp.o[2020-01-30T11:31:38.597Z] [ 45%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ModelSource.cpp.o[2020-01-30T11:31:39.136Z] [ 47%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/SingleValueSource.cpp.o[2020-01-30T11:31:39.136Z] [ 50%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ArraySource.cpp.o[2020-01-30T11:31:39.136Z] [ 52%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ModelHistorySource.cpp.o[2020-01-30T11:31:39.136Z] [ 54%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ChartAxisSource.cpp.o[2020-01-30T11:31:39.400Z] [ 56%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ValueHistorySource.cpp.o[2020-01-30T11:31:39.400Z] [ 58%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/datasource/ColorGradientSource.cpp.o[2020-01-30T11:31:39.400Z] [ 60%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/scenegraph/PieChartMaterial.cpp.o[2020-01-30T11:31:39.401Z] [ 63%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/scenegraph/PieChartNode.cpp.o[2020-01-30T11:31:39.401Z] [ 65%] Building CXX object src/CMakeFiles/QuickChartsStatic.dir/scenegraph/LineGridNode.cpp.o[2020-01-30T11:31:39.670Z] [