date:20200201

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread George Vogiatzis

gvgeo removed a reviewer: ndavis.
gvgeo added a subscriber: ndavis.
gvgeo added a comment.


  
  
  In D27082#604556 , @ndavis wrote:
  
  > poor horizontal alignment
  
  
  Don't make me redraw PC3 tests too. The basis of the issue is the same, 
different Label than Button height. For PC3 label is shorter than buttons.
  
  In D26758#604416 , @gvgeo wrote:
  
  > F8071207: alignment.png 
  >  This shows the problem.
  >  Don't know what is the correct approach:
  >  1 Label needs to be shorter.
  >  2 Give correct height in checkbox, and center the buttons.
  >  3 Override label height in radiobutton, to make everything slim. Will need 
to center when used.
  
  
  Either need to increase label height to button height, or need to center 
label in the test (and everywhere else it is used.)
  
  ---
  
  In D27082#604557 , @ndavis wrote:
  
  > Well, it has the correct size in that it's 16x16, but it's like it was 
stretched and crop
  
  
  Others would say "The position of the left side is off by half a pixel".
  The cause of it and solution, as I interpret them is D27083 
.
  
  ---
  
  In D27082#604556 , @ndavis wrote:
  
  > I'm not really the best person to review this
  
  
  I made these 2 patches based on your feedback, and thought  it would be a 
good idea to see them. There, fixed it :)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma
Cc: ndavis, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 108 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/108/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 01 Feb 2020 23:00:32 +
 Build duration:
6 min 40 sec and counting
   BUILD ARTIFACTS
  acc/KF5Service-5.67.0.xmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5636/8095)47%
(2454/5179)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1504/1587)49%
(654/1342)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1856/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2080/2744)61%
(1012/1669)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 82 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/82/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 01 Feb 2020 23:00:32 +
 Build duration:
6 min 40 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5634/8095)47%
(2450/5179)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1502/1587)48%
(650/1342)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1856/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2080/2744)61%
(1012/1669)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/79/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 23:00:31 +
 Build duration:
4 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Banning QNetworkAccessManager

2020-02-01 Thread Ben Cooksley

Hi all,

For an extremely long time now, it has been a known issue with the
QNetworkAccessManager that by default it does not follow redirects as
issued by the server it is accessing. This is something the Qt Project
has refused to address using the justification of 'behavioural
compatibility'

This behaviour is contrary to that of just about every other HTTP
stack (with the exception of libcurl from my understanding) and is
behaviour that nobody expects.

As a consequence of this (broken) behaviour, Sysadmin has been
effectively forced to implement workarounds and other compatibility
measures in place to keep applications functional. These measures harm
the long term maintainability of our systems, and sometimes limit our
ability to make services more scalable. In some instances, the cost of
compatibility measures would be too high, resulting in functionality
of applications being broken. I am aware of at least one instance
where if a compatibility measure we maintain is removed, the
application will crash (segfault) during it's operation (a failure
that makes the application unusable)

Prior to now, i've taken the approach of advertising that
QNetworkAccessManager is broken and needs a flag set within
applications when used, however unfortunately this seems to have been
an ineffective approach and cases of broken behaviour continue to
appear (despite this brokeness being known about and advertised since
back in the Qt 4.x series when this class was introduced)

Therefore, given the Qt Project is unlikely to change their position
on this, I would like to propose the following:
1) That effective immediately, QNetworkAccessManager and it's children
classes be banned and prohibited within KDE software, to be enforced
by server side hooks.
2) That we fork QNetworkAccessManager and the associated classes
within the appropriate Framework (to be determined), where the
defective behaviour can then be corrected.

Comments?

Regards,
Ben Cooksley
KDE Sysadmin

D26931: Introduce SPDX license headers

2020-02-01 Thread Andreas Cord-Landwehr

cordlandwehr added inline comments.

INLINE COMMENTS

> kossebau wrote in MIT.txt:1
> Does the  " " work here?

The statement is correct, it directly comes from the SPDX license text registry 
and is installed via the "reuse download" tool to ensure that the original 
header is deployed.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr, cgiboudeaux
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 179 - Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/179/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 20:19:37 +
 Build duration:
7 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

D23410: improve word completion to use highlighting to detect word boundaries

2020-02-01 Thread Christoph Cullmann

cullmann planned changes to this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23410

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23410: improve word completion to use highlighting to detect word boundaries

2020-02-01 Thread Christoph Cullmann

cullmann added a comment.


  Reverted atm...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23410

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23410: improve word completion to use highlighting to detect word boundaries

2020-02-01 Thread Christoph Cullmann

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Did lead to regressions, see https://bugs.kde.org/show_bug.cgi?id=412502

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23410

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread Noah Davis

ndavis added a comment.


  Well, it has the correct size in that it's 16x16, but it's like it was 
stretched and cropped.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread Noah Davis

ndavis added a comment.


  I'm not really the best person to review this, but it seems to work. The test 
still has poor horizontal alignment and the button doesn't have the correct 
size. F8074583: Screenshot_20200201_142426.PNG 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26931: Introduce SPDX license headers

2020-02-01 Thread Friedrich W. H. Kossebau

kossebau added inline comments.

INLINE COMMENTS

> MIT.txt:1
> +MIT License Copyright (c)  
> +

Does the  " " work here?

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr, cgiboudeaux
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D27092: Update license statements to SPDX identifiers

2020-02-01 Thread Andreas Cord-Landwehr

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Update all existing license and copyright statements
  to SPDX identifiers.

REPOSITORY
  R280 Prison

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27092

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/MIT.txt
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  autotests/reedsolomontest.cpp
  cmake/FindDmtx.cmake
  cmake/FindQRencode.cmake
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/aztecbarcode.h
  src/lib/bitvector.cpp
  src/lib/bitvector_p.h
  src/lib/code128barcode.cpp
  src/lib/code128barcode.h
  src/lib/code39barcode.cpp
  src/lib/code39barcode.h
  src/lib/code93barcode.cpp
  src/lib/code93barcode.h
  src/lib/config-prison.h.in
  src/lib/datamatrixbarcode.cpp
  src/lib/datamatrixbarcode.h
  src/lib/prison.cpp
  src/lib/prison.h
  src/lib/qrcodebarcode.cpp
  src/lib/qrcodebarcode.h
  src/lib/reedsolomon.cpp
  src/lib/reedsolomon_p.h
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  src/quick/prisonquickplugin.cpp
  src/tools/prison-datamatrix.cpp
  tests/barcode.qml
  tests/barcodeexamplewidget.cpp
  tests/barcodeexamplewidget.h
  tests/prison.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27092: Update license statements to SPDX identifiers

2020-02-01 Thread Andreas Cord-Landwehr

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27092

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27091: Convert license statements to SPDX

2020-02-01 Thread Christophe Giboudeaux

cgiboudeaux added a comment.


  +1 LGTM

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27091

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27091: Convert license statements to SPDX

2020-02-01 Thread Andreas Cord-Landwehr

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27091

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27091: Convert license statements to SPDX

2020-02-01 Thread Andreas Cord-Landwehr

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX and add required files in LICENSES
  folder.

REPOSITORY
  R246 Sonnet

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27091

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-or-later.txt
  autotests/test_core.cpp
  autotests/test_core.h
  autotests/test_filter.cpp
  autotests/test_filter.h
  autotests/test_highlighter.cpp
  autotests/test_settings.cpp
  autotests/test_settings.h
  autotests/test_suggest.cpp
  cmake/FindENCHANT.cmake
  cmake/FindHUNSPELL.cmake
  data/gentrigrams.cpp
  data/parsetrigrams.cpp
  examples/configdialog.cpp
  examples/dialogexample.cpp
  examples/dialogexample.h
  examples/dictionarycombobox.cpp
  examples/highlighterexample.cpp
  examples/highlighterexample.h
  examples/plaintextedit.cpp
  examples/textedit.cpp
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/core/client.cpp
  src/core/client_p.h
  src/core/guesslanguage.cpp
  src/core/guesslanguage.h
  src/core/languagefilter.cpp
  src/core/languagefilter_p.h
  src/core/loader.cpp
  src/core/loader_p.h
  src/core/settings.cpp
  src/core/settings_p.h
  src/core/speller.cpp
  src/core/speller.h
  src/core/spellerplugin.cpp
  src/core/spellerplugin_p.h
  src/core/textbreaks.cpp
  src/core/textbreaks_p.h
  src/core/tokenizer.cpp
  src/core/tokenizer_p.h
  src/plugins/aspell/aspellclient.cpp
  src/plugins/aspell/aspellclient.h
  src/plugins/aspell/aspelldict.cpp
  src/plugins/aspell/aspelldict.h
  src/plugins/enchant/enchantclient.cpp
  src/plugins/enchant/enchantclient.h
  src/plugins/enchant/enchantdict.cpp
  src/plugins/enchant/enchantdict.h
  src/plugins/hspell/hspellclient.cpp
  src/plugins/hspell/hspellclient.h
  src/plugins/hspell/hspelldict.cpp
  src/plugins/hspell/hspelldict.h
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspellclient.h
  src/plugins/hunspell/hunspelldict.cpp
  src/plugins/hunspell/hunspelldict.h
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerclient.h
  src/plugins/ispellchecker/ispellcheckerdict.cpp
  src/plugins/ispellchecker/ispellcheckerdict.h
  src/plugins/nsspellchecker/nsspellcheckerclient.h
  src/plugins/nsspellchecker/nsspellcheckerclient.mm
  src/plugins/nsspellchecker/nsspellcheckerdict.h
  src/plugins/nsspellchecker/nsspellcheckerdict.mm
  src/plugins/voikko/voikkoclient.cpp
  src/plugins/voikko/voikkoclient.h
  src/plugins/voikko/voikkodict.cpp
  src/plugins/voikko/voikkodict.h
  src/ui/configdialog.cpp
  src/ui/configdialog.h
  src/ui/configwidget.cpp
  src/ui/configwidget.h
  src/ui/dialog.cpp
  src/ui/dialog.h
  src/ui/dictionarycombobox.cpp
  src/ui/dictionarycombobox.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h
  src/ui/spellcheckdecorator.cpp
  src/ui/spellcheckdecorator.h
  tests/backgroundtest.cpp
  tests/backgroundtest.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 81 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/81/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 01 Feb 2020 17:29:08 +
 Build duration:
7 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5633/8099)47%
(2451/5183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1508/1591)49%
(656/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2076/2744)60%
(1007/1669)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/78/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 17:29:08 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 107 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/107/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 01 Feb 2020 17:29:08 +
 Build duration:
3 min 8 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5631/8099)47%
(2447/5183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1506/1591)48%
(652/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2076/2744)60%
(1007/1669)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

D27087: Add HEIF thumbnailer

2020-02-01 Thread Kai Uwe Broulik

broulik added a comment.


  https://codereview.qt-project.org/c/qt/qtimageformats/+/236077

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: cfeck, broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Christoph Feck

cfeck added a comment.


  Where can we see the status of the HEIF Qt loader? If it correctly implements 
scaled image loading, then a separate thumbnailer indeed makes not much sense. 
If, however, it always loads the full image, then scales it down, we got a case 
for a separate thumbnailer such as this one.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: cfeck, broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, 
iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-02-01 Thread Christoph Cullmann

cullmann updated this revision to Diff 74839.
cullmann added a comment.


  set normal or dark icons based on current palette

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25119?vs=69194=74839

BRANCH
  arcpatch-D25119

REVISION DETAIL
  https://phabricator.kde.org/D25119

AFFECTED FILES
  CMakeLists.txt
  KF5BreezeIconsConfig.cmake.in
  src/CMakeLists.txt
  src/main.cpp

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii

zzag added a comment.


  In D27087#604479 , @broulik wrote:
  
  > There's a Qt heif image plug in in the works in Qt. If any, we should help 
there or at least get our own into kimageformats, so Gwenview and others can 
open such files properly.
  
  
  I assume that you want to get the first image stored in a heif file and use 
it as a thumbnail. I'm not sure whether it's a good idea to completely ignore 
thumbnails that are associated with the primary image.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii

zzag abandoned this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Kai Uwe Broulik

broulik added a comment.


  -1 for making a dedicated thumbnailer.
  There's a Qt heif image plug in in the works in Qt. If any, we should help 
there or at least get our own into kimageformats, so Gwenview and others can 
open such files properly.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii

zzag added a comment.


  In D27087#604477 , @ngraham wrote:
  
  > Very cool. So QImage supports this file format now such that you could open 
the image in, say, Gwenview?
  
  
  No, as far as I know there is no `QImageIOHandler` for HEIF files. However, 
applications such as GIMP, Krita, and digiKam are able to open HEIF files.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Nathaniel Graham

ngraham added a comment.


  Very cool. So QImage support this file format now such that you could open 
the image in, say, Gwenview?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii

zzag updated this revision to Diff 74836.
zzag added a comment.


  missing copyright stuff in Findlibheif.cmake

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27087?vs=74835=74836

BRANCH
  heic-thumbnailer

REVISION DETAIL
  https://phabricator.kde.org/D27087

AFFECTED FILES
  cmake/Findlibheif.cmake
  thumbnail/CMakeLists.txt
  thumbnail/heifcreator.cpp
  thumbnail/heifcreator.h
  thumbnail/heifthumbnail.desktop

To: zzag, #plasma
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii

zzag edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27087

To: zzag, #plasma
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27087: Add HEIF thumbnailer

2020-02-01 Thread Vlad Zahorodnii

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
zzag requested review of this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  heic-thumbnailer

REVISION DETAIL
  https://phabricator.kde.org/D27087

AFFECTED FILES
  cmake/Findlibheif.cmake
  thumbnail/CMakeLists.txt
  thumbnail/heifcreator.cpp
  thumbnail/heifcreator.h
  thumbnail/heifthumbnail.desktop

To: zzag, #plasma
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D26931: Introduce SPDX license headers

2020-02-01 Thread Andreas Cord-Landwehr

This revision was automatically updated to reflect the committed changes.
Closed by commit R274:11f5cd0390e4: Introduce SPDX license headers (authored by 
cordlandwehr).

REPOSITORY
  R274 KIdleTime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26931?vs=74768=74834

REVISION DETAIL
  https://phabricator.kde.org/D26931

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/MIT.txt
  examples/KIdleTest.cpp
  examples/KIdleTest.h
  examples/main.cpp
  src/abstractsystempoller.cpp
  src/abstractsystempoller.h
  src/kidletime.cpp
  src/kidletime.h
  src/plugins/osx/macpoller.cpp
  src/plugins/osx/macpoller.h
  src/plugins/windows/windowspoller.cpp
  src/plugins/windows/windowspoller.h
  src/plugins/xscreensaver/xscreensaverbasedpoller.cpp
  src/plugins/xscreensaver/xscreensaverbasedpoller.h
  src/plugins/xsync/fixx11h.h
  src/plugins/xsync/xsyncbasedpoller.cpp
  src/plugins/xsync/xsyncbasedpoller.h
  src/widgetbasedpoller.cpp
  src/widgetbasedpoller.h

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 80 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/80/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 01 Feb 2020 10:19:55 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5631/8099)47%
(2444/5183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1507/1592)48%
(651/1348)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 79 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/79/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 01 Feb 2020 09:07:12 +
 Build duration:
1 hr 12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5633/8099)47%
(2449/5183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1509/1592)49%
(657/1348)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1004/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

D27083: [PC2]Give Label integer width.

2020-02-01 Thread George Vogiatzis

gvgeo added a comment.


  The Checkbox takes fractional position, caused from the fractional width of 
the Label. This lead to blurriness.
  F8071229: Screenshot_20200201_100353_2.png 

  I don't understand what the problem is. Height can also take the 
`Math.ceil(paintedHeight)` part.
  Got confused, what is the requested change?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, 
bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 106 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/106/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 01 Feb 2020 10:11:34 +
 Build duration:
3 min 25 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5631/8099)47%
(2444/5183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1507/1592)48%
(651/1348)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/77/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 10:11:34 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 58 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/58/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:09:33 +
 Build duration:
59 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D26758: Fix the size and pixel alignment of checkboxes and radiobuttons

2020-02-01 Thread George Vogiatzis

gvgeo added a comment.


  F8071207: alignment.png 
  This shows the problem.
  Don't know what is the correct approach:
  1 Label needs to be shorter, like PC3.
  2 Give correct height in checkbox, and center the buttons.
  3 Override label height in radiobutton, to make everything slim. Will need to 
center when used.
  
  Sorry for the non relevant note, thought you were maintainer. You answered 
anyway, thanks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26758

To: ndavis, #plasma, #vdg, ngraham
Cc: gvgeo, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D25698: New query mechanism for applications: KApplicationTrader

2020-02-01 Thread David Faure

dfaure added a comment.


  ping?

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D25698

To: dfaure, broulik, mart, vkrause, nicolasfella, aacid, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » threadweaver » kf5-qt5 SUSEQt5.12 - Build # 60 - Fixed!

2020-02-01 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/threadweaver/job/kf5-qt5%20SUSEQt5.12/60/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 01 Feb 2020 09:10:03 +
 Build duration:
45 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5ThreadWeaver-5.67.0.xmlcompat_reports/KF5ThreadWeaver_compat_report.htmllogs/KF5ThreadWeaver/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(2/7)71%
(55/78)71%
(55/78)73%
(2433/3329)41%
(2486/6100)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)99%
(1219/1224)51%
(1748/3454)benchmarks0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/60)examples.HelloInternet0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/264)examples.HelloWorld0%
(0/1)0%
(0/1)0%
(0/3)100%
(0/0)examples.HelloWorldRaw0%
(0/1)0%
(0/1)0%
(0/13)100%
(0/0)examples.ThumbNailer0%
(0/14)0%
(0/14)0%
(0/458)0%
(0/880)src98%
(42/43)98%
(42/43)87%
(1214/1388)51%
(738/1442)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:07:51 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testTextInputFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/76/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:07:10 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27083: [PC2]Give Label integer width.

2020-02-01 Thread David Edmundson

davidedmundson added a comment.


  I don't understand from the screenshot what changed wrt widths in your 
screenshots. Could you expand on what the bug identified is?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, 
bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:06:41 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

D27083: [PC2]Give Label integer width.

2020-02-01 Thread David Edmundson

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  The math.ceil changes. Absolutely.
  
  Binding width to painted width doesn't make sense. They're different things. 
It'll break any alignment

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, 
bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/52/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:06:13 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 105 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/105/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 01 Feb 2020 09:07:11 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Service-5.67.0.xmlcompat_reports/KF5Service_compat_report.htmllogs/KF5Service/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kservicetestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)84%
(72/86)84%
(72/86)70%
(5629/8097)47%
(2442/5181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(13/13)100%
(13/13)95%
(1505/1590)48%
(649/1346)src.kbuildsycoca100%
(1/1)100%
(1/1)90%
(45/50)38%
(3/8)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/329)0%
(0/225)src.plugin67%
(2/3)67%
(2/3)48%
(46/95)41%
(33/81)src.services97%
(29/30)97%
(29/30)61%
(1853/3056)41%
(736/1796)src.sycoca83%
(24/29)83%
(24/29)76%
(2075/2743)60%
(1005/1667)tests0%
(0/5)0%
(0/5)0%
(0/117)0%
(0/34)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(105/117)67%
(16/24)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 282 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/282/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:04:45 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:04:28 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.14/2/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 01 Feb 2020 09:00:11 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.KAuthHelperTest

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.14/2/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Sat, 01 Feb 2020 09:00:21 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.kbookmarktest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:02:39 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 58 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/58/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:02:17 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 155 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/155/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 01 Feb 2020 09:01:32 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.67.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.67.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6928/9112)43%
(10797/24836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2898/2990)49%
(6194/12720)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/799)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 72 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/72/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:01:59 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 103 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/103/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:01:32 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 48 - Still Unstable!

2020-02-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/48/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 01 Feb 2020 09:00:29 +
 Build duration:
8 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D27083: [PC2]Give Label integer width.

2020-02-01 Thread George Vogiatzis

gvgeo edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27083: [PC2]Give Label integer width.

2020-02-01 Thread George Vogiatzis

gvgeo added a comment.


  PC3 label gives integer size.
  If this patch is right, will make a patch to change all the tests to use 
PC2/PC3 label, instead of QQC2 for proper display.
  
  The 2 vertical misalignment problems are not the focus of this patch, created 
by:
  
  1. PC2 label height is way bigger that QQC2.
  2. A bug with the checkbox prevents label to take proper height.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27083: [PC2]Give Label integer width.

2020-02-01 Thread George Vogiatzis

gvgeo edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27083: [PC2]Give Label integer width.

2020-02-01 Thread George Vogiatzis

gvgeo edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27082: [Tests]Make radiobutton3.qml use PC3

2020-02-01 Thread George Vogiatzis

gvgeo retitled this revision from "Make radiobutton3.qml use PC3" to 
"[Tests]Make radiobutton3.qml use PC3".
gvgeo edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27083: [PC2]Give Label integer width.

2020-02-01 Thread George Vogiatzis

gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, ndavis.
gvgeo added a project: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Label paintedWidth creates alingment issues when used in Grid, Flow.
  Also change height round to ceil, to prevent cropping vertical text.

TEST PLAN
  Run `qmlscene test.qml`
  Before:
  Checkbox vertical lines have aliasing ssues.
  After:
  Proper display for second Checkbox.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  label2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27083

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/Label.qml

To: gvgeo, #plasma, #vdg, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27082: Make radiobutton3.qml use PC3

2020-02-01 Thread George Vogiatzis

gvgeo added a comment.


  Because PC3 label is shorter that PC3 checkbox, there is a misalignment than 
need fixing. Either need to change label to have a height similar to PC2 
(1.6*fontHeight). Or need to change this test's text vertical alignment.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27082

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27082: Make radiobutton3.qml use PC3

2020-02-01 Thread George Vogiatzis

gvgeo created this revision.
gvgeo added reviewers: Plasma, ndavis.
gvgeo added a project: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Correct radiobutton3.qml to use Plasma Components 3 instead of 2.

TEST PLAN
  Run `qmlscene radiobutton3.qml`
  Before:
  Misaligned button and big height. (bug in PC2 radiobutton)
  After:
  Correct height and alignment between button and button's text.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27082

AFFECTED FILES
  tests/components/radiobutton3.qml

To: gvgeo, #plasma, ndavis
Cc: kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, ngraham, bruns, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

67 matches

Mail list logo