D27263: RFC: Accent colour for KColorScheme

[Carson Black]

cblack edited the summary of this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27263

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

[Carson Black]

cblack added a task: T11052: Accent Colors, Color Ramps and other improvements 
to theming..

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27263

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

[Carson Black]

cblack planned changes to this revision.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27263

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27263: RFC: Accent colour for KColorScheme

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This is a roughly thrown-together patch demonstrating how an
  accent colour can be implemented via modifiying KColorScheme.
  
  Notes about what sucks currently:
  
  - No way to query the true colour of an item getting overidden by an accent 
colour (bad for stuff like KColorSchemeEditor)
  - Accent color text on accent colour background is 100% unreadable
  
  Stuff I plan to do:
  
  - Split Accent → AccentForeground and AccentBackground.
  - Figure out a way to more elegantly handle inactive and disabled accent 
colours

TEST PLAN
  Add an `Accent` colour in a `[Colors:Accent]` section in a colourscheme.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  kcolorscheme-accent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27263

AFFECTED FILES
  src/kcolorscheme.cpp

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 292 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/292/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 09 Feb 2020 04:42:07 +
 Build duration:
8 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27220: add pix icon

[Mathis Brüchert]

mbruchert added a comment.


  F8092609: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27220

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @mlaurent Wasn't there also something which tells kdebugsettings about 
renamed categories? Is that documented anywhere? Could that be supported by 
some additional macro or adaption of the existing/new ones?

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addautomaticcategoriesgeneration

REVISION DETAIL
  https://phabricator.kde.org/D27150

To: kossebau, #build_system, #frameworks, broulik, mlaurent
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/58/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 08 Feb 2020 22:19:51 +
 Build duration:
5 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/92/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 08 Feb 2020 22:19:51 +
 Build duration:
5 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D26394: ECMGeneratePriFile: Fix static configurations

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26394

To: kfunk, dfaure, winterz, vkrause, apol
Cc: kossebau, lbeltrame, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Make sure to run the icons through an SVG optimizer, per 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization
  
  After that, you'll need to manually fix the stylesheet stuff by getting rid 
of `color:#da4453` inside the path definitions. The easiest way to do this is 
to just open the svg files with a text editor and remove those bigs manually.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D26394: ECMGeneratePriFile: Fix static configurations

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ECMGeneratePriFile.cmake:183
> +  set(PRI_TARGET_MODULE_CONFIG "")
> +  get_target_property(target_type ${EGPF_LIB_NAME} TYPE)
> +  if (target_type STREQUAL "STATIC_LIBRARY")

Hmpf, this adds the firm assumption that EGPF_LIB_NAME actually is a target. 
One could say the API docs require this to be though only implicitly. At least 
I missed it. And for a reason:

In Okteta I have target names which do not match the outputname. And thus I 
pass for LIB_NAME the outputname (even extract it explicitely by

  get_target_property(_libraryName ${_targetName} OUTPUT_NAME)

so that in the pri file generation code the name and module properties have 
matching strings. I never looked at the implementation, the `TARGET` in the 
helper vars might have hinted me this logic here is more primitive:

  set(PRI_TARGET_LIBNAME ${EGPF_LIB_NAME})
  # [...]
  QT.${PRI_TARGET_BASENAME}.name = ${PRI_TARGET_LIBNAME}
  QT.${PRI_TARGET_BASENAME}.module = ${PRI_TARGET_LIBNAME}

Guess I have to come up with a patch to allow caller side to pass another name 
explicitly then.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D26394

To: kfunk, dfaure, winterz, vkrause, apol
Cc: kossebau, lbeltrame, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Me too!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

[Nathaniel Graham]

ngraham added a dependent revision: D27260: [applets/systemtray] Set pin 
button's size correctly.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-pc3-toolbutton-sizing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27221

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: gvgeo, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

[Matej Mrenica]

mthw edited the summary of this revision.
mthw edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Carson Black]

cblack accepted this revision.
cblack added a comment.


  Style-wise, the tinting effect definitely an improvement over what we 
currently have. Everything here LGTM.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove updated this revision to Diff 75277.
niccolove added a comment.


  Changed saturation to 6.0

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27122?vs=75145=75277

BRANCH
  contrast_effect_background_color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27122

AFFECTED FILES
  src/desktoptheme/breeze-dark/CMakeLists.txt
  src/desktoptheme/breeze-dark/metadata.desktop.cmake
  src/desktoptheme/breeze-dark/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze-light/metadata.desktop.cmake
  src/desktoptheme/breeze/metadata.desktop.cmake
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  In D27122#608074 , @ngraham wrote:
  
  > But ultimately, don't let this become design-by-committee. This is your 
patch, and your proposal. It's good to take into account feedback, but not to 
the extent that it compromises what you're trying to accomplish in the 
interests of pleasing people who fundamentally don't like it and never will. 
You do need to maintain text legibility, but beyond that, the people who just 
don't like transparency won't be happiest with any opacity value less than 1. 
If you try to placate them, you'll be pushed in the direction of compromising 
your design vision. If your design vision is fundamentally sound, those people 
will just need to adapt a bit.
  >
  > (and I say this one of those people :) )
  
  
  Thanks for the feedback!
  My personal opinion is that something like .6 looks best, and I think the 
general feedback I got is in line with that. I will update the values 
accordingly :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/49/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 08 Feb 2020 18:29:05 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D27255: nota

[Mathis Brüchert]

mbruchert added a reviewer: camiloh.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

[Mathis Brüchert]

mbruchert added a comment.


  F8092229: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

AFFECTED FILES
  icons-dark/apps/48/nota.svg
  icons/apps/48/nota.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27220: add pix icon

[Mathis Brüchert]

mbruchert updated this revision to Diff 75270.
mbruchert added a comment.


  - change shadow color

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27220?vs=75186=75270

BRANCH
  pix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27220

AFFECTED FILES
  icons-dark/apps/48/pix.svg
  icons/apps/48/pix.svg

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

[Mathis Brüchert]

mbruchert updated this revision to Diff 75269.
mbruchert added a comment.


  - change shadow color

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27246?vs=75247=75269

BRANCH
  buho (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27246

AFFECTED FILES
  icons-dark/apps/48/buho.svg
  icons/apps/48/buho.svg

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27218: Add icon for org.kde.Ikona

[Carson Black]

cblack updated this revision to Diff 75266.
cblack added a comment.


  Drop 64px icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27218?vs=75183=75266

BRANCH
  ikona-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27218

AFFECTED FILES
  icons-dark/apps/22/org.kde.Ikona.svg
  icons-dark/apps/32/org.kde.Ikona.svg
  icons-dark/apps/48/org.kde.Ikona.svg
  icons/apps/22/org.kde.Ikona.svg
  icons/apps/32/org.kde.Ikona.svg
  icons/apps/48/org.kde.Ikona.svg

To: cblack, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27239: [android] Emit defaultActivated when tapping the notification

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:0a0efe39f898: [android] Emit defaultActivated when 
tapping the notification (authored by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27239?vs=75264=75265

REVISION DETAIL
  https://phabricator.kde.org/D27239

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  defa

REVISION DETAIL
  https://phabricator.kde.org/D27239

To: nicolasfella, #frameworks, vkrause
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26441: New icon for KTimeTracker

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:dca95f680776: New icon for KTimeTracker (authored by 
cblack).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26441?vs=74293=75263

REVISION DETAIL
  https://phabricator.kde.org/D26441

AFFECTED FILES
  icons-dark/apps/22/ktimetracker.svg
  icons-dark/apps/32/ktimetracker.svg
  icons-dark/apps/48/ktimetracker.svg
  icons/apps/22/ktimetracker.svg
  icons/apps/32/ktimetracker.svg
  icons/apps/48/ktimetracker.svg

To: cblack, #vdg, ndavis
Cc: hellcp, ndavis, kde-frameworks-devel, aspotashev, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

[Nicolas Fella]

nicolasfella updated this revision to Diff 75264.
nicolasfella added a comment.


  - set correct flags

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27239?vs=75242=75264

BRANCH
  defa

REVISION DETAIL
  https://phabricator.kde.org/D27239

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Mathis Brüchert]

mbruchert added a reviewer: camiloh.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Mathis Brüchert]

mbruchert added a comment.


  F8092163: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Mathis Brüchert]

mbruchert updated this revision to Diff 75261.
mbruchert added a comment.


  - fix shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27252?vs=75260=75261

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

AFFECTED FILES
  icons-dark/apps/48/index.svg
  icons/apps/48/index.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

AFFECTED FILES
  icons-dark/apps/48/index.svg
  icons/apps/48/index.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Nathaniel Graham]

ngraham added a comment.


  But ultimately, don't let this become design-by-committee. This is your 
patch, and your proposal. It's good to take into account feedback, but not to 
the extent that it compromises what you're trying to accomplish in the 
interests of pleasing people who fundamentally don't like it and never will. 
You do need to maintain text legibility, but beyond that, the people who just 
don't like transparency won't be happiest with any opacity value less than 1. 
If you try to placate them, you'll be pushed in the direction of compromising 
your design vision. If your design vision is fundamentally sound, those people 
will just need to adapt a bit.
  
  (and I say this one of those people :) )

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Nathaniel Graham]

ngraham added a comment.


  My result was 0.644.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

License Clarification for kguiaddons/tests/openurltest.cpp

[Andreas Cord-Landwehr]

Hi Aleix,

I found the file kguiaddons/tests/openurltest.cpp with an ambiguous license 
statement about both LGPL and GPL. According to the license header, you are 
the only copyright holder and a review of the file authors resulted in only 
minor contributions by others.

Can you clarify the file license? With a look at the other files in the test 
folder, the best fitting license would be

GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL

to be consistent.

Cheers,
Andreas

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

[George Vogiatzis]

gvgeo added a comment.


  On second thought, maybe it was fine. `Layout.preferredWidth` should not have 
any effect when icon is not visible anyway. And negative value could be set if 
needed.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-pc3-toolbutton-sizing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27221

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: gvgeo, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  I personally choose 0.4 for opacity, but I was now thinking whether higher or 
lower values could be better. I took 50 screenshots in different conditions, 
but since those are a bit difficult to upload to Phab, I also made a website 
which helps you pick a value: 
https://niccolo.venerandi.com/backstage/files/opacity/compare.html - I'd 
suggest using fullscreen and trying a couple of times. It's very hacky and 
bad-written, but it's only supposed to be a quick tool.
  You can also see *all* screenshots at 
https://niccolo.venerandi.com/backstage/files/opacity/{0.2,0.4,0.5,0.6,0.8}/{1:10}.png

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27224: add Kongress icon

[Mathis Brüchert]

mbruchert added a reviewer: dkardarakos.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27224

To: mbruchert, dkardarakos
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert added a reviewer: mart.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert removed a reviewer: marcorichetta.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, marcorichetta
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert added a reviewer: marcorichetta.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, marcorichetta
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27220: add pix icon

[Mathis Brüchert]

mbruchert added a reviewer: camiloh.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27220

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

[Matej Mrenica]

mthw edited the summary of this revision.
mthw edited the test plan for this revision.
mthw added reviewers: VDG, Plasma.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27197: Add symbolic screenshot icons

[Mathis Brüchert]

mbruchert added a reviewer: lnj.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27197

To: mbruchert, lnj
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

[Matej Mrenica]

mthw updated this revision to Diff 75251.
mthw added a comment.


  Also change Dark icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27247?vs=75250=75251

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Rotate the "no symbol" for "mic muted" so it looks the same as "speakers muted"

[Matej Mrenica]

mthw created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mthw requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: buho

[Mathis Brüchert]

mbruchert added a reviewer: camiloh.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

[Mathis Brüchert]

mbruchert retitled this revision from "buho" to "add buho icon".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: buho

[Mathis Brüchert]

mbruchert added a comment.


  F8091923: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: buho

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  buho (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27246

AFFECTED FILES
  icons-dark/apps/48/buho.svg
  icons/apps/48/buho.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D27245

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX and add license text files in LICENSES
  folder as required by the REUSE specification.

REPOSITORY
  R249 KI18n

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27245

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/ki18ndeclarativetest.cpp
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  autotests/ktranscriptcleantest.cpp
  autotests/ktranscriptcleantest.h
  autotests/ktranscripttest.cpp
  autotests/ktranscripttest.h
  autotests/testhelpers.cpp
  autotests/testhelpers.h
  cmake/FindLibIntl.cmake
  cmake/KF5I18nMacros.cmake.in
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake
  cmake/kf5i18nuic.cmake
  cmake/rules_PyKF5.py
  src/common_helpers.cpp
  src/common_helpers_p.h
  src/config.h.in
  src/gettext.h
  src/kcatalog.cpp
  src/kcatalog_p.h
  src/klocalizedcontext.cpp
  src/klocalizedcontext.h
  src/klocalizedstring.cpp
  src/klocalizedstring.h
  src/klocalizedtranslator.cpp
  src/klocalizedtranslator.h
  src/ktranscript.cpp
  src/ktranscript_p.h
  src/kuitmarkup.cpp
  src/kuitmarkup.h
  src/kuitmarkup_p.h
  src/kuitsetup.h
  src/main.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

[Nicolas Fella]

nicolasfella updated this revision to Diff 75242.
nicolasfella added a comment.


  - broadcast correctly

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27239?vs=75234=75242

BRANCH
  defa

REVISION DETAIL
  https://phabricator.kde.org/D27239

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R277:5397f0651e8e: KPlotting: Convert license statements to 
SPDX (authored by cordlandwehr).

REPOSITORY
  R277 KPlotting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27234?vs=75235=75241

REVISION DETAIL
  https://phabricator.kde.org/D27234

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/kplotaxistest.cpp
  autotests/kplotobjecttest.cpp
  autotests/kplotpointtest.cpp
  autotests/kplotwidgettest.cpp
  examples/testplot_main.cpp
  examples/testplot_widget.cpp
  examples/testplot_widget.h
  src/kplotaxis.cpp
  src/kplotaxis.h
  src/kplotobject.cpp
  src/kplotobject.h
  src/kplotpoint.cpp
  src/kplotpoint.h
  src/kplotwidget.cpp
  src/kplotwidget.h

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R277 KPlotting

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27234

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr marked 3 inline comments as done.
cordlandwehr added a comment.


  Unified all license header statements without "*" markers.

REPOSITORY
  R277 KPlotting

REVISION DETAIL
  https://phabricator.kde.org/D27234

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27235: add calindori icon in the new pm style

[Mathis Brüchert]

mbruchert updated this revision to Diff 75236.
mbruchert added a comment.


  - fix radius

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27235?vs=75229=75236

BRANCH
  calindori (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27235

AFFECTED FILES
  icons-dark/apps/48/calindori.svg
  icons/apps/48/calindori.svg

To: mbruchert, dkardarakos, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75235.
cordlandwehr added a comment.


  Unify comment style for license headers

REPOSITORY
  R277 KPlotting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27234?vs=75226=75235

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27234

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/kplotaxistest.cpp
  autotests/kplotobjecttest.cpp
  autotests/kplotpointtest.cpp
  autotests/kplotwidgettest.cpp
  examples/testplot_main.cpp
  examples/testplot_widget.cpp
  examples/testplot_widget.h
  src/kplotaxis.cpp
  src/kplotaxis.h
  src/kplotobject.cpp
  src/kplotobject.h
  src/kplotpoint.cpp
  src/kplotpoint.h
  src/kplotwidget.cpp
  src/kplotwidget.h

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

[Nicolas Fella]

nicolasfella edited the test plan for this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27239

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27239: [android] Emit defaultActivated when tapping the notification

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When the user taps a notification the corresponding activity is launched. By 
emitting a signal we allow the app to react to this, e.g. open the right 
conversation in a chat app.

REPOSITORY
  R289 KNotifications

BRANCH
  defa

REVISION DETAIL
  https://phabricator.kde.org/D27239

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: nicolasfella, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> cordlandwehr wrote in testplot_main.cpp:2-5
> do you mean the "*" character in each comment line?

yes. they're added only for a couple files

REPOSITORY
  R277 KPlotting

REVISION DETAIL
  https://phabricator.kde.org/D27234

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27092: Prison: Convert license statements to SPDX identifiers

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:3a0aa5897182: Prison: Convert license statements to SPDX 
identifiers (authored by cordlandwehr).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27092?vs=74842=75233

REVISION DETAIL
  https://phabricator.kde.org/D27092

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/MIT.txt
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  autotests/reedsolomontest.cpp
  cmake/FindDmtx.cmake
  cmake/FindQRencode.cmake
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/lib/aztecbarcode.cpp
  src/lib/aztecbarcode.h
  src/lib/bitvector.cpp
  src/lib/bitvector_p.h
  src/lib/code128barcode.cpp
  src/lib/code128barcode.h
  src/lib/code39barcode.cpp
  src/lib/code39barcode.h
  src/lib/code93barcode.cpp
  src/lib/code93barcode.h
  src/lib/config-prison.h.in
  src/lib/datamatrixbarcode.cpp
  src/lib/datamatrixbarcode.h
  src/lib/prison.cpp
  src/lib/prison.h
  src/lib/qrcodebarcode.cpp
  src/lib/qrcodebarcode.h
  src/lib/reedsolomon.cpp
  src/lib/reedsolomon_p.h
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  src/quick/prisonquickplugin.cpp
  src/tools/prison-datamatrix.cpp
  tests/barcode.qml
  tests/barcodeexamplewidget.cpp
  tests/barcodeexamplewidget.h
  tests/prison.cpp

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  In D27122#607167 , @ngraham wrote:
  
  > Please add a comment in the Description section of this patch explaining 
why the previously disabled Intensity value is now enabled.
  
  
  ✓

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27238: Add an option to dynamic-break inside words

[eudoxos]

eudoxos created this revision.
eudoxos added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
eudoxos requested review of this revision.

REVISION SUMMARY
  Add option to break lines longer than view width (or static boundary, when 
dynamic-wrapping at static boundary) anywhere. It merely sets 
QTextOption::WrapAnywhere for the view, plus exposes that as checkbox in the 
config and key for saving the configuration.
  
  `QTextOption::WrapAtWordBoundaryOrAnywhere` is unfortunately very dumb, 
splitting at space only; while this might be ok for natural languages, it is 
not suitable for code: e.g. 
`if(eng->option.wrapMode()==QTextOption::WrapAtWordBoundaryOrAnywhere){` has no 
"word boundary" according the the algorithm. FYI `QTtextLayout` internally uses 
`QTextEngine::itemize()` 
[https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/text/qtextengine.cpp?h=dev#n2057](link).
  
  This patch makes a difference also for long lines "without word boundary" 
which should break anywhere as fallback (as per Qt's docs); in this fallback 
case, though ktextedit inserts zero-length line at the beginning (this is 
likely an existing but in ktextedit).
  
  Without breaking anywhere (old behavior, the default):
  F8091831: image.png 
  
  breaking anywhere:
  F8091828: image.png 
  
  (My first contribution here.)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27238

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: eudoxos
Cc: kwrite-devel, kde-frameworks-devel, cent, rrosch, LeGast00n, cblack, 
szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, head7, cullmann, 
kfunk, sars, dhaumann

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27234: KPlotting: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in testplot_main.cpp:2-5
> extra '*' ?

do you mean the "*" character in each comment line?

REPOSITORY
  R277 KPlotting

REVISION DETAIL
  https://phabricator.kde.org/D27234

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham
Cc: ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27235: add calindori icon in the new pm style

[Mathis Brüchert]

mbruchert added a reviewer: dkardarakos.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27235

To: mbruchert, dkardarakos
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27235: add calindori icon in the new pm style

[Mathis Brüchert]

mbruchert added reviewers: ndavis, ngraham.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27235

To: mbruchert, dkardarakos, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27235: add calindori icon in the new pm style

[Mathis Brüchert]

mbruchert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mbruchert requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  calindori (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27235

AFFECTED FILES
  icons-dark/apps/48/calindori.svg
  icons/apps/48/calindori.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert retitled this revision from "add kirigami-galery icon" to "add 
kirigami-gallery icon".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-galery icon

[Mathis Brüchert]

mbruchert updated this revision to Diff 75228.
mbruchert added a comment.


  - fix typo

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27223?vs=75194=75228

BRANCH
  kirigami_galery (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27223

AFFECTED FILES
  icons-dark/apps/48/kirigami-gallery.svg
  icons/apps/48/kirigami-gallery.svg

To: mbruchert
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> testplot_main.cpp:2-5
> + *
> + * SPDX-FileCopyrightText: 2006 Jason Harris 
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later

extra '*' ?

REPOSITORY
  R277 KPlotting

REVISION DETAIL
  https://phabricator.kde.org/D27234

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27092: Prison: Convert license statements to SPDX identifiers

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27092

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26931: KIdleTime: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Introduce SPDX license headers" to 
"KIdleTime: Convert license statements to SPDX".

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26931

To: cordlandwehr, cgiboudeaux
Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27091: Sonnet: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license statements to SPDX" 
to "Sonnet: Convert license statements to SPDX".

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27091

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27092: Prison: Convert license statements to SPDX identifiers

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Update license statements to SPDX 
identifiers" to "Prison: Convert license statements to SPDX identifiers".

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D27092

To: cordlandwehr
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27103: KItemModels: Convert license headers to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license headers to SPDX 
markers" to "KItemModels: Convert license headers to SPDX markers".

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D27103

To: cordlandwehr, dfaure
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27231: BluezQt: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr closed this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D27231

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27231: BluezQt: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R269 BluezQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27231

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27104: KArchive: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license statements to SPDX 
headers" to "KArchive: Convert license statements to SPDX headers".

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27104

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27158: Fix some compiler warnings

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  l-compiler-warnings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27158

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R277 KPlotting

REVISION DETAIL
  https://phabricator.kde.org/D27234

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27234: KPlotting: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX and add license text files in LICENSES
  folder as required by the REUSE specification.

REPOSITORY
  R277 KPlotting

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27234

AFFECTED FILES
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/LGPL-2.0-or-later.txt
  autotests/kplotaxistest.cpp
  autotests/kplotobjecttest.cpp
  autotests/kplotpointtest.cpp
  autotests/kplotwidgettest.cpp
  examples/testplot_main.cpp
  examples/testplot_widget.cpp
  examples/testplot_widget.h
  src/kplotaxis.cpp
  src/kplotaxis.h
  src/kplotobject.cpp
  src/kplotobject.h
  src/kplotpoint.cpp
  src/kplotpoint.h
  src/kplotwidget.cpp
  src/kplotwidget.h

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27231: BluezQt: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license statements to SPDX" 
to "BluezQt: Convert license statements to SPDX".

REPOSITORY
  R269 BluezQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27231

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27106: Attica: Convert license statements to SPDX markers

[Andreas Cord-Landwehr]

cordlandwehr retitled this revision from "Convert license statements to SPDX 
markers" to "Attica: Convert license statements to SPDX markers".

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27231: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr marked an inline comment as done.

REPOSITORY
  R269 BluezQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27231

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27231: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr updated this revision to Diff 75223.
cordlandwehr added a comment.


  Add missing newline

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27231?vs=75217=75223

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27231

AFFECTED FILES
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/adaptertest.cpp
  autotests/adaptertest.h
  autotests/agentmanagertest.cpp
  autotests/agentmanagertest.h
  autotests/autotests.cpp
  autotests/autotests.h
  autotests/batterytest.cpp
  autotests/batterytest.h
  autotests/devicetest.cpp
  autotests/devicetest.h
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/agentmanager.cpp
  autotests/fakebluez/agentmanager.h
  autotests/fakebluez/batteryinterface.cpp
  autotests/fakebluez/batteryinterface.h
  autotests/fakebluez/deviceinterface.cpp
  autotests/fakebluez/deviceinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/inputinterface.cpp
  autotests/fakebluez/inputinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/fakebluez/main.cpp
  autotests/fakebluez/mediainterface.cpp
  autotests/fakebluez/mediainterface.h
  autotests/fakebluez/mediaplayerinterface.cpp
  autotests/fakebluez/mediaplayerinterface.h
  autotests/fakebluez/mediatransportinterface.cpp
  autotests/fakebluez/mediatransportinterface.h
  autotests/fakebluez/obexagentmanager.cpp
  autotests/fakebluez/obexagentmanager.h
  autotests/fakebluez/obexclient.cpp
  autotests/fakebluez/obexclient.h
  autotests/fakebluez/object.cpp
  autotests/fakebluez/object.h
  autotests/fakebluez/objectmanager.cpp
  autotests/fakebluez/objectmanager.h
  autotests/fakebluez/profilemanager.cpp
  autotests/fakebluez/profilemanager.h
  autotests/fakebluez/testinterface.cpp
  autotests/fakebluez/testinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/inputtest.cpp
  autotests/inputtest.h
  autotests/jobstest.cpp
  autotests/jobstest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  autotests/managertest.cpp
  autotests/managertest.h
  autotests/mediaplayertest.cpp
  autotests/mediaplayertest.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  autotests/mediatransporttest.cpp
  autotests/mediatransporttest.h
  autotests/obexmanagertest.cpp
  autotests/obexmanagertest.h
  autotests/qml/tst_adapter.qml
  autotests/qml/tst_device.qml
  autotests/qml/tst_input.qml
  autotests/qml/tst_manager.qml
  autotests/qml/tst_mediaplayer.qml
  autotests/qmltests.cpp
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/agent.cpp
  src/agent.h
  src/agentadaptor.cpp
  src/agentadaptor.h
  src/battery.cpp
  src/battery.h
  src/battery_p.h
  src/bluezqt_dbustypes.h
  src/device.cpp
  src/device.h
  src/device_p.cpp
  src/device_p.h
  src/devicesmodel.cpp
  src/devicesmodel.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/imports/DevicesModel.qml
  src/imports/bluezqtextensionplugin.cpp
  src/imports/bluezqtextensionplugin.h
  src/imports/declarativeadapter.cpp
  src/imports/declarativeadapter.h
  src/imports/declarativebattery.cpp
  src/imports/declarativebattery.h
  src/imports/declarativedevice.cpp
  src/imports/declarativedevice.h
  src/imports/declarativedevicesmodel.cpp
  src/imports/declarativedevicesmodel.h
  src/imports/declarativeinput.cpp
  src/imports/declarativeinput.h
  src/imports/declarativemanager.cpp
  src/imports/declarativemanager.h
  src/imports/declarativemediaplayer.cpp
  src/imports/declarativemediaplayer.h
  src/initmanagerjob.cpp
  src/initmanagerjob.h
  src/initobexmanagerjob.cpp
  src/initobexmanagerjob.h
  src/input.cpp
  src/input.h
  src/input_p.h
  src/job.cpp
  src/job.h
  src/job_p.h
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  src/leadvertisingmanager.h
  src/leadvertisingmanager_p.h
  src/macros.h
  src/manager.cpp
  src/manager.h
  src/manager_p.cpp
  

D27231: Convert license statements to SPDX

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  LGTM once the license file is fixed

INLINE COMMENTS

> LicenseRef-KDE-Accepted-LGPL.txt:13
> +GNU General Public License for more details.
> \ No newline at end of file


missing newline

REPOSITORY
  R269 BluezQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27231

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27106: Convert license statements to SPDX markers

[David Faure]

dfaure added a comment.


  Can you add the repository name in the title of the review request? Otherwise 
they all look the same in emails.

REPOSITORY
  R235 Attica

REVISION DETAIL
  https://phabricator.kde.org/D27106

To: cordlandwehr
Cc: dfaure, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  The approach makes sense to me.

INLINE COMMENTS

> kmountpoint.cpp:420
> +#else
> +const QString realname = path;
>  #endif

You should rename this variable, it's no longer the result of 
canonicalFilePath() (also called "realpath" in glibc).

> kmountpoint.h:45
> + * making this function non-blocking, or try to return the real final 
> mount point potentially blocking
> + * if a network filesystem is unresponsive
> + */

Missing @since

> kmountpoint.h:68
>   */
> -Ptr findByPath(const QString ) const;
> +Ptr findByPath(const QString , FindByPathFlag flag = 
> RealMountPoint) const;
>  

This is BIC, you changed the signature of an existing exported method.

You need to overload it, instead.
i.e. add a method with two args, and a comment like

  // TODO KF6 merge with the above method using RealMountPoint as default value

(and a @since flag of course)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27231: Convert license statements to SPDX

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license statements to SPDX and add license text files in LICENSES
  folder as required by the REUSE specification.

REPOSITORY
  R269 BluezQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27231

AFFECTED FILES
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/adaptertest.cpp
  autotests/adaptertest.h
  autotests/agentmanagertest.cpp
  autotests/agentmanagertest.h
  autotests/autotests.cpp
  autotests/autotests.h
  autotests/batterytest.cpp
  autotests/batterytest.h
  autotests/devicetest.cpp
  autotests/devicetest.h
  autotests/fakebluez/adapterinterface.cpp
  autotests/fakebluez/adapterinterface.h
  autotests/fakebluez/agentmanager.cpp
  autotests/fakebluez/agentmanager.h
  autotests/fakebluez/batteryinterface.cpp
  autotests/fakebluez/batteryinterface.h
  autotests/fakebluez/deviceinterface.cpp
  autotests/fakebluez/deviceinterface.h
  autotests/fakebluez/devicemanager.cpp
  autotests/fakebluez/devicemanager.h
  autotests/fakebluez/fakebluez.cpp
  autotests/fakebluez/fakebluez.h
  autotests/fakebluez/gattmanagerinterface.cpp
  autotests/fakebluez/gattmanagerinterface.h
  autotests/fakebluez/inputinterface.cpp
  autotests/fakebluez/inputinterface.h
  autotests/fakebluez/leadvertisingmanagerinterface.cpp
  autotests/fakebluez/leadvertisingmanagerinterface.h
  autotests/fakebluez/main.cpp
  autotests/fakebluez/mediainterface.cpp
  autotests/fakebluez/mediainterface.h
  autotests/fakebluez/mediaplayerinterface.cpp
  autotests/fakebluez/mediaplayerinterface.h
  autotests/fakebluez/mediatransportinterface.cpp
  autotests/fakebluez/mediatransportinterface.h
  autotests/fakebluez/obexagentmanager.cpp
  autotests/fakebluez/obexagentmanager.h
  autotests/fakebluez/obexclient.cpp
  autotests/fakebluez/obexclient.h
  autotests/fakebluez/object.cpp
  autotests/fakebluez/object.h
  autotests/fakebluez/objectmanager.cpp
  autotests/fakebluez/objectmanager.h
  autotests/fakebluez/profilemanager.cpp
  autotests/fakebluez/profilemanager.h
  autotests/fakebluez/testinterface.cpp
  autotests/fakebluez/testinterface.h
  autotests/gattmanagertest.cpp
  autotests/gattmanagertest.h
  autotests/inputtest.cpp
  autotests/inputtest.h
  autotests/jobstest.cpp
  autotests/jobstest.h
  autotests/leadvertisingmanagertest.cpp
  autotests/leadvertisingmanagertest.h
  autotests/managertest.cpp
  autotests/managertest.h
  autotests/mediaplayertest.cpp
  autotests/mediaplayertest.h
  autotests/mediatest.cpp
  autotests/mediatest.h
  autotests/mediatransporttest.cpp
  autotests/mediatransporttest.h
  autotests/obexmanagertest.cpp
  autotests/obexmanagertest.h
  autotests/qml/tst_adapter.qml
  autotests/qml/tst_device.qml
  autotests/qml/tst_input.qml
  autotests/qml/tst_manager.qml
  autotests/qml/tst_mediaplayer.qml
  autotests/qmltests.cpp
  src/a2dp-codecs.c
  src/a2dp-codecs.h
  src/adapter.cpp
  src/adapter.h
  src/adapter_p.cpp
  src/adapter_p.h
  src/agent.cpp
  src/agent.h
  src/agentadaptor.cpp
  src/agentadaptor.h
  src/battery.cpp
  src/battery.h
  src/battery_p.h
  src/bluezqt_dbustypes.h
  src/device.cpp
  src/device.h
  src/device_p.cpp
  src/device_p.h
  src/devicesmodel.cpp
  src/devicesmodel.h
  src/gattapplication.cpp
  src/gattapplication.h
  src/gattapplication_p.cpp
  src/gattapplication_p.h
  src/gattcharacteristic.cpp
  src/gattcharacteristic.h
  src/gattcharacteristic_p.cpp
  src/gattcharacteristic_p.h
  src/gattcharacteristicadaptor.cpp
  src/gattcharacteristicadaptor.h
  src/gattmanager.cpp
  src/gattmanager.h
  src/gattmanager_p.cpp
  src/gattmanager_p.h
  src/gattservice.cpp
  src/gattservice.h
  src/gattservice_p.cpp
  src/gattservice_p.h
  src/gattserviceadaptor.cpp
  src/gattserviceadaptor.h
  src/imports/DevicesModel.qml
  src/imports/bluezqtextensionplugin.cpp
  src/imports/bluezqtextensionplugin.h
  src/imports/declarativeadapter.cpp
  src/imports/declarativeadapter.h
  src/imports/declarativebattery.cpp
  src/imports/declarativebattery.h
  src/imports/declarativedevice.cpp
  src/imports/declarativedevice.h
  src/imports/declarativedevicesmodel.cpp
  src/imports/declarativedevicesmodel.h
  src/imports/declarativeinput.cpp
  src/imports/declarativeinput.h
  src/imports/declarativemanager.cpp
  src/imports/declarativemanager.h
  src/imports/declarativemediaplayer.cpp
  src/imports/declarativemediaplayer.h
  src/initmanagerjob.cpp
  src/initmanagerjob.h
  src/initobexmanagerjob.cpp
  src/initobexmanagerjob.h
  src/input.cpp
  src/input.h
  src/input_p.h
  src/job.cpp
  src/job.h
  src/job_p.h
  src/leadvertisement.cpp
  src/leadvertisement.h
  src/leadvertisement_p.cpp
  src/leadvertisement_p.h
  src/leadvertisementadaptor.cpp
  src/leadvertisementadaptor.h
  src/leadvertisingmanager.cpp
  

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven added a comment.


  We might want to use Solid instead since it is capable of sending signals 
when mnttab is updated, rather than like here having a mount point list updated 
every 5 seconds.
  With this code we might have issues with potential run condition : when there 
is a mount within the 5 seconds cache refresh window and this function is 
called, it will return incorrect data by default mount point for / .
  If this filesystem becomes unresponsive right away, this will cause a freeze 
because the slowness state would be incorrect.
  
  And a great thing I learned more about at Fosdem, there is a new upcoming 
Linux API io_uring https://lwn.net/Articles/810414/ that will allow us to make 
asynchronous statx calls with timeout (linux 5.6+), making dealing with 
unresponsive file system that much easier.
  
  In the meantime this works.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26407

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27218: Add icon for org.kde.Ikona

[Noah Davis]

ndavis added a comment.


  JFYI, the 64px versions of app icons are currently unused.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27218

To: cblack, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D26407: KFileItem: Improve isSlow to not block when a network mount is unresponsive, make SkipMimeTypeFromContent skip only on slow fs

[Méven Car]

meven updated this revision to Diff 75216.
meven added a comment.


  Add a enum parameter to findByPath to choose its behavior regarding returning 
first slow path

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26407?vs=73836=75216

BRANCH
  arcpatch-D26407

REVISION DETAIL
  https://phabricator.kde.org/D26407

AFFECTED FILES
  src/core/kfileitem.cpp
  src/core/kmountpoint.cpp
  src/core/kmountpoint.h

To: meven, #frameworks, ngraham, broulik, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27185: Use the right translation catalog to show translations

[Yuri Chornoivan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:8f382ef18606: Use the right translation catalog to show 
translations (authored by yurchor).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27185?vs=75082=75214#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27185?vs=75082=75214

REVISION DETAIL
  https://phabricator.kde.org/D27185

AFFECTED FILES
  src/qtquick/qml/Button.qml
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/DownloadItemsSheet.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/NewStuffList.qml
  src/qtquick/qml/Page.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/GridTileDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

To: yurchor, #frameworks, #localization, davidedmundson
Cc: davidedmundson, victorr, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27104: Convert license statements to SPDX headers

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:8c40c6f028b3: Convert license statements to SPDX headers 
(authored by cordlandwehr).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27104?vs=74862=75213

REVISION DETAIL
  https://phabricator.kde.org/D27104

AFFECTED FILES
  LICENSES/BSD-2-Clause.txt
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/deprecatedtest.cpp
  autotests/karchivetest.cpp
  autotests/karchivetest.h
  autotests/kcompressiondevicetest.cpp
  autotests/kcompressiondevicetest.h
  autotests/kfiltertest.cpp
  autotests/kfiltertest.h
  autotests/klimitediodevicetest.cpp
  autotests/klimitediodevicetest.h
  examples/bzip2gzip/main.cpp
  examples/helloworld/main.cpp
  examples/tarlocalfiles/main.cpp
  examples/unzipper/main.cpp
  src/k7zip.cpp
  src/k7zip.h
  src/kar.cpp
  src/kar.h
  src/karchive.cpp
  src/karchive.h
  src/karchive_p.h
  src/karchivedirectory.h
  src/karchiveentry.h
  src/karchivefile.h
  src/kbzip2filter.cpp
  src/kbzip2filter.h
  src/kcompressiondevice.cpp
  src/kcompressiondevice.h
  src/kcompressiondevice_p.h
  src/kfilterbase.cpp
  src/kfilterbase.h
  src/kfilterdev.cpp
  src/kfilterdev.h
  src/kgzipfilter.cpp
  src/kgzipfilter.h
  src/klimitediodevice.cpp
  src/klimitediodevice_p.h
  src/knonefilter.cpp
  src/knonefilter.h
  src/krcc.cpp
  src/krcc.h
  src/ktar.cpp
  src/ktar.h
  src/kxzfilter.cpp
  src/kxzfilter.h
  src/kzip.cpp
  src/kzip.h
  src/kzipfileentry.h
  tests/k7ziptest.cpp
  tests/kartest.cpp
  tests/krcctest.cpp
  tests/ktartest.cpp
  tests/kziptest.cpp

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27091: Convert license statements to SPDX

[Andreas Cord-Landwehr]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:857bb8eb4173: Convert license statements to SPDX 
(authored by cordlandwehr).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27091?vs=74841=75212

REVISION DETAIL
  https://phabricator.kde.org/D27091

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-or-later.txt
  autotests/test_core.cpp
  autotests/test_core.h
  autotests/test_filter.cpp
  autotests/test_filter.h
  autotests/test_highlighter.cpp
  autotests/test_settings.cpp
  autotests/test_settings.h
  autotests/test_suggest.cpp
  cmake/FindENCHANT.cmake
  cmake/FindHUNSPELL.cmake
  data/gentrigrams.cpp
  data/parsetrigrams.cpp
  examples/configdialog.cpp
  examples/dialogexample.cpp
  examples/dialogexample.h
  examples/dictionarycombobox.cpp
  examples/highlighterexample.cpp
  examples/highlighterexample.h
  examples/plaintextedit.cpp
  examples/textedit.cpp
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h
  src/core/backgroundchecker_p.h
  src/core/client.cpp
  src/core/client_p.h
  src/core/guesslanguage.cpp
  src/core/guesslanguage.h
  src/core/languagefilter.cpp
  src/core/languagefilter_p.h
  src/core/loader.cpp
  src/core/loader_p.h
  src/core/settings.cpp
  src/core/settings_p.h
  src/core/speller.cpp
  src/core/speller.h
  src/core/spellerplugin.cpp
  src/core/spellerplugin_p.h
  src/core/textbreaks.cpp
  src/core/textbreaks_p.h
  src/core/tokenizer.cpp
  src/core/tokenizer_p.h
  src/plugins/aspell/aspellclient.cpp
  src/plugins/aspell/aspellclient.h
  src/plugins/aspell/aspelldict.cpp
  src/plugins/aspell/aspelldict.h
  src/plugins/enchant/enchantclient.cpp
  src/plugins/enchant/enchantclient.h
  src/plugins/enchant/enchantdict.cpp
  src/plugins/enchant/enchantdict.h
  src/plugins/hspell/hspellclient.cpp
  src/plugins/hspell/hspellclient.h
  src/plugins/hspell/hspelldict.cpp
  src/plugins/hspell/hspelldict.h
  src/plugins/hunspell/hunspellclient.cpp
  src/plugins/hunspell/hunspellclient.h
  src/plugins/hunspell/hunspelldict.cpp
  src/plugins/hunspell/hunspelldict.h
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerclient.h
  src/plugins/ispellchecker/ispellcheckerdict.cpp
  src/plugins/ispellchecker/ispellcheckerdict.h
  src/plugins/nsspellchecker/nsspellcheckerclient.h
  src/plugins/nsspellchecker/nsspellcheckerclient.mm
  src/plugins/nsspellchecker/nsspellcheckerdict.h
  src/plugins/nsspellchecker/nsspellcheckerdict.mm
  src/plugins/voikko/voikkoclient.cpp
  src/plugins/voikko/voikkoclient.h
  src/plugins/voikko/voikkodict.cpp
  src/plugins/voikko/voikkodict.h
  src/ui/configdialog.cpp
  src/ui/configdialog.h
  src/ui/configwidget.cpp
  src/ui/configwidget.h
  src/ui/dialog.cpp
  src/ui/dialog.h
  src/ui/dictionarycombobox.cpp
  src/ui/dictionarycombobox.h
  src/ui/highlighter.cpp
  src/ui/highlighter.h
  src/ui/spellcheckdecorator.cpp
  src/ui/spellcheckdecorator.h
  tests/backgroundtest.cpp
  tests/backgroundtest.h

To: cordlandwehr, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns