KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/8/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 12 Feb 2020 01:40:25 +
 Build duration:
6 hr 9 min and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 305 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/305/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 12 Feb 2020 06:13:17 +
 Build duration:
1 hr 24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34819/62088)40%
(17679/43868)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9723/10183)47%
(4541/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8731/14619)51%
(4518/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8330)43%
(2076/4808)src.gui100%
(2/2)100%
(2/2)89%
(96/108)68%
(45/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1785/4288)36%
(1293/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
  

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

cullmann updated this revision to Diff 75513.
cullmann added a comment.


  de-init com after interface got released, avoids crash

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27332?vs=75497&id=75513

BRANCH
  arcpatch-D27332

REVISION DETAIL
  https://phabricator.kde.org/D27332

AFFECTED FILES
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerdict.cpp

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

cullmann added a comment.


  :=) I think the issue is even much smaller, I just call un-init before 
release, that is wrong :/
  I will quickfix that and avoid other changes (beside the extra nullptr 
checks).

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27332

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 61 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/61/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:19:27 +
 Build duration:
1 hr 6 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 113 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/113/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 12 Feb 2020 06:09:37 +
 Build duration:
1 hr 14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.68.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6928/9111)43%
(10797/24836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2898/2990)49%
(6194/12720)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/798)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/63/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 12 Feb 2020 06:07:28 +
 Build duration:
1 hr 8 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/53/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:17:31 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 90 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/90/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 06:17:52 +
 Build duration:
50 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.68.0.xmllogs/KF5WindowSystem/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)79%
(44/56)79%
(44/56)74%
(7277/9881)55%
(3547/6505)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)98%
(3083/3162)53%
(1300/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src86%
(12/14)86%
(12/14)53%
(819/1534)42%
(302/718)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(16/17)94%
(16/17)70%
(3368/4827)59%
(1942/3277)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/34/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:16:10 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/55/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:15:21 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 430 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/430/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 06:13:17 +
 Build duration:
38 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiogui_favicontestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34816/62088)40%
(17679/43872)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9721/10183)47%
(4540/9636)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8730/14619)51%
(4517/8853)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4689/8330)43%
(2078/4812)src.gui100%
(2/2)100%
(2/2)89%
(96/108)68%
(45/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1785/4288)36%
(1293/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 297 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/297/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:13:17 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiogui_favicontestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/32/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:12:53 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_read_hdr

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:10:36 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/60/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:10:20 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/78/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:10:02 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/108/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 06:09:37 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/97/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 06:07:29 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D27238: Add an option to dynamic-break inside words

[eudoxos]

eudoxos updated this revision to Diff 75509.
eudoxos added a comment.


  Change config key to `dynamic-word-wrap-anywhere` as suggested.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27238?vs=75231&id=75509

REVISION DETAIL
  https://phabricator.kde.org/D27238

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: eudoxos, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, 
LeGast00n, cblack, szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, 
head7, kfunk, sars

D25743: Expose IndexerState enum to QML

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, bruns, abrahams

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/7/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 12 Feb 2020 04:20:41 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.solidhwtest

D27263: RFC: Accent colour for KColorScheme

[Nathaniel Graham]

ngraham added a comment.


  Looks like plasma doesn't respect the accent color.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27263

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/6/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 12 Feb 2020 04:01:41 +
 Build duration:
3 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 187 lines...][2020-02-12T04:05:13.421Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2020-02-12T04:05:13.421Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2020-02-12T04:05:13.421Z] VSCMD_ARG_TGT_ARCH= 'x64'[2020-02-12T04:05:13.421Z] VSCMD_VER = '16.4.3'[2020-02-12T04:05:13.421Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2020-02-12T04:05:13.421Z] WINDIR= 'C:\Windows'[2020-02-12T04:05:13.421Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.18362.0'[2020-02-12T04:05:13.421Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2020-02-12T04:05:13.421Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2020-02-12T04:05:13.421Z] WINDOWSSDKLIBVERSION  = '10.0.18362.0\'[2020-02-12T04:05:13.421Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\'[2020-02-12T04:05:13.421Z] WINDOWSSDKVERSION = '10.0.18362.0\'[2020-02-12T04:05:13.421Z] WORKSPACE = 'C:/CI/Job Build'[2020-02-12T04:05:13.421Z] __DOTNET_ADD_64BIT= '1'[2020-02-12T04:05:13.421Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-02-12T04:05:13.421Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-02-12T04:05:13.421Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\solid;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-02-12T04:05:13.421Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\solid\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-12T04:05:13.421Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-02-12T04:05:13.421Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-02-12T04:05:13.421Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-02-12T04:05:13.421Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\solid\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-12T04:05:13.421Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-12T04:05:13.421Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-12T04:05:13.421Z] [2020-02-12T04:05:13.421Z] [2020-02-12T04:05:13.421Z] == Commencing Configuration:[2020-02-12T04:05:13.421Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/solid/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-02-12T04:05:13.682Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-02-12T04:05:13.941Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-02-12T04:05:13.941Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-12T04:05:14.633Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-12T04:05:14.633Z] -- Detecting C compiler ABI info[2020-02-12T04:05:14.633Z] -- Detecting C compiler ABI info - done[2020-02-12T04:05:14.633Z] -- Detecting C compile features[2020-02-12T04:05:14.893Z] -- Detecting C compile features - done[2020-02-12T04:05:14.893Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-12T04:05:15.463Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-12T04:05:15.463Z] -- Detecting CXX compiler ABI info[2020-02-12T04:05:15.723Z] -- Detecting CXX compiler ABI info - done[2020-02-12T04:05:15.723Z] -- Detecting CXX compile features[2020-02-12T04:05:15.983Z] -- Detecting CXX compile features - done[2020-02-12T04:05:15.983Z] -- [2020-02-12T04:05:1

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/96/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 12 Feb 2020 03:54:47 +
 Build duration:
3 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/62/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 12 Feb 2020 03:54:48 +
 Build duration:
3 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.tests.ECMPoQmToolsTestFailed: projectroot.tests.GenerateSipBindingsName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

D27293: smb: do not map uid and gid

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug212801

REVISION DETAIL
  https://phabricator.kde.org/D27293

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/60/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 02:56:27 +
 Build duration:
1 min 30 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.14/5/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Wed, 12 Feb 2020 02:56:27 +
 Build duration:
26 sec and counting
   CONSOLE OUTPUT
  [...truncated 185 lines...][2020-02-12T02:56:48.682Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2020-02-12T02:56:48.682Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2020-02-12T02:56:48.683Z] VSCMD_ARG_TGT_ARCH= 'x64'[2020-02-12T02:56:48.683Z] VSCMD_VER = '16.4.3'[2020-02-12T02:56:48.683Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2020-02-12T02:56:48.683Z] WINDIR= 'C:\Windows'[2020-02-12T02:56:48.683Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.18362.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.18362.0'[2020-02-12T02:56:48.683Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2020-02-12T02:56:48.683Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2020-02-12T02:56:48.683Z] WINDOWSSDKLIBVERSION  = '10.0.18362.0\'[2020-02-12T02:56:48.683Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\'[2020-02-12T02:56:48.683Z] WINDOWSSDKVERSION = '10.0.18362.0\'[2020-02-12T02:56:48.683Z] WORKSPACE = 'C:/CI/Job Build'[2020-02-12T02:56:48.683Z] __DOTNET_ADD_64BIT= '1'[2020-02-12T02:56:48.683Z] __DOTNET_PREFERRED_BITNESS = '64'[2020-02-12T02:56:48.683Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python38\Scripts\;C:\Program Files\Python38\;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2020-02-12T02:56:48.683Z] CMAKE_PREFIX_PATH = 'C:\CI\Software Installs\solid;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils'[2020-02-12T02:56:48.683Z] XDG_DATA_DIRS = 'C:\CI\Software Installs\solid\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-12T02:56:48.683Z] PKG_CONFIG_PATH   = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\pkgconfig;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\lib\pkgconfig'[2020-02-12T02:56:48.683Z] QT_PLUGIN_PATH= 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\lib\qca-qt5;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\bin\plugins'[2020-02-12T02:56:48.683Z] QMAKEFEATURES = 'C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\mkspecs/features'[2020-02-12T02:56:48.683Z] QT_DATA_DIRS  = 'C:\CI\Software Installs\solid\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\share;C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\share'[2020-02-12T02:56:48.683Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-12T02:56:48.683Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-12T02:56:48.683Z] [2020-02-12T02:56:48.683Z] [2020-02-12T02:56:48.683Z] == Commencing Configuration:[2020-02-12T02:56:48.683Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="C:/CI/Software Installs/solid/" -G "Ninja" -DBUILD_QCH=TRUE "C:\CI\Job Build"[2020-02-12T02:56:48.942Z] -- The C compiler identification is MSVC 19.24.28315.0[2020-02-12T02:56:49.202Z] -- The CXX compiler identification is MSVC 19.24.28315.0[2020-02-12T02:56:49.202Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-12T02:56:49.776Z] -- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-12T02:56:49.776Z] -- Detecting C compiler ABI info[2020-02-12T02:56:50.035Z] -- Detecting C compiler ABI info - done[2020-02-12T02:56:50.035Z] -- Detecting C compile features[2020-02-12T02:56:50.604Z] -- Detecting C compile features - done[2020-02-12T02:56:50.604Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe[2020-02-12T02:56:50.863Z] -- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Tools/MSVC/14.24.28314/bin/Hostx64/x64/cl.exe -- works[2020-02-12T02:56:50.863Z] -- Detecting CXX compiler ABI info[2020-02-12T02:56:51.124Z] -- Detecting CXX compiler ABI info - done[2020-02-12T02:56:51.124Z] -- Detecting CXX compile features[2020-02-12T02:56:51.385Z] -- Detecting CXX compile features - done[2020-02-12T02:56:51.385Z] -- [2020-02-12T02:56:51.385Z

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol added a dependent revision: D27339: Implement input methods.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27338

To: apol, #kwin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/52/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 12 Feb 2020 01:40:25 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

D27218: Add icon for org.kde.Ikona

[Carson Black]

cblack updated this revision to Diff 75506.
cblack added a comment.


  Update style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27218?vs=75266&id=75506

BRANCH
  ikona-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27218

AFFECTED FILES
  icons-dark/apps/48/org.kde.Ikona.svg
  icons/apps/48/org.kde.Ikona.svg

To: cblack, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27338: Provide an initial implementation for input-method-unstable-v1

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: KWin, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Makes it possible to implement the protocol in your favourite
  compositor.

TEST PLAN
  Used it with maliit and weston-keyboard

REPOSITORY
  R127 KWayland

BRANCH
  apol/inputmethod

REVISION DETAIL
  https://phabricator.kde.org/D27338

AFFECTED FILES
  CMakeLists.txt
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/inputmethod_interface.cpp
  src/server/inputmethod_interface.h

To: apol, #kwin, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27334: Fix pri file: have qmake name of QtGui as dep, to not fail with CamelCase includes

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: svuorela.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R280 Prison

BRANCH
  prifixesreview

REVISION DETAIL
  https://phabricator.kde.org/D27334

AFFECTED FILES
  src/lib/CMakeLists.txt

To: kossebau, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27200: Make the attached property a simple QObject

[David Edmundson]

davidedmundson added a comment.


  The component changes seem unrelated

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27200

To: mart, bshah, #plasma
Cc: davidedmundson, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

cullmann added a comment.


  I played a bit with it.
  No idea why I get crash reports over the store and can't see this locally.
  Given the docs state one shall not do the de-init during unloading but sonnet 
handles the clients/spellers via some global static that could be a reason...

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27332

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27238: Add an option to dynamic-break inside words

[Christoph Cullmann]

cullmann added a comment.


  Hmm, not sure.
  Given we have everywhere at the moment the dynamic/static word wrap wording, 
I would rather stick with that.
  
  for me the menu reads "View -> Word Wrap -> Dynamic Word Wrap", too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27238

To: eudoxos, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, 
LeGast00n, cblack, szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, 
head7, kfunk, sars

D27238: Add an option to dynamic-break inside words

[eudoxos]

eudoxos added a comment.


  In D27238#609494 , @cullmann wrote:
  
  > I am ok with this.
  >  Thought I would like to have a more consistent name for the config key.
  >  We have already "dynamic-word-wrap", I would like 
"dynamic-word-wrap-anywhere" better than the abbreviated "dyn-wrap-anywhere"
  
  
  No problem. While I am at fixing that, would not "dynamic-wrap", 
"dynamic-wrap-anywhere", ... fit better? It is lines which are wrapped after 
all, not words. There might be more options like that later (working on that) 
and it will be harder to change later.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27238

To: eudoxos, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, 
LeGast00n, cblack, szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, 
head7, kfunk, sars

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

cullmann updated this revision to Diff 75497.
cullmann added a comment.


  - skip com init/deinit

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27332?vs=75492&id=75497

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27332

AFFECTED FILES
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerclient.h
  src/plugins/ispellchecker/ispellcheckerdict.cpp

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24401: Use exposed DBus methods to switch activities in CLI

[Christian Muehlhaeuser]

muesli added a comment.


  @ivan @ngraham Ok, with 5.18 out I think we can finally review this one :-)

REPOSITORY
  R6 KActivities

REVISION DETAIL
  https://phabricator.kde.org/D24401

To: muesli, ivan
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

cullmann added reviewers: Frameworks, vonreth.
cullmann added a comment.


  See crash reports in Windows store.
  For me locally, it seemed to work :/

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27332

To: cullmann, #frameworks, vonreth
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27332: try to fix issue with ispellchecker on windows

[Christoph Cullmann]

cullmann created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  de-init com after release, try to better ensure we check for nullptr
  
  see e.g. backtrace
  
  0 sonnet_ispellchecker.dll
ISpellCheckerClient::~ISpellCheckerClient
  1 sonnet_ispellchecker.dllISpellCheckerClient::`scalar deleting 
destructor'
  2 Qt5Core.dll QLibraryPrivate::unload
  3 Qt5Core.dll QLibraryStore::cleanup
  4 Qt5Core.dll `anonymous namespace'::`dynamic atexit destructor for 
'qlibraryCleanup_dtor_instance_''
  5 ucrtbase.dll_lambda_f03950bc5685219e0bcd2087efbe011e_::operator
  6 ucrtbase.dll__crt_seh_guarded_call_int_::operator
  7 ucrtbase.dll_execute_onexit_table
  8 Qt5Core.dll dllmain_crt_process_detach
  9 Qt5Core.dll dllmain_dispatch
  10ntdll.dll   LdrpCallInitRoutine
  11ntdll.dll   LdrShutdownProcess
  12ntdll.dll   RtlExitUserProcess
  13kernel32.dllFatalExit
  14ucrtbase.dllexit_or_terminate_process
  15ucrtbase.dllcommon_exit
  16kate.exe__scrt_common_main_seh
  17kernel32.dllBaseThreadInitThunk
  18ntdll.dll   RtlUserThreadStart

REPOSITORY
  R246 Sonnet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27332

AFFECTED FILES
  src/plugins/ispellchecker/ispellcheckerclient.cpp
  src/plugins/ispellchecker/ispellcheckerdict.cpp

To: cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Carson Black]

cblack added subscribers: ndavis, cblack.
cblack accepted this revision as: VDG.
cblack added a comment.


  This icon is visually nice, but it doesn't look 100% Breeze-y to me. I would 
see what feedback @ndavis has for the icon.

REPOSITORY
  R266 Breeze Icons

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh, #vdg
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27252: add maui index icon in pm style

[Camilo Higuita]

camiloh accepted this revision.
camiloh added a comment.
This revision is now accepted and ready to land.


  I like it

REPOSITORY
  R266 Breeze Icons

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

[Camilo Higuita]

camiloh accepted this revision.
camiloh added a comment.
This revision is now accepted and ready to land.


  Looks extra nice and appropriate

REPOSITORY
  R266 Breeze Icons

BRANCH
  buho (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27224: add Kongress icon

[Mathis Brüchert]

mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27224

To: mbruchert, dkardarakos, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27246: add buho icon

[Mathis Brüchert]

mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27235: add calindori icon in the new pm style

[Mathis Brüchert]

mbruchert edited reviewers, added: VDG; removed: ndavis, ngraham.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27235

To: mbruchert, dkardarakos, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Mathis Brüchert]

mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Mathis Brüchert]

mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

[Mathis Brüchert]

mbruchert added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27313: Add syntax highlighting for Solidity

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:fd345c7338fb: Add syntax highlighting for Solidity 
(authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27313?vs=75437&id=75489

REVISION DETAIL
  https://phabricator.kde.org/D27313

AFFECTED FILES
  autotests/folding/test.sol.fold
  autotests/html/test.sol.html
  autotests/input/test.sol
  autotests/reference/test.sol.ref
  data/syntax/solidity.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27313: Add syntax highlighting for Solidity

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, thanks for taking care!
  Let's merge this.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-solidity

REVISION DETAIL
  https://phabricator.kde.org/D27313

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:bae7a9dd2361: [FileIndexScheduler] Force evaluation of 
indexerState after suspend/resume (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27326?vs=75479&id=75487

REVISION DETAIL
  https://phabricator.kde.org/D27326

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

[Niccolò Venerandi]

niccolove added a comment.


  In D27122#609276 , @ndavis wrote:
  
  > I think rather than adjusting hardcoded opacity in the SVGs, we need to 
make configurable plasmashell opacity a reality. Then, if we want to do an 
effect like what Nate described, we could have a way to automatically adjust 
the global plasmashell opacity.
  
  
  I agree, but I think this kind of fall outside the scope of this patch 
(change the default plasma look), also because even with the slider, the above 
problems would persist. Rather, I was discussing that in the last post of 
https://phabricator.kde.org/T11925
  
  > @niccolove wrote:
  > Breeze panel and dialog being different when using a dark theme
  
  I'm working on fixing the blur effect thanks to Alex Nemeth help.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D27320: enable anonymous and domain extra field in authinfo

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I also cannot test this properly, but the code change looks appropriate.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327484

REVISION DETAIL
  https://phabricator.kde.org/D27320

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27295: smb: support more advanced hidden file flag

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug307353

REVISION DETAIL
  https://phabricator.kde.org/D27295

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27294: fix free space calculation

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Nice!

REPOSITORY
  R320 KIO Extras

BRANCH
  bug298801

REVISION DETAIL
  https://phabricator.kde.org/D27294

To: sitter, ngraham, meven
Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27328: Drop qmake pri file generation & installation, currently broken

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
kossebau requested review of this revision.

REVISION SUMMARY
  The library NetworkManager is in the public interface of NetworkManagerQt,
  thus needs to be listed as a dependency, so that its include dirs
  and library to link are found.
  This would need another pri file for the library NetworkManager though,
  which there seems none to exist yet.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  dropbrokenprifile

REVISION DETAIL
  https://phabricator.kde.org/D27328

AFFECTED FILES
  metainfo.yaml
  src/CMakeLists.txt

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27327: Drop qmake pri file generation & installation, currently broken

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
kossebau requested review of this revision.

REVISION SUMMARY
  The library ModemManager is in the public interface of ModemManagerQt,
  thus needs to be listed as a dependency, so that its include dirs
  and library to link are found.
  This would need another pri file for the library ModemManager though,
  which there seems none to exist yet.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  dropbrokenprifile

REVISION DETAIL
  https://phabricator.kde.org/D27327

AFFECTED FILES
  metainfo.yaml
  src/CMakeLists.txt

To: kossebau, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops. Can confirm the bug and the fix.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27326

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume

[Stefan Brüns]

bruns added a comment.


  Reported on reddit:
  
https://www.reddit.com/r/kde/comments/f1y1g0/baloo_doesnt_resume_after_suspend/

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27326

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27326: [FileIndexScheduler] Force evaluation of indexerState after suspend/resume

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
bruns added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When the scheduler is idle when suspending scheduleIndexing() has to be
  triggered, otherwise indexerState is only evaluated on the first external
  trigger (e.g. a changed file).
  
  On resume, scheduleIndexing() never updated the state, as Suspended did
  not qualify as an Idle state. This had the effect of the scheduler being
  stuck in the Suspended state.

TEST PLAN
  balooctl suspend && balooctl status
  balooctl resume && balooctl status

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27326

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.14 - Build # 8 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.14/8/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 11 Feb 2020 15:13:34 +
 Build duration:
2 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.KAuthPolicyGenTestFailed: projectroot.autotests.KAuthPolicyGenTestCompare

D27288: [policy-gen] Fix the code to actually use the correct capture group

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:f6020e857424: [policy-gen] Fix the code to actually use 
the correct capture group (authored by ahmadsamir).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27288?vs=75459&id=75475

REVISION DETAIL
  https://phabricator.kde.org/D27288

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/foo.policy
  autotests/foo_actions.actions
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, dfaure, apol, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25123: New yakuake logo/icon

[Nathaniel Graham]

ngraham added a comment.


  In D25123#607216 , @davidre wrote:
  
  > If you land this please update the summary before. No need to have all the 
variants  in the commit message it should be about the actual change. Thanks :)
  
  
  @mglb ^^
  
  Can you do this so we can land the patch?

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein, ndavis
Cc: davidre, GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, 
numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, michaelh, bruns

D27315: Fix size of the header in GridViewKCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Resolves https://bugs.kde.org/show_bug.cgi?id=417347 and seems like the 
correct fix.

REPOSITORY
  R296 KDeclarative

BRANCH
  gridviewkcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27315

To: davidre, mart, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27315: Fix size of the header in GridViewKCM

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27315

To: davidre, mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: Frameworks 5.67 re-spin request

[Nate Graham]

Merci beaucoup David!

Nate


On 2020-02-10 15:20, David Faure wrote:

On lundi 10 février 2020 15:32:11 CET Nate Graham wrote:

Hello frameworks packagers,
I hate to have to make this request, bug could we get Frameworks 5.67
re-spun to include these two commits:

https://cgit.kde.org/kirigami.git/commit/?id=f695cde36a6829b8b92b2fd82deff16
d9385fcb9

https://cgit.kde.org/qqc2-desktop-style.git/commit/?id=6995b4ae81a2f3ca3c24d
2fa6d1560bfe0898737

These commits fix highly user-visible issues with scrollbars in
QML-based apps, most notably Discover.

I've been told that most LTS distros are planning to ship Plasma 5.18
with Frameworks 5.67, so if that version doesn't include these fixes,
then Plasma 5.18 LTS users will be stuck with the issues for years and
we'll get a ton of bug reports.


Done:

kirigami v5.67.1
b0f31c4c671f3cb4cab3425f5d757c6cf6e2d02b
0311ba00b213a26acddd9fe4ce0642ed2500a076429ea5fe4424fdf634f12e68  
sources/kirigami2-5.67.1.tar.xz

qqc2-desktop-style v5.67.1
a992466f2fe596b1ae34da91fd7e95e21b973a52
b2af96084e85096506cc109634234150cfc88a9fcf2d6887c55ef1787c046a44  
sources/qqc2-desktop-style-5.67.1.tar.xz

https://kde.org/info/kde-frameworks-5.67.0.php updated (without much polish).

D27321: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Example use in KDevelop:
  F8097786: Screenshot_20200211_151939.png 


REPOSITORY
  R267 Oxygen Icons

REVISION DETAIL
  https://phabricator.kde.org/D27321

To: kossebau, #vdg, ndavis, andreask
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D27321: Add status icons: data-error, 
data-warning, data-information.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27321: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau added a dependency: D27272: Add status icons: data-error, 
data-warning, data-information.

REPOSITORY
  R267 Oxygen Icons

REVISION DETAIL
  https://phabricator.kde.org/D27321

To: kossebau, #vdg, ndavis, andreask
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27321: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: VDG, ndavis, andreask.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Following addition of same icon names to Breeze icon theme.
  
  These are generic icons to use to mark the status of data or other content.
  The current available icons are bound to other context, like dialog or
  cloud.
  
  Use case of such icons would be e.g. with KDevelop to put such lines on the
  marker border to mark lines with errors, warnings or hints as found by
  parsers & checkers by a symbol, as well as in the problem report tool view
  or as symbols in inline notes.
  Those places use small icons, and best signal the type of marker by both
  shape & color.
  
  Linking dialog-* counterparts, which work here.

REPOSITORY
  R267 Oxygen Icons

BRANCH
  adddatastatusicons

REVISION DETAIL
  https://phabricator.kde.org/D27321

AFFECTED FILES
  16x16/status/data-error.png
  16x16/status/data-information.png
  16x16/status/data-warning.png
  22x22/status/data-error.png
  22x22/status/data-information.png
  22x22/status/data-warning.png

To: kossebau, #vdg, ndavis, andreask
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27272

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27288: [policy-gen] Fix the code to actually use the correct capture group

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

BRANCH
  l-policy-gen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27288

To: ahmadsamir, #frameworks, dfaure, apol, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27291: install smb as both smb:// and cifs://

[Harald Sitter]

sitter added a comment.


  Easy merge for master, just needs some ctrl-c magic. Thanks for the heads up 
though :)

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27320: enable anonymous and domain extra field in authinfo

[Harald Sitter]

sitter created this revision.
sitter added reviewers: ngraham, dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this causes kiod to query the password with the relevant functionality
  enabled. domain additionally defaults to whatever smbc_getWorkgroup returns
  
  BUG: 327484
  FIXED-IN: 19.12.3

TEST PLAN
  - builds
  - auth query has new functionality
  - logging in still works as expected
  
  I couldn't actually get the original problem in 327484 to appear with a samba 
DC I threw together, so for all I know this doesn't actually fix the bug but I 
have no way to test :|

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327484

REVISION DETAIL
  https://phabricator.kde.org/D27320

AFFECTED FILES
  smb/kio_smb.h
  smb/kio_smb_auth.cpp

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27215: add vvave icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6063eb838d9b: add vvave icon (authored by mbruchert, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27215?vs=75178&id=75461

REVISION DETAIL
  https://phabricator.kde.org/D27215

AFFECTED FILES
  icons-dark/apps/48/vvave.svg
  icons/apps/48/vvave.svg

To: mbruchert, #vdg, camiloh, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27214: add puremaps icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c5835b98d666: add puremaps icon (authored by mbruchert, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27214?vs=75177&id=75460

REVISION DETAIL
  https://phabricator.kde.org/D27214

AFFECTED FILES
  icons-dark/apps/48/puremaps.svg
  icons/apps/48/puremaps.svg

To: mbruchert, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27214: add puremaps icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  puremaps-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27214

To: mbruchert, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25123: New yakuake logo/icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  yakuake

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein, ndavis
Cc: davidre, GB_2, ndavis, ognarb, ngraham, hein, kde-frameworks-devel, 
numerodix, vmarinescu, ryanmccoskrie, LeGast00n, cblack, michaelh, bruns

D27288: [policy-gen] Fix the code to actually use the correct capture group

[Ahmad Samir]

ahmadsamir updated this revision to Diff 75459.
ahmadsamir retitled this revision from "[policy-gen] Fix the code to actually 
captured the correct capture group" to "[policy-gen] Fix the code to actually 
use the correct capture group".
ahmadsamir added a comment.


  Fix commit message

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27288?vs=75458&id=75459

BRANCH
  l-policy-gen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27288

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/foo.policy
  autotests/foo_actions.actions
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27288: [policy-gen] Fix the code to actually captured the correct capture group

[Ahmad Samir]

ahmadsamir updated this revision to Diff 75458.
ahmadsamir added a comment.


  Follow naming convention, KAuth

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27288?vs=75451&id=75458

BRANCH
  l-policy-gen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27288

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/foo.policy
  autotests/foo_actions.actions
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Unify the look of all icons containing 🚫 (no sign)

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:61247fff3c48: Unify the look of all icons containing 🚫  
(no sign) (authored by mthw, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27247?vs=75443&id=75457

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/mail-mark-junk.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/mail-mark-junk.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/mail-mark-junk.svg
  icons-dark/actions/32/mail-mark-junk.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/mail-mark-junk.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/mail-mark-junk.svg
  icons/actions/24/audio-volume-muted.svg
  icons/actions/24/mail-mark-junk.svg
  icons/actions/32/mail-mark-junk.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: meven, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27288: [policy-gen] Fix the code to actually captured the correct capture group

[Ahmad Samir]

ahmadsamir updated this revision to Diff 75451.
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Add a simple/crude unit test

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27288?vs=75369&id=75451

BRANCH
  l-policy-gen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27288

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/foo.policy
  autotests/foo_actions.actions
  src/policy-gen/policy-gen.cpp

To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27315: Fix size of the header in GridViewKCM

[David Redondo]

davidre edited the test plan for this revision.
davidre added a reviewer: broulik.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D27315

To: davidre, mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27315: Fix size of the header in GridViewKCM

[David Redondo]

davidre created this revision.
davidre added a reviewer: mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The same as in SimpleKCM and ScrollviewKCM

REPOSITORY
  R296 KDeclarative

BRANCH
  gridviewkcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27315

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml

To: davidre, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27247: Unify the look of all icons containing 🚫 (no sign)

[Matej Mrenica]

mthw updated this revision to Diff 75443.
mthw added a comment.


  Name should be correct now.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27247?vs=75434&id=75443

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/mail-mark-junk.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/mail-mark-junk.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/mail-mark-junk.svg
  icons-dark/actions/32/mail-mark-junk.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/mail-mark-junk.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/mail-mark-junk.svg
  icons/actions/24/audio-volume-muted.svg
  icons/actions/24/mail-mark-junk.svg
  icons/actions/32/mail-mark-junk.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: meven, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27238: Add an option to dynamic-break inside words

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I am ok with this.
  Thought I would like to have a more consistent name for the config key.
  We have already "dynamic-word-wrap", I would like 
"dynamic-word-wrap-anywhere" better than the abbreviated "dyn-wrap-anywhere"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27238

To: eudoxos, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, 
LeGast00n, cblack, szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, 
head7, kfunk, sars

D27238: Add an option to dynamic-break inside words

[eudoxos]

eudoxos added a comment.


  A complementary (also related to dynamic wrapping) change is tracked under 
D27285 .

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27238

To: eudoxos
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, cent, rrosch, 
LeGast00n, cblack, szutmael, GB_2, domson, michaelh, ngraham, bruns, demsking, 
head7, kfunk, sars

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos updated this revision to Diff 75440.
eudoxos added a comment.


  Fix tab/space indentation, fix maximum width. No other glitches known at 
present.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27285?vs=75361&id=75440

BRANCH
  dynwrap-marker (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27285

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katelinelayout.cpp
  src/render/katelinelayout.h
  src/render/katerenderer.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: eudoxos, #vdg
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27313: Add syntax highlighting for Solidity

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  FEATURE: 411867
  
  The XML file was created by Robert Kaiser and attached in: 
https://bugs.kde.org/show_bug.cgi?id=411867
  
  I took the test file from the Solidity documentation: 
https://solidity.readthedocs.io/en/latest/solidity-by-example.html

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-solidity

REVISION DETAIL
  https://phabricator.kde.org/D27313

AFFECTED FILES
  autotests/folding/test.sol.fold
  autotests/html/test.sol.html
  autotests/input/test.sol
  autotests/reference/test.sol.ref
  data/syntax/solidity.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27291: install smb as both smb:// and cifs://

[Méven Car]

meven added a comment.


  Samba protocol has been partly ported to the json format 
https://phabricator.kde.org/D26358
  This may be a great time to add the cifs protocol to `smb/smb.json` instead 
of propagating another .protocol file

REPOSITORY
  R320 KIO Extras

BRANCH
  bug327295

REVISION DETAIL
  https://phabricator.kde.org/D27291

To: sitter, dfaure, ngraham
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, pberestov, iasensio, 
fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27247: Unify the look of all icons containing 🚫 (no sign)

[Méven Car]

meven added a comment.


  In D27247#609444 , @mthw wrote:
  
  > Changed git name, nothing else
  
  
  It seems it has not work, we still see "mthw0" as author of the commit.
  
  You probably needs to `git commit amend --no-edit` (use git basically to do 
the dead), it should update the author of the commit (or remove the --no-edit 
and save as-is), and then arc diff again.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: meven, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27294: fix free space calculation

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Tested with success with samba 4.5
  
  I gave a try to fix this issue, did not got through until samba's code. Thanks

REPOSITORY
  R320 KIO Extras

BRANCH
  bug298801

REVISION DETAIL
  https://phabricator.kde.org/D27294

To: sitter, ngraham, meven
Cc: meven, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27247: Unify the look of all icons containing 🚫 (no sign)

[Matej Mrenica]

mthw updated this revision to Diff 75434.
mthw added a comment.


  Changed git name, nothing else

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27247?vs=75406&id=75434

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27247

AFFECTED FILES
  icons-dark/actions/16/font-disable.svg
  icons-dark/actions/16/mail-mark-junk.svg
  icons-dark/actions/22/font-disable.svg
  icons-dark/actions/22/mail-mark-junk.svg
  icons-dark/actions/24/audio-volume-muted.svg
  icons-dark/actions/24/mail-mark-junk.svg
  icons-dark/actions/32/mail-mark-junk.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/actions/16/font-disable.svg
  icons/actions/16/mail-mark-junk.svg
  icons/actions/22/font-disable.svg
  icons/actions/22/mail-mark-junk.svg
  icons/actions/24/audio-volume-muted.svg
  icons/actions/24/mail-mark-junk.svg
  icons/actions/32/mail-mark-junk.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: mthw, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns