D27419: Update Japanese holidays

[N. Higa]

nhiga created this revision.
nhiga added reviewers: dvratil, winterz.
nhiga added projects: KDE PIM, Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  This patch is purely cosmetic since the predicted Vernal and Autumnal Equinox 
Days of 2021 are the same as the official announcement 
.
  The source URLs in the comment section are now in HTTPS. (When using the HTTP 
version , a notice on 
"always-on" TLS of Cabinet Office Website 
 will be displayed.)

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D27419

AFFECTED FILES
  holidays/plan2/holiday_jp_en-us
  holidays/plan2/holiday_jp_ja

To: nhiga, dvratil, winterz
Cc: #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, 
dcaliste, michaelh, ngraham, bruns, dvasin, rodsevich, winterz, vkrause, 
mlaurent, knauss, dvratil

D27412: Port away from deprecated API on Qt 5.15.0

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:781064ba1c13: Port away from deprecated API on Qt 5.15.0 
(authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27412?vs=75714=75731#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27412?vs=75714=75731

REVISION DETAIL
  https://phabricator.kde.org/D27412

AFFECTED FILES
  src/drkonqidialog.cpp

To: apol, #frameworks, davidedmundson, sitter
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2020-02-13 00:48, Kai Uwe Broulik wrote:
To minimize potential Frameworks dependency problems I would even go as 
far as put Feature freeze on same date as Frameworks tagging date so 
that no new stuff goes in that could require a Framework change, like 
the wallpaper JPG vs PNG situation.


But did people care about all of this? Nope. We had a wallpaper contest 
that was explicitly scheduled to go in even after the Beta. This is 
unacceptable and next time we do this I will flat out revert a wallpaper 
change after the beta.


I agree, we could have and should have done the wallpaper competition 
earlier. However I'm not aware of any user-visible regressions that 
stemmed from the last-minute shuffle for the wallpaper, which is what 
I'm talking about here. Are you?



Next is this pointless scroll bar visual change. Why did that have to go 
in a day before the Beta, and - surprise - cause problems all over the 
stack which require a bunch of Frameworks fixes?


I agree, that should have been deferred to 5.19. Definitely a lack of 
discipline on our behalf.



Another topic was the KUserFeedback KCM. There had been substantial 
changes also on release date and this is a feature that must be spot-on 
and work 120% from day one. The KNewStuffQuick stuff was a substantial 
change even after Beta freeze...


Like the wallpaper shuffle, I'm not aware of any actual user-visible 
bugs that resulted from this.


In my estimation, the last-minute changes were necessary to get us to 
that 120%, or at least closer than where we were before. Without those 
last-minute kuserfeedback changes, I was worried that the poor 
presentation of what was being transmitted would cause a PR disaster, 
send privacy-conscious people into a panic, and cause other users to 
lose trust in us. As-is, we got one guy on Reddit who wouldn't pipe down 
about it. Without the last-minute changes, I foresaw that times a 
hundred. So at that point it was either introduce last-minute changes or 
punt the whole feature into Plasma 5.19. Which we could have done I 
guess. Maybe we should have. But it seemed like a lot of people really 
wanted it in the LTS release.


And again, nothing actually regressed from that, to my knowledge. What I 
was drawing attention here were regressions and bugs introduced in 
Frameworks that affected people upgrading to Plasma 5.18, such as:


- https://bugs.kde.org/show_bug.cgi?id=417351 [FormLayout positioning 
and width regressions]

- https://bugs.kde.org/show_bug.cgi?id=417127 [Can't turn off Baloo]
- https://bugs.kde.org/show_bug.cgi?id=417511 [Un-maximized dark panels 
have white corners]


Without special point releases or distro packager backporting, LTS users 
could be hitting these issues for years.



Nate

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2020-02-13 00:42, Ben Cooksley wrote:

A better way of approaching this would be to freeze the Frameworks
version you are going to require API wise at an earlier point in the
Plasma development cycle. This would allow for a full Frameworks
release cycle to pass where bugs encountered during the lead up to the
Plasma release can be fixed.

This version of Frameworks would then be the one that Plasma hard depends on.


We do this; Plasma 5.18 has a minimum Frameworks dependency of 5.66. See 
https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series


The problem here isn't so much API breaks but rather major bugs and UI 
regressions. if a framework has a very visible bug or UI regression in 
5.66 of the kind that we would really like to fix, but LTS distros 
freeze on that version, then LTS users will be stuck with that issue 
forever unless we make a frameworks point release or cajole distro 
packagers to backport the fix.


Rolling release distro users will first see Plasma 5.18 with Frameworks 
5.67, so if that frameworks version has a major bug or UI regression, it 
will take a month for the fix to land in users' hands whereas if the 
issue were in Plasma itself, we could fix it immediately and users would 
get the fix in a week (the first point release is one week after the .0 
release).


My point is that the schedules just don't really match up if we want to 
present a polished finished product and continue to fix bugs for the 
lifetime of an LTS release.



Nate

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos updated this revision to Diff 75727.
eudoxos added a comment.


  Fix indentation lines shown spuriously when horizontal space was unsufficient 
for indent fill

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27285?vs=75533=75727

BRANCH
  dynwrap-marker

REVISION DETAIL
  https://phabricator.kde.org/D27285

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katelinelayout.cpp
  src/render/katelinelayout.h
  src/render/katerenderer.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: eudoxos, #vdg
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[eudoxos]

eudoxos added a comment.


  Note to myself: should handle the case when width percentage disallows the 
indent, e.g. here:
  F8104336: image.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kmessagewidget.cpp:155
>  };
> -
> +// Add bordersize to the margin so it starts from the inner border and 
> doesn't look to cramped
> +q->layout()->setContentsMargins(q->layout()->contentsMargins() + 
> borderSize);

too

> kmessagewidget.cpp:193
> +textLabel->setPalette(palette);
> +// update the Icon in case its recolorable
> +q->setIcon(icon);

typo: it is

> kmessagewidget.cpp:325
> +constexpr float radius = 4 * 0.6;
> +const QRect innerRect = rect().marginsRemoved(QMargins() + borderSize/2);
> +const QColor color = palette().color(QPalette::Window);

missing spaces around `/`

> kmessagewidget.cpp:397
>  
> -if (isVisible() && (d->timeLine->state() == QTimeLine::NotRunning) && 
> (height() == d->bestContentHeight()) && (d->content->pos().y() == 0)) {
> +if (isVisible() && (d->timeLine->state() == QTimeLine::NotRunning) && 
> (height() == d->bestContentHeight())){
>  emit showAnimationFinished();

missing space before `{`

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27412: Port away from deprecated API on Qt 5.15.0

[Ömer Fadıl Usta]

usta added a comment.


  isnt this also needs #include 

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

To: apol, #frameworks, davidedmundson, sitter
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27416: Add small icons for KeePassXC

[Wojciech Stachurski]

wsdfhjxc edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27416

To: wsdfhjxc, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27416: Add small icons for KeePassXC

[Wojciech Stachurski]

wsdfhjxc created this revision.
wsdfhjxc added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
wsdfhjxc requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  keepassxc-small

REVISION DETAIL
  https://phabricator.kde.org/D27416

AFFECTED FILES
  icons-dark/apps/16/keepassxc-locked.svg
  icons-dark/apps/16/keepassxc-unlocked.svg
  icons-dark/apps/22/keepassxc-locked.svg
  icons-dark/apps/22/keepassxc-unlocked.svg
  icons/apps/16/keepassxc-locked.svg
  icons/apps/16/keepassxc-unlocked.svg
  icons/apps/22/keepassxc-locked.svg
  icons/apps/22/keepassxc-unlocked.svg

To: wsdfhjxc, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27412: Port away from deprecated API on Qt 5.15.0

[Harald Sitter]

sitter accepted this revision.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

To: apol, #frameworks, davidedmundson, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre updated this revision to Diff 75717.
davidre added a comment.


  remove debug remains

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=75716=75717

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27412: Port away from deprecated API on Qt 5.15.0

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

To: apol, #frameworks, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

[David Redondo]

davidre updated this revision to Diff 75716.
davidre added a comment.


  Explicitly set TextColor and palettes of the labels and react to parent 
changes . For example necessary for konsole 
  that uses stylesheet which break palette propagation and reparents the widget 
after creation.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27035?vs=74766=75716

BRANCH
  no-css (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27035

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  src/kmessagewidget.cpp

To: davidre, #frameworks, ngraham
Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27321: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R267:cc173d74cbcc: Add status icons: data-error, data-warning, 
data-information (authored by kossebau).

REPOSITORY
  R267 Oxygen Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27321?vs=75468=75715

REVISION DETAIL
  https://phabricator.kde.org/D27321

AFFECTED FILES
  16x16/status/data-error.png
  16x16/status/data-information.png
  16x16/status/data-warning.png
  22x22/status/data-error.png
  22x22/status/data-information.png
  22x22/status/data-warning.png

To: kossebau, #vdg, ndavis, andreask
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27412: Port away from deprecated API on Qt 5.15.0

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Upstream recommends using QLocale for turning dates into strings.

TEST PLAN
  Builds on my system now

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27412

AFFECTED FILES
  src/drkonqidialog.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27272: Add status icons: data-error, data-warning, data-information

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0f841410f874: Add status icons: data-error, data-warning, 
data-information (authored by kossebau).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27272?vs=75429=75712

REVISION DETAIL
  https://phabricator.kde.org/D27272

AFFECTED FILES
  icons-dark/status/16/data-error.svg
  icons-dark/status/16/data-information.svg
  icons-dark/status/16/data-warning.svg
  icons-dark/status/22/data-error.svg
  icons-dark/status/22/data-information.svg
  icons-dark/status/22/data-warning.svg
  icons/status/16/data-error.svg
  icons/status/16/data-information.svg
  icons/status/16/data-warning.svg
  icons/status/22/data-error.svg
  icons/status/22/data-information.svg
  icons/status/22/data-warning.svg

To: kossebau, #vdg, ndavis
Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27320: enable anonymous and domain extra field in authinfo

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:9d52cd9c9144: smb: enable anonymous and domain extra 
field in authinfo (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27320?vs=75466=75705#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27320?vs=75466=75705

REVISION DETAIL
  https://phabricator.kde.org/D27320

AFFECTED FILES
  smb/kio_smb.h
  smb/kio_smb_auth.cpp

To: sitter, ngraham, dfaure
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:a813d67cf6af: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT 
(authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27378?vs=75630=75706#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27378?vs=75630=75706

REVISION DETAIL
  https://phabricator.kde.org/D27378

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27377: map ECONNABORTED to ERR_CONNECTION_BROKEN

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:2075e76389cc: smb: map ECONNABORTED to 
ERR_CONNECTION_BROKEN (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27377?vs=75628=75703

REVISION DETAIL
  https://phabricator.kde.org/D27377

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27372: smb: disable mode bits getting forwarded to KIO

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:718abcb69b78: smb: disable mode bits getting forwarded to 
KIO (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27372?vs=75618=75704

REVISION DETAIL
  https://phabricator.kde.org/D27372

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: sitter, ngraham
Cc: dfaure, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27153: port sftp to Result system to force serialization of error/finish condition

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> feverfew wrote in kio_sftp.cpp:145
> Technically unrelated to your changes, but does this even work? isn't the 
> check supposed to be against `errno` in this case, not offset?

True enough. I expect, like many things in the slaves, this never actually 
worked. that line was introduced as `KDE_lseek` and that too was just an alias 
for lseek :|
Also lseek doesn't even errno EAGAIN according to the manpage. I expect seeking 
as a whole needs fixing, I'll record a bug.

> feverfew wrote in kio_sftp.cpp:302
> `if (result.success) { ...} else { ... } seems clearer to me

That function is a verbatim copy from ftp so I'd rather not change it.

> feverfew wrote in kio_sftp.cpp:328
> I'm a bit confused, why is this necessary?

Kinda unrelated to the diff, I only changed it because this class has way too 
many type coercions.
`i` goes into `ssh_userauth_kbdint_getprompt` which has an unsigned signature, 
the counter `n` coming out of `ssh_userauth_kbdint_getnprompts` is signed 
though. The explicit cast silences the warning of the type coercion between int 
and unsigned.

Mind you, I think n<1 cannot even happen. The server challenged us, so there's 
always going to be at least one prompt, so the fact that it returns a signed 
prompt count is silly to begin with.

> feverfew wrote in kio_sftp.h:77
> TODO KF6 https://en.cppreference.com/w/cpp/language/attributes/nodiscard ?

I guess, that applies to all slaves though. ftp already has it and smb is also 
going to get it at some point. If we want a todo comment I'd put it in the ftp 
code. Though TBH I think that should just be a clazy check or deprecation 
inside Qt when built with c++17.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27153

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27153: port sftp to Result system to force serialization of error/finish condition

[Harald Sitter]

sitter updated this revision to Diff 75698.
sitter marked 2 inline comments as done.
sitter added a comment.


  s/LL/U
  
  call finished() from frontend close() (internal close cannot finish and 
cannot error).  " // must call finish(), which will set d->inOpenLoop=false" 
one of many expectations not asserted by slavebase :(

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27153?vs=74991=75698

BRANCH
  sftp-errors

REVISION DETAIL
  https://phabricator.kde.org/D27153

AFFECTED FILES
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25583: Quit baloo_file_extractor if DB transaction fails

[Stefan Brüns]

bruns added a comment.


  From the viewpoint of baloo_file, the process just hangs, which is bad.

INLINE COMMENTS

> app.cpp:138
>  
>  QDBusConnection::sessionBus().send(message);
>  

You still send out the message, though the results have not been commited.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns, ngraham
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Gotcha, thanks for the explanation. Makes sense now.

REPOSITORY
  R320 KIO Extras

BRANCH
  bug417166

REVISION DETAIL
  https://phabricator.kde.org/D27378

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

[Nathaniel Graham]

ngraham removed a dependent revision: D27260: [applets/systemtray] Set pin 
button's size correctly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27221

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: mart, gvgeo, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a subscriber: mart.
ngraham added a comment.


  Looks like @mart just did this in D27396 .

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27221

To: ngraham, #vdg, #plasma, broulik, ndavis
Cc: mart, gvgeo, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27399: make sure the size hints are integer and even

[David Edmundson]

davidedmundson added a comment.


  Please ensure that you've run the relevant plasma-framework/tests/components  
in qmlscene

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27399

To: mart, broulik
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27399: make sure the size hints are integer and even

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:667dce502acf: make sure the size hints are integer and 
even (authored by mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27399?vs=75681=75688

REVISION DETAIL
  https://phabricator.kde.org/D27399

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27399: make sure the size hints are integer and even

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/sizefixes

REVISION DETAIL
  https://phabricator.kde.org/D27399

To: mart, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27399: make sure the size hints are integer and even

[Marco Martin]

mart created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  for retrocompatibility with pc2 units.gridUnit * 1.6 is used
  a lot as size hint (we have to guarantee buttons and
  textfields have the same height by default for perfect
  horizontal alignment.
  tough we have make sure that size is integer and even otherwise
  we'll have a lot of internal misalignments

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/sizefixes

REVISION DETAIL
  https://phabricator.kde.org/D27399

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/TextField.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27396: support icon.width/height

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3de1c2462eda: support icon.width/height (authored by 
mart).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75677=75678

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma, broulik
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart updated this revision to Diff 75677.
mart added a comment.


  - don't expose externally default size

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75675=75677

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart updated this revision to Diff 75675.
mart added a comment.


  - default icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27396?vs=75672=75675

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart added a comment.


  In D27396#611425 , @broulik wrote:
  
  > Don't we want to set a default? I keep seeing people hardcoding 
`icon.width` all over the place when they used PC3 and I want that to stop
  
  
  then should be i think smallMedium size for toolbuttons (and i guess 
tabbuttons) and small for normal pushbuttons

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Kai Uwe Broulik]

broulik added a comment.


  Don't we want to set a default? I keep seeing people hardcoding `icon.width` 
all over the place when they used PC3 and I want that to stop

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27396

To: mart, #plasma
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27396: support icon.width/height

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support the icon size hint of the control. Reinstate it in ToolButton
  and add the support for the other controls
  CCBUG:417514

TEST PLAN
  possible to control buttons icon sizes

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/iconSize

REVISION DETAIL
  https://phabricator.kde.org/D27396

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27378: smb: map EHOSTUNREACH to ERR_CANNOT_CONNECT

[Harald Sitter]

sitter added a comment.


  Nah. 50.50.50.50 is an actual host on the internet for all your router knows 
^^
  
  You need to use an unassigned address within your actual home network, 
otherwise your router will (likely) send it off to the internet and then it 
will bounce around there for a bit as every router goes "does any router know 
50.50.50.50?" until smb is tired of waiting and times out. Which is precisely 
what happend to you, IOW "we tried to talk to this host but got no reply before 
we got sick of waiting" and the waiting happend because routers all over the 
world tried to figure out who 50.50.50.50 is.
  
  The actual error this diff introduces is for example:
  F8103267: Screenshot_20200214_105251.png 

  
  Somewhat unrelated, but, if you check job_error.cpp in KIO you'll find 
KIO::Job::detailedErrorStrings which is backed by KIO::rawErrorDetail and that 
has mountains of causes and possible solutions for a lot of the KIO error 
types. Dolphin should really find a way to use that data somehow and the data 
should be polished I guess, it's probably been dormant since kde3. I can 
totally see why a single line description for an error is not accurately 
explaining what that error is, what it means or what to do about it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27378

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson added a comment.


  I'm going to push soon if I don't hear soon. It solves a real world problem 
and it's had one approval.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns, ngraham
Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27083: [PC2]Give Label integer width.

[George Vogiatzis]

gvgeo added a comment.


  While I was improving the test.qml, found that Headings also have the same 
problem but vertically. I imagine that is from the fractional-part in the 
multiplier.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27083: [PC2]Give Label integer width.

[George Vogiatzis]

gvgeo edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27083

To: gvgeo, #plasma, #vdg, ndavis, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, michaelh, ZrenBot, 
ngraham, bruns, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

[Milian Wolff]

mwolff added a comment.


  In D27285#611163 , @dhaumann wrote:
  
  > Ok, I now fully got this, thanks for the explanation. And indeed without 
any left fill visual feedback is missing.
  >
  > What I wonder is how much of this needs to be configurable. We could also 
just make the left fill of 4 default or so.
  >
  > In any case, I think we should go forward with this patch. @cullmann your 
opinion?
  
  
  You could use the current document's indent width instead of hardcoding 4?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27285

To: eudoxos, #vdg
Cc: mwolff, cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, 
LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27385: [RFC] Return error instead of aborting when receiving an unexpected answer

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> slavebase.cpp:1100
>  } else {
> -qFatal("Fatal Error: Got cmd %d, while waiting for an answer!", 
> cmd);
> +qDebug("Error: Got cmd %d, while waiting for an answer!", cmd);
> +return -1;

Should at least be `qWarning` imho

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27385

To: fifr, #frameworks, dfaure, meven
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns