D27640: templates: Convert license statements to SPDX headers

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, cordlandwehr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also consistently use LGPL-2.1-or-later as default license

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  templatesusespdxlicensestyle

REVISION DETAIL
  https://phabricator.kde.org/D27640

AFFECTED FILES
  templates/cpp-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/cpp-plasmoid/src/%{APPNAMELC}.cpp
  templates/cpp-plasmoid/src/%{APPNAMELC}.h
  templates/cpp-plasmoid/src/package/contents/ui/main.qml
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper/LICENSES/LGPL-2.1-or-later.txt
  templates/plasma-wallpaper/package/contents/ui/config.qml
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/plasma-wallpaper/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid-with-qml-extension/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/qml-plasmoid/LICENSES/LGPL-2.1-or-later.txt
  templates/qml-plasmoid/package/contents/ui/main.qml
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, #plasma, cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27637: kill twitter support

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  killtwitter

REVISION DETAIL
  https://phabricator.kde.org/D27637

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 441 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/441/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 04:43:05 +
 Build duration:
9 min 2 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34821/62088)40%
(17702/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)96%
(9734/10191)47%
(4553/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8730/14615)51%
(4513/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 307 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/307/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 25 Feb 2020 04:43:05 +
 Build duration:
6 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 316 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/316/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 25 Feb 2020 04:43:05 +
 Build duration:
5 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34816/62087)40%
(17692/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4549/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8732/14615)51%
(4514/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 355 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/355/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 25 Feb 2020 00:44:25 +
 Build duration:
2 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2690)0%
(0/1825)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2054)0%
(0/1410)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 208 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/208/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Tue, 25 Feb 2020 00:44:25 +
 Build duration:
2 min 31 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.68.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513 Failed: 4 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_icon.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_keynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_listskeynavigation.qmlFailed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt513.autotests.tst_pagerow.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/20)0%
(0/20)0%
(0/2690)0%
(0/1825)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/13)0%
(0/13)0%
(0/2054)0%
(0/1410)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/628)0%
(0/415)

D27633: Port to KPluginLoader

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R155:27487ab9276c: Port to KPluginLoader (authored by 
nicolasfella).

REPOSITORY
  R155 KAccounts Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27633?vs=76326=76335

REVISION DETAIL
  https://phabricator.kde.org/D27633

AFFECTED FILES
  src/daemon/daemon.cpp
  src/lib/kaccountsdplugin.cpp
  src/lib/kaccountsdplugin.h

To: nicolasfella, bshah, leinir, #frameworks, apol

D27637: kill twitter support

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Frameworks, apol, bshah.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Twitter support in KAccounts has been reportedly broken for years 
(https://bugs.kde.org/show_bug.cgi?id=363260) and is currently disabled. 
Therefor the twitter plugin cannot work. We have no complaint about it not 
working in Purpose bugs, which makes me conclude it won't be missed.
  
  It allows us to get rid of the ugly dependency on nodejs, too.

REPOSITORY
  R495 Purpose Library

BRANCH
  killtwitter

REVISION DETAIL
  https://phabricator.kde.org/D27637

AFFECTED FILES
  CMakeLists.txt
  src/plugins/CMakeLists.txt
  src/plugins/twitter-microblog.service.in
  src/plugins/twitter/Messages.sh
  src/plugins/twitter/contents/code/main.js.in
  src/plugins/twitter/contents/code/package.json
  src/plugins/twitter/contents/config/config.qml
  src/plugins/twitter/metadata.json

To: nicolasfella, #frameworks, apol, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27153: port sftp to Result system to force serialization of error/finish condition

[Alexander Saoutkin]

feverfew accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-errors

REVISION DETAIL
  https://phabricator.kde.org/D27153

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27633: Port to KPluginLoader

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R155 KAccounts Integration

BRANCH
  kpluginloader

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks, apol

D27633: Port to KPluginLoader

[Nicolas Fella]

nicolasfella added reviewers: leinir, Frameworks.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27633

To: nicolasfella, bshah, leinir, #frameworks

D27635: Restore kio-webdav plugin

[Nicolas Fella]

nicolasfella added a reviewer: Frameworks.

REPOSITORY
  R155 KAccounts Integration

REVISION DETAIL
  https://phabricator.kde.org/D27635

To: nicolasfella, bshah, leinir, #frameworks

D27632: Implement UString operator= to make gcc happy

[Harri Porten]

porten added a comment.


  On first sight I don't get how the class' memory management works these days. 
Before commenting on the patch I have to refresh my knowledge.

REPOSITORY
  R314 KJs

REVISION DETAIL
  https://phabricator.kde.org/D27632

To: aacid
Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27632: Implement UString operator= to make gcc happy

[Albert Astals Cid]

aacid added a subscriber: porten.

REPOSITORY
  R314 KJs

REVISION DETAIL
  https://phabricator.kde.org/D27632

To: aacid
Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27632: Implement UString operator= to make gcc happy

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  otherwise complains that there's a copy constructor but not an
  assignment operator

REPOSITORY
  R314 KJs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27632

AFFECTED FILES
  src/kjs/ustring.h

To: aacid
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks so much everyone! @sitter I'll read up on CMake a bit and try to 
implement your suggestions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 259 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/259/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 21:31:00 +
 Build duration:
2 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 151 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/151/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 21:31:00 +
 Build duration:
2 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 144 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/144/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 21:31:00 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 213 lines...][2020-02-24T21:31:20.837Z] [ 16%] Automatic MOC for target symlink[2020-02-24T21:31:20.837Z] [ 16%] Automatic MOC for target scalable[2020-02-24T21:31:20.837Z] [ 20%] Automatic MOC for target qrcAlias[2020-02-24T21:31:20.837Z] [ 20%] Built target breeze-icons-dark-mkdir[2020-02-24T21:31:20.837Z] [ 20%] Built target breeze-icons-mkdir[2020-02-24T21:31:21.099Z] [ 20%] Built target qrcAlias_autogen[2020-02-24T21:31:21.099Z] Scanning dependencies of target qrcAlias[2020-02-24T21:31:21.099Z] [ 25%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias_autogen/mocs_compilation.cpp.o[2020-02-24T21:31:21.099Z] [ 29%] Building CXX object CMakeFiles/qrcAlias.dir/qrcAlias.cpp.o[2020-02-24T21:31:21.368Z] [ 29%] Built target symlink_autogen[2020-02-24T21:31:21.368Z] [ 29%] Built target dupe_autogen[2020-02-24T21:31:21.368Z] [ 29%] Built target newline_autogen[2020-02-24T21:31:21.368Z] [ 29%] Built target scalable_autogen[2020-02-24T21:31:21.625Z] [ 29%] Built target breeze-validate-svg[2020-02-24T21:31:21.625Z] Scanning dependencies of target symlink[2020-02-24T21:31:21.625Z] [ 33%] Building CXX object autotests/CMakeFiles/symlink.dir/symlink_autogen/mocs_compilation.cpp.o[2020-02-24T21:31:21.625Z] [ 37%] Building CXX object autotests/CMakeFiles/symlink.dir/symlinktest.cpp.o[2020-02-24T21:31:21.625Z] Scanning dependencies of target scalable[2020-02-24T21:31:21.625Z] Scanning dependencies of target dupe[2020-02-24T21:31:21.625Z] Scanning dependencies of target newline[2020-02-24T21:31:21.625Z] [ 41%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o[2020-02-24T21:31:21.625Z] [ 45%] Building CXX object autotests/CMakeFiles/scalable.dir/scalabletest.cpp.o[2020-02-24T21:31:21.625Z] [ 50%] Building CXX object autotests/CMakeFiles/newline.dir/newline_autogen/mocs_compilation.cpp.o[2020-02-24T21:31:21.625Z] [ 54%] Building CXX object autotests/CMakeFiles/dupe.dir/dupe_autogen/mocs_compilation.cpp.o[2020-02-24T21:31:21.625Z] [ 58%] Building CXX object autotests/CMakeFiles/dupe.dir/dupetest.cpp.o[2020-02-24T21:31:21.625Z] [ 62%] Building CXX object autotests/CMakeFiles/newline.dir/newlinetest.cpp.o[2020-02-24T21:31:21.899Z] [ 66%] Linking CXX executable bin/qrcAlias[2020-02-24T21:31:22.162Z] [ 66%] Built target qrcAlias[2020-02-24T21:31:22.162Z] Scanning dependencies of target breeze-icons-dark-rcc[2020-02-24T21:31:22.162Z] Scanning dependencies of target breeze-icons-rcc[2020-02-24T21:31:22.162Z] [ 70%] Generating res/breeze-icons-dark.qrc[2020-02-24T21:31:22.162Z] [ 75%] Generating res/breeze-icons.qrc[2020-02-24T21:31:22.432Z] /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/autotests/scalabletest.cpp:76:26: warning: result of comparison of constant -1 with _expression_ of type 'KIconLoaderDummy::Context' is always true [-Wtautological-constant-out-of-range-compare][2020-02-24T21:31:22.432Z] QVERIFY2(context != -1,[2020-02-24T21:31:22.432Z]  ~~~ ^  ~~[2020-02-24T21:31:22.432Z] /usr/local/include/qt5/QtTest/qtestcase.h:77:9: note: expanded from macro 'QVERIFY2'[2020-02-24T21:31:22.432Z] if (statement) {\[2020-02-24T21:31:22.432Z] ^[2020-02-24T21:31:22.688Z] [ 79%] Linking CXX executable ../bin/symlink[2020-02-24T21:31:22.688Z] [ 83%] Linking CXX executable ../bin/newline[2020-02-24T21:31:22.688Z] [ 87%] Linking CXX executable ../bin/dupe[2020-02-24T21:31:22.688Z] [ 87%] Built target symlink[2020-02-24T21:31:22.688Z] [ 87%] Built target newline[2020-02-24T21:31:22.688Z] [ 87%] Built target dupe[2020-02-24T21:31:22.944Z] 1 warning generated.[2020-02-24T21:31:22.944Z] [ 91%] Linking CXX executable ../bin/scalable[2020-02-24T21:31:22.944Z] [ 91%] Built target scalable[2020-02-24T21:31:25.479Z] [ 95%] Generating breeze-icons-dark.rcc[2020-02-24T21:31:25.479Z] [100%] Generating breeze-icons.rcc[2020-02-24T21:31:27.376Z] [100%] Built target breeze-icons-dark-rcc[2020-02-24T21:31:27.376Z] [100%] Built target breeze-icons-rcc[2020-02-24T21:31:42.258Z] [100%] Built target breeze-generate-24px-versions-dark[2020-02-24T21:31:42.258Z] [100%] Built target breeze-generate-24px-versions[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[2020-02-24T21:31:43.348Z] + python3 -u ci-tooling/helpers/install-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/ --divertTo '/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/install-divert/'[2020-02-24T21:31:43.348Z] [  8%] Automatic MOC for target qrcAlias[2020-02-24T21:31:43.348Z] [  8%] Automatic MOC for target 

D27464: Add application menu dbus paths to org_kde_plasma_window interface

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasmawindowmanagement_interface.cpp:129
> how is this 9 already?

Git blame shows that it's been 9 since 2018. Looks like someone made a mistake 
a while back?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27153: port sftp to Result system to force serialization of error/finish condition

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27153

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27596: Load QM files from assets: URLs on Android

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  They used to work back when I added the code for it. Maybe it broke over 
time. If it works for you, go for it.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

D27596: Load QM files from assets: URLs on Android

[Volker Krause]

vkrause added a comment.


  In D27596#616554 , @apol wrote:
  
  > Don't we need an if Qt 5.13 elseif Qt 5.14?
  >
  > In other Qt versions it won't be in the assets...
  
  
  Are you sure about this? I had tested this on my Qt 5.13 setup and the files 
are in the same place there. I can't prove it with the binary factory apk 
though, translations don't seem to be included there at all?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D27596

To: vkrause
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, 
bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 440 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/440/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 17:20:31 +
 Build duration:
8 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34810/62087)40%
(17690/43854)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4547/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14615)51%
(4512/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 315 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/315/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 17:20:31 +
 Build duration:
6 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34843/62089)40%
(17704/43850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4547/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8749/14616)51%
(4523/8833)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2070/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1806/4289)36%
(1312/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
 

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 306 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/306/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 17:20:31 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27497: Fix code generation for entries with min/max

[Henri Chain]

hchain updated this revision to Diff 76317.
hchain added a comment.


  const, change method name, reformat code

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27497?vs=75987=76317

REVISION DETAIL
  https://phabricator.kde.org/D27497

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test13.cpp.ref
  autotests/kconfig_compiler/test_param_minmax.cpp.ref
  autotests/kconfig_compiler/test_param_minmax.h.ref
  autotests/kconfig_compiler/test_param_minmax.kcfg
  autotests/kconfig_compiler/test_param_minmax.kcfgc
  autotests/kconfig_compiler/test_param_minmax_main.cpp
  autotests/kconfig_compiler/test_properties_minmax.cpp.ref
  autotests/kconfig_compiler/test_properties_minmax.h.ref
  autotests/kconfig_compiler/test_properties_minmax.kcfg
  autotests/kconfig_compiler/test_properties_minmax.kcfgc
  autotests/kconfig_compiler/test_properties_minmax_main.cpp
  autotests/kconfig_compiler/test_signal.cpp.ref
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27607: Deprecate KDBusConnectionPool

[Volker Krause]

vkrause updated this revision to Diff 76316.
vkrause added a comment.


  Set EXCLUDE_DEPRECATED_BEFORE_AND_AT.

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27607?vs=76241=76316

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27607

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/kdbusconnectionpool.cpp
  src/kdbusconnectionpool.h
  src/kdeinitinterface.cpp

To: vkrause
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27594: Remove unused KDBusConnectionPool include

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:faace55f0bea: Remove unused KDBusConnectionPool include 
(authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27594?vs=76207=76315

REVISION DETAIL
  https://phabricator.kde.org/D27594

AFFECTED FILES
  src/core/kdirnotify.cpp

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

[David Edmundson]

davidedmundson accepted this revision as: davidedmundson.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D23339

REVISION DETAIL
  https://phabricator.kde.org/D23339

To: dvratil, #plasma, #frameworks, apol, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25743: Expose IndexerState enum to QML

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25743

To: davidedmundson, #baloo, ngraham
Cc: broulik, kde-frameworks-devel, ngraham, #baloo, hurikhan77, lots0logs, 
LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, 
astippich, spoorun, bruns, abrahams

D27628: Buttons: allow to scale up icons

[Nathaniel Graham]

ngraham added a comment.


  +1 visually and behaviorally; fixes the issues described in D27260 
 and D27449 
.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

mart edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27628

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27628: Buttons: allow to scale up icons

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  always scale icons unless a size is specified in the api.
  this makes icon sizing more in line with plasma components 2

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/anothersizehint

REVISION DETAIL
  https://phabricator.kde.org/D27628

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml
  src/declarativeimports/plasmacomponents3/TabButton.qml
  src/declarativeimports/plasmacomponents3/ToolButton.qml
  tests/components/toolbutton3.qml

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Nathaniel Graham]

ngraham added a comment.


  Yes, I have 1.9.12. I don't yet have an available update to 1.19.14 or later, 
sadly.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27627: Fix initialization order

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27627

To: dvratil, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  arcpatch-D23339

REVISION DETAIL
  https://phabricator.kde.org/D23339

To: dvratil, #plasma, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27616: [UrlHandler] optimise the code and less if nesting

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> urlhandler.cpp:55
> +// not a KDE application
> +QDesktopServices::openUrl(u);
>  }

won't this recurse forever?

REPOSITORY
  R273 KGuiAddons

REVISION DETAIL
  https://phabricator.kde.org/D27616

To: ahmadsamir, #frameworks, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

[Aleix Pol Gonzalez]

apol accepted this revision.

REPOSITORY
  R252 Framework Integration

BRANCH
  messagewidget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27039

To: davidre, #frameworks, aacid, anthonyfieroni, apol
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27620: [krun] Share implementation of runService and runApplication

[Aleix Pol Gonzalez]

apol added a comment.


  Don't we need KDesktopFile::isAuthorizedDesktopFile now?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27620

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27620: [krun] Share implementation of runService and runApplication

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> krun.cpp:716
> +if (!flags.testFlag(DeleteTemporaryFiles)) {
> +// Remember we opened those urls, for the "recent documents" menu in 
> kicker
> +for (const QUrl  : urls) {

while at it, let's stop calling it kicker?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27620

To: davidedmundson, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27497: Fix code generation for entries with min/max

[Kevin Ottens]

ervin added a comment.


  A few smallish issues only, otherwise LGTM.

INLINE COMMENTS

> KConfigSourceGenerator.cpp:316
>  {
> -   stream() << "  " << itemPath(entry, cfg()) << " = "
> +QString innerItemVarStr(innerItemVar(entry, cfg()));
> +if (!entry->signalList.isEmpty()) {

I'd const it and also use the = style of initialization which I find more 
readable.

> KConfigSourceGenerator.cpp:354
> +QString argBracket = QStringLiteral("[%1]").arg(i);
> +QString innerItemVarStr = innerItemVar(entry, cfg()) + argBracket;
>  

const those please

> KConfigSourceGenerator.cpp:365
> +
> +QString itemVarStr(itemPath(entry, cfg()) + argBracket);
> +

ditto

> kconfig_compiler.cpp:397
>  {
> -if (cfg.itemAccessors) {
> -return QString();
> +QString type = cfg.inherits + "::Item" + itemType(e->type);
> +

const

> kconfig_compiler.cpp:401
> +fCap[0] = fCap[0].toUpper();
> +QString argSuffix = (!e->param.isEmpty()) ? 
> (QStringLiteral("[%1]").arg(e->paramMax + 1)) : QString();
> +QString result;

const

> kconfig_compiler.cpp:462
>  
> -QString newItem(const CfgEntry* entry, const QString , const QString& 
> defaultValue,
> +QString newItemInner(const CfgEntry *entry, const QString , const 
> QString ,
>  const KConfigParameters , const QString ) {

Should be named newInnerItem

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

[Kevin Ottens]

ervin requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27497

To: hchain, meven, crossi, ervin, bport, tcanabrava
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I guess nobody has further input then.
  LGTM. Ship it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24641

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns

D27504: WIP: RFC: smb faster copy to local

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> hallas wrote in kio_smb_dir.cpp:49
> Yes, you could (and should ;) ) use standard C++ for this, i.e.:
> 
>   std::unique_ptr buf;
>   buf = std::make_unique(segmentSize);

we use c++11 so can't use make_unique and QBA seems excessive given the use. I 
am rather tempted to go for QVarLengthArray though, after all, technically the 
buf has a minimal size, so we could always put that on the stack and only alloc 
larger sizes on the heap. Thoughts?

> hallas wrote in kio_smb_dir.cpp:494
> What is the reason to use `QFuture` over `std::future`?

No particular reason, haven't used std::future before is all.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck
Cc: hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, 
pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, 
GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D27502: Create ConfigView an unmanaged ConfigWidget

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> loader.h:6
>   */
> -#ifndef SONNET_LOADER_P_H
> -#define SONNET_LOADER_P_H
> +#ifndef SONNET_LOADER_H
> +#define SONNET_LOADER_H

What's the reason for loader becoming public? If that's mostly out of 
convenience (it looks like it is), I'd advise not turning it public, Settings 
and ConfigView can use it internally but let's not increase the API surface 
even more with Loader.

> settings.cpp:13
>  #include 
> -#include 
>  #include 

Obviously will reappear here ;-)

> settings.cpp:109
>  {
> -if (d->checkUppercase != check) {
> +if (d->checkUppercase != !check) {
>  d->modified = true;

This is an odd bit of logic, isn't it?

> settings.cpp:119
>  {
> -return d->checkUppercase;
> +return !d->checkUppercase;
>  }

Ditto

> settings.h:9
> +
> +#include 
> +#include 

Please remove that include (it'll become more obvious why you'll be able to do 
it with one of the comments below) ;-)

> settings.h:33
> +
> +public:
> +~Settings() override;

Will need a ctor (see other comments) in the form of `explicit Settings(QObject 
*parent = nullptr);`

> settings.h:36
> +
> +Settings(const Settings &) = delete;
> +Settings =(const Settings &) = delete;

This is likely useless now, since we inherit from QObject and QObject is 
non-copyable

> settings.h:37
> +Settings(const Settings &) = delete;
> +Settings =(const Settings &) = delete;
> +

Ditto

> settings.h:79
> +// A static list of KDE specific words that we want to recognize
> +static QStringList defaultIgnoreList()
> +{

Move all the implementations of those static methods to the cpp file.

> settings.h:136
> +private:
> +void readIgnoreList();
> +bool setQuietIgnoreList(const QStringList );

Time to move those to the SettingsPrivate class.

> settings.h:141
> +friend class Loader;
> +explicit Settings(Loader *loader);
> +private:

Might end up disappearing completely, unsure but to be evaluated

> speller.cpp:216
>  case CheckUppercase:
> -d->settings->setCheckUppercase(b);
> +d->settings->setCheckUppercase(!b);
>  break;

And that negation again? We're negating twice now...

> speller.cpp:232
>  case CheckUppercase:
> -return d->settings->checkUppercase();
> +return !d->settings->checkUppercase();
>  case SkipRunTogether:

And again...

I wonder what's happening there, it's highly confusing.

> configview.cpp:33
> +layout->setObjectName(QStringLiteral("SonnetConfigUILayout"));
> +d->wdg = new QWidget(this);
> +d->ui.setupUi(d->wdg);

I'm kind of surprised at this extra widget, can't we get rid of it?

> configview.h:17
> +}
> +#include "sonnetui_export.h"
> +

Please move this line just after the `#include `

> configview.h:23
> +{
> +Q_OBJECT
> +public:

You might want to declare a bunch of Q_PROPERTY there

> configview.h:25
> +public:
> +explicit ConfigView(QWidget *parent, QStringList clients);
> +~ConfigView();

clients should be a const reference (although I suspect it'll disappear)

parent should be the last parameter and default to nullptr

> configview.h:26
> +explicit ConfigView(QWidget *parent, QStringList clients);
> +~ConfigView();
> +

override

> configview.h:30
> +
> +void setPreferredLanguages(const QStringList );
> +QStringList preferredLanguages() const;

All the setters there would make for good public slots

> configview.h:34
> +QString language() const;
> +void setIgnoreList(const QStringList& ignoreList);
> +QStringList ignoreList() const;

Space before & not after

> configview.h:39
> +void setBackgroundCheckingButtonShown(bool);
> +protected Q_SLOTS:
> +void slotIgnoreWordRemoved();

Are they directly called by a subclass outside the library? If not move them to 
the dpointer and use Q_PRIVATE_SLOT

> configview.h:42
> +void slotIgnoreWordAdded();
> +private Q_SLOTS:
> +void slotUpdateButton(const QString );

Move to the d pointer and use Q_PRIVATE_SLOT for those

> configview.h:55
> +ConfigViewPrivate *const d;
> +QStringList m_ignoreList;
> +};

Should be in the d pointer

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D27502

To: bport, #plasma, ervin, crossi, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27627: Fix initialization order

[Daniel Vrátil]

dvratil created this revision.
dvratil added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27627

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/scriptengines/qml/plasmoid/dropmenu.cpp

To: dvratil, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

[Daniel Vrátil]

dvratil added reviewers: Plasma, Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23339

To: dvratil, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D23339: Fix memory leak in ConfigView and Dialog

[Daniel Vrátil]

dvratil updated this revision to Diff 76305.
dvratil added a comment.


  - Rebase on current master

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23339?vs=64284=76305

BRANCH
  arcpatch-D23339

REVISION DETAIL
  https://phabricator.kde.org/D23339

AFFECTED FILES
  src/plasmaquick/configview.cpp
  src/plasmaquick/configview.h
  src/plasmaquick/dialog.h

To: dvratil
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25682: add initial wsdiscovery support

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:41397521423b: add initial wsdiscovery support (authored 
by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25682?vs=73704=76301#toc

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25682?vs=73704=76301

REVISION DETAIL
  https://phabricator.kde.org/D25682

AFFECTED FILES
  smb/CMakeLists.txt
  smb/discovery.cpp
  smb/discovery.h
  smb/dnssddiscoverer.cpp
  smb/dnssddiscoverer.h
  smb/kdsoap-ws-discovery-client/.gitignore
  smb/kdsoap-ws-discovery-client/.gitlab-ci.yml
  smb/kdsoap-ws-discovery-client/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/KDSoapWSDiscoveryClientConfig.cmake.in
  smb/kdsoap-ws-discovery-client/LICENSE
  smb/kdsoap-ws-discovery-client/README.md
  smb/kdsoap-ws-discovery-client/examples/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/main.cpp
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.cpp
  smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.h
  smb/kdsoap-ws-discovery-client/src/CMakeLists.txt
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.cpp
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.h
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.cpp
  smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.h
  smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.cpp
  smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.h
  
smb/kdsoap-ws-discovery-client/wsdl/docs.oasis-open.org/ws-dd/discovery/1.1/os/wsdd-discovery-1.1-schema-os.xsd
  
smb/kdsoap-ws-discovery-client/wsdl/docs.oasis-open.org/ws-dd/discovery/1.1/os/wsdd-discovery-1.1-wsdl-os.wsdl
  smb/kdsoap-ws-discovery-client/wsdl/download.sh
  smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/08/addressing
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/09/transfer/transfer.wsdl
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2004/09/transfer/transfer.xsd
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2005/04/discovery/ws-discovery.wsdl
  
smb/kdsoap-ws-discovery-client/wsdl/schemas.xmlsoap.org/ws/2005/04/discovery/ws-discovery.xsd
  smb/kdsoap-ws-discovery-client/wsdl/www.w3.org/2006/03/addressing/ws-addr.xsd
  smb/kio_smb.h
  smb/kio_smb_browse.cpp
  smb/wsdiscoverer.cpp
  smb/wsdiscoverer.h

To: sitter, dfaure, #frameworks, #dolphin, ngraham
Cc: winterz, meven, schmeisser, bcooksley, ngraham, caspermeijn, 
davidedmundson, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, 
LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D27617: [breeze-icons] Add telegram-desktop tray icons

[Rocket Aaron]

rocka added a comment.


  What's the version of telegram-desktop? Would it still be blue if change 
workspace theme to breeze-dark? If it works fine in breeze-dark and telegram 
version is 1.9.12, it maybe a upstream bug 

 , and was fixed in the latest 1.9.14 release.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27153: port sftp to Result system to force serialization of error/finish condition

[Harald Sitter]

sitter updated this revision to Diff 76300.
sitter added a comment.


  fix problems found by dfaure
  
  I've also added Q_REQUIRED_RESULT to fail() and pass() to help not forget to 
do something with
  the return value. there's no reason to call them and ignore the constructed 
object

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27153?vs=75698=76300

BRANCH
  sftp-errors

REVISION DETAIL
  https://phabricator.kde.org/D27153

AFFECTED FILES
  sftp/kio_sftp.cpp
  sftp/kio_sftp.h

To: sitter, dfaure, feverfew
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D27617: [breeze-icons] Add telegram-desktop tray icons

[Noah Davis]

ndavis added a comment.


  In D27617#616925 , @ngraham wrote:
  
  > Thanks for the patch!
  >
  > But...it's blue: :)
  >
  > F8128783: Screenshot_20200224_073346.png 

  
  
  Weird. I can't see anything obviously wrong in the code. I'll test it later.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch!
  
  But...it's blue: :)
  
  F8128783: Screenshot_20200224_073346.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27617

To: rocka, #vdg, Fuchs
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 258 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/258/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 13:54:12 +
 Build duration:
2 min 33 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 33 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/33/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 24 Feb 2020 13:54:12 +
 Build duration:
2 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 150 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/150/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 13:54:12 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 143 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/143/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 13:54:12 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D27624: only install generated icons if they were generated

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:22a845115bc2: only install generated icons if they were 
generated (authored by sitter).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27624?vs=76288=76292

REVISION DETAIL
  https://phabricator.kde.org/D27624

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt

To: sitter, bshah, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:82fc5404d041: only find bash once (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27622?vs=76285=76291#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27622?vs=76285=76291

REVISION DETAIL
  https://phabricator.kde.org/D27622

AFFECTED FILES
  CMakeLists.txt
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt

To: sitter, bshah, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27624: only install generated icons if they were generated

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27624

To: sitter, bshah, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27622

To: sitter, bshah, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27624: only install generated icons if they were generated

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: bshah.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  which is conditional on not being win32. this should fix win32 builds

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27624

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt

To: sitter, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> CMakeLists.txt:79
> +find_program(BASH_EXE bash)
> +add_feature_info("24x24 generation" BASH_EXE "'bash' is require to 
> generate 24x24 variants")
> +

*required

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27622

To: sitter, bshah
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27622: only find bash once

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27622

To: sitter, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27622: only find bash once

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: bshah.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27622

AFFECTED FILES
  CMakeLists.txt
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt

To: sitter, bshah
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

[David Redondo]

davidre updated this revision to Diff 76284.
davidre added a comment.


  - Introduce Plasma::Theme::palette

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27589?vs=76197=76284

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/plasma/private/theme_p.cpp
  src/plasma/private/theme_p.h
  src/plasma/theme.cpp
  src/plasma/theme.h

To: davidre, #plasma, cblack, ngraham, mart
Cc: mart, wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 142 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/142/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 13:34:52 +
 Build duration:
1 min 45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 149 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/149/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 13:34:52 +
 Build duration:
2 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 257 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/257/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 13:34:52 +
 Build duration:
2 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 32 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/32/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 24 Feb 2020 13:34:52 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 7961 lines...][2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/32/battery-missing.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-error.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-information.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-password.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-positive.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-question.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-warning.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-high.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-low.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-medium.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/alarm-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-missed-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-soon-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-high-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-low-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-medium-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-muted-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/avatar-default-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-charging-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-charging-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charged-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charging-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-symbolic.svg[2020-02-24T13:35:44.141Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software 

D27557: Auto-generate 24px monochrome icons

[Harald Sitter]

sitter added a comment.


  This is now working again. The symlink tests fail though. That still needs 
fixing by someone who isn't me.
  
  Here's my feedback:
  
  For bash or sh scripts:
  
  - make sure a sh script is actually POSIX compliant by running it through a 
POSIX sh implementation
  - if the scripts outcome is relevant you must `set -e` to force all errors to 
also terminate the script and in turn force you to either deal with them or 
explicitly ignore them
  - if your script is doing a lot of stuff you may want to revise how the 
script works. specifically for this diff sed needs to iter all the content of 
all the SVGs this can benefit greatly from running across multiple cores, but 
with the way it is written it cannot. a better solution would be to move the 
for loop into cmake and then construct targets for all files where each target 
calls `generate.sh inputfile` and the shell script only has the logic from 
inside the loop. this effectively gives you free "threading" in that 
cmake/make/ninja know how to run build targets in parallel so by making each 
file its own target you can now utilize all cores of a system without having to 
manage threading manually.
  
  On the cmake side:
  
  - do not ever mutate installation paths (well, exceptions apply ofc, but 
99.9% of the time). they may not be writable and they will not ever be what you 
expect them to be because the paths themselves are mutable in packaging 
scenarios (as in: cmake gets run with path=/usr BUT that's is not at all where 
things get installed when `make install` gets called).
  - setting working directory to current source is bad form. it allows you to 
accidentally pollute or change the source dir, it's undesirable and generally 
speaking relying on relative paths is a bit meh anyway
  - bit nitpicky: but generally when you have any find_* call you'll want some 
cmake FeatureSummary call to go along with that to describe whatever you need 
the finded thing for. specifically since this script is actually bash-dependent 
we need to look for bash, but currently we provide no useful feedback on it 
being missing and the build will just fail on BASH-EXEC_NOT_FOUND or something 
when the relevant target would get run. a cheap solution is to use ` 
add_feature_info` to describe the feature
  
  In general for this diff:
  
  - the introduced script absolutely needs a test. its correct behavior is 
required to have the x24 variants and right now we have no assurances of that
  - as mentioned, I really do not like that this runs at build time. it's not 
very "green". the outcome does not change based on environment, nor is the 
target environment relevant. so a dozen or more developers regularly needlessly 
spend power on generating the ever same mutations of the largely ever same 
files, and every month all distributions do the same, equally needlessly. this 
should only be run when artists add/change icons

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 256 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/256/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 13:01:12 +
 Build duration:
3 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 141 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/141/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 13:01:12 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 148 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/148/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 13:01:12 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 31 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/31/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 24 Feb 2020 13:01:12 +
 Build duration:
1 min 9 sec and counting
   CONSOLE OUTPUT
  [...truncated 7961 lines...][2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/32/battery-missing.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-error.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-information.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-password.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-positive.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-question.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-warning.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-high.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-low.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-medium.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/alarm-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-missed-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-soon-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-high-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-low-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-medium-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-muted-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/avatar-default-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-charging-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-charging-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charged-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charging-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-symbolic.svg[2020-02-24T13:02:20.119Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software 

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:c8bf5e96cf2f: KConfigSkeletonItem : allow to set a 
KconfigGroup to read and write items in… (authored by crossi).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=76281=76282

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Kevin Ottens]

ervin accepted this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 30 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/30/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 24 Feb 2020 12:39:21 +
 Build duration:
1 min 33 sec and counting
   CONSOLE OUTPUT
  [...truncated 7961 lines...][2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/32/battery-missing.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-error.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-information.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-password.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-positive.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-question.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-warning.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-high.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-low.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-medium.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/alarm-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-missed-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-soon-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-high-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-low-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-medium-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-muted-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/avatar-default-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-charging-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-charging-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charged-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charging-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-symbolic.svg[2020-02-24T12:40:52.761Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 147 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/147/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 12:39:20 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 191 lines...][2020-02-24T12:40:05.321Z] PATH  = '/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-02-24T12:40:05.321Z] PROFILEREAD   = 'true'[2020-02-24T12:40:05.321Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-24T12:40:05.321Z] HOSTTYPE  = 'x86_64'[2020-02-24T12:40:05.321Z] BUILD_ID  = '147'[2020-02-24T12:40:05.321Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-24T12:40:05.321Z] OLDPWD= '/home/jenkins'[2020-02-24T12:40:05.321Z] LC_CTYPE  = 'C.UTF-8'[2020-02-24T12:40:05.321Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-24T12:40:05.321Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-24T12:40:05.321Z] QT_SELECT = 'qt5'[2020-02-24T12:40:05.321Z] LANG  = 'en_US.UTF-8'[2020-02-24T12:40:05.321Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T12:40:05.321Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-24T12:40:05.321Z] [2020-02-24T12:40:05.321Z] [2020-02-24T12:40:05.321Z] == Commencing Configuration:[2020-02-24T12:40:05.321Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13"[2020-02-24T12:40:05.596Z] -- The C compiler identification is GNU 9.2.1[2020-02-24T12:40:05.869Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-24T12:40:05.869Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T12:40:05.869Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T12:40:05.869Z] -- Detecting C compiler ABI info[2020-02-24T12:40:05.869Z] -- Detecting C compiler ABI info - done[2020-02-24T12:40:05.869Z] -- Detecting C compile features[2020-02-24T12:40:05.869Z] -- Detecting C compile features - done[2020-02-24T12:40:05.869Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T12:40:06.132Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T12:40:06.132Z] -- Detecting CXX compiler ABI info[2020-02-24T12:40:06.389Z] -- Detecting CXX compiler ABI info - done[2020-02-24T12:40:06.389Z] -- Detecting CXX compile features[2020-02-24T12:40:06.389Z] -- Detecting CXX compile features - done[2020-02-24T12:40:06.389Z] -- [2020-02-24T12:40:06.389Z] [2020-02-24T12:40:06.389Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T12:40:06.389Z] -- Looking for __GLIBC__[2020-02-24T12:40:06.645Z] -- Looking for __GLIBC__ - found[2020-02-24T12:40:06.645Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T12:40:06.645Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T12:40:06.645Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T12:40:06.901Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T12:40:07.158Z] -- The following REQUIRED packages have been found:[2020-02-24T12:40:07.158Z] [2020-02-24T12:40:07.158Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T12:40:07.158Z]  * Qt5Core[2020-02-24T12:40:07.158Z]  * Qt5Test[2020-02-24T12:40:07.158Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T12:40:07.158Z] [2020-02-24T12:40:07.158Z] -- Configuring done[2020-02-24T12:40:07.719Z] -- Generating done[2020-02-24T12:40:07.719Z] CMake Warning:[2020-02-24T12:40:07.719Z]   Manually-specified variables were not used by the project:[2020-02-24T12:40:07.719Z] [2020-02-24T12:40:07.719Z] BUILD_QCH[2020-02-24T12:40:07.719Z] [2020-02-24T12:40:07.719Z] [2020-02-24T12:40:07.719Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T12:40:09.057Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-02-24T12:40:09.057Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T12:40:09.057Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T12:40:09.057Z] Scanning dependencies of target dupe_autogen[2020-02-24T12:40:09.057Z] [  4%] Automatic MOC for target qrcAlias[2020-02-24T12:40:09.057Z] Scanning dependencies of target symlink_autogen[2020-02-24T12:40:09.057Z] [  8%] Automatic MOC for target 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 255 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/255/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 12:39:21 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 199 lines...][2020-02-24T12:40:05.897Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-24T12:40:05.897Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-24T12:40:05.897Z] QT_SELECT = 'qt5'[2020-02-24T12:40:05.897Z] LANG  = 'en_US.UTF-8'[2020-02-24T12:40:05.897Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T12:40:05.897Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-24T12:40:05.897Z] [2020-02-24T12:40:05.897Z] [2020-02-24T12:40:05.897Z] == Commencing Configuration:[2020-02-24T12:40:05.897Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12"[2020-02-24T12:40:06.153Z] -- The C compiler identification is GNU 9.2.1[2020-02-24T12:40:06.153Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-24T12:40:06.153Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T12:40:06.153Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T12:40:06.153Z] -- Detecting C compiler ABI info[2020-02-24T12:40:06.153Z] -- Detecting C compiler ABI info - done[2020-02-24T12:40:06.153Z] -- Detecting C compile features[2020-02-24T12:40:06.153Z] -- Detecting C compile features - done[2020-02-24T12:40:06.153Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T12:40:06.408Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T12:40:06.408Z] -- Detecting CXX compiler ABI info[2020-02-24T12:40:06.408Z] -- Detecting CXX compiler ABI info - done[2020-02-24T12:40:06.408Z] -- Detecting CXX compile features[2020-02-24T12:40:06.408Z] -- Detecting CXX compile features - done[2020-02-24T12:40:06.408Z] -- [2020-02-24T12:40:06.408Z] [2020-02-24T12:40:06.408Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T12:40:06.408Z] -- Looking for __GLIBC__[2020-02-24T12:40:06.663Z] -- Looking for __GLIBC__ - found[2020-02-24T12:40:06.663Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T12:40:06.663Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T12:40:06.663Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T12:40:06.918Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T12:40:07.173Z] -- The following REQUIRED packages have been found:[2020-02-24T12:40:07.173Z] [2020-02-24T12:40:07.173Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T12:40:07.173Z]  * Qt5Core[2020-02-24T12:40:07.173Z]  * Qt5Test[2020-02-24T12:40:07.173Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T12:40:07.173Z] [2020-02-24T12:40:07.173Z] -- Configuring done[2020-02-24T12:40:08.100Z] -- Generating done[2020-02-24T12:40:08.100Z] CMake Warning:[2020-02-24T12:40:08.100Z]   Manually-specified variables were not used by the project:[2020-02-24T12:40:08.100Z] [2020-02-24T12:40:08.100Z] BUILD_QCH[2020-02-24T12:40:08.100Z] [2020-02-24T12:40:08.100Z] [2020-02-24T12:40:08.100Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T12:40:09.541Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-24T12:40:09.542Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T12:40:09.542Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T12:40:09.542Z] Scanning dependencies of target dupe_autogen[2020-02-24T12:40:09.542Z] Scanning dependencies of target symlink_autogen[2020-02-24T12:40:09.542Z] Scanning dependencies of target scalable_autogen[2020-02-24T12:40:09.542Z] Scanning dependencies of target newline_autogen[2020-02-24T12:40:09.542Z] [  4%] Automatic MOC for target qrcAlias[2020-02-24T12:40:09.542Z] [  8%] Automatic MOC for target dupe[2020-02-24T12:40:09.542Z] [ 16%] Automatic MOC for target symlink[2020-02-24T12:40:09.542Z] [ 16%] Automatic MOC for target newline[2020-02-24T12:40:09.542Z] [ 20%] Automatic MOC for target scalable[2020-02-24T12:40:09.542Z] [ 20%] Built target qrcAlias_autogen[2020-02-24T12:40:09.542Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-24T12:40:09.797Z] [ 20%] Built target breeze-icons-mkdir[2020-02-24T12:40:09.797Z] Scanning dependencies of target 

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 140 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/140/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 12:39:20 +
 Build duration:
31 sec and counting
   CONSOLE OUTPUT
  [...truncated 140 lines...][2020-02-24T12:39:44.068Z] QT_SELECT = 'qt5'[2020-02-24T12:39:44.068Z] LANG  = 'en_US.UTF-8'[2020-02-24T12:39:44.068Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T12:39:44.068Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-24T12:39:44.068Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-24T12:39:44.068Z] [2020-02-24T12:39:44.068Z] [2020-02-24T12:39:44.068Z] == Commencing Configuration:[2020-02-24T12:39:44.068Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13"[2020-02-24T12:39:44.326Z] -- The C compiler identification is Clang 8.0.1[2020-02-24T12:39:44.326Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-24T12:39:44.326Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T12:39:44.326Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T12:39:44.326Z] -- Detecting C compiler ABI info[2020-02-24T12:39:44.326Z] -- Detecting C compiler ABI info - done[2020-02-24T12:39:44.326Z] -- Detecting C compile features[2020-02-24T12:39:44.326Z] -- Detecting C compile features - done[2020-02-24T12:39:44.326Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T12:39:44.582Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T12:39:44.582Z] -- Detecting CXX compiler ABI info[2020-02-24T12:39:44.582Z] -- Detecting CXX compiler ABI info - done[2020-02-24T12:39:44.582Z] -- Detecting CXX compile features[2020-02-24T12:39:44.582Z] -- Detecting CXX compile features - done[2020-02-24T12:39:44.582Z] -- [2020-02-24T12:39:44.582Z] [2020-02-24T12:39:44.582Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T12:39:44.582Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-24T12:39:44.582Z] -- Looking for __GLIBC__[2020-02-24T12:39:44.582Z] -- Looking for __GLIBC__ - not found[2020-02-24T12:39:44.582Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T12:39:44.842Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T12:39:44.842Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T12:39:44.842Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T12:39:46.244Z] -- The following REQUIRED packages have been found:[2020-02-24T12:39:46.244Z] [2020-02-24T12:39:46.244Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T12:39:46.244Z]  * Qt5Core[2020-02-24T12:39:46.244Z]  * Qt5Test[2020-02-24T12:39:46.244Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T12:39:46.244Z] [2020-02-24T12:39:46.244Z] -- Configuring done[2020-02-24T12:39:47.612Z] -- Generating done[2020-02-24T12:39:47.612Z] CMake Warning:[2020-02-24T12:39:47.612Z]   Manually-specified variables were not used by the project:[2020-02-24T12:39:47.612Z] [2020-02-24T12:39:47.612Z] BUILD_QCH[2020-02-24T12:39:47.612Z] [2020-02-24T12:39:47.612Z] [2020-02-24T12:39:47.612Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T12:39:49.790Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-02-24T12:39:50.050Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T12:39:50.050Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T12:39:50.050Z] Scanning dependencies of target scalable_autogen[2020-02-24T12:39:50.050Z] Scanning dependencies of target newline_autogen[2020-02-24T12:39:50.050Z] Scanning dependencies of target dupe_autogen[2020-02-24T12:39:50.050Z] Scanning dependencies of target symlink_autogen[2020-02-24T12:39:50.050Z] [  4%] Automatic MOC for target newline[2020-02-24T12:39:50.050Z] [  8%] Automatic MOC for target scalable[2020-02-24T12:39:50.050Z] [ 12%] Automatic MOC for target qrcAlias[2020-02-24T12:39:50.050Z] [ 16%] Automatic MOC for target dupe[2020-02-24T12:39:50.050Z] [ 20%] Automatic MOC for target symlink[2020-02-24T12:39:50.050Z] [ 20%] Built target qrcAlias_autogen[2020-02-24T12:39:50.307Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-24T12:39:50.307Z] [ 20%] Built target breeze-icons-mkdir[2020-02-24T12:39:50.307Z] Scanning dependencies of target 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 146 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/146/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 12:30:46 +
 Build duration:
1 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 197 lines...][2020-02-24T12:31:38.928Z] OLDPWD= '/home/jenkins'[2020-02-24T12:31:38.928Z] LC_CTYPE  = 'C.UTF-8'[2020-02-24T12:31:38.928Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-24T12:31:38.928Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-24T12:31:38.928Z] QT_SELECT = 'qt5'[2020-02-24T12:31:38.928Z] LANG  = 'en_US.UTF-8'[2020-02-24T12:31:38.928Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T12:31:38.928Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-24T12:31:38.928Z] [2020-02-24T12:31:38.928Z] [2020-02-24T12:31:38.928Z] == Commencing Configuration:[2020-02-24T12:31:38.928Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13"[2020-02-24T12:31:39.521Z] -- The C compiler identification is GNU 9.2.1[2020-02-24T12:31:39.521Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-24T12:31:39.785Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T12:31:39.785Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T12:31:39.785Z] -- Detecting C compiler ABI info[2020-02-24T12:31:40.052Z] -- Detecting C compiler ABI info - done[2020-02-24T12:31:40.052Z] -- Detecting C compile features[2020-02-24T12:31:40.052Z] -- Detecting C compile features - done[2020-02-24T12:31:40.052Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T12:31:40.320Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T12:31:40.320Z] -- Detecting CXX compiler ABI info[2020-02-24T12:31:40.610Z] -- Detecting CXX compiler ABI info - done[2020-02-24T12:31:40.610Z] -- Detecting CXX compile features[2020-02-24T12:31:40.610Z] -- Detecting CXX compile features - done[2020-02-24T12:31:40.610Z] -- [2020-02-24T12:31:40.610Z] [2020-02-24T12:31:40.610Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T12:31:40.610Z] -- Looking for __GLIBC__[2020-02-24T12:31:40.887Z] -- Looking for __GLIBC__ - found[2020-02-24T12:31:40.887Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T12:31:41.179Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T12:31:41.179Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T12:31:41.451Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T12:31:41.719Z] -- The following REQUIRED packages have been found:[2020-02-24T12:31:41.719Z] [2020-02-24T12:31:41.719Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T12:31:41.719Z]  * Qt5Core[2020-02-24T12:31:41.719Z]  * Qt5Test[2020-02-24T12:31:41.719Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T12:31:41.719Z] [2020-02-24T12:31:41.719Z] -- Configuring done[2020-02-24T12:31:42.683Z] -- Generating done[2020-02-24T12:31:42.683Z] CMake Warning:[2020-02-24T12:31:42.683Z]   Manually-specified variables were not used by the project:[2020-02-24T12:31:42.683Z] [2020-02-24T12:31:42.683Z] BUILD_QCH[2020-02-24T12:31:42.683Z] [2020-02-24T12:31:42.683Z] [2020-02-24T12:31:42.683Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T12:31:44.499Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-02-24T12:31:44.499Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T12:31:44.499Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T12:31:44.499Z] Scanning dependencies of target symlink_autogen[2020-02-24T12:31:44.803Z] [  4%] Automatic MOC for target qrcAlias[2020-02-24T12:31:44.803Z] Scanning dependencies of target dupe_autogen[2020-02-24T12:31:44.803Z] [ 12%] Automatic MOC for target symlink[2020-02-24T12:31:44.803Z] [ 12%] Automatic MOC for target dupe[2020-02-24T12:31:44.803Z] Scanning dependencies of target newline_autogen[2020-02-24T12:31:44.803Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-24T12:31:44.803Z] Scanning dependencies of target scalable_autogen[2020-02-24T12:31:44.803Z] Scanning dependencies of target breeze-generate-24px-versions[2020-02-24T12:31:44.803Z] [ 16%] Automatic MOC for target newline[2020-02-24T12:31:44.803Z] [ 

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 29 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/29/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 24 Feb 2020 12:30:46 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 7961 lines...][2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/32/battery-missing.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-error.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-information.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-password.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-positive.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-question.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-warning.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-high.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-low.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-medium.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/alarm-symbolic.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-missed-symbolic.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-soon-symbolic.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-high-symbolic.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-low-symbolic.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-medium-symbolic.svg[2020-02-24T12:31:41.225Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-muted-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/avatar-default-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-charging-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-charging-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charged-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charging-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-symbolic.svg[2020-02-24T12:31:41.226Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 254 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/254/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 12:30:46 +
 Build duration:
49 sec and counting
   CONSOLE OUTPUT
  [...truncated 202 lines...][2020-02-24T12:31:31.129Z] LANG  = 'en_US.UTF-8'[2020-02-24T12:31:31.129Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T12:31:31.129Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-24T12:31:31.129Z] [2020-02-24T12:31:31.129Z] [2020-02-24T12:31:31.129Z] == Commencing Configuration:[2020-02-24T12:31:31.129Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12"[2020-02-24T12:31:31.129Z] -- The C compiler identification is GNU 9.2.1[2020-02-24T12:31:31.129Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-24T12:31:31.129Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T12:31:31.385Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T12:31:31.385Z] -- Detecting C compiler ABI info[2020-02-24T12:31:31.385Z] -- Detecting C compiler ABI info - done[2020-02-24T12:31:31.385Z] -- Detecting C compile features[2020-02-24T12:31:31.385Z] -- Detecting C compile features - done[2020-02-24T12:31:31.385Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T12:31:31.385Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T12:31:31.385Z] -- Detecting CXX compiler ABI info[2020-02-24T12:31:31.639Z] -- Detecting CXX compiler ABI info - done[2020-02-24T12:31:31.639Z] -- Detecting CXX compile features[2020-02-24T12:31:31.639Z] -- Detecting CXX compile features - done[2020-02-24T12:31:31.639Z] -- [2020-02-24T12:31:31.639Z] [2020-02-24T12:31:31.639Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T12:31:31.639Z] -- Looking for __GLIBC__[2020-02-24T12:31:31.639Z] -- Looking for __GLIBC__ - found[2020-02-24T12:31:31.639Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T12:31:31.639Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T12:31:31.639Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T12:31:31.894Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T12:31:32.149Z] -- The following REQUIRED packages have been found:[2020-02-24T12:31:32.149Z] [2020-02-24T12:31:32.149Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T12:31:32.149Z]  * Qt5Core[2020-02-24T12:31:32.149Z]  * Qt5Test[2020-02-24T12:31:32.149Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T12:31:32.149Z] [2020-02-24T12:31:32.149Z] -- Configuring done[2020-02-24T12:31:32.708Z] -- Generating done[2020-02-24T12:31:32.708Z] CMake Warning:[2020-02-24T12:31:32.708Z]   Manually-specified variables were not used by the project:[2020-02-24T12:31:32.708Z] [2020-02-24T12:31:32.708Z] BUILD_QCH[2020-02-24T12:31:32.708Z] [2020-02-24T12:31:32.708Z] [2020-02-24T12:31:32.708Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T12:31:33.674Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-24T12:31:33.674Z] Scanning dependencies of target scalable_autogen[2020-02-24T12:31:33.674Z] Scanning dependencies of target breeze-generate-24px-versions[2020-02-24T12:31:33.674Z] Scanning dependencies of target symlink_autogen[2020-02-24T12:31:33.674Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T12:31:33.674Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-24T12:31:33.674Z] Scanning dependencies of target newline_autogen[2020-02-24T12:31:33.674Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T12:31:33.674Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-02-24T12:31:33.674Z] Scanning dependencies of target dupe_autogen[2020-02-24T12:31:33.674Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-02-24T12:31:33.674Z] [  8%] Automatic MOC for target symlink[2020-02-24T12:31:33.674Z] [  8%] Automatic MOC for target qrcAlias[2020-02-24T12:31:33.674Z] [ 12%] Automatic MOC for target scalable[2020-02-24T12:31:33.674Z] [ 16%] Automatic MOC for target newline[2020-02-24T12:31:33.674Z] [ 20%] Automatic MOC for target dupe[2020-02-24T12:31:33.674Z] Using GNU-style sed arguments[2020-02-24T12:31:33.674Z] [ 20%] Built target breeze-icons-mkdir[2020-02-24T12:31:33.674Z] [ 20%] Built target 

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 139 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/139/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 12:30:45 +
 Build duration:
26 sec and counting
   CONSOLE OUTPUT
  [...truncated 138 lines...][2020-02-24T12:31:06.326Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2020-02-24T12:31:06.326Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2020-02-24T12:31:06.326Z] QT_SELECT = 'qt5'[2020-02-24T12:31:06.326Z] LANG  = 'en_US.UTF-8'[2020-02-24T12:31:06.326Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T12:31:06.326Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-24T12:31:06.326Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-24T12:31:06.326Z] [2020-02-24T12:31:06.326Z] [2020-02-24T12:31:06.326Z] == Commencing Configuration:[2020-02-24T12:31:06.326Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13"[2020-02-24T12:31:06.326Z] -- The C compiler identification is Clang 8.0.1[2020-02-24T12:31:06.581Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-24T12:31:06.582Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T12:31:06.582Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T12:31:06.582Z] -- Detecting C compiler ABI info[2020-02-24T12:31:06.582Z] -- Detecting C compiler ABI info - done[2020-02-24T12:31:06.582Z] -- Detecting C compile features[2020-02-24T12:31:06.582Z] -- Detecting C compile features - done[2020-02-24T12:31:06.582Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T12:31:06.837Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T12:31:06.837Z] -- Detecting CXX compiler ABI info[2020-02-24T12:31:06.837Z] -- Detecting CXX compiler ABI info - done[2020-02-24T12:31:06.837Z] -- Detecting CXX compile features[2020-02-24T12:31:06.837Z] -- Detecting CXX compile features - done[2020-02-24T12:31:06.837Z] -- [2020-02-24T12:31:06.837Z] [2020-02-24T12:31:06.837Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T12:31:06.837Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-24T12:31:06.837Z] -- Looking for __GLIBC__[2020-02-24T12:31:06.837Z] -- Looking for __GLIBC__ - not found[2020-02-24T12:31:06.837Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T12:31:06.837Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T12:31:06.837Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T12:31:07.093Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T12:31:07.654Z] -- The following REQUIRED packages have been found:[2020-02-24T12:31:07.654Z] [2020-02-24T12:31:07.654Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T12:31:07.654Z]  * Qt5Core[2020-02-24T12:31:07.654Z]  * Qt5Test[2020-02-24T12:31:07.654Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T12:31:07.654Z] [2020-02-24T12:31:07.654Z] -- Configuring done[2020-02-24T12:31:08.580Z] -- Generating done[2020-02-24T12:31:08.580Z] CMake Warning:[2020-02-24T12:31:08.580Z]   Manually-specified variables were not used by the project:[2020-02-24T12:31:08.580Z] [2020-02-24T12:31:08.580Z] BUILD_QCH[2020-02-24T12:31:08.580Z] [2020-02-24T12:31:08.580Z] [2020-02-24T12:31:08.580Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T12:31:09.885Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-02-24T12:31:09.885Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T12:31:09.885Z] Scanning dependencies of target dupe_autogen[2020-02-24T12:31:09.885Z] Scanning dependencies of target breeze-generate-24px-versions[2020-02-24T12:31:09.885Z] Scanning dependencies of target scalable_autogen[2020-02-24T12:31:09.885Z] Scanning dependencies of target symlink_autogen[2020-02-24T12:31:09.885Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T12:31:09.885Z] Scanning dependencies of target newline_autogen[2020-02-24T12:31:09.885Z] Scanning dependencies of target breeze-icons-mkdir[2020-02-24T12:31:09.885Z] Scanning dependencies of target breeze-icons-dark-mkdir[2020-02-24T12:31:09.885Z] Scanning dependencies of target breeze-generate-24px-versions-dark[2020-02-24T12:31:09.885Z] [ 12%] Automatic MOC for target symlink[2020-02-24T12:31:09.885Z] [ 12%] 

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi marked an inline comment as done.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27059

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27059: KConfigSkeletonItem : allow to set a KconfigGroup to read and write items in nested groups

[Cyril Rossi]

crossi updated this revision to Diff 76281.
crossi added a comment.


  fix comment

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27059?vs=75829=76281

REVISION DETAIL
  https://phabricator.kde.org/D27059

AFFECTED FILES
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h

To: crossi, ervin, dfaure, #frameworks, mdawson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 28 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/28/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Mon, 24 Feb 2020 11:42:35 +
 Build duration:
1 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 7961 lines...][2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/32/battery-missing.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-error.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-information.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-password.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-positive.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-question.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/dialog-warning.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-high.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-low.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/64/security-medium.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/alarm-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-missed-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/appointment-soon-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-high-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-low-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-medium-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/audio-volume-muted-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/avatar-default-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-charging-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-caution-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-charging-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-empty-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charged-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-charging-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software Installs/breeze-icons/bin/data/icons/breeze/status/symbolic/battery-full-symbolic.svg[2020-02-24T11:44:02.839Z] -- Installing: C:/CI/Job Build/install-divert/CI/Software 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 145 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/145/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 24 Feb 2020 11:42:36 +
 Build duration:
57 sec and counting
   CONSOLE OUTPUT
  [...truncated 193 lines...][2020-02-24T11:43:25.459Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-24T11:43:25.459Z] HOSTTYPE  = 'x86_64'[2020-02-24T11:43:25.459Z] BUILD_ID  = '145'[2020-02-24T11:43:25.459Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-24T11:43:25.459Z] OLDPWD= '/home/jenkins'[2020-02-24T11:43:25.459Z] LC_CTYPE  = 'C.UTF-8'[2020-02-24T11:43:25.459Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-24T11:43:25.459Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-24T11:43:25.459Z] QT_SELECT = 'qt5'[2020-02-24T11:43:25.459Z] LANG  = 'en_US.UTF-8'[2020-02-24T11:43:25.459Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T11:43:25.459Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-24T11:43:25.459Z] [2020-02-24T11:43:25.459Z] [2020-02-24T11:43:25.459Z] == Commencing Configuration:[2020-02-24T11:43:25.459Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13"[2020-02-24T11:43:26.384Z] -- The C compiler identification is GNU 9.2.1[2020-02-24T11:43:26.944Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-24T11:43:26.944Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T11:43:27.200Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T11:43:27.200Z] -- Detecting C compiler ABI info[2020-02-24T11:43:27.200Z] -- Detecting C compiler ABI info - done[2020-02-24T11:43:27.200Z] -- Detecting C compile features[2020-02-24T11:43:27.200Z] -- Detecting C compile features - done[2020-02-24T11:43:27.200Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T11:43:27.455Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T11:43:27.455Z] -- Detecting CXX compiler ABI info[2020-02-24T11:43:27.455Z] -- Detecting CXX compiler ABI info - done[2020-02-24T11:43:27.455Z] -- Detecting CXX compile features[2020-02-24T11:43:27.455Z] -- Detecting CXX compile features - done[2020-02-24T11:43:27.455Z] -- [2020-02-24T11:43:27.455Z] [2020-02-24T11:43:27.710Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T11:43:27.710Z] -- Looking for __GLIBC__[2020-02-24T11:43:27.965Z] -- Looking for __GLIBC__ - found[2020-02-24T11:43:27.965Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T11:43:28.220Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T11:43:28.220Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T11:43:28.220Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T11:43:28.780Z] -- The following REQUIRED packages have been found:[2020-02-24T11:43:28.780Z] [2020-02-24T11:43:28.780Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T11:43:28.780Z]  * Qt5Core[2020-02-24T11:43:28.780Z]  * Qt5Test[2020-02-24T11:43:28.780Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T11:43:28.780Z] [2020-02-24T11:43:28.780Z] -- Configuring done[2020-02-24T11:43:29.708Z] -- Generating done[2020-02-24T11:43:29.708Z] CMake Warning:[2020-02-24T11:43:29.708Z]   Manually-specified variables were not used by the project:[2020-02-24T11:43:29.708Z] [2020-02-24T11:43:29.708Z] BUILD_QCH[2020-02-24T11:43:29.708Z] [2020-02-24T11:43:29.708Z] [2020-02-24T11:43:29.708Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T11:43:30.981Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2020-02-24T11:43:30.981Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T11:43:30.981Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T11:43:30.981Z] Scanning dependencies of target symlink_autogen[2020-02-24T11:43:30.981Z] Scanning dependencies of target dupe_autogen[2020-02-24T11:43:30.981Z] Scanning dependencies of target newline_autogen[2020-02-24T11:43:30.981Z] Scanning dependencies of target scalable_autogen[2020-02-24T11:43:30.981Z] [  4%] Automatic MOC for target qrcAlias[2020-02-24T11:43:30.981Z] [  8%] Automatic MOC for target symlink[2020-02-24T11:43:30.981Z] [ 12%] Automatic MOC for 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 253 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/253/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 24 Feb 2020 11:42:36 +
 Build duration:
54 sec and counting
   CONSOLE OUTPUT
  [...truncated 193 lines...][2020-02-24T11:43:24.965Z] MAIL  = '/var/spool/mail/jenkins'[2020-02-24T11:43:24.965Z] HOSTTYPE  = 'x86_64'[2020-02-24T11:43:24.965Z] BUILD_ID  = '253'[2020-02-24T11:43:24.965Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-02-24T11:43:24.965Z] OLDPWD= '/home/jenkins'[2020-02-24T11:43:24.965Z] LC_CTYPE  = 'C.UTF-8'[2020-02-24T11:43:24.965Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-24T11:43:24.965Z] PKG_CONFIG_PATH   = '/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-02-24T11:43:24.965Z] QT_SELECT = 'qt5'[2020-02-24T11:43:24.965Z] LANG  = 'en_US.UTF-8'[2020-02-24T11:43:24.965Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T11:43:24.965Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-02-24T11:43:24.965Z] [2020-02-24T11:43:24.965Z] [2020-02-24T11:43:24.965Z] == Commencing Configuration:[2020-02-24T11:43:24.965Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address' -DBUILD_QCH=TRUE "/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12"[2020-02-24T11:43:24.965Z] -- The C compiler identification is GNU 9.2.1[2020-02-24T11:43:25.221Z] -- The CXX compiler identification is GNU 9.2.1[2020-02-24T11:43:25.221Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T11:43:25.221Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T11:43:25.221Z] -- Detecting C compiler ABI info[2020-02-24T11:43:25.221Z] -- Detecting C compiler ABI info - done[2020-02-24T11:43:25.476Z] -- Detecting C compile features[2020-02-24T11:43:25.476Z] -- Detecting C compile features - done[2020-02-24T11:43:25.476Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T11:43:25.476Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T11:43:25.476Z] -- Detecting CXX compiler ABI info[2020-02-24T11:43:25.476Z] -- Detecting CXX compiler ABI info - done[2020-02-24T11:43:25.476Z] -- Detecting CXX compile features[2020-02-24T11:43:25.476Z] -- Detecting CXX compile features - done[2020-02-24T11:43:25.476Z] -- [2020-02-24T11:43:25.476Z] [2020-02-24T11:43:25.476Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T11:43:25.731Z] -- Looking for __GLIBC__[2020-02-24T11:43:25.731Z] -- Looking for __GLIBC__ - found[2020-02-24T11:43:25.731Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T11:43:25.731Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T11:43:25.731Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T11:43:25.987Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T11:43:26.242Z] -- The following REQUIRED packages have been found:[2020-02-24T11:43:26.242Z] [2020-02-24T11:43:26.242Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T11:43:26.242Z]  * Qt5Core[2020-02-24T11:43:26.242Z]  * Qt5Test[2020-02-24T11:43:26.242Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T11:43:26.242Z] [2020-02-24T11:43:26.242Z] -- Configuring done[2020-02-24T11:43:27.168Z] -- Generating done[2020-02-24T11:43:27.168Z] CMake Warning:[2020-02-24T11:43:27.168Z]   Manually-specified variables were not used by the project:[2020-02-24T11:43:27.168Z] [2020-02-24T11:43:27.168Z] BUILD_QCH[2020-02-24T11:43:27.168Z] [2020-02-24T11:43:27.168Z] [2020-02-24T11:43:27.168Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T11:43:28.366Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2020-02-24T11:43:28.366Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T11:43:28.366Z] Scanning dependencies of target newline_autogen[2020-02-24T11:43:28.366Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T11:43:28.366Z] Scanning dependencies of target dupe_autogen[2020-02-24T11:43:28.366Z] Scanning dependencies of target symlink_autogen[2020-02-24T11:43:28.366Z] Scanning dependencies of target scalable_autogen[2020-02-24T11:43:28.366Z] [  4%] Automatic MOC for target dupe[2020-02-24T11:43:28.366Z] [  8%] Automatic MOC for target qrcAlias[2020-02-24T11:43:28.366Z] [ 12%] Automatic MOC for 

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 138 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/138/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 24 Feb 2020 11:42:36 +
 Build duration:
25 sec and counting
   CONSOLE OUTPUT
  [...truncated 134 lines...][2020-02-24T11:42:55.181Z] SHLVL = '0'[2020-02-24T11:42:55.181Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-02-24T11:42:55.181Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-02-24T11:42:55.181Z] PKG_CONFIG_PATH   = '/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-02-24T11:42:55.181Z] QT_PLUGIN_PATH= '/usr/local/lib/qca-qt5'[2020-02-24T11:42:55.181Z] XDG_CONFIG_DIRS   = '/usr/local/etc/xdg'[2020-02-24T11:42:55.181Z] QT_SELECT = 'qt5'[2020-02-24T11:42:55.181Z] LANG  = 'en_US.UTF-8'[2020-02-24T11:42:55.181Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-02-24T11:42:55.181Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-02-24T11:42:55.181Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-02-24T11:42:55.181Z] [2020-02-24T11:42:55.181Z] [2020-02-24T11:42:55.181Z] == Commencing Configuration:[2020-02-24T11:42:55.181Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/" -DBUILD_QCH=TRUE "/usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13"[2020-02-24T11:42:55.438Z] -- The C compiler identification is Clang 8.0.1[2020-02-24T11:42:55.438Z] -- The CXX compiler identification is Clang 8.0.1[2020-02-24T11:42:55.438Z] -- Check for working C compiler: /usr/bin/cc[2020-02-24T11:42:55.438Z] -- Check for working C compiler: /usr/bin/cc -- works[2020-02-24T11:42:55.438Z] -- Detecting C compiler ABI info[2020-02-24T11:42:55.438Z] -- Detecting C compiler ABI info - done[2020-02-24T11:42:55.438Z] -- Detecting C compile features[2020-02-24T11:42:55.438Z] -- Detecting C compile features - done[2020-02-24T11:42:55.438Z] -- Check for working CXX compiler: /usr/bin/c++[2020-02-24T11:42:55.695Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2020-02-24T11:42:55.695Z] -- Detecting CXX compiler ABI info[2020-02-24T11:42:55.695Z] -- Detecting CXX compiler ABI info - done[2020-02-24T11:42:55.695Z] -- Detecting CXX compile features[2020-02-24T11:42:55.695Z] -- Detecting CXX compile features - done[2020-02-24T11:42:55.695Z] -- [2020-02-24T11:42:55.695Z] [2020-02-24T11:42:55.695Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for BreezeIcons.[2020-02-24T11:42:55.695Z] -- Could not set up the appstream test. appstreamcli is missing.[2020-02-24T11:42:55.695Z] -- Looking for __GLIBC__[2020-02-24T11:42:55.695Z] -- Looking for __GLIBC__ - not found[2020-02-24T11:42:55.695Z] -- Performing Test _OFFT_IS_64BIT[2020-02-24T11:42:55.695Z] -- Performing Test _OFFT_IS_64BIT - Success[2020-02-24T11:42:55.695Z] -- Performing Test HAVE_DATE_TIME[2020-02-24T11:42:55.952Z] -- Performing Test HAVE_DATE_TIME - Success[2020-02-24T11:42:56.514Z] -- The following REQUIRED packages have been found:[2020-02-24T11:42:56.514Z] [2020-02-24T11:42:56.514Z]  * ECM (required version >= 5.67.0), Extra CMake Modules., [2020-02-24T11:42:56.514Z]  * Qt5Core[2020-02-24T11:42:56.514Z]  * Qt5Test[2020-02-24T11:42:56.514Z]  * Qt5 (required version >= 5.12.0)[2020-02-24T11:42:56.514Z] [2020-02-24T11:42:56.514Z] -- Configuring done[2020-02-24T11:42:57.897Z] -- Generating done[2020-02-24T11:42:57.897Z] CMake Warning:[2020-02-24T11:42:57.897Z]   Manually-specified variables were not used by the project:[2020-02-24T11:42:57.897Z] [2020-02-24T11:42:57.897Z] BUILD_QCH[2020-02-24T11:42:57.897Z] [2020-02-24T11:42:57.897Z] [2020-02-24T11:42:57.897Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-02-24T11:42:58.872Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project breeze-icons --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-02-24T11:42:59.137Z] Scanning dependencies of target breeze-validate-svg[2020-02-24T11:42:59.137Z] Scanning dependencies of target scalable_autogen[2020-02-24T11:42:59.137Z] Scanning dependencies of target qrcAlias_autogen[2020-02-24T11:42:59.137Z] Scanning dependencies of target dupe_autogen[2020-02-24T11:42:59.137Z] Scanning dependencies of target newline_autogen[2020-02-24T11:42:59.137Z] Scanning dependencies of target symlink_autogen[2020-02-24T11:42:59.137Z] [  4%] Automatic MOC 

D27614: build: fix the build where install prefix is not user-writable

[Bhushan Shah]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:462c5dfe2e9a: build: fix the build where install prefix 
is not user-writable (authored by bshah).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27614?vs=76278=76279

REVISION DETAIL
  https://phabricator.kde.org/D27614

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt
  validate_svg.sh

To: bshah, ngraham, lbeltrame, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27614: build: fix the build where install prefix is not user-writable

[Bhushan Shah]

bshah updated this revision to Diff 76278.
bshah added a comment.


  rebase

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27614?vs=76256=76278

BRANCH
  bshah/fix-build

REVISION DETAIL
  https://phabricator.kde.org/D27614

AFFECTED FILES
  icons-dark/CMakeLists.txt
  icons/CMakeLists.txt
  validate_svg.sh

To: bshah, ngraham, lbeltrame, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27557: Auto-generate 24px monochrome icons

[David Redondo]

davidre added a comment.


  I disagree but it's not my call

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Harald Sitter]

sitter added a comment.


  @davidre we provide a theme, if someone explicitly looks for a specific file 
within that theme that'd be squarely outside the supported realm of a theme. 
it'd prevent improving the theme which may mean changing scaling rules and 
removing the then useless sizes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[David Redondo]

davidre added a comment.


  Also we need to have this on Windows, too.
  Breeze-icons is part of Frameworks and these were exported/installed files. A 
user could easily have a reference to one of the files somewhere.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, ngraham, bruns

D27557: Auto-generate 24px monochrome icons

[Noah Davis]

ndavis added a comment.


  Should we just revert for now?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27557

To: ngraham, #vdg, ndavis, #frameworks, sitter
Cc: bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27614: build: fix the build where install prefix is not user-writable

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I'd rather have the excess spaces been done away with. Otherwise LGTM, please 
rebase and land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  bshah/fix-build

REVISION DETAIL
  https://phabricator.kde.org/D27614

To: bshah, ngraham, lbeltrame, sitter
Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns