D27769: modemmanager-qt: Convert license headers to SPDX expressions

2020-03-01 Thread Jan Grulich 
jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27769

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 319 - Still Unstable!

2020-03-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/319/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Mon, 02 Mar 2020 04:42:35 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34833/62097)40%
(17687/43858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4538/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8730/14616)51%
(4509/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4667/8327)43%
(2071/4808)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4288)36%
(1309/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

D26095: kio EBN constructor cleanup

2020-03-01 Thread John Hayes 
jhayes abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26095

To: jhayes
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26092: kidletime EBN constructor cleanup

2020-03-01 Thread John Hayes 
jhayes abandoned this revision.

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D26092

To: jhayes, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 444 - Still Unstable!

2020-03-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/444/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 02 Mar 2020 04:42:35 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.68.0.xmllogs/KF5KIO/5.68.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiofilewidgets_knewfilemenutestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34812/62097)40%
(17700/43862)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9732/10191)47%
(4542/9638)autotests.http100%
(5/5)100%
(5/5)99%
(580/581)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(104/118)88%
(104/118)60%
(8726/14617)51%
(4517/8835)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4666/8327)43%
(2072/4812)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(680/1269)39%
(390/1000)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(645/1372)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1791/4288)36%
(1311/3636)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)47%
(632/1331)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 310 - Still Unstable!

2020-03-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/310/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Mar 2020 04:42:35 +
 Build duration:
8 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiofilewidgets_knewfilemenutestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 112 - Still Unstable!

2020-03-01 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/112/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 02 Mar 2020 01:57:41 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns edited the summary of this revision.
bruns added a dependency: D27766: [ModifiedFileIndexer] Omit BasicIndexingJob 
run when not required.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Stefan Brüns 
bruns added a dependent revision: D27767: [ModifiedFileIndexer] Correct time 
checks for new files.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns updated this revision to Diff 76744.
bruns added a comment.


  const

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27767?vs=76735=76744

REVISION DETAIL
  https://phabricator.kde.org/D27767

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D27772: [WriteTransaction] Extend position test case

2020-03-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Until now, the case where a term was kept but all positions for the term
  are removed was not covered. Add a test case.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27772

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

2020-03-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  As the following addTerms() does another reserve() with growing by
  terms.size() sum up both sizes. The reserve() in addTerms() is a
  noop then.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27771

AFFECTED FILES
  src/engine/writetransaction.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-01 Thread Carson Black 
cblack added a comment.


  Would the version number already being 9 in old versions of KWayland cause 
any issues? I have a feeling old KWayland versions may not like it when they're 
sent events they don't recognize, unless libwayland/KWayland handle that 
usecase.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:74
> +bool cTimeChanged;
> +bool isKnownFile = tr.hasDocument(fileId);
> +if (isKnownFile) {

const?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27767

To: bruns, #baloo, ngraham
Cc: astippich, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, spoorun, ngraham, bruns, 
abrahams

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-03-01 Thread Alexander Saoutkin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R283:f53d6a29a049: [KAuth] Add support for action details in 
Polkit1 backend. (authored by feverfew).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21795?vs=76739=76740

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-03-01 Thread Alexander Saoutkin 
feverfew updated this revision to Diff 76739.
feverfew added a comment.


  - Fix &
  - Use enum class
  - Use enum instead of string comparison

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21795?vs=76497=76739

BRANCH
  arcpatch-D21795_2

REVISION DETAIL
  https://phabricator.kde.org/D21795

AFFECTED FILES
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/HelperProxy.h
  src/backends/dbus/DBusHelperProxy.cpp
  src/backends/dbus/DBusHelperProxy.h
  src/backends/dbus/org.kde.kf5auth.xml
  src/backends/fake/FakeBackend.cpp
  src/backends/fake/FakeBackend.h
  src/backends/fakehelper/FakeHelperProxy.cpp
  src/backends/fakehelper/FakeHelperProxy.h
  src/backends/mac/AuthServicesBackend.cpp
  src/backends/mac/AuthServicesBackend.h
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h
  src/kauthaction.cpp
  src/kauthaction.h
  src/kauthexecutejob.cpp

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, GB_2, michaelh, bruns

Re: kreversi 19.12 fails to build at IconSize call

2020-03-01 Thread Ben Cooksley 
On Mon, Mar 2, 2020 at 2:19 AM Christoph Feck  wrote:
>
> Hi,
>
> kreversi release/19.12 branch fails to build with this error on CI:
>
>
> pageItem->setIcon(QIcon::fromTheme(icon).pixmap(IconSize(KIconLoader::Toolbar)));
>  error: IconSize was not declared in this scope
>
> See
> https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kreversi/
>
> Additionally, kwordquiz fails to build on Windows CI,
> see
> https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kwordquiz/

The KWordQuiz error is due to a regression in Frameworks, the fix for
which is at https://phabricator.kde.org/D27355

>
> I would be glad if someone could investigate these issues.
>
> Thanks,
> Christoph

Cheers,
Ben

>
> --
> Christoph Feck
> KDE Release Team

D27355: POC: Make kstatusnotifieritem available without dbus

2020-03-01 Thread Ben Cooksley 
bcooksley added a comment.


  Have you had a chance to look into this @broulik?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27355

To: vonreth, bcooksley, jjazeix, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27769: modemmanager-qt: Convert license headers to SPDX expressions

2020-03-01 Thread Andreas Cord-Landwehr 
cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added a reviewer: jgrulich.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX expressions and add license
  files as required by REUSE specification.

REPOSITORY
  R281 ModemManagerQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27769

AFFECTED FILES
  .Doxyfile.cmake
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/bearerpropertiestest.cpp
  autotests/bearerpropertiestest.h
  autotests/modem3gpppropertiestest.cpp
  autotests/modem3gpppropertiestest.h
  autotests/modem3gppussdpropertiestest.cpp
  autotests/modem3gppussdpropertiestest.h
  autotests/modemcdmapropertiestest.cpp
  autotests/modemcdmapropertiestest.h
  autotests/modemlocationpropertiestest.cpp
  autotests/modemlocationpropertiestest.h
  autotests/modemmessagingpropertiestest.cpp
  autotests/modemmessagingpropertiestest.h
  autotests/modemomapropertiestest.cpp
  autotests/modemomapropertiestest.h
  autotests/modempropertiestest.cpp
  autotests/modempropertiestest.h
  autotests/modemtest.cpp
  autotests/modemtest.h
  autotests/modemtimepropertiestest.cpp
  autotests/modemtimepropertiestest.h
  cmake/FindModemManager.cmake
  examples/main.cpp
  src/bearer.cpp
  src/bearer.h
  src/bearer_p.h
  src/call.cpp
  src/call.h
  src/call_p.h
  src/dbus/dbus.h
  src/dbus/fakedbus.h
  src/fakemodem/bearer.cpp
  src/fakemodem/bearer.h
  src/fakemodem/fakemodem.cpp
  src/fakemodem/fakemodem.h
  src/fakemodem/modem.cpp
  src/fakemodem/modem.h
  src/fakemodem/modem3gpp.cpp
  src/fakemodem/modem3gpp.h
  src/fakemodem/modem3gppussd.cpp
  src/fakemodem/modem3gppussd.h
  src/fakemodem/modemcdma.cpp
  src/fakemodem/modemcdma.h
  src/fakemodem/modemlocation.cpp
  src/fakemodem/modemlocation.h
  src/fakemodem/modemmessaging.cpp
  src/fakemodem/modemmessaging.h
  src/fakemodem/modemoma.cpp
  src/fakemodem/modemoma.h
  src/fakemodem/modemsimple.cpp
  src/fakemodem/modemsimple.h
  src/fakemodem/modemtime.cpp
  src/fakemodem/modemtime.h
  src/fakemodem/objectmanager.cpp
  src/fakemodem/objectmanager.h
  src/fakemodem/sms.cpp
  src/fakemodem/sms.h
  src/generictypes.cpp
  src/generictypes.h
  src/generictypes_p.h
  src/interface.cpp
  src/interface.h
  src/interface_p.h
  src/macros_p.h
  src/manager.cpp
  src/manager.h
  src/manager_p.h
  src/mmdebug_p.h
  src/modem.cpp
  src/modem.h
  src/modem3gpp.cpp
  src/modem3gpp.h
  src/modem3gpp_p.h
  src/modem3gppussd.cpp
  src/modem3gppussd.h
  src/modem3gppussd_p.h
  src/modem_p.h
  src/modemcdma.cpp
  src/modemcdma.h
  src/modemcdma_p.h
  src/modemdevice.cpp
  src/modemdevice.h
  src/modemdevice_p.h
  src/modemfirmware.cpp
  src/modemfirmware.h
  src/modemfirmware_p.h
  src/modemlocation.cpp
  src/modemlocation.h
  src/modemlocation_p.h
  src/modemmessaging.cpp
  src/modemmessaging.h
  src/modemmessaging_p.h
  src/modemoma.cpp
  src/modemoma.h
  src/modemoma_p.h
  src/modemsignal.cpp
  src/modemsignal.h
  src/modemsignal_p.h
  src/modemsimple.cpp
  src/modemsimple.h
  src/modemsimple_p.h
  src/modemtime.cpp
  src/modemtime.h
  src/modemtime_p.h
  src/modemvoice.cpp
  src/modemvoice.h
  src/modemvoice_p.h
  src/sim.cpp
  src/sim.h
  src/sim_p.h
  src/sms.cpp
  src/sms.h
  src/sms_p.h

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27769: modemmanager-qt: Convert license headers to SPDX expressions

2020-03-01 Thread Andreas Cord-Landwehr 
cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R281 ModemManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D27769

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in modifiedfileindexer.cpp:118
> This check is redundant now, we here only when `cTimeChanged` is true.

I saw it in other patch, i does not need change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:118
>  if (tr.hasDocument(job.document().id())) {
>  if (cTimeChanged) {
>  tr.replaceDocument(job.document(), XAttrTerms | DocumentTime 
> | FileNameTerms | DocumentUrl);

This check is redundant now, we here only when `cTimeChanged` is true.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D27766

To: bruns, #baloo, ngraham
Cc: anthonyfieroni, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, 
cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D27767: [ModifiedFileIndexer] Correct time checks for new files

2020-03-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case baloo has just started, a new and immediately modified file can
  end up in the ModifiedFileIndexer. In this case, the timestamps default
  to 0. As a 0 timestamp also occasionally appears e.g. for files from
  archives (tar, zip ...) these would be treated as unchanged and not be
  added to the index.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27767

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27766: [ModifiedFileIndexer] Omit BasicIndexingJob run when not required

2020-03-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case only the mtime has changed (i.e. only contents), only the times
  and the content indexing flag have to be updated in the DB. The times
  are already available from the fileinfo, so no need to create a
  BasicIndexingJob.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27766

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

2020-03-01 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Counting the number of files to be indexed (m_provider->size()) can
  be significantly more costly than checking if the next batch is empty.
  Also the m_stop condition was checked twice.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27765

AFFECTED FILES
  src/file/filecontentindexer.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27528: Adapt action numbering in Android to work like in KNotifications

2020-03-01 Thread Nicolas Fella 
nicolasfella closed this revision.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27528

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: jbbgameich, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

2020-03-01 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:92f5564da771: Adapt action numbering in Android to work 
like in KNotifications (authored by cacahueto, committed by nicolasfella).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27740?vs=76685=76732

REVISION DETAIL
  https://phabricator.kde.org/D27740

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, jbbgameich, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27740: Adapt action numbering in Android to work like in KNotifications

2020-03-01 Thread Nicolas Fella 
nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  adapt-action-numbering-in-android (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27740

To: cacahueto, #frameworks, nicolasfella, vkrause
Cc: kde-frameworks-devel, jbbgameich, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

T10262: Integrate KIO Slaves into file system using FUSE gateway

2020-03-01 Thread Nathaniel Graham 
ngraham closed subtask T10263: FUSE daemon for accessing KIO Slaves as 
Resolved.

TASK DETAIL
  https://phabricator.kde.org/T10262

To: cfeck, ngraham
Cc: chinmoyr, fvogt, feverfew, #frameworks, ngraham, #dolphin, cfeck, 
pberestov, iasensio, fprice, MrPepe, fbampaloukas, alexde, Codezela, meven, 
spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov

Re: kreversi 19.12 fails to build at IconSize call

2020-03-01 Thread Ahmad Samir 

On 01/03/2020 15:17, Christoph Feck wrote:

Hi,

kreversi release/19.12 branch fails to build with this error on CI:


pageItem->setIcon(QIcon::fromTheme(icon).pixmap(IconSize(KIconLoader::Toolbar))); 


     error: IconSize was not declared in this scope

See 
https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kreversi/ 



Already fixed in master branch, by 
https://cgit.kde.org/kreversi.git/commit/?id=1ec3546075044ce6d0c7d1ba4ff794c6fcaa0ee1





Additionally, kwordquiz fails to build on Windows CI,
see 
https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kwordquiz/ 



I would be glad if someone could investigate these issues.

Thanks,
Christoph




--
Ahmad Samir

kreversi 19.12 fails to build at IconSize call

2020-03-01 Thread Christoph Feck 

Hi,

kreversi release/19.12 branch fails to build with this error on CI:


pageItem->setIcon(QIcon::fromTheme(icon).pixmap(IconSize(KIconLoader::Toolbar)));
error: IconSize was not declared in this scope

See 
https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kreversi/


Additionally, kwordquiz fails to build on Windows CI,
see 
https://build.kde.org/job/Applications/view/Everything%20-%20stable-kf5-qt5/job/kwordquiz/


I would be glad if someone could investigate these issues.

Thanks,
Christoph

--
Christoph Feck
KDE Release Team

D27760: WIP | Added BatchMoveJob

2020-03-01 Thread Emirald Mateli 
emateli added a comment.


  In that it supports moving them to different directories but as well as 
moving them with a different name. This operation is to allow also batch 
renaming of items. See this patch for more details: D14631 

  
  eg: BatchMove {`a.txt -> Sample.txt`, `b.md -> new/Readme.md`}.  In the 
context of the mentioned patch the directory wouldn't change of course, but 
this is also a more generic move job. Move these files from here to somewhere 
else in a single job (also so that a single undo reverts everything back to the 
original place).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D26211: Port QRegExp to QRegularExpression

2020-03-01 Thread Ahmad Samir 
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:633a9f22340b: Port QRegExp to QRegularExpression 
(authored by ahmadsamir).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26211?vs=76705=76724

REVISION DETAIL
  https://phabricator.kde.org/D26211

AFFECTED FILES
  data/parsetrigrams.cpp

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27760: WIP | Added BatchMoveJob

2020-03-01 Thread Nicolas Fella 
nicolasfella added a comment.


  What's the difference to the job you get with KIO::move with a list of urls? 
https://api.kde.org/frameworks/kio/html/namespaceKIO.html#a20da0b04660f834de30f9440673f6d5e

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27760: WIP | Added BatchMoveJob

2020-03-01 Thread Emirald Mateli 
emateli retitled this revision from "Added BatchMoveJob" to "WIP | Added 
BatchMoveJob".
emateli edited the summary of this revision.
emateli added reviewers: dfaure, ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27760

To: emateli, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26211: Port QRegExp to QRegularExpression

2020-03-01 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks, guess that should go in now.

REPOSITORY
  R246 Sonnet

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26211

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27760: Added BatchMoveJob

2020-03-01 Thread Emirald Mateli 
emateli created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
emateli requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  batchmove

REVISION DETAIL
  https://phabricator.kde.org/D27760

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/batchmovejobtest.cpp
  src/core/CMakeLists.txt
  src/core/batchmovejob.cpp
  src/core/batchmovejob.h
  src/widgets/fileundomanager.h

To: emateli
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25315: KDirModel: implement showing a root node for the requested URL

2020-03-01 Thread David Faure 
dfaure added a comment.


  Well, I don't have your code. Which calls are you making into KDirModel? 
(openUrl(args=?), expandToUrl(args=?))

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-03-01 Thread Volker Krause 
vkrause added a comment.


  In D26749#620142 , @apol wrote:
  
  > Seems ready to land to me.
  
  
  It does seem to break poppler in the old setup here, not sure yet why though. 
If we land the docker change as well that is probably acceptable though.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26749

To: vkrause, apol
Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
GB_2, bencreasy, michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

2020-03-01 Thread Ahmad Samir 
ahmadsamir added a comment.


  To get those numbers I tested with this code:
  
QFontDatabase fdb;
const QStringList fontFamilies = fdb.families();
QStringList list;
int regularCnt = 0;
int normalCnt = 0;
int bookCnt = 0;
int romanCnt = 0;
for (const QString  : fontFamilies) {
const QStringList styles = fdb.styles(family);
for (const QString  : styles) {
if (s == QLatin1String("Regular")) {
++regularCnt;
} else if (s == QLatin1String("Normal")) {
++normalCnt;
} else if (s == QLatin1String("Book")) {
++bookCnt;
} else if (s == QLatin1String("Roman")) {
++romanCnt;
}
}
}

qDebug() << "Regular: " << regularCnt;
qDebug() << "Normal: " << normalCnt;
qDebug() << "Book: " << bookCnt;
qDebug() << "Roman: " << romanCnt;

REPOSITORY
  R237 KConfig

BRANCH
  l-font-sytleName (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27735

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

2020-03-01 Thread Ahmad Samir 
ahmadsamir updated this revision to Diff 76721.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Add some relevant statistics

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27735?vs=76682=76721

BRANCH
  l-font-sytleName (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27735

AFFECTED FILES
  src/gui/kconfiggroupgui.cpp

To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26342: Allow overriding to disable auto language detection

2020-03-01 Thread Michel Ludwig 
mludwig added a comment.


  @Simon: If you add a call 'setAutoDetectLanguageDisabled(false)' to 
'BackgroundChecker::changeLanguage' and 'BackgroundChecker::setSpeller', you 
should be able to take Albert's suggestion into account.
  
  For the Highlighter it should be similar.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26342

To: sdepiets, #frameworks, cullmann, mlaurent, mludwig
Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns