KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 322 - Still Unstable!

2020-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/322/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 09 Mar 2020 04:49:16 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27910: Make sure warning output is enabled before testing if the correct warning is printed

2020-03-08 Thread Aleix Pol Gonzalez 
apol added a comment.


  Is it passing on the CI because somehow we enable warnings on there?
  
https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.13/60/testReport/

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D27910

To: sandsmark, dfaure
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27883: Register spawned applications as an independent cgroups

2020-03-08 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> kprocessrunner.cpp:51
> +
> +std::once_flag dbusTypesRegistered;
> +

This could be in the function scope as static.

> kprocessrunner.cpp:281
> +{
> +if (!qEnvironmentVariableIsSet("KDE_APPLICATIONS_AS_SCOPE")) {
> +return;

Who defines this environment variable?

> kprocessrunner.cpp:301
> +const QString mode = QStringLiteral("fail"); // mode defines what to do 
> in the case of a name conflict, in this case, just do nothing
> +NamedVariantList properties;
> +QList> aux; // unused, but we need the 
> signatue to be correct;

Declare and define together

> kprocessrunner.cpp:302
> +NamedVariantList properties;
> +QList> aux; // unused, but we need the 
> signatue to be correct;
> +

*signatuRe

Also I'm not sure I understand...

> kprocessrunner.cpp:308
> +message.setArguments({name, mode, QVariant::fromValue(properties), 
> QVariant::fromValue(aux)});
> +QDBusConnection::sessionBus().call(message);
> +}

Does this need to be sync?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27883

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27927: Use more flexible shebang

2020-03-08 Thread Harald Sitter 
sitter accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27927

To: tcberner, #freebsd, sitter, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Noah Davis 
ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Noah Davis 
ndavis added a comment.


  It's a systray icon, so it doesn't need to have a 16px version

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27936: Windows: Add suport for file date creation

2020-03-08 Thread Méven Car 
meven created this revision.
meven added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27936

AFFECTED FILES
  src/ioslaves/file/file_win.cpp

To: meven, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

2020-03-08 Thread Méven Car 
meven updated this revision to Diff 77235.
meven added a comment.


  Get code ready for 5.69, I really HOPE that the last time I have to do this, 
remove a few qDebug(), add some test assertions, make test more reliable

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25010?vs=75740=77235

BRANCH
  arcpatch-D25010

REVISION DETAIL
  https://phabricator.kde.org/D25010

AFFECTED FILES
  autotests/jobremotetest.cpp
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/CMakeLists.txt
  src/core/copyjob.cpp
  src/core/deletejob.cpp
  src/core/directorysizejob.cpp
  src/core/global.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/filewidgets/kdiroperator.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/widgets/krun.cpp
  src/widgets/paste.cpp
  tests/kioslavetest.cpp
  tests/listjobtest.cpp

To: meven, #frameworks, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27882: Move KProcessRunner into it's own file

2020-03-08 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27882

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

2020-03-08 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

INLINE COMMENTS

> surface_interface.h:348
> +/**
> + * Emitted whenever a new child sub-surface @p subSurface is added.
> + */

Include @since

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27860

To: zzag, #kwin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

2020-03-08 Thread Méven Car 
meven added a comment.


  In D27833#622353 , @apol wrote:
  
  > What's the use-case?
  
  
  Originally D27934  was needing it, but in 
the end this is not needed anymore, so I think it should be best to postpone 
this change for KF6, avoiding to introduces those BC shenanigans.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27833

To: meven, ervin, bport, crossi, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27913: Icons for emoji categories

2020-03-08 Thread Yunhe Guo 
guoyunhe added a comment.


  In D27913#624159 , @ngraham wrote:
  
  > If we do this, then won't the category icons look different from the actual 
emoji icons when using a font where the emojis look different?
  
  
  Hi @ngraham , the main idea is to make the left panel use only Breeze icons.
  
  Reference design in Telegram Desktop:
  
  F8145244: image.png 
  
  In WhatsApp:
  
  F8145247: image.png 
  
  In this way we can choose what the icon look like.
  
  Current implementation renders the first emoji in the category. You can see 
the "Objects" category is a "Muted" emoji. And the "Symbols" icon is an "ATM" 
emoji. They don't fit the category very well.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-08 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:ec207330d5bd: KconfigXT: Add a value attribute to Enum 
field choices (authored by meven).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=77225=77226

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-03-08 Thread Méven Car 
meven updated this revision to Diff 77225.
meven added a comment.


  Rebase on master

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27463?vs=77077=77225

BRANCH
  arcpatch-D27463_2

REVISION DETAIL
  https://phabricator.kde.org/D27463

AFFECTED FILES
  autotests/kconfig_compiler/test4.cpp.ref
  autotests/kconfig_compiler/test4.kcfg
  autotests/kconfig_compiler/test5.cpp.ref
  autotests/kconfig_compiler/test5.kcfg
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kcoreconfigskeleton_p.h
  src/kconfig_compiler/KConfigCommonStructs.h
  src/kconfig_compiler/KConfigSourceGenerator.cpp
  src/kconfig_compiler/KConfigXmlParser.cpp
  src/kconfig_compiler/README.dox
  src/kconfig_compiler/kcfg.xsd

To: meven, ervin, bport, crossi, #frameworks
Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Ariel AxionL 
axionl marked an inline comment as done.
axionl added a comment.


  In D27926#624240 , @ngraham wrote:
  
  > Nice!
  >
  > Do you think you could also make 16px versions?
  
  
  Sorry, maybe not. The 16px space is too small to get the correct angle to 
convert 1px thick strokes to paths on Inkscape.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D25315: KDirModel: implement showing a root node for the requested URL

2020-03-08 Thread Ahmad Samir 
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kdirmodel.h:79
> That sounds more confusing to me, depending on how one thinks about all this.
> 
> There's nothing special about the first child compared to other direct 
> children, one misinterpretation of your suggested sentence would be that the 
> first child will be shown but not its siblings.
> 
> If ShowRoot is not set, then the given URL isn't shown, its children are. All 
> of them :)

Fair point.

> dfaure wrote in kdirmodeltest_gui.cpp:92
> Making file:/// work was actually more trouble so it's worth having an easy 
> way to test this. This is an interactive test anyway, you can pass 
> /usr/share/fonts as argument if you want to test that path :-)

I did test the /usr/share/fonts path :); it's just that starting at "/" looked 
"normal", whereas starting at a specific dir conveyed the goal of this change 
better, to me anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  Nice!
  
  Do you think you could also make 16px versions?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D25315: KDirModel: implement showing a root node for the requested URL

2020-03-08 Thread David Faure 
dfaure marked an inline comment as done.
dfaure added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kdirmodel.h:79
> I suggest:
> s/its children/the first child/ OR
> s/at its children/directly at the first child/

That sounds more confusing to me, depending on how one thinks about all this.

There's nothing special about the first child compared to other direct 
children, one misinterpretation of your suggested sentence would be that the 
first child will be shown but not its siblings.

If ShowRoot is not set, then the given URL isn't shown, its children are. All 
of them :)

> ahmadsamir wrote in kdirmodeltest_gui.cpp:92
> I think a test with "file:///usr/share/fonts" would work better, i.e. the url 
> arg is the top/focus of the model.

Making file:/// work was actually more trouble so it's worth having an easy way 
to test this. This is an interactive test anyway, you can pass /usr/share/fonts 
as argument if you want to test that path :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25315

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25315: KDirModel: implement showing a root node for the requested URL

2020-03-08 Thread David Faure 
dfaure updated this revision to Diff 77224.
dfaure added a comment.


  Add missing braces around one-line if()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25315?vs=77155=77224

BRANCH
  2019_11_kdirmodel_root

REVISION DETAIL
  https://phabricator.kde.org/D25315

AFFECTED FILES
  autotests/kdirmodeltest.cpp
  autotests/kdirmodeltest.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kdirmodeltest_gui.cpp

To: dfaure, stefanocrocco, elvisangelaccio, meven, apol
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Ariel AxionL 
axionl updated this revision to Diff 77223.
axionl added a comment.


  Update flameshot tray icon.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27926?vs=77197=77223

REVISION DETAIL
  https://phabricator.kde.org/D27926

AFFECTED FILES
  icons-dark/status/22/flameshot-tray.svg
  icons/status/22/flameshot-tray.svg

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27909: Move barcode image scaling logic to AbstractBarcode

2020-03-08 Thread Sune Vuorela 
svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  pending

REVISION DETAIL
  https://phabricator.kde.org/D27909

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Still Unstable!

2020-03-08 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/85/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 08 Mar 2020 16:21:18 +
 Build duration:
1 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D27562: [kcmcontrols] Respect header/footer visibility

2020-03-08 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0dad857cddfb: [kcmcontrols] Respect header/footer 
visibility (authored by nicolasfella).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27562?vs=76136=77221

REVISION DETAIL
  https://phabricator.kde.org/D27562

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridViewKCM.qml
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: nicolasfella, #plasma, mart, ngraham
Cc: iasensio, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27562: [kcmcontrols] Respect header/footer visibility

2020-03-08 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  rhv

REVISION DETAIL
  https://phabricator.kde.org/D27562

To: nicolasfella, #plasma, mart, ngraham
Cc: iasensio, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27927: Use more flexible shebang

2020-03-08 Thread Nathaniel Graham 
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27927

To: tcberner, #freebsd, sitter, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27913: Icons for emoji categories

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  If we do this, then won't the category icons look different from the actual 
emoji icons when using a font where the emojis look different?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27913

To: guoyunhe, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

2020-03-08 Thread Andreas Cord-Landwehr 
cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D27932

To: cordlandwehr, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

2020-03-08 Thread Andreas Cord-Landwehr 
cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added a reviewer: jgrulich.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX expressions
  and add license files as required by REUSE specification.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D27932

AFFECTED FILES
  .Doxyfile.cmake
  LICENSES/BSD-3-Clause.txt
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  autotests/activeconnectiontest.cpp
  autotests/activeconnectiontest.h
  autotests/managertest.cpp
  autotests/managertest.h
  autotests/settings/8021xsettingtest.cpp
  autotests/settings/8021xsettingtest.h
  autotests/settings/adslsettingtest.cpp
  autotests/settings/adslsettingtest.h
  autotests/settings/bluetoothsettingtest.cpp
  autotests/settings/bluetoothsettingtest.h
  autotests/settings/bondsettingtest.cpp
  autotests/settings/bondsettingtest.h
  autotests/settings/bridgeportsettingtest.cpp
  autotests/settings/bridgeportsettingtest.h
  autotests/settings/bridgesettingtest.cpp
  autotests/settings/bridgesettingtest.h
  autotests/settings/cdmasettingtest.cpp
  autotests/settings/cdmasettingtest.h
  autotests/settings/connectionsettingtest.cpp
  autotests/settings/connectionsettingtest.h
  autotests/settings/dcbsettingtest.cpp
  autotests/settings/dcbsettingtest.h
  autotests/settings/gsmsettingtest.cpp
  autotests/settings/gsmsettingtest.h
  autotests/settings/infinibandsettingtest.cpp
  autotests/settings/infinibandsettingtest.h
  autotests/settings/iptunnelsettingtest.cpp
  autotests/settings/iptunnelsettingtest.h
  autotests/settings/ipv4settingtest.cpp
  autotests/settings/ipv4settingtest.h
  autotests/settings/ipv6settingtest.cpp
  autotests/settings/ipv6settingtest.h
  autotests/settings/macsecsettingtest.cpp
  autotests/settings/macsecsettingtest.h
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/olpcmeshsettingtest.cpp
  autotests/settings/olpcmeshsettingtest.h
  autotests/settings/ovsbridgesettingtest.cpp
  autotests/settings/ovsbridgesettingtest.h
  autotests/settings/ovsinterfacesettingtest.cpp
  autotests/settings/ovsinterfacesettingtest.h
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  autotests/settings/pppoesettingtest.cpp
  autotests/settings/pppoesettingtest.h
  autotests/settings/pppsettingtest.cpp
  autotests/settings/pppsettingtest.h
  autotests/settings/proxysettingtest.cpp
  autotests/settings/proxysettingtest.h
  autotests/settings/serialsettingtest.cpp
  autotests/settings/serialsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  autotests/settings/teamportsettingtest.cpp
  autotests/settings/teamportsettingtest.h
  autotests/settings/tunsettingtest.cpp
  autotests/settings/tunsettingtest.h
  autotests/settings/usersettingtest.cpp
  autotests/settings/usersettingtest.h
  autotests/settings/vlansettingtest.cpp
  autotests/settings/vlansettingtest.h
  autotests/settings/vpnsettingtest.cpp
  autotests/settings/vpnsettingtest.h
  autotests/settings/vxlansettingtest.cpp
  autotests/settings/vxlansettingtest.h
  autotests/settings/wimaxsettingtest.cpp
  autotests/settings/wimaxsettingtest.h
  autotests/settings/wiredsettingtest.cpp
  autotests/settings/wiredsettingtest.h
  autotests/settings/wireguardsettingtest.cpp
  autotests/settings/wireguardsettingtest.h
  autotests/settings/wirelesssecuritysettingtest.cpp
  autotests/settings/wirelesssecuritysettingtest.h
  autotests/settings/wirelesssettingtest.cpp
  autotests/settings/wirelesssettingtest.h
  autotests/settingstest.cpp
  autotests/settingstest.h
  cmake/FindNetworkManager.cmake
  examples/createconnection/main.cpp
  examples/main.cpp
  src/accesspoint.cpp
  src/accesspoint.h
  src/accesspoint_p.h
  src/activeconnection.cpp
  src/activeconnection.h
  src/activeconnection_p.h
  src/adsldevice.cpp
  src/adsldevice.h
  src/adsldevice_p.h
  src/bluetoothdevice.cpp
  src/bluetoothdevice.h
  src/bluetoothdevice_p.h
  src/bonddevice.cpp
  src/bonddevice.h
  src/bonddevice_p.h
  src/bridgedevice.cpp
  src/bridgedevice.h
  src/bridgedevice_p.h
  src/connection.cpp
  src/connection.h
  src/connection_p.h
  src/device.cpp
  src/device.h
  src/device_p.h
  src/devicestatistics.cpp
  src/devicestatistics.h
  src/devicestatistics_p.h
  src/dhcp4config.cpp
  src/dhcp4config.h
  src/dhcp4config_p.h
  src/dhcp6config.cpp
  src/dhcp6config.h
  src/dhcp6config_p.h
  src/dnsconfiguration.cpp
  src/dnsconfiguration.h
  src/dnsdomain.cpp
  src/dnsdomain.h
  src/fakenetwork/accesspoint.cpp
  src/fakenetwork/accesspoint.h

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks, this will be nice to have once the issue identified in my comment is 
resolved.

INLINE COMMENTS

> flameshot-tray.svg:2
> + xmlns="http://www.w3.org/2000/svg;>
> + stroke-width=".26458333">
> +

Hardcoded colors alert! :)

You need to embed the stylesheet and make each path use it. Follow the pattern 
in other monochrome breeze icons, and see how to do that at 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Embedding_stylesheets_in_SVGs

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27926

To: axionl, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27929: CMake syntax fixes

2020-03-08 Thread Alex Turbov 
turbov created this revision.
turbov added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
turbov requested review of this revision.

REVISION SUMMARY
  - add some more variables introduced in CMake 3.17
  - allow back-slash characters in bracket comments
  - detect _internal variables first, then built-ins

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27929

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin 
gikari edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin 
gikari added reviewers: Kate, Frameworks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27928: [VIM Mode] Add g g commands

2020-03-08 Thread Mikhail Zolotukhin 
gikari created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Add twin commands for `gj` and `gk` for usage with standard
  arrow keys.
  
  BUG: 418486

TEST PLAN
  1. Open document with large sentences, that span across multiple visual lines 
in Kate and use `gj` and `gk` commands in normal mode to move inside a line.
  2. Use `g` and `g` commands - the result must be the same, as using 
`gj` and `gk` commands.
  3. Repeat the same for `visual` mode.

REPOSITORY
  R39 KTextEditor

BRANCH
  g-up-g-down-commands (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27928

AFFECTED FILES
  src/vimode/modes/normalvimode.cpp
  src/vimode/modes/visualvimode.cpp

To: gikari
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann