D27223: add kirigami-gallery icon

[Noah Davis]

ndavis added a comment.


  In D27223#626722 , @ngraham wrote:
  
  > Sorry this got lost.
  >
  > Still looks kinda jaggy to me though, especially at 48px.: F8172949: 
Screenshot_20200312_204742.png 
  >
  > Do you think you could clean up the outline a bit?
  
  
  Just to give some direction, I've found that the easiest way to fix these 
kinds of issues is to cut away the outside edge of the part that is sticking 
out. In theory, making shapes overlap perfectly should prevent the covered bits 
from showing. In practice, SVG renderers sometimes draw an outline of the part 
underneath around the part that is above.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D27223: add kirigami-gallery icon

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Sorry this got lost.
  
  Still looks kinda jaggy to me though, especially at 48px.: F8172949: 
Screenshot_20200312_204742.png 
  
  Do you think you could clean up the outline a bit?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D25010#626677 , @mlaurent wrote:
  
  > Did you test to compile with flags == 5.68.0 ?
  >  I tested it with kdepim and I need to adapt it.
  >  -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ?
  
  
  You also want to adapt kdepim-runtime it seems -> failing as part of 
dependency build e.g. here: 
https://build.kde.org/view/Failing/job/Administration/job/Dependency%20Build%20Extragear%20kf5-qt5%20SUSEQt5.12/lastFailedBuild/console
 (I just  triggered product build, but missed that the latest "Applications" 
dep build might not yet have pulled in the new KIO with the respective 
deprecation).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kossebau wrote in statjob.h:203
> This wants to be "5, 69" now, not "5, 68"

Ah, was already fixed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Christoph Cullmann]

cullmann updated this revision to Diff 77526.
cullmann added a comment.


  remove useless output of stray azOffset var

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28015?vs=77525=77526

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28015

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Christoph Cullmann]

cullmann added reviewers: nibags, dhaumann, vkrause.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

[Christoph Cullmann]

cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  see bug 418778
  
  VHDL highlighting is very slow as close to all regexes are marked as dynamic
  but most have no place holders used at all
  now the checker detects that
  
  if nobody objects to the logic of this check (I might be confused about other 
side-effects of dynamic),
  then I will adapt the below faults and adjust this request

TEST PLAN
  make && make test
  
  >
  =
  
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/doxygenlua.xml"
 line 246 broken regex: "--\\[(=*)\\[" problem: dynamic=true but no %\d+ 
placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/latex.xml" 
line 405 broken regex: "(.)" problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/latex.xml" 
line 418 broken regex: "(.)" problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/lua.xml" 
line 472 broken regex: "\\[(=*)\\[" problem: dynamic=true but no %\d+ 
placeholder -1
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/metafont.xml" 
line 917 broken regex: "(.)" problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sass.xml" 
line 140 broken regex: "(\\s+)(?=/[*/])" problem: dynamic=true but no %\d+ 
placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sass.xml" 
line 141 broken regex: "()/[*/]" problem: dynamic=true but no %\d+ placeholder 
-1
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sql-postgresql.xml"
 line 1013 broken regex: "\\$([^\\$\\n\\r]*)\\$" problem: dynamic=true but no 
%\d+ placeholder -1
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sql-postgresql.xml"
 line 1023 broken regex: "\\$([^\\$\\n\\r]*)\\$" problem: dynamic=true but no 
%\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 222 broken regex: 
"(\\b)architecture\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 226 broken regex: 
"(\\b)package\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+is\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 228 broken regex: 
"(\\b)package\\s+body\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+is\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 231 broken regex: 
"(\\b)configuration\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 272 broken regex: 
"(\\b)function\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 287 broken regex: "(\\b)end(\\s+function)?\\b" problem: dynamic=true but 
no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 300 broken regex: 
"(\\b)architecture\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+of\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+is"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 304 broken regex: 
"(\\b)end(\\s+architecture)?(\\s+\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s*;"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 337 broken regex: "(\\b)end(\\s+function)?\\b" problem: dynamic=true but 
no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 349 broken regex: 
"(\\b)(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b\\s*:\\s*)(if|for).*\\s+generate\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 351 broken regex: 
"(\\b)(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b\\s*:\\s*)?process\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 353 broken regex: 

D27844: Store and fetch complete view config in and from session config

[Christoph Cullmann]

cullmann added a comment.


  Zoom is like all view stuff local, yes, I assume that is often not wanted.
  But that is a orthogonal issue.
  The same could be said for "dynamic word wrap", very seldom you want to set 
that for one view.
  On the other side, for the global config, one has the settings dialog, same 
for "zoom", aka font size.

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27929: CMake syntax fixes

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:39ad168cf350: CMake syntax fixes (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27929?vs=77200=77524

REVISION DETAIL
  https://phabricator.kde.org/D27929

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D27928: [VIM Mode] Add g g commands

[Christoph Cullmann]

cullmann added a comment.


  And btw., thanks a lot for taking care!
  The vimode for sure has more need for love, if you have time ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27928: [VIM Mode] Add g g commands

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:736844969d2b: [VIM Mode] Add gup gdown 
commands (authored by gikari, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27928?vs=77355=77523

REVISION DETAIL
  https://phabricator.kde.org/D27928

AFFECTED FILES
  autotests/src/vimode/keys.cpp
  src/vimode/modes/normalvimode.cpp
  src/vimode/modes/visualvimode.cpp

To: gikari, #kate, #frameworks, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> statjob.h:203
> +
> +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 68)
>  /**

This wants to be "5, 69" now, not "5, 68"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27928: [VIM Mode] Add g g commands

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  g-up-g-down-commands (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D27928: [VIM Mode] Add g g commands

[Christoph Cullmann]

cullmann added a comment.


  I think, one issue is, that  and  don't work that way in the test 
framework.
  I reformulated the test with \down and \up and moved the asserts to verifies.
  This works for me, will push this, please take a look if that is ok for you, 
too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Laurent Montel]

mlaurent added a comment.


  Did you test to compile with flags == 5.68.0 ?
  I tested it with kdepim and I need to adapt it.
  -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27986: Allow providing an error message from the application

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77522.
apol added a comment.


  Prefer char*

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27986?vs=77451=77522

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27986

AFFECTED FILES
  src/kcrash.cpp
  src/kcrash.h

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krununittest.cpp:245
> +QCOMPARE(KShell::joinArgs(parser.resultingArguments()),
> + QStringLiteral("/usr/bin/ktelnetservice5 
> %1://root@10.1.1.1").arg(protocol));
> +}

Wait, I didn't notice before, but this is broken.
On my system it's in another prefix.
On Windows it won't be in /usr/bin either.
You need to either strip out the path, or use 
QStandardPaths::findExecutable("ktelnetservice5") in an arg() for that expected 
value.

> dfaure wrote in krununittest.cpp:238
> QFINDTESTDATA() is more flexible than a solution like CMAKE_SOURCE_DIR [e.g. 
> it allows deploying unittests to android devices]. It's also simpler to use 
> (no buildsystem change).

Good practice is to follow that with QVERIFY(!ktelnet.isEmpty());

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77521.
ahmadsamir added a reviewer: feverfew.
ahmadsamir added a comment.


  Tweak

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27999?vs=77520=77521

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28002: [WIP]Allow disabling of data collection

[David Edmundson]

davidedmundson added a comment.


  > Currently data is collected by default, with no way of disabling it.
  
  That's far from true. Things are off by default. Most providers are not run 
at all.
  The commit message is either confused or misleading.
  
  Some usage stuff is retained regardless, but as you note it is because it is 
used for the notification reminder.
  
  Having the start count save guarded by the global killswitch isn't going to 
be too problematic, so personally I would be ok with it. I don't see why load 
needs to return early with a bool, it's overly complicating things.
  
  I also don't see it as fixing anything real. It's local data (that 
kactivitymanagerd is keeping anyway...) and no different to an app storing a 
window size or whatever.

REPOSITORY
  R849 User Feedback Collection Framework

REVISION DETAIL
  https://phabricator.kde.org/D28002

To: gvgeo, #frameworks, apol, vkrause
Cc: davidedmundson, #frameworks

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77520.
ahmadsamir edited the summary of this revision.
ahmadsamir removed a reviewer: feverfew.
ahmadsamir removed a subscriber: feverfew.
ahmadsamir added a comment.


  Address comments, use QFINDTESTDATA()

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27999?vs=77479=77520

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns, 
feverfew

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[David Faure]

dfaure added a comment.


  @mlaurent compilation is broken because a method got deprecated, and you set 
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06 so the use of that method no 
longer compiles.
  You can hardly blame other people for deprecating methods, it's a rather 
natural thing to do at this point...
  On the contrary, I strongly suggest to stop setting 
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x06, it just breaks too much. It 
even breaks stable branches.
  
  I fixed that for kjumpingcube in 
https://commits.kde.org/kjumpingcube/5f238b424da1c57c56024a7e871579075bd06c73
  
  In order to port away from deprecated methods, I suggest a script that 
increases the KF_DISABLE_DEPRECATED_BEFORE_AND_AT, which you (or anyone who 
wants to help with that) can run and fix compilation before pushing. It's what 
I regularly do for KF5 itself.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27986: Allow providing an error message from the application

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Every other static variable here is a char* so that there's no global 
constructor being called at application startup.
  Why not do the same? Just `strdup` the result of the toUtf8() call.
  
  BTW: why the 1024 limit?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[David Faure]

dfaure added a comment.


  Thanks for the unittest with the fix.

INLINE COMMENTS

> krununittest.cpp:238
> +{
> +const QString ktelnet = QStringLiteral(CMAKE_SOURCE_DIR) + 
> QStringLiteral("/src/ioslaves/telnet/ktelnetservice5.desktop");
> +const KService service(ktelnet);

QFINDTESTDATA() is more flexible than a solution like CMAKE_SOURCE_DIR [e.g. it 
allows deploying unittests to android devices]. It's also simpler to use (no 
buildsystem change).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kpasswdserver.cpp:201
>  
>  bool KPasswdServer::hasPendingQuery(const QString , const KIO::AuthInfo 
> )
>  {

I wonder why the whole method isn't const

> kpasswdserver.cpp:713
> +   if (current->info.realmValue == info.realmValue) {
> +  authList->erase(it);
>authItem = current;

(this one is fine, there's a "break;" below)

> apol wrote in kpasswdserver.cpp:648
> Use erase.

This is not the way to use erase(). It invalidates the iterator...

The proper way is

  it = authList->erase(it);

and doing ++it at the end of the for loop, not in the 3rd part of the for() 
line, since we don't want ++it after it=erase(it).

> apol wrote in kpasswdserver.cpp:682
> Use erase.

same problem here.
add "} else { ++it; }"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

[Albert Astals Cid]

aacid added a comment.


  Looks reasonable to me, but i'm not a huge expert here either, i guess you 
can commit given you are the expert.
  
  Or maybe wait a few days in case someone else has commits?

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D27966

To: dfaure, aacid, nicolasfella, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28002: [WIP]Allow disabling of data collection

[Nathaniel Graham]

ngraham added reviewers: Frameworks, apol, vkrause.

REPOSITORY
  R849 User Feedback Collection Framework

REVISION DETAIL
  https://phabricator.kde.org/D28002

To: gvgeo, #frameworks, apol, vkrause
Cc: #frameworks

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 77511.
trmdi added a comment.


  Minor improvement

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77508=77511

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28002: [WIP]Allow disabling of data collection

[George Vogiatzis]

gvgeo added a subscriber: Frameworks.
gvgeo added a comment.


  Added Frameworks for visibility. kuserfeedback is not included in the group.

REPOSITORY
  R849 User Feedback Collection Framework

REVISION DETAIL
  https://phabricator.kde.org/D28002

To: gvgeo
Cc: #frameworks

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Nathaniel Graham]

ngraham added a dependent revision: D27998: [KCMs/Workspace] Add option for 
dndToMove.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi edited the summary of this revision.
trmdi edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi updated this revision to Diff 77508.
trmdi added a comment.


  Allow to explicitly show the menu when holding Shift

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27951?vs=77433=77508

BRANCH
  add-dndToMove (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27951

AFFECTED FILES
  src/widgets/dropjob.cpp

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D28014: smb: do not double finish

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  finish() must not be called twice yet previously the case branches
  would call it but then there'd also be a global finished after the switch.
  remove the cases' finished().
  
  this code is, I think, actually not used anywhere so it matters little.

TEST PLAN
  hoping for the best!

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-mount-doublefinish

REVISION DETAIL
  https://phabricator.kde.org/D28014

AFFECTED FILES
  smb/kio_smb_mount.cpp

To: sitter, ngraham
Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

[Laurent Montel]

mlaurent added a comment.


  "/compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:582:63: erreur: 
impossible de convertir « KIO::StatJob::DestinationSide » de « 
KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »}
  
582 |  KIO::StatJob* statJob = KIO::stat(url, 
KIO::StatJob::DestinationSide, 0);
| 
~~^~~
|   |
|   
KIO::StatJob::StatSide
  
  /compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp: Dans la fonction 
membre « void Game::loadGame() »:
  /compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:627:60: erreur: 
impossible de convertir « KIO::StatJob::SourceSide » de « 
KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »}
  
627 |   KIO::StatJob* statJob = KIO::stat(url, 
KIO::StatJob::SourceSide, 0);
|  ~~^~
||
|
KIO::StatJob::StatSide
  
  "
  
  compile is broken in several package see below.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25010

To: meven, #frameworks, dfaure, kossebau
Cc: mlaurent, dalbers, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 67 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/67/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Mar 2020 10:46:45 +
 Build duration:
2 hr 7 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(241/269)90%
(241/269)85%
(27269/32251)53%
(10996/20689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12508/12599)50%
(6584/13087)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6331/7478)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7976/9518)64%
(2399/3775)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 329 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/329/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 12:34:40 +
 Build duration:
9 min 52 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D21466: Recommend rebooting after installing Samba

[Harald Sitter]

sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R432 File Sharing (Samba) integration

BRANCH
  recommend-rebooting (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter
Cc: anthonyfieroni, sitter, bruns

D21466: Recommend rebooting after installing Samba

[Anthony Fieroni]

anthonyfieroni added a comment.


  Just start services, reboot will not do anything else.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: anthonyfieroni, sitter, bruns

D21466: Recommend rebooting after installing Samba

[Aleix Pol Gonzalez]

apol added a comment.


  In D21466#626419 , @sitter wrote:
  
  > In D21466#625834 , @apol wrote:
  >
  > > So yes, Discover will notify about updates. That doesn't mean it should 
be shown here too.
  >
  >
  > To clarify: are you -1 this diff?
  
  
  no, sorry, I meant to +1. ETOOMANYNEGATIVES.
  
  >> If anything, we should be pushing for such updates to happen at 
startup/shutdown because it doesn't seem like the user benefits from it being 
swapped at runtime, but that's a different question.
  > 
  > "Such updates" being group changes?
  
  I'd like to know which updates will need a reboot before updating and just 
move them to update offline.

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: sitter, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Alexander Saoutkin]

feverfew added a reviewer: feverfew.
feverfew added a comment.


  I'll review this when I have a chance (sometime this week).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27985: Include s_kcrashErrorMessage in our traces

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  LGTM for when the kcrash diff is ready.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27985

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27986: Allow providing an error message from the application

[Harald Sitter]

sitter added a reviewer: dfaure.
sitter added a subscriber: dfaure.
sitter added a comment.


  Paging @dfaure for expert input.
  Is that global static qbytearray safe? Should we make it a q_global_static to 
comply with our library policy? Any objections to the diff?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 77494.
leinir added a comment.


  - Merge branch 'master' into fix-update
  - Update @since

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27544?vs=76096=77494

BRANCH
  fix-update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27544

AFFECTED FILES
  src/core/engine.cpp
  src/core/jobs/httpworker.cpp
  src/core/security.cpp
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/NewStuffItem.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store
Cc: alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27544: Fix update scenarios with no explicit downloadlink selected

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D27544#622575 , @alexde wrote:
  
  > In D27544#622272 , @ngraham 
wrote:
  >
  > > (...) there has to be a way to (...) label everything properly etc.
  >
  >
  >
  >
  > In D27544#622501 , @leinir wrote:
  >
  > > We are at least two people not too happy with that situation... The label 
we're using for that now is technically a free-text field. (...) However, each 
downloaditem does have a tags section, and while that would need some thought 
put into it, i think we could do something clever with that. A bit outside the 
scope of this patch, of course, but something to spent some braining time on :)
  >
  >
  > Sounds similar to bug #415483.
  
  
  Vaguely, but they're more orthogonal than anything - the problem here is a 
lack of well named downloads, which is a generic issue, where the issue 
described in that bug is content-type-specific.
  
  It is also not exactly what this diff is about and i'd like to avoid this 
going off on a tangent, especially given the issue this patch addresses is 
causing updates to just not work...
  
  With that in mind - ping? Been a few weeks now, and i'll have to update the 
patch because we've had a frameworks release in the meantime...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D27544

To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, 
#discover_software_store
Cc: alexde, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 167 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/167/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Mar 2020 10:35:20 +
 Build duration:
1 hr 16 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/70/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Mar 2020 10:35:28 +
 Build duration:
1 hr 17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.tests.ECMPoQmToolsTestName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/68/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:49:55 +
 Build duration:
56 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D21466: Recommend rebooting after installing Samba

[Harald Sitter]

sitter added a comment.


  In D21466#625834 , @apol wrote:
  
  > So yes, Discover will notify about updates. That doesn't mean it should be 
shown here too.
  
  
  To clarify: are you -1 this diff?
  
  > If anything, we should be pushing for such updates to happen at 
startup/shutdown because it doesn't seem like the user benefits from it being 
swapped at runtime, but that's a different question.
  
  "Such updates" being group changes?

REPOSITORY
  R432 File Sharing (Samba) integration

REVISION DETAIL
  https://phabricator.kde.org/D21466

To: ngraham, #vdg, #frameworks, #dolphin, apol
Cc: sitter, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 108 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/108/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 10:46:46 +
 Build duration:
40 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testSubCompositor
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)89%
(240/269)89%
(240/269)84%
(27207/32248)53%
(10978/20689)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)99%
(12446/12596)50%
(6564/13087)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6328/7478)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(118/124)95%
(118/124)84%
(7979/9518)64%
(2401/3775)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/60/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:46:46 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 16 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:44:38 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/60/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:43:40 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 328 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/328/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:41:18 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 64 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/64/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:38:37 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 170 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/170/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 10:37:48 +
 Build duration:
21 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.69.0.xmllogs/KF5CoreAddons/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6927/9112)43%
(10794/24836)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2897/2990)49%
(6191/12720)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(108/290)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/782)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)66%
(869/1308)35%
(991/2821)src.lib.jobs71%
(5/7)71%
(5/7)56%
(157/278)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(679/799)42%
(954/2269)src.lib.randomness100%
(2/2)100%
(2/2)69%
(66/95)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)52%
(441/848)47%
(1008/2157)src.lib.util100%
(15/15)100%
(15/15)83%
(994/1191)51%
(1012/1999)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:38:57 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Harald Sitter]

sitter added a subscriber: feverfew.
sitter added a comment.


  Tested fuse and it works as expected. Code looks reasonable, but I have 
little expertise with this class.
  @feverfew probably ought to comment as well since he introduced the fuse code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/86/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:38:17 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/116/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:37:48 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittestFailed: projectroot.autotests.klistopenfilesjobtest_unix

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/103/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 10:35:28 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.tests.ECMPoQmToolsTestName: projectroot.tests Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.tests.ECMAddTests Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 60 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/60/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:36:39 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 490 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.testicaltimezonesFailed: projectroot.autotests.testrecurtodo

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 160 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/160/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Mar 2020 10:35:20 +
 Build duration:
9 min 6 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 274 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/274/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Mar 2020 10:35:20 +
 Build duration:
8 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove planned changes to this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27695

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27695: WIP: Create a new TopArea element using widgets/toparea svg

[Niccolò Venerandi]

niccolove updated this revision to Diff 77482.
niccolove added a comment.


  Added PlasmoidHeading to qmldir

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27695?vs=77418=77482

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27695

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: niccolove, mart, ngraham
Cc: ngraham, davidedmundson, ahiemstra, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#626135 , @ngraham wrote:
  
  > it needs more discussion first...
  
  
  When drop an image to the desktop in the FolderView layout, there would be no 
menu, so users can not change the wallpaper in this case. How do you think 
about this?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

[Cyril Rossi]

crossi added a comment.


  In D27133#625924 , @apol wrote:
  
  > The patch and the feature sound good to me, the resulting xml feels a bit 
weird and could use some clarification.
  
  
  Thank you for your comment.
  
  I agree it looks a bit odd, nested group element would be more xmlish.
  We choose a simpler approach as moving in the kconfig_compiler code isn't 
easy and the need was for one kcm (notifications).

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27133

To: crossi, ervin, dfaure, #frameworks
Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir added a comment.


  FTR, I don't have access to any smb:// servers, so couldn't test the KIOFuse 
stuff.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, sitter, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Extend krununittest to test ktelnetservice.
  
  Use CMake target_compile_definitions() to set the CMAKE* vars that need
  to be accessed from the code in krununittest.

TEST PLAN
  $ kde-open5 ssh://user@1.1.1.1
  
outputs:
command= "ktelnetservice5 %u" args= ("ktelnetservice5 %u", 
"ssh://user@1.1.1.1")
kf5.kio.core: couldn't create slave: "klauncher said: Unknown protocol 
'ssh'.\n"
  
  and you get a message box with "File not found: ssh://user@1.1.1.1".
  
  Apply diff then try again, now a terminal window is launched by
  ktelnetservice5 and ssh is invoked as expected.
  
  BUG: 418258
  
  FIXED-IN: 5.69

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27999

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/krununittest.cpp
  autotests/krununittest.h
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns