KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 335 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/335/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Mar 2020 05:01:25 +
 Build duration:
8 min 48 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77702.
ngraham added a comment.


  Don't auto-collapse when the default action button is clicked; this can 
interfere with actions where you want the button to show a custom expanded 
view, as in the Networks widget

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77701=77702

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77701.
ngraham added a comment.


  - Create a re-usable public `toggleExpanded()` function and use it internally
  - Make the busy indicator a bit smaller so it doesn't make the list item 
taller when it appears

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77695=77701

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77695.
ngraham added a comment.


  Use `StyledText` instead of `RichText` because `RichText` doesn't support 
eliding (see https://bugreports.qt.io/browse/QTBUG-16567)

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77691=77695

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh jeez.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27854

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27853: [WriteTransactionTest] Test removal of positions only

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27853

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27772: [WriteTransaction] Extend position test case

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27772

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27771: [WriteTransaction] Avoid growing m_pendingOperations twice on replace

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27771

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D27855: [Debug] Improve readability of positioninfo debug format

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D27855

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77691.
ngraham added a comment.


  Add TODOs

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77688=77691

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77687.
ngraham added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77686=77687

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77688.
ngraham added a comment.


  Fix one thing

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77687=77688

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham marked 5 inline comments as done.
ngraham added a comment.


  By switching to the PC3 `BusyIndicator`, I'm now seeing a binding loop that 
doesn't make sense to me:
  

file:///home/nate/kde/usr/lib64/qml/org/kde/plasma/components.3/ExpandableListItem.qml:191:13:
 QML BusyIndicator: Binding loop detected for property "implicitHeight"
  
  I'm not touching the `implicitWidth` of the item here, so it seems like it 
could be inherent to the control itself.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ExpandableListItem.qml:2
> It shouldn't be in PC3. It's new API from qqc2.A

Where should it live? PC2? Kirigami?

> davidedmundson wrote in ExpandableListItem.qml:23
> Unused?

Not unused, it's needed for `Highlight`, which has no PC3 version.

> davidedmundson wrote in ExpandableListItem.qml:179
> Shouldn't it run the default action?

It already does by virtue of having `defaultActionButtonAction` being an alias 
to `defaultActionButton.action`; this just adds an additional behavior on top 
of that. I'll add a comment to make this clearer

> davidedmundson wrote in ExpandableListItem.qml:230
> Seems random

Not random; this is the easing curve we agreed to and is now in the HIG: 
https://hig.kde.org/style/animations.html#guidelines

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 77686.
ngraham marked 4 inline comments as done.
ngraham added a comment.


  - Address review comments
  - Improve inline comments for clarify
  - Use a pointing hand cursor when hovering over the item to indicate that 
it's clickable
  - Make subtitle wrapping optional
  - Substantially simplify the expanded view handling

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77636=77686

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ExpandableListItem.qml
  src/declarativeimports/plasmacomponents3/qmldir
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir
  src/desktoptheme/breeze/widgets/plasmoidheading.svg

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta requested changes to this revision.
usta added inline comments.

INLINE COMMENTS

> cochise wrote in jobtest.cpp:573
> {set,get}fattr = linux command
> {set.get}extattr = BSD command
> {set.get}xtattr = MacOS command
> 
> This command could have a little more consistency...

but you have written it as with single T , i think it must be double ( TT )

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28020: New class ProcessLauncherJob in KIOGui

[David Faure]

dfaure updated this revision to Diff 77682.
dfaure added a comment.


  - Don't block in start(), make it fully async
  - Add waitForStarted() for KRun (with unittests)
  - Add test for non-existing executables, with and without kioexec
- after making sure that the command isn't trivial, by starting with cd 
KIO::DesktopExecParser helps, though, it returns /bin/sh as such a case So we 
don't have to do this when the process finishes, we can check it upfront
  - Connect to QProcess::errorOccurred just for debugging (debug output in case 
the process crashes)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28020?vs=77547=77682

BRANCH
  2020_ProcessLauncherJob

REVISION DETAIL
  https://phabricator.kde.org/D28020

AFFECTED FILES
  KF5KIOConfig.cmake.in
  autotests/CMakeLists.txt
  autotests/kiotesthelper.h
  autotests/processlauncherjobtest.cpp
  autotests/processlauncherjobtest.h
  src/gui/CMakeLists.txt
  src/gui/config-kiogui.h.cmake
  src/gui/kprocessrunner.cpp
  src/gui/kprocessrunner_p.h
  src/gui/processlauncherjob.cpp
  src/gui/processlauncherjob.h
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/krun_p.h

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28061: Reduce unneeded dependencies

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28061

To: apol, #frameworks, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D17816: Support for xattrs on kio copy/move

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> cochise wrote in jobtest.cpp:573
> xtattr = MacOS command
> It uses a single command to read and write.

All of these are spelled with two consecutive 't'.
The code has a single 't' : getextatr.

> dfaure wrote in jobtest.cpp:638
>   if (command.isEmpty())
>   qWarning() << "ERROR: setfattr/setextattr/xattr not found";
> 
> to make it easier to debug than just this method returning empty.

Was my comment ignored?

> dfaure wrote in jobtest.cpp:650
> QSKIP("This test requires setfattr")
> 
> Otherwise it will look like a "PASS" in the test output.

My comment was ignored.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise added a comment.


  In D17816#627925 , @pino wrote:
  
  > xattrs on the Linux tmpfs have been supported for many years, almost a 
decade.
  
  
  But only enough to support ACL.
  
  > The tmpfs filesystem supports extended attributes (see xattr(7)), but user 
extended attributes are not permitted.
  
  http://man7.org/linux/man-pages/man5/tmpfs.5.html
  
  > tmpfs can support extended attributes if you enable CONFIG_TMPFS_XATTR in 
Kernel config. But Currently this enables support for the trusted.* and 
security.* namespaces.
  
  
https://stackoverflow.com/questions/30760177/xattr-extended-attributes-not-settable-for-file-in-tmp-while-in-home-on-same-m

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise added inline comments.

INLINE COMMENTS

> cochise wrote in jobtest.cpp:573
> {set,get}fattr = linux command
> {set.get}extattr = BSD command
> {set.get}xtattr = MacOS command
> 
> This command could have a little more consistency...

xtattr = MacOS command
It uses a single command to read and write.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Pino Toscano]

pino added a comment.


  In D17816#627921 , @cochise wrote:
  
  > In D17816#627918 , @bruns wrote:
  >
  > > Not true in general ... please add back, and **check** if the destination 
FS supports XAttrs. If not, print a warning and SKIP
  >
  >
  > Not true in general. But test the copies to /tmp, and on most distros today 
it's a tmpfs, that don't support xattr. But checking support is a good idea.
  
  
  
  
$ grep -i xattr /boot/config-$(uname -r) | grep -i tmp
CONFIG_TMPFS_XATTR=y
  
  xattrs on the Linux tmpfs have been supported for many years, almost a decade.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> jobtest.cpp:568
> +
> +void JobTest::compareXattr(const QString , const QString , QString 
> )
> +{

remove the command parameter from the method, use e.g. a `m_xattrGetCommand` 
JobTest member

> jobtest.cpp:593
> +
> +QStringList arguments = {"-n", "name", src};
> +QHashIterator i(attrs);

By just iterating over the expected xattrs, extraneous attrs will be silently 
skipped. Use '-d'

> jobtest.cpp:613
> +
> +arguments.replace(2, dest);
> +xattrreader.start(command, arguments);

Redundant code.

Call this function once after writing the source, compare with what you tried 
to write.

Call another time for each copy operation.

> jobtest.cpp:626
> +
> +QString getXattrCommand()
> +{

Do the lookup once in `JobTest::initTestCase`

> jobtest.cpp:626
> +
> +QString getXattrCommand()
> +{

Check for both set and get commands.

> jobtest.cpp:641
> +}
> +return command.split("/").last();
> +}

Keep the full path.

> jobtest.cpp:687
> +QVERIFY2(job->exec(), qPrintable(job->errorString()));
> +compareXattr(src, dest, command); // Our test
> +

If this copy never happened, the check would still succeed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Cochise César]

cochise added a comment.


  In D17816#627918 , @bruns wrote:
  
  > Not true in general ... please add back, and **check** if the destination 
FS supports XAttrs. If not, print a warning and SKIP
  
  
  Not true in general. But test the copies to /tmp, and on most distros today 
it's a tmpfs, that don't support xattr. But checking support is a good idea.

INLINE COMMENTS

> usta wrote in jobtest.cpp:573
> I am not sure but it looks like there is a typo here
> getextatr --->
> getextattr
> but not sure , can someone make a comment about this ?

{set,get}fattr = linux command
{set.get}extattr = BSD command
{set.get}xtattr = MacOS command

This command could have a little more consistency...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Ömer Fadıl Usta]

usta added inline comments.

INLINE COMMENTS

> jobtest.cpp:573
> +} else if (command == "setextattr") {
> +command = "getextatr";
> +}

I am not sure but it looks like there is a typo here
getextatr --->
getextattr
but not sure , can someone make a comment about this ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added a comment.


  > - Removed tests for copy/move to another partition, as this should fail. 
The destination filesystem don't support xattr.
  
  Not true in general ... please add back, and **check** if the destination FS 
supports XAttrs. If not, print a warning and SKIP

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall
Cc: scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh

D28061: Reduce unneeded dependencies

[Aleix Pol Gonzalez]

apol updated this revision to Diff 77678.
apol added a comment.


  polish

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28061?vs=77677=77678

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28061

AFFECTED FILES
  src/tests/crashtest/CMakeLists.txt
  src/tests/crashtest/crashtest.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28061: Reduce unneeded dependencies

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  No need to translate a test app that is not even being installed.
  Make it a QGuiApplication so less stuff is pulled.

TEST PLAN
  Still crashes :)

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28061

AFFECTED FILES
  src/tests/crashtest/CMakeLists.txt
  src/tests/crashtest/crashtest.cpp

To: apol, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27985: Include s_kcrashErrorMessage in our traces

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:39ed9cf6449e: Include s_kcrashErrorMessage in our traces 
(authored by apol).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27985?vs=77452=77676

REVISION DETAIL
  https://phabricator.kde.org/D27985

AFFECTED FILES
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/tests/crashtest/crashtest.cpp

To: apol, #frameworks, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27986: Allow providing an error message from the application

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R285:6177c81d04a7: Allow providing an error message from the 
application (authored by apol).

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27986?vs=77552=77675

REVISION DETAIL
  https://phabricator.kde.org/D27986

AFFECTED FILES
  src/kcrash.cpp
  src/kcrash.h

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 334 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/334/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Mar 2020 18:41:56 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Tranter Madi]

trmdi added a comment.


  In D27951#627849 , 
@elvisangelaccio wrote:
  
  > > With dndToMove=true in kdeglobals, drag files will move them without 
showing the menu. (holding Shift shows it)
  >
  > Are we going to expose this setting in Plasma?
  
  
  Yes: https://phabricator.kde.org/D27998

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28060

To: dfaure, apol, davidedmundson, elvisangelaccio
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Re: KIO: try to assign an icon to action submenus

[Chloe Kudryavtsev]

On 3/15/20 12:19 PM, David Faure wrote:
> On vendredi 13 mars 2020 21:19:42 CET Chloe Kudryavtsev wrote:
>> On 3/13/20 2:18 PM, David Faure wrote:
>>> On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote:
 Currently, action submenus (X-KDE-Submenu) have no icons.
 This patch makes it inherit the icon of the first action.
>>>
>>> I wonder if this is always wanted? The icon for the first action might not
>>> be representative of what the other actions do.
>>>
>>> Wouldn't it be better to be able to explicitly specify the icon for the
>>> submenu?
>>
>> That would be better, but that can't easily be done without reorganizing
>> how the whole thing works.
>> insertServicesSubmenus() currently receives a QMap> ServiceList>, the target QMenu and a boolean.
>> Meanwhile, the icon for the desktop file as a whole would be available
>> in the KConfigGroup (from desktopFile).
>>
>> Basically, making the "global" (i.e [Desktop Entry]) Icon setting be
>> what is used would require breaking API (changing the signature of
>> insertServicesSubmenus).
> 
> If you're talking about KFileItemActionsPrivate::insertServicesSubmenus
> that's a method of the Private class (as the classname indicates),
> so you can change it as much as you want, it's not part of the public API.
> 
>> In the meanwhile, in practice, ServiceMenus do have (at the very least)
>> similar icons, because TryExec is effectively global (there is no
>> support for disabling individual actions, it's done purely on a
>> per-desktop-file basis).
> 
> Right, but I don't like putting something in place with limitations, that 
> someone else will surely have a problem with, one day.


Sorry, it appears I wasn't sufficiently clear, so let's walk through it.
insertServicesSubmenus receives a QMap.
ServiceList is a QList.
Reading back I'm noticing that I claimed it's only take changing the
signature, and assume I was talking about the QMap
bit, but it's my fault regardless.

insertServicesSubmenus will iterate over the values in the QMap (i.e
each submenu in a given category) - if you pass an icon as a call to
insertServicesSubmenus, *every submenu per category will have the same
icon*.
The categories in question are userPriority, user and userTopLevel - i.e
entirely separate submenus from different .desktop files.

So we need to be able to pass an icon inside of a ServiceList.
As mentioned, ServiceList is a QList.
QList is part of Qt and KServiceAction is part of KService.

If we wanted to approach it in this way, then, the best way would be to
extend KService, and add a parent() pointer or similar to a KService -
which would have its own .icon() call.

The ServiceLists in question are accessed via PopupServices::selectList,
bound to a local ServiceList and then populated.
As a consequence, we know exactly where they're coming from:
KDesktopFileActions::userDefinedServices.
All 3 versions of that function eventually boil down to the one with a
KService variable, meaning it would be possible to add this information
at that level, though some care would be needed for it to not be freed
(either through smart pointers, or by allocating it on the heap).

Alternatively, we could change the type of ServiceList to something that
wraps around (or inherits) QList, but still has an icon() method.
KDesktopFileActions::userDefinedServices would then need to return a
ServiceList after populating it.
The issue here is that this would change public API
(userDefinedServices, which would now return a ServiceList rather than a
raw QList) and require making ServiceList more
standalone/available.

Finally, we could take the above approach, but make a new-ified
ServiceList from the output of userDefinedServices.
This is fairly simple in the final invocation, where *it2 is the
KService in question.
In the other two scenarios, we have a KDesktopFile.
We could use KDesktopFile::readIcon() to do the same process.
The issue with this approach is that it would be extremely messy.
Extending types in Qt is non-trivial, and if we wrap around QList
basically every line that so much as mentions ServiceList would need to
be modified (including things like assignment through a reference).
This can be done, but I'm not particularly convinced this is an improvement.
SubMenus are already used fairly rarely (being a KDE-specific key), and
none of the .desktop ServiceMenus present on my system (nor that I'm
aware of) even use this feature (possibly due to the lack of icon support).

>> I would participate in an effort to extend KConfig, KIO and co. to
>> improve the overall handling of .desktop files, but the process in
>> general is kind of a bother, and I don't really like touching C++
>> nowadays either, so it's a hard sell to put that as a high priority
>> for me.
>
> This seems a rather strong statement for the work at hand here.
> If all that's needed is to pass an icon to insertServicesSubmenus you
> surely don't need to extend KConfig...

Same story here, apparently - sorry for not 

D27951: Allow users to change dropAction to MoveAction through kdeglobals

[Elvis Angelaccio]

elvisangelaccio added a comment.


  > With dndToMove=true in kdeglobals, drag files will move them without 
showing the menu. (holding Shift shows it)
  
  Are we going to expose this setting in Plasma?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27951

To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson
Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[David Edmundson]

davidedmundson requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28033: Create ExpandableListItem

[Niccolò Venerandi]

niccolove added a comment.


  AFAIK, there should be a easy way to add animations to the highlight effect. 
An example is the print one, where clicking on it will animate the highlight. 
It should also be possible to make the highlight effect fly over elements 
instead of always being on the hovered element. Not a must for this patch, but 
it could be nice to have.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, ngraham

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28060

To: dfaure, apol, davidedmundson, elvisangelaccio
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D25815: Transmission-Qt tray icon added

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: vinzenzv; removed: ndavis.

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: ndavis, #vdg, ngraham, vinzenzv
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
cblack, fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28060

To: dfaure, apol, davidedmundson, elvisangelaccio
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D28056: KWindowSystem: Convert license headers to SPDX expressions

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D28056

To: cordlandwehr, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28058: KWayland: Convert license headers to SPDX

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D28058

To: cordlandwehr, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

[Ahmad Samir]

ahmadsamir added a comment.


  I tested it; before applying the diff:
  
$ /usr/lib64/libexec/kf5/kioexec --tempfiles does_not_exist /tmp/foo
command= "does_not_exist" args= ("does_not_exist", "/tmp/foo")
EXEC "does_not_exist /tmp/foo"
EXEC done
$ echo $?
0
  
  
  
$ /usr/lib64/libexec/kf5/kioexec --tempfiles ls /tmp/foo
command= "ls" args= ("ls", "/tmp/foo")
EXEC "/usr/bin/ls /tmp/foo"
/usr/bin/ls: cannot access '/tmp/foo': No such file or directory
EXEC done
$ echo $?
0
  
  with the diff:
  
$ bin/kioexec --tempfiles does_not_exist /tmp/foo
command= "does_not_exist" args= ("does_not_exist", "/tmp/foo")
EXEC "does_not_exist /tmp/foo"
EXEC done
$ echo $?
254
  
  
  
$ building-dir/bin/kioexec --tempfiles ls /tmp/foo
command= "ls" args= ("ls", "/tmp/foo")
EXEC "/usr/bin/ls /tmp/foo"
/usr/bin/ls: cannot access '/tmp/foo': No such file or directory
EXEC done
$ echo $?
2
  
  so the patch works.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28060

To: dfaure, apol, davidedmundson, elvisangelaccio
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

Re: KIO: try to assign an icon to action submenus

[David Faure]

On vendredi 13 mars 2020 21:19:42 CET Chloe Kudryavtsev wrote:
> On 3/13/20 2:18 PM, David Faure wrote:
> > On mardi 3 mars 2020 18:29:47 CET Chloe Kudryavtsev wrote:
> >> Currently, action submenus (X-KDE-Submenu) have no icons.
> >> This patch makes it inherit the icon of the first action.
> > 
> > I wonder if this is always wanted? The icon for the first action might not
> > be representative of what the other actions do.
> > 
> > Wouldn't it be better to be able to explicitly specify the icon for the
> > submenu?
> 
> That would be better, but that can't easily be done without reorganizing
> how the whole thing works.
> insertServicesSubmenus() currently receives a QMap ServiceList>, the target QMenu and a boolean.
> Meanwhile, the icon for the desktop file as a whole would be available
> in the KConfigGroup (from desktopFile).
> 
> Basically, making the "global" (i.e [Desktop Entry]) Icon setting be
> what is used would require breaking API (changing the signature of
> insertServicesSubmenus).

If you're talking about KFileItemActionsPrivate::insertServicesSubmenus
that's a method of the Private class (as the classname indicates),
so you can change it as much as you want, it's not part of the public API.

> In the meanwhile, in practice, ServiceMenus do have (at the very least)
> similar icons, because TryExec is effectively global (there is no
> support for disabling individual actions, it's done purely on a
> per-desktop-file basis).

Right, but I don't like putting something in place with limitations, that 
someone else will surely have a problem with, one day.

> I would participate in an effort to extend KConfig, KIO and co. to
> improve the overall handling of .desktop files, but the process in
> general is kind of a bother, and I don't really like touching C++
> nowadays either, so it's a hard sell to put that as a high priority for me.

This seems a rather strong statement for the work at hand here.
If all that's needed is to pass an icon to insertServicesSubmenus you surely 
don't need to extend KConfig...

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D28060: Fix exitcode from kioexec when executable doesn't exist (and --tempfiles is set)

[David Faure]

dfaure created this revision.
dfaure added reviewers: apol, davidedmundson, elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  kioexec --tempfiles does_not_exist /tmp/foo
  Used to exit with code 0, now it exits with code -1.
  Found by a unittest that will soon be pushed as part of D28020 
.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28060

AFFECTED FILES
  src/kioexec/main.cpp

To: dfaure, apol, davidedmundson, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25815: Transmission-Qt tray icon added

[Nathaniel Graham]

ngraham added a comment.


  @ndavis, since you already submitted an alternative icon, maybe you could 
take this over. @vinzenzv would that be okay with you?

REVISION DETAIL
  https://phabricator.kde.org/D25815

To: vinzenzv, #vdg, ndavis, ngraham
Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, 
cblack, fbampaloukas, GB_2, trickyricky26, michaelh, bruns

D28058: KWayland: Convert license headers to SPDX

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28058

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28058: KWayland: Convert license headers to SPDX

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX expressions and add license files as
  required by REUSE specification.

REPOSITORY
  R127 KWayland

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D28058

AFFECTED FILES
  LICENSES/BSD-3-Clause.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT-CMU.txt
  LICENSES/MIT.txt
  autotests/client/test_compositor.cpp
  autotests/client/test_datadevice.cpp
  autotests/client/test_datasource.cpp
  autotests/client/test_drag_drop.cpp
  autotests/client/test_error.cpp
  autotests/client/test_fake_input.cpp
  autotests/client/test_idle.cpp
  autotests/client/test_plasma_virtual_desktop.cpp
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_pointer_constraints.cpp
  autotests/client/test_remote_access.cpp
  autotests/client/test_selection.cpp
  autotests/client/test_server_side_decoration.cpp
  autotests/client/test_server_side_decoration_palette.cpp
  autotests/client/test_shadow.cpp
  autotests/client/test_shm_pool.cpp
  autotests/client/test_text_input.cpp
  autotests/client/test_wayland_appmenu.cpp
  autotests/client/test_wayland_blur.cpp
  autotests/client/test_wayland_connection_thread.cpp
  autotests/client/test_wayland_contrast.cpp
  autotests/client/test_wayland_filter.cpp
  autotests/client/test_wayland_fullscreen_shell.cpp
  autotests/client/test_wayland_output.cpp
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  autotests/client/test_wayland_region.cpp
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_wayland_seat.cpp
  autotests/client/test_wayland_shell.cpp
  autotests/client/test_wayland_slide.cpp
  autotests/client/test_wayland_subcompositor.cpp
  autotests/client/test_wayland_subsurface.cpp
  autotests/client/test_wayland_surface.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  autotests/client/test_xdg_decoration.cpp
  autotests/client/test_xdg_foreign.cpp
  autotests/client/test_xdg_output.cpp
  autotests/client/test_xdg_shell.cpp
  autotests/client/test_xdg_shell.h
  autotests/client/test_xdg_shell_stable.cpp
  autotests/client/test_xdg_shell_v5.cpp
  autotests/client/test_xdg_shell_v6.cpp
  autotests/server/surfaceextension_helper.cpp
  autotests/server/test_display.cpp
  autotests/server/test_no_xdg_runtime_dir.cpp
  autotests/server/test_qt_surface_extension.cpp
  autotests/server/test_seat.cpp
  cmake/Modules/FindWaylandProtocols.cmake
  src/client/appmenu.cpp
  src/client/appmenu.h
  src/client/blur.cpp
  src/client/blur.h
  src/client/buffer.cpp
  src/client/buffer.h
  src/client/buffer_p.h
  src/client/compositor.cpp
  src/client/compositor.h
  src/client/connection_thread.cpp
  src/client/connection_thread.h
  src/client/contrast.cpp
  src/client/contrast.h
  src/client/datadevice.cpp
  src/client/datadevice.h
  src/client/datadevicemanager.cpp
  src/client/datadevicemanager.h
  src/client/dataoffer.cpp
  src/client/dataoffer.h
  src/client/datasource.cpp
  src/client/datasource.h
  src/client/dpms.cpp
  src/client/dpms.h
  src/client/event_queue.cpp
  src/client/event_queue.h
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/fullscreen_shell.cpp
  src/client/fullscreen_shell.h
  src/client/idle.cpp
  src/client/idle.h
  src/client/idleinhibit.cpp
  src/client/idleinhibit.h
  src/client/keyboard.cpp
  src/client/keyboard.h
  src/client/keystate.cpp
  src/client/keystate.h
  src/client/output.cpp
  src/client/output.h
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/outputmanagement.cpp
  src/client/outputmanagement.h
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/pointer.cpp
  src/client/pointer.h
  src/client/pointerconstraints.cpp
  src/client/pointerconstraints.h
  src/client/pointergestures.cpp
  src/client/pointergestures.h
  src/client/protocols/appmenu.xml
  src/client/protocols/blur.xml
  src/client/protocols/contrast.xml
  src/client/protocols/dpms.xml
  src/client/protocols/fake-input.xml
  src/client/protocols/idle.xml
  src/client/protocols/keystate.xml
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/protocols/plasma-effects.xml
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/protocols/plasma-window-management.xml
  src/client/protocols/remote-access.xml
  

D28056: KWindowSystem: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr added a task: T11550: Add SPDX License markers.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28056

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28056: KWindowSystem: Convert license headers to SPDX expressions

[Andreas Cord-Landwehr]

cordlandwehr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cordlandwehr requested review of this revision.

REVISION SUMMARY
  Convert license headers to SPDX expressions and add license
  files according to REUSE specification.

REPOSITORY
  R278 KWindowSystem

BRANCH
  spdx

REVISION DETAIL
  https://phabricator.kde.org/D28056

AFFECTED FILES
  LICENSES/LGPL-2.0-only.txt
  LICENSES/LGPL-2.0-or-later.txt
  LICENSES/LGPL-2.1-only.txt
  LICENSES/LGPL-2.1-or-later.txt
  LICENSES/LGPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
  LICENSES/MIT.txt
  autotests/compositingenabled_test.cpp
  autotests/dontcrashmapviewport.cpp
  autotests/fixx11h_test.cpp
  autotests/fixx11h_test2.cpp
  autotests/helper/wayland_platform.cpp
  autotests/kkeyserver_x11_unittest.cpp
  autotests/kmanagerselectiontest.cpp
  autotests/kmanagerselectiontest.h
  autotests/kstartupinfo_unittest.cpp
  autotests/kwindoweffectstest.cpp
  autotests/kwindowinfox11test.cpp
  autotests/kwindowsystem_platform_wayland_test.cpp
  autotests/kwindowsystem_threadtest.cpp
  autotests/kwindowsystemx11test.cpp
  autotests/kxmessages_unittest.cpp
  autotests/netrootinfotestwm.cpp
  autotests/nettesthelper.h
  autotests/netwininfotestclient.cpp
  autotests/netwininfotestwm.cpp
  src/kkeyserver.cpp
  src/kkeyserver.h
  src/kstartupinfo.cpp
  src/kstartupinfo.h
  src/kusertimestamp.cpp
  src/kusertimestamp.h
  src/kwindoweffects.cpp
  src/kwindoweffects.h
  src/kwindoweffects_dummy.cpp
  src/kwindoweffects_dummy_p.h
  src/kwindoweffects_p.h
  src/kwindowinfo.cpp
  src/kwindowinfo.h
  src/kwindowinfo_dummy_p.h
  src/kwindowinfo_p.h
  src/kwindowshadow.cpp
  src/kwindowshadow.h
  src/kwindowshadow_dummy_p.h
  src/kwindowshadow_p.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h
  src/kwindowsystem_dummy_p.h
  src/kwindowsystem_p.h
  src/kwindowsystemplugininterface.cpp
  src/kwindowsystemplugininterface_p.h
  src/netwm_def.h
  src/platforms/osx/kkeyserver.cpp
  src/platforms/osx/kkeyserver_mac.h
  src/platforms/osx/kwindowinfo.cpp
  src/platforms/osx/kwindowinfo_mac_p.h
  src/platforms/osx/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem.cpp
  src/platforms/wayland/kwindowsystem_p_wayland.h
  src/platforms/wayland/plugin.cpp
  src/platforms/wayland/plugin.h
  src/platforms/windows/kkeyserver.cpp
  src/platforms/windows/kkeyserver_win.h
  src/platforms/windows/kwindowinfo.cpp
  src/platforms/windows/kwindowsystem.cpp
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/fixx11h.h
  src/platforms/xcb/kkeyserver.cpp
  src/platforms/xcb/kkeyserver_x11.h
  src/platforms/xcb/kselectionowner.cpp
  src/platforms/xcb/kselectionowner.h
  src/platforms/xcb/kselectionwatcher.cpp
  src/platforms/xcb/kselectionwatcher.h
  src/platforms/xcb/kwindoweffects.cpp
  src/platforms/xcb/kwindoweffects_x11.h
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h
  src/platforms/xcb/kwindowshadow.cpp
  src/platforms/xcb/kwindowshadow_p_x11.h
  src/platforms/xcb/kwindowsystem.cpp
  src/platforms/xcb/kwindowsystem_p_x11.h
  src/platforms/xcb/kxerrorhandler.cpp
  src/platforms/xcb/kxerrorhandler_p.h
  src/platforms/xcb/kxmessages.cpp
  src/platforms/xcb/kxmessages.h
  src/platforms/xcb/kxutils.cpp
  src/platforms/xcb/kxutils_p.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h
  src/platforms/xcb/plugin.cpp
  src/platforms/xcb/plugin.h
  src/pluginwrapper.cpp
  src/pluginwrapper_p.h
  tests/backgroundcontrasttest.cpp
  tests/blurbehindtest.cpp
  tests/createpixmapfromhandletest.cpp
  tests/icontest.cpp
  tests/setmainwindowtest.cpp

To: cordlandwehr
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 333 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/333/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Mar 2020 11:43:28 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 332 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/332/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Mar 2020 09:33:21 +
 Build duration:
2 hr 10 min and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D28020: New class ProcessLauncherJob in KIOGui

[David Faure]

dfaure planned changes to this revision.
dfaure added inline comments.

INLINE COMMENTS

> davidedmundson wrote in kprocessrunner.cpp:39
> WId as an int is problematic for wayland.
> 
> Can we do QWindow*? it'll allow adding support in future.
> 
> For the compatibility path we can loop through QApp->windows to find the 
> object from windowId

Actually if D28016  is approved, I can 
remove the windowId altogether.

> davidedmundson wrote in processlauncherjob.h:111
> I don't like that this has to be available immediately after start()
> 
> it means we can't make all the blocking calls for kiofuse/discrete 
> gpus/whatever async.
> 
> which would be really nice for the future.
> 
> can we have a signal 
> started();
> 
> and it's valid after that?
> 
> or...alternatively have ProcessLaunchJob::finished() come after 
> processStarted, instead of when the process ends?  and this is valid when the 
> job completes? From a plasma POV I just want to know if kate started ok, but 
> I don't care if it crashes later.

This is an excellent point. This keeps bothering me too.

One issue is that in order to use this from KRun I needed the PID immediately.
But maybe we can add a blocking method (with QProcess::waitForStarted, no event 
loop there) specifically for KRun, until KF6.

Re job completion, I agree that apps only care about starting the process.
The idea of watching for exit code to detect non-existing executable was only a 
small optimization in 2000 (commit 15bd0141a63f244bdd6f9 
), 
let's move this around and check before hand, it'll be much simpler.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28020

To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » prison » kf5-qt5 AndroidQt5.14 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/6/
 Project:
kf5-qt5 AndroidQt5.14
 Date of build:
Sun, 15 Mar 2020 09:33:01 +
 Build duration:
2 min 29 sec and counting

D27947: Port away from deprecated QList::toSet()

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:30d964096430: Port away from deprecated QList::toSet() 
(authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27947?vs=77287=77649

REVISION DETAIL
  https://phabricator.kde.org/D27947

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/filewidgets/kfilepreviewgenerator.cpp
  src/urifilters/ikws/searchproviderdlg.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28030: Also expose the true minimum size to QML

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:e0dec83dd692: Also expose the true minimum size to QML 
(authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28030?vs=77578=77650

REVISION DETAIL
  https://phabricator.kde.org/D28030

AFFECTED FILES
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h
  tests/barcode.qml

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:018f223692de: [KPasswdServer] replace foreach with 
range/index-based for (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27965?vs=77554=77648

REVISION DETAIL
  https://phabricator.kde.org/D27965

AFFECTED FILES
  src/kpasswdserver/autotests/kpasswdservertest.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27989: Add a new set of barcode size functions

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:838f886c380f: Add a new set of barcode size functions 
(authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27989?vs=77441=77647

REVISION DETAIL
  https://phabricator.kde.org/D27989

AFFECTED FILES
  autotests/aztecbarcodetest.cpp
  autotests/code128barcodetest.cpp
  src/lib/abstractbarcode.cpp
  src/lib/abstractbarcode.h
  src/quick/barcodequickitem.cpp

To: vkrause, svuorela
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27947: Port away from deprecated QList::toSet()

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-kcoredirlister-toset (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27947

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27965: [KPasswdServer] replace foreach with range/index-based for

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  l-kpasswdserver (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27965

To: ahmadsamir, #frameworks, dfaure, meven
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27986: Allow providing an error message from the application

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27986

To: apol, #frameworks, sitter, dfaure
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns