D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis updated this revision to Diff 78136.
ndavis added a comment.


  - Use evenly distributed and proportioned style for dialpad

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28163?vs=78107=78136

BRANCH
  dialpad-voicemail (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28163

AFFECTED FILES
  icons-dark/actions/16/call-voicemail.svg
  icons-dark/actions/22/call-voicemail.svg
  icons-dark/actions/symbolic/call-voicemail-symbolic.svg
  icons-dark/devices/16/input-dialpad.svg
  icons-dark/devices/22/input-dialpad.svg
  icons-dark/devices/symbolic/input-dialpad-symbolic.svg
  icons/actions/16/call-voicemail.svg
  icons/actions/22/call-voicemail.svg
  icons/actions/symbolic/call-voicemail-symbolic.svg
  icons/devices/16/input-dialpad.svg
  icons/devices/22/input-dialpad.svg
  icons/devices/symbolic/input-dialpad-symbolic.svg

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28163: Add input-dialpad and call-voicemail

[Nathaniel Graham]

ngraham added a comment.


  Well, I'm out of ideas

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis added a comment.


  In D28163#631474 , @ngraham wrote:
  
  > Maybe we could keep the dots 2x2 for the 22px version?
  
  
  You can't get even spacing unless you make it way smaller than a normal 22px 
icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/68/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 21 Mar 2020 01:25:48 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testIdleFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 75 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/75/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 21 Mar 2020 01:25:48 +
 Build duration:
6 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.69.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 47 test(s)Failed: projectroot.autotests.client.kwayland_testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)84%
(27527/32725)53%
(11046/20995)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)98%
(12464/12674)50%
(6538/13169)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6336/7478)65%
(1836/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8128/9772)63%
(2439/3891)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D28168: Broadcast application menu to resources when registering them

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8032cb0f0e9a: Broadcast application menu to resources 
when registering them (authored by cblack).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28168?vs=78119=78133

REVISION DETAIL
  https://phabricator.kde.org/D28168

AFFECTED FILES
  src/server/plasmawindowmanagement_interface.cpp

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, zzag, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/67/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 16:59:31 +
 Build duration:
8 hr 4 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/66/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 12:33:25 +
 Build duration:
11 hr and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

D28163: Add input-dialpad and call-voicemail

[Bhushan Shah]

bshah added a comment.


  Hmm yeah I am also not a fan of the stretched out dialpad icon

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28168: Broadcast application menu to resources when registering them

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/broadcast-appmenu-on-resource-register (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28168

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, zzag, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28169: [DesktopExecParser] Let the service open protocols is claims to support

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in desktopexecparser.cpp:350
> Doesn't this break the special case in the comment below?
> VLC claims to support smb:// but if we have a password, we need to be able to 
> pass it, so we want to use KIOFuse?
> 
> And then if you fix that, we're back to a simple revert of the last commit, 
> no?

Indeed.

However I still think the condition is flawed:

- vlc.desktop says it supports smb:// so "supported" is true, !supported is 
false, we go the branch of ||, userName is not empty but password is empty, go 
to KIOFuse
- but what if both the userName and password _aren't_ empty, vlc is already out 
of the picture

IIUC, vlc has native smb support which will beat any FUSE equivalent, right?

I'll think about it some more :/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28163: Add input-dialpad and call-voicemail

[Nathaniel Graham]

ngraham added a comment.


  Maybe we could keep the dots 2x2 for the 22px version?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28169: [DesktopExecParser] Let the service open protocols is claims to support

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> desktopexecparser.cpp:350
>  const QUrl url = d->urls.at(i);
> -if (hasSchemeHandler(url)) {
> + // if the app/service claims to support opening this protocol, 
> let it
> +if (isProtocolInSupportedList(url, appSupportedProtocols)) {

Doesn't this break the special case in the comment below?
VLC claims to support smb:// but if we have a password, we need to be able to 
pass it, so we want to use KIOFuse?

And then if you fix that, we're back to a simple revert of the last commit, no?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28169

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Ahmad Samir]

ahmadsamir added a comment.


  
  
  In D28122#631254 , @kossebau wrote:
  
  > Please also add a note in the documentation when to use 
new-name-of-KFontDialog and when QFontDialog, i.e. in which use-cases 
new-name-of-KFontDialog is superior and not using the non-platform one is 
justified.
  
  
  I tried documenting the features, the result is a bit shoddy... :)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Ahmad Samir]

ahmadsamir updated this revision to Diff 78124.
ahmadsamir added a comment.


  - Rename to KFontChooserDialog to prevent conflict with the one from 
KDELibs4Support
  - Document "features"

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28122?vs=77904=78124

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

AFFECTED FILES
  docs/pics/kfontchooserdialog.png
  src/CMakeLists.txt
  src/kfontchooserdialog.cpp
  src/kfontchooserdialog.h
  tests/CMakeLists.txt
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

Re: 2 kirigami fixes for a point release

[David Faure]

On vendredi 20 mars 2020 12:16:09 CET David Edmundson wrote:
> >> > Kirigami seems to be rather unstable, I wonder if anything can be done
> >> > to
> >> > improve upon that [*].
> >> 
> >> One important thing seems to have been getting sloppy in those repos;
> >> mandatory code reviews.
> >> That's an easy thing to enforce, and we know it makes a huge difference
> >> to
> >> code.
> >> 
> >> Even if no-one comments, the extra delay of it running on your own
> >> system delivers a lot.
> >
> >I fully agree.
> >
> >(CC'ing the developer lists)
> 
> The situation with code reviews has not changed.
> 
>  git log --grep Differential --invert-grep  --since 1.month
> 
> In Kirigami is extremely disappointing, and not something we see in
> other frameworks.

Thanks for noticing (and for the nice git command line!).

I'm going to ask more directly than the other David dares doing...

@Marco, can you please start using phabricator for all your commits, so that 
they get reviewed?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir added a comment.


  See D28169 .

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28169: [DesktopExecParser] Let the service open protocols is claims to support

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, sitter, feverfew, ngraham.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  This reverts commit 14b7f2c7ee72b 
; 
the added unit test failed on the
  CI system because hasSchemeHandler() couldn't find the ktelnetservice5.desktop
  file in /usr/share/applications, as KIO isn't installed on the CI system.
  
  However, if we have a service and it claims to support opening urls with
  certain protocols/schemes, then we should let it do that.
  
  Besides the original condition seems flawed as it meant that even if
  isProtocolInSupportedList() returned true, we'd still take the
  KIOFuse path.
  
  CCBUG: 418258

TEST PLAN
  kiowidgets-krununittest passes

REPOSITORY
  R241 KIO

BRANCH
  l-krun-ssh-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28169

AFFECTED FILES
  src/core/desktopexecparser.cpp

To: ahmadsamir, #frameworks, dfaure, sitter, feverfew, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28168: Broadcast application menu to resources when registering them

[Carson Black]

cblack created this revision.
cblack added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Previously, KWayland wasn't hanging onto the application menu
  to broadcast it when registering a resource. This fixes that.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/broadcast-appmenu-on-resource-register (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28168

AFFECTED FILES
  src/server/plasmawindowmanagement_interface.cpp

To: cblack, #kwin
Cc: kde-frameworks-devel, zzag, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28129: Read the new message string after rather than before

[Aleix Pol Gonzalez]

apol updated this revision to Diff 78117.
apol added a comment.
This revision is now accepted and ready to land.


  Fix it in a theoretically better but more convoluted way

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28129?vs=77929=78117

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28129

AFFECTED FILES
  src/backtracegenerator.cpp
  src/backtracewidget.cpp
  src/data/debuggers/internal/gdbrc
  src/data/debuggers/internal/lldbrc
  src/debugger.cpp
  src/debugger.h
  src/gdbhighlighter.cpp
  src/gdbhighlighter.h
  src/parser/backtraceline.h
  src/parser/backtraceparser.cpp
  src/parser/backtraceparser.h
  src/parser/backtraceparser_p.h
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h

To: apol, #frameworks, broulik, sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis added a comment.


  In D28163#631346 , @ngraham wrote:
  
  > I thought the margins were maximums. Making the icon skinnier seems fine to 
me.
  
  
  they are maximums. those guides are at the canvas size. At the correct 
proportion, it's 22px tall. If I try to shrink the size of the squares, then I 
get ridiculous spacing or they make the icon off center.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28164: Add test for application menu in PWM interface

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4f4142d3d3a8: Add test for application menu in PWM 
interface (authored by cblack).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28164?vs=78109=78111

REVISION DETAIL
  https://phabricator.kde.org/D28164

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28163: Add input-dialpad and call-voicemail

[Nathaniel Graham]

ngraham added a comment.


  I thought the margins were maximums. Making the icon skinnier seems fine to 
me.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis added a comment.


  In D28163#631343 , @ngraham wrote:
  
  > The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. 
The others look fine.
  
  
  I agree, but it's really hard to get the proportions right and have it 
respect the usual margins. Do you think it would be OK to break the rules on 
margins here? F8186554: Screenshot_20200320_125611.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28163: Add input-dialpad and call-voicemail

[Nathaniel Graham]

ngraham added a comment.


  The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. 
The others look fine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28164: Add test for application menu in PWM interface

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28164

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28164: Add test for application menu in PWM interface

[Carson Black]

cblack created this revision.
cblack added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  See that the test works as expected.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28164

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp

To: cblack, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28163

To: ndavis, #vdg
Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28163: Add input-dialpad and call-voicemail

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Requested by @bshah for Plasma Mobile

REPOSITORY
  R266 Breeze Icons

BRANCH
  dialpad-voicemail (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28163

AFFECTED FILES
  icons-dark/actions/16/call-voicemail.svg
  icons-dark/actions/22/call-voicemail.svg
  icons-dark/actions/symbolic/call-voicemail-symbolic.svg
  icons-dark/devices/16/input-dialpad.svg
  icons-dark/devices/22/input-dialpad.svg
  icons-dark/devices/symbolic/input-dialpad-symbolic.svg
  icons/actions/16/call-voicemail.svg
  icons/actions/22/call-voicemail.svg
  icons/actions/symbolic/call-voicemail-symbolic.svg
  icons/devices/16/input-dialpad.svg
  icons/devices/22/input-dialpad.svg
  icons/devices/symbolic/input-dialpad-symbolic.svg

To: ndavis, #vdg
Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir added a comment.


  OK, I see why it's failing. KMimeTypeTrader::self()->preferredService() (from 
schemeService()) can't find ktelnetservice5.desktop in /usr/share/applications/ 
since KIO isn't installed on the CI system; so skip the test in that case?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham marked 4 inline comments as done.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[Ahmad Samir]

ahmadsamir added a comment.


  In D27999#631255 , @dfaure wrote:
  
  > This commit breaks krununittest in CI, can you take a look?
  >
  > 
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/471/testReport/junit/projectroot/autotests/kiowidgets_krununittest/
  >
  > Thanks.
  
  
  I did pass locally :/; I'm on it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 78104.
ngraham added a comment.


  Use the new `veryLongDuration` duration instead a multiple of `longDuration`

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=78103=78104

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Please also add a note in the documentation when to use KFontDialog and when 
QFontDialog, i.e. in which use-cases KFontDialog is superior and not using the 
non-platform one is justified.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

[David Faure]

dfaure added a comment.


  This commit breaks krununittest in CI, can you take a look?
  
  
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/471/testReport/junit/projectroot/autotests/kiowidgets_krununittest/
  
  Thanks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D27999

To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 78103.
ngraham added a comment.


  Rebase

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28033?vs=77947=78103

BRANCH
  ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28033

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml
  src/declarativeimports/plasmaextracomponents/qml/qmldir

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Ahmad Samir]

ahmadsamir added a comment.


  In D28122#631237 , @kossebau wrote:
  
  > Moving a class (and thus its exported symbols) from a library to another 
one in its public dependency interface should be doable I guess (no actual 
experience in having done that though).
  >
  > But you sadly cannot change/remove exported symbols and the data layout, 
like done here (e.g. by dropping the KDialog intermediate inherited class data).
  >
  > So you will need a new name, KFontDialog cannot be reused.
  
  
  Nearest candidate is KFontChooserDialog, which describes this class, a dialog 
for KFontChooser widget :)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:049978008b12: Make animation durations consistent with 
Kirigami values (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28144?vs=78036=78102

REVISION DETAIL
  https://phabricator.kde.org/D28144

AFFECTED FILES
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added a dependency: D28144: Make animation durations consistent with 
Kirigami values.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma, davidedmundson
Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Moving a class (and thus its exported symbols) from a library to another one 
in its public dependency interface should be doable I guess (no actual 
experience in having done that though).
  
  But you sadly cannot change/remove exported symbols and the data layout, like 
done here (e.g. by dropping the KDialog intermediate inherited class data).
  
  So you will need a new name, KFontDialog cannot be reused.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28144: Make animation durations consistent with Kirigami values

[Nathaniel Graham]

ngraham added a dependent revision: D28033: Create ExpandableListItem.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28144: Make animation durations consistent with Kirigami values

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  improved-durations (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28144

To: ngraham, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Ahmad Samir]

ahmadsamir added a comment.


  (Also could some one with more power than me clang-format this whole repo 
(there's a clang-format.cmake in extra-cmake-modules)? just note that some 
hand-formatted char* definitions blow up :)).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28161

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: dfaure, sitter, apol.
Herald added projects: Dolphin, Frameworks.
Herald added a subscriber: kfm-devel.
ahmadsamir requested review of this revision.

TEST PLAN
  Showing man pages in konqueror still works

REPOSITORY
  R320 KIO Extras

BRANCH
  l-QRE (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28161

AFFECTED FILES
  bookmarks/kio_bookmarks.cpp
  fish/fish.cpp
  man/kio_man.cpp
  man/man2html.cpp
  smb/kdsoap-ws-discovery-client/autotests/test_wsdiscoveryclient.cpp

To: ahmadsamir, dfaure, sitter, apol
Cc: kfm-devel, kde-frameworks-devel, pberestov, iasensio, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D27214: add puremaps icon

[Mathis Brüchert]

mbruchert added a comment.


  there is only a puremaps flatpak and the icon there is called 
'io.github.rinigus.PureMaps.png' should it be renamed to that?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27214

To: mbruchert, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 181 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/181/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 20 Mar 2020 11:50:45 +
 Build duration:
2 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 288 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/288/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 11:50:45 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 174 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/174/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 11:50:45 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D27246: add buho icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:01354ce40243: add buho icon (authored by mbruchert, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27246?vs=78086=78088

REVISION DETAIL
  https://phabricator.kde.org/D27246

AFFECTED FILES
  icons-dark/apps/48/buho.svg
  icons/apps/48/buho.svg

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27246: add buho icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  buho (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 173 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/173/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 11:46:20 +
 Build duration:
2 min 38 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 180 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/180/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 20 Mar 2020 11:46:20 +
 Build duration:
2 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 287 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/287/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 11:46:20 +
 Build duration:
2 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

D27235: add calindori icon in the new pm style

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e715ff69549e: add calindori icon in the new pm style 
(authored by mbruchert, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27235?vs=78085=78087

REVISION DETAIL
  https://phabricator.kde.org/D27235

AFFECTED FILES
  icons-dark/apps/48/calindori.svg
  icons/apps/48/calindori.svg

To: mbruchert, dkardarakos, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27235: add calindori icon in the new pm style

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  calindori (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27235

To: mbruchert, dkardarakos, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27246: add buho icon

[Mathis Brüchert]

mbruchert updated this revision to Diff 78086.
mbruchert added a comment.


  - fix shadows

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27246?vs=75269=78086

BRANCH
  buho (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27246

AFFECTED FILES
  icons-dark/apps/48/buho.svg
  icons/apps/48/buho.svg

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D27210: add KDEconnect Icons

[Noah Davis]

ndavis added a comment.


  Hmm. I'm not into the color icon. These combinations of colors and shapes 
just seem very foreign to Breeze. If KDE Connect wants to change its icon 
branding, maybe they should have some elements that are a bit more 
abstract/stylized than the current color icon? I currently don't have many 
suggestions, but I'll try to come up with more to say later.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27210

To: mbruchert, #vdg, #kde_connect, ngraham
Cc: ndavis, ngraham, albertvaka, nicolasfella, kde-frameworks-devel, LeGast00n, 
cblack, GB_2, michaelh, bruns

D27235: add calindori icon in the new pm style

[Mathis Brüchert]

mbruchert updated this revision to Diff 78085.
mbruchert added a comment.


  - remove hole

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27235?vs=75236=78085

BRANCH
  calindori (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27235

AFFECTED FILES
  icons-dark/apps/48/calindori.svg
  icons/apps/48/calindori.svg

To: mbruchert, dkardarakos, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 286 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/286/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 11:34:09 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 179 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/179/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 20 Mar 2020 11:34:09 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)80%
(239/300)62%
(112/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(40/55)56%
(10/18)autotests100%
(5/5)100%
(5/5)81%
(199/245)62%
(102/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 172 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/172/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 20 Mar 2020 11:34:09 +
 Build duration:
2 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.symlink

D27255: Add nota icon

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:c40434acbf70: Add nota icon (authored by mbruchert, 
committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27255?vs=78083=78084

REVISION DETAIL
  https://phabricator.kde.org/D27255

AFFECTED FILES
  icons-dark/apps/48/nota.svg
  icons/apps/48/nota.svg

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27210: add KDEconnect Icons

[Mathis Brüchert]

mbruchert added a comment.


  hmm I don't think that It is a problem because both devices the app can run 
on are depicted

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27210

To: mbruchert, #vdg, #kde_connect, ngraham
Cc: ngraham, albertvaka, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D27255: Add nota icon

[Noah Davis]

ndavis retitled this revision from "nota" to "Add nota icon".

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27255: nota

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D27255: nota

[Mathis Brüchert]

mbruchert updated this revision to Diff 78083.
mbruchert added a comment.


  - update dotted lines

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27255?vs=75271=78083

BRANCH
  nota (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27255

AFFECTED FILES
  icons-dark/apps/48/nota.svg
  icons/apps/48/nota.svg

To: mbruchert, camiloh, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 75 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/75/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Fri, 20 Mar 2020 11:15:21 +
 Build duration:
6 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KCMUtils-5.69.0.xmlcompat_reports/KF5KCMUtils_compat_report.htmllogs/KF5KCMUtils/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/21)0%
(0/21)0%
(0/1717)0%
(0/883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/13)0%
(0/13)0%
(0/1299)0%
(0/706)src.ksettings0%
(0/8)0%
(0/8)0%
(0/418)0%
(0/177)

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 108 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/108/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 20 Mar 2020 11:15:03 +
 Build duration:
6 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KCMUtils-5.69.0.xmlcompat_reports/KF5KCMUtils_compat_report.htmllogs/KF5KCMUtils/5.69.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/21)0%
(0/21)0%
(0/1717)0%
(0/883)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/13)0%
(0/13)0%
(0/1299)0%
(0/706)src.ksettings0%
(0/8)0%
(0/8)0%
(0/418)0%
(0/177)

Re: 2 kirigami fixes for a point release

[David Edmundson]

>> > Kirigami seems to be rather unstable, I wonder if anything can be done to
>> > improve upon that [*].
>
>> One important thing seems to have been getting sloppy in those repos;
>> mandatory code reviews.
>> That's an easy thing to enforce, and we know it makes a huge difference to
>> code.
>>
>> Even if no-one comments, the extra delay of it running on your own
>> system delivers a lot.

>I fully agree.
>
>(CC'ing the developer lists)

The situation with code reviews has not changed.

 git log --grep Differential --invert-grep  --since 1.month

In Kirigami is extremely disappointing, and not something we see in
other frameworks.

David

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

[Méven Car]

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me.
  Please wait for me review.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontdlg (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28122

To: ahmadsamir, #frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

[Kai Uwe Broulik]

broulik added a comment.


  Depends on kdeclarative, if that is rebuilt, a rebuild of kcmutil should fix 
that

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28131

To: mart, broulik
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28131: listen to passiveNotificationRequested

[David Faure]

dfaure added a comment.


  CI is not happy: 
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/107/console

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28131

To: mart, broulik
Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28128: Add force save behavior to KEntryMap

[Méven Car]

meven accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kconfigdata.cpp:139
>  
> +// If overidded entry is global and not default. And it's overrided by a 
> non global
> +if (e.bGlobal && !(options & EntryGlobal) && !k.bDefault)

s/overidded/overridden

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D28128

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27504: smb faster copy to local

[Méven Car]

meven added a comment.


  Looks good to me.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D27504

To: sitter, ngraham, cfeck, #frameworks, #dolphin
Cc: meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, 
kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, 
alexde, GB_2, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, mikesomov

D24895: [RFC] Drop implicit size from PC buttons

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Marking as request changes as per my comments above

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart, #vdg, davidedmundson
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, 
cblack, GB_2, michaelh, bruns