D29138: [Solid] Replace foreach (deprecated) with range/index for

[Méven Car]

meven added a comment.


  In D29138#656094 , @dfaure wrote:
  
  > Wow those iterations over map.keys() were awful.
  
  
  We still have a few of those in solid :
  
$ rg ".keys\(\)"
src/tools/solid-hardware/solid-hardware.cpp
151:Q_FOREACH (const QString , properties.keys())

src/solid/devices/backends/udisks2/udisksdevicebackend.cpp
220:Q_FOREACH (const QString , interfaces_and_properties.keys()) {

src/solid/devices/backends/fstab/fstabhandling.cpp
219:QStringList devices = 
globalFstabCache->localData().m_mtabCache.keys();

src/solid/devices/backends/udisks2/udisksmanager.cpp
179:qCDebug(UDISKS2) << udi << "has new interfaces:" << 
interfaces_and_properties.keys();
201:else if (m_deviceCache.contains(udi) && 
interfaces_and_properties.keys().contains(UD2_DBUS_INTERFACE_FILESYSTEM)) {

src/solid/devices/backends/iokit/iokitstorageaccess.cpp
89:Q_FOREACH (const QString , changes.keys()) {

src/solid/devices/backends/iokit/iokitopticaldrive.cpp
284:foreach (const Solid::OpticalDrive::MediumType type, 
d->cdTypeMap.keys()) {
289:foreach (const Solid::OpticalDrive::MediumType type, 
d->dvdTypeMap.keys()) {
294:foreach (const Solid::OpticalDrive::MediumType type, 
d->bdTypeMap.keys()) {

src/solid/devices/backends/hal/halopticaldisc.cpp
34:Q_FOREACH (const Solid::OpticalDisc::ContentType type, map.keys()) {

src/solid/devices/backends/fakehw/fakeopticaldisc.cpp
38:Q_FOREACH (const Solid::OpticalDisc::ContentType type, map.keys()) {

src/solid/devices/backends/fakehw/fakestorageaccess.cpp
60:Q_FOREACH (const QString , changes.keys()) {

src/solid/devices/backends/hal/halcdrom.cpp
55:Q_FOREACH (const Solid::OpticalDrive::MediumType type, map.keys()) {

src/solid/devices/backends/fakehw/fakecdrom.cpp
48:Q_FOREACH (const Solid::OpticalDrive::MediumType type, map.keys()) {

src/solid/devices/backends/udisks2/udisksopticaldrive.cpp
63:Q_FOREACH (const QDBusObjectPath , reply.value().keys()) 
{
208:Q_FOREACH (const Solid::OpticalDrive::MediumType , map.keys()) 
{

INLINE COMMENTS

> fakemanager.cpp:135
>  QStringList result;
> -FakeDevice *device;
> -Q_FOREACH (device, d->loadedDevices) {
> +for (FakeDevice *device : qAsConst(d->loadedDevices)) {
>  if (device->property(key).toString() == value) {

I guess you can const the FakeDevice

> fakemanager.cpp:147
>  QStringList result;
> -FakeDevice *device;
> -Q_FOREACH (device, d->loadedDevices) {
> +for (FakeDevice *device : qAsConst(d->loadedDevices)) {
>  if (device->queryDeviceInterface(type)) {

I guess you can const the FakeDevice

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven updated this revision to Diff 81061.
meven added a comment.


  avoid instanciating m_storageAccess in FstabDevice::FstabDevice

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28590?vs=79922=81061

BRANCH
  arcpatch-D28590

REVISION DETAIL
  https://phabricator.kde.org/D28590

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakedevice.cpp
  src/solid/devices/backends/fakehw/fakedevice.h
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabmanager.cpp
  src/solid/devices/backends/shared/rootdevice.cpp
  src/solid/devices/backends/shared/rootdevice.h
  src/solid/devices/backends/udev/udevdevice.cpp
  src/solid/devices/backends/udev/udevdevice.h
  src/solid/devices/backends/udev/udevmanager.cpp
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h
  src/solid/devices/backends/udisks2/udisksmanager.cpp
  src/solid/devices/backends/upower/upowerdevice.cpp
  src/solid/devices/backends/upower/upowerdevice.h
  src/solid/devices/backends/upower/upowermanager.cpp
  src/solid/devices/frontend/device.cpp
  src/solid/devices/frontend/device.h
  src/solid/devices/ifaces/device.h

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Méven Car]

meven added a comment.


  In D28590#654139 , @bruns wrote:
  
  > Do not create m_storageAccess in the constructor
  
  
  Hmm, you told me `the f (m_displayName.isEmpty()) block belongs here`, I 
don't see why instantiating `m_storageAccess` here is bad but mehh.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29138: [Solid] Replace foreach (deprecated) with range/index for

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fakeopticaldisc.cpp:38
> +
> +for (auto it = map.cbegin(); it != map.cend(); ++it) {
> +if (content_typelist.contains(it.value())) {

dito

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29138: [Solid] Replace foreach (deprecated) with range/index for

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fakecdrom.cpp:48
> +
> +for (auto it = map.cbegin(); it != map.cend(); ++it) {
> +if (supported_medialist.contains(it.value())) {

The obviously better solution is to iterate over `supported_medialist` and swap 
the key and value of the map.

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29138: [Solid] Replace foreach (deprecated) with range/index for

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Wow those iterations over map.keys() were awful.

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

D28811: Add drawer on mobile and clean code

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code 
(authored by ognarb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28811?vs=80229=81051#toc

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80229=81051

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

Re: Problems in KWayland causes by API and ABI compatibility promises

[David Edmundson]

We had a meeting. It resulted in some final action decisions.
These will affect the kwayland folder in frameworks.

The meeting was attended by: Kevin Ottens, Vlad Zahorodnii, Aleix Pol,
Myself, Benjamin Port who all approved the plan.

*Protocols:*

We make a new repo. It will contain just protocol XML files.

plasma-wayland-protocols - target is kdesupport.

Existing protocols remain exactly the same, just moved
New protocols follow upstream wayland-protocols naming scheme using the
"zkde_" prefix

*Client - short term:*

We leave things unchanged.

Kwin tests will continue to use KWayland::Client as is, the upcoming fork
KWayalndServer (mentioned in a bit) will stil use it.

If something comes up that requires an ABI break or new classes from client
(XdgShell for example) we deal with it locally in the relevant repo as per
the longer term plan.

We slowly migrate to the long term plan.


*Client - long term direction:*

If something is used in N places - we should abstract things in a high
level API like KWindowSystem.

If it's used in 1 place, we go native with QtWayalndClientExtension and the
generated classes.

Autotests for the server should use generated low-level classes, see for
example the currently merged tabletmanager autotest. If we need something
in kwin and KWaylandServer, we just do it in both.

Client will still have a KF6 library for doing super core stuff such as
ConnectionThread, wl_surface, buffers etc. It won't contain all the extra
protocols.

At KF6 we rename namespace and repo to KWaylandClient.


*Server - short term:*

We make a new repo. It forks existing KWayland::server classes from
framework's kwayland + the autotests. This goes into kwaylandserver

   -

   put in workspace
   -

   no ABI/API guarantees, but released in sync with kwin
   -

   .so bumps each time
   -

   new namespace (i.e KWaylandServer)
   -

   Institute a complete freeze of the server folder in KF5

*Server - long term direction:*

   - Unit tests migrate to testing against just generated code for the
   extra protocols


   - Drop Interface suffix in class names.


   - Drop from KF6


I'm very hopefully this will really help spur our kwin and wayland efforts
as well as prepare us for KF6.


Regards

David

D28882: Create protocol to manage video feeds

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  In future, it might be faster to put up just the interface xml for review 
first.
  
  --
  
  In terms of wayland protocols this is non-standard.
  
  All clients get a list of available sources. On bind they get all all 
available sources via addSource. Additional sources are new events. 
  That part's fine.
  
  The part with nodeID is unusual. It's convention (though not technically the 
law) that globals broadcast the same thing to all bound resources.
  
  ClientA requests create.
  All clients get a created event
  There's no way to tie a created or failed to the original request 
  Client A and B can both connect to the same source, yet either can call close.
  
  If we're doing a waland protocol I would have expected:
  
ScreenCastInterface - global
event: source_added
event: done
request: get_stream (returns a ScreenStream object)

ScreenStream - resource
event: created
event: failed
event: closed (closed by external sources, clients should now release the 
stream resource)
request: release   (closes the stream if applicable, is also of type 
destructor)

INLINE COMMENTS

> screencast.xml:16
> +
> +
> +

Typically events are like signals, so would be called "source_added"

Convention is also lower_snake_case

> screencast.xml:31
> +
> +
> +

this is racey with create.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich, davidedmundson
Cc: davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Nathaniel Graham]

ngraham added a comment.


  That's much better! I think I'd use a slightly darker shade of gray though. 
Not much, just a bit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

[Chris Escargot]

saligari updated this revision to Diff 81041.
saligari added a comment.


  - corrected hard edges
  - aaand that's it probably for me, I'm reasonably happy with this and I think 
I've learned quite a bit
  - Here it is ^_^

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=81032=81041

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29138: [Solid] Replace foreach (deprecated) with range/index for

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol, meven.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  src/imports/devices.cpp
  src/solid/devices/backends/fakehw/*
  src/solid/devices/backends/fstab/*

TEST PLAN
  make && ctest

REPOSITORY
  R245 Solid

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29138

AFFECTED FILES
  src/imports/devices.cpp
  src/solid/devices/backends/fakehw/fakecdrom.cpp
  src/solid/devices/backends/fakehw/fakedevice.cpp
  src/solid/devices/backends/fakehw/fakemanager.cpp
  src/solid/devices/backends/fakehw/fakeopticaldisc.cpp
  src/solid/devices/backends/fakehw/fakeprocessor.cpp
  src/solid/devices/backends/fakehw/fakestorageaccess.cpp
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabmanager.cpp

To: ahmadsamir, #frameworks, dfaure, apol, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  Same. I will try some half-way that works everywhere more consistenly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  Yeah, to me the third version looks better than the status quo for some 
wallpapers, but worse for others.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker updated this revision to Diff 81035.
heikobecker added a comment.


  Added missing parentheses

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29136?vs=81033=81035

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29136

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

[Heiko Becker]

heikobecker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  I noticed that when installeding marble, which sets
  KDE_INSTALL_DIRS_NO_DEPRECATED, which then invalidates a possibly
  custom location set via KDEInstallIDirs, causing translations to
  land in a surprising locations.

TEST PLAN
  Marble's translations land in the desired location

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29136

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Stefan Brüns]

bruns added a comment.


  > Bruns's comment about right-handed mice (gradient) is due to the quite 
asymmetrical shape many modern mice use for ergonomic reasons (RSI).
  
  No, even for a ball bottom right is darkest. Shapes should be drawn as if 
there were a light at the top left, i.e. with a shadow at the bottom right.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

[Chris Escargot]

saligari updated this revision to Diff 81032.
saligari added a comment.


  - tried to change the shape into something more modern (though I quite like 
the old-ish look)
  - changed the gradient as bruns said, can't say I see much difference
  - removed the middle curve

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=80971=81032

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka added a reviewer: Frameworks.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

[Konrad Materka]

kmaterka updated this revision to Diff 81031.
kmaterka added a comment.


  Rebase to master (includes D29102 )

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28470?vs=80148=81031

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28470

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, 
ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#655680 , @ngraham wrote:
  
  > To be honest, I kinda prefer the befores since the afters are significantly 
darker. Is there a way to preserve the desired level of translucency without 
causing the background to darken like that?
  
  
  Yeah, but it results in very altered colors in wallpapers like Volna. I added 
a second variant to show that. Feedback very welcome!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Johan Ouwerkerk]

ouwerkerk added a comment.


  In D29095#655214 , @ngraham wrote:
  
  > FWIW all the mice in my house have this exact shape, but they're black, not 
gray. So I don't think the shape is too old-fashioned per se. It's the gray 
color that's anacrhonistic part,  since it's a very 90s/early 2000s color and 
modern mice tend to be black: F8254746: Screenshot_20200422_210145.png 

  
  
  Well, one thing you'll also note is that modern mice tend to be narrower 
(and/or have a twist in the shape and/or have a slight inwards curve towards 
the middle (top and bottom are wider than the middle part).
  
  Bruns comment about right-handed mice (gradient) is due to the quite 
asymmetrical shape many modern mice use for ergonomic reasons (RSI).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

[Stefan Brüns]

bruns added a comment.


  F8255905: bitmap.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0004e5c89a24: [KFontChooser] Add new DisplayFlag; modify 
how flags are used (authored by ahmadsamir).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29065?vs=81007=81011

REVISION DETAIL
  https://phabricator.kde.org/D29065

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Stefan Brüns]

bruns added a comment.


  The new one looks very oldschool. Some ideas how to improve that:
  
  - buttons are typically only separated from each other, but not from the 
body, try removing the horizontal line
  - the body should be narrower at the center
  - the gradient does not match the shape. Bottom right should be darkest

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D28882: Create protocol to manage video feeds

[Jan Grulich]

jgrulich added a comment.


  I have tested this and it now works as before, tested with Chromium, while 
checking all the values we pass to the portal and PipeWire which seem to be 
correct.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Ahmad Samir]

ahmadsamir marked an inline comment as done.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Ahmad Samir]

ahmadsamir updated this revision to Diff 81007.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.


  More docs, and a trailing comma in the enum to ease git diff/blame if more 
flags are added

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29065?vs=80989=81007

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[David Faure]

dfaure added a comment.


  I agree, it's now common practice to have a final comma.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kfontchooser.h:90
> Wouldn't that look a bit weird as if something has been removed or missing?

I might perhaps while getting used to if you are coming from old code habits, 
but the syntax of C++ has been extra extended to allow this, among others to 
make patches/diffs less noisy or #if#else around list ends, but many also fancy 
this for line-by-line git blame improvements.

And the majority of projects I contribute to now does this by default, and no 
confusion known to me, the eyes get quickly adapted to the pattern, even more 
as each line now has the same content

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> bruns wrote in plasma-kded.service.in:5
> How about using some LIBEXEC dir instead, this should never be called 
> directly, or am I missing something?

This is unrelated and kded has been there forever

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasma-kded.service.in:5
> @CMAKE_INSTALL_FULL_BINDIR@

How about using some LIBEXEC dir instead, this should never be called directly, 
or am I missing something?

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontchooser.h:87
> maybe document that FixedFontsOnly implies NoFixedCheckBox?
> 
> (as in, the widget will behave as if NoFixedCheckBox was set)

Yes, will do (less surprises for users of the class).

> kossebau wrote in kfontchooser.h:90
> I would add a final ",", so you do not need to touch the line if any further 
> flags are added in the future. Improves git blame display per line :)

Wouldn't that look a bit weird as if something has been removed or missing?

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Nathaniel Graham]

ngraham added a comment.


  Hmm yeah, that gray color is probably too dark. Also a color that dark likely 
wouldn't need an outline as it would be visible on both light and dark 
backgrounds.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Nathaniel Graham]

ngraham added a comment.


  To be honest, I kinda prefer the befores since the afters are significantly 
darker. Is there a way to preserve the desired level of translucency without 
causing the background to darken like that?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/11/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 23 Apr 2020 13:38:54 +
 Build duration:
7 min 26 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testPlasmaShellFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> kfontchooser.h:90
> +ShowDifferences = 4,///< Display the font differences interfaces
> +NoFixedCheckBox = 8 ///< Do not Show a checkbox to toggle 
> showing only fixed fonts
>  };

I would add a final ",", so you do not need to touch the line if any further 
flags are added in the future. Improves git blame display per line :)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8945c1f7baaf: [server] Add some sub-surface life cycle 
signals (authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27860?vs=76996=80998#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27860?vs=76996=80998

REVISION DETAIL
  https://phabricator.kde.org/D27860

AFFECTED FILES
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: zzag, #kwin, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfontchooser.h:87
> +NoDisplayFlags = 0, ///< No flags set
> +FixedFontsOnly = 1, ///< Only show fixed fonts, excluding 
> proportional fonts
> +DisplayFrame = 2,   ///< Show a visual frame around the chooser

maybe document that FixedFontsOnly implies NoFixedCheckBox?

(as in, the widget will behave as if NoFixedCheckBox was set)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28582: KRunner: Show error message for Actions in dbus runner

[Alexander Lohnau]

alex added a comment.


  I am also going to try a friendly ping here :-).

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D28582

To: alex, #plasma, davidedmundson, broulik, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29051: Add ecm_generate_dbus_service_file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Any chance for a simple unit test to check the generation does what is 
expected (or catches bad input)? :)

INLINE COMMENTS

> ECMGenerateDBusServiceFile.cmake:22
> +# are to be installed in the same directory as the D-Bus daemon. On other 
> platforms
> +#  must be an absolute path to the service executable.
> +#

This might be misunderstood that people on the caller side need to do an 
if/else switch for what to pass as EXECUTABLE.
Perhaps change to say this should be the absolute path (and give a hint that 
with KDEInstallDirs being used this should be then the _FULL variant of the 
variable.)
The actual special handling for the Windows case could be mentioned as a note 
only, for the curious user.

> ECMGenerateDBusServiceFile.cmake:24
> +#
> +# Optionally, a  can be specified.
> +#

This leaves me puzzled what values are exactly accepted here, should get more 
details (and perhaps a separate example).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Thu, 23 Apr 2020 13:03:44 +
 Build duration:
2 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.quickviewsharedengine

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Niccolò Venerandi]

niccolove added a comment.


  In D28353#655226 , @ngraham wrote:
  
  > It's okay. :)
  >
  > This is gonna seem like a really dumb question, but which images are the 
befores and which are the afters?
  
  
  Not a dumb question! They are all before-after, but keep in mind that they 
have the colorscheme change patch applied, so they both look different from 
default. First one is default + your colorscheme patch, second one is defult + 
colorscheme patch + this patch.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28355: Introduce function ecm_install_configured_file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  A bit unsure if the arg name "TEMPLATES" is good, or if perhaps should be 
renamed to "INPUT". Just mentioning, not preferring one over the other. So far 
have not found existing samples to take as lead for consistent argument naming.
  
  For completeness, would be good to test for presence of ARGS_DESTINATION, 
given this is a required arg, and do an error report, instead of falling flat 
internally on the install() command.
  ARGS_TEMPLATES should be fine to be empty, no need to error out on that, 
might happen if input on caller side is based on a var which gets filled 
conditionally and might eventually end with empty list,
  
  And while talking checking input, I recently learned about the foillowing 
handling, and think it provides users of the macros some service in case of 
typos or accidental misuse, so propose to also add here:
  
if(ARGS_UNPARSED_ARGUMENTS)
  message(FATAL_ERROR "Unknown arguments given to 
ecm_install_configured_file(): \"${ARGS_UNPARSED_ARGUMENTS}\"")
endif()
  
  Otherwise looks good to me as well, no showstoppers on my mind. Not yet 
tested myself though, only looked at patch code.

INLINE COMMENTS

> ECMConfiguredInstall.cmake:5
> +#
> +# Take a list of files, runs configure_file and installs the resultant 
> configured file in the given location.
> +#

"Takes". And: configured "files", given "list of files"?

> CMakeLists.txt:2
> +project(ECMConfiguredInstallTest)
> +cmake_minimum_required(VERSION 3.5)
> +set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/../../modules)

cmake_minimum_required should be first line always, for consistent pattern.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson, #build_system
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, bencreasy, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

[Ahmad Samir]

ahmadsamir updated this revision to Diff 80989.
ahmadsamir marked 2 inline comments as done.
ahmadsamir retitled this revision from "[KFontChooser] Add a DisplayFlag to 
allow not showing fixedOnly checkbox" to "[KFontChooser] Add new DisplayFlag; 
modify how flags are used".
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Verbatim

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29065?vs=80988=80989

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

[Ahmad Samir]

ahmadsamir updated this revision to Diff 80988.
ahmadsamir added a comment.


  - Use a proper flag set, 0/1/2/4/8, from dfaure
  - When checking a flag is set use bitwise &, not bitwise ^, the latter would 
fail if another flag was set
  - As per dfaure's suggestion, when FixedFontsOnly is set, don't use the 
checkbox that toggles/filters fixed fonts
  - Add more use cases to the kfontchooserdialogtest app

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29065?vs=80792=80988

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29096: Prefix includes and libs dir with QT_SYSROOT

[Erik Schilling]

ablu added a comment.


  > Not having done much cross-compilation-library-setups naively I would have 
thought that when building a library which uses ECMGeneratePriFile and 
preparing it for cross-compilation, the installation prefix would be hardcoded 
into the generated artifacts.. Seems that instead files are relocated 
sometimes, changing their path & prefix, or tools snipping of some things?
  
  There does not seem to be THE way to do it, gcc and alike have --sysroot for 
overriding the otherwise default of /usr/{include,lib}, cmake has variables 
which you can change to modify the path from which stuff is loaded, Qt itself 
uses variables like $$QT_MODULE_INCLUDE_BASE which is filled by 
MODULE_BASE_INDIR which is filled relative to a filename in the Qt install dir. 
I thought about using QT_MODULE_INCLUDE_BASE (and the lib alternative) first, 
but these are no public Qt API and could change any time. In contrast 
QT_SYSROOT is documented and should do the job I think.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29096

To: ablu, #build_system, apol, vkrause, kfunk
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80984.
apol added a comment.


  Also propagate the buffer size, it's important for the client to know what 
buffer size it will have.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80801=80984

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  autotests/server/CMakeLists.txt
  autotests/server/test_screencasting.cpp
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/screencasting_interface.cpp
  src/server/screencasting_interface.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28355: Introduce function ecm_install_configured_file

[Friedrich W. H. Kossebau]

kossebau added a reviewer: Build System.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson, #build_system
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, bencreasy, michaelh, ngraham, bruns

D29096: Prefix includes and libs dir with QT_SYSROOT

[Friedrich W. H. Kossebau]

kossebau added reviewers: Build System, apol, vkrause, kfunk.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29096

To: ablu, #build_system, apol, vkrause, kfunk
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns

D29096: Prefix includes and libs dir with QT_SYSROOT

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for the explanation, fear though I am missing some details and thus 
have not yet understood the problem and the solution. Not having done much 
cross-compilation-library-setups naively I would have thought that when 
building a library which uses ECMGeneratePriFile and preparing it for 
cross-compilation, the installation prefix would be hardcoded into the 
generated artifacts.. Seems that instead files are relocated sometimes, 
changing their path & prefix, or tools snipping of some things? So 
$$[QT_SYSROOT] would make up for that, when having a library build normally for 
a system, but then deployed to the cross-compilation system below some path? 
Just curious in case you have time to teach me, positioning myself here as 
curious person at the sideline :)
  
  For what I tested at least, the setups I was interested in with my question, 
non-systemwide installations, like for a developer having their development env 
in their home folder and helping qmake to find pri files using QMAKEPATH env 
var, this patch seems to not affect this, so no objections from me :)
  
  To help getting some people who can judge this is a proper patch for the 
actual purpose, adding some more explicit reviewers now.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29096

To: ablu
Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D29126#655523 , @dfaure wrote:
  
  > And KRun was widgets based too. At least now you can get rid of widgets 
completely (for this bit about starting apps) by connecting to the result() 
signal yourself instead of using a dialog ui delegate. There's also a 
knotifications based ui delegate, but not sure it's appropriate here (that's 
more for plasma itself I would say).
  
  
  Indeed! 'tis all very handy - and thanks :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29126

To: dfaure, ngraham, broulik, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

[David Faure]

dfaure closed this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29126

To: dfaure, ngraham, broulik, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

[David Faure]

dfaure added a comment.


  And KRun was widgets based too. At least now you can get rid of widgets 
completely (for this bit about starting apps) by connecting to the result() 
signal yourself instead of using a dialog ui delegate. There's also a 
knotifications based ui delegate, but not sure it's appropriate here (that's 
more for plasma itself I would say).

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29126

To: dfaure, ngraham, broulik, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Was /just/ about to be all "nooo, widgets in core, crying forever" but this 
isn't core, so go for it ;)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29126

To: dfaure, ngraham, broulik, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

[Alexander Lohnau]

alex marked 3 inline comments as done.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

[Alexander Lohnau]

alex updated this revision to Diff 80976.
alex added a comment.


  Use internal question system
  
  PS: I am not sure on which branch this should land,
  thats why I haven't edited the translations.

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29123?vs=80967=80976

BRANCH
  bugfix_install_uninstall_messages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29123

AFFECTED FILES
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

[David Faure]

dfaure created this revision.
dfaure added reviewers: ngraham, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The plan is to deprecate KRun::run*

TEST PLAN
  Builds

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29126

AFFECTED FILES
  src/kmoretools/kmoretoolsmenufactory.cpp

To: dfaure, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:37137cec3a92: Port KToolInvocation::kdeinitExecWait to 
QProcess (authored by broulik).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29062?vs=80785=80973

REVISION DETAIL
  https://phabricator.kde.org/D29062

AFFECTED FILES
  src/kded.cpp

To: broulik, davidedmundson, #frameworks, apol
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Chris Escargot]

saligari updated this revision to Diff 80971.
saligari added a comment.


  Changed the icon, with ndavis' help, so that it better fits its 64px place.
  
  I also tried joystick's/input gaming colors but didn't like it much, here's a 
comparison in 64px:

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=80935=80971

BRANCH
  input-mouse-patch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons/devices/64/input-mouse.svg

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

[Alexander Lohnau]

alex added a comment.


  No problem :-). And good to know that the concept of this patch makes sense 
^^.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28355: Introduce function ecm_install_configured_file

[David Edmundson]

davidedmundson added a dependent revision: D28305: Systemd Startup.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, bencreasy, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

[David Edmundson]

davidedmundson added a dependent revision: D28305: Systemd Startup.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D29035: Install service files for kwin

[David Edmundson]

davidedmundson added a dependent revision: D28305: Systemd Startup.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D29035

To: broulik, #plasma, #frameworks
Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, mkulinski, ragreen, jackyalcine, iodelay, 
crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
hardening, romangg, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29051: Add ecm_generate_dbus_service_file

[David Edmundson]

davidedmundson added a dependent revision: D28305: Systemd Startup.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D29051

To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

[Dan Leinir Turthra Jensen]

leinir added a comment.


  (and now i've done it myself, terribly sorry about that, missed the WIP at 
the start of the title! Hope some of my comments were useful, though :) )

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

[Dan Leinir Turthra Jensen]

leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.


  The reporting side of this seems based on a misunderstanding of what the 
UI-less Core is supposed to be doing... The conceptual intention in general 
isn't bad, but it needs a bit of work. Thanks for spotting it, too :)

INLINE COMMENTS

> CMakeLists.txt:71
>  KF5::CoreAddons
> +KF5::WidgetsAddons # KMessageBox error messages
>  Qt5::Xml

No, that's what the Question system is for. No widget stuff in Core, thanks :)

> installation.cpp:631
> +// can delete the files manually
> +entry.setStatus(KNS3::Entry::Installed);
> +KMessageBox::error(nullptr, err);

If you are changing the status, you need to also emit entryChanged, otherwise 
the cache will be inconsistent

> installation.cpp:632
> +entry.setStatus(KNS3::Entry::Installed);
> +KMessageBox::error(nullptr, err);
> +return;

As you are already issuing the signal with the error, intercept that instead. 
Don't spawn widgets from Core, that adds a widget dependency to the Qtquick 
module.

> installation.cpp:653
> -
> -emit signalEntryChanged(entry);
>  }

Unless you report the entry as changed, the cache will not be updated and the 
entire reporting side will fall down. Please put that line back :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.12 - Build # 94 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.12/94/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 23 Apr 2020 09:11:44 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5NetworkManagerQt-5.70.0.xmllogs/KF5NetworkManagerQt/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 37 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(6/6)53%
(164/311)53%
(164/311)58%
(8170/14175)36%
(1785/4924)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)100%
(239/239)47%
(108/232)autotests.settings100%
(37/37)100%
(37/37)99%
(1907/1915)76%
(254/336)src25%
(26/102)25%
(26/102)27%
(971/3658)21%
(379/1780)src.dbus20%
(16/80)20%
(16/80)9%
(86/920)100%
(0/0)src.fakenetwork75%
(6/8)75%
(6/8)74%
(504/677)45%
(35/78)src.settings94%
(76/81)94%
(76/81)66%
(4463/6766)40%
(1009/2498)

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.14/9/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 23 Apr 2020 09:11:44 +
 Build duration:
8 min 7 sec and counting
   BUILD ARTIFACTS
  acc/KF5NetworkManagerQt-5.70.0.xmllogs/KF5NetworkManagerQt/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 37 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(6/6)53%
(164/311)53%
(164/311)58%
(8168/14175)36%
(1784/4924)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)100%
(239/239)47%
(108/232)autotests.settings100%
(37/37)100%
(37/37)99%
(1907/1915)76%
(254/336)src25%
(26/102)25%
(26/102)26%
(969/3658)21%
(378/1780)src.dbus20%
(16/80)20%
(16/80)9%
(86/920)100%
(0/0)src.fakenetwork75%
(6/8)75%
(6/8)74%
(504/677)45%
(35/78)src.settings94%
(76/81)94%
(76/81)66%
(4463/6766)40%
(1009/2498)

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

[Alexander Lohnau]

alex created this revision.
alex added reviewers: KNewStuff, meven, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
alex requested review of this revision.

REVISION SUMMARY
  As described in the bug report the uninstallation failed, but the
  service was marked as removed. Now the service gets only marked as
  uninstalled if the script runs without an error. If there is an error
  the user gets a popup.

TEST PLAN
  Set the exit code to 1 and try to install a dolphin plugin.
  You should get an error message.
  
  Without modifying the exit code you should be able to install services.
  
  The manual deletion can be tested by removing the installed service file. for 
example:
  rm ~/.local/share/kservices5/ServiceMenus/iso_mounter_unmounter.desktop
  Then the uninstaller will crash:
  "Failed to remove .desktop file ... No such file or directory" 
  Then you delete the installed file manually:
  rm ~/.local/share/servicemenu-download/iso_mounter_unmounter.desktop
  And now you can click the uninstall button and it gets removed
  from the list of installed services.

REPOSITORY
  R304 KNewStuff

BRANCH
  bugfix_install_uninstall_messages (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29123

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/installation.cpp
  src/core/installation.h

To: alex, #knewstuff, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29121: Replace foreach with range-for

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:b53859b89a13: Replace foreach with range-for (authored by 
ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29121?vs=80963=80965

REVISION DETAIL
  https://phabricator.kde.org/D29121

AFFECTED FILES
  src/settings/ipv4setting.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29121: Replace foreach with range-for

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29121

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29121: Replace foreach with range-for

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, jgrulich.
Herald added a project: Frameworks.
Herald added 1 blocking reviewer(s): jgrulich.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  I missed one file before, now it should actually build with -DQT_NO_FOREACH.

TEST PLAN
  make && ctest

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-5 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29121

AFFECTED FILES
  src/settings/ipv4setting.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.12 - Build # 93 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.12/93/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 23 Apr 2020 08:39:10 +
 Build duration:
59 sec and counting
   CONSOLE OUTPUT
  [...truncated 456 lines...][2020-04-23T08:40:06.941Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:667:16: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:06.941Z]   667 | Q_FOREACH (const QVariantMap & addressData, setting.addressData()) {[2020-04-23T08:40:06.941Z]   |^[2020-04-23T08:40:06.941Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:674:16: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:06.941Z]   674 | Q_FOREACH (const QVariantMap & routeData, setting.routeData()) {[2020-04-23T08:40:06.941Z]   |^[2020-04-23T08:40:06.941Z] [ 25%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/connectionsettings.cpp.o[2020-04-23T08:40:06.941Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/dcbsetting.cpp.o[2020-04-23T08:40:06.941Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/gsmsetting.cpp.o[2020-04-23T08:40:06.941Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/matchsetting.cpp.o[2020-04-23T08:40:07.196Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/olpcmeshsetting.cpp.o[2020-04-23T08:40:07.196Z] make[2]: *** [src/CMakeFiles/KF5NetworkManagerQt.dir/build.make:746: src/CMakeFiles/KF5NetworkManagerQt.dir/settings/ipv4setting.cpp.o] Error 1[2020-04-23T08:40:07.196Z] make[2]: *** Waiting for unfinished jobs[2020-04-23T08:40:07.196Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/iptunnelsetting.cpp.o[2020-04-23T08:40:07.196Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/ipv4setting.cpp.o[2020-04-23T08:40:07.451Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/ipv6setting.cpp.o[2020-04-23T08:40:07.706Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/infinibandsetting.cpp.o[2020-04-23T08:40:07.964Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/macsecsetting.cpp.o[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp: In member function ���virtual void NetworkManager::Ipv4Setting::fromMap(const QVariantMap&)���:[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:382:20: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:07.964Z]   382 | Q_FOREACH (const uint utmp, temp) {[2020-04-23T08:40:07.964Z]   |^[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:382:9: error: ���Q_FOREACH��� was not declared in this scope; did you mean ���Q_FOREVER���?[2020-04-23T08:40:07.964Z]   382 | Q_FOREACH (const uint utmp, temp) {[2020-04-23T08:40:07.964Z]   | ^[2020-04-23T08:40:07.964Z]   | Q_FOREVER[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:404:20: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:07.964Z]   404 | Q_FOREACH (const QList , temp) {[2020-04-23T08:40:07.964Z]   |^[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:404:9: error: ���Q_FOREACH��� was not declared in this scope; did you mean ���Q_FOREVER���?[2020-04-23T08:40:07.964Z]   404 | Q_FOREACH (const QList , temp) {[2020-04-23T08:40:07.964Z]   | ^[2020-04-23T08:40:07.964Z]   | Q_FOREVER[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:433:20: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:07.964Z]   433 | Q_FOREACH (const QList , temp) {[2020-04-23T08:40:07.964Z]   |^[2020-04-23T08:40:07.964Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.12/src/settings/ipv4setting.cpp:433:9: error: ���Q_FOREACH��� was not declared in this scope; did you mean ���Q_FOREVER���?[2020-04-23T08:40:07.964Z]   433 | Q_FOREACH (const QList , temp) {[2020-04-23T08:40:07.964Z]   | ^[2020-04-23T08:40:07.964Z]   | Q_FOREVER[2020-04-23T08:40:07.964Z] 

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.14 - Build # 8 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.14/8/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Thu, 23 Apr 2020 08:39:16 +
 Build duration:
1 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 452 lines...][2020-04-23T08:40:17.585Z] [ 23%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/vethdevice.cpp.o[2020-04-23T08:40:17.585Z] make[2]: *** [src/CMakeFiles/KF5NetworkManagerQt_static.dir/build.make:746: src/CMakeFiles/KF5NetworkManagerQt_static.dir/settings/ipv4setting.cpp.o] Error 1[2020-04-23T08:40:17.585Z] make[2]: *** Waiting for unfinished jobs[2020-04-23T08:40:17.585Z] [ 23%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/wireguarddevice.cpp.o[2020-04-23T08:40:17.585Z] [ 23%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/adslsetting.cpp.o[2020-04-23T08:40:17.843Z] [ 24%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/bluetoothsetting.cpp.o[2020-04-23T08:40:17.843Z] [ 24%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/bondsetting.cpp.o[2020-04-23T08:40:17.843Z] [ 24%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/bridgesetting.cpp.o[2020-04-23T08:40:18.103Z] [ 24%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/bridgeportsetting.cpp.o[2020-04-23T08:40:18.671Z] [ 25%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/cdmasetting.cpp.o[2020-04-23T08:40:18.671Z] [ 25%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/connectionsettings.cpp.o[2020-04-23T08:40:19.239Z] [ 25%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/dcbsetting.cpp.o[2020-04-23T08:40:19.239Z] [ 25%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/gsmsetting.cpp.o[2020-04-23T08:40:19.239Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/iptunnelsetting.cpp.o[2020-04-23T08:40:19.239Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/ipv4setting.cpp.o[2020-04-23T08:40:19.239Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/ipv6setting.cpp.o[2020-04-23T08:40:19.497Z] [ 26%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/infinibandsetting.cpp.o[2020-04-23T08:40:19.497Z] make[1]: *** [CMakeFiles/Makefile2:2643: src/CMakeFiles/KF5NetworkManagerQt_static.dir/all] Error 2[2020-04-23T08:40:19.497Z] make[1]: *** Waiting for unfinished jobs[2020-04-23T08:40:19.497Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/macsecsetting.cpp.o[2020-04-23T08:40:19.497Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/matchsetting.cpp.o[2020-04-23T08:40:19.755Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/olpcmeshsetting.cpp.o[2020-04-23T08:40:20.321Z] [ 27%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/ovsbridgesetting.cpp.o[2020-04-23T08:40:20.321Z] [ 28%] Building CXX object src/CMakeFiles/KF5NetworkManagerQt.dir/settings/ovsinterfacesetting.cpp.o[2020-04-23T08:40:20.321Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.14/src/settings/ipv4setting.cpp: In member function ���virtual void NetworkManager::Ipv4Setting::fromMap(const QVariantMap&)���:[2020-04-23T08:40:20.321Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.14/src/settings/ipv4setting.cpp:382:20: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:20.321Z]   382 | Q_FOREACH (const uint utmp, temp) {[2020-04-23T08:40:20.322Z]   |^[2020-04-23T08:40:20.322Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.14/src/settings/ipv4setting.cpp:382:9: error: ���Q_FOREACH��� was not declared in this scope; did you mean ���Q_FOREVER���?[2020-04-23T08:40:20.322Z]   382 | Q_FOREACH (const uint utmp, temp) {[2020-04-23T08:40:20.322Z]   | ^[2020-04-23T08:40:20.322Z]   | Q_FOREVER[2020-04-23T08:40:20.322Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.14/src/settings/ipv4setting.cpp:404:20: error: expected primary-_expression_ before ���const���[2020-04-23T08:40:20.322Z]   404 | Q_FOREACH (const QList , temp) {[2020-04-23T08:40:20.322Z]   |^[2020-04-23T08:40:20.322Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.14/src/settings/ipv4setting.cpp:404:9: error: ���Q_FOREACH��� was not declared in this scope; did you mean ���Q_FOREVER���?[2020-04-23T08:40:20.322Z]   404 | Q_FOREACH (const QList , temp) {[2020-04-23T08:40:20.322Z]   | ^[2020-04-23T08:40:20.322Z]   | Q_FOREVER[2020-04-23T08:40:20.322Z] /home/jenkins/workspace/Frameworks/networkmanager-qt/kf5-qt5 SUSEQt5.14/src/settings/ipv4setting.cpp:433:20: 

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:ee827d8efba2: [NetworkManager-qt] Replace foreach with 
range for, hopefully last pass (authored by ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29093?vs=80880=80961

REVISION DETAIL
  https://phabricator.kde.org/D29093

AFFECTED FILES
  CMakeLists.txt
  examples/createconnection/main.cpp
  examples/main.cpp
  src/settings/connectionsettings.cpp
  src/settings/dcbsetting.cpp
  src/settings/security8021xsetting.cpp
  src/settings/tcsetting.cpp
  src/settings/wirelesssecuritysetting.cpp
  src/utils.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:6d7caf3468ed: [NetworkManager-qt] Replace foreach with 
range/index for loop, third pass (authored by ahmadsamir).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29091?vs=80875=80960

REVISION DETAIL
  https://phabricator.kde.org/D29091

AFFECTED FILES
  src/settings/ipv6setting.cpp
  src/settings/teamportsetting.cpp

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29093

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  l-foreach-3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29091

To: ahmadsamir, #frameworks, jgrulich
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns