D29793: Rename Perl6 syntax to Raku

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29793

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29793: Rename Perl6 syntax to Raku

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, Kate, jpoelen, 
cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In October 2019, Perl6 was renamed to "Raku".
  
  The syntax is renamed to **"Raku"**, however, I don't know if you prefer a 
name that also includes "Perl6", such as **"Raku (Perl6)"** or **"Raku/Perl6"**.
  
  I also add the new extensions and update the extension in the test file.
  
  Any inconvenience with this diff don't hesitate to notify.
  
  **Sources:**
  
  - Raku Programming Language: https://raku.org/
  - Raku Documentation: https://docs.perl6.org/
  - The Perl Foundation News. TPF response to Raku rename: 
https://news.perlfoundation.org/post/tpf-response-raku-rename
  - LWN.net. Perl 6 renamed to Raku: https://lwn.net/Articles/802329/
  
  **NOTE:** This was sent by nvisser on GitHub: 
https://github.com/KDE/syntax-highlighting/pull/24

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rename-perl6-raku

REVISION DETAIL
  https://phabricator.kde.org/D29793

AFFECTED FILES
  autotests/folding/highlight.pl6.fold
  autotests/folding/highlight.raku.fold
  autotests/html/highlight.pl6.html
  autotests/html/highlight.raku.html
  autotests/input/highlight.pl6
  autotests/input/highlight.raku
  autotests/reference/highlight.pl6.ref
  autotests/reference/highlight.raku.ref
  data/syntax/perl6.xml
  data/syntax/raku.xml

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29789: Make text always align with font base line

[Xuetian Weng]

xuetianweng added a comment.


  This is my another try as an alternative solution to D25339 
. Actually this works surprisingly good 
IMHO, at least for CJK users for most cases.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D29789

To: xuetianweng, rjvbb, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29789: Make text always align with font base line

[Xuetian Weng]

xuetianweng edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D29789

To: xuetianweng, rjvbb, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29789: Make text always align with font base line

[Xuetian Weng]

xuetianweng created this revision.
xuetianweng added reviewers: rjvbb, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
xuetianweng requested review of this revision.

REVISION SUMMARY
  When font uses other fallback font, the base line may change to make all
  text on the same baseline. But when we render the text, we should always
  follow the baseline from FontMetrics to avoid text baseline jump up and
  down depending on the text in the line.

TEST PLAN
  Text manually with some mixed text.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29789

AFFECTED FILES
  src/render/katerenderer.cpp
  src/render/katerenderer.h

To: xuetianweng, rjvbb, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: update lineHeight if boundingRect indicates a larger value.

[Xuetian Weng]

xuetianweng added a comment.


  Actually I was trying to use this approach in the patch because I was afraid 
that variable line height may need to estimate the whole document height to 
make scroll work correctly.
  
  But during this patching experience I realized that the ktexteditor first 
line is always a whole line. So the renderer only need to care about the 
current page instead of whole document, which makes variable line height might 
not as hard as thought.
  
  I won't have time recently to look into the variable line height though.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann

D29787: Fix krununittest

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  After 6452a34cf01d03d316 
, 
DesktopExecParser::resultingArguments() needs
  to find the terminal app binary, otherwise it returns an empty QStringList.

TEST PLAN
  krununittest passes again

REPOSITORY
  R241 KIO

BRANCH
  l-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29787

AFFECTED FILES
  autotests/krununittest.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

[Ahmad Samir]

ahmadsamir updated this revision to Diff 82974.
ahmadsamir retitled this revision from "[StatJob] Change mostLocalUrl to only 
handle protocols with Class=:local" to "[StatJob] Make mostLocalUrl ignore 
remote (ftp, http...etc) URLs".
ahmadsamir edited the summary of this revision.
ahmadsamir edited the test plan for this revision.
ahmadsamir added a comment.


  Improve

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29782?vs=82959=82974

BRANCH
  l-most-local-url-local (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29782

AFFECTED FILES
  src/core/statjob.cpp
  src/core/statjob.h

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

[Ahmad Samir]

ahmadsamir added a comment.


  In D29385#671987 , @dfaure wrote:
  
  > That's the point, a NFS mount *is* a local URL, so we do use QFile for it. 
And then it takes forever because the kernel has to talk over a socket to 
answer us.
  >  Yes this is horrendous. I hate network mounts :-)
  
  
  I don't have *any* network mounts, never have, so I wasn't aware of that. 
Yep, that is horrendous.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29385

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

[David Faure]

dfaure added a comment.


  That's the point, a NFS mount *is* a local URL, so we do use QFile for it. 
And then it takes forever because the kernel has to talk over a socket to 
answer us.
  Yes this is horrendous. I hate network mounts :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29385

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

[Ahmad Samir]

ahmadsamir added a comment.


  In D29385#671980 , @dfaure wrote:
  
  > It's 3 times faster on my local SSD.
  >
  > Now think of a NFS mount on a server from another country
  
  
  I was thinking mostly of QFile when url.isLocalFile() is true, but yeah I see 
your point :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29385

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

[David Faure]

dfaure added a comment.


  It's 3 times faster on my local SSD.
  
  Now think of a NFS mount on a server from another country

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29385

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in openurljob.cpp:261
> LOL we're like an old couple, the explicit discussion doesn't actually need 
> to happen anymore ;)
> 
> OK for everyone else, we're debating whether it's ok to use blocking 
> local-file I/O like QFile or QMimeDatabase which reads from the file.
> 
> Of course less code paths is a good thing for maintenance, but it seems *so* 
> overkill to make two calls to a kioslave just to find out the mimetype of a 
> file My main counter argument is performance.
> 
> For the whole OpenUrlJob until the mimetype is found:
> 
> With KIO
> 
>   RESULT : OpenUrlJobTest::takeOverAfterMimeTypeFound():
>0.29 msecs per iteration (total: 75, iterations: 256)
> 
> With the local-file optimization
> 
>   RESULT : OpenUrlJobTest::takeOverAfterMimeTypeFound():
>0.0986 msecs per iteration (total: 101, iterations: 1024)
> 
> That's 3 times faster. Admittedly this is not the kind of things people do in 
> a loop.
> 
> Well, OK, if nobody objects I can remove the local-files fast paths.
> 0.2ms is nothing when lharming 2018 PG Demi Lovato Ashley Tisdale Avril 
> Lavigne-02052020.mpgaunching an app, or even when opening a URL in a browser.
> 
> [More context: QMimeDatabase *might* determine the mimetype from just the 
> extension, in which case no I/O happens and we could do that here, or it 
> might need to look into the contents of the file. We can ask it to not do 
> that but then the mimetype determination will be less good, for some 
> mimetypes; and we can't ask it if we would get better information by looking 
> at content, so there's no way to split up the work between here and the 
> kioslave. It's "quick search" vs "full search", not phase 1, phase 2.]

> OK for everyone else, we're debating whether it's ok to use blocking 
> local-file I/O like QFile or QMimeDatabase which reads from the file.

I know this ship has sailed (well, sunk in this case :)), but if it's 3 times 
faster to use QFile, then is it really a "blocking I/O" operation? it's too 
fast to be "blocking"...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29385

To: dfaure, ahmadsamir, broulik, meven, kossebau, davidedmundson, nicolasfella, 
svuorela
Cc: feverfew, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

[Nathaniel Graham]

ngraham updated this revision to Diff 82971.
ngraham added a comment.


  Only open in System Settings or Info Center if systemsettings is installed

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29711?vs=82751=82971

BRANCH
  create-kcmshell-openSystemSettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29711

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.h

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

[Ahmad Samir]

ahmadsamir planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29782

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kossebau wrote in openurljob.h:120
> You meant, according to 
> https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members
>  :)

I got the info from a commit in kwidgetsaddons where you "fixed" a previous 
commit of mine :)

Thanks for the link though.

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> openurljob.h:119
> + * a different implementation on Windows.
> + *
> + * @param b whether to only show the "open with" dialog.

Please mention explicit what the default is (false),  to remove any ambiguity.

Some other setters might want to have this stated as well, btw.

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

[Nathaniel Graham]

ngraham added a comment.


  In D29711#671616 , @mart wrote:
  
  > hmm, should probably check before whether systemsettings5 and kinfocenter 
exist beforehand and fallback to kcmshell if not?
  
  
  Yeah Christoph and Luigi brought that up too. Will do.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in openurljob.h:120
> It seems that we shouldn't end @param with a ".", according to @kossebau 
> anyway...

You meant, according to 
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members
 :)

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

[Ahmad Samir]

ahmadsamir accepted this revision.
ahmadsamir added a subscriber: kossebau.
ahmadsamir added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> openurljob.h:120
> + *
> + * @param b whether to only show the "open with" dialog.
> + */

It seems that we shouldn't end @param with a ".", according to @kossebau 
anyway...

REPOSITORY
  R241 KIO

BRANCH
  2020_05_displayOpenWithDialog

REVISION DETAIL
  https://phabricator.kde.org/D29558

To: dfaure, ahmadsamir, broulik, svuorela
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Recent breakage in kwallet

[Roman Gilg]

On Fri, May 15, 2020 at 3:53 PM Roman Gilg  wrote:
>
> On Fri, May 15, 2020 at 12:44 PM Marco Martin  wrote:
> >
> > Hi all,
> > Recently, the package of KWallet framework for neon (devel unstable,
> > package built out of current master state) seems to be broken: kwallet
> > now can't open anymore wallets previously created (it works if the
> > local kwallet data is deleted and recreated)
> > the weird thing is that it seems that with a manual build it works instead.
>
> I build it manually and it's broken there too.
>
> > The only kinda suspicious commit is
> > 850219f83e7d746 fix compilation with -Werror=undef
> > which seems to fix.. big endian for everyone?
> > still no idea why is broken only the distro-built package
> >
> > --
> > Marco Martin
>
> Just in case you're on Neon Dev Unstable: I just realized that on one
> of the last updates the whole plasma-desktop and plasma-workspace
> packages were uninstalled from my machine and now they can't be
> installed anymore because of some conflict with libksysguard.
>
> I didn't notice it at first because I have a self-compiled version but
> it would be not far fetched that even a separate compilation of
> KWallet breaks in some ways when the Plasma installation in /usr is
> ripped out, especially when only a subset of KDE packages is compiled.
> So my plan at the moment is to wait until I can install Plasma back
> into /usr and then try again.

Package plasma-desktop can be installed again, so I did. But problem
with KWallet sadly persists.

D17816: Support for xattrs on kio copy/move

[Gleb Popov]

arrowd updated this revision to Diff 82960.
arrowd added a comment.


  I decided to help with this a bit.
  
  - Fix detection of  header. It requires  to be 
included too.
  - Implement test helpers for BSD (extattr).
  
  At the moment, some tests fail for me, because xattrs don't seem to be 
copied. I'll look into that later.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=80336=82960

BRANCH
  arcpatch-D17816

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/ioslaves/file/ConfigureChecks.cmake
  src/ioslaves/file/config-kioslave-file.h.cmake
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, sitter.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Previously mostLocalUrl would check that !url.isLocalFile(), that meant
  a statjob would be fired for remote urls, such urls will never have a
  mostLocalUrl. Instead check for protocols with Class=:local.
  
  For a list of such protocols: `grep :local /usr/share/kservices5/*.protocol`
  
  Thanks to sitter for figuring it out in the bug report.
  
  BUG: 420985
  FIXED-IN: 5.71

TEST PLAN
  make && ctest

REPOSITORY
  R241 KIO

BRANCH
  l-most-local-url-local (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29782

AFFECTED FILES
  src/core/statjob.cpp
  src/core/statjob.h

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

[Gleb Popov]

arrowd commandeered this revision.
arrowd added a reviewer: cochise.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, 
dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, 
spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Christoph Cullmann]

cullmann added a comment.


  Sure, thanks for the improvement!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f804af905ef3: Assign Identifier attribute to 
opening double quote instead of Comment (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29735?vs=82808=82955

REVISION DETAIL
  https://phabricator.kde.org/D29735

AFFECTED FILES
  data/syntax/sql-postgresql.xml

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars

D27844: Store and fetch complete view config in and from session config

[Christoph Cullmann]

cullmann added a comment.


  Hmm, right, didn't think about that :(
  Guess if we want to have this, we need to improve the read/writeConfig 
functions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29406: Add X-KDE-Original-Executable to Applications properties

[Méven Car]

meven removed a dependent revision: D29407: ScreenshotEffect: Use Service 
Property to authorize screenshot without confirmation.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29406

To: meven, #frameworks, davidedmundson, apol, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

[Méven Car]

meven added a dependent revision: D29407: ScreenshotEffect: Use Service 
Property to authorize screenshot without confirmation.

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D29774

To: meven, davidedmundson, zzag, #frameworks, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29034: Add systemd user service file for kded

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:4ae4de9ff469: Add systemd user service file for kded 
(authored by broulik).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29034?vs=82868=82949

REVISION DETAIL
  https://phabricator.kde.org/D29034

AFFECTED FILES
  src/CMakeLists.txt
  src/plasma-kded.service.in

To: broulik, #plasma, #frameworks, davidedmundson
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29034: Add systemd user service file for kded

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29034

To: broulik, #plasma, #frameworks, davidedmundson
Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in file_unix.cpp:1052
> I'm confused. We want to solve renaming 'a' to 'A' when 'A' does *not* exist.
> 
> QFile::rename will not overwrite an existing file, so it will do nothing if 
> dest exists.

const QByteArray dest1 = "/mnt/fat32/A";
  const QByteArray dest2 = "/mnt/fat32/a";
  QT_STATBUF buff_dest;
  qDebug() << QT_LSTAT(dest1, _dest);
  qDebug() << QT_LSTAT(dest2, _dest);

IIUC, from FAT32 POV, 'A' exists if 'a' exists and vice versa.

> dfaure wrote in file_unix.cpp:1074
> Wouldn't it be enough to just call QFile::rename here?
> 
> The whole idea is: if QFile::rename is able to rename a file in all cases, 
> including the a->A special case on FAT, then let's just delegate the renaming 
> to QFile.
> 
> Then we don't need to have any special case in our code.
> 
> QFile::rename does not overwrite, though, so if the dest exists and the 
> Overwrite flag is set, we might have to either delete the dest first (race 
> condition, not sure it matters here), or in *that* case use ::rename() since 
> we know it can't be a FAT32-case-change (FAT32 can't have both a and A).

Too many quirks if we don't use ::rename(). I tested with e.g. in file_unix.cpp:

  bool renamed =  QFile::rename(src, dest);
  if (!renamed) {
  if ((_flags & KIO::Overwrite) || isSrcSymLink) {
  renamed = ::rename(_src.data(), _dest.data()) == 0;
  }
  }

- QFile::rename doesn't overwrite as you said
- renaming symlinks depends on ::rename
- some unit tests are failing due to permissions

  FAIL!  : JobTest::statDetailsBasic() Compared values are not the same
 Actual   (kioItem.permissions()): 420
 Expected (438)  : 438
 Loc: [/home/ahmad/dev/kio/autotests/jobtest.cpp(1464)]
  INFO   : JobTest::statDetailsBasicSetDetails() entering
  FAIL!  : JobTest::statDetailsBasicSetDetails() Compared values are not the 
same
 Actual   (kioItem.permissions()): 420
 Expected (438)  : 438
 Loc: [/home/ahmad/dev/kio/autotests/jobtest.cpp(1503)]

That and ::rename() is used all over the place in file_unix.cpp, I am not that 
comfortable using QFile::rename except for the freaky FAT32 case :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29610

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Recent breakage in kwallet

[Roman Gilg]

On Fri, May 15, 2020 at 12:44 PM Marco Martin  wrote:
>
> Hi all,
> Recently, the package of KWallet framework for neon (devel unstable,
> package built out of current master state) seems to be broken: kwallet
> now can't open anymore wallets previously created (it works if the
> local kwallet data is deleted and recreated)
> the weird thing is that it seems that with a manual build it works instead.

I build it manually and it's broken there too.

> The only kinda suspicious commit is
> 850219f83e7d746 fix compilation with -Werror=undef
> which seems to fix.. big endian for everyone?
> still no idea why is broken only the distro-built package
>
> --
> Marco Martin

Just in case you're on Neon Dev Unstable: I just realized that on one
of the last updates the whole plasma-desktop and plasma-workspace
packages were uninstalled from my machine and now they can't be
installed anymore because of some conflict with libksysguard.

I didn't notice it at first because I have a self-compiled version but
it would be not far fetched that even a separate compilation of
KWallet breaks in some ways when the Plasma installation in /usr is
ripped out, especially when only a subset of KDE packages is compiled.
So my plan at the moment is to wait until I can install Plasma back
into /usr and then try again.

D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

[Méven Car]

meven created this revision.
meven added reviewers: davidedmundson, zzag, Frameworks, KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  This added field to Application desktop entries allows to declare an access 
request to a DBUS interface.
  
  Needed for D29407 

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29774

AFFECTED FILES
  src/services/application.desktop

To: meven, davidedmundson, zzag, #frameworks, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

[Marco Martin]

mart added a comment.


  hmm, should probably check before whether systemsettings5 and kinfocenter 
exist beforehand and fallback to kcmshell if not?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 605 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/605/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 May 2020 10:47:00 +
 Build duration:
6 min 50 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(25/36)67%
(278/414)67%
(278/414)55%
(34463/62903)39%
(17498/44568)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9111/10602)42%
(4288/10248)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8457/14375)50%
(4401/8718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
   

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 107 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/107/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 15 May 2020 10:47:00 +
 Build duration:
6 min 57 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(25/36)67%
(278/414)67%
(278/414)55%
(34447/62903)39%
(17481/44564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9111/10601)42%
(4288/10248)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8447/14374)50%
(4394/8718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4287)36%
(1300/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 115 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/115/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 15 May 2020 10:47:00 +
 Build duration:
5 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29767: CopyJob: Check if destination dir is a symlink

[Méven Car]

meven updated this revision to Diff 82920.
meven marked 3 inline comments as done.
meven added a comment.


  review feedback, cleanups

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29767?vs=82902=82920

BRANCH
  arcpatch-D29767

REVISION DETAIL
  https://phabricator.kde.org/D29767

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/copyjob.cpp

To: meven, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29767: CopyJob: Check if destination dir is a symlink

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8769b6360d87: CopyJob: Check if destination dir is a 
symlink (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29767?vs=82920=82921

REVISION DETAIL
  https://phabricator.kde.org/D29767

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/copyjob.cpp

To: meven, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Recent breakage in kwallet

[Marco Martin]

Hi all,
Recently, the package of KWallet framework for neon (devel unstable,
package built out of current master state) seems to be broken: kwallet
now can't open anymore wallets previously created (it works if the
local kwallet data is deleted and recreated)
the weird thing is that it seems that with a manual build it works instead.
The only kinda suspicious commit is
850219f83e7d746 fix compilation with -Werror=undef
which seems to fix.. big endian for everyone?
still no idea why is broken only the distro-built package

-- 
Marco Martin

Re: Request for ktexteditor patch release

[Friedrich W. H. Kossebau]

Am Freitag, 15. Mai 2020, 12:03:08 CEST schrieb David Faure:
> On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote:
> > Hi,
> > 
> > I would like to ask for a 5.70 patch release for ktexteditor, with
> > 972da14f486a83556e192d09bb18a2500728895a cherry-picked.
> > 
> > Not a crasher, but preventing the pickup of any global view setting
> > changes
> > after a kate/kdevelop session close & open cycle for existing document
> > views, which has been hit and reported by a few people already the last
> > days.
> 
> Thanks for the notification. Done:
> 
> ktexteditor v5.70.1
> 5e6ea19f95a36e21473c00a8d30cbea0f150a13f
> c7b568e75c147161992f8875fe36fb46885bccddb63c22edaf81071583f4204c 
> sources/ktexteditor-5.70.1.tar.xz

Merci.

> Please add a description of the bug in www/info/kde-frameworks-5.70.0.php
> (or give me a patch if you can't push).

No checkout of the respective repo, so possibly fastest if I give you the raw 
data here:
* KTextEditor global view setting changes ignored after session reopening 
(Kate, KDevelop)
https://bugs.kde.org/show_bug.cgi?id=421375

> Also, please make sure to write a unittest for this regression so we catch
> it next time.

Yup. 

Cheers
Friedrich

Re: Request for ktexteditor patch release

[David Faure]

On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote:
> Hi,
> 
> I would like to ask for a 5.70 patch release for ktexteditor, with
> 972da14f486a83556e192d09bb18a2500728895a cherry-picked.
> 
> Not a crasher, but preventing the pickup of any global view setting changes
> after a kate/kdevelop session close & open cycle for existing document
> views, which has been hit and reported by a few people already the last
> days.

Thanks for the notification. Done:

ktexteditor v5.70.1
5e6ea19f95a36e21473c00a8d30cbea0f150a13f
c7b568e75c147161992f8875fe36fb46885bccddb63c22edaf81071583f4204c  
sources/ktexteditor-5.70.1.tar.xz

Please add a description of the bug in www/info/kde-frameworks-5.70.0.php (or 
give me a patch if you can't push).

Also, please make sure to write a unittest for this regression so we catch it 
next time.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/14/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 15 May 2020 08:48:41 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.71.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(260/298)87%
(260/298)67%
(33009/49189)49%
(14804/30094)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4791/5129)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5526/5568)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1082/1472)src.completion100%
(11/11)100%
(11/11)57%
(1785/3131)42%
(1008/2423)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/855)0%
(0/180)src.document100%
(4/4)100%
(4/4)61%
(1937/3176)48%
(1419/2977)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor93%
(14/15)93%
(14/15)84%
(187/222)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1050)16%
(146/897)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(7/7)100%
(7/7)77%
(947/1224)67%
(612/916)src.schema29%
(2/7)29%
(2/7)1%
(19/1468)1%
(6/625)src.script100%
(16/16)100%
(16/16)68%
(706/1038)54%

Request for ktexteditor patch release

[Friedrich W. H. Kossebau]

Hi,

I would like to ask for a 5.70 patch release for ktexteditor, with 
972da14f486a83556e192d09bb18a2500728895a cherry-picked.

Not a crasher, but preventing the pickup of any global view setting changes 
after a kate/kdevelop session close & open cycle for existing document views, 
which has been hit and reported by a few people already the last days.

Cheers
Friedrich

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.14 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.14/15/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 15 May 2020 08:48:41 +
 Build duration:
7 min 58 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:a3148c470784: Add 48px places icons (authored by 
manueljlin).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29739?vs=82904=82910

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/index.theme
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  icons/places/48/folder-templates.svg
  icons/places/48/folder-text.svg
  icons/places/48/folder-txt.svg
  icons/places/48/folder-unlocked.svg
  

D27844: Store and fetch complete view config in and from session config

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D27844#671380 , @dhaumann wrote:
  
  > I suggest to revert, and send a notification with the change to 
kde-distro-packa...@kde.org to avoid that many users break their configuration.
  
  
  Okay, doing now.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D29739: Add 48px places icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Manuel Jesús de la Fuente]

manueljlin updated this revision to Diff 82904.
manueljlin added a comment.


  Changed folder-documents, folder-networks, folder-script, user-desktop.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29739?vs=82873=82904

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/places/48/certificate-server.svg
  icons-dark/places/48/desktop.svg
  icons-dark/places/48/favorites.svg
  icons-dark/places/48/folder-activities.svg
  icons-dark/places/48/folder-black.svg
  icons-dark/places/48/folder-blue.svg
  icons-dark/places/48/folder-bookmark.svg
  icons-dark/places/48/folder-brown.svg
  icons-dark/places/48/folder-cloud.svg
  icons-dark/places/48/folder-cyan.svg
  icons-dark/places/48/folder-decrypted.svg
  icons-dark/places/48/folder-development.svg
  icons-dark/places/48/folder-documents.svg
  icons-dark/places/48/folder-download.svg
  icons-dark/places/48/folder-downloads.svg
  icons-dark/places/48/folder-dropbox.svg
  icons-dark/places/48/folder-encrypted.svg
  icons-dark/places/48/folder-favorites.svg
  icons-dark/places/48/folder-games.svg
  icons-dark/places/48/folder-gdrive.svg
  icons-dark/places/48/folder-green.svg
  icons-dark/places/48/folder-grey.svg
  icons-dark/places/48/folder-html.svg
  icons-dark/places/48/folder-image-people.svg
  icons-dark/places/48/folder-image.svg
  icons-dark/places/48/folder-images.svg
  icons-dark/places/48/folder-important.svg
  icons-dark/places/48/folder-locked.svg
  icons-dark/places/48/folder-magenta.svg
  icons-dark/places/48/folder-mail.svg
  icons-dark/places/48/folder-music.svg
  icons-dark/places/48/folder-network.svg
  icons-dark/places/48/folder-onedrive.svg
  icons-dark/places/48/folder-open.svg
  icons-dark/places/48/folder-orange.svg
  icons-dark/places/48/folder-owncloud.svg
  icons-dark/places/48/folder-picture.svg
  icons-dark/places/48/folder-pictures.svg
  icons-dark/places/48/folder-print.svg
  icons-dark/places/48/folder-public.svg
  icons-dark/places/48/folder-publicshare.svg
  icons-dark/places/48/folder-recent.svg
  icons-dark/places/48/folder-red.svg
  icons-dark/places/48/folder-remote.svg
  icons-dark/places/48/folder-root.svg
  icons-dark/places/48/folder-script.svg
  icons-dark/places/48/folder-sound.svg
  icons-dark/places/48/folder-tar.svg
  icons-dark/places/48/folder-temp.svg
  icons-dark/places/48/folder-templates.svg
  icons-dark/places/48/folder-text.svg
  icons-dark/places/48/folder-txt.svg
  icons-dark/places/48/folder-unlocked.svg
  icons-dark/places/48/folder-video.svg
  icons-dark/places/48/folder-videos.svg
  icons-dark/places/48/folder-violet.svg
  icons-dark/places/48/folder-yellow.svg
  icons-dark/places/48/folder.svg
  icons-dark/places/48/folder_html.svg
  icons-dark/places/48/library-music.svg
  icons-dark/places/48/network-server.svg
  icons-dark/places/48/network-workgroup.svg
  icons-dark/places/48/stock_folder.svg
  icons-dark/places/48/user-desktop.svg
  icons-dark/places/48/user-home.svg
  icons/index.theme
  icons/places/48/certificate-server.svg
  icons/places/48/desktop.svg
  icons/places/48/favorites.svg
  icons/places/48/folder-activities.svg
  icons/places/48/folder-black.svg
  icons/places/48/folder-blue.svg
  icons/places/48/folder-bookmark.svg
  icons/places/48/folder-brown.svg
  icons/places/48/folder-cloud.svg
  icons/places/48/folder-cyan.svg
  icons/places/48/folder-decrypted.svg
  icons/places/48/folder-development.svg
  icons/places/48/folder-documents.svg
  icons/places/48/folder-download.svg
  icons/places/48/folder-downloads.svg
  icons/places/48/folder-dropbox.svg
  icons/places/48/folder-encrypted.svg
  icons/places/48/folder-favorites.svg
  icons/places/48/folder-games.svg
  icons/places/48/folder-gdrive.svg
  icons/places/48/folder-green.svg
  icons/places/48/folder-grey.svg
  icons/places/48/folder-html.svg
  icons/places/48/folder-image-people.svg
  icons/places/48/folder-image.svg
  icons/places/48/folder-images.svg
  icons/places/48/folder-important.svg
  icons/places/48/folder-locked.svg
  icons/places/48/folder-magenta.svg
  icons/places/48/folder-mail.svg
  icons/places/48/folder-music.svg
  icons/places/48/folder-network.svg
  icons/places/48/folder-onedrive.svg
  icons/places/48/folder-open.svg
  icons/places/48/folder-orange.svg
  icons/places/48/folder-owncloud.svg
  icons/places/48/folder-picture.svg
  icons/places/48/folder-pictures.svg
  icons/places/48/folder-print.svg
  icons/places/48/folder-public.svg
  icons/places/48/folder-publicshare.svg
  icons/places/48/folder-recent.svg
  icons/places/48/folder-red.svg
  icons/places/48/folder-remote.svg
  icons/places/48/folder-root.svg
  icons/places/48/folder-script.svg
  icons/places/48/folder-sound.svg
  icons/places/48/folder-tar.svg
  icons/places/48/folder-temp.svg
  icons/places/48/folder-templates.svg
  icons/places/48/folder-text.svg
  icons/places/48/folder-txt.svg
  

D29743: sftp: map sftp_open error to kio error

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:07e44cb1b536: sftp: map sftp_open error to kio error 
(authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29743?vs=82835=82903

REVISION DETAIL
  https://phabricator.kde.org/D29743

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, feverfew
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov

D29767: CopyJob: Check if destination dir is a symlink

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks for the quick fix and for the test! Just minor issues in comments, 
feel free to push after fixing.

INLINE COMMENTS

> jobtest.cpp:626
> +// just the same as copyDirectoryToSamePartition, but this time dest is 
> a symlink.
> +// So we get a file in the symblink dir, 
> "dirFromHome_symlink/dirFromHome" and
> +// "dirFromHome_symOrigin/dirFromHome"

Typo: symblink

> jobtest.cpp:633
> +createTestDirectory(origSymlink);
> +//createTestSymlink(origSymlink, targetSymlink.toLatin1());
> +

remove

> jobtest.cpp:648
> +
> +// file is visible in both symlinks ends
> +QVERIFY(QFileInfo(origSymlink + "/dirFromHome").isDir());;

there is only one symlink ;-)

Maybe "The file is visible in both places, due to the symlink" ?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29767

To: meven, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 604 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/604/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 May 2020 07:02:12 +
 Build duration:
6 min 9 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(25/36)67%
(278/414)67%
(278/414)55%
(34442/62884)39%
(17486/44550)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9095/10584)42%
(4281/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8457/14375)50%
(4400/8718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/106/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 15 May 2020 07:02:12 +
 Build duration:
6 min 25 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.71.0.xmllogs/KF5KIO/5.71.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report69%
(25/36)67%
(278/414)67%
(278/414)55%
(3/62885)39%
(17488/44546)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests97%
(57/59)97%
(57/59)86%
(9095/10583)42%
(4281/10230)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core89%
(103/116)89%
(103/116)59%
(8457/14375)50%
(4402/8718)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui88%
(7/8)88%
(7/8)77%
(624/809)61%
(374/614)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(714/1289)41%
(424/1040)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(653/1375)37%
(531/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 114 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/114/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 15 May 2020 07:02:12 +
 Build duration:
5 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiogui_applicationlauncherjobtestFailed: projectroot.autotests.kiowidgets_clipboardupdatertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_krununittestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D29767: CopyJob: Check if destination dir is a symlink

[Méven Car]

meven updated this revision to Diff 82902.
meven added a comment.


  Remove unrelated change

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29767?vs=82901=82902

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29767

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/copyjob.cpp

To: meven, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

[Méven Car]

meven added a comment.


  Fix at D29767 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28902

To: dfaure, meven
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29767: CopyJob: Check if destination dir is a symlink

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, dfaure, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 421213
  FIXED-IN: 5.71

TEST PLAN
  ctest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29767

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/copyjob.cpp
  src/core/kioglobal_p.h

To: meven, #frameworks, dfaure, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns