D29397: KPreviewJob : Support for DeviceRatioPixel
ngraham added a comment. The proposed additions to the spec are non-controversial IMO. Let's push that forward. I left a supportive comment in the email thread, so maybe it's time to put together a patch that people can comment on. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set
wrobelda added a comment. @cullmann I will do my best to try and test it with KMyMoney this coming weekend. I'll keep you posted. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: wrobelda, davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
KDE CI: Frameworks » kcrash » kf5-qt5 FreeBSDQt5.14 - Build # 18 - Still Failing!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/18/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Mon, 08 Jun 2020 17:35:49 +
Build duration:
36 min and counting
CONSOLE OUTPUT
[...truncated 192 lines...][2020-06-08T18:12:28.009Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2020-06-08T18:12:28.009Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2020-06-08T18:12:28.009Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2020-06-08T18:12:28.267Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2020-06-08T18:12:28.267Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2020-06-08T18:12:28.267Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2020-06-08T18:12:28.267Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components: doxygen dot [2020-06-08T18:12:28.267Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2020-06-08T18:12:28.267Z] -- The following features have been enabled:[2020-06-08T18:12:28.267Z] [2020-06-08T18:12:28.267Z] * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2020-06-08T18:12:28.267Z] * Core Pattern Raising, Raising signals to kernel core patterns (iff the pattern is a process). You may wish to not install drkonqi if this can cause a UI conflict. [2020-06-08T18:12:28.267Z] [2020-06-08T18:12:28.267Z] -- The following OPTIONAL packages have been found:[2020-06-08T18:12:28.267Z] [2020-06-08T18:12:28.267Z] * X11[2020-06-08T18:12:28.267Z] [2020-06-08T18:12:28.267Z] -- The following REQUIRED packages have been found:[2020-06-08T18:12:28.267Z] [2020-06-08T18:12:28.267Z] * ECM (required version >= 5.71.0), Extra CMake Modules., [2020-06-08T18:12:28.267Z] * Qt5 (required version >= 5.12.0)[2020-06-08T18:12:28.267Z] * KF5CoreAddons (required version >= 5.71.0)[2020-06-08T18:12:28.267Z] * Qt5Gui (required version >= 5.14.2)[2020-06-08T18:12:28.268Z] * KF5WindowSystem (required version >= 5.71.0)[2020-06-08T18:12:28.268Z] * Qt5X11Extras (required version >= 5.12.0)[2020-06-08T18:12:28.268Z] * Doxygen (required version >= 1.8.13)[2020-06-08T18:12:28.268Z]Needed for API dox QCH file generation[2020-06-08T18:12:28.268Z] * QHelpGenerator, Part of Qt5 tools[2020-06-08T18:12:28.268Z]Needed for API dox QCH file generation[2020-06-08T18:12:28.268Z] * Qt5Core[2020-06-08T18:12:28.268Z] * Qt5Widgets (required version >= 5.12.0)[2020-06-08T18:12:28.268Z] [2020-06-08T18:12:28.268Z] -- Configuring done[2020-06-08T18:12:28.524Z] -- Generating done[2020-06-08T18:12:28.524Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kcrash/kf5-qt5 FreeBSDQt5.14/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-06-08T18:12:29.516Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcrash --branchGroup kf5-qt5 --platform FreeBSDQt5.14 --usingInstall /home/jenkins/install-prefix/[2020-06-08T18:12:29.516Z] Scanning dependencies of target Qt5Core_QCH[2020-06-08T18:12:29.516Z] Scanning dependencies of target coreconfigtest_autogen[2020-06-08T18:12:29.516Z] Scanning dependencies of target KF5Crash_autogen[2020-06-08T18:12:29.516Z] [ 0%] Built target Qt5Core_QCH[2020-06-08T18:12:29.516Z] [ 5%] Automatic MOC for target KF5Crash[2020-06-08T18:12:29.516Z] [ 11%] Automatic MOC for target coreconfigtest[2020-06-08T18:12:29.516Z] Scanning dependencies of target KF5Crash_QCH[2020-06-08T18:12:29.516Z] [ 16%] Generating src/KF5Crash.qch, src/KF5Crash.tags[2020-06-08T18:12:29.516Z] [ 16%] Built target KF5Crash_autogen[2020-06-08T18:12:29.780Z] Scanning dependencies of target KF5Crash[2020-06-08T18:12:29.780Z] [ 22%] Building CXX object src/CMakeFiles/KF5Crash.dir/KF5Crash_autogen/mocs_compilation.cpp.o[2020-06-08T18:12:29.780Z] [ 27%] Building CXX object src/CMakeFiles/KF5Crash.dir/coreconfig.cpp.o[2020-06-08T18:12:29.780Z] [ 33%] Building CXX object src/CMakeFiles/KF5Crash.dir/kcrash.cpp.o[2020-06-08T18:12:30.037Z] [ 33%] Built target coreconfigtest_autogen[2020-06-08T18:12:30.295Z] Scanning dependencies of target coreconfigtest[2020-06-08T18:12:30.295Z] [ 38%] Building CXX object autotests/CMakeFiles/coreconfigtest.dir/coreconfigtest.cpp.o[2020-06-08T18:12:30.295Z] [ 44%] Building CXX object autotests/CMakeFiles/coreconfigtest.dir/coreconfigtest_autogen/mocs_compilation.cpp.o[2020-06-08T18:12:30.295Z] Building up file structure...[2020-06-08T18:12:30.295Z] Insert custom filters...[2020-06-08T18:12:30.295Z] Insert help data for filter section (1 of 1)...[2020-06-08T18:12:30.295Z] Insert files...[2020-06-08T18:12:30.295Z] Insert contents...[2020-06-08T18:12:30.295Z] Insert indices...[2020-06-08T18:12:30.295Z] Documentation successfully generated.[2020-06-08T18:12:30.295Z] [ 44%] Built target KF5Crash_QCH[2020-06-08T18:12:30.886Z]
KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.14 - Build # 18 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.14/18/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 08 Jun 2020 17:37:22 + Build duration: 20 min and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5FileMetaData-5.71.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.71.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.embeddedimagedatatestFailed: projectroot.autotests.extractorcoveragetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report80% (4/5)97% (60/62)97% (60/62)87% (4158/4799)48% (5742/11880)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (19/19)100% (19/19)98% (1520/1549)49% (2978/6065)src96% (27/28)96% (27/28)82% (1466/1778)47% (651/1378)src.extractors100% (13/13)100% (13/13)78% (964/1236)46% (1709/3682)src.writers100% (1/1)100% (1/1)99% (208/210)54% (404/749)tests0% (0/1)0% (0/1)0% (0/26)0% (0/6)
KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 183 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/183/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Jun 2020 17:37:21 + Build duration: 3 min 34 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5FileMetaData-5.71.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.71.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.embeddedimagedatatestFailed: projectroot.autotests.extractorcoveragetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report80% (4/5)97% (60/62)97% (60/62)87% (4156/4797)48% (5738/11872)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (19/19)100% (19/19)98% (1518/1547)49% (2976/6061)src96% (27/28)96% (27/28)82% (1466/1778)47% (651/1378)src.extractors100% (13/13)100% (13/13)78% (964/1236)46% (1707/3678)src.writers100% (1/1)100% (1/1)99% (208/210)54% (404/749)tests0% (0/1)0% (0/1)0% (0/26)0% (0/6)
D27223: add kirigami-gallery icon
ndavis added a comment. I think I'd prefer to keep this similar to the original Kirigami icon. Do you mind if I commandeer this? I've already made the changes. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D27223: add kirigami-gallery icon
ndavis added a comment. I noticed that the lighting in this version of the Kirigami is flipped. Is that intentional? I don't think it makes sense for the top of the K popout to be darker than the bottom. Since the light in Breeze icons comes from the top left, the top should be light, like in the original Kirigami icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D27223: add kirigami-gallery icon
mbruchert added a comment. I believe everything should be fixed now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D27223: add kirigami-gallery icon
mbruchert updated this revision to Diff 83252. mbruchert added a comment. - fix color REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=83251=83252 BRANCH kirigami_galery (branched from master) REVISION DETAIL https://phabricator.kde.org/D27223 AFFECTED FILES icons-dark/apps/48/kirigami-gallery.svg icons/apps/48/kirigami-gallery.svg To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D27223: add kirigami-gallery icon
mbruchert updated this revision to Diff 83251. mbruchert added a comment. - align pixel grid - fix typo - fix overlapping bug REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27223?vs=75859=83251 BRANCH kirigami_galery (branched from master) REVISION DETAIL https://phabricator.kde.org/D27223 AFFECTED FILES icons-dark/apps/48/kirigami-gallery.svg icons/apps/48/kirigami-gallery.svg To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D28355: Introduce function ecm_install_configured_file
davidedmundson added a comment. Moved to invent. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson, #build_system Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns
D28355: Introduce function ecm_install_configured_file
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:2976b27a6c0b: Introduce function ecm_install_configured_file (authored by davidedmundson). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28355?vs=79176=83249 REVISION DETAIL https://phabricator.kde.org/D28355 AFFECTED FILES docs/module/ECMConfiguredInstall.rst modules/ECMConfiguredInstall.cmake tests/CMakeLists.txt tests/ECMConfiguredInstallTest/CMakeLists.txt tests/ECMConfiguredInstallTest/check_tree.cmake.in tests/ECMConfiguredInstallTest/configured.txt tests/ECMConfiguredInstallTest/configured_atOnly.txt.in tests/ECMConfiguredInstallTest/expected/configured.txt tests/ECMConfiguredInstallTest/expected/configured_atOnly.txt tests/ECMConfiguredInstallTest/expected/multi1.txt tests/ECMConfiguredInstallTest/expected/multi2.txt tests/ECMConfiguredInstallTest/multi1.txt.in tests/ECMConfiguredInstallTest/multi2.txt.in To: davidedmundson, #build_system Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns
D27223: add kirigami-gallery icon
mart added a comment. can we fix this and go ahead? @mbruchert can you still work on it? want to put it on invent? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27223 To: mbruchert, mart, #vdg, ndavis, ngraham Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set
cullmann added a comment. That depends. If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l Cc: wrobelda, davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.12 - Build # 97 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/97/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 08 Jun 2020 08:30:51 + Build duration: 2 min 44 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5I18n-5.71.0.xmlcompat_reports/KF5I18n_compat_report.htmllogs/KF5I18n/5.71.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)100% (17/17)100% (17/17)68% (2040/3022)48% (920/1929)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (5/5)100% (5/5)92% (424/461)52% (196/376)src100% (12/12)100% (12/12)63% (1616/2561)47% (724/1553)
KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.14 - Build # 14 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.14/14/ Project: kf5-qt5 SUSEQt5.14 Date of build: Mon, 08 Jun 2020 08:30:51 + Build duration: 1 min 41 sec and counting BUILD ARTIFACTS abi-compatibility-results.yamlacc/KF5I18n-5.71.0.xmlcompat_reports/KF5I18n_compat_report.htmllogs/KF5I18n/5.71.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (2/2)100% (17/17)100% (17/17)67% (2039/3022)48% (917/1929)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (5/5)100% (5/5)92% (424/461)52% (196/376)src100% (12/12)100% (12/12)63% (1615/2561)46% (721/1553)
KDE CI: Frameworks » ki18n » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Mon, 08 Jun 2020 08:30:51 + Build duration: 43 sec and counting JUnit Tests Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi
davidre added a comment. Ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29463 To: Zren, #kirigami, mart Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
