D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  You're completely right in the sense that for a batch rename files will be in 
the same folder. However, rename really is just a move operation. The current 
BatchRenameJob has a hardcoded logic about placeholders and extensions which 
make it unusable outside of its current scope.
  
  The proposed BatchMoveJob does exactly that: Move these files from here to 
there, no questions asked and without any manipulation of the file names.
  
  In the context of this job it Wil be used to rename files, but as a patch it 
is completely independent of this. Applications such as Dolphin or Krusader for 
example, can also use it to do their batch moves instead of implementing it 
themselves with multiple subjobs etc.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: luco, nicopons, meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, 
dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Luca Errani]

luco added a comment.


  @emateli Thank you for your response, I saw that patch and I sincerely don't 
understand the reason why you're writing a completely different job 
(`BatchMoveJob`) when the required operation is exactly a `BatchRenameJob`. 
  I'm asking this because I've never used a "batch rename" feature to move 
files to a different folder, I always used that to rename multiple files with a 
regex pattern or a numbering sequence instead, but maybe it's just me.
  
  Do you think an initial implementation of your GUI with the standard 
`BatchRenameJob` could work? What problems could appear? I see the usefulness 
of the `BatchMoveJob`, but I can't see how is that related to this patch!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: luco, nicopons, meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, 
dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli added a comment.


  I honestly think the GUI is mostly ready, at least what I wanted to achieve 
with it: Something that is advanced enough but not over the top with options as 
there's already tools for that. Will check at some point to finish the items 
left from the review here. What this needs to be fully implemented is support 
from KIO for a "proper" batch move operation. I've submitted a patch for that 
at D27760  but am still waiting for a 
review.
  
  I'm completely open to new ideas though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: luco, nicopons, meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, 
dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Luca Errani]

luco added a comment.


  @emateli Are you still working on this? I'd love to see this feature 
implemented, I wanted to start by myself then on the Matrix Dolphin channel 
they suggested seeing this patch and it's awesome! Could you use some help?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent, meven, #dolphin
Cc: luco, nicopons, meven, anthonyfieroni, chinmoyr, mlaurent, asensi, rkflx, 
dfaure, aacid, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/4/
 Project:
kf5-qt5 SUSEQt5.15
 Date of build:
Sun, 05 Jul 2020 13:40:03 +
 Build duration:
7 min 46 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.72.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.72.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testAdaFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)85%
(262/307)85%
(262/307)67%
(33050/49269)49%
(14779/30050)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src97%
(37/38)97%
(37/38)93%
(4798/5140)49%
(1812/3680)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5528/5570)58%
(984/1708)src.buffer88%
(15/17)88%
(15/17)89%
(1677/1892)74%
(1078/1464)src.completion100%
(11/11)100%
(11/11)57%
(1788/3134)42%
(1009/2425)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(182/457)21%
(73/340)src.dialogs0%
(0/4)0%
(0/4)0%
(0/864)0%
(0/184)src.document100%
(4/4)100%
(4/4)61%
(1936/3179)48%
(1407/2945)src.export0%
(0/4)0%
(0/4)0%
(0/121)0%
(0/156)src.include.ktexteditor78%
(14/18)78%
(14/18)83%
(189/227)55%
(125/226)src.inputmode100%
(8/8)100%
(8/8)63%
(192/304)51%
(39/77)src.mode88%
(7/8)88%
(7/8)36%
(378/1051)16%
(146/891)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/862)0%
(0/278)src.render100%
(8/8)100%
(8/8)77%
(950/1227)67%
(610/914)src.schema22%
(2/9)22%
(2/9)1%
(19/1472)1%
(6/625)src.script94%
(16/17)94%
(16/17)67%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/4/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sun, 05 Jul 2020 13:40:03 +
 Build duration:
5 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.bug313759Failed: projectroot.autotests.kateindenttest_testCstyleFailed: projectroot.autotests.kateindenttest_testPascalName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)