D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.


  Thanks :-)

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 83348.
nicolasfella added a comment.


  - Use menus font metric

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26448?vs=83346=83348

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

AFFECTED FILES
  src/CMakeLists.txt
  src/krecentfilesmenu.cpp
  src/krecentfilesmenu.h

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 99 - Fixed!

2020-08-13 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/99/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Thu, 13 Aug 2020 10:46:45 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 55 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 98 - Unstable!

2020-08-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/98/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Thu, 13 Aug 2020 10:24:57 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 55 test(s)Failed: projectroot.autotests.kiogui_openurljobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kparts » kf5-qt5 WindowsMSVCQt5.14 - Build # 57 - Unstable!

2020-08-13 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20WindowsMSVCQt5.14/57/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Thu, 13 Aug 2020 10:03:45 +
 Build duration:
2 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.openorsavequestion_unittest

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> krecentfilesmenu.cpp:74
> +{
> +action = new QAction(titleWithSensibleWidth(qobject_cast *>(menu->parent(;
> +QObject::connect(action, ::triggered, action, [this, menu]() 
> {

QMenu is a QWidget. Why not just pass `menu` as argument?
It would use the menu's font which is more correct than the parent widget's 
font (the menu font could be set by a stylesheet or by 
`QApplication::setFont(font, "QMenu")`.

Also `menu` is never null, which simplifies the code in the method being called.

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, ngraham, bruns