D23694: Add support for sshfs to the fstab backend

2020-10-18 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  In D23694#676610 , @lbeltrame 
wrote:
  
  > @elvisangelaccio Thanks, first of all. If that's the case, do you think 
it's better to touch KIO first before landing this?
  
  
  Yeah this should probably wait for the KIO patch, which I just submitted: 
https://invent.kde.org/frameworks/kio/-/merge_requests/175

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D23694

To: lbeltrame, bruns, broulik, fvogt, #kde_connect
Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 247 - Fixed!

2020-10-18 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/247/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sun, 18 Oct 2020 21:49:21 +
 Build duration:
5 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-18 Thread David Faure 
On mardi 6 octobre 2020 11:59:34 CEST Ben Cooksley wrote:
> Hi all,
> 
> This evening i've completed updates to the Windows CI system, bringing it
> from the previous Qt 5.14 setup it was using up to the more recent Qt 5.15.
> As part of this various other libraries will have also been updated.
> 
> This update was prompted by an unannounced dependency change within Breeze
> Icons. As a reminder to all developers, it is imperative that any change to
> your dependencies on a non-KDE project be announced two weeks or more in
> advance.
> 
> Unfortunately due to regressions within Breeze Icons, it is not possible
> for the Dependency Builds to complete at this time, meaning Windows CI
> functionality will be generally unavailable until this is corrected.
> 
> The failure log can be found at
> https://build.kde.org/job/Administration/job/Dependency%20Build%20Extragear%
> 20stable-kf5-qt5%20WindowsMSVCQt5.15/lastFailedBuild/console

That looks like the usual java timeout

I re-ran the exact same job and it passed.

Can you re-enable normal CI service for Windows?
I noticed e.g. that KIO tests were not run anymore...

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D22764: Stabilize test KFileWidgetTest::testDropFile

2020-10-18 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> kfilewidgettest.cpp:481
> +KDirLister *dirLister = fileWidget.dirOperator()->dirLister();
> +QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url)));
> +

For the record, this is broken, it should have been `completed(QUrl)`. 
Specifying argument names is incorrect in SIGNAL() and SLOT() macros.

It makes the wait() below fail every time, but after 5s, so the 100ms became 5s 
:-)

I'm working on fixing this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22764

To: meven, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 246 - Unstable!

2020-10-18 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/246/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sun, 18 Oct 2020 20:24:00 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.applicationlauncherjob_forkingtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 245 - Fixed!

2020-10-18 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/245/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sun, 18 Oct 2020 18:46:27 +
 Build duration:
5 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 58 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 244 - Unstable!

2020-10-18 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/244/
 Project:
kf5-qt5 FreeBSDQt5.15
 Date of build:
Sun, 18 Oct 2020 18:34:35 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: projectroot.autotests.applicationlauncherjob_servicetestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D17816: Support for xattrs on kio copy/move

2020-10-18 Thread Nathaniel Graham 
ngraham added a comment.


  @bruns?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham 
ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, 
sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, 
fprice, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, feverfew, 
trickyricky26, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, that's weird. Let's throw it on the pile.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, 
sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, 
fprice, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, feverfew, 
trickyricky26, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Ahmad Samir 
ahmadsamir added subscribers: sitter, ahmadsamir.
ahmadsamir added a comment.


  ATM, the behaviour is that if you go to /foo/bar/baz/ and "bar" is present in 
the places panel, then while you're at baz or any of its sub-folders then "bar" 
is highlighted in the places panel, i.e the "closest" bookmark is highlighted. 
There is a bug report about changing the behaviour to only highlight the 
"current" folder if it's in the panel.
  
  Posting here to start discussing the issue.
  
  https://bugs.kde.org/show_bug.cgi?id=156678

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham, ahmadsamir
Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, 
sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, 
fprice, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, feverfew, 
trickyricky26, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham 
ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, 
nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, fprice, cblack, 
konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, meven, crozbo, 
spoorun, ndavis, navarromorales, firef, andrebarros, skadinna, emmanuelp, 
rdieter, mikesomov, aaronhoneycutt, mbohlender

D28745: Skip caching thumbnails on encrypted filesystems

2020-10-18 Thread Marcin Gurtowski 
marcingu added a comment.


  I think I have the Solid part done, but as I don't know this code well, I'd 
be grateful if someone more advanced on the subject checked it.
  
  https://invent.kde.org/frameworks/solid/-/merge_requests/19
  
  Unfortunately, I wasn't able to test it on LUKS device, because I had 
problems mounting it.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: sitter, dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, 
kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov