Re: Including instead of , does it upset POSIX?
On 15/04/2021 00:16, Albert Astals Cid wrote: [...] karchive/autotests/karchivetest.cpp:28:#include karchive/src/karchive.cpp:23:#include I changed those and it compiles just fine here. kdesu/src/kdesu_stub.c:31:#include (this is C code (guessing since I don't know C), so it makes sense to leave that one in) Yes, this is not C++ kholidays/src/parsers/plan2/holidayscannerplan.cpp:1313:# include kholidays/src/parsers/plan2/holidayscannerplan.lpp:17:# include This works too kinit/src/kdeinit/kinit.cpp:24:#include kinit/src/kdeinit/kinit_mac.mm:25:#include kinit/src/kdeinit/kinit_win.cpp:15:#include kinit/src/klauncher/klauncher.cpp:21:#include kinit/src/start_kdeinit/start_kdeinit.c:12:#include kinit/src/wrapper.cpp:23:#include Same (obviously excluding start_kdeinit.c) ktexteditor/src/buffer/katesecuretextbuffer.cpp:12:#include ktexteditor/src/buffer/katetextbuffer.cpp:20:#include Same. Maybe your problem was that you tried to change C files? I'll try again, maybe there is/was something in my build environment... no idea what though. :) There was only a couple of .c files (I remember kdesu); but ktexteditor doesn't have an .c files. Thanks for re-checking. Cheers, Albert -- Ahmad Samir
Re: Including instead of , does it upset POSIX?
On 14/04/2021 22:20, Albert Astals Cid wrote: El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va escriure: Hello :) A week or so ago I created an MR to include instead of in KIO[1]. From /usr/include/c++/10/cerrno: /** @file cerrno * This is a Standard C++ Library file. You should @c \#include this file * in your programs, rather than any of the @a *.h implementation files. * * This is the C++ version of the Standard C Library header @c errno.h, * and its contents are (mostly) the same as that header, but are all * contained in the namespace @c std (except for names which are defined * as macros in C). */ And then I made similar commits to a lot of the other Frameworks (not all, since the build failed for some of them, so I left them alone). I honestly didn't think this would be a problem, but you say the build of some of them failed, so i guess it is :D Could you link to the particular MR's that failed? I created one MR for KIO, once that was reviewed, I then applied similar patches to the other Frameworks directly. Fortunately, it's easy to find which ones weren't changed, grep/rg; (I excluded frameworks that are going to be deprecated, kdelibs4support and kjs): karchive/autotests/karchivetest.cpp:28:#include karchive/src/karchive.cpp:23:#include kdesu/src/kdesu_stub.c:31:#include (this is C code (guessing since I don't know C), so it makes sense to leave that one in) kholidays/src/parsers/plan2/holidayscannerplan.cpp:1313:# include kholidays/src/parsers/plan2/holidayscannerplan.lpp:17:# include kinit/src/kdeinit/kinit.cpp:24:#include kinit/src/kdeinit/kinit_mac.mm:25:#include kinit/src/kdeinit/kinit_win.cpp:15:#include kinit/src/klauncher/klauncher.cpp:21:#include kinit/src/start_kdeinit/start_kdeinit.c:12:#include kinit/src/wrapper.cpp:23:#include ktexteditor/src/buffer/katesecuretextbuffer.cpp:12:#include ktexteditor/src/buffer/katetextbuffer.cpp:20:#include Cheers, Albert -- Ahmad Samir
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 702 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/702/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 15 Apr 2021 11:05:58 + Build duration: 9 min 9 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: projectroot.autotests.kiogui_openurljobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.15 - Build # 703 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/703/ Project: kf5-qt5 SUSEQt5.15 Date of build: Thu, 15 Apr 2021 11:01:12 + Build duration: 12 min and counting BUILD ARTIFACTS acc/KF5KIO-5.82.0.xmllogs/KF5KIO/5.82.0/log.txt JUnit Tests Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 57 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report68% (25/37)68% (291/428)68% (291/428)57% (37107/65271)41% (19282/47067)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests95% (59/62)95% (59/62)91% (10586/11642)45% (5414/12148)autotests.http100% (5/5)100% (5/5)99% (503/504)65% (88/136)autotests.kcookiejar100% (1/1)100% (1/1)93% (165/177)70% (49/70)src100% (1/1)100% (1/1)89% (8/9)71% (10/14)src.core89% (108/121)89% (108/121)61% (9002/14676)52% (4540/8681)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets79% (30/38)79% (30/38)58% (5134/8808)46% (2326/5070)src.gui100% (8/8)100% (8/8)82% (699/856)63% (347/554)src.gui.systemd50% (2/4)50% (2/4)4% (7/173)1% (1/104)src.ioslaves.file100% (7/7)100% (7/7)54% (742/1370)39% (443/1128)src.ioslaves.file.kauth0% (0/2)0% (0/2)0% (0/179)0% (0/89)src.ioslaves.ftp100% (2/2)100% (2/2)47% (647/1363)37% (531/1420)src.ioslaves.help0% (0/5)0% (0/5)0% (0/248)0% (0/148)src.ioslaves.http88% (7/8)88% (7/8)42% (1784/4258)36% (1319/3644)src.ioslaves.http.kcookiejar40% (2/5)40% (2/5)47% (625/1323)56% (578/1037)src.ioslaves.remote100% (2/2)100% (2/2)25%
KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 701 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/701/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Thu, 15 Apr 2021 11:01:12 + Build duration: 4 min 39 sec and counting JUnit Tests Name: projectroot Failed: 0 test(s), Passed: 56 test(s), Skipped: 0 test(s), Total: 56 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
KDE CI: Frameworks » kconfig » kf5-qt5 WindowsMSVCQt5.15 - Build # 81 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.15/81/ Project: kf5-qt5 WindowsMSVCQt5.15 Date of build: Thu, 15 Apr 2021 10:12:55 + Build duration: 2 min 14 sec and counting JUnit Tests Name: projectroot Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 28 test(s)
KDE CI: Frameworks » kconfig » kf5-qt5 WindowsMSVCQt5.15 - Build # 80 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20WindowsMSVCQt5.15/80/ Project: kf5-qt5 WindowsMSVCQt5.15 Date of build: Thu, 15 Apr 2021 10:03:03 + Build duration: 9 min 41 sec and counting JUnit Tests Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfignokdehometestName: projectroot.autotests Failed: 0 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 28 test(s)
