D26652: Unbreak module imports for Python2

[A. Wilcox]

awilcox added a comment.


  Why should Python 2 continue to be supported, after its EOL on 2020-01-01?
  
  What cases would a user be running the latest KDE release, but still have a 
Python 2 interpreter present as their primary/only Python interpreter?

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D26652

To: kossebau, ochurlaud, cordlandwehr
Cc: awilcox, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D8256: Add _XOPEN_SOURCE to C definitions

[A. Wilcox]

awilcox added a comment.


  rindex was being used in kscreenlocker but that code was removed last year.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ngraham, 
bruns

D11011: Do not assume layout of msghdr and iovec structure

[A . Wilcox]

awilcox added a comment.


  That's fine with me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11011

To: chinmoyr, dfaure, awilcox
Cc: #frameworks, michaelh

D11011: Do not assume layout of msghdr and iovec structure

[A . Wilcox]

awilcox accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11011

To: chinmoyr, dfaure, awilcox
Cc: #frameworks, michaelh

D11011: Do not assume layout of msghdr and iovec structure

[A . Wilcox]

awilcox added a comment.


  I can confirm that this patch does fix the build on musl.  Thank you!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11011

To: chinmoyr, dfaure, awilcox
Cc: #frameworks, michaelh

D6709: Add support for sharing file descriptor between KIO slave and KAuth helper

[A . Wilcox]

awilcox reopened this revision.
awilcox added a comment.
This revision is now accepted and ready to land.


  BUG: 391367 :
  
  musl is strictly POSIX conformant 
,
 which means it uses int for msg_iovlen and socklen_t for msg_controllen in the 
msghdr struct.
  
  POSIX defines msghdr 
 as 
containing "at least" the standard members, not "only" the standard members.
  
  Since this code (non-conformantly) assumes the members and layout of msghdr 
in its ctor, it FTBFS on 64-bit musl platforms (including x86_64, ppc64, 
aarch64):
  
In file included from 
/usr/src/packages/user/kio/src/kio-5.43.0/src/ioslaves/file/fdreceiver.cpp:23:0:
/usr/src/packages/user/kio/src/kio-5.43.0/src/ioslaves/file/sharefd_p.h: In 
constructor 'FDMessageHeader::FDMessageHeader()':

/usr/src/packages/user/kio/src/kio-5.43.0/src/ioslaves/file/sharefd_p.h:78:37: 
error: invalid conversion from 'char (*)[24]' to 'int' [-fpermissive]
 , msg{nullptr, 0,  , 1,  _buf, sizeof cmsg_buf, 0}
 ^

/usr/src/packages/user/kio/src/kio-5.43.0/src/ioslaves/file/sharefd_p.h:78:55: 
error: invalid conversion from 'long unsigned int' to 'void*' [-fpermissive]
 , msg{nullptr, 0,  , 1,  _buf, sizeof cmsg_buf, 0}
   ^~~~

/usr/src/packages/user/kio/src/kio-5.43.0/src/ioslaves/file/sharefd_p.h:78:66: 
warning: missing initializer for member 'msghdr::__pad2' 
[-Wmissing-field-initializers]
 , msg{nullptr, 0,  , 1,  _buf, sizeof cmsg_buf, 0}
  ^

/usr/src/packages/user/kio/src/kio-5.43.0/src/ioslaves/file/sharefd_p.h:78:66: 
warning: missing initializer for member 'msghdr::msg_flags' 
[-Wmissing-field-initializers]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6709

To: chinmoyr, thiago, #frameworks, dfaure
Cc: awilcox, dfaure, davidedmundson, elvisangelaccio, shortstheory, michaelh

D8256: Add _XOPEN_SOURCE to C definitions

[A . Wilcox]

awilcox added a comment.


  Please do note that `_XOPEN_SOURCE` must be `600` and not `700` because some 
components of KDE still use `rindex` which is no longer supported in X/Open 7 
.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry
Cc: #frameworks, #build_system

D8256: Add _XOPEN_SOURCE to C definitions

[A . Wilcox]

awilcox created this revision.
awilcox added a reviewer: alexmerry.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  (This was reported on the KDE bug tracker as Bug 373175 
.  The summary of that bug 
follows.)
  
  When building on non-glibc Unix platforms, such as Solaris, NetBSD, and 
Linux/musl or Linux/uclibc, multiple components of KF5 fail to build.  This is 
because -std=iso9899:1990 is specified (for strict C90 compliance) but 
_XOPEN_SOURCE is not defined, so none of the POSIX interfaces are exported.  I 
have seen this reported in at least:
  
  - kinit
  - kscreenlocker
  - plasma-workspace
  
  The attached patch resolves this issue on all our build boxes; additionally, 
applying it to my glibc builder did not change the already working result.

TEST PLAN
  The entire Adélie Linux distribution's set of KDE packages has been built 
against extra-cmake-modules-5.38.0 with this patch applied.  The Plasma 5 
desktop and KDE software build, test, and run correctly (where applicable).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: awilcox, alexmerry
Cc: #frameworks, #build_system

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

[A . Wilcox]

awilcox updated this revision to Diff 20619.
awilcox added a comment.


  This diff was created with  `git diff`.

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8064?vs=20125=20619

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  src/start_kdeinit/CMakeLists.txt

To: awilcox, dfaure
Cc: graesslin, #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

[A . Wilcox]

awilcox created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  While packaging kinit 5.38.0 for Adélie, I ran in to the following error:
  
-- Installing: 
/usr/src/packages/user/kinit/pkg/kinit/usr/lib/libexec/kf5/start_kdeinit
Failed to set capabilities on file `/usr/lib/libexec/kf5/start_kdeinit' (No 
such file or directory)
usage: setcap [-q] [-v] (-r|-|)  [ ... (-r|-|) 
 ]

 Note  must be a regular (non-symlink) file.
  
  This was caused by a missing escape in the CMake instruction to run setcap.  
I have verified that this patch also applies cleanly to master.

TEST PLAN
  - Build with and without libcap, with and without `DESTDIR` set.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  kinit-5.38.0/src/start_kdeinit/CMakeLists.txt

To: awilcox
Cc: #frameworks

D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

[A. Wilcox]

awilcox updated this revision to Diff 15456.
awilcox added a comment.


  This is now a patch made with ```git format-patch``` against current master 
(https://phabricator.kde.org/R286:6a24cf9d5a2fd83a22ea74d502d24665dcd0b57c).  
Still passes on both Py2 and Py3.

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4377?vs=10780=15456

REVISION DETAIL
  https://phabricator.kde.org/D4377

AFFECTED FILES
  autotests/samplefiles/testexternalextractor/main.py
  autotests/samplefiles/testexternalwriter/main.py

To: awilcox, mgallien
Cc: #frameworks

[Differential] [Updated] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

[A. Wilcox]

awilcox updated the test plan for this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D4377

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: awilcox
Cc: #frameworks

[Differential] [Request, 10 lines] D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

[A. Wilcox]

awilcox created this revision.
awilcox set the repository for this revision to R286 KFileMetaData.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  KFileMetaData test scripts are usable in both deprecated Python 2, and new 
Python 3.  This removes 'python2' from the shebang and uses the regular 
'python' interpreter, thereby removing the requirement of Python 2 being on a 
system to be able to test KFileMetaData.
  
  Additionally, it removes unused imports.

TEST PLAN
  This patch was applied to:
  
  - 5.23
  - 5.26
  - 5.29
  
  It was tested on Linux kernel 4.4 using:
  
  - x86_64
  - x86_32
  - PowerPC
  
  It was tested on glibc and musl libc.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D4377

AFFECTED FILES
  kfilemetadata-5.23.0/autotests/samplefiles/testexternalextractor/main.py
  kfilemetadata-5.23.0/autotests/samplefiles/testexternalwriter/main.py

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: awilcox
Cc: #frameworks

[Differential] [Request, 14 lines] D4335: Fix endianness issues once and for all in Blowfish algorithm

[A. Wilcox]

awilcox created this revision.
awilcox set the repository for this revision to R311 KWallet.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Attempting to package KWallet 5.29.0 for PowerPC, I ran in to a test failure 
with the Blowfish algorithm.  This led me to bug 362805 
.  I have implemented the 
suggested fix from comment 17 there, with a small change; it is better to 
simply include  than .

TEST PLAN
  - Built on x86_64 computer with patch applied; opened existing wallet.
  - Built on PowerPC computer with patch applied; opened existing wallet.
  - Created new wallet on x86_64 computer, and opened it on PowerPC computer.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D4335

AFFECTED FILES
  kwallet-5.29.0/src/runtime/kwalletd/backend/blowfish.cc

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: awilcox
Cc: #frameworks